<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
This PR introduces the socket name support to kamailio cli just like [listen directive](https://www.kamailio.org/wikidocs/cookbooks/devel/core/#listen) does in the config file.
You can start kamailio using the `-l` argument to define listening sockets. This PR adds the `name=` part support to match the config file.
`kamailio -l test=udp:10.0.0.55:5061/1.1.1.1:5060`
Discussion about whether `-l **test=**udp:10.0.0.55:5061/1.1.1.1:5060` or `-l udp:10.0.0.55:5061/1.1.1.1:5060**=test**` can be found in
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3954
-- Commit Summary --
* main: Add support for naming socket in cli
-- File Changes --
M src/main.c (41)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3954.patchhttps://github.com/kamailio/kamailio/pull/3954.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3954
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3954(a)github.com>
Module: kamailio
Branch: master
Commit: c622429b1514f49d36519248f90b647f7b7b3144
URL: https://github.com/kamailio/kamailio/commit/c622429b1514f49d36519248f90b647…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2024-08-22T13:22:56+02:00
tm: align comments
---
Modified: src/modules/tm/t_fwd.c
---
Diff: https://github.com/kamailio/kamailio/commit/c622429b1514f49d36519248f90b647…
Patch: https://github.com/kamailio/kamailio/commit/c622429b1514f49d36519248f90b647…
---
diff --git a/src/modules/tm/t_fwd.c b/src/modules/tm/t_fwd.c
index b669f1d7762..c9f0bc2cab4 100644
--- a/src/modules/tm/t_fwd.c
+++ b/src/modules/tm/t_fwd.c
@@ -1348,9 +1348,9 @@ void e2e_cancel(struct sip_msg *cancel_msg, struct cell *t_cancel,
for(i = 0; i < t_invite->nr_of_outgoings; i++) {
if(cancel_bm & (1 << i)) {
/* it's safe to get the reply lock since e2e_cancel is
- * called with the cancel as the "current" transaction so
- * at most t_cancel REPLY_LOCK is held in this process =>
- * no deadlock possibility */
+ * called with the cancel as the "current" transaction so
+ * at most t_cancel REPLY_LOCK is held in this process =>
+ * no deadlock possibility */
ret = cancel_branch(t_invite, i, reason,
cfg_get(tm, tm_cfg, cancel_b_flags)
| ((t_invite->uac[i].request.buffer == NULL)
@@ -1391,8 +1391,8 @@ void e2e_cancel(struct sip_msg *cancel_msg, struct cell *t_cancel,
if(t_invite->uac[i].last_received >= 100) {
/* Provisional reply received on this branch, send CANCEL */
/* we do need to stop the retr. timers if the request is not
- * an invite and since the stop_rb_retr() cost is lower than
- * the invite check we do it always --andrei */
+ * an invite and since the stop_rb_retr() cost is lower than
+ * the invite check we do it always --andrei */
stop_rb_retr(&t_invite->uac[i].request);
if(SEND_BUFFER(&t_cancel->uac[i].request) == -1) {
LM_ERR("e2e cancel - send failed\n");
@@ -1409,12 +1409,12 @@ void e2e_cancel(struct sip_msg *cancel_msg, struct cell *t_cancel,
&t_cancel->uac[i].request);
} else {
/* No provisional response received, stop
- * retransmission timers */
+ * retransmission timers */
if(!(cfg_get(tm, tm_cfg, cancel_b_flags)
& F_CANCEL_B_FORCE_RETR))
stop_rb_retr(&t_invite->uac[i].request);
/* no need to stop fr, it will be stopped by relay_reply
- * put_on_wait -- andrei */
+ * put_on_wait -- andrei */
/* Generate faked reply */
if(cfg_get(tm, tm_cfg, cancel_b_flags)
& F_CANCEL_B_FAKE_REPLY) {