sr-dev July 2024

sr-dev@lists.kamailio.org

16 participants
208 discussions

git:master:70563ca0: dialplan: remove pcre2_free() warning

by Victor Seva

Module: kamailio Branch: master Commit: 70563ca0629a8de5aa5427b003f441e6c3a40c6a URL: https://github.com/kamailio/kamailio/commit/70563ca0629a8de5aa5427b003f441e… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-07-18T13:41:16+02:00 dialplan: remove pcre2_free() warning related to #3851 --- Modified: src/modules/dialplan/dp_db.c --- Diff: https://github.com/kamailio/kamailio/commit/70563ca0629a8de5aa5427b003f441e… Patch: https://github.com/kamailio/kamailio/commit/70563ca0629a8de5aa5427b003f441e… --- diff --git a/src/modules/dialplan/dp_db.c b/src/modules/dialplan/dp_db.c index 857a2e43e75..64d2a4f3b12 100644 --- a/src/modules/dialplan/dp_db.c +++ b/src/modules/dialplan/dp_db.c @@ -203,8 +203,10 @@ static void *pcre2_malloc(size_t size, void *ext) static void pcre2_free(void *ptr, void *ext) { - shm_free(ptr); - ptr = NULL; + if(ptr) { + shm_free(ptr); + ptr = NULL; + } } int init_data(void)

2 months, 2 weeks

git:master:310b6310: lcr: remove pcre2_free() warning

by Victor Seva

Module: kamailio Branch: master Commit: 310b631007082f553117d126b6b9bd915be596ac URL: https://github.com/kamailio/kamailio/commit/310b631007082f553117d126b6b9bd9… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-07-18T13:41:15+02:00 lcr: remove pcre2_free() warning related to #3851 --- Modified: src/modules/lcr/lcr_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/310b631007082f553117d126b6b9bd9… Patch: https://github.com/kamailio/kamailio/commit/310b631007082f553117d126b6b9bd9… --- diff --git a/src/modules/lcr/lcr_mod.c b/src/modules/lcr/lcr_mod.c index 6cad2830fb6..f53de3b3668 100644 --- a/src/modules/lcr/lcr_mod.c +++ b/src/modules/lcr/lcr_mod.c @@ -433,8 +433,10 @@ static void *pcre2_malloc(size_t size, void *ext) static void pcre2_free(void *ptr, void *ext) { - shm_free(ptr); - ptr = NULL; + if(ptr) { + shm_free(ptr); + ptr = NULL; + } } /*

2 months, 2 weeks

git:master:b86030cf: regex: remove pcre2_free() warning

by Victor Seva

Module: kamailio Branch: master Commit: b86030cfbd66ba95f33f312595edae29e2b5cde0 URL: https://github.com/kamailio/kamailio/commit/b86030cfbd66ba95f33f312595edae2… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-07-18T13:41:15+02:00 regex: remove pcre2_free() warning related to #3851 --- Modified: src/modules/regex/regex_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/b86030cfbd66ba95f33f312595edae2… Patch: https://github.com/kamailio/kamailio/commit/b86030cfbd66ba95f33f312595edae2… --- diff --git a/src/modules/regex/regex_mod.c b/src/modules/regex/regex_mod.c index 52ed60b295c..f4e93e48a3e 100644 --- a/src/modules/regex/regex_mod.c +++ b/src/modules/regex/regex_mod.c @@ -170,8 +170,10 @@ static void *pcre2_malloc(size_t size, void *ext) static void pcre2_free(void *ptr, void *ext) { - shm_free(ptr); - ptr = NULL; + if(ptr) { + shm_free(ptr); + ptr = NULL; + } } /*! \brief

2 months, 2 weeks

[kamailio/kamailio] tcpops: fix memory leak in $tcp(conid) (PR #3924)

by Dennis

2 months, 2 weeks

git:master:acf50d86: tcpops: fix memory leak in $tcp(conid)

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: acf50d86b502af36e3635d61745feaa5c577231d URL: https://github.com/kamailio/kamailio/commit/acf50d86b502af36e3635d61745feaa… Author: Dennis Yurasov <dennis-y(a)yandex-team.ru> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-18T13:31:26+02:00 tcpops: fix memory leak in $tcp(conid) - reference counter to tcp session not decremented, so shm for session never free --- Modified: src/modules/tcpops/tcpops_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/acf50d86b502af36e3635d61745feaa… Patch: https://github.com/kamailio/kamailio/commit/acf50d86b502af36e3635d61745feaa… --- diff --git a/src/modules/tcpops/tcpops_mod.c b/src/modules/tcpops/tcpops_mod.c index 6b648230894..a89a18992aa 100644 --- a/src/modules/tcpops/tcpops_mod.c +++ b/src/modules/tcpops/tcpops_mod.c @@ -811,6 +811,9 @@ static int pv_get_tcp(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) tcpconn_put(con); return pv_get_sintval(msg, param, res, ival); default: /* conid */ + if(con) { + tcpconn_put(con); + } return pv_get_sintval(msg, param, res, msg->rcv.proto_reserved1); } }

2 months, 2 weeks

git:master:84ea36b4: core: remove unnecessary check after using the structure

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 84ea36b4b79c07c4fc0a8c9e119184433353764e URL: https://github.com/kamailio/kamailio/commit/84ea36b4b79c07c4fc0a8c9e1191844… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-18T12:29:05+02:00 core: remove unnecessary check after using the structure --- Modified: src/core/msg_translator.c --- Diff: https://github.com/kamailio/kamailio/commit/84ea36b4b79c07c4fc0a8c9e1191844… Patch: https://github.com/kamailio/kamailio/commit/84ea36b4b79c07c4fc0a8c9e1191844… --- diff --git a/src/core/msg_translator.c b/src/core/msg_translator.c index ab02fb7c47c..f26abd2e79d 100644 --- a/src/core/msg_translator.c +++ b/src/core/msg_translator.c @@ -2384,7 +2384,7 @@ char *generate_res_buf_from_sip_res( } /* test and add xavp via reply params */ - if(msg && msg->via2 && (msg->msg_flags & FL_ADD_XAVP_VIA_REPLY_PARAMS) + if(msg->via2 && (msg->msg_flags & FL_ADD_XAVP_VIA_REPLY_PARAMS) && _ksr_xavp_via_reply_params.len > 0) { xparams.s = pv_get_buffer(); xparams.len = xavp_serialize_fields_style(&_ksr_xavp_via_reply_params,

2 months, 2 weeks

git:master:15b2a546: core: set digit 0 in the md5 buffer in case of error inside char_msg_val()

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 15b2a5467f11e009ae4efad1ee29af860326095f URL: https://github.com/kamailio/kamailio/commit/15b2a5467f11e009ae4efad1ee29af8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-18T12:17:10+02:00 core: set digit 0 in the md5 buffer in case of error inside char_msg_val() --- Modified: src/core/char_msg_val.h --- Diff: https://github.com/kamailio/kamailio/commit/15b2a5467f11e009ae4efad1ee29af8… Patch: https://github.com/kamailio/kamailio/commit/15b2a5467f11e009ae4efad1ee29af8… --- diff --git a/src/core/char_msg_val.h b/src/core/char_msg_val.h index b3d7e4a1bea..bcdea56b85e 100644 --- a/src/core/char_msg_val.h +++ b/src/core/char_msg_val.h @@ -41,8 +41,11 @@ inline static int char_msg_val(struct sip_msg *msg, char *cv) str sempty = str_init(""); if(unlikely(!check_transaction_quadruple(msg))) { - LM_ERR("can't calculate char_value due to a parsing error\n"); - memset(cv, '0', MD5_LEN); + int i; + for(i = 0; i < MD5_LEN; i++) { + cv[i] = '0'; + } + LM_ERR("cannot calculate char_value due to a parsing error\n"); return 0; } /* to body is automatically parsed (via check_transactionquadruple /

2 months, 2 weeks

git:master:a471d34d: core: init res inside select_cfg_var()

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: a471d34d6162387a1427f5d0c5b3c6079a2b0bdc URL: https://github.com/kamailio/kamailio/commit/a471d34d6162387a1427f5d0c5b3c60… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-07-18T12:00:47+02:00 core: init res inside select_cfg_var() --- Modified: src/core/cfg/cfg_select.c --- Diff: https://github.com/kamailio/kamailio/commit/a471d34d6162387a1427f5d0c5b3c60… Patch: https://github.com/kamailio/kamailio/commit/a471d34d6162387a1427f5d0c5b3c60… --- diff --git a/src/core/cfg/cfg_select.c b/src/core/cfg/cfg_select.c index f948dd4ab4c..f3b2d681d3e 100644 --- a/src/core/cfg/cfg_select.c +++ b/src/core/cfg/cfg_select.c @@ -147,6 +147,9 @@ int select_cfg_var(str *res, select_t *s, struct sip_msg *msg) int i; static char buf[INT2STR_MAX_LEN]; + res->s = 0; + res->len = 0; + if(msg == NULL) { /* fixup call */ @@ -228,12 +231,7 @@ int select_cfg_var(str *res, select_t *s, struct sip_msg *msg) break; case CFG_VAR_STR: - if(p) { - memcpy(res, p, sizeof(str)); - } else { - res->s = 0; - res->len = 0; - } + memcpy(res, p, sizeof(str)); break; default:

2 months, 2 weeks

[kamailio/kamailio] ims_qos_npn: forked module from ims_qos, for better rx support (PR #3921)

by Dragos Vingarzan

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  The `ims_qos` module had a few limitations. This fork of that module adds: - AAR for the registration (signaling path monitoring) - subsequent AARs in calls - support for STR - extra event_routes on Rx authorization session events - extra AVPs decoding and use The dependency and use of the `ims_dialog` was removed. We think that the respective module has fallen behind `dialog` (although it should've replaced it? don't know...). Cleaning/upgrading that module too might be too much effort. Since these changes might be breaking things for other folks using IMS, we are pushing these as an alternative module. We hope that we'll find though consensus in the future and either remove or merge with the older `ims_qos` module. Same would be valid for `ims_dialog` and `dialog`, yet those also might need some upgrades. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3921 -- Commit Summary -- * ims_qos_npn: imported modified module * src: added ims_qos_npn to Makefile.groups -- File Changes -- M src/Makefile.groups (2) A src/modules/ims_qos_npn/Makefile (19) A src/modules/ims_qos_npn/README (781) A src/modules/ims_qos_npn/cdpeventprocessor.c (382) A src/modules/ims_qos_npn/cdpeventprocessor.h (87) A src/modules/ims_qos_npn/doc/Makefile (4) A src/modules/ims_qos_npn/doc/ims_qos.xml (113) A src/modules/ims_qos_npn/doc/ims_qos_admin.xml (882) A src/modules/ims_qos_npn/ims_qos_mod.c (2173) A src/modules/ims_qos_npn/ims_qos_mod.h (85) A src/modules/ims_qos_npn/ims_qos_stats.c (156) A src/modules/ims_qos_npn/ims_qos_stats.h (38) A src/modules/ims_qos_npn/rx_aar.c (1296) A src/modules/ims_qos_npn/rx_aar.h (131) A src/modules/ims_qos_npn/rx_asr.c (124) A src/modules/ims_qos_npn/rx_asr.h (59) A src/modules/ims_qos_npn/rx_authdata.c (494) A src/modules/ims_qos_npn/rx_authdata.h (125) A src/modules/ims_qos_npn/rx_avp.c (2144) A src/modules/ims_qos_npn/rx_avp.h (118) A src/modules/ims_qos_npn/rx_rar.c (160) A src/modules/ims_qos_npn/rx_rar.h (34) A src/modules/ims_qos_npn/rx_str.c (184) A src/modules/ims_qos_npn/rx_str.h (61) A src/modules/ims_qos_npn/sem.h (90) A src/modules/ims_qos_npn/stats.c (79) A src/modules/ims_qos_npn/stats.h (61) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3921.patch https://github.com/kamailio/kamailio/pull/3921.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3921 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3921(a)github.com>

2 months, 2 weeks

[kamailio/kamailio] siprepo: fix int params and wrong copy data in siprepo_msg_async_pull (PR #3919)

by emvondo

2 months, 2 weeks

← Newer
1
...
7
8
9
10
11
12
13
...
21
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2024