sr-dev March 2024

sr-dev@lists.kamailio.org

14 participants
233 discussions

git:master:9a94930a: smsops: short reference section about variables

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 9a94930ae1168d5df79e3dc1414841cdf23a2eba URL: https://github.com/kamailio/kamailio/commit/9a94930ae1168d5df79e3dc1414841c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-03-28T08:31:05+01:00 smsops: short reference section about variables --- Modified: src/modules/smsops/doc/smsops_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/9a94930ae1168d5df79e3dc1414841c… Patch: https://github.com/kamailio/kamailio/commit/9a94930ae1168d5df79e3dc1414841c… --- diff --git a/src/modules/smsops/doc/smsops_admin.xml b/src/modules/smsops/doc/smsops_admin.xml index fa19ebfc79c..da95e37c012 100644 --- a/src/modules/smsops/doc/smsops_admin.xml +++ b/src/modules/smsops/doc/smsops_admin.xml @@ -95,5 +95,19 @@ smsdump(); </section> </section> + <section> + <title>Variables</title> + <para>Several variables are exported by the module to access the + attributes of the SMS.</para> + <itemizedlist> + <listitem> + <para><emphasis>$smsack</emphasis></para> + <para><emphasis>$smsbody</emphasis></para> + <para><emphasis>$rpdata(key)</emphasis></para> + <para><emphasis>$tpdu(key)</emphasis></para> + </listitem> + </itemizedlist> + </section> + </chapter>

1 month, 3 weeks

[kamailio/kamailio] Kamailio 5.7 TLS fail to compile (Issue #3796)

by iliesh

### Description Unable to upgrade Kamailio 5.7 on CentOS7 Error: ``` tls_mod.c: In function ‘fork_child’: tls_mod.c:348:2: error: ‘for’ loop initial declarations are only allowed in C99 mode for(int k = 0; k < 16; k++) { ^ tls_mod.c:348:2: note: use option -std=c99 or -std=gnu99 to compile your code make[2]: *** [tls_mod.o] Error 1 make[1]: *** [modules] Error 1 ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` Current installed version: ``` version: kamailio 5.7.4 (x86_64/linux) 2e6e87 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3796 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3796(a)github.com>

1 month, 3 weeks

[kamailio/kamailio] Fix 'for' loop initial declarations error (PR #3797)

by Xenofon Karamanos

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3796 (replace XXXX with an open issue number) #### Description  This PR fixes the compiles error regarding initial declarations in `for` loops You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3797 -- Commit Summary -- * tls: Fix ‘for’ loop initial declarations error * file_out: FIx ‘for’ loop initial declarations error -- File Changes -- M src/modules/file_out/file_out.c (11) M src/modules/tls/tls_mod.c (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3797.patch https://github.com/kamailio/kamailio/pull/3797.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3797 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3797(a)github.com>

1 month, 3 weeks

git:master:ae04ccac: file_out: FIx âforâ loop initial declarations error

by Xenofon Karamanos

Module: kamailio Branch: master Commit: ae04ccac92225a1e7b573a28ded555789e8604cd URL: https://github.com/kamailio/kamailio/commit/ae04ccac92225a1e7b573a28ded5557… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2024-03-27T18:08:20+02:00 file_out: FIx ��for�� loop initial declarations error --- Modified: src/modules/file_out/file_out.c --- Diff: https://github.com/kamailio/kamailio/commit/ae04ccac92225a1e7b573a28ded5557… Patch: https://github.com/kamailio/kamailio/commit/ae04ccac92225a1e7b573a28ded5557… --- diff --git a/src/modules/file_out/file_out.c b/src/modules/file_out/file_out.c index 886f01f944f..a13d3531dde 100644 --- a/src/modules/file_out/file_out.c +++ b/src/modules/file_out/file_out.c @@ -100,6 +100,7 @@ struct module_exports exports = { static int mod_init(void) { + int i = 0; LM_DBG("initializing\n"); LM_DBG("base_folder = %.*s\n", fo_base_folder.len, fo_base_folder.s); @@ -121,7 +122,7 @@ static int mod_init(void) *fo_number_of_files = fo_count_assigned_files(); /* Fixup the prefix */ - for(int i = 0; i < *fo_number_of_files; i++) { + for(i = 0; i < *fo_number_of_files; i++) { str s; s.s = fo_files[i].fo_prefix.s; s.len = fo_files[i].fo_prefix.len; @@ -139,7 +140,7 @@ static int mod_init(void) } /* Initialize per process vars */ - for(int i = 0; i < *fo_number_of_files; i++) { + for(i = 0; i < *fo_number_of_files; i++) { fo_files[i].fo_stored_timestamp = time(NULL); } @@ -156,6 +157,7 @@ static int mod_init(void) static int child_init(int rank) { int pid; + int i = 0; if(rank != PROC_MAIN) { return 0; } @@ -172,7 +174,7 @@ static int child_init(int rank) return -1; /* Initialize and open files */ - for(int i = 0; i < *fo_number_of_files; i++) { + for(i = 0; i < *fo_number_of_files; i++) { fo_init_file(i); } @@ -194,7 +196,8 @@ static int child_init(int rank) static void destroy(void) { int result = 0; - for(int i = 0; i < *fo_number_of_files; i++) { + int i = 0; + for(i = 0; i < *fo_number_of_files; i++) { result = fo_file_properties_destroy(&fo_files[i]); if(result < 0) { LM_ERR("Failed to destroy file properties\n");

1 month, 3 weeks

git:master:9f2abc69: tls: Fix âforâ loop initial declarations error

by Xenofon Karamanos

Module: kamailio Branch: master Commit: 9f2abc69e27c4b3246628138ec81fced81d7bc7a URL: https://github.com/kamailio/kamailio/commit/9f2abc69e27c4b3246628138ec81fce… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2024-03-27T18:08:20+02:00 tls: Fix ��for�� loop initial declarations error --- Modified: src/modules/tls/tls_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/9f2abc69e27c4b3246628138ec81fce… Patch: https://github.com/kamailio/kamailio/commit/9f2abc69e27c4b3246628138ec81fce… --- diff --git a/src/modules/tls/tls_mod.c b/src/modules/tls/tls_mod.c index b4a2afb7818..83b86d99d58 100644 --- a/src/modules/tls/tls_mod.c +++ b/src/modules/tls/tls_mod.c @@ -345,7 +345,8 @@ static tls_domains_cfg_t* tls_use_modparams(void) */ static void fork_child(void) { - for(int k = 0; k < 16; k++) { + int k = 0; + for(k = 0; k < 16; k++) { if(pthread_getspecific(k) != 0) pthread_setspecific(k, 0x0); }

1 month, 3 weeks

[kamailio/kamailio] topos module breaks UPDATE (Issue #3437)

by Guybrush T.

### Description Kamailio v5.5.6 with topos module and postgres DB. UAC (A) -> Kamailio Registrar (B) -> Kamailio PSTN GW (C) -> PSTN (D) Call goes from A to D, PSTN sends UPDATE, UPDATE is routed from C to A instead to B and then to A. #### Reproduction Caller calls callee and receives an UPDATE from callee. In my case it was when the call was routed to voicemail. #### Log Messages ``` Kamailio takes the wrong route in UPDATE (upstream) case. May 3 15:23:12 sipproxy /usr/sbin/kamailio[263013]: DEBUG: topos [tps_msg.c:882]: tps_request_received(): r-uri updated to: [sip:1234@<UAC-IP>;uniq=B0EB9A84A278626DA07219E2AE01C] May 3 15:23:12 sipproxy /usr/sbin/kamailio[263013]: DEBUG: topos [tps_msg.c:187]: tps_add_headers(): adding to headers(0) - [Route: sip:<<KamailioPSTNgwIP>>;lr=on;ftag=9945501E2B94B883;did=1fc.42f;nat=yes#015#012] May 3 15:23:12 sipproxy /usr/sbin/kamailio[263013]: DEBUG: topos [tps_msg.c:187]: tps_add_headers(): adding to headers(0) - [P-SR-XUID: atpsh-64527b0a-40362-1#015#012] The right one would be the x_rr (a_rr), but it takes only the s_rr: May 3 15:23:12 sipproxy /usr/sbin/kamailio[263013]: DEBUG: db_postgres [km_res.c:234]: db_postgres_convert_rows(): PQgetvalue(0x7fcb4893db50,0,7)=[sip:<KamailioRegistrarIP>;lr=on;ftag=9945501E2B94B883;did=1fc.7b92] May 3 15:23:12 sipproxy /usr/sbin/kamailio[263013]: DEBUG: db_postgres [km_res.c:242]: db_postgres_convert_rows(): [0][7] Column[x_rr]=[sip:<KamailioRegistrarIP>;lr=on;ftag=9945501E2B94B883;did=1fc.7b92] May 3 15:23:12 sipproxy /usr/sbin/kamailio[263013]: DEBUG: db_postgres [km_res.c:234]: db_postgres_convert_rows(): PQgetvalue(0x7fcb4893db50,0,8)=[sip:<PSTNgw>:5060;transport=udp;lr;Hpt=8ef8_116;CxtId=3;TRC=ffffffff-ffffffff;X-HwB2bUaCookie=18614] May 3 15:23:12 sipproxy /usr/sbin/kamailio[263013]: DEBUG: db_postgres [km_res.c:242]: db_postgres_convert_rows(): [0][8] Column[y_rr]=[sip:<PSTNgw>:5060;transport=udp;lr;Hpt=8ef8_116;CxtId=3;TRC=ffffffff-ffffffff;X-HwB2bUaCookie=18614] May 3 15:23:12 sipproxy /usr/sbin/kamailio[263013]: DEBUG: db_postgres [km_res.c:234]: db_postgres_convert_rows(): PQgetvalue(0x7fcb4893db50,0,9)=[sip:<<KamailioPSTNgwIP>>;lr=on;ftag=9945501E2B94B883;did=1fc.42f;nat=yes] May 3 15:23:12 sipproxy /usr/sbin/kamailio[263013]: DEBUG: db_postgres [km_res.c:242]: db_postgres_convert_rows(): [0][9] Column[s_rr]=[sip:<<KamailioPSTNgwIP>>;lr=on;ftag=9945501E2B94B883;did=1fc.42f;nat=yes] May 3 15:23:12 sipproxy /usr/sbin/kamailio[263019]: DEBUG: db_postgres [km_res.c:242]: db_postgres_convert_rows(): [0][10] Column[a_rr]=[sip:<KamailioRegistrarIP>;lr=on;ftag=9945501E2B94B883;did=1fc.7b92] May 3 15:23:12 sipproxy /usr/sbin/kamailio[263019]: DEBUG: db_postgres [km_res.c:234]: db_postgres_convert_rows(): PQgetvalue(0x7fcb4893dbd8,0,11)=[] ``` ### Possible Solutions Respect Route headers for UPDATE messages. ### Additional Information Current running kamailio 5.5.6 but tried also latest 5.6.4 with same behavior. ``` version: kamailio 5.5.6 (x86_64/linux) 72dbb0 flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 72dbb0 compiled on 05:48:21 Apr 27 2023 with gcc 11.3.0 ``` * **Operating System**: ``` Distributor ID: Ubuntu Description: Ubuntu 22.04.2 LTS Release: 22.04 Codename: jammy Linux sipproxy 5.15.0-70-generic #77-Ubuntu SMP Tue Mar 21 14:02:37 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux ``` Possibly related bug: https://github.com/kamailio/kamailio/issues/3090 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3437 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3437(a)github.com>

1 month, 3 weeks

git:master:4137a8c6: pkg/kamailio: packaged pvtpl module into RPM

by Sergey Safarov

Module: kamailio Branch: master Commit: 4137a8c63a03a316a0fa0f37d518a09e68273309 URL: https://github.com/kamailio/kamailio/commit/4137a8c63a03a316a0fa0f37d518a09… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2024-03-27T09:57:29+02:00 pkg/kamailio: packaged pvtpl module into RPM --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/4137a8c63a03a316a0fa0f37d518a09… Patch: https://github.com/kamailio/kamailio/commit/4137a8c63a03a316a0fa0f37d518a09… --- diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index 8bbe77b63dd..6d79bb8ec9f 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -1585,6 +1585,7 @@ fi %doc %{_docdir}/kamailio/modules/README.print_lib %doc %{_docdir}/kamailio/modules/README.pv %doc %{_docdir}/kamailio/modules/README.pv_headers +%doc %{_docdir}/kamailio/modules/README.pvtpl %doc %{_docdir}/kamailio/modules/README.pua_rpc %doc %{_docdir}/kamailio/modules/README.qos %doc %{_docdir}/kamailio/modules/README.ratelimit @@ -1750,6 +1751,7 @@ fi %{_libdir}/kamailio/modules/pua_rpc.so %{_libdir}/kamailio/modules/pv.so %{_libdir}/kamailio/modules/pv_headers.so +%{_libdir}/kamailio/modules/pvtpl.so %{_libdir}/kamailio/modules/qos.so %{_libdir}/kamailio/modules/ratelimit.so %{_libdir}/kamailio/modules/registrar.so

1 month, 3 weeks

git:master:9848d43c: smsops: reformat module exports structures

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 9848d43cb367d6901a0b8c727759feb8a8fad930 URL: https://github.com/kamailio/kamailio/commit/9848d43cb367d6901a0b8c727759feb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-03-26T19:17:23+01:00 smsops: reformat module exports structures --- Modified: src/modules/smsops/smsops.c --- Diff: https://github.com/kamailio/kamailio/commit/9848d43cb367d6901a0b8c727759feb… Patch: https://github.com/kamailio/kamailio/commit/9848d43cb367d6901a0b8c727759feb… --- diff --git a/src/modules/smsops/smsops.c b/src/modules/smsops/smsops.c index 3e2cb88bc58..d8354af2319 100644 --- a/src/modules/smsops/smsops.c +++ b/src/modules/smsops/smsops.c @@ -30,31 +30,36 @@ MODULE_VERSION -static pv_export_t mod_pvs[] = {{{"smsack", sizeof("smsack") - 1}, PVT_OTHER, - pv_sms_ack, 0, 0, 0, 0, 0}, - {{"rpdata", sizeof("rpdata") - 1}, PVT_OTHER, pv_get_sms, pv_set_sms, - pv_parse_rpdata_name, 0, 0, 0}, - {{"tpdu", sizeof("tpdu") - 1}, PVT_OTHER, pv_get_sms, pv_set_sms, +/* clang-format off */ +static pv_export_t mod_pvs[] = { + {{"smsack", sizeof("smsack") - 1}, PVT_OTHER, pv_sms_ack, 0, 0, 0, 0, 0}, + {{"rpdata", sizeof("rpdata") - 1}, PVT_OTHER, pv_get_sms, pv_set_sms, + pv_parse_rpdata_name, 0, 0, 0}, + {{"tpdu", sizeof("tpdu") - 1}, PVT_OTHER, pv_get_sms, pv_set_sms, pv_parse_tpdu_name, 0, 0, 0}, - {{"smsbody", sizeof("smsbody") - 1}, PVT_OTHER, pv_sms_body, 0, 0, 0, 0, - 0}, - {{0, 0}, 0, 0, 0, 0, 0, 0, 0}}; + {{"smsbody", sizeof("smsbody") - 1}, PVT_OTHER, pv_sms_body, 0, 0, 0, 0, 0}, + + {{0, 0}, 0, 0, 0, 0, 0, 0, 0} +}; static cmd_export_t cmds[] = { - {"smsdump", (cmd_function)smsdump, 0, 0, 0, REQUEST_ROUTE}, - {"isRPDATA", (cmd_function)isRPDATA, 0, 0, 0, REQUEST_ROUTE}, - {0, 0, 0, 0, 0, 0}}; + {"smsdump", (cmd_function)smsdump, 0, 0, 0, REQUEST_ROUTE}, + {"isRPDATA", (cmd_function)isRPDATA, 0, 0, 0, REQUEST_ROUTE}, + + {0, 0, 0, 0, 0, 0} +}; /** module exports */ struct module_exports exports = { - "smsops", /* module name */ - DEFAULT_DLFLAGS, /* dlopen flags */ - cmds, /* exported functions */ - 0, /* exported parameters */ - 0, /* exported rpc functions */ - mod_pvs, /* exported pseudo-variables */ - 0, /* response handling function*/ - 0, /* module init function */ - 0, /* per-child init function */ - 0 /* module destroy function */ + "smsops", /* module name */ + DEFAULT_DLFLAGS, /* dlopen flags */ + cmds, /* exported functions */ + 0, /* exported parameters */ + 0, /* exported rpc functions */ + mod_pvs, /* exported pseudo-variables */ + 0, /* response handling function*/ + 0, /* module init function */ + 0, /* per-child init function */ + 0 /* module destroy function */ }; +/* clang-format on */

1 month, 3 weeks

RFC: move app_lua_sr to kamailio-archive

by Victor Seva

Hi, I would like to move app_lua_sr to kamailio-archive but I would like to hear if anyone out there has a solid reason not to do it. Since we have app_lua as KEMI for a long time I think is time to retire the old remains of app_lua Cheers -- ----------------------------------------------------------------- | ,''`. Victor Seva | | : :' : linuxmaniac(a)torreviejawireless.org | | `. `' PGP: 8F19 CADC D42A 42D4 5563 730C 51A0 9B18 CF5A 5068 | | `- Debian Developer | -----------------------------------------------------------------

1 month, 3 weeks

git:5.8:3fac5afc: file_out: Cast to correct type of str

by Xenofon Karamanos

Module: kamailio Branch: 5.8 Commit: 3fac5afc42a606391d6a7c0337ef5e4e136d6b80 URL: https://github.com/kamailio/kamailio/commit/3fac5afc42a606391d6a7c0337ef5e4… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2024-03-26T09:57:49Z file_out: Cast to correct type of str (cherry picked from commit 4ada818099b5b7cb7deff1b1ce93b5aacaa1b84e) --- Modified: src/modules/file_out/file_out.c --- Diff: https://github.com/kamailio/kamailio/commit/3fac5afc42a606391d6a7c0337ef5e4… Patch: https://github.com/kamailio/kamailio/commit/3fac5afc42a606391d6a7c0337ef5e4… --- diff --git a/src/modules/file_out/file_out.c b/src/modules/file_out/file_out.c index 7e035f13359..886f01f944f 100644 --- a/src/modules/file_out/file_out.c +++ b/src/modules/file_out/file_out.c @@ -344,7 +344,7 @@ static int fo_add_filename(modparam_t type, void *val) LM_ERR("modparam value is null\n"); return -1; } - if(strlen((char *)val) == 0) { + if(strlen(((str *)val)->s) == 0) { LM_ERR("modparam value is empty\n"); return -1; }

1 month, 3 weeks

← Newer
1
2
3
4
5
6
7
8
...
24
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2024