sr-dev December 2024

sr-dev@lists.kamailio.org

17 participants
313 discussions

git:master:909e659d: http_async_client: fixed crash on curl callback

by Federico Cabiddu

Module: kamailio Branch: master Commit: 909e659dc33942a92e54bed37ee1387f121c63e6 URL: https://github.com/kamailio/kamailio/commit/909e659dc33942a92e54bed37ee1387… Author: Nikolay Ivanuschak <ivanuschak.nikolay(a)gmail.com> Committer: Federico Cabiddu <federico.cabiddu(a)gmail.com> Date: 2024-12-10T09:25:37+01:00 http_async_client: fixed crash on curl callback --- Modified: src/modules/http_async_client/http_multi.c --- Diff: https://github.com/kamailio/kamailio/commit/909e659dc33942a92e54bed37ee1387… Patch: https://github.com/kamailio/kamailio/commit/909e659dc33942a92e54bed37ee1387… --- diff --git a/src/modules/http_async_client/http_multi.c b/src/modules/http_async_client/http_multi.c index daceb932ec9..30ae016d720 100644 --- a/src/modules/http_async_client/http_multi.c +++ b/src/modules/http_async_client/http_multi.c @@ -157,10 +157,12 @@ void event_cb(int fd, short kind, void *userp) /* CURLMOPT_SOCKETFUNCTION */ int sock_cb(CURL *e, curl_socket_t s, int what, void *cbp, void *sockp) { + struct http_m_cell *cell; struct http_m_global *g = (struct http_m_global *)cbp; - struct http_m_cell *cell = (struct http_m_cell *)sockp; const char *whatstr[] = {"none", "IN", "OUT", "INOUT", "REMOVE"}; + cell = http_m_cell_lookup(e); + LM_DBG("socket callback: s=%d e=%p what=%s\n", s, e, whatstr[what]); if(what == CURL_POLL_REMOVE) { /* if cell is NULL the handle has been removed by the event callback for timeout */

1 week, 6 days

[kamailio/kamailio] github: [skip ci]: bump threeal/cmake-action from 2.0.0 to 2.1.0 (PR #4062)

by dependabot[bot]

Bumps [threeal/cmake-action](https://github.com/threeal/cmake-action) from 2.0.0 to 2.1.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/threeal/cmake-action/releases">threea… releases</a>.</em></p> <blockquote> <h2>Version 2.1.0</h2> <h2>What's Changed</h2> <ul> <li>Added support for specifying quotations for inputs with multiple values.</li> <li>Reduced bundled action script size by removing bloated dependencies.</li> <li>Enhanced development configurations and CI workflows.</li> <li>Updated development dependencies.</li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/threeal/cmake-action/compare/v2...v2.1.0&quot… </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/threeal/cmake-action/commit/725d1314ccf9ea922… chore: bump prettier from 3.4.1 to 3.4.2 (<a href="https://redirect.github.com/threeal/cmake-action/issues/543&quot… <li><a href="https://github.com/threeal/cmake-action/commit/6954eda1e8b7fec84… chore: bump typescript-eslint from 8.16.0 to 8.17.0 (<a href="https://redirect.github.com/threeal/cmake-action/issues/542&quot… <li><a href="https://github.com/threeal/cmake-action/commit/9b2633db99477647e… chore: bump <code>@eslint/js</code> from 9.15.0 to 9.16.0 (<a href="https://redirect.github.com/threeal/cmake-action/issues/541&quot… <li><a href="https://github.com/threeal/cmake-action/commit/d08d2651e1a4410b6… chore: bump eslint from 9.15.0 to 9.16.0 (<a href="https://redirect.github.com/threeal/cmake-action/issues/540&quot… <li><a href="https://github.com/threeal/cmake-action/commit/3f767d1e2b70aca09… chore: bump rollup from 4.27.4 to 4.28.0 (<a href="https://redirect.github.com/threeal/cmake-action/issues/539&quot… <li><a href="https://github.com/threeal/cmake-action/commit/b6fc2b4c091acd09e… chore: bump Yarn to version 4.5.3 (<a href="https://redirect.github.com/threeal/cmake-action/issues/538&quot… <li><a href="https://github.com/threeal/cmake-action/commit/639d8219e822101b6… chore: bump <code>@types/node</code> from 22.10.0 to 22.10.1 (<a href="https://redirect.github.com/threeal/cmake-action/issues/537&quot… <li><a href="https://github.com/threeal/cmake-action/commit/820fc064966f53b9e… chore: bump prettier from 3.3.3 to 3.4.1 (<a href="https://redirect.github.com/threeal/cmake-action/issues/536&quot… <li><a href="https://github.com/threeal/cmake-action/commit/38835ec642f1688f1… chore: bump typescript-eslint from 8.15.0 to 8.16.0 (<a href="https://redirect.github.com/threeal/cmake-action/issues/534&quot… <li><a href="https://github.com/threeal/cmake-action/commit/4a4b9a2bb1f850992… chore: bump <code>@types/node</code> from 22.9.1 to 22.10.0 (<a href="https://redirect.github.com/threeal/cmake-action/issues/533&quot… <li>Additional commits viewable in <a href="https://github.com/threeal/cmake-action/compare/v2.0.0...v2.1.0&… view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?d… Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4062 -- Commit Summary -- * github: [skip ci]: bump threeal/cmake-action from 2.0.0 to 2.1.0 -- File Changes -- M .github/workflows/cmake_build.yml (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4062.patch https://github.com/kamailio/kamailio/pull/4062.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4062 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4062(a)github.com>

1 week, 6 days

git:master:e71b02a3: github: [skip ci]: bump threeal/cmake-action from 2.0.0 to 2.1.0

by Victor Seva

Module: kamailio Branch: master Commit: e71b02a326e2ce54e4bf6c6c209f79af43c54278 URL: https://github.com/kamailio/kamailio/commit/e71b02a326e2ce54e4bf6c6c209f79a… Author: dependabot[bot] <49699333+dependabot[bot](a)users.noreply.github.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-12-10T07:59:12+01:00 github: [skip ci]: bump threeal/cmake-action from 2.0.0 to 2.1.0 Bumps [threeal/cmake-action](https://github.com/threeal/cmake-action) from 2.0.0 to 2.1.0. - [Release notes](https://github.com/threeal/cmake-action/releases) - [Commits](https://github.com/threeal/cmake-action/compare/v2.0.0...v2.1.0) --- updated-dependencies: - dependency-name: threeal/cmake-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support(a)github.com> --- Modified: .github/workflows/cmake_build.yml --- Diff: https://github.com/kamailio/kamailio/commit/e71b02a326e2ce54e4bf6c6c209f79a… Patch: https://github.com/kamailio/kamailio/commit/e71b02a326e2ce54e4bf6c6c209f79a… --- diff --git a/.github/workflows/cmake_build.yml b/.github/workflows/cmake_build.yml index 8bab75c65bb..73ab19ef5d7 100644 --- a/.github/workflows/cmake_build.yml +++ b/.github/workflows/cmake_build.yml @@ -49,7 +49,7 @@ jobs: sudo apt-get install -y gcc-aarch64-linux-gnu g++-aarch64-linux-gnu - name: Build Project natively - uses: threeal/cmake-action(a)v2.0.0 + uses: threeal/cmake-action(a)v2.1.0 # Step runs for all except this combination if: matrix.os != 'ubuntu-latest' || matrix.target_arch != 'aarch64' with: @@ -62,7 +62,7 @@ jobs: - name: Build Project with cross-compiler if: matrix.os == 'ubuntu-latest' && matrix.target_arch == 'aarch64' - uses: threeal/cmake-action(a)v2.0.0 + uses: threeal/cmake-action(a)v2.1.0 with: build-dir: ${{github.workspace}}/build build-args: -j8

1 week, 6 days

[kamailio/kamailio] kamcmd tls.reload problem (Issue #4033)

by ynasida

Hello, I am using letsencrypt cert and key and do not want to restart kamailio every 3 months to load new ones. I know that there is: kamcmd tls.reload method but it has an error for me. error: 500 - Error while fixing TLS configuration (consult server log) I am checking the logs and see: kamailio[3865480]: INFO: tls [tls_domain.c:345]: ksr_tls_fill_missing(): TLSs<default>: tls_method=3 kamailio[3865480]: INFO: tls [tls_domain.c:357]: ksr_tls_fill_missing(): TLSs<default>: certificate='/etc/kamailio/certs/my_cert.crt' kamailio[3865480]: INFO: tls [tls_domain.c:364]: ksr_tls_fill_missing(): TLSs<default>: ca_list='(null)' kamailio[3865480]: INFO: tls [tls_domain.c:371]: ksr_tls_fill_missing(): TLSs<default>: ca_path='(null)' kamailio[3865480]: INFO: tls [tls_domain.c:378]: ksr_tls_fill_missing(): TLSs<default>: crl='(null)' kamailio[3865480]: INFO: tls [tls_domain.c:382]: ksr_tls_fill_missing(): TLSs<default>: require_certificate=0 kamailio[3865480]: INFO: tls [tls_domain.c:390]: ksr_tls_fill_missing(): TLSs<default>: cipher_list='(null)' kamailio[3865480]: INFO: tls [tls_domain.c:397]: ksr_tls_fill_missing(): TLSs<default>: private_key='/etc/kamailio/certs/private.key' kamailio[3865480]: INFO: tls [tls_domain.c:401]: ksr_tls_fill_missing(): TLSs<default>: verify_certificate=0 kamailio[3865480]: INFO: tls [tls_domain.c:406]: ksr_tls_fill_missing(): TLSs<default>: verify_depth=9 kamailio[3865480]: INFO: tls [tls_domain.c:410]: ksr_tls_fill_missing(): TLSs<default>: verify_client=0 kamailio[3865480]: NOTICE: tls [tls_domain.c:1168]: ksr_tls_fix_domain(): registered server_name callback handler for socket [:0], server_name='<default>' ... kamailio[3865480]: ERROR: tls [tls_domain.c:590]: load_cert(): TLSs<default>: Unable to load certificate file '/etc/kamailio/certs/my_cert.crt' kamailio[3865480]: ERROR: tls [tls_util.h:49]: tls_err_ret(): load_cert:error:03000072:digital envelope routines::decode error (sni: unknown) kamailio[3865480]: ERROR: tls [tls_util.h:49]: tls_err_ret(): load_cert:error:0A00018F:SSL routines::ee key too small (sni: unknown) Any advice ? It's interesting that there are not any TLS errors in case I restart kamailio. I can make TLS calls without problems. deb 12.5 version: kamailio 5.7.4 (x86_64/linux) -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4033 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4033(a)github.com>

1 week, 6 days

git:master:8e398b86: lib/srdb1: new and free connection callbacks expect one parameter

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 8e398b8675079e1baac7c7575e70283175cdebe2 URL: https://github.com/kamailio/kamailio/commit/8e398b8675079e1baac7c7575e70283… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-12-09T19:04:25+01:00 lib/srdb1: new and free connection callbacks expect one parameter - new connection is executetd with a database id and free connection with a pool con - compiler warnings: src/lib/srdb1/db.c:322:23: warning: passing arguments to a function without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] 322 | con = new_connection(id); src/lib/srdb1/db.c:361:18: warning: passing arguments to a function without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] 361 | free_connection(con); --- Modified: src/lib/srdb1/db.c Modified: src/lib/srdb1/db.h --- Diff: https://github.com/kamailio/kamailio/commit/8e398b8675079e1baac7c7575e70283… Patch: https://github.com/kamailio/kamailio/commit/8e398b8675079e1baac7c7575e70283… --- diff --git a/src/lib/srdb1/db.c b/src/lib/srdb1/db.c index b13d87c692b..77dea84df52 100644 --- a/src/lib/srdb1/db.c +++ b/src/lib/srdb1/db.c @@ -270,7 +270,7 @@ int db_bind_mod(const str *mod, db_func_t *mydbf) * Initialize database module * \note No function should be called before this */ -db1_con_t *db_do_init(const str *url, void *(*new_connection)()) +db1_con_t *db_do_init(const str *url, void *(*new_connection)(struct db_id *)) { return db_do_init2(url, *new_connection, DB_POOLING_PERMITTED); } @@ -280,8 +280,8 @@ db1_con_t *db_do_init(const str *url, void *(*new_connection)()) * Initialize database module * \note No function should be called before this */ -db1_con_t *db_do_init2( - const str *url, void *(*new_connection)(), db_pooling_t pooling) +db1_con_t *db_do_init2(const str *url, void *(*new_connection)(struct db_id *), + db_pooling_t pooling) { struct db_id *id; void *con; @@ -347,7 +347,7 @@ db1_con_t *db_do_init2( * Shut down database module * \note No function should be called after this */ -void db_do_close(db1_con_t *_h, void (*free_connection)()) +void db_do_close(db1_con_t *_h, void (*free_connection)(struct pool_con *)) { struct pool_con *con; diff --git a/src/lib/srdb1/db.h b/src/lib/srdb1/db.h index 248647ecd07..a9538f6b9ca 100644 --- a/src/lib/srdb1/db.h +++ b/src/lib/srdb1/db.h @@ -48,6 +48,8 @@ #include "db_cap.h" #include "db_con.h" #include "db_row.h" +#include "db_id.h" +#include "db_pool.h" #include "db_pooling.h" #include "db_locking.h" @@ -464,7 +466,7 @@ int db_bind_mod(const str *mod, db_func_t *dbf); * \return returns a pointer to the db1_con_t representing the connection if it was successful, otherwise 0 is returned. */ -db1_con_t *db_do_init(const str *url, void *(*new_connection)()); +db1_con_t *db_do_init(const str *url, void *(*new_connection)(struct db_id *)); /** @@ -478,8 +480,8 @@ db1_con_t *db_do_init(const str *url, void *(*new_connection)()); * \return returns a pointer to the db1_con_t representing the connection if it was successful, otherwise 0 is returned. */ -db1_con_t *db_do_init2( - const str *url, void *(*new_connection)(), db_pooling_t pooling); +db1_con_t *db_do_init2(const str *url, void *(*new_connection)(struct db_id *), + db_pooling_t pooling); /** @@ -490,7 +492,7 @@ db1_con_t *db_do_init2( * \param _h database connection handle * \param (*free_connection) Pointer to the db specific free_connection method */ -void db_do_close(db1_con_t *_h, void (*free_connection)()); +void db_do_close(db1_con_t *_h, void (*free_connection)(struct pool_con *)); /**

1 week, 6 days

Updated: Online devel meeting on matrix - 15:00 UTC, Dec 9, 2024

by Daniel-Constantin Mierla

Hello, we should consider an online devel meeting sometime soon to summarize what was done at (and still needs to be done after) devel meeting in Dusseldorf and plan a bit the targets for next major release 6.0. If considered useful, I propose Dec 9, 2024 (Monday) at 15:00UTC (16:00 Berlin/Paris/Madrid/Rome), but we can also look for other dates as well. Topics to be discussed can be added at: - https://github.com/kamailio/kamailio-wiki/blob/main/docs/devel/irc-meetings… Pull requests can be made by users without git access. Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda

2 weeks

git:master:83e9cc03: cmake: Link internal libraries to core and remove them from modules

by Xenofon Karamanos

Module: kamailio Branch: master Commit: 83e9cc036147b071281ad5c444a473ece83f618e URL: https://github.com/kamailio/kamailio/commit/83e9cc036147b071281ad5c444a473e… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xenakiskaramanos(a)gmail.com> Date: 2024-12-09T15:19:57+02:00 cmake: Link internal libraries to core and remove them from modules --- Modified: src/CMakeLists.txt Modified: src/core/CMakeLists.txt Modified: src/lib/CMakeLists.txt Modified: src/lib/ims/CMakeLists.txt Modified: src/lib/srdb1/CMakeLists.txt Modified: src/lib/srdb2/CMakeLists.txt Modified: src/lib/trie/CMakeLists.txt Modified: src/modules/acc/CMakeLists.txt Modified: src/modules/alias_db/CMakeLists.txt Modified: src/modules/auth_db/CMakeLists.txt Modified: src/modules/avpops/CMakeLists.txt Modified: src/modules/carrierroute/CMakeLists.txt Modified: src/modules/cfg_db/CMakeLists.txt Modified: src/modules/cnxcc/CMakeLists.txt Modified: src/modules/cplc/CMakeLists.txt Modified: src/modules/db2_ldap/CMakeLists.txt Modified: src/modules/db2_ops/CMakeLists.txt Modified: src/modules/db_berkeley/CMakeLists.txt Modified: src/modules/db_cluster/CMakeLists.txt Modified: src/modules/db_flatstore/CMakeLists.txt Modified: src/modules/db_mongodb/CMakeLists.txt Modified: src/modules/db_oracle/CMakeLists.txt Modified: src/modules/db_perlvdb/CMakeLists.txt Modified: src/modules/db_postgres/CMakeLists.txt Modified: src/modules/db_redis/CMakeLists.txt Modified: src/modules/db_sqlite/CMakeLists.txt Modified: src/modules/db_text/CMakeLists.txt Modified: src/modules/db_unixodbc/CMakeLists.txt Modified: src/modules/dialog/CMakeLists.txt Modified: src/modules/dialplan/CMakeLists.txt Modified: src/modules/dispatcher/CMakeLists.txt Modified: src/modules/dmq/CMakeLists.txt Modified: src/modules/domain/CMakeLists.txt Modified: src/modules/domainpolicy/CMakeLists.txt Modified: src/modules/drouting/CMakeLists.txt Modified: src/modules/group/CMakeLists.txt Modified: src/modules/htable/CMakeLists.txt Modified: src/modules/imc/CMakeLists.txt Modified: src/modules/ims_auth/CMakeLists.txt Modified: src/modules/ims_charging/CMakeLists.txt Modified: src/modules/ims_dialog/CMakeLists.txt Modified: src/modules/ims_diameter_server/CMakeLists.txt Modified: src/modules/ims_icscf/CMakeLists.txt Modified: src/modules/ims_ipsec_pcscf/CMakeLists.txt Modified: src/modules/ims_isc/CMakeLists.txt Modified: src/modules/ims_ocs/CMakeLists.txt Modified: src/modules/ims_qos/CMakeLists.txt Modified: src/modules/ims_qos_npn/CMakeLists.txt Modified: src/modules/ims_usrloc_pcscf/CMakeLists.txt Modified: src/modules/ims_usrloc_scscf/CMakeLists.txt Modified: src/modules/kazoo/CMakeLists.txt Modified: src/modules/keepalive/CMakeLists.txt Modified: src/modules/lcr/CMakeLists.txt Modified: src/modules/matrix/CMakeLists.txt Modified: src/modules/mohqueue/CMakeLists.txt Modified: src/modules/mqueue/CMakeLists.txt Modified: src/modules/msilo/CMakeLists.txt Modified: src/modules/mtree/CMakeLists.txt Modified: src/modules/p_usrloc/CMakeLists.txt Modified: src/modules/pdt/CMakeLists.txt Modified: src/modules/permissions/CMakeLists.txt Modified: src/modules/pipelimit/CMakeLists.txt Modified: src/modules/prefix_route/CMakeLists.txt Modified: src/modules/presence/CMakeLists.txt Modified: src/modules/presence_xml/CMakeLists.txt Modified: src/modules/pua/CMakeLists.txt Modified: src/modules/rls/CMakeLists.txt Modified: src/modules/rtpengine/CMakeLists.txt Modified: src/modules/rtpproxy/CMakeLists.txt Modified: src/modules/sca/CMakeLists.txt Modified: src/modules/secfilter/CMakeLists.txt Modified: src/modules/sipcapture/CMakeLists.txt Modified: src/modules/siptrace/CMakeLists.txt Modified: src/modules/siputils/CMakeLists.txt Modified: src/modules/speeddial/CMakeLists.txt Modified: src/modules/sqlops/CMakeLists.txt Modified: src/modules/topos/CMakeLists.txt Modified: src/modules/uac/CMakeLists.txt Modified: src/modules/uid_auth_db/CMakeLists.txt Modified: src/modules/uid_avp_db/CMakeLists.txt Modified: src/modules/uid_domain/CMakeLists.txt Modified: src/modules/uid_gflags/CMakeLists.txt Modified: src/modules/uid_uri_db/CMakeLists.txt Modified: src/modules/uri_db/CMakeLists.txt Modified: src/modules/userblocklist/CMakeLists.txt Modified: src/modules/usrloc/CMakeLists.txt Modified: src/modules/utils/CMakeLists.txt Modified: src/modules/xcap_client/CMakeLists.txt Modified: src/modules/xcap_server/CMakeLists.txt Modified: src/modules/xhttp/CMakeLists.txt Modified: src/modules/xhttp_pi/CMakeLists.txt --- Diff: https://github.com/kamailio/kamailio/commit/83e9cc036147b071281ad5c444a473e… Patch: https://github.com/kamailio/kamailio/commit/83e9cc036147b071281ad5c444a473e…

2 weeks

[kamailio/kamailio] Module snmpstats reporting inconsistent call success metrics on intense peaks of failed calls (Issue #4006)

by igorpotjevlesh

### Description We are plotting the call success rate on each of our proxies. Using the Kamailio snmpstats module, we try to obtain three counters in order to plot them on a graph: - Total Calls - Active Calls - Error Calls Most of the time, everything works well and we obtain sensible values: `snmpwalk -c mycommunity -v 2c W.X.Y.Z 1.3.6.1.4.1.34352.3.1.3.1.3.2 -O n` > .1.3.6.1.4.1.34352.3.1.3.1.3.2.1.0 = Gauge32: 309 -> Total Calls .1.3.6.1.4.1.34352.3.1.3.1.3.2.2.0 = Gauge32: 95 -> Active Calls .1.3.6.1.4.1.34352.3.1.3.1.3.2.3.0 = Gauge32: 214 -> Error calls However, **when our proxies are facing intense peaks of failed calls in a short timespan**, sometimes, the **"Error Calls"** counter returns a value **higher than "Total Calls"**. As a result, **"Active Calls"** suddenly reaches a value close to the **maximum of a _Gauge32_** (because ${TotalCalls} - {ErrorCalls} < 0$). `snmpwalk -c mycommunity -v 2c W.X.Y.Z 1.3.6.1.4.1.34352.3.1.3.1.3.2 -O n` > .1.3.6.1.4.1.34352.3.1.3.1.3.2.1.0 = Gauge32: 153 -> Total Calls .1.3.6.1.4.1.34352.3.1.3.1.3.2.2.0 = Gauge32: 4294967226 -> Active Calls .1.3.6.1.4.1.34352.3.1.3.1.3.2.3.0 = Gauge32: 223 -> Error calls As a result, our graphs make no more sense. ### Troubleshooting There seems to be a bug causing Total calls to be lower than Error calls when a high number of failed calls are received in a short time window. Moreover, there is an integer overflow resulting to the negative result of the substraction being converted to a _Gauge32_. Maybe setting it to 0 in case of a negative result would be safer ? #### Reproduction Using the following configuration for the snmpstats module of your Kamailio proxy: ``` # -------- snmpstats params ------- modparam("snmpstats", "snmpgetPath", "/usr/bin/") modparam("snmpstats", "snmpCommunity", "mycommunity") modparam("snmpstats", "sipEntityType", "proxyServer") ``` On intense peaks of failed calls, get the call success metrics using `snmpwalk` : `snmpwalk -c mycommunity -v 2c W.X.Y.Z 1.3.6.1.4.1.34352.3.1.3.1.3.2 -O n` > .1.3.6.1.4.1.34352.3.1.3.1.3.2.1.0 = Gauge32: 153 -> Total Calls .1.3.6.1.4.1.34352.3.1.3.1.3.2.2.0 = Gauge32: 4294967226 -> Active Calls .1.3.6.1.4.1.34352.3.1.3.1.3.2.3.0 = Gauge32: 223-> Error calls ### Additional Information **Kamailio Version**: `kamailio -v` > version: kamailio 5.6.4 (x86_64/linux) a004cf flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_ MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_S R_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, U SE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SI ZE 65535, DEFAULT PKG_SIZE 64MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: a004cf compiled on 16:10:41 May 22 2023 with gcc 4.4.7 * **Operating System**: `uname -r` > 2.6.32-279.el6.x86_64 `lsb_release -a` > LSB Version: :core-4.0-amd64:core-4.0-noarch:graphics-4.0-amd64:graphics-4.0-noarch:printing-4.0-amd64:printing-4.0-noarch Distributor ID: RedHatEnterpriseServer Description: Red Hat Enterprise Linux Server release 6.3 (Santiago) Release: 6.3 Codename: Santiago -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4006 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4006(a)github.com>

2 weeks

[kamailio/kamailio] Python exception handling fixes (PR #4044)

by Matthias Urlichs

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [X] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Python's C interface contract states that C code must *either* raise an exception and return NULL, *or* return a Python object. Doing both will raise a `SystemError` exception which obscures the original problem. It may also cause a memory leak. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4044 -- Commit Summary -- * app_python3: fix exception handling -- File Changes -- M src/modules/app_python3/apy_kemi.c (4) M src/modules/app_python3s/apy3s_kemi.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4044.patch https://github.com/kamailio/kamailio/pull/4044.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4044 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4044(a)github.com>

2 weeks

git:master:ef73fb87: app_python3s: fix exception handling

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: ef73fb876f527c3bde4b425e3ec70d3f613fcb87 URL: https://github.com/kamailio/kamailio/commit/ef73fb876f527c3bde4b425e3ec70d3… Author: Matthias Urlichs <matthias(a)urlichs.de> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-12-09T12:13:54+01:00 app_python3s: fix exception handling Python's C interface contract states that C code must *either* raise an exception and return NULL, *or* return a Python object. --- Modified: src/modules/app_python3s/apy3s_kemi.c --- Diff: https://github.com/kamailio/kamailio/commit/ef73fb876f527c3bde4b425e3ec70d3… Patch: https://github.com/kamailio/kamailio/commit/ef73fb876f527c3bde4b425e3ec70d3… --- diff --git a/src/modules/app_python3s/apy3s_kemi.c b/src/modules/app_python3s/apy3s_kemi.c index f28354909b7..dd23bd0f2d7 100644 --- a/src/modules/app_python3s/apy3s_kemi.c +++ b/src/modules/app_python3s/apy3s_kemi.c @@ -409,7 +409,7 @@ PyObject *sr_apy_kemi_exec_func_ex( if(pobj == NULL) { LM_ERR("null parameter - func: %.*s idx: %d argc: %d\n", fname.len, fname.s, i, (int)alen); - return sr_kemi_apy_return_false(); + return NULL; } if(ket->ptypes[i] == SR_KEMIP_STR) { if(!PyUnicode_Check(pobj)) { @@ -421,7 +421,7 @@ PyObject *sr_apy_kemi_exec_func_ex( if(vps[i].v.s.s == NULL) { LM_ERR("null-string parameter - func: %.*s idx: %d argc: %d\n", fname.len, fname.s, i, (int)alen); - return sr_kemi_apy_return_false(); + return NULL; } vps[i].v.s.len = (int)slen; vps[i].vtype = SR_KEMIP_STR;

2 weeks

← Newer
1
...
21
22
23
24
25
26
27
...
32
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2024