sr-dev November 2024

sr-dev@lists.kamailio.org

20 participants
367 discussions

git:master:cc4e51c4: rtpengine: doc - fix quote tag

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: cc4e51c45d23b4450d082ba606445b515788ba61 URL: https://github.com/kamailio/kamailio/commit/cc4e51c45d23b4450d082ba606445b5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-19T16:20:46+01:00 rtpengine: doc - fix quote tag --- Modified: src/modules/rtpengine/doc/rtpengine_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/cc4e51c45d23b4450d082ba606445b5… Patch: https://github.com/kamailio/kamailio/commit/cc4e51c45d23b4450d082ba606445b5… --- diff --git a/src/modules/rtpengine/doc/rtpengine_admin.xml b/src/modules/rtpengine/doc/rtpengine_admin.xml index cc4241808ea..9a57c2e551e 100644 --- a/src/modules/rtpengine/doc/rtpengine_admin.xml +++ b/src/modules/rtpengine/doc/rtpengine_admin.xml @@ -915,7 +915,7 @@ modparam("rtpengine", "mos_min_roundtrip_pv", "$avp(mos_min_roundtrip)") There is no default value. </para> <para> - This value is filled in after invoking< quote>rtpengine_delete</quote>, + This value is filled in after invoking <quote>rtpengine_delete</quote>, <quote>rtpengine_query</quote>, or <quote>rtpengine_manage</quote> if the command resulted in a deletion of the call (or call branch). </para>

1 month, 2 weeks

git:master:d93e0bc1: pv: made is_uri_enclosed() condition function inline

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: d93e0bc19f577114ef7e07afad3ce329c399a488 URL: https://github.com/kamailio/kamailio/commit/d93e0bc19f577114ef7e07afad3ce32… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-19T16:18:01+01:00 pv: made is_uri_enclosed() condition function inline --- Modified: src/modules/pv/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/d93e0bc19f577114ef7e07afad3ce32… Patch: https://github.com/kamailio/kamailio/commit/d93e0bc19f577114ef7e07afad3ce32… --- diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index f112931a735..1054a6ae57b 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -76,8 +76,6 @@ int _pv_pid = 0; #define PV_HDR_DELIM "," #define PV_HDR_DELIM_LEN (sizeof(PV_HDR_DELIM) - 1) -static int is_uri_enclosed(struct sip_msg *msg, struct to_body *tb); - int pv_get_msgid(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) { if(msg == NULL) @@ -3605,6 +3603,26 @@ int pv_set_bflag( return 0; } +static inline int is_uri_enclosed(struct sip_msg *msg, struct to_body *tb) +{ + /* Check for the presence of display name */ + if(tb->display.len == 0) { + /* Display name not found */ + char *uri_body = tb->body.s; + + /* Assuming a valid sip message (true otherwise parser fails way before) + if it starts with '<' there is a respective '>'. + Also, parser trims any leading white space if no DisplayName is found + */ + if(uri_body[0] == '<') { + return 1; + } + return 0; + } + /* Display name found, URI should/must be enclosed */ + return 1; +} + int pv_set_xto_attr(struct sip_msg *msg, pv_param_t *param, int op, pv_value_t *val, struct to_body *tb, int type) { @@ -3799,26 +3817,6 @@ int pv_set_xto_attr(struct sip_msg *msg, pv_param_t *param, int op, return -1; } -int is_uri_enclosed(struct sip_msg *msg, struct to_body *tb) -{ - /* Check for the presence of display name */ - if(tb->display.len == 0) { - /* Display name not found */ - char *uri_body = tb->body.s; - - /* Assuming a valid sip message (true otherwise parser fails way before) - if it starts with '<' there is a respective '>'. - Also, parser trims any leading white space if no DisplayName is found - */ - if(uri_body[0] == '<') { - return 1; - } - return 0; - } - /* Display name found, URI should/must be enclosed */ - return 1; -} - int pv_set_to_attr(struct sip_msg *msg, pv_param_t *param, int op, pv_value_t *val, int type) {

1 month, 2 weeks

[kamailio/kamailio] pv: Ensure URI enclosed in <> when changing Display Name (PR #3935)

by Xenofon Karamanos

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  This PR fixes a bug in pseudo-variables related to "From" and "To" headers and changing the `Display Name` through `$tu/$fu/$fn/$tn`. According to standard the URI must be enclosed in <> if a `Display Name` is given, but it may or may NOT if no display name is present. So, if one tries to modify the `from`/`to` header with an initial empty display name and URI that is NOT enclosed in <>, it yields an invalid message. This PR makes sure that if URI was not enclosed in <> and display name is modified, that will wrap URI in <>. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3935 -- Commit Summary -- * pv: Ensure URI enclosed in <> when changing Display Name -- File Changes -- M src/modules/pv/pv_core.c (62) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3935.patch https://github.com/kamailio/kamailio/pull/3935.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3935 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3935(a)github.com>

1 month, 2 weeks

git:master:ff58d71f: modules: readme files regenerated - rtpengine ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: ff58d71f3d6c01e6c1a000c5f4de8fc8f5bedc3d URL: https://github.com/kamailio/kamailio/commit/ff58d71f3d6c01e6c1a000c5f4de8fc… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-11-19T16:16:09+01:00 modules: readme files regenerated - rtpengine ... [skip ci] --- Modified: src/modules/rtpengine/README --- Diff: https://github.com/kamailio/kamailio/commit/ff58d71f3d6c01e6c1a000c5f4de8fc… Patch: https://github.com/kamailio/kamailio/commit/ff58d71f3d6c01e6c1a000c5f4de8fc…

1 month, 2 weeks

git:master:75e17db2: pv: Ensure URI enclosed in <> when changing Display Name

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 75e17db22afa92929054ccf36c8ca9b5daafccd8 URL: https://github.com/kamailio/kamailio/commit/75e17db22afa92929054ccf36c8ca9b… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-19T16:15:59+01:00 pv: Ensure URI enclosed in <> when changing Display Name --- Modified: src/modules/pv/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/75e17db22afa92929054ccf36c8ca9b… Patch: https://github.com/kamailio/kamailio/commit/75e17db22afa92929054ccf36c8ca9b… --- diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index e36c5004032..f112931a735 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -76,6 +76,8 @@ int _pv_pid = 0; #define PV_HDR_DELIM "," #define PV_HDR_DELIM_LEN (sizeof(PV_HDR_DELIM) - 1) +static int is_uri_enclosed(struct sip_msg *msg, struct to_body *tb); + int pv_get_msgid(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) { if(msg == NULL) @@ -3607,9 +3609,13 @@ int pv_set_xto_attr(struct sip_msg *msg, pv_param_t *param, int op, pv_value_t *val, struct to_body *tb, int type) { str buf = {0, 0}; + str buf_uri = {0, 0}; struct lump *l = NULL; int loffset = 0; + int loffset_uri = 0; int llen = 0; + int llen_uri = 0; + int is_enclosed = 0; if(msg == NULL || param == NULL) { LM_ERR("bad parameters\n"); @@ -3683,7 +3689,7 @@ int pv_set_xto_attr(struct sip_msg *msg, pv_param_t *param, int op, } buf.s = pkg_malloc(val->rs.len); if(buf.s == 0) { - LM_ERR("no more pkg mem\n"); + PKG_MEM_ERROR; goto error; } buf.len = val->rs.len; @@ -3715,6 +3721,29 @@ int pv_set_xto_attr(struct sip_msg *msg, pv_param_t *param, int op, } buf.len = val->rs.len; memcpy(buf.s, val->rs.s, val->rs.len); + + /* Check if the URI is enclosed in angle brackets */ + is_enclosed = is_uri_enclosed(msg, tb); + /* If uri is not enclosed, we need to enclose it in < > + before adding display name */ + if(!is_enclosed) { + LM_DBG("URI is not enclosed in angle brackets\n"); + /* Enclose URI in angle brackets */ + loffset_uri = tb->uri.s - msg->buf; + llen_uri = tb->uri.len; + /* Add angle brackets */ + buf_uri.s = pkg_malloc(tb->uri.len + 2); + if(buf_uri.s == 0) { + LM_ERR("no more pkg mem\n"); + goto error; + } + buf_uri.len = tb->uri.len + 2; + buf_uri.s[0] = '<'; + memcpy(buf_uri.s + 1, tb->uri.s, tb->uri.len); + buf_uri.s[buf_uri.len - 1] = '>'; + LM_DBG("URI after enclosing: %.*s\n", buf_uri.len, buf_uri.s); + } + if(tb->display.len == 0) { l = anchor_lump(msg, tb->body.s - msg->buf, 0, 0); buf.s[buf.len] = ' '; @@ -3744,6 +3773,24 @@ int pv_set_xto_attr(struct sip_msg *msg, pv_param_t *param, int op, if(buf.s != 0) pkg_free(buf.s); } + + if(llen_uri > 0) { + if((l = del_lump(msg, loffset_uri, llen_uri, 0)) == 0) { + LM_ERR("failed to delete xto attribute %d\n", type); + goto error; + } + } + /* set new value when given */ + if(l != NULL && buf_uri.len > 0) { + if(insert_new_lump_after(l, buf_uri.s, buf_uri.len, 0) == 0) { + LM_ERR("failed to set xto attribute %d\n", type); + goto error; + } + } else { + if(buf_uri.s != 0) + pkg_free(buf_uri.s); + } + return 0; error: @@ -3752,6 +3799,26 @@ int pv_set_xto_attr(struct sip_msg *msg, pv_param_t *param, int op, return -1; } +int is_uri_enclosed(struct sip_msg *msg, struct to_body *tb) +{ + /* Check for the presence of display name */ + if(tb->display.len == 0) { + /* Display name not found */ + char *uri_body = tb->body.s; + + /* Assuming a valid sip message (true otherwise parser fails way before) + if it starts with '<' there is a respective '>'. + Also, parser trims any leading white space if no DisplayName is found + */ + if(uri_body[0] == '<') { + return 1; + } + return 0; + } + /* Display name found, URI should/must be enclosed */ + return 1; +} + int pv_set_to_attr(struct sip_msg *msg, pv_param_t *param, int op, pv_value_t *val, int type) {

1 month, 2 weeks

[kamailio/kamailio] Fixed segfault when using kazoo_query in kazoo mod (PR #4002)

by Remco van Vugt

A response to the amqp query caused a segfault in libc - Refactored parts of the code to be more readable and DRY - Split up functions for 3/4/5 arguments passed - Tested in 8.5.2 #### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description The current state of the module was not usable anymore as everything up from 5.5.x caused a segfault when the kazoo_query method was executed. Refactored the module a bit to make sure it is works again 5.8.x You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4002 -- Commit Summary -- * Fixed segfault when using kazoo_query in kazoo mod -- File Changes -- M src/modules/kazoo/kazoo.c (10) M src/modules/kazoo/kz_amqp.c (67) M src/modules/kazoo/kz_amqp.h (9) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4002.patch https://github.com/kamailio/kamailio/pull/4002.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4002 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4002(a)github.com>

1 month, 2 weeks

git:master:5a4b91e9: kazoo: fixed segfault when using kazoo_query

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 5a4b91e92b03160e13ef83ad486fb64fdae71c7f URL: https://github.com/kamailio/kamailio/commit/5a4b91e92b03160e13ef83ad486fb64… Author: Remco van Vugt <r.vanvugt(a)raffel.nl> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-19T16:05:27+01:00 kazoo: fixed segfault when using kazoo_query - Refactored parts of the code to be more readable and DRY - Split up functions for 3/4/5 arguments passed to avoid segfault - Fixed pseudovar allocation for returning results - Tested in 8.5.2 --- Modified: src/modules/kazoo/kazoo.c Modified: src/modules/kazoo/kz_amqp.c Modified: src/modules/kazoo/kz_amqp.h --- Diff: https://github.com/kamailio/kamailio/commit/5a4b91e92b03160e13ef83ad486fb64… Patch: https://github.com/kamailio/kamailio/commit/5a4b91e92b03160e13ef83ad486fb64…

1 month, 2 weeks

[kamailio/kamailio] modules/snmpstats: exit with `ksr_exit()` instead of standard `exit()` (PR #3993)

by Anton Yabchinskiy

The former respects the `--atexit=no` from Kamailio command line. See note on `atexit` in TLS module "Overview".   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  I'm using `tls` module along with some other modules. On Kamailio termination there are a lot of "freeing already freed pointer" messages from `qm_free()`. Also there may be a corrupted memory report (followed by `abort()`) from `qm_debug_check_frag()`. I'm aware of `--atexit=no` required for `tls`, and Kamailio is indeed started as `kamailio --atexit=no -m 16 -n 1 -w . -f some.cfg`. The `tls` module is loaded and configured something like this: ``` disable_core_dump=no debug=2 memdbg=2 # mem_safety=0 enable_tls=yes listen=tls:127.0.0.1:5060 mpath="lib64/kamailio/modules" loadmodule "tls.so" modparam("tls", "init_mode", 1) modparam("tls", "config", "tls.cfg"); loadmodule "snmpstats.so" modparam("snmpstats", "sipEntityType", "proxyServer") modparam("snmpstats", "snmpgetPath", "/usr/bin/") modparam("snmpstats", "snmpCommunity", "MySNMPComunity") modparam("snmpstats", "snmpVersion", "2c") loadmodule "xlog.so" route { xlog("L_NOTICE", "Hello\n"); } ``` Running Kamailio and then stopping it with `SIGTERM` yields the following. Some blocks of shared memory are allocated by the main process (PID 62575). E.g., one of the blocks: ``` 0(62575) INFO: <core> [core/mem/q_malloc.c:429]: qm_malloc(): qm_malloc(0x7facc5dc0000, 8) returns address 0x7facc5e55810 frag. 0x7facc5e557d8 (size=8) on 1 -th hit ``` On termination, this address is freed by another process (PID 62583). Somewhere after "sig_usr(): signal 15 received" message there's the following entry in the log: ``` 5(62583) INFO: <core> [core/mem/q_malloc.c:495]: qm_free(): qm_free(0x7facc5dc0000, 0x7facc5e55810), called from tls: tls_init.c: ser_free(400) ``` Then later the same address is freed again, by the main process (PID 62575). That's due to explicit call to `OPENSSL_cleanup()` from `tls_h_mod_destroy_f()` in `tls` module: ``` 0(62575) INFO: tls [tls_init.c:1063]: tls_h_mod_destroy_f(): executing openssl v1.1+ cleanup 0(62575) INFO: <core> [core/mem/q_malloc.c:495]: qm_free(): qm_free(0x7facc5dc0000, 0x7facc5e55810), called from tls: tls_init.c: ser_free(400) 0(62575) CRITICAL: <core> [core/mem/q_malloc.c:535]: qm_free(): BUG: freeing already freed pointer (0x7facc5e55810), called from tls: tls_init.c: ser_free(400), first free tls: tls_init.c: ser_free(400) - ignoring ``` It depends on initial conditions (which modules are loaded, what is the configuration, etc.), but sometimes `qm_debug_check_frag()` detects memory corruption and calls `abort()`: ``` 0(62575) CRITICAL: <core> [core/mem/q_malloc.c:126]: qm_debug_check_frag(): BUG: qm: fragm. 0x7facc5e891e0 (address 0x7facc5e89218) beginning overwritten (7facc5e85498)! Memory allocator was called from tls: tls_init.c:400. Fragment marked by :140376711102467. Exec from core/mem/q_malloc.c:526. ``` The output of `kamcmd core.ps` suggests that the offending process (PID 62583) is related to SNMP: ``` 62575 main process - attendant … 62583 SNMP AgentX ``` The "SNMP AgentX" process in `snmpstats` overrides some signal handlers (including the `SIGTERM` one) and calls `exit()`: ``` /*! Creates a child that will become the AgentX sub-agent. The child will * insulate itself from the rest of Kamailio by overriding most of signal * handlers. */ void agentx_child(int rank) { … /* Setup a SIGTERM handler */ sigfillset(&new_sigterm_handler.sa_mask); new_sigterm_handler.sa_flags = 0; new_sigterm_handler.sa_handler = sigterm_handler; sigaction(SIGTERM, &new_sigterm_handler, NULL); … } ``` ``` static void sigterm_handler(int signal) { /* Just exit. The master agent will clean everything up for us */ exit(0); } ``` Looks like this `exit()` triggers an extra call to `OPENSSL_cleanup`, implicitly armed by OpenSSL itself on startup. So, the OpenSSL cleanup gets called twice. As for now I've fixed the issue by replacing this `exit(0)` with `ksr_exit(0)` which respects the `--atexit=no` command line option. But I wonder is it a right way to do it. As far as I can see, code in `src/modules/` ignores `ksr_exit()` and uses plain `exit()`. Is it for a reason? Shouldn't modules also exit with `ksr_exit`? You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3993 -- Commit Summary -- * modules/snmpstats: exit with ksr_exit() instead of standard exit() -- File Changes -- M src/modules/snmpstats/snmpstats.c (5) M src/modules/snmpstats/sub_agent.c (5) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3993.patch https://github.com/kamailio/kamailio/pull/3993.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3993 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3993(a)github.com>

1 month, 2 weeks

git:master:ed5899b8: modules/snmpstats: exit with ksr_exit() instead of standard exit()

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: ed5899b8213a28eb5659edfd5b1b9740ba6a5ab5 URL: https://github.com/kamailio/kamailio/commit/ed5899b8213a28eb5659edfd5b1b974… Author: Anton Yabchinskiy <arn(a)bestmx.net> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-19T16:04:13+01:00 modules/snmpstats: exit with ksr_exit() instead of standard exit() The former respects the `--atexit=no` from Kamailio command line. See note on `atexit` in TLS module "Overview". --- Modified: src/modules/snmpstats/snmpstats.c Modified: src/modules/snmpstats/sub_agent.c --- Diff: https://github.com/kamailio/kamailio/commit/ed5899b8213a28eb5659edfd5b1b974… Patch: https://github.com/kamailio/kamailio/commit/ed5899b8213a28eb5659edfd5b1b974… --- diff --git a/src/modules/snmpstats/snmpstats.c b/src/modules/snmpstats/snmpstats.c index 34b699bdeb2..ac0614f777e 100644 --- a/src/modules/snmpstats/snmpstats.c +++ b/src/modules/snmpstats/snmpstats.c @@ -92,6 +92,7 @@ #include "../../core/script_cb.h" #include "../../core/mem/mem.h" #include "../../core/mem/shm_mem.h" +#include "../../core/daemonize.h" #include "snmpSIPRegUserTable.h" #include "snmpSIPContactTable.h" @@ -561,14 +562,14 @@ static int spawn_sysUpTime_child(void) "kamailioSIPServiceStartTime is defaulting to zero\n"); close(snmpget_fd); free(full_path_to_snmpget); - exit(-1); + ksr_exit(-1); } /* We should never be able to get here, because execve() is never * supposed to return. */ close(snmpget_fd); free(full_path_to_snmpget); - exit(-1); + ksr_exit(-1); } diff --git a/src/modules/snmpstats/sub_agent.c b/src/modules/snmpstats/sub_agent.c index 92ca838c944..cc3ff06aa02 100644 --- a/src/modules/snmpstats/sub_agent.c +++ b/src/modules/snmpstats/sub_agent.c @@ -65,6 +65,7 @@ #include "../../core/dprint.h" #include "../../core/cfg/cfg_struct.h" +#include "../../core/daemonize.h" static int keep_running; @@ -72,7 +73,7 @@ static int keep_running; static void sigterm_handler(int signal) { /* Just exit. The master agent will clean everything up for us */ - exit(0); + ksr_exit(0); } /*! This function: @@ -125,7 +126,7 @@ static int initialize_agentx(void) LM_DBG("Shutting down Kamailio SNMPD MasterX sub agent.\n"); snmp_shutdown(AGENT_PROCESS_NAME); SOCK_CLEANUP; - exit(0); + ksr_exit(0); return 0; }

1 month, 2 weeks

[kamailio/kamailio] rtpengine: update doc (PR #3998)

by Ihor Olkhovskyi

- explicit mention of label= flag - add explanations regarding mos_A/B_label_pv parameters - typo fixes   #### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3998 -- Commit Summary -- * rtpengine: update doc -- File Changes -- M src/modules/rtpengine/doc/rtpengine_admin.xml (48) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3998.patch https://github.com/kamailio/kamailio/pull/3998.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3998 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3998(a)github.com>

1 month, 2 weeks

← Newer
1
...
24
25
26
27
28
29
30
...
37
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2024