sr-dev November 2024

sr-dev@lists.kamailio.org

20 participants
367 discussions

[kamailio/kamailio] Kamailio crash on http_async_client module callback invocation (Issue #4019)

by Ivanuschak Nikolay

### Description Kamailio service crashed occasionally on `sock_cb` callback function of `http_async_client` module #### Reproduction The crash happens occasionally, no specific conditions have been identified for this issue. #### Debugging Data ``` Program terminated with signal SIGSEGV, Segmentation fault. (gdb) bt full #0 0x0000ffff9f4205e4 in event_del_ () from /lib64/libevent-2.1.so.6 No symbol table info available. #1 0x0000ffff9e7c9b24 in sock_cb (e=0xffffa2027ba8, s=9, what=4, cbp=0xffffa1c0fe58, sockp=0xffffa202d258) at http_multi.c:166 g = 0xffffa1c0fe58 cell = 0xffffa202d258 whatstr = {0xffff9e7eb508 "none", 0xffff9e7eb510 "IN", 0xffff9e7eb518 "OUT", 0xffff9e7eb520 "INOUT", 0xffff9e7eb528 "REMOVE"} __func__ = "sock_cb" #2 0x0000ffff9e73ffa8 in Curl_multi_closed () from /lib64/libcurl.so.4 No symbol table info available. #3 0x0000ffff9e73d43c in Curl_closesocket () from /lib64/libcurl.so.4 No symbol table info available. #4 0x0000ffff9e72c8f8 in conn_free.part () from /lib64/libcurl.so.4 No symbol table info available. #5 0x0000ffff9e72d544 in Curl_disconnect () from /lib64/libcurl.so.4 No symbol table info available. #6 0x0000ffff9e740948 in multi_done () from /lib64/libcurl.so.4 No symbol table info available. #7 0x0000ffff9e742b10 in curl_multi_remove_handle () from /lib64/libcurl.so.4 No symbol table info available. #8 0x0000ffff9e7c7f2c in event_cb (fd=59, kind=1, userp=0xffffa2027ba8) at http_multi.c:123 error = 0xffff9e7eac70 "TIMEOUT" g = 0xffffa1c0fe58 rc = 1968268110 easy = 0xffffa2027ba8 cell = 0xffffa202d258 __func__ = "event_cb" action = 0 #9 0x0000ffff9f423628 in event_process_active_single_queue () from /lib64/libevent-2.1.so.6 No symbol table info available. #10 0x0000ffff9f423ee8 in event_base_loop () from /lib64/libevent-2.1.so.6 No symbol table info available. #11 0x0000ffff9e7b7160 in async_http_run_worker (worker=0xffffa1606ed8) at async_http.c:95 ret = 65535 __func__ = "async_http_run_worker" #12 0x0000ffff9e7dc364 in child_init (rank=0) at http_async_client_mod.c:380 pid = 0 i = 0 __func__ = "child_init" #13 0x0000000000607fa8 in init_mod_child (m=0xffffb136c2f0, rank=0) at core/sr_module.c:899 --Type <RET> for more, q to quit, c to continue without paging-- ret = 0 __func__ = "init_mod_child" #14 0x0000000000607b38 in init_mod_child (m=0xffffb136d018, rank=0) at core/sr_module.c:892 ret = 0 __func__ = "init_mod_child" #15 0x0000000000607b38 in init_mod_child (m=0xffffb136ead0, rank=0) at core/sr_module.c:892 ret = 0 __func__ = "init_mod_child" #16 0x0000000000607b38 in init_mod_child (m=0xffffb13a98f8, rank=0) at core/sr_module.c:892 ret = 0 __func__ = "init_mod_child" #17 0x0000000000607b38 in init_mod_child (m=0xffffb140ab28, rank=0) at core/sr_module.c:892 ret = 0 __func__ = "init_mod_child" #18 0x0000000000607b38 in init_mod_child (m=0xffffb145ebf8, rank=0) at core/sr_module.c:892 ret = 1 __func__ = "init_mod_child" #19 0x00000000006089c4 in init_child (rank=0) at core/sr_module.c:953 ret = -783429656 type = 0x923dc0 "PROC_MAIN" __func__ = "init_child" #20 0x0000000000433030 in main_loop () at main.c:1843 i = 8 pid = 2823204 si = 0x0 si_desc = "udp receiver child=7 sock=[2605:84c0:48:205:1::6]:5080\000\000\220\036ٰ\377\377\000\000 \321M\321\377\377\000\000h\220\066\261\377\377\000\000\320\377\377\377\200\377\377\377\020\321M\321\377\377\000\000 \321M\321\377\377\000\000 \321M\321\377\377\000\000\360\320M\321\377\377\000\000\320\377\377\377\200\377\377\377" nrprocs = 8 woneinit = 1 __func__ = "main_loop" #21 0x000000000043f4e8 in main (argc=11, argv=0xffffd14dd6a8) at main.c:3086 cfg_stream = 0xc2502a0 c = -1 r = 0 tmp = 0xffffd14dfe34 "" tmp_len = 0 port = 0 proto = 65535 ahost = 0x0 --Type <RET> for more, q to quit, c to continue without paging-- aport = 0 options = 0x8e7c08 ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:Y:" ret = -1 seed = 203142350 rfd = 4 debug_save = 0 debug_flag = 0 dont_fork_cnt = 2 n_lst = 0xffffffff p = 0xffffb3d34348 <__libc_start_main+160> "" st = {st_dev = 25, st_ino = 18459, st_mode = 16877, st_nlink = 3, st_uid = 0, st_gid = 987, st_rdev = 0, __pad1 = 0, st_size = 80, st_blksize = 65536, __pad2 = 0, st_blocks = 0, st_atim = {tv_sec = 1707863213, tv_nsec = 9999979}, st_mtim = {tv_sec = 1729635590, tv_nsec = 702238079}, st_ctim = { tv_sec = 1729635598, tv_nsec = 32030431}, __glibc_reserved = {0, 0}} tbuf = '\000' <repeats 56 times>, "x\376\b\264\377\377\000\000h\376\b\264\377\377\000\000\b\376\b\264\377\377\000\000(\376\b\264\377\377\000\000\070\376\b\264\377\377\000\000\250\376\b\264\377\377\000\000\270\376\b\264\377\377\000\000\310\376\b\264\377\377\000\000H\376\b\264\377\377\000\000X\376\b\264\377\377", '\000' <repeats 18 times>, "\330\375\b\264\377\377", '\000' <repeats 42 times>... option_index = 12 long_options = {{name = 0x8e9fe0 "help", has_arg = 0, flag = 0x0, val = 104}, {name = 0x8e4e48 "version", has_arg = 0, flag = 0x0, val = 118}, { name = 0x8e9fe8 "alias", has_arg = 1, flag = 0x0, val = 1024}, {name = 0x8e9ff0 "subst", has_arg = 1, flag = 0x0, val = 1025}, {name = 0x8e9ff8 "substdef", has_arg = 1, flag = 0x0, val = 1026}, {name = 0x8ea008 "substdefs", has_arg = 1, flag = 0x0, val = 1027}, {name = 0x8ea018 "server-id", has_arg = 1, flag = 0x0, val = 1028}, {name = 0x8ea028 "loadmodule", has_arg = 1, flag = 0x0, val = 1029}, {name = 0x8ea038 "modparam", has_arg = 1, flag = 0x0, val = 1030}, {name = 0x8ea048 "log-engine", has_arg = 1, flag = 0x0, val = 1031}, {name = 0x8ea058 "debug", has_arg = 1, flag = 0x0, val = 1032}, { name = 0x8ea060 "cfg-print", has_arg = 0, flag = 0x0, val = 1033}, {name = 0x8ea070 "atexit", has_arg = 1, flag = 0x0, val = 1034}, { name = 0x8ea078 "all-errors", has_arg = 0, flag = 0x0, val = 1035}, {name = 0x0, has_arg = 0, flag = 0x0, val = 0}} __func__ = "main" (gdb) f 8 #8 0x0000ffff9e7c7f2c in event_cb (fd=59, kind=1, userp=0xffffa2027ba8) at http_multi.c:123 123 curl_multi_remove_handle(g->multi, easy); (gdb) f 1 #1 0x0000ffff9e7c9b24 in sock_cb (e=0xffffa2027ba8, s=9, what=4, cbp=0xffffa1c0fe58, sockp=0xffffa202d258) at http_multi.c:166 166 event_del(cell->ev); (gdb) p cell $1 = (struct http_m_cell *) 0xffffa202d258 (gdb) p cell->ev $2 = (struct event *) 0x92fbf0 (gdb) p *cell->ev $3 = {type = 1701998435, name = {s = 0x615f7273752f6572 <error: Cannot access memory at address 0x615f7273752f6572>, len = 1663987830}, params = {hooks = {contact = { expires = 0x7273752f65726f63, q = 0x632e7076615f, methods = 0x5b203e65726f633c, received = 0x7273752f65726f63, instance = 0x393a632e7076615f, reg_id = 0x203a5d32, ob = 0x6f6e20646c756f63, flags = 0x61636f6c6c612074}, uri = {transport = 0x7273752f65726f63, lr = 0x632e7076615f, r2 = 0x5b203e65726f633c, maddr = 0x7273752f65726f63, ttl = 0x393a632e7076615f, dstip = 0x203a5d32, dstport = 0x6f6e20646c756f63, ftag = 0x61636f6c6c612074, ob = 0x6572616873206574}, event_dialog = {call_id = 0x7273752f65726f63, from_tag = 0x632e7076615f, to_tag = 0x5b203e65726f633c, include_session_description = 0x7273752f65726f63, sla = 0x393a632e7076615f, ma = 0x203a5d32}}, list = 0x79726f6d656d2064}} ``` As it's seen in the stack backtrace the `cell` object is already released at the moment when `event_del` with this object is called. #### Log Messages - #### SIP Traffic - ### Possible Solutions - ### Additional Information ``` [centos@esrp-1b ~]$ kamailio -v version: kamailio 5.7.2 (aarch64/linux) 968dbe flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT-NOSMP, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 968dbe compiled on 19:25:05 Nov 10 2023 with gcc 8.5.0 ``` * **Operating System**: ``` [centos@esrp-1b ~]$ cat /etc/centos-release CentOS Stream release 8 [centos@esrp-1b ~]$ uname -a Linux esrp-1b.fl.base911.com 4.18.0-536.el8.aarch64 #1 SMP Thu Jan 18 15:21:54 UTC 2024 aarch64 aarch64 aarch64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4019 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4019(a)github.com>

4 hours, 13 minutes

[kamailio/kamailio] tcp_timer_check_connections() logs on CRITICAL and is not caught by event_route[tcp:timeout] (Issue #3995)

by Fritjof Höst

### Description Hi! We are in the progress of upgrading from Kamailio 5.5 to 5.8. During our testing we have noticed a new error being reported from Kamailio. We don’t see any other errors following it. ```jsx /usr/sbin/kamailio[201]: CRITICAL: <core> [core/tcp_main.c:5544]: tcp_timer_check_connections(): message processing timeout on connection id: 67896 (state: 3) - closing ``` It does seem to be [new code](https://github.com/kamailio/kamailio/blob/master/src/core/tcp_main.c#… in Kamailio reporting this issue. Given that this is a fairly expected thing, cleaning up a connection which receives no traffic within the given time, is there a need for it to be reported on CRITICAL? I’d also expect it to be caught by ``` event_route[tcp:timeout] { xlog("L_INFO","connection $conid timeouts (unanswered keepalives)"); } ``` given that [the description](https://www.kamailio.org/docs/modules/stable/modules/tcpops.ht… of this one is `Called for connection timeouts (unanswered keepalives).`. ### Troubleshooting We don't have any way to reproduce it, we are still investigating it to figure out the cause. It happens around every 2 hours, so we think there might some some scheduled test or job running in our test system causing this. ### Additional Information * **Kamailio Version** - 5.8.3 * **Operating System**: Debian 12 AMI from the AWS Marketplace. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3995 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3995(a)github.com>

13 hours, 15 minutes

[kamailio/kamailio] Possibly adjusting the SDP parser to be more lenient towards scenarios where a stream is being removed/rejected and connection-information "c=" is only available per media (no session-wide "c=") and the removed/rejected stream omits all fields (Issue #3982)

by thomas414

### Description I encountered an issue with a specific device that is receiving a T.38 fax. The call gets established towards the device normally with inband media, then the device requests T.38 media and tries to remove the audio media via sending port 0 in the ReInvite SDP. Also it sends connection-information only on the media level and there is no "c=" on the session level. Reading through the related RFCs and the kamailio code and discussing this on the mailing list, we came to the conclusion that kamailio is doing everything correct as per RFC. Though we were wondering if it would be possible to adjust the parser to be not as strict as it is right now, and allow a missing "c=" line on the media-level if the stream is removed/rejected via port 0, since i see no sense in requiring connection information. Of course we are also in contact with the vendor to hopefully adjust on their side. Here are the related RFCs: 1. RFC8866 5.7 `A session description MUST contain either at least one "c=" line in each media description or a single "c=" line at the session level. It MAY contain a single session-level "c=" line and additional media-level "c=" line(s) per-media-description, in which case the media-level values override the session-level settings for the respective media.` 2. RFC3264 8.2 `Existing media streams are removed by creating a new SDP with the port number for that stream set to zero. The stream description MAY omit all attributes present previously, and MAY list just a single media format.` At first i was especially confused by the RFC3264 8.2 part, since it seemed correct what the device is sending, but if you read carefully and keep the wording for SDP in mind only attributes ("a=") MAY be omitted. So a "c=" line should still be in the SDP for the removed media if it's not included on the session-level. Or do you see this differently? ### Expected behavior Kamailio allows and parses the SDP when there is no session-wide "c=", a media stream is being removed via port zero and there is no "c=" for this media stream and only the remaining media streams include a "c=" line. #### Actual observed behavior Kamailio throws an error when trying to parse the SDP. #### Log Messages ``` <core> [core/parser/sdp/sdp.c:523]: parse_sdp_session(): can't find media IP in the message ``` #### SIP Traffic ``` v=0 o=xmserver 1726638425 1726638427 IN IP4 169.254.1.1 s=xmserver t=0 0 m=audio 0 RTP/AVP 8 m=image 56002 udptl t38 c=IN IP4 169.254.1.1 a=sendrecv a=T38FaxVersion:0 a=T38MaxBitRate:14400 a=T38FaxFillBitRemoval:0 a=T38FaxTranscodingMMR:0 a=T38FaxTranscodingJBIG:0 a=T38FaxRateManagement:transferredTCF a=T38FaxMaxBuffer:200 a=T38FaxMaxDatagram:72 a=T38FaxUdpEC:t38UDPRedundancy ``` ### Possible Solutions ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.8.3 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 12.2.0 ``` * **Operating System**: ``` Debian 12 Linux hostname 6.1.0-20-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.85-1 (2024-04-11) x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3982 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3982(a)github.com>

13 hours, 15 minutes

Freezing development for 6.0.x series

by Daniel-Constantin Mierla

Hello, I propose to aim freezing the development for 6.0.x series at the end of the 16th of December 2024 (Monday). New features that one wants to get in this release series have to be pushed to git repository or pull requests made for them. Afterwards usually follows a 4-6 weeks of testing till the first release 6.0.0. Unfreezing will happen earlier, after the first weeks of testing when the 6.0 branch will be created. Cheers, Daniel -- Daniel-Constantin Mierla (@ asipto.com) twitter.com/miconda -- linkedin.com/in/miconda Kamailio Consultancy, Training and Development Services -- asipto.com

5 days, 2 hours

[kamailio/kamailio] Advertise in listen directive still gives port in headers even though it's not set or set to 0 (Issue #3933)

by Evgenii Buchnev

Reopening. (https://github.com/kamailio/kamailio/issues/3932#issuecomment-2252138364) It's bug. Please see highlighted on screenshot. ![image](https://github.com/user-attachments/assets/88b9671d-d2be-4d49-8596-3e6ab3a2d294) Hey Team, Thank you for the awesome software ### Description Neither option work: `listen=... advertise some.custom.hostname.io` `listen=... advertise some.custom.hostname.io:0` to make Kamailio present only hostname(without port) in Record-Route headers, affects NAPTR/SRV. ### Troubleshooting ============ _Hostname without port - still gives port 5081 in Record-Route_ **kamailio.cfg** ... `listen=tls:KAM_LOC_IP:5081 advertise some.custom.io name "provider_socket_tls"` ... **sngrep, 200 OK for INVITE** ... `Record-Route: <sip:some.custom.io:5081;transport=tls;r2=on;lr;did=494.6e51>` ... **kamcmd corex.list_sockets** ... ``` { af: IPv4 proto: tls name: 172.17.57.164 addrlist: { addr: 172.17.57.164 } port: 5081 sockstr: tls:172.17.57.164:5081 mcast: no mhomed: no virtual: no sockname: provider_socket_tls advertise: tls:some.custom.io:0 } ``` ... ======== _Hostname with port 0 - still gives port 5081 in Record-Route_ kamailio.cfg ... `listen=tls:KAM_LOC_IP:5081 advertise some.custom.io:0 name "provider_socket_tls"` ... sngrep, 200 OK for INVITE ... `Record-Route: <sip:some.custom.io:5081;transport=tls;r2=on;lr;did=042.7721>` ... kamcmd corex.list_sockets ... ``` { af: IPv4 proto: tls name: 172.17.57.164 addrlist: { addr: 172.17.57.164 } port: 5081 sockstr: tls:172.17.57.164:5081 mcast: no mhomed: no virtual: no sockname: provider_socket_tls advertise: tls:some.custom.io:0 } ``` ... ============ _Hostname with explicit different port 8888 - gives that port 8888 in Record-Route (to confirm config works)_ kamailio.cfg ... `listen=tls:KAM_LOC_IP:5081 advertise some.custom.io:8888 name "provider_socket_tls"` ... sngrep, 200 OK for INVITE ... `Record-Route: <sip:some.custom.io:8888;transport=tls;r2=on;lr;did=dae.ac31>` ... kamcmd corex.list_sockets ... ``` { af: IPv4 proto: tls name: 172.17.57.164 addrlist: { addr: 172.17.57.164 } port: 5081 sockstr: tls:172.17.57.164:5081 mcast: no mhomed: no virtual: no sockname: provider_socket_tls advertise: tls:some.custom.io:8888 } ``` ... #### Reproduction Please see Troubleshooting section #### Debugging Data Please see Troubleshooting section #### Log Messages N/A #### SIP Traffic Please see Troubleshooting section ### Possible Solutions N/A ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.8.2 (x86_64/linux) dbe51d flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: dbe51d compiled on 07:13:22 Jul 17 2024 with gcc 12.2.0) ``` * **Operating System**: ``` [dev]root@[voiceproxy]:~# lsb_release -a No LSB modules are available. Distributor ID: Debian Description: Debian GNU/Linux 12 (bookworm) Release: 12 Codename: bookworm [dev]root@[voiceproxy]:~# uname -a Linux i-0875d7720d6152612 6.1.0-23-cloud-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.99-1 (2024-07-15) x86_64 GNU/Linux [dev]root@[voiceproxy]:~# cat /etc/*relea* ID=ec2 VERSION="20240702-1796" PRETTY_NAME="Debian GNU/Linux 12 (bookworm)" NAME="Debian GNU/Linux" VERSION_ID="12" VERSION="12 (bookworm)" VERSION_CODENAME=bookworm ID=debian HOME_URL="https://www.debian.org/" SUPPORT_URL="https://www.debian.org/support" BUG_REPORT_URL="https://bugs.debian.org/" ``` * **Might be related** : https://github.com/kamailio/kamailio/issues/1884 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3933 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3933(a)github.com>

5 days, 7 hours

[kamailio/kamailio] kamailio.cfg updates for v6.0.x series (Issue #4034)

by Daniel-Constantin Mierla

Discuss and track updates to default kamailio.cfg for v6.0.x series. If you want to add something new to or remove from kamailio.cfg, post a comment in this thread. Commits to kamailio.cfg can also reference this tracker item. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4034 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4034(a)github.com>

5 days, 8 hours

[kamailio/kamailio] ims_isc: bugfix: firstflag incorrect in isc_match_filter (PR #4018)

by Kilian Wöber

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  The function isc_match_filter uses a local variable "firstflag", to handle the case of an HSS based terminating unregistered service. In that case, the S-CSCF exchanges SAR/SAA with the HSS in order to learn the subscription data and the iFC for an unregistered user or for a PSI. The firstflag is necessary to make a distiction between the FAILURE ROUTE that is used for this case and the FAILURE ROUTE that is used for transaction failure towards the AS. The error is, the firstflag is set for the latter case, too, which leads to a wrong handling of communication errors towards the AS. This PR introduces a new function that looks for the old ISCMARK in the lumps of the stored message and hence can make a distinction between the SAR/SAA case and the AS failure case. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4018 -- Commit Summary -- * ims_isc: bugfix: firstflag incorrect in isc_match_filter -- File Changes -- M src/modules/ims_isc/ims_isc_mod.c (24) M src/modules/ims_isc/mark.c (51) M src/modules/ims_isc/mark.h (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4018.patch https://github.com/kamailio/kamailio/pull/4018.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4018 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4018(a)github.com>

1 week

[kamailio/kamailio] htable: export table create api functions (PR #4010)

by Stefan Mititelu

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Looks like htable module already exports API functions, but currently no other module uses them. Added 2 more API functions for table creation (so other modules can be able to create their own hash tables if they want to) You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4010 -- Commit Summary -- * htable: export table create api functions -- File Changes -- M src/modules/htable/api.c (10) M src/modules/htable/api.h (4) M src/modules/htable/ht_api.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4010.patch https://github.com/kamailio/kamailio/pull/4010.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4010 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4010(a)github.com>

1 week

[kamailio/kamailio] The future of internal libraries (Issue #4041)

by Daniel-Constantin Mierla

Considering that it hasn't been much activity around the internal libraries for long time, I was wondering if it still makes sense to keep them like they are or merge them in the core. Recently, during the devel meeting, I relocated a couple of them to the archive. The `lib/binrpc` (and `print`) can have the same fate, being not actually used. The srdb1 is very common and I guess it is very rare the case when a deployment is used without a module not depending on it (e.g., even if dispatcher is used with a list file, the code is still linked to this library). The `trie` library is small and `ims` is actually a set of getter functions for message attribtues/headers. The `srdb2` is not used much, but I think the right approach for it is to change the modules using it to `libsrdb1` and get rid of it completely sometime in the future. Till then the code is not big and can reside as part of the core. The benefits I see are in simplifying the build system (current makefiles and hopefully soon-to-be-merged the one based on cmake), reducing also the time to compute compile and link dependencies; getting rid of packaging complexity (same library may be needed by different modules, which, when packaged separately, the library has to be in a 3rd package, or have dependency of the other module's package -- probably now the libs are shipped with the core package). The code for libs can stay at the same location, so source code for modules doesn't need to be updated, just that they are compiled with the core, removing internal libs from makefiles. Thinking that we go for 6.0.x, clarifying the plans for this component and cleaning it, if decided so, should fit well in such version number jump. Opinions? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4041 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4041(a)github.com>

1 week, 2 days

[kamailio/kamailio] fedora 40: make[2]: --libs8: No such file or directory (Issue #4025)

by sergey-safarov

### Description During source compilation on Fedora 40 I see an error ``` [2024-11-15T10:13:57.497Z] make[3]: Entering directory '/root/rpmbuild/BUILD/kamailio-6.0.0-dev3/src/lib/srdb2' [2024-11-15T10:13:57.502Z] make[3]: 'libsrdb2.so.1.0' is up to date. [2024-11-15T10:13:57.502Z] make[3]: Leaving directory '/root/rpmbuild/BUILD/kamailio-6.0.0-dev3/src/lib/srdb2' [2024-11-15T10:13:57.504Z] LD (gcc) [M uid_uri_db.so] uid_uri_db.so [2024-11-15T10:13:57.535Z] make[2]: --libs8: No such file or directory [2024-11-15T10:13:57.569Z] make[2]: --libs8: No such file or directory [2024-11-15T10:13:57.590Z] CC (gcc) [M dialplan.so] dialplan.o [2024-11-15T10:13:58.005Z] CC (gcc) [M dialplan.so] dp_db.o [2024-11-15T10:13:58.331Z] CC (gcc) [M dialplan.so] dp_repl.o [2024-11-15T10:13:58.742Z] make[3]: Entering directory '/root/rpmbuild/BUILD/kamailio-6.0.0-dev3/src/lib/srdb1' [2024-11-15T10:13:58.748Z] make[3]: 'libsrdb1.so.1.0' is up to date. [2024-11-15T10:13:58.748Z] make[3]: Leaving directory '/root/rpmbuild/BUILD/kamailio-6.0.0-dev3/src/lib/srdb1' [2024-11-15T10:13:58.749Z] LD (gcc) [M dialplan.so] dialplan.so [2024-11-15T10:13:58.776Z] make[2]: --libs8: No such file or directory [2024-11-15T10:13:58.808Z] make[2]: --libs8: No such file or directory [2024-11-15T10:13:58.837Z] CC (gcc) [M lcr.so] hash.o [2024-11-15T10:13:58.984Z] CC (gcc) [M lcr.so] lcr_mod.o [2024-11-15T10:14:00.389Z] CC (gcc) [M lcr.so] lcr_rpc.o [2024-11-15T10:14:00.518Z] make[3]: Entering directory '/root/rpmbuild/BUILD/kamailio-6.0.0-dev3/src/lib/srdb1' [2024-11-15T10:14:00.528Z] make[3]: 'libsrdb1.so.1.0' is up to date. [2024-11-15T10:14:00.528Z] make[3]: Leaving directory '/root/rpmbuild/BUILD/kamailio-6.0.0-dev3/src/lib/srdb1' [2024-11-15T10:14:00.529Z] LD (gcc) [M lcr.so] lcr.so [2024-11-15T10:14:00.564Z] make[2]: --libs8: No such file or directory [2024-11-15T10:14:00.592Z] make[2]: --libs8: No such file or directory [2024-11-15T10:14:00.623Z] CC (gcc) [M regex.so] regex_mod.o [2024-11-15T10:14:00.952Z] LD (gcc) [M regex.so] regex.so [2024-11-15T10:14:00.997Z] CC (gcc) [M app_jsdt.so] app_jsdt_api.o [2024-11-15T10:14:01.437Z] CC (gcc) [M app_jsdt.so] app_jsdt_kemi_export.o [2024-11-15T10:14:02.089Z] CC (gcc) [M app_jsdt.so] app_jsdt_mod.o [2024-11-15T10:14:02.389Z] CC (gcc) [M app_jsdt.so] duk_module_node.o [2024-11-15T10:14:02.470Z] CC (gcc) [M app_jsdt.so] duktape.o ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4025 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4025(a)github.com>

1 week, 2 days

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2024