sr-dev October 2024

sr-dev@lists.kamailio.org

14 participants
110 discussions

git:master:b0e16a57: call_control: fix warning unused variable

by Victor Seva

Module: kamailio Branch: master Commit: b0e16a57eab4d4d4113054aa2b79452da82dd7c9 URL: https://github.com/kamailio/kamailio/commit/b0e16a57eab4d4d4113054aa2b79452… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-08T13:05:20+02:00 call_control: fix warning unused variable > Warning: call_control.c:1098:7: warning: unused variable 'param' [-Wunused-variable] > int *param; > ^ > Warning: call_control.c:1099:13: warning: unused variable 'type' [-Wunused-variable] > modparam_t type; > ^ > 2 warnings generated. --- Modified: src/modules/call_control/call_control.c --- Diff: https://github.com/kamailio/kamailio/commit/b0e16a57eab4d4d4113054aa2b79452… Patch: https://github.com/kamailio/kamailio/commit/b0e16a57eab4d4d4113054aa2b79452… --- diff --git a/src/modules/call_control/call_control.c b/src/modules/call_control/call_control.c index 41b36eeedd6..a635f107324 100644 --- a/src/modules/call_control/call_control.c +++ b/src/modules/call_control/call_control.c @@ -1095,9 +1095,6 @@ static int CallControl(struct sip_msg *msg, char *str1, char *str2) static int mod_init(void) { pv_spec_t avp_spec; - int *param; - modparam_t type; - // initialize the canonical_uri_avp structure if(canonical_uri_avp.spec.s == NULL || canonical_uri_avp.spec.len <= 0) {

2 months, 2 weeks

git:master:ce4107a6: tm: fix warning uninitialized variable

by Victor Seva

Module: kamailio Branch: master Commit: ce4107a6f654a4bc4462efb90f3cc5e8c73bf9ed URL: https://github.com/kamailio/kamailio/commit/ce4107a6f654a4bc4462efb90f3cc5e… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-08T13:05:19+02:00 tm: fix warning uninitialized variable > Warning: t_fwd.c:1919:46: warning: variable 'port' is uninitialized when used here [-Wuninitialized] > ret = forward_request_uac(p_msg, &host, port, &dst); > ^~~~ > t_fwd.c:1843:21: note: initialize the variable 'port' to silence this warning > unsigned short port; > ^ > = 0 > 1 warning generated. --- Modified: src/modules/tm/t_fwd.c --- Diff: https://github.com/kamailio/kamailio/commit/ce4107a6f654a4bc4462efb90f3cc5e… Patch: https://github.com/kamailio/kamailio/commit/ce4107a6f654a4bc4462efb90f3cc5e… --- diff --git a/src/modules/tm/t_fwd.c b/src/modules/tm/t_fwd.c index 9568b6adb1b..23e61ae818b 100644 --- a/src/modules/tm/t_fwd.c +++ b/src/modules/tm/t_fwd.c @@ -1840,7 +1840,7 @@ int t_forward_cancel(struct sip_msg *p_msg, struct proxy_l *proxy, int proto, int new_tran; struct dest_info dst; str host; - unsigned short port; + unsigned short port = 0; short comp; t = 0;

2 months, 2 weeks

git:master:9475837b: core/rand: fix -Wdeprecated-non-prototype

by Victor Seva

Module: kamailio Branch: master Commit: 9475837b209c91366e8bb40416552b02c13aaf3a URL: https://github.com/kamailio/kamailio/commit/9475837b209c91366e8bb40416552b0… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-08T13:05:19+02:00 core/rand: fix -Wdeprecated-non-prototype > Warning: core/rand/isaac/rand.c:28:6: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] > void isaac(ctx) randctx *ctx; > ^ > Warning: core/rand/isaac/rand.c:81:6: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] > void randinit(ctx, flag) randctx *ctx; --- Modified: src/core/rand/isaac/rand.c --- Diff: https://github.com/kamailio/kamailio/commit/9475837b209c91366e8bb40416552b0… Patch: https://github.com/kamailio/kamailio/commit/9475837b209c91366e8bb40416552b0… --- diff --git a/src/core/rand/isaac/rand.c b/src/core/rand/isaac/rand.c index eb917fdd34f..52d44d5eb6d 100644 --- a/src/core/rand/isaac/rand.c +++ b/src/core/rand/isaac/rand.c @@ -25,7 +25,7 @@ rand.c: By Bob Jenkins. My random number generator, ISAAC. Public Domain. *(r++) = b = ind(mm, y >> RANDSIZL) + x; \ } -void isaac(ctx) randctx *ctx; +void isaac(randctx *ctx) { register ub4 a, b, x, y, *m, *mm, *m2, *r, *mend; mm = ctx->randmem; @@ -78,8 +78,7 @@ void isaac(ctx) randctx *ctx; } /* if (flag==TRUE), then use the contents of randrsl[] to initialize mm[]. */ -void randinit(ctx, flag) randctx *ctx; -word flag; +void randinit(randctx *ctx, word flag) { word i; ub4 a, b, c, d, e, f, g, h;

2 months, 2 weeks

[kamailio/kamailio] <core> [core/mem/q_malloc.c:519]: qm_free(): BUG: freeing already freed pointer (0x7f7cd10b07d8) (Issue #3971)

by 87LuckyMan321

### Description  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) <core> [core/mem/q_malloc.c:519]: qm_free(): BUG: freeing already freed pointer (0x7f7cd10b07d8), called from core: core/xavp.c: xavp_free_unsafe(100), first free core: core/xavp.c: xavp_new_value(116) - ignoring #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` version: kamailio 5.6.4 (x86_64/linux) 0a4d88 (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3971 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3971(a)github.com>

2 months, 2 weeks

[kamailio/kamailio] Build for el9 without legacy geoip (PR #3886)

by Oded Arbel

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #3592 #### Description The `kamailio-geoip` RPM sub package currently builds both the `geoip` module - based on [the old and out of support MaxMind GeoIP library](https://github.com/maxmind/geoip-api-c) - and the newer `geoip2` module - based on [the currently supported `libmaxminddb`](https://github.com/maxmind/libmaxminddb). The old GeoIP C library had its end of support date at May 2022 but for a while was still shipped for many distributions. At this point though, the EPEL repository that shipped the GeoIP library for RHEL-based operating systems, has removed it from their repositories for "Enterprise Linux 9": ![Screenshot_20240620_144233](https://github.com/kamailio/kamailio/assets/381782/bb1f2481-57f7-48af-b0f1-0ba1c14a3042) Therefor builds using the bundled spec file fail on EL9 installations. The suggested change is to add an RPM build option `--with geoip2` that when specified will build just the `geoip2` module for the `kamailio-geoip` RPM subpackage. This build option is not enabled by default, unless the build is running on a RHEL 9 based OS - in which case it is set as the default, because otherwise trivial builds break. To revert to the older behavior in RHEL 9 based OSs (and assuming you have the required unsupported library installed correctly) one will need to set both `--without geoip2 --with geoip`. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3886 -- Commit Summary -- * packaging: RPM build option to build just the geoip2 module * packaging: make 'with geoip2' the default behavior for EL9 -- File Changes -- M pkg/kamailio/obs/kamailio.spec (36) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3886.patch https://github.com/kamailio/kamailio/pull/3886.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3886 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3886(a)github.com>

2 months, 2 weeks

[kamailio/kamailio] IMS DB: Adding i-cscf database/tables under utils/kamctl/mysql (orig. from misc/examples/ims/icscf.sql) (PR #3876)

by markusmonka

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Adding sqlfile ims i-cscf to utils/kamctl/mysql copied from misc/examples/ims/icscf so that sql file will be automatically included in kamailio-mysql-module packages in the future You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3876 -- Commit Summary -- * IMS DB: Adding i-cscf database/tables under utils/kamctl/mysql -- File Changes -- A utils/kamctl/mysql/ims-icscf.sql (94) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3876.patch https://github.com/kamailio/kamailio/pull/3876.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3876 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3876(a)github.com>

2 months, 2 weeks

[kamailio/kamailio] relay to voip provider / sip trunk / path? (Issue #3990)

by gentoosys

hi. I am using https://github.com/havfo/WEBRTC-to-SIP to have a web sipcaller. it uses kamailio + rtpengine + web sipcaller (jssip) right now it is working using internal account and can call to another sip. But I need to use websipcaller to call to voip provider. I tried to register on my voip provider, and use just outbound websocket proxy, but it not working giving 401 the config I am using is https://github.com/havfo/WEBRTC-to-SIP/blob/master/etc/kamailio/kamailio.cfg Please help adopt it to relay anything to external sip provider. I don't know what I need, relay, sip trunk or path module. kamailio configs are very hard for me to understand. So I need it just as websocket proxy to my voip provider, that doesn't support websocket. thanks! -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3990 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3990(a)github.com>

2 months, 2 weeks

[kamailio/kamailio] dialog: Remove dlg_flag docs (PR #3975)

by Bastian Triller

Related to #3961   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3975 -- Commit Summary -- * dialog: Remove dlg_flag docs -- File Changes -- M src/modules/dialog/dlg_handlers.c (2) M src/modules/dialog/doc/dialog_admin.xml (16) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3975.patch https://github.com/kamailio/kamailio/pull/3975.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3975 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3975(a)github.com>

2 months, 2 weeks

git:master:66fe6eb7: dialog: Remove dlg_flag docs

by Xenofon Karamanos

Module: kamailio Branch: master Commit: 66fe6eb71e58a02222d1a2fb00f9a0cdb863134c URL: https://github.com/kamailio/kamailio/commit/66fe6eb71e58a02222d1a2fb00f9a0c… Author: Bastian Triller <bastian.triller(a)gmail.com> Committer: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Date: 2024-10-02T10:49:05Z dialog: Remove dlg_flag docs Related to #3961 --- Modified: src/modules/dialog/dlg_handlers.c --- Diff: https://github.com/kamailio/kamailio/commit/66fe6eb71e58a02222d1a2fb00f9a0c… Patch: https://github.com/kamailio/kamailio/commit/66fe6eb71e58a02222d1a2fb00f9a0c… --- diff --git a/src/modules/dialog/dlg_handlers.c b/src/modules/dialog/dlg_handlers.c index 7e48116a2b9..ee14ef14ca3 100644 --- a/src/modules/dialog/dlg_handlers.c +++ b/src/modules/dialog/dlg_handlers.c @@ -101,10 +101,10 @@ int dlg_set_tm_waitack(tm_cell_t *t, dlg_cell_t *dlg); /*! * \brief Initialize the dialog handlers * \param rr_param_p added record-route parameter - * \param dlg_flag_p dialog flag * \param timeout_avp_p AVP for timeout setting * \param default_timeout_p default timeout * \param seq_match_mode_p matching mode + * \param keep_proxy_rr_p keep proxy's record-route mode */ void init_dlg_handlers(char *rr_param_p, pv_spec_t *timeout_avp_p, int default_timeout_p, int seq_match_mode_p, int keep_proxy_rr_p)

2 months, 2 weeks

[kamailio/kamailio] KSR.dispatcher.ds_is_from_list is returning always true (Issue #3988)

by iliesh

### Description I'm trying to check if the incoming message is from the dispatcher hosts using KEMI function ds_is_from_list from a lua script: ``` if KSR.dispatcher.ds_is_from_list("-1", "2") then KSR.info("Dispatcher List \n"); return "list" end ``` I'm getting always true if when the source IP of the request is from a different network: ``` /usr/local/sbin/kamcmd dispatcher.list { NRSETS: 1 RECORDS: { SET: { ID: 1 TARGETS: { DEST: { URI: sip:127.0.0.1:5060 FLAGS: AX PRIORITY: 0 LATENCY: { AVG: 0 STD: 0 EST: 0 MAX: 0 TIMEOUT: 0 } } } } } } ``` SIP Request: ``` [info] [sipexer.go:1578] main.SIPExerDialogLoop(): local socket address: 172.16.22.12:45379 (udp) [info] [sipexer.go:1579] main.SIPExerDialogLoop(): local via address: 172.16.22.12:45379 [info] [sipexer.go:1580] main.SIPExerDialogLoop(): sending to udp 192.168.1.1:5060: [[--- OPTIONS sip:192.168.1.1:5060 SIP/2.0 Via: SIP/2.0/UDP 172.16.22.12:45379;rport;branch=z9hG4bKSG.70e3db71-1902-40aa-898b-ba582eefb784 From: <sip:alice@localhost>;tag=4f0ad3f3-1008-49dd-8177-7913ab12cf38 To: <sip:bob@localhost> Call-ID: 4f538d14-e8e4-495b-818a-c595f4457585 CSeq: 977235 OPTIONS Date: Tue, 01 Oct 2024 10:51:14 IST User-Agent: SIPExer v1.1.0 Max-Forwards: 10 Content-Length: 0 ``` Works ok when I'm using this function from the default configuration file: ``` if (ds_is_from_list("-1", "2")) { xlogl("L_INFO","Dispatcher List\n"); exit; } ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.8.3 (x86_64/linux) ab3530-dirty ``` * **Operating System**: ``` 5.14.0-508.el9.x86_64 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3988 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3988(a)github.com>

2 months, 3 weeks

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2024