sr-dev January 2024

sr-dev@lists.kamailio.org

19 participants
311 discussions

[kamailio/kamailio] github: [skip ci]: bump wolletd/clang-format-checker from 1.10 to 1.11 (PR #3732)

by dependabot[bot]

Bumps [wolletd/clang-format-checker](https://github.com/wolletd/clang-format-check… from 1.10 to 1.11. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/wolletd/clang-format-checker/releases"&g… releases</a>.</em></p> <blockquote> <h2>Version 1.11</h2> <p>The action again works without <code>actions/checkout</code> before and checks out the repository itself if not present to use the <code>.clang-format</code> file of the project.</p> <p>Also add clang-format 16 and 17.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/WolleTD/clang-format-checker/commit/c4a732902… Merge pull request <a href="https://redirect.github.com/wolletd/clang-format-checker/issues/… from WolleTD/checkout</li> <li><a href="https://github.com/WolleTD/clang-format-checker/commit/2e3de0eab… checkout source when no repository is present</li> <li><a href="https://github.com/WolleTD/clang-format-checker/commit/95b84cca8… test: rename local branch</li> <li><a href="https://github.com/WolleTD/clang-format-checker/commit/d14c3190c… Merge pull request <a href="https://redirect.github.com/wolletd/clang-format-checker/issues/… from WolleTD/llvm17</li> <li><a href="https://github.com/WolleTD/clang-format-checker/commit/74192a346… Add clang-format 16 and 17</li> <li>See full diff in <a href="https://github.com/wolletd/clang-format-checker/compare/v1.10...… view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?d… Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3732 -- Commit Summary -- * github: [skip ci]: bump wolletd/clang-format-checker from 1.10 to 1.11 -- File Changes -- M .github/workflows/pull_request.yml (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3732.patch https://github.com/kamailio/kamailio/pull/3732.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3732 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3732(a)github.com>

10 months, 3 weeks

git:master:8e2a1a36: github: [skip ci]: bump wolletd/clang-format-checker from 1.10 to 1.11

by Victor Seva

Module: kamailio Branch: master Commit: 8e2a1a36f14a18834d1a98e8483b4595a533abff URL: https://github.com/kamailio/kamailio/commit/8e2a1a36f14a18834d1a98e8483b459… Author: dependabot[bot] <49699333+dependabot[bot](a)users.noreply.github.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-01-30T07:41:30+01:00 github: [skip ci]: bump wolletd/clang-format-checker from 1.10 to 1.11 Bumps [wolletd/clang-format-checker](https://github.com/wolletd/clang-format-check… from 1.10 to 1.11. - [Release notes](https://github.com/wolletd/clang-format-checker/releases) - [Commits](https://github.com/wolletd/clang-format-checker/compare/v1.10...v1… --- updated-dependencies: - dependency-name: wolletd/clang-format-checker dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support(a)github.com> --- Modified: .github/workflows/pull_request.yml --- Diff: https://github.com/kamailio/kamailio/commit/8e2a1a36f14a18834d1a98e8483b459… Patch: https://github.com/kamailio/kamailio/commit/8e2a1a36f14a18834d1a98e8483b459… --- diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index e17814b8481..543f7c05238 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -13,7 +13,7 @@ jobs: contents: read # to fetch code (actions/checkout) steps: - uses: actions/checkout@v4 - - uses: wolletd/clang-format-checker(a)v1.10 + - uses: wolletd/clang-format-checker(a)v1.11 with: target-ref: master build:

10 months, 3 weeks

git:master:520b9dce: github: [skip ci]: bump ammaraskar/gcc-problem-matcher

by Victor Seva

Module: kamailio Branch: master Commit: 520b9dce03d695cd1d95432e6bf52ed47d046cd4 URL: https://github.com/kamailio/kamailio/commit/520b9dce03d695cd1d95432e6bf52ed… Author: dependabot[bot] <49699333+dependabot[bot](a)users.noreply.github.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-01-30T07:40:57+01:00 github: [skip ci]: bump ammaraskar/gcc-problem-matcher Bumps [ammaraskar/gcc-problem-matcher](https://github.com/ammaraskar/gcc-problem-m… from 0.2.0 to 0.3.0. - [Release notes](https://github.com/ammaraskar/gcc-problem-matcher/releases) - [Commits](https://github.com/ammaraskar/gcc-problem-matcher/compare/0.2.0...… --- updated-dependencies: - dependency-name: ammaraskar/gcc-problem-matcher dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support(a)github.com> --- Modified: .github/workflows/main.yml Modified: .github/workflows/pull_request.yml --- Diff: https://github.com/kamailio/kamailio/commit/520b9dce03d695cd1d95432e6bf52ed… Patch: https://github.com/kamailio/kamailio/commit/520b9dce03d695cd1d95432e6bf52ed… --- diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 86b05df1822..8b7ae03a271 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -34,7 +34,7 @@ jobs: compilier: clang steps: - uses: actions/checkout@v4 - - uses: ammaraskar/gcc-problem-matcher(a)0.2.0 + - uses: ammaraskar/gcc-problem-matcher(a)0.3.0 - name: build run: | cd /code diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index cda04d04389..e17814b8481 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -39,7 +39,7 @@ jobs: compilier: clang steps: - uses: actions/checkout@v4 - - uses: ammaraskar/gcc-problem-matcher(a)0.2.0 + - uses: ammaraskar/gcc-problem-matcher(a)0.3.0 - name: build run: | cd /code

10 months, 3 weeks

[kamailio/kamailio] github: [skip ci]: bump ammaraskar/gcc-problem-matcher from 0.2.0 to 0.3.0 (PR #3733)

by dependabot[bot]

Bumps [ammaraskar/gcc-problem-matcher](https://github.com/ammaraskar/gcc-problem-m… from 0.2.0 to 0.3.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ammaraskar/gcc-problem-matcher/releases"… releases</a>.</em></p> <blockquote> <h2>Update for node16 deprecation</h2> <p>Github has deprecated node16 actions, this update fixes the deprecation warning emitted. See <a href="https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/">https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ammaraskar/gcc-problem-matcher/commit/0f9c86f… Update to use node20, fixes <a href="https://redirect.github.com/ammaraskar/gcc-problem-matcher/issue… <li>See full diff in <a href="https://github.com/ammaraskar/gcc-problem-matcher/compare/0.2.0.… view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?d… Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3733 -- Commit Summary -- * github: [skip ci]: bump ammaraskar/gcc-problem-matcher -- File Changes -- M .github/workflows/main.yml (2) M .github/workflows/pull_request.yml (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3733.patch https://github.com/kamailio/kamailio/pull/3733.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3733 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3733(a)github.com>

10 months, 3 weeks

[kamailio/kamailio] TLS: Recent fixes for for OpenSSL 3.X are causing consistent startup failures when unixodbc is used (Issue #3727)

by kdanderso

### Description Kamailio fails to start after recent changes were made to improve support for OpenSSL 3.X. The failure occurs for both OpenSSL 3.X and OpenSSL 1.1.X, and are the same as failures I had been seeing on previous Kamailio versions when using OpenSSL 3.X. These errors were not occurring for OpenSSL 1.1.X prior to commits on Jan 4, 2024. My configuration is using the unixodbc module to communicate with a Microsoft SQL Server database. Furthermore, the dispatcher module is configured to use the database. With this configuration, Kamailio always fails at startup. It may log a "freeing already free pointer bug" or sometimes indicates pointer corruption. In either case, it fails to connect to the database. #### Reproduction Start Kamailio with configuration files similar to the following. For the log file shown below, Kamailio was started with "kamailio -dd -E --atexit=no" [kamailio.txt](https://github.com/kamailio/kamailio/files/14068346/kamailio.… [tls.txt](https://github.com/kamailio/kamailio/files/14068347/tls.txt) #### Log Messages [kamailio.log](https://github.com/kamailio/kamailio/files/14068278/kamailio.… #### SIP Traffic None. Problem occurs during initialization. ### Additional Information * **Kamailio Version** - output of `kamailio -v` version: kamailio 5.8.0-dev2 (x86_64/linux) 4db5d7-dirty flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 4db5d7 -dirty compiled on 17:44:29 Jan 26 2024 with gcc 9.4.0 * **Operating System**: Distributor ID: Ubuntu Description: Ubuntu 20.04.6 LTS Release: 20.04 Codename: focal Kernel: 5.4.0-170-generic (Similar behavior is seen on Ubuntu 22.04 using OpenSSL 3.X.) -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3727 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3727(a)github.com>

10 months, 3 weeks

[kamailio/kamailio] db_postgres: init libssl in a thread (PR #3730)

by space88man

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [X] PR should be backported to stable branches - [ ] Tested changes locally - [X] Related to issue #3727 #### Description PostgreSQL may be configured to use SSL: init in a thread You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3730 -- Commit Summary -- * db_postgres: init libssl in a thread -- File Changes -- M src/modules/db_postgres/km_dbase.c (17) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3730.patch https://github.com/kamailio/kamailio/pull/3730.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3730 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3730(a)github.com>

10 months, 3 weeks

git:master:3426b153: db_postgres: init libssl in a thread

by S-P Chan

Module: kamailio Branch: master Commit: 3426b153d02d9d8d3e909eff9d18cb14108072ca URL: https://github.com/kamailio/kamailio/commit/3426b153d02d9d8d3e909eff9d18cb1… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-01-30T06:53:10+08:00 db_postgres: init libssl in a thread --- Modified: src/modules/db_postgres/km_dbase.c --- Diff: https://github.com/kamailio/kamailio/commit/3426b153d02d9d8d3e909eff9d18cb1… Patch: https://github.com/kamailio/kamailio/commit/3426b153d02d9d8d3e909eff9d18cb1… --- diff --git a/src/modules/db_postgres/km_dbase.c b/src/modules/db_postgres/km_dbase.c index 02cb5c421d5..065b71f0709 100644 --- a/src/modules/db_postgres/km_dbase.c +++ b/src/modules/db_postgres/km_dbase.c @@ -34,6 +34,7 @@ #include <string.h> #include <stdio.h> #include <stdlib.h> +#include <pthread.h> #include "../../core/dprint.h" #include "../../core/mem/mem.h" #include "../../lib/srdb1/db.h" @@ -108,24 +109,57 @@ static void db_postgres_free_query(const db1_con_t *_con); * \param _url URL of the database that should be opened * \return database connection on success, NULL on error * \note this function must be called prior to any database functions + * + * Init libssl in a thread */ -db1_con_t *db_postgres_init(const str *_url) +static db1_con_t *db_postgres_init0(const str *_url) { return db_do_init(_url, (void *)db_postgres_new_connection); } +db1_con_t *db_postgres_init(const str *_url) +{ + pthread_t tid; + db1_con_t *ret; + + pthread_create( + &tid, NULL, (void *(*)(void *))db_postgres_init0, (void *)_url); + pthread_join(tid, (void **)&ret); + + return ret; +} /*! * \brief Initialize database for future queries, specify pooling * \param _url URL of the database that should be opened * \param pooling whether or not to use a pooled connection * \return database connection on success, NULL on error * \note this function must be called prior to any database functions + * + * Init libssl in thread */ -db1_con_t *db_postgres_init2(const str *_url, db_pooling_t pooling) +struct _thread_args +{ + const str *_url; + db_pooling_t pooling; +}; + +static db1_con_t *_db_postgres_init2(struct _thread_args *args) { - return db_do_init2(_url, (void *)db_postgres_new_connection, pooling); + return db_do_init2( + args->_url, (void *)db_postgres_new_connection, args->pooling); } +db1_con_t *db_postgres_init2(const str *_url, db_pooling_t pooling) +{ + pthread_t tid; + db1_con_t *ret; + + pthread_create(&tid, NULL, (void *(*)(void *))_db_postgres_init2, + (void *)&(struct _thread_args){_url, pooling}); + pthread_join(tid, (void **)&ret); + + return ret; +} /*! * \brief Close database when the database is no longer needed * \param _h closed connection, as returned from db_postgres_init

10 months, 3 weeks

[kamailio/kamailio] db_mysql: init libssl in a thread (PR #3729)

by space88man

#### Pre-Submission Checklist - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [X] PR should be backported to stable branches - [ ] Tested changes locally - [X] Related to issue #3727 #### Description `mod_init()` in configuration can initialise libssl in rank 0(thread#1). User report is with regard to using `db_unixodbc`; however the same errors can be reproduced with `db_mysql` replacing `db_unixodbc`. This PR inits libssl in a separate thread. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3729 -- Commit Summary -- * db_mysql: init libssl in a thread -- File Changes -- M src/modules/db_mysql/km_dbase.c (17) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3729.patch https://github.com/kamailio/kamailio/pull/3729.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3729 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3729(a)github.com>

10 months, 3 weeks

git:master:5dffb934: db_mysql: init libssl in a thread

by S-P Chan

Module: kamailio Branch: master Commit: 5dffb934a2f7f986fdc09e433833991c54612646 URL: https://github.com/kamailio/kamailio/commit/5dffb934a2f7f986fdc09e433833991… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-01-30T06:51:36+08:00 db_mysql: init libssl in a thread --- Modified: src/modules/db_mysql/km_dbase.c --- Diff: https://github.com/kamailio/kamailio/commit/5dffb934a2f7f986fdc09e433833991… Patch: https://github.com/kamailio/kamailio/commit/5dffb934a2f7f986fdc09e433833991… --- diff --git a/src/modules/db_mysql/km_dbase.c b/src/modules/db_mysql/km_dbase.c index 577f3dc798b..721ba8aa6cf 100644 --- a/src/modules/db_mysql/km_dbase.c +++ b/src/modules/db_mysql/km_dbase.c @@ -34,6 +34,7 @@ #include <stdio.h> #include <string.h> #include <mysql.h> +#include <pthread.h> #include <errmsg.h> #include "../../core/mem/mem.h" #include "../../core/dprint.h" @@ -197,8 +198,10 @@ static char *db_mysql_tquote = "`"; * No function should be called before this * \param _url URL used for initialization * \return zero on success, negative value on failure + * + * Init libssl in a thread */ -db1_con_t *db_mysql_init(const str *_url) +static db1_con_t *db_mysql_init0(const str *_url) { db1_con_t *c; c = db_do_init(_url, (void *)db_mysql_new_connection); @@ -208,6 +211,16 @@ db1_con_t *db_mysql_init(const str *_url) } +db1_con_t *db_mysql_init(const str *_url) +{ + pthread_t tid; + db1_con_t *ret; + + pthread_create(&tid, NULL, (void *(*)(void *))db_mysql_init0, (void *)_url); + pthread_join(tid, (void **)&ret); + + return ret; +} /** * Shut down the database module. * No function should be called after this

10 months, 3 weeks

[kamailio/kamailio] db_unixodbc: init libssl in a thread (PR #3728)

by space88man

- [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [X] PR should be backported to stable branches - [X] Tested changes locally - [X ] Related to issue #3727 #### Description The bug report kamailio configuration is using dispatcher + unixodbc and the database driver (tested with MariaDB ODBC, user reports with MS SQL Server(not tested)) inits libssl in rank 0(thread 1). This PR will init in a thread. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3728 -- Commit Summary -- * db_unixodbc: init libssl in a thread -- File Changes -- M src/modules/db_unixodbc/dbase.c (17) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3728.patch https://github.com/kamailio/kamailio/pull/3728.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3728 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3728(a)github.com>

10 months, 3 weeks

← Newer
1
...
4
5
6
7
8
9
10
...
32
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2024