sr-dev September 2023

sr-dev@lists.kamailio.org

17 participants
299 discussions

SIP to websocket routing problems
by Centelles Martin, Joel 22 Sep '23

22 Sep '23

Hello everybody, we've a kamailio setup as a SIP proxy/SBC that we use to route incoming request into our system . We also need to support web browser clients, so, we properly enabled and configured the websocket module according to its module's documentation: https://www.kamailio.org/docs/modules/devel/modules/websocket.html#idm37 This solution is working fine for both TLS SIP clients and incoming websocket INVITEs but, when we try to route a SIP call from a SIP client to a registered websocket client, our SBC is unable to find the proper socket connection even if the proper IP, port and transport is received in the Request-URI or the Route header: Received request URI looks like: * INVITE sip:b80snduq@185.41.96.32:54510;transport=wss SIP/2.0 while the Route header looks like: * Route: <sip:10.122.144.132:5061;transport=tls;lr;received=sip:185.41.96.32:54510%3Btransport%3Dws> My only guess is that the transport parameter, for some reason, is not being properly parsed but I've been debugging core/forward.c with no luck as it seems that the request is not even being forwarded. Any suggestion about what code I should look into? Is the destination IP, port and protocol usually set in the core parsing or might this be a nathelper module error? Thank you very much in advance for your help. BR, Joel.

1 0

git:master:90cb4c8a: app_python: use global parameter for request route callback
by Daniel-Constantin Mierla 22 Sep '23

22 Sep '23

Module: kamailio Branch: master Commit: 90cb4c8a3376b967960a2185b3acc669734f5e33 URL: https://github.com/kamailio/kamailio/commit/90cb4c8a3376b967960a2185b3acc66… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-09-22T14:11:04+02:00 app_python: use global parameter for request route callback --- Modified: src/modules/app_python/apy_kemi.c --- Diff: https://github.com/kamailio/kamailio/commit/90cb4c8a3376b967960a2185b3acc66… Patch: https://github.com/kamailio/kamailio/commit/90cb4c8a3376b967960a2185b3acc66… --- diff --git a/src/modules/app_python/apy_kemi.c b/src/modules/app_python/apy_kemi.c index d163a792c16..c9addc7600a 100644 --- a/src/modules/app_python/apy_kemi.c +++ b/src/modules/app_python/apy_kemi.c @@ -60,7 +60,7 @@ int sr_kemi_config_engine_python( ret = apy_exec( msg, rname->s, (rparam && rparam->s) ? rparam->s : NULL, 0); } else { - ret = apy_exec(msg, "ksr_request_route", NULL, 1); + ret = apy_exec(msg, kemi_request_route_callback.s, NULL, 1); } } else if(rtype == CORE_ONREPLY_ROUTE) { if(kemi_reply_route_callback.len > 0) {

1 0

Change in mailing list configuration related to DMARC spam filtering
by Henning Westerholt 22 Sep '23

22 Sep '23

Hello, due to some changes from certain cloud infrastructure provider related to spam filtering with DMARC, we need to change the list manager "mailman" configuration for the following lists: * sr-users * sr-user-es * sr-dev * business * sr-docs * kamailio-announce * the administrative mailing list The change will impact the "From" that is displayed in your email program. Without that change large e-mail providers (Gmail, Microsoft O365) will reject messages from a sender with certain strict DMARC policy. This is already affecting several people on the lists (for example with GitHub notice mails), but over time the problem will certainly increase. Regarding the technical change: We will munge the From: header so it doesn't contain the domain that triggers the DMARC rejection. Essentially, the Mailman list takes ownership of the message and injects its own address into the From: header. This can affect reply-to-sender, although we add the original From: address in the Reply-To: header (or sometimes the Cc: header) to reduce the impact of this. We plan to do this for all emails unconditionally, regardless of their sender DMARC policy, to have an identical behaviour for all users. Please refer to this [1] page for more details. For a general description of DMARC refer to this page [2]. This change should have not a big impact for you, but some users might need to adapt some mail filters. Therefore, we would like to gather feedback on that change from you. We expect that the most visible change is that It will be not possible anymore to just reply by e-mail to mails from GitHub and have them "automatically" added to the discussed issue. This feature was so far used rarely and only from a few people. We plan to implement this change by the end of this week, when its done it will be also shortly announced. Best regards, Henning Westerholt [1] https://wiki.list.org/DEV/DMARC [2] https://dmarc.org/overview/ -- Henning Westerholt - https://skalatan.de/blog/ Kamailio services - https://gilawa.com<https://gilawa.com/>

1 1

git:master:eb3895ad: app_python3: use PyErr_Clear() in case of errors
by Daniel-Constantin Mierla 21 Sep '23

21 Sep '23

Module: kamailio Branch: master Commit: eb3895ad2bf666f738ce94ee35ffb9cbfa62d867 URL: https://github.com/kamailio/kamailio/commit/eb3895ad2bf666f738ce94ee35ffb9c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-09-21T15:11:34+02:00 app_python3: use PyErr_Clear() in case of errors --- Modified: src/modules/app_python3/python_exec.c --- Diff: https://github.com/kamailio/kamailio/commit/eb3895ad2bf666f738ce94ee35ffb9c… Patch: https://github.com/kamailio/kamailio/commit/eb3895ad2bf666f738ce94ee35ffb9c… --- diff --git a/src/modules/app_python3/python_exec.c b/src/modules/app_python3/python_exec.c index f57a876dcf7..beab9a978b5 100644 --- a/src/modules/app_python3/python_exec.c +++ b/src/modules/app_python3/python_exec.c @@ -71,6 +71,9 @@ int apy_exec(sip_msg_t *_msg, char *fname, char *fparam, int emode) PyGILState_STATE gstate; int locked = 0; + /* clear error state */ + PyErr_Clear(); + if(lock_try(_sr_python_reload_lock) == 0) { if(_sr_python_reload_version && *_sr_python_reload_version != _sr_python_local_version) { @@ -92,11 +95,13 @@ int apy_exec(sip_msg_t *_msg, char *fname, char *fparam, int emode) pFunc = PyObject_GetAttrString(_sr_apy_handler_obj, fname); if(pFunc == NULL || !PyCallable_Check(pFunc)) { if(emode == 1) { - LM_ERR("%s not found or is not callable\n", fname); + LM_ERR("%s not found or is not callable (%p)\n", fname, pFunc); } else { - LM_DBG("%s not found or is not callable\n", fname); + LM_DBG("%s not found or is not callable (%p)\n", fname, pFunc); + } + if(pFunc) { + Py_XDECREF(pFunc); } - Py_XDECREF(pFunc); _sr_apy_env.msg = bmsg; if(emode == 1) { goto err; @@ -161,6 +166,8 @@ int apy_exec(sip_msg_t *_msg, char *fname, char *fparam, int emode) Py_DECREF(pResult); _sr_apy_env.msg = bmsg; err: + /* clear error state */ + PyErr_Clear(); PY_GIL_RELEASE; LOCK_RELEASE; return rval;

1 0

git:master:daf0d172: app_python3: use global parameter for request route callback
by Daniel-Constantin Mierla 21 Sep '23

21 Sep '23

Module: kamailio Branch: master Commit: daf0d1722e01b5d1a819a7045f8c3347a948144e URL: https://github.com/kamailio/kamailio/commit/daf0d1722e01b5d1a819a7045f8c334… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-09-21T15:03:52+02:00 app_python3: use global parameter for request route callback --- Modified: src/modules/app_python3/apy_kemi.c --- Diff: https://github.com/kamailio/kamailio/commit/daf0d1722e01b5d1a819a7045f8c334… Patch: https://github.com/kamailio/kamailio/commit/daf0d1722e01b5d1a819a7045f8c334… --- diff --git a/src/modules/app_python3/apy_kemi.c b/src/modules/app_python3/apy_kemi.c index a2ca3e0693d..339d505cdda 100644 --- a/src/modules/app_python3/apy_kemi.c +++ b/src/modules/app_python3/apy_kemi.c @@ -63,7 +63,7 @@ int sr_kemi_config_engine_python( ret = apy_exec( msg, rname->s, (rparam && rparam->s) ? rparam->s : NULL, 0); } else { - ret = apy_exec(msg, "ksr_request_route", NULL, 1); + ret = apy_exec(msg, kemi_request_route_callback.s, NULL, 1); } } else if(rtype == CORE_ONREPLY_ROUTE) { if(kemi_reply_route_callback.len > 0) {

1 0

git:master:e44f8cb0: app_python3s: use global parameter for request route callback
by Daniel-Constantin Mierla 21 Sep '23

21 Sep '23

Module: kamailio Branch: master Commit: e44f8cb0bd217cc9a9d619ae031cfeb9933fc582 URL: https://github.com/kamailio/kamailio/commit/e44f8cb0bd217cc9a9d619ae031cfeb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-09-21T14:59:14+02:00 app_python3s: use global parameter for request route callback --- Modified: src/modules/app_python3s/apy3s_kemi.c --- Diff: https://github.com/kamailio/kamailio/commit/e44f8cb0bd217cc9a9d619ae031cfeb… Patch: https://github.com/kamailio/kamailio/commit/e44f8cb0bd217cc9a9d619ae031cfeb… --- diff --git a/src/modules/app_python3s/apy3s_kemi.c b/src/modules/app_python3s/apy3s_kemi.c index b5041bba4ef..38c67b9e1d5 100644 --- a/src/modules/app_python3s/apy3s_kemi.c +++ b/src/modules/app_python3s/apy3s_kemi.c @@ -182,7 +182,7 @@ int sr_kemi_config_engine_python( ret = apy3s_exec_func( msg, rname->s, (rparam && rparam->s) ? rparam->s : NULL, 0); } else { - ret = apy3s_exec_func(msg, "ksr_request_route", NULL, 1); + ret = apy3s_exec_func(msg, kemi_request_route_callback.s, NULL, 1); } } else if(rtype == CORE_ONREPLY_ROUTE) { if(kemi_reply_route_callback.len > 0) {

1 0

git:master:be39bc8f: app_python3s: use PyErr_Clear() in case of errors
by Daniel-Constantin Mierla 21 Sep '23

21 Sep '23

Module: kamailio Branch: master Commit: be39bc8fd67c38f6a2b9d07047bb990a1ffacf77 URL: https://github.com/kamailio/kamailio/commit/be39bc8fd67c38f6a2b9d07047bb990… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-09-21T14:56:25+02:00 app_python3s: use PyErr_Clear() in case of errors --- Modified: src/modules/app_python3s/apy3s_kemi.c --- Diff: https://github.com/kamailio/kamailio/commit/be39bc8fd67c38f6a2b9d07047bb990… Patch: https://github.com/kamailio/kamailio/commit/be39bc8fd67c38f6a2b9d07047bb990… --- diff --git a/src/modules/app_python3s/apy3s_kemi.c b/src/modules/app_python3s/apy3s_kemi.c index 9130a84f9fa..b5041bba4ef 100644 --- a/src/modules/app_python3s/apy3s_kemi.c +++ b/src/modules/app_python3s/apy3s_kemi.c @@ -76,6 +76,9 @@ int apy3s_exec_func(sip_msg_t *_msg, char *fname, char *fparam, int emode) return -1; } + /* clear error state */ + PyErr_Clear(); + if(lock_try(_sr_python_reload_lock) == 0) { if(_sr_python_reload_version && *_sr_python_reload_version != _sr_python_local_version) { @@ -98,11 +101,13 @@ int apy3s_exec_func(sip_msg_t *_msg, char *fname, char *fparam, int emode) if(pFunc == NULL || !PyCallable_Check(pFunc)) { if(emode == 1) { - LM_ERR("%s not found or is not callable\n", fname); + LM_ERR("%s not found or is not callable (%p)\n", fname, pFunc); } else { - LM_DBG("%s not found or is not callable\n", fname); + LM_DBG("%s not found or is not callable (%p)\n", fname, pFunc); + } + if(pFunc) { + Py_XDECREF(pFunc); } - Py_XDECREF(pFunc); _sr_apy_env.msg = bmsg; if(emode == 1) { goto error; @@ -157,6 +162,8 @@ int apy3s_exec_func(sip_msg_t *_msg, char *fname, char *fparam, int emode) if(locked) { lock_release(_sr_python_reload_lock); } + /* clear error state */ + PyErr_Clear(); return rval; }

1 0

git:master:7e376682: app_lua: proper global parameter for request route callback function
by Daniel-Constantin Mierla 21 Sep '23

21 Sep '23

Module: kamailio Branch: master Commit: 7e37668208d49cc529bfb920db29e71343b44d8f URL: https://github.com/kamailio/kamailio/commit/7e37668208d49cc529bfb920db29e71… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-09-21T14:40:08+02:00 app_lua: proper global parameter for request route callback function - fix of previous commit --- Modified: src/modules/app_lua/app_lua_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/7e37668208d49cc529bfb920db29e71… Patch: https://github.com/kamailio/kamailio/commit/7e37668208d49cc529bfb920db29e71… --- diff --git a/src/modules/app_lua/app_lua_mod.c b/src/modules/app_lua/app_lua_mod.c index dc1b4184d3b..5a554f03aba 100644 --- a/src/modules/app_lua/app_lua_mod.c +++ b/src/modules/app_lua/app_lua_mod.c @@ -111,7 +111,7 @@ int sr_kemi_config_engine_lua( (rparam && rparam->s) ? rparam->s : NULL, NULL, NULL, 0); } else { ret = app_lua_run_ex( - msg, kemi_reply_route_callback.s, NULL, NULL, NULL, 1); + msg, kemi_request_route_callback.s, NULL, NULL, NULL, 1); } } else if(rtype == CORE_ONREPLY_ROUTE) { if(kemi_reply_route_callback.len > 0) {

1 0

[kamailio/kamailio] Support to get environment variable (Issue #3558)
by yamatoyosuke 21 Sep '23

21 Sep '23

Hi I'm aware that to get environment variable we can use `$env(varname)` however this require to load pv module first, eg: below: ``` loadmodule "pv" #!substdef "/DBRWUSER/$env(DBRWUSER)/g" #!substdef "/DBRWPW/$env(DBRWPW)/g" ``` in some case we need to get variable at the beginning (or convenient way or modern application), example: ``` alias=$getenv(DOMAIN) listen="$getenv(PRIVATE_IP)" advertise "$getenv(PUBLIC_IP)" ``` ** $getenv just name of new function is similar to $env but not require pv -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3558 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3558(a)github.com>

2 3

[kamailio/kamailio] cdp: add TLS capability (PR #3548)
by Lucian Balaceanu 21 Sep '23

21 Sep '23

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Adding TLS capability to connections between Kamailio and configured peers. Configuration done via kamailio.cfg. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3548 -- Commit Summary -- * cdp: adding TLS capability to peer connections * cdp: documenting TLS capability related parameters -- File Changes -- M src/modules/cdp/Makefile (2) M src/modules/cdp/cdp_mod.c (27) A src/modules/cdp/cdp_tls.c (196) A src/modules/cdp/cdp_tls.h (51) M src/modules/cdp/doc/cdp_admin.xml (97) M src/modules/cdp/receiver.c (73) M src/modules/cdp/receiver.h (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3548.patch https://github.com/kamailio/kamailio/pull/3548.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3548 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3548(a)github.com>

6 27

← Newer
1
...
16
17
18
19
20
21
22
...
30
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2023