sr-dev July 2023

sr-dev@lists.kamailio.org

15 participants
244 discussions

git:master:192b681c: sipcapture: make sure we null terminate the copy of the string
by Victor Seva 26 Jul '23

26 Jul '23

Module: kamailio Branch: master Commit: 192b681ce7fcd868a4a47a7c26863c733321b8d4 URL: https://github.com/kamailio/kamailio/commit/192b681ce7fcd868a4a47a7c26863c7… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-07-26T15:00:38+02:00 sipcapture: make sure we null terminate the copy of the string bug introduced at cbd7810fff3d5145c1ce34c0e362b5590bb92a12 --- Modified: src/modules/sipcapture/sipcapture.c --- Diff: https://github.com/kamailio/kamailio/commit/192b681ce7fcd868a4a47a7c26863c7… Patch: https://github.com/kamailio/kamailio/commit/192b681ce7fcd868a4a47a7c26863c7… --- diff --git a/src/modules/sipcapture/sipcapture.c b/src/modules/sipcapture/sipcapture.c index de0a15174cc..5efb1898036 100644 --- a/src/modules/sipcapture/sipcapture.c +++ b/src/modules/sipcapture/sipcapture.c @@ -2252,7 +2252,8 @@ static int sip_capture( ip.s = ip_addr2a(&msg->rcv.src_ip); ip.len = strlen(ip.s); - memcpy(buf_ip, ip.s, ip.len); + /* Copy, including teminating \0 */ + memcpy(buf_ip, ip.s, ip.len + 1); sco.source_ip.s = buf_ip; sco.source_ip.len = ip.len; sco.source_port = msg->rcv.src_port; @@ -2839,7 +2840,8 @@ static int report_capture(sip_msg_t *msg, str *_table, str *_corr, str *_data) /* IP source and destination */ ip.s = ip_addr2a(&msg->rcv.src_ip); ip.len = strlen(ip.s); - memcpy(buf_ip, ip.s, ip.len); + /* Copy, including teminating \0 */ + memcpy(buf_ip, ip.s, ip.len + 1); sco.source_ip.s = buf_ip; sco.source_ip.len = ip.len; sco.source_port = msg->rcv.src_port;

1 0

git:master:3c1700fb: rtpproxy: make sure we null terminate the copy of the string.
by Victor Seva 26 Jul '23

26 Jul '23

Module: kamailio Branch: master Commit: 3c1700fb7693c05025be1058e856fe610f4be031 URL: https://github.com/kamailio/kamailio/commit/3c1700fb7693c05025be1058e856fe6… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-07-26T14:55:17+02:00 rtpproxy: make sure we null terminate the copy of the string. bug introduced at d00ceda2c04 --- Modified: src/modules/rtpproxy/rtpproxy.c --- Diff: https://github.com/kamailio/kamailio/commit/3c1700fb7693c05025be1058e856fe6… Patch: https://github.com/kamailio/kamailio/commit/3c1700fb7693c05025be1058e856fe6… --- diff --git a/src/modules/rtpproxy/rtpproxy.c b/src/modules/rtpproxy/rtpproxy.c index 9d7190cabc3..bc252982e1c 100644 --- a/src/modules/rtpproxy/rtpproxy.c +++ b/src/modules/rtpproxy/rtpproxy.c @@ -1834,7 +1834,8 @@ static int rtpproxy_answer1_helper_f(struct sip_msg *msg, char *flags) cp.s = ip_addr2a(&msg->rcv.dst_ip); cp.len = strlen(cp.s); - memcpy(newip, cp.s, cp.len); + /* Copy, including teminating \0 */ + memcpy(newip, cp.s, cp.len + 1); return force_rtp_proxy(msg, flags, newip, 0, 0); }

1 0

git:master:2750e48b: rtpproxy: make sure we null terminate the copy of the string.
by Victor Seva 26 Jul '23

26 Jul '23

Module: kamailio Branch: master Commit: 2750e48b5445e9334cb7a062d7d53a1fb9a0a411 URL: https://github.com/kamailio/kamailio/commit/2750e48b5445e9334cb7a062d7d53a1… Author: Maksym Sobolyev <sobomax(a)sippysoft.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-07-26T14:46:45+02:00 rtpproxy: make sure we null terminate the copy of the string. Broken in d00ceda2c04. --- Modified: src/modules/rtpproxy/rtpproxy.c --- Diff: https://github.com/kamailio/kamailio/commit/2750e48b5445e9334cb7a062d7d53a1… Patch: https://github.com/kamailio/kamailio/commit/2750e48b5445e9334cb7a062d7d53a1… --- diff --git a/src/modules/rtpproxy/rtpproxy.c b/src/modules/rtpproxy/rtpproxy.c index 8103fef4edd..9d7190cabc3 100644 --- a/src/modules/rtpproxy/rtpproxy.c +++ b/src/modules/rtpproxy/rtpproxy.c @@ -1698,7 +1698,8 @@ static int rtpproxy_manage(struct sip_msg *msg, char *flags, char *ip) if(ip == NULL) { cp.s = ip_addr2a(&msg->rcv.dst_ip); cp.len = strlen(cp.s); - memcpy(newip, cp.s, cp.len); + /* Copy, including teminating \0 */ + memcpy(newip, cp.s, cp.len + 1); } if(msg->msg_flags & FL_SDP_BODY)

1 0

git:master:8b113985: rtpengine: increase buf size to print mos llint range
by Stefan Mititelu 20 Jul '23

20 Jul '23

Module: kamailio Branch: master Commit: 8b1139851d9f88add1fd7da0dbc0b2b56933cdd3 URL: https://github.com/kamailio/kamailio/commit/8b1139851d9f88add1fd7da0dbc0b2b… Author: Stefan Mititelu <stefan-cristian.mititelu(a)1and1.ro> Committer: Stefan Mititelu <stefan.mititelu(a)govoip.ro> Date: 2023-07-20T15:25:37+03:00 rtpengine: increase buf size to print mos llint range --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/8b1139851d9f88add1fd7da0dbc0b2b… Patch: https://github.com/kamailio/kamailio/commit/8b1139851d9f88add1fd7da0dbc0b2b… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 59bcfb47795..68003908268 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -180,14 +180,15 @@ struct minmax_mos_label_stats }; struct minmax_stats_vals { - long long mos; - long long at; - long long packetloss; - long long jitter; - long long roundtrip; - long long roundtrip_leg; - long long samples; - long long avg_samples; /* our own running count to average the averages */ + long long int mos; + long long int at; + long long int packetloss; + long long int jitter; + long long int roundtrip; + long long int roundtrip_leg; + long long int samples; + long long int + avg_samples; /* our own running count to average the averages */ }; #define RTPE_LIST_VERSION_DELAY 10 @@ -3879,12 +3880,13 @@ static void avp_print_decimal(pv_elem_t *pv, int num, struct sip_msg *msg) len = snprintf(buf, sizeof(buf), "%i.%i", num / 10, abs(num % 10)); avp_print_s(pv, buf, len, msg); } -static void avp_print_int(pv_elem_t *pv, int num, struct sip_msg *msg) +static void avp_print_llint( + pv_elem_t *pv, long long int num, struct sip_msg *msg) { int len; - char buf[8]; + char buf[20]; - len = snprintf(buf, sizeof(buf), "%i", num); + len = snprintf(buf, sizeof(buf), "%lld", num); avp_print_s(pv, buf, len, msg); } static void avp_print_time(pv_elem_t *pv, int num, struct sip_msg *msg) @@ -3904,12 +3906,13 @@ static void avp_print_mos(struct minmax_mos_stats *s, avp_print_decimal(s->mos_pv, vals->mos / vals->avg_samples, msg); avp_print_time(s->at_pv, vals->at - created, msg); - avp_print_int(s->packetloss_pv, vals->packetloss / vals->avg_samples, msg); - avp_print_int(s->jitter_pv, vals->jitter / vals->avg_samples, msg); - avp_print_int(s->roundtrip_pv, vals->roundtrip / vals->avg_samples, msg); - avp_print_int( + avp_print_llint( + s->packetloss_pv, vals->packetloss / vals->avg_samples, msg); + avp_print_llint(s->jitter_pv, vals->jitter / vals->avg_samples, msg); + avp_print_llint(s->roundtrip_pv, vals->roundtrip / vals->avg_samples, msg); + avp_print_llint( s->roundtrip_leg_pv, vals->roundtrip_leg / vals->avg_samples, msg); - avp_print_int(s->samples_pv, vals->samples / vals->avg_samples, msg); + avp_print_llint(s->samples_pv, vals->samples / vals->avg_samples, msg); } static int decode_mos_vals_dict(

1 0

[kamailio/kamailio] rtpengine: increase buf size to print mos llint range (PR #3517)
by Stefan Mititelu 20 Jul '23

20 Jul '23

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  CDR avp() mos values gets trimmed at the first larger mos value received. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3517 -- Commit Summary -- * rtpengine: increase buf size to print mos llint range -- File Changes -- M src/modules/rtpengine/rtpengine.c (32) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3517.patch https://github.com/kamailio/kamailio/pull/3517.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3517 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3517(a)github.com>

2 3

git:5.6:d4d28c09: dialog: set cbs list to NULL after destroying
by Victor Seva 20 Jul '23

20 Jul '23

Module: kamailio Branch: 5.6 Commit: d4d28c098ddc07ab1b956a13878cd8e6f180fe3d URL: https://github.com/kamailio/kamailio/commit/d4d28c098ddc07ab1b956a13878cd8e… Author: Stefan Mititelu <stefan-cristian.mititelu(a)1and1.ro> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-07-20T09:38:17+02:00 dialog: set cbs list to NULL after destroying (cherry picked from commit 6881faadec45dd16dd896b13db44862e7df70422) (cherry picked from commit 20be29ab3638d803341ec376b02edd7c14a9174a) --- Modified: src/modules/dialog/dlg_hash.c --- Diff: https://github.com/kamailio/kamailio/commit/d4d28c098ddc07ab1b956a13878cd8e… Patch: https://github.com/kamailio/kamailio/commit/d4d28c098ddc07ab1b956a13878cd8e… --- diff --git a/src/modules/dialog/dlg_hash.c b/src/modules/dialog/dlg_hash.c index 54b8916d4e0..d61bfb62b49 100644 --- a/src/modules/dialog/dlg_hash.c +++ b/src/modules/dialog/dlg_hash.c @@ -370,8 +370,11 @@ void destroy_dlg(struct dlg_cell *dlg) if (dlg_db_mode) remove_dialog_from_db(dlg); - if (dlg->cbs.first) + if(dlg->cbs.first) { destroy_dlg_callbacks_list(dlg->cbs.first); + dlg->cbs.first = NULL; + dlg->cbs.types = 0; + } if (dlg->profile_links) destroy_linkers(dlg->profile_links);

1 0

git:5.7:20be29ab: dialog: set cbs list to NULL after destroying
by Victor Seva 20 Jul '23

20 Jul '23

Module: kamailio Branch: 5.7 Commit: 20be29ab3638d803341ec376b02edd7c14a9174a URL: https://github.com/kamailio/kamailio/commit/20be29ab3638d803341ec376b02edd7… Author: Stefan Mititelu <stefan-cristian.mititelu(a)1and1.ro> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-07-20T09:37:12+02:00 dialog: set cbs list to NULL after destroying (cherry picked from commit 6881faadec45dd16dd896b13db44862e7df70422) --- Modified: src/modules/dialog/dlg_hash.c --- Diff: https://github.com/kamailio/kamailio/commit/20be29ab3638d803341ec376b02edd7… Patch: https://github.com/kamailio/kamailio/commit/20be29ab3638d803341ec376b02edd7… --- diff --git a/src/modules/dialog/dlg_hash.c b/src/modules/dialog/dlg_hash.c index 54b8916d4e0..d61bfb62b49 100644 --- a/src/modules/dialog/dlg_hash.c +++ b/src/modules/dialog/dlg_hash.c @@ -370,8 +370,11 @@ void destroy_dlg(struct dlg_cell *dlg) if (dlg_db_mode) remove_dialog_from_db(dlg); - if (dlg->cbs.first) + if(dlg->cbs.first) { destroy_dlg_callbacks_list(dlg->cbs.first); + dlg->cbs.first = NULL; + dlg->cbs.types = 0; + } if (dlg->profile_links) destroy_linkers(dlg->profile_links);

1 0

[kamailio/kamailio] dialog: set cbs list to NULL after destroying (PR #3514)
by Stefan Mititelu 19 Jul '23

19 Jul '23

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [X] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Make sure dialog cbs list is NULL after is destroyed. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3514 -- Commit Summary -- * dialog: set cbs list to NULL after destroying -- File Changes -- M src/modules/dialog/dlg_hash.c (5) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3514.patch https://github.com/kamailio/kamailio/pull/3514.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3514 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3514(a)github.com>

2 1

git:master:6881faad: dialog: set cbs list to NULL after destroying
by Victor Seva 19 Jul '23

19 Jul '23

Module: kamailio Branch: master Commit: 6881faadec45dd16dd896b13db44862e7df70422 URL: https://github.com/kamailio/kamailio/commit/6881faadec45dd16dd896b13db44862… Author: Stefan Mititelu <stefan-cristian.mititelu(a)1and1.ro> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-07-19T15:04:25+02:00 dialog: set cbs list to NULL after destroying --- Modified: src/modules/dialog/dlg_hash.c --- Diff: https://github.com/kamailio/kamailio/commit/6881faadec45dd16dd896b13db44862… Patch: https://github.com/kamailio/kamailio/commit/6881faadec45dd16dd896b13db44862… --- diff --git a/src/modules/dialog/dlg_hash.c b/src/modules/dialog/dlg_hash.c index 2454940fee3..8e740003c24 100644 --- a/src/modules/dialog/dlg_hash.c +++ b/src/modules/dialog/dlg_hash.c @@ -365,8 +365,11 @@ void destroy_dlg(struct dlg_cell *dlg) if(dlg_db_mode) remove_dialog_from_db(dlg); - if(dlg->cbs.first) + if(dlg->cbs.first) { destroy_dlg_callbacks_list(dlg->cbs.first); + dlg->cbs.first = NULL; + dlg->cbs.types = 0; + } if(dlg->profile_links) destroy_linkers(dlg->profile_links);

1 0

Kamailio v5.5.7 Released
by Daniel-Constantin Mierla 19 Jul '23

19 Jul '23

Hello, Kamailio SIP Server v5.5.7 stable release is out. This is a maintenance release of the stable branch 5.5 that includes fixes since the release of v5.5.6. There is no change to database schema or configuration language structure that you have to do on previous installations of v5.5.x. Deployments running previous v5.5.x versions are strongly recommended to be upgraded to v5.5.7. Note that 5.5 is now the third last stable branch, v5.5.7 being the last planned released in 5.5.x series. The latest two stable branch are 5.6 and 5.7, with v5.7.1 being released a while ago. For more details about version 5.5.7 (including links and guidelines to download the tarball or from GIT repository), visit: * https://www.kamailio.org/w/2023/07/kamailio-v5-5-7-released/ RPM, Debian/Ubuntu packages will be available soon as well. Many thanks to all contributing and using Kamailio! Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio World Conference - www.kamailioworld.com

1 0

← Newer
1
...
12
13
14
15
16
17
18
...
25
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2023