Module: kamailio
Branch: master
Commit: b26cfeda773867e8f346f3eb0f5c31e8cd408ac9
URL: https://github.com/kamailio/kamailio/commit/b26cfeda773867e8f346f3eb0f5c31e…
Author: �������������������� �������������������������������� <git-dpa(a)aegee.org>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2023-04-10T08:03:47+02:00
rtpengine clarifications
See http://lists.sipwise.com/pipermail/spce-user_lists.sipwise.com/2023-April/0… and
https://github.com/sipwise/rtpengine/issues/1595#issuecomment-1382378886
---
Modified: src/modules/rtpengine/doc/rtpengine_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/b26cfeda773867e8f346f3eb0f5c31e…
Patch: https://github.com/kamailio/kamailio/commit/b26cfeda773867e8f346f3eb0f5c31e…
---
diff --git a/src/modules/rtpengine/doc/rtpengine_admin.xml b/src/modules/rtpengine/doc/rtpengine_admin.xml
index ba6e9f2d22b..0cb881b4397 100644
--- a/src/modules/rtpengine/doc/rtpengine_admin.xml
+++ b/src/modules/rtpengine/doc/rtpengine_admin.xml
@@ -2366,7 +2366,8 @@ rtpengine_offer();
<emphasis>force-answer</emphasis> - force <quote>answer</quote>, that is,
only rewrite &sdp; when corresponding session already exists
in the &rtp; proxy. By default is on when the session is to be
- completed.
+ completed. This is only necessary when the offer was sent by <function>rtpengine_offer()</function>, and
+ the answer is handled by <function>rtpengine_manage()</function>.
</para></listitem>
<listitem><para>
<emphasis>direction=...</emphasis> - this option specifies a logical network
@@ -2482,9 +2483,9 @@ rtpengine_offer();
transport protocol that should be used towards the recipient of
the &sdp;. If none of them are specified, the protocol given in
the &sdp; is left untouched. Otherwise, the <quote>SRTP</quote> flag indicates that
- SRTP should be used, while <quote>RTP</quote> indicates that SRTP should not be used.
- <quote>AVPF</quote> indicates that the advanced RTCP profile with feedback messages
- should be used, and <quote>AVP</quote> indicates that the regular RTCP profile
+ SRTP should be used, while <quote>RTP</quote> indicates that both SRTP and AVPF should
+ not be used. <quote>AVPF</quote> indicates that the advanced RTCP profile with feedback
+ messages should be used, and <quote>AVP</quote> indicates that the regular RTCP profile
should be used. See also the next set of flags below.
</para></listitem>
<listitem><para>
I have installed kamaillio 5.6 on debian 11, bullseye with RTP engine latest version 11.x. Using webrtc client as jssip to connect with kamailio and route the calls to asterisk server from kamailio.
in Local network everything working fine
When I connect JSSIP webrtc client from public internet I am getting no voice for both ends. I have observed that the rtp is flowing from the remote end to the client while IVR is playing from callee end. But the rtp doesnt know where to route to reach the webrtc client.
For normal UDP call everyting works fine from local and public internet. The issue is only for ws and wss calls
observations :
ICE options : trickle ICE
ICE candidates with sdp is there when calling from local network
ICE candidates are not with sdp when calling from publi internet. C IN and RTCP = 0..0.0.0:9
found RTP is routing to ------- > 0.0.0.0:9 and not reaching anywhere
RTPengine interface is local ip and public ip is advertised, in kmailio also public ip is advertised
sip dumb has been investgated and found everything is observed as normal with only one difference, that is no ice candidates for wss client from public internet
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3413
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3413(a)github.com>
Module: kamailio
Branch: master
Commit: a4970749b2be40cd598d4ce5cf2eaa6b38fc2307
URL: https://github.com/kamailio/kamailio/commit/a4970749b2be40cd598d4ce5cf2eaa6…
Author: Ovidiu Sas <osas(a)voipembedded.com>
Committer: Ovidiu Sas <osas(a)voipembedded.com>
Date: 2023-04-08T01:48:11-04:00
tm: enhance documentation for on_sl_reply param
---
Modified: src/modules/tm/doc/params.xml
---
Diff: https://github.com/kamailio/kamailio/commit/a4970749b2be40cd598d4ce5cf2eaa6…
Patch: https://github.com/kamailio/kamailio/commit/a4970749b2be40cd598d4ce5cf2eaa6…
---
diff --git a/src/modules/tm/doc/params.xml b/src/modules/tm/doc/params.xml
index e19d709e5a8..5b65dcabebe 100644
--- a/src/modules/tm/doc/params.xml
+++ b/src/modules/tm/doc/params.xml
@@ -715,7 +715,7 @@ modparam("tm", "reparse_on_dns_failover", 0)
</para>
<para>
If KEMI is used, the parameter has to be the KEMI function name, which
- receives a string parameter with the event name.
+ receives a string parameter with the event name, respectively "on_sl_reply".
</para>
<example>
<title>Set <varname>on_sl_reply</varname> parameter</title>
@@ -727,6 +727,20 @@ modparam("tm", "on_sl_reply", "stateless_replies")
onreply_route["stateless_replies"] {
# do not allow stateless replies to be forwarded
return 0;
+}
+ </programlisting>
+ </example>
+ <example>
+ <title>Set <varname>on_sl_reply</varname> parameter (KEMI javascript)</title>
+ <programlisting>
+...
+modparam("tm", "on_sl_reply", "ksr_slreply")
+...
+-- event callback function implemented in javascript
+function ksr_slreply(evname) {
+ # the evname is set to "on_sl_reply"
+ # do not allow stateless replies to be forwarded
+ KSR.x.drop();
}
</programlisting>
</example>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
I added `nats_publish_request` which calls the `natsConnection_PublishRequestString` to send a request to the NATS server with a `reply` string so the response can be easily replied back.
I tested in Lua and the native route, not sure if it's the right way to implement. I can update docs if it sounds good.
Thanks.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3397
-- Commit Summary --
* nats: add a reply param to nats_publish and expose as nats_publish_request in KEMI
-- File Changes --
M src/modules/nats/nats_mod.c (18)
M src/modules/nats/nats_mod.h (2)
M src/modules/nats/nats_pub.c (52)
M src/modules/nats/nats_pub.h (7)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3397.patchhttps://github.com/kamailio/kamailio/pull/3397.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3397
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3397(a)github.com>
```
nats_mod.c: In function 'nats_destroy_workers':
nats_mod.c:600:53: error: invalid operands to binary != (have 'uv_poll_t' {aka 'struct uv_poll_s'} and 'void *')
600 | if(pub_worker->poll != NULL) {
| ~~~~~~~~~~~~~~~~ ^~
| |
| uv_poll_t {aka struct uv_poll_s}
make[3]: *** [../../Makefile.rules:100: nats_mod.o] Error 1
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/commit/a6caaabe4bc85e1b41d5bd9b0b89380…
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/commit/a6caaabe4bc85e1b41d5bd9b0b8938069eace309/107767533(a)github.com>