sr-dev April 2023

sr-dev@lists.kamailio.org

15 participants
263 discussions

[kamailio/kamailio] sanity: implement reserved char check in the header and values (Issue #3421)

by sergey-safarov

### Description Our partner sending a call with this header ``` From: "COVER JERRY & M" <sip:+12099283442@206.147.236.174:5060;otg=TLMNCAXFDS0_3887>;tag=gK0c7f90e2 ``` According [RFC3261](https://www.rfc-editor.org/rfc/rfc3261#section-25.1) ``` Several rules are incorporated from RFC 2396 [5] but are updated to make them compliant with RFC 2234 [10]. These include: reserved = ";" / "/" / "?" / ":" / "@" / "&" / "=" / "+" / "$" / "," unreserved = alphanum / mark mark = "-" / "_" / "." / "!" / "~" / "*" / "'" / "(" / ")" escaped = "%" HEXDIG HEXDIG ``` Also ``` SIP follows the requirements and guidelines of RFC 2396 [5] when defining the set of characters that must be escaped in a SIP URI, and uses its ""%" HEX HEX" mechanism for escaping. From RFC 2396 [5]: The set of characters actually reserved within any given URI component is defined by that component. In general, a character is reserved if the semantics of the URI changes if the character is replaced with its escaped US-ASCII encoding [5]. Excluded US- ASCII characters (RFC 2396 [5]), such as space and control characters and characters used as URI delimiters, also MUST be escaped. URIs MUST NOT contain unescaped space and control characters. ``` And ``` Expanding the hname and hvalue tokens in Section 25 show that all URI reserved characters in header field names and values MUST be escaped. ``` For now, looks like `the sanity` module does not check reserver char usage. This ticket was created to collect recommendations for feature implementation. Should be checked headers? Maybe a similar check is already present in the code and you can provide a reference? Unscaped reserved char usage in "From", "To", "P-Asserted-Identity" and "Remote-Party-ID" for display name breaking SIP message (for example the "lost" module cannot parse properly "From" header). Should such be implemented in the Kamailio core also? ### Expected behavior One of these expected: 1) Kamailio drop a message with reserved char usage in the header names and values. For TCP and TLS transport drop connection; 2) sanity module allows checking reserved char usage in the header names and values. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3421 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3421(a)github.com>

1 year, 8 months

git:master:5a2df203: modules: readme files regenerated - call_control ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 5a2df203a244e79a1868910da312f765091d22f5 URL: https://github.com/kamailio/kamailio/commit/5a2df203a244e79a1868910da312f76… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-04-25T22:16:28+02:00 modules: readme files regenerated - call_control ... [skip ci] --- Modified: src/modules/call_control/README Modified: src/modules/cfgutils/README Modified: src/modules/janssonrpcc/README Modified: src/modules/jsonrpcs/README Modified: src/modules/jwt/README Modified: src/modules/kazoo/README Modified: src/modules/keepalive/README Modified: src/modules/kemix/README Modified: src/modules/kex/README --- Diff: https://github.com/kamailio/kamailio/commit/5a2df203a244e79a1868910da312f76… Patch: https://github.com/kamailio/kamailio/commit/5a2df203a244e79a1868910da312f76…

1 year, 8 months

git:master:4c8276fc: kex: typos

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 4c8276fcf268a690ea671c4ddeaad1f89e293565 URL: https://github.com/kamailio/kamailio/commit/4c8276fcf268a690ea671c4ddeaad1f… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-04-25T22:11:28+02:00 kex: typos --- Modified: src/modules/kex/core_stats.c Modified: src/modules/kex/doc/kex_admin.xml Modified: src/modules/kex/kex_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/4c8276fcf268a690ea671c4ddeaad1f… Patch: https://github.com/kamailio/kamailio/commit/4c8276fcf268a690ea671c4ddeaad1f… --- diff --git a/src/modules/kex/core_stats.c b/src/modules/kex/core_stats.c index 565ce4e77d7..816ae39a90f 100644 --- a/src/modules/kex/core_stats.c +++ b/src/modules/kex/core_stats.c @@ -409,7 +409,7 @@ struct rpc_list_params { /** - * Satistic getter RPC callback. + * Statistic getter RPC callback. */ static void rpc_get_grp_vars_cbk(void* p, str* g, str* n, counter_handle_t h) { @@ -644,7 +644,7 @@ static void rpc_stats_fetchn_statistics(rpc_t* rpc, void* ctx) } /** - * Satistic reset/clear-er RPC callback.. + * Statistic reset/clear-er RPC callback.. */ static void rpc_reset_or_clear_grp_vars_cbk(void* p, str* g, str* n, counter_handle_t h) diff --git a/src/modules/kex/doc/kex_admin.xml b/src/modules/kex/doc/kex_admin.xml index 34484bc4ec8..5c597e97047 100644 --- a/src/modules/kex/doc/kex_admin.xml +++ b/src/modules/kex/doc/kex_admin.xml @@ -88,7 +88,7 @@ setsflag("$var(flag)"); <section id="kex.f.issflagset"> <title><function moreinfo="none">issflagset(flag)</function></title> <para> - Return true of the script flag is set. + Return true if the script flag is set. </para> <para>Meaning of the parameters is as follows:</para> <itemizedlist> @@ -179,7 +179,7 @@ setbflag("$var(flag)", "1"); <section id="kex.f.isbflagset"> <title><function moreinfo="none">isbflagset(flag [, branch])</function></title> <para> - Return true of the branch flag is set. + Return true if the branch flag is set. </para> <para>Meaning of the parameters is as follows:</para> <itemizedlist> @@ -762,7 +762,7 @@ resetdebug(); </title> <para>Print the list of available internal statistics.</para> <para>NOTE: the result is an array of strings that have the list of - statistics formated like "name = value", being propagated over the time + statistics formatted like "name = value", being propagated over the time from the MI variant. Use "stats.fetch" or "stats.fetchn"commands to have a more JSON-friendly output.</para> <para>Parameters: <emphasis>statsid</emphasis> - which statistics to @@ -785,7 +785,7 @@ resetdebug(); <para>Print the list of available internal statistics with a more json friendly output. Each printed statistic is a field in the output structure: {"statsgroup.statsname" : "statsvalue"}. The value is - represented as string to accomodate large numbers.</para> + represented as string to accommodate large numbers.</para> <para>Parameters: <emphasis>statsid</emphasis> - which statistics to be printed. If set to 'all' then all statistics are printed; if set to 'statsgroup:' then all statistics in the group are printed; diff --git a/src/modules/kex/kex_mod.c b/src/modules/kex/kex_mod.c index e46e85b5cf4..1927c7343d3 100644 --- a/src/modules/kex/kex_mod.c +++ b/src/modules/kex/kex_mod.c @@ -141,7 +141,7 @@ static int mod_init(void) register_pkg_proc_stats(); pkg_proc_stats_init_rpc(); - /* per module memmory debugging RPC command */ + /* per module memory debugging RPC command */ mod_stats_init_rpc(); return 0;

1 year, 8 months

git:master:79fc3f1f: kemix: update Kamailio URLs to HTTP â HTTPS

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 79fc3f1fc9561f43146a107c824d1d97d3a8b021 URL: https://github.com/kamailio/kamailio/commit/79fc3f1fc9561f43146a107c824d1d9… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-04-25T22:11:28+02:00 kemix: update Kamailio URLs to HTTP �� HTTPS --- Modified: src/modules/kemix/doc/kemix_admin.xml Modified: src/modules/kemix/kemix_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/79fc3f1fc9561f43146a107c824d1d9… Patch: https://github.com/kamailio/kamailio/commit/79fc3f1fc9561f43146a107c824d1d9… --- diff --git a/src/modules/kemix/doc/kemix_admin.xml b/src/modules/kemix/doc/kemix_admin.xml index 0743d7765c5..f28467dc170 100644 --- a/src/modules/kemix/doc/kemix_admin.xml +++ b/src/modules/kemix/doc/kemix_admin.xml @@ -30,8 +30,8 @@ <itemizedlist> <listitem> <para> - <ulink url="http://kamailio.org/docs/tutorials/devel/kamailio-kemi-framework/"> - http://kamailio.org/docs/tutorials/devel/kamailio-kemi-framework/</ulink> + <ulink url="https://kamailio.org/docs/tutorials/devel/kamailio-kemi-framework/"> + https://kamailio.org/docs/tutorials/devel/kamailio-kemi-framework/</ulink> </para> </listitem> </itemizedlist> diff --git a/src/modules/kemix/kemix_mod.c b/src/modules/kemix/kemix_mod.c index e6bff3841cf..c710d50ffcf 100644 --- a/src/modules/kemix/kemix_mod.c +++ b/src/modules/kemix/kemix_mod.c @@ -75,7 +75,7 @@ static sr_kemi_xval_t* ki_kx_get_ruri(sip_msg_t *msg) } if(msg->first_line.type == SIP_REPLY) { - /* REPLY doesnt have a ruri */ + /* REPLY doesn't have a ruri */ sr_kemi_xval_null(&_sr_kemi_kx_xval, 0); return &_sr_kemi_kx_xval; } @@ -108,7 +108,7 @@ static sr_kemi_xval_t* ki_kx_get_ouri(sip_msg_t *msg) } if(msg->first_line.type == SIP_REPLY) { - /* REPLY doesnt have a ruri */ + /* REPLY doesn't have a ruri */ sr_kemi_xval_null(&_sr_kemi_kx_xval, 0); return &_sr_kemi_kx_xval; }

1 year, 8 months

git:master:e7c8dcb9: keepalive: typos

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: e7c8dcb9507fbd44cc1d00132b433a2d91705a48 URL: https://github.com/kamailio/kamailio/commit/e7c8dcb9507fbd44cc1d00132b433a2… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-04-25T22:11:28+02:00 keepalive: typos --- Modified: src/modules/keepalive/doc/keepalive_admin.xml Modified: src/modules/keepalive/keepalive.h Modified: src/modules/keepalive/keepalive_rpc.c --- Diff: https://github.com/kamailio/kamailio/commit/e7c8dcb9507fbd44cc1d00132b433a2… Patch: https://github.com/kamailio/kamailio/commit/e7c8dcb9507fbd44cc1d00132b433a2…

1 year, 8 months

git:master:67a01aa6: kazoo: typos

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 67a01aa6757f19397438457c6665d338f6804f24 URL: https://github.com/kamailio/kamailio/commit/67a01aa6757f19397438457c6665d33… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-04-25T22:11:28+02:00 kazoo: typos --- Modified: src/modules/kazoo/doc/kazoo_admin.xml Modified: src/modules/kazoo/kazoo.c Modified: src/modules/kazoo/kz_amqp.c --- Diff: https://github.com/kamailio/kamailio/commit/67a01aa6757f19397438457c6665d33… Patch: https://github.com/kamailio/kamailio/commit/67a01aa6757f19397438457c6665d33… --- diff --git a/src/modules/kazoo/doc/kazoo_admin.xml b/src/modules/kazoo/doc/kazoo_admin.xml index 2d47ce83c1e..4128e8c834c 100644 --- a/src/modules/kazoo/doc/kazoo_admin.xml +++ b/src/modules/kazoo/doc/kazoo_admin.xml @@ -371,7 +371,7 @@ modparam("kazoo", "consume_messages_on_reconnect", 0) <section> <title><varname>single_consumer_on_reconnect</varname>(int)</title> <para>When the main loop receives a message from rabbitmq it will defer the - execution to a worker in a round-robin manner. this parameter allows to use the + execution to a worker in a round-robin manner. This parameter allows to use the same worker when kazoo reconnects to rabbitmq.</para> <para> <emphasis>Default value is 1.</emphasis> diff --git a/src/modules/kazoo/kazoo.c b/src/modules/kazoo/kazoo.c index 46f1f098b21..989d637bf22 100644 --- a/src/modules/kazoo/kazoo.c +++ b/src/modules/kazoo/kazoo.c @@ -176,7 +176,7 @@ static param_export_t params[] = { {"node_hostname", PARAM_STR, &dbk_node_hostname}, {"amqp_connection", PARAM_STRING|USE_FUNC_PARAM,(void*)kz_amqp_add_connection}, {"amqp_max_channels", INT_PARAM, &dbk_channels}, - {"amqp_timmer_process_interval", INT_PARAM, &kz_timer_ms}, + {"amqp_timer_process_interval", INT_PARAM, &kz_timer_ms}, {"amqp_consumer_ack_timeout_micro", INT_PARAM, &kz_ack_tv.tv_usec}, {"amqp_consumer_ack_timeout_sec", INT_PARAM, &kz_ack_tv.tv_sec}, {"amqp_interprocess_timeout_micro", INT_PARAM, &kz_sock_tv.tv_usec}, diff --git a/src/modules/kazoo/kz_amqp.c b/src/modules/kazoo/kz_amqp.c index 873d6fe421c..1604cea612e 100644 --- a/src/modules/kazoo/kz_amqp.c +++ b/src/modules/kazoo/kz_amqp.c @@ -2353,10 +2353,10 @@ int add_amqp_headers (char * headers, amqp_basic_properties_t * props ) if (header_value != NULL) { num_headers++; } else { - LM_ERR("Header-Value cant be parsed - skipping!\n"); + LM_ERR("Header-Value can't be parsed - skipping!\n"); } } else { - LM_ERR("Header-Name cant be parsed - skipping!\n"); + LM_ERR("Header-Name can't be parsed - skipping!\n"); } kv_pair_str = strtok_r(NULL, headers_delim, &header_saveptr); }

1 year, 8 months

git:master:8c5a8ce5: jwt: typo algoritm â algorithm

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 8c5a8ce562e5ab98a7e6bdf163bab833ec3a7cf5 URL: https://github.com/kamailio/kamailio/commit/8c5a8ce562e5ab98a7e6bdf163bab83… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-04-25T22:11:28+02:00 jwt: typo algoritm �� algorithm --- Modified: src/modules/jwt/doc/jwt_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/8c5a8ce562e5ab98a7e6bdf163bab83… Patch: https://github.com/kamailio/kamailio/commit/8c5a8ce562e5ab98a7e6bdf163bab83… --- diff --git a/src/modules/jwt/doc/jwt_admin.xml b/src/modules/jwt/doc/jwt_admin.xml index 165ca170f95..5389bb61f30 100644 --- a/src/modules/jwt/doc/jwt_admin.xml +++ b/src/modules/jwt/doc/jwt_admin.xml @@ -101,7 +101,7 @@ modparam("jwt", "key_mode", 1) </listitem> <listitem> <para> - alg - the algoritm to build the signature, as supported by the + alg - the algorithm to build the signature, as supported by the libjwt (e.g., RS256, HS256, ES256, ...) </para> </listitem> @@ -158,7 +158,7 @@ modparam("jwt", "key_mode", 1) </listitem> <listitem> <para> - alg - the algoritm to build the signature, as supported by the + alg - the algorithm to build the signature, as supported by the libjwt (e.g., RS256, HS256, ES256, ...) </para> </listitem> @@ -210,7 +210,7 @@ modparam("jwt", "key_mode", 1) </listitem> <listitem> <para> - alg - the algoritm to build the signature, as supported by the + alg - the algorithm to build the signature, as supported by the libjwt (e.g., RS256, HS256, ES256, ...) </para> </listitem>

1 year, 8 months

git:master:285a2606: jsonrpcs: typos

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 285a260687d4dce5636531a4ffffc43b0d37e883 URL: https://github.com/kamailio/kamailio/commit/285a260687d4dce5636531a4ffffc43… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-04-25T22:11:28+02:00 jsonrpcs: typos --- Modified: src/modules/jsonrpcs/doc/jsonrpcs_admin.xml Modified: src/modules/jsonrpcs/jsonrpcs_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/285a260687d4dce5636531a4ffffc43… Patch: https://github.com/kamailio/kamailio/commit/285a260687d4dce5636531a4ffffc43… --- diff --git a/src/modules/jsonrpcs/doc/jsonrpcs_admin.xml b/src/modules/jsonrpcs/doc/jsonrpcs_admin.xml index 9e558c4cfd..0e39676edd 100644 --- a/src/modules/jsonrpcs/doc/jsonrpcs_admin.xml +++ b/src/modules/jsonrpcs/doc/jsonrpcs_admin.xml @@ -380,7 +380,7 @@ modparam("jsonrpcs", "dgram_user", "root") <section id="jsonrpcs.p.dgram_timeout"> <title><varname>dgram_timeout</varname> (int)</title> <para> - The reply will expire after trying to sent it for socket_timeout + The reply will expire after trying to send it for socket_timeout milliseconds. </para> <para> diff --git a/src/modules/jsonrpcs/jsonrpcs_mod.c b/src/modules/jsonrpcs/jsonrpcs_mod.c index e369c62569..8ce008ccb5 100644 --- a/src/modules/jsonrpcs/jsonrpcs_mod.c +++ b/src/modules/jsonrpcs/jsonrpcs_mod.c @@ -298,7 +298,7 @@ static int jsonrpc_delayed_reply_ctx_init(jsonrpc_ctx_t* ctx) /** Implementation of rpc_fault function required by the management API. * * This function will be called whenever a management function - * indicates that an error ocurred while it was processing the request. The + * indicates that an error occurred while it was processing the request. The * function takes the reply code and reason phrase as parameters, these will * be put in the body of the reply. * @@ -340,7 +340,7 @@ static void jsonrpc_fault(jsonrpc_ctx_t* ctx, int code, char* fmt, ...) * This is the function that will be called whenever a management function * asks the management interface to send the reply to the client. * The SIP/HTTP reply sent to - * the client will be always 200 OK, if an error ocurred on the server then it + * the client will be always 200 OK, if an error occurred on the server then it * will be indicated in the html document in body. * * @param ctx A pointer to the context structure of the jsonrpc request that @@ -1191,7 +1191,7 @@ static void jsonrpc_delayed_ctx_close(struct rpc_delayed_ctx* dctx) (hdr->parsed<(void*)r_ctx->msg || hdr->parsed>=(void*)(r_ctx->msg+r_ctx->msg_shm_block_size))) { /* header parsed filed doesn't point inside uas.request memory - * chunck -> it was added by failure funcs.-> free it as pkg */ + * chunk -> it was added by failure funcs.-> free it as pkg */ DBG("removing hdr->parsed %d\n", hdr->type); clean_hdr_field(hdr); hdr->parsed = 0;

1 year, 8 months

git:master:27e97f17: janssonrpcc: typo

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 27e97f1717e542765125f32f0bde98f6bf47e26b URL: https://github.com/kamailio/kamailio/commit/27e97f1717e542765125f32f0bde98f… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-04-25T22:11:28+02:00 janssonrpcc: typo --- Modified: src/modules/janssonrpcc/doc/janssonrpcc_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/27e97f1717e542765125f32f0bde98f… Patch: https://github.com/kamailio/kamailio/commit/27e97f1717e542765125f32f0bde98f… --- diff --git a/src/modules/janssonrpcc/doc/janssonrpcc_admin.xml b/src/modules/janssonrpcc/doc/janssonrpcc_admin.xml index 0d7e78c7085..10a3a732482 100644 --- a/src/modules/janssonrpcc/doc/janssonrpcc_admin.xml +++ b/src/modules/janssonrpcc/doc/janssonrpcc_admin.xml @@ -143,7 +143,7 @@ modparam("janssonrpcc", "result_pv", "$var(result)") modparam("janssonrpcc", "server", "conn=tests;srv=_test1._tcp.example.net"); modparam("janssonrpcc", "server", "conn=tests;srv=_test2._tcp.example.net"); modparam("janssonrpcc", "server", "conn=local;addr=localhost;port=8080;priority=10;weight=10"); -modparam("janssonrpcc", "server", "conn=user_db;addr=rpc.prod.exmaple.net;port=5060;priority=10;weight=10"); +modparam("janssonrpcc", "server", "conn=user_db;addr=rpc.prod.example.net;port=5060;priority=10;weight=10"); ... </programlisting> </example>

1 year, 8 months

git:master:326ad479: ims_registrar_pcscf: typo

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 326ad479fb9e09f4f3a177606f2b5dcc09fbbd62 URL: https://github.com/kamailio/kamailio/commit/326ad479fb9e09f4f3a177606f2b5dc… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-04-25T22:11:28+02:00 ims_registrar_pcscf: typo --- Modified: src/modules/ims_registrar_pcscf/save.c --- Diff: https://github.com/kamailio/kamailio/commit/326ad479fb9e09f4f3a177606f2b5dc… Patch: https://github.com/kamailio/kamailio/commit/326ad479fb9e09f4f3a177606f2b5dc… --- diff --git a/src/modules/ims_registrar_pcscf/save.c b/src/modules/ims_registrar_pcscf/save.c index 88c0c008a8e..db9b7e73877 100644 --- a/src/modules/ims_registrar_pcscf/save.c +++ b/src/modules/ims_registrar_pcscf/save.c @@ -254,7 +254,7 @@ static inline int update_contacts(struct sip_msg *req,struct sip_msg *rpl, udoma } /** - * Save contact based on REGISTER request. this will be a pending save, until we receive response + * Save contact based on REGISTER request. This will be a pending save, until we receive response * from SCSCF. If no response after pending_timeout seconds, the contacts is removed. Can only be used from REQUEST ROUTE */ int save_pending(struct sip_msg* _m, udomain_t* _d) {

1 year, 8 months

← Newer
1
...
12
13
14
15
16
17
18
...
27
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2023