sr-dev March 2023

sr-dev@lists.kamailio.org

14 participants
251 discussions

git:master:9cc9a177: p_usrloc: use PRIu64 macro to find out what format is needed for uint64_t since it depends on architecture
by Victor Seva 20 Mar '23

20 Mar '23

Module: kamailio Branch: master Commit: 9cc9a177daf6d5ce11fbdef714bd576716dc5a2f URL: https://github.com/kamailio/kamailio/commit/9cc9a177daf6d5ce11fbdef714bd576… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-03-20T16:56:03+01:00 p_usrloc: use PRIu64 macro to find out what format is needed for uint64_t since it depends on architecture --- Modified: src/modules/p_usrloc/ul_check.c --- Diff: https://github.com/kamailio/kamailio/commit/9cc9a177daf6d5ce11fbdef714bd576… Patch: https://github.com/kamailio/kamailio/commit/9cc9a177daf6d5ce11fbdef714bd576… --- diff --git a/src/modules/p_usrloc/ul_check.c b/src/modules/p_usrloc/ul_check.c index dfc062f266..0ed32dc99f 100644 --- a/src/modules/p_usrloc/ul_check.c +++ b/src/modules/p_usrloc/ul_check.c @@ -19,6 +19,7 @@ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ +#include <inttypes.h> #include <stdint.h> #include "../../core/mem/shm_mem.h" @@ -136,7 +137,7 @@ int must_retry(time_t *timer, time_t interval){ if(!timer){ return -1; } - LM_DBG("must_retry: time is at %llu, retry at %llu.\n", (uint64_t)time(NULL), + LM_DBG("must_retry: time is at %" PRIu64 ", retry at %" PRIu64 ".\n", (uint64_t)time(NULL), (uint64_t)(*timer)); if(*timer <= time(NULL)){ *timer = time(NULL) + interval;

1 0

git:master:1b3224c5: rtpengine: use PRIu64 macro to find out what format is needed for uint64_t since it depends on architecture
by Victor Seva 20 Mar '23

20 Mar '23

Module: kamailio Branch: master Commit: 1b3224c514105d69c3099c11edc5ef20ca02c567 URL: https://github.com/kamailio/kamailio/commit/1b3224c514105d69c3099c11edc5ef2… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-03-20T16:53:15+01:00 rtpengine: use PRIu64 macro to find out what format is needed for uint64_t since it depends on architecture --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/1b3224c514105d69c3099c11edc5ef2… Patch: https://github.com/kamailio/kamailio/commit/1b3224c514105d69c3099c11edc5ef2… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 58c96efc0d..51bd9e380a 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -19,6 +19,7 @@ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ +#include <inttypes.h> #include <sys/types.h> #include <sys/socket.h> #include <sys/time.h> @@ -1337,7 +1338,7 @@ static void rtpengine_rpc_reload(rpc_t* rpc, void* ctx) _rtpe_list_version->vernum += 1; _rtpe_list_version->vertime = time(NULL); - LM_DBG("current rtpengines list version: %d (%llu)\n", + LM_DBG("current rtpengines list version: %d (%" PRIu64 ")\n", _rtpe_list_version->vernum, (uint64_t)_rtpe_list_version->vertime); rpc->rpl_printf(ctx, "Ok. Reload successful."); @@ -1857,7 +1858,7 @@ static int build_rtpp_socks(int lmode, int rtest) { if(_rtpe_list_vernum_local == _rtpe_list_version->vernum) { /* same version for the list of rtpengines */ - LM_DBG("same rtpengines list version: %d (%llu)\n", + LM_DBG("same rtpengines list version: %d (%" PRIu64 ")\n", _rtpe_list_version->vernum, (uint64_t)_rtpe_list_version->vertime); return 0;

1 0

git:master:452af935: modules: readme files regenerated - evapi ... [skip ci]
by Kamailio Dev 20 Mar '23

20 Mar '23

Module: kamailio Branch: master Commit: 452af935fbcc60572541941612091cbc0535a310 URL: https://github.com/kamailio/kamailio/commit/452af935fbcc60572541941612091cb… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-03-20T16:31:24+01:00 modules: readme files regenerated - evapi ... [skip ci] --- Modified: src/modules/evapi/README Modified: src/modules/jsonrpcs/README Modified: src/modules/pipelimit/README --- Diff: https://github.com/kamailio/kamailio/commit/452af935fbcc60572541941612091cb… Patch: https://github.com/kamailio/kamailio/commit/452af935fbcc60572541941612091cb…

1 0

git: new commits in branch master
by Daniel-Constantin Mierla 20 Mar '23

20 Mar '23

- URL: https://github.com/kamailio/kamailio/commit/926ba9473775878d8f38b175764a50d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:29+01:00 rtpengine: cast to uint64_t when using time_t value - URL: https://github.com/kamailio/kamailio/commit/e29ce594466385a7c35634fda4b4664… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:29+01:00 p_usrloc: cast to uint64_t when using time_t value - URL: https://github.com/kamailio/kamailio/commit/161ec6d14b702cb92406171152d127b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:29+01:00 jsonrpcs: protocol extended to allow storing response in a file - implemented for udp sockets - URL: https://github.com/kamailio/kamailio/commit/4fec664327410db4e5ff7036a459e99… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:29+01:00 jsonrpcs: implemented result storing for rpc over fifo - URL: https://github.com/kamailio/kamailio/commit/1b5caab3479bb32c2986906e6e07ea9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:29+01:00 kamctl: option to set store path for rpc commands - URL: https://github.com/kamailio/kamailio/commit/e27823f746eb8fca834474945e45bfe… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:29+01:00 pipelimit: added rpc command pl.rm_pipe - URL: https://github.com/kamailio/kamailio/commit/6c0b62c464bcbc67e485c1e2193b7a6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:29+01:00 pipelimit: docs for rpc command pl.rm_pipe - URL: https://github.com/kamailio/kamailio/commit/e0713531bf6ea2aa9b249503dc346ac… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:30+01:00 pipelimit: new rpc command pl.reset_pipe - reset associated values - URL: https://github.com/kamailio/kamailio/commit/569db2eeaef17f3034f692e808f3401… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:30+01:00 pipelimit: docs for rpc command pl.reset_pipe - URL: https://github.com/kamailio/kamailio/commit/4c998de5f54ee941f7516e589e29405… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:30+01:00 evapi: wait when idle made a modparam - URL: https://github.com/kamailio/kamailio/commit/3b99e09dc10ff38024b2821b26f2efe… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:30+01:00 evapi: docs for wait_idle modparam - URL: https://github.com/kamailio/kamailio/commit/3bff060dcb74a081782abdbdade830b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:30+01:00 evapi: use internal workers to handle client messages - URL: https://github.com/kamailio/kamailio/commit/b34e24770a6435577097b173cafab30… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:30+01:00 jsonrpcs: initial support for tcp transport - one rpc command per connection, which is closed after the response is sent - URL: https://github.com/kamailio/kamailio/commit/1400e8cb6aebdd93a5b0c6979a444a8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:30+01:00 jsonrpcs: more debug messages when handling tcp commands - URL: https://github.com/kamailio/kamailio/commit/7000f437ac8f3fb40c7a55c8c7a3c2c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:30+01:00 jsonrpcs: docs for tcp_socket parameter - URL: https://github.com/kamailio/kamailio/commit/58bd64200e4d2f237f192acf6f88074… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:30+01:00 evapi: support for adaptive wait on idle to spare cpu when not busy - URL: https://github.com/kamailio/kamailio/commit/6e4ba9bd7421bf483cdbc7e5484f21d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:30+01:00 evapi: wait increase limit made modparam - URL: https://github.com/kamailio/kamailio/commit/b044c33c72318c12de78c0d8b7f8ac5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:30+01:00 evapi: docs for wait_increase parameter - URL: https://github.com/kamailio/kamailio/commit/1dc0eac9a3a3abd6e128aa5f1d17d5f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:30+01:00 evapi: if workers is 0, execute callback by evapi receiver - URL: https://github.com/kamailio/kamailio/commit/d4be0b2ec72159c5769fc6d7d0cee57… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:30+01:00 evapi: docs - updates to workers parameter - URL: https://github.com/kamailio/kamailio/commit/ab1831efc20816e18a89e6322d16c8e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-20T16:28:30+01:00 core: skip warning for atomic ops with locking for some dev os-es - do not print the compile warning for non-native memory barier/atomic ops on some devel platforms, for now macos with apple silicon cpu

1 0

git:master:135f7b5e: modules: readme files regenerated - ims_registrar_pcscf ... [skip ci]
by Kamailio Dev 20 Mar '23

20 Mar '23

Module: kamailio Branch: master Commit: 135f7b5e2114617b0bc408175ec146d248d01d3a URL: https://github.com/kamailio/kamailio/commit/135f7b5e2114617b0bc408175ec146d… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-03-20T11:01:25+01:00 modules: readme files regenerated - ims_registrar_pcscf ... [skip ci] --- Modified: src/modules/ims_registrar_pcscf/README --- Diff: https://github.com/kamailio/kamailio/commit/135f7b5e2114617b0bc408175ec146d… Patch: https://github.com/kamailio/kamailio/commit/135f7b5e2114617b0bc408175ec146d… --- diff --git a/src/modules/ims_registrar_pcscf/README b/src/modules/ims_registrar_pcscf/README index 3bfb0e6003..02327a005c 100644 --- a/src/modules/ims_registrar_pcscf/README +++ b/src/modules/ims_registrar_pcscf/README @@ -312,6 +312,33 @@ pcscf_save("location"); * domain - Logical domain within the registrar. If a database is used then this must be name of the table which stores the contacts. + The return code may have the following values: + * ( 1) OK + * (-1) Parsing of contact data failed + * (-2) Deregistration in progress + + For db_mode = DB_ONLY (3) setting for ims_usrloc_pcscf module modparam + following logic is implemented: + * To avoid race time conditions between a REREGISTER and the expiry + handler state machine in the scscf an approach is chosen to refuse + a REREGISTER in time window of 20 seconds after pcontact expiry on + the pcscf (thus allowing expiry handling to finish). REREGISTER is + refused in this scenario with return code -2. + * In case a REREGISTER arrives at pcscf and the respective pcontact + is expired longer than time window of 20 seconds registration also + is refused with return code -2 and additionaly PUBLISH is sent to + scscf with expiry = 0. + * The rc -2 shall be handled in register.cfg script as follows: + pcscf_save_pending("location"); + switch ($retcode) { + case -1: + ....... + case -2: + send_reply("500", "Deregister in progress - Please try again"); + exit; + break; + } + 4.3. pcscf_follows_service_routes(domain) Returns true, if the request is following the "learned" service-routes

1 0

git:master:38d72c3f: ims_registrar_pcscf: changes for ul db_mode DB_ONLY
by Henning Westerholt 20 Mar '23

20 Mar '23

Module: kamailio Branch: master Commit: 38d72c3f8248b32b3ba0ff24abd1f2f7407f9d8f URL: https://github.com/kamailio/kamailio/commit/38d72c3f8248b32b3ba0ff24abd1f2f… Author: Annemarie Mandl <mandl(a)rpmbld.novalocal> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-03-20T10:57:21+01:00 ims_registrar_pcscf: changes for ul db_mode DB_ONLY Enable registration of pcscf contact callback during download from db location table and inserting pcontact (normally this callback is registered during handling of REGISTER). Refuse REGISTER when pcontact is expired since [0 to 20] seconds. Within this time window a NOTIFY is expected from scscf and in order to avoid race time conditions between scscf and pcscf REGISTER will be refused. Refuse REGISTER when pcontact is expired longer than 20 seconds - send PUBLISH (contact expired) to scscf to trigger NOTIFY. In both REGISTER refused scenarios routing script should reply 500 - Deregistration in progress. undo changes in ul_callback.c & ul_callback.h corrections after comments from Henning --- Modified: src/modules/ims_registrar_pcscf/doc/ims_registrar_pcscf_admin.xml Modified: src/modules/ims_registrar_pcscf/ims_registrar_pcscf_mod.c Modified: src/modules/ims_registrar_pcscf/notify.c Modified: src/modules/ims_registrar_pcscf/save.c --- Diff: https://github.com/kamailio/kamailio/commit/38d72c3f8248b32b3ba0ff24abd1f2f… Patch: https://github.com/kamailio/kamailio/commit/38d72c3f8248b32b3ba0ff24abd1f2f…

1 0

[kamailio/kamailio] ims_registrar_pcscf: changes for ul db_mode DB_ONLY (PR #3317)
by petermarianF 20 Mar '23

20 Mar '23

Enable registration of pcscf contact callback during download from db location table and inserting pcontact (normally this callback is registered during handling of REGISTER). Refuse REGISTER when pcontact is expired since [0 to 20] seconds. Within this time window a NOTIFY is expected from scscf and in order to avoid race time conditions between scscf and pcscf REGISTER will be refused. Refuse REGISTER when pcontact is expired longer than 20 seconds - send PUBLISH (contact expired) to scscf to trigger NOTIFY. In both REGISTER refused scenarios routing script should reply 500 - Deregister in progress.   #### Pre-Submission Checklist    - [ x] Commit message has the format required by CONTRIBUTING guide - [ x] Commits are split per component (core, individual modules, libs, utils, ...) - [ x] Each component has a single commit (if not, squash them into one commit) - [ x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  In case a pcontact found in location db has to be inserted into pcscf cache depending on contact state also callbacks have to be registered for this pcontact. Registering of callback_pcscf_contact_cb is enabled in this module. Handling of contact expiry is usually triggered in the scscf (mem_timer_udomain which runs every 10 secs). Sending of NOTIFY to pcscf may take up to 20 seconds from start of expiry due to timing conditions. To avoid race time conditions between a REREGISTER and the expiry handler state machine in the scscf an approach is chosen to refuse a REREGISTER in time window of 20 seconds after pcontact expiry on the pcscf (thus allowing expiry handling to finish). REREGISTER is refused in this scenario with new return_code -2. In case a REREGISTER arrives at pcscf and the respective pcontact is expired longer than time window of 20 seconds registration also is refused with rc -2 and additionaly PUBLISH is sent to scscf with expiry = 0. The rc -2 shall be handled in register.cfg script as follows: pcscf_save_pending("location"); switch ($retcode) { case -1: # Missing/wrong Information in REGISTER. send_reply("400", "Information wrong - See log."); exit; break; case -2: # De-Register in Progress, or PUBLISH ongoing due to registration expiry, # or new REGISTER blocked because registration just expired (up to 20sec). append_to_reply("Retry-After: 30\r\n"); send_reply("500", "Deregister in progress - Please try again"); exit; break; } You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3317 -- Commit Summary -- * ims_registrar_pcscf: changes for ul db_mode DB_ONLY -- File Changes -- M src/modules/ims_registrar_pcscf/ims_registrar_pcscf_mod.c (21) M src/modules/ims_registrar_pcscf/notify.c (4) M src/modules/ims_registrar_pcscf/save.c (37) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3317.patch https://github.com/kamailio/kamailio/pull/3317.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3317 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3317(a)github.com>

2 11

Dialog-Module and CSeq tracking
by Carsten Bock 17 Mar '23

17 Mar '23

Hi, Quick question: Looking at the Dialog module and CSeq tracking functionality, I've noticed the following: - on the one hand, we are storing the current CSeq for each direction in the Dialog structure - on the other hand, we are storing a "Delta" of the received vs. updated CSeq as a Dialog Variable Does replacing the Delta with the CSeq already stored with the Dialog structure make sense? I am asking because of my latest changes, where there may be more sources for an updated CSeq (e.g., when sending a Request from script within the Dialog) and more use cases for an updated CSeq (Up and Downstream). I've updated the dialog module for my use already accordingly https://github.com/kamailio/kamailio/compare/master...carstenbock/dialog_cs… I wanted to hear other opinions and possible pitfalls as well... Thanks, Carsten -- Carsten Bock I CTO & Founder ng-voice GmbH Trostbrücke 1 I 20457 Hamburg I Germany T +49 179 2021244 I www.ng-voice.com Registry Office at Local Court Hamburg, HRB 120189 Managing Directors: Dr. David Bachmann, Carsten Bock

3 3

git:master:e8520177: auth_identity: add missing error handling for allocation errors, convert to memory log macros
by Henning Westerholt 14 Mar '23

14 Mar '23

Module: kamailio Branch: master Commit: e8520177f6fd70676251cfd2307c0ab40701a701 URL: https://github.com/kamailio/kamailio/commit/e8520177f6fd70676251cfd2307c0ab… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-03-14T21:14:20Z auth_identity: add missing error handling for allocation errors, convert to memory log macros --- Modified: src/modules/auth_identity/auth_dynstr.c Modified: src/modules/auth_identity/auth_hdrs.c Modified: src/modules/auth_identity/auth_http.c Modified: src/modules/auth_identity/auth_identity.c Modified: src/modules/auth_identity/auth_tables.c --- Diff: https://github.com/kamailio/kamailio/commit/e8520177f6fd70676251cfd2307c0ab… Patch: https://github.com/kamailio/kamailio/commit/e8520177f6fd70676251cfd2307c0ab…

1 0

git:master:7e617ab8: dmq: add missing memory allocation checks, convert to memory log macros
by Henning Westerholt 14 Mar '23

14 Mar '23

Module: kamailio Branch: master Commit: 7e617ab89f5275f1b269382ae2c1fee508854cf1 URL: https://github.com/kamailio/kamailio/commit/7e617ab89f5275f1b269382ae2c1fee… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-03-14T21:10:04Z dmq: add missing memory allocation checks, convert to memory log macros --- Modified: src/modules/dmq/dmq.c Modified: src/modules/dmq/dmq_funcs.c Modified: src/modules/dmq/dmqnode.c Modified: src/modules/dmq/message.c Modified: src/modules/dmq/notification_peer.c Modified: src/modules/dmq/peer.c Modified: src/modules/dmq/worker.c --- Diff: https://github.com/kamailio/kamailio/commit/7e617ab89f5275f1b269382ae2c1fee… Patch: https://github.com/kamailio/kamailio/commit/7e617ab89f5275f1b269382ae2c1fee…

1 0

← Newer
1
...
18
19
20
21
22
23
24
25
26
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2023