sr-dev March 2023

sr-dev@lists.kamailio.org

14 participants
247 discussions

[kamailio/kamailio] core: fix a seg while t_continue with nats module (PR #3396)

by Seven Du

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ x Each component has a single commit (if not, squash them into one commit) - [ x No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  segfault ``` #0 0x0000ffffb9934840 in cfg_update_local (no_cbs=0) at ../../core/cfg/cfg_struct.h:366 366 cfg_child_cb = cfg_child_cb->next; (gdb) print cfg_child_cb $1 = (cfg_child_cb_t *) 0x0 ``` example lua: ``` function ksr_route_nats() KSR.tm.t_newtran() local tindex = KSR.pv.gete("$T(id_index)") local tlabel = KSR.pv.gete("$T(id_label)") KSR.tmx.t_suspend() local req = { jsonrpc = "2.0", method = "route", id = tindex .. ':' .. tlabel, params = { from = KSR.pv.gete("$fu"), to = KSR.pv.gete("$tu"), } } local rpc = cjson.encode(req) KSR.info("rpc: " .. rpc .. "\n") KSR.nats.publish("cn.xswitch.ctrl.route", rpc) KSR.x.exit(); end function handle_nats_response(data) msg = cjson.decode(data) if (not msg) or (not msg.id) then return end KSR.info("========= msg.id: " .. msg.id .. "\n") if not msg.result then KSR.error("response has no result\n") return end tindex, tlabel = msg.id:match("(.+):(.+)") if tindex and tlabel then KSR.pv.sets('$var(nats_response)', data) KSR.tmx.t_continue(tindex, tlabel, 'ksr_nats_continue') end end ``` I'm not sure if it's the proper fix, but this pr fixed the seg. Thanks. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3396 -- Commit Summary -- * core: fix a seg while t_continue with nats module -- File Changes -- M src/core/cfg/cfg_struct.h (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3396.patch https://github.com/kamailio/kamailio/pull/3396.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3396 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3396(a)github.com>

1 year, 1 month

[kamailio/kamailio] tcpops: added tcp_get_conid() for kemi (PR #3402)

by Muhammad Shahzad Shafi

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  In `tcpops` module, the method `tcp_get_conid()` was missing which may be needed to trace, track and log TCP connections, especially for UDP to TCP reply route in KEMI. The patch is tested to work with `master` and `5.6` and above branches. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3402 -- Commit Summary -- * tcpops: added tcp_get_conid() for kemi -- File Changes -- M src/modules/tcpops/tcpops_mod.c (25) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3402.patch https://github.com/kamailio/kamailio/pull/3402.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3402 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3402(a)github.com>

1 year, 1 month

git:master:ea30efdb: tcpops: added tcp_get_conid() for kemi

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: ea30efdbae2b33988e6157ba5e17aba16db156d4 URL: https://github.com/kamailio/kamailio/commit/ea30efdbae2b33988e6157ba5e17aba… Author: Muhammad Shahzad Shafi <muhammad.shafi(a)1und1.de> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-30T21:07:19+02:00 tcpops: added tcp_get_conid() for kemi --- Modified: src/modules/tcpops/tcpops_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/ea30efdbae2b33988e6157ba5e17aba… Patch: https://github.com/kamailio/kamailio/commit/ea30efdbae2b33988e6157ba5e17aba… --- diff --git a/src/modules/tcpops/tcpops_mod.c b/src/modules/tcpops/tcpops_mod.c index 8590e4b6b65..d5dac245024 100644 --- a/src/modules/tcpops/tcpops_mod.c +++ b/src/modules/tcpops/tcpops_mod.c @@ -601,6 +601,26 @@ static int ki_tcp_get_conid_helper(sip_msg_t* msg, str *saddr, pv_spec_t *pvs) return 1; } +/** + * + */ +static int ki_tcp_get_conid(sip_msg_t* msg, str *saddr, str *pvs) +{ + pv_spec_t *dst; + dst = pv_cache_get(pvs); + + if(dst==NULL) { + LM_ERR("failed to get pv spec for: %.*s\n", pvs->len, pvs->s); + return -1; + } + if(dst->setf==NULL) { + LM_ERR("target pv is not writable: %.*s\n", pvs->len, pvs->s); + return -1; + } + + return ki_tcp_get_conid_helper(msg, saddr, dst); +} + /** * */ @@ -855,6 +875,11 @@ static sr_kemi_t sr_kemi_tcpops_exports[] = { { SR_KEMIP_INT, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("tcpops"), str_init("tcp_get_conid"), + SR_KEMIP_INT, ki_tcp_get_conid, + { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { str_init("tcpops"), str_init("tcp_set_otcpid"), SR_KEMIP_INT, ki_tcp_set_otcpid, { SR_KEMIP_INT, SR_KEMIP_NONE, SR_KEMIP_NONE,

1 year, 1 month

git:master:6f8c1bf9: modules: readme files regenerated - acc ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 6f8c1bf967ca3d101a70631df8d77cc7855b3a72 URL: https://github.com/kamailio/kamailio/commit/6f8c1bf967ca3d101a70631df8d77cc… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-03-30T19:31:38+02:00 modules: readme files regenerated - acc ... [skip ci] --- Modified: src/modules/acc/README Modified: src/modules/acc_json/README Modified: src/modules/acc_radius/README Modified: src/modules/alias_db/README Modified: src/modules/app_java/README Modified: src/modules/app_jsdt/README Modified: src/modules/app_lua/README Modified: src/modules/app_lua_sr/README Modified: src/modules/app_perl/README Modified: src/modules/app_python/README Modified: src/modules/app_ruby/README Modified: src/modules/app_sqlang/README Modified: src/modules/async/README Modified: src/modules/auth/README Modified: src/modules/auth_db/README Modified: src/modules/auth_ephemeral/README Modified: src/modules/auth_identity/README Modified: src/modules/auth_radius/README Modified: src/modules/avpops/README --- Diff: https://github.com/kamailio/kamailio/commit/6f8c1bf967ca3d101a70631df8d77cc… Patch: https://github.com/kamailio/kamailio/commit/6f8c1bf967ca3d101a70631df8d77cc…

1 year, 1 month

git: new commits in branch master

by Daniel-Constantin Mierla

- URL: https://github.com/kamailio/kamailio/commit/d394cc62e48fe4636d4c9b2cf9ca8d5… Author: �� <git-dpa(a)aegee.org> Date: 2023-03-30T19:23:29+02:00 acc: typo - URL: https://github.com/kamailio/kamailio/commit/f5cfafa396c5925b8b4694c3e962564… Author: �� <git-dpa(a)aegee.org> Date: 2023-03-30T19:23:29+02:00 acc_json: typos - URL: https://github.com/kamailio/kamailio/commit/63044aab8a915484f90fc21a16c5034… Author: �� <git-dpa(a)aegee.org> Date: 2023-03-30T19:23:29+02:00 acc_radius: typo - URL: https://github.com/kamailio/kamailio/commit/7e6942f283237033da9c211d5342e96… Author: �� <git-dpa(a)aegee.org> Date: 2023-03-30T19:23:29+02:00 alias_db: typo - URL: https://github.com/kamailio/kamailio/commit/0a062c9e52f61b48f6daf46756aeebb… Author: �� <git-dpa(a)aegee.org> Date: 2023-03-30T19:23:29+02:00 app_java: typos - URL: https://github.com/kamailio/kamailio/commit/ca2c51143aab9ffafbb4f0a5474beb2… Author: �� <git-dpa(a)aegee.org> Date: 2023-03-30T19:23:29+02:00 app_jsdt: typos - URL: https://github.com/kamailio/kamailio/commit/9083ee603161475e805beb729ce4d11… Author: �� <git-dpa(a)aegee.org> Date: 2023-03-30T19:23:29+02:00 app_lua: typos - URL: https://github.com/kamailio/kamailio/commit/f066bc53bf64791719ee3f97f2641aa… Author: �� <git-dpa(a)aegee.org> Date: 2023-03-30T19:23:29+02:00 app_lua_sr: typos - URL: https://github.com/kamailio/kamailio/commit/051af44ddb92a3b31f0236e4b430edc… Author: �� <git-dpa(a)aegee.org> Date: 2023-03-30T19:23:29+02:00 app_mono: typos - URL: https://github.com/kamailio/kamailio/commit/f833583fb02a9d26665692b02b4a2cf… Author: �� <git-dpa(a)aegee.org> Date: 2023-03-30T19:23:29+02:00 app_perl: typos - URL: https://github.com/kamailio/kamailio/commit/f57dae9081d54b364285fe4950426f8… Author: �� <git-dpa(a)aegee.org> Date: 2023-03-30T19:23:29+02:00 app_python: typo - URL: https://github.com/kamailio/kamailio/commit/909e339becdc5db93830d9c3f0934a6… Author: �� <git-dpa(a)aegee.org> Date: 2023-03-30T19:23:29+02:00 app_ruby: typos - URL: https://github.com/kamailio/kamailio/commit/fe06f13c4d41cff9ee2b0d62926102d… Author: �� <git-dpa(a)aegee.org> Date: 2023-03-30T19:23:29+02:00 app_sqlang: typos - URL: https://github.com/kamailio/kamailio/commit/3f0c5103c661f73c9d172cd3728226e… Author: �� <git-dpa(a)aegee.org> Date: 2023-03-30T19:23:29+02:00 async: typos - URL: https://github.com/kamailio/kamailio/commit/0cb433212526537624ff51eb659cb22… Author: �� <git-dpa(a)aegee.org> Date: 2023-03-30T19:23:29+02:00 auth: typos - URL: https://github.com/kamailio/kamailio/commit/2d88dbe4dada18784a75cd228f55e8a… Author: �� <git-dpa(a)aegee.org> Date: 2023-03-30T19:23:29+02:00 auth_db: typos - URL: https://github.com/kamailio/kamailio/commit/95b9ad47fbf4f8444aa94aeb39c8c44… Author: �� <git-dpa(a)aegee.org> Date: 2023-03-30T19:23:29+02:00 auth_diameter: typos - URL: https://github.com/kamailio/kamailio/commit/22535e19236c1d1cefca02d0b1d50b5… Author: �� <git-dpa(a)aegee.org> Date: 2023-03-30T19:23:29+02:00 auth_ephemeral: typos - URL: https://github.com/kamailio/kamailio/commit/da353c293ba46abbb21b5bcbbfa8e75… Author: �� <git-dpa(a)aegee.org> Date: 2023-03-30T19:23:29+02:00 auth_identiy: typos - URL: https://github.com/kamailio/kamailio/commit/1fd32a957a136214ed7d521595eb135… Author: �� <git-dpa(a)aegee.org> Date: 2023-03-30T19:23:29+02:00 auth_radius: typos - URL: https://github.com/kamailio/kamailio/commit/0b986aeeffa7faa14f7e954df01cfb0… Author: �� <git-dpa(a)aegee.org> Date: 2023-03-30T19:23:29+02:00 avpops: typos

1 year, 1 month

[kamailio/kamailio] Typos (PR #3375)

by Дилян Палаузов

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3375 -- Commit Summary -- * acc: typo * acc_json: typos * acc_radius: typo * alias_db: typo * app_java: typos * app_jsdt: typos * app_lua: typos * app_lua_sr: typos * app_mono: typos * app_perl: typos * app_python: typo * app_ruby: typos * app_sqlang: typos * async: typos * auth: typos * auth_db: typos * auth_diameter: typos * auth_ephemeral: typos * auth_identiy: typos * auth_radius: typos * avpops: typos -- File Changes -- M src/modules/acc/doc/acc_admin.xml (2) M src/modules/acc_json/acc_json_mod.c (2) M src/modules/acc_json/doc/acc_json_admin.xml (2) M src/modules/acc_radius/doc/acc_radius_admin.xml (2) M src/modules/alias_db/doc/alias_db_admin.xml (2) M src/modules/app_java/README-draft (12) M src/modules/app_java/doc/app_java_admin.xml (4) M src/modules/app_java/kamailio_java_folder/java-untested/siprouter_src/SipMsg.java (2) M src/modules/app_java/kamailio_java_folder/java/siprouter_src/SipMsg.java (2) M src/modules/app_jsdt/app_jsdt_mod.c (8) M src/modules/app_jsdt/doc/app_jsdt_admin.xml (4) M src/modules/app_jsdt/duktape.c (10) M src/modules/app_lua/app_lua_mod.c (10) M src/modules/app_lua/doc/app_lua_admin.xml (2) M src/modules/app_lua_sr/doc/app_lua_sr_admin.xml (4) M src/modules/app_mono/app_mono_mod.c (4) M src/modules/app_perl/app_perl_mod.c (2) M src/modules/app_perl/doc/app_perl_admin.xml (4) M src/modules/app_perl/doc/app_perl_pod.xml (2) M src/modules/app_perl/doc/app_perl_samples.xml (2) M src/modules/app_perl/lib/perl/Kamailio/LDAPUtils/LDAPConf.pm (4) M src/modules/app_python/doc/app_python_admin.xml (2) M src/modules/app_ruby/app_ruby_mod.c (2) M src/modules/app_ruby/doc/app_ruby_admin.xml (2) M src/modules/app_sqlang/app_sqlang_mod.c (8) M src/modules/app_sqlang/doc/app_sqlang_admin.xml (2) M src/modules/app_sqlang/squirrel/sqstdlib/sqstdrex.cpp (2) M src/modules/app_sqlang/squirrel/squirrel/sqvm.cpp (6) M src/modules/async/doc/async_admin.xml (4) M src/modules/auth/auth.xml (18) M src/modules/auth/doc/auth_functions.xml (2) M src/modules/auth/doc/auth_params.xml (14) M src/modules/auth/nc.c (6) M src/modules/auth/nid.h (4) M src/modules/auth/ot_nonce.c (6) M src/modules/auth_db/authorize.c (2) M src/modules/auth_db/doc/auth_db_admin.xml (4) M src/modules/auth_diameter/authorize.c (2) M src/modules/auth_diameter/authorize.h (2) M src/modules/auth_diameter/avp.c (2) M src/modules/auth_diameter/defs.h (2) M src/modules/auth_diameter/message.c (2) M src/modules/auth_diameter/tcp_comm.c (2) M src/modules/auth_ephemeral/auth_ephemeral_mod.c (2) M src/modules/auth_ephemeral/doc/auth_ephemeral_admin.xml (2) M src/modules/auth_identity/auth_hdrs.c (2) M src/modules/auth_identity/auth_identity.c (10) M src/modules/auth_identity/auth_tables.c (10) M src/modules/auth_identity/doc/auth_identity_functions.xml (2) M src/modules/auth_radius/doc/auth_radius_admin.xml (2) M src/modules/auth_radius/sterman.c (2) M src/modules/avpops/avpops.c (4) M src/modules/avpops/doc/avpops_admin.xml (8) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3375.patch https://github.com/kamailio/kamailio/pull/3375.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3375 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3375(a)github.com>

1 year, 1 month

HTTPS for xHTTP module

by luca.nardin＠kontron.com

Hello, we need to use kamailio to handle some HTTP(S) GET requests coming from another REST client and we are considering to use the xHTTP module of kamailio. It seems this module only supports HTTP and not HTTPS connections, is that correct? Kind regards, Luca Nardin Kontron Transportation

1 year, 1 month

[kamailio/kamailio] uac_redirect: Module fails to load [regression] (Issue #3188)

by Alex Hermann

The uac_redirect fails to load in 5.6. It used to load fine before. It is complaining about the acc API, which it never did before. I don't use the acc module and fail to see why uac_redirect would need it. ``` 2022-07-15T14:41:43.813169+02:00 pc1 proxy1[381424]: ERROR: uac_redirect [../../modules/acc/acc_api.h:191]: acc_load_api(): cannot find bind_acc 2022-07-15T14:41:43.813232+02:00 pc1 proxy1[381424]: ERROR: uac_redirect [uac_redirect.c:254]: redirect_init(): cannot bind to ACC API 2022-07-15T14:41:43.813283+02:00 pc1 proxy1[381424]: ERROR: <core> [core/sr_module.c:971]: init_mod(): Error while initializing module uac_redirect (/usr/lib/x86_64-linux-gnu/kamailio/modules/uac_redirect.so) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3188 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3188(a)github.com>

1 year, 1 month

[kamailio/kamailio] core:tcp allow to handle TCP connections with tcp_accept_haproxy=yes flag even message does not contain PROXY protocol header (#2206)

by ovoshlook

Covers setups when kamailio behind the service with HAPROXY protocol support but in other hand it also serves requests from other services that available per direct connection (such as B2BUA in the same local network). #### Pre-Submission Checklist - [*] Commit message has the format required by CONTRIBUTING guide - [*] Commits are split per component (core, individual modules, libs, utils, ...) - [*] Each component has a single commit (if not, squash them into one commit) - [*] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [*] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [*] PR should be backported to stable branches - [*] Tested changes locally #### Description - function tcpconn_read_haproxy() returns 2 if PROXY header NOT found. - Message about no header shown at the debug level. - No errors - TCP connection successfully establishes You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2206 -- Commit Summary -- * handle tcp request with tcp_accept_haproxy even no PROXY header found * core:tcp allow to handle TCP connections even message does not contain PROXY protocol header * core:tcp allow to handle TCP connections even message does not contain PROXY protocol header -- File Changes -- M src/core/tcp_main.c (8) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2206.patch https://github.com/kamailio/kamailio/pull/2206.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2206

1 year, 1 month

git:5.5:bbb40895: ndb_redis: fix index on parsing sentinel address

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.5 Commit: bbb40895bc74810b37df2760bee309025fca27af URL: https://github.com/kamailio/kamailio/commit/bbb40895bc74810b37df2760bee3090… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-30T12:54:26+02:00 ndb_redis: fix index on parsing sentinel address (cherry picked from commit 5c8eed0ce78d029f28a1819262516940b7dd749e) (cherry picked from commit d4ff1550a7c7f9647236f03559dc2fc3106a2b8d) --- Modified: src/modules/ndb_redis/redis_client.c --- Diff: https://github.com/kamailio/kamailio/commit/bbb40895bc74810b37df2760bee3090… Patch: https://github.com/kamailio/kamailio/commit/bbb40895bc74810b37df2760bee3090… --- diff --git a/src/modules/ndb_redis/redis_client.c b/src/modules/ndb_redis/redis_client.c index fd6e124bdc..50efb1906e 100644 --- a/src/modules/ndb_redis/redis_client.c +++ b/src/modules/ndb_redis/redis_client.c @@ -160,7 +160,7 @@ int redisc_init(void) port = 6379; if( (pos = strchr(sentinelAddr, ':')) != NULL ) { port = atoi(pos+1); - pos[i] = '\0'; + pos[0] = '\0'; } redis = redisConnectWithTimeout(sentinelAddr, port, tv_conn);

1 year, 1 month

← Newer
1
...
11
12
13
14
15
16
17
...
25
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2023