sr-dev November 2023

sr-dev@lists.kamailio.org

15 participants
391 discussions

git:master:7bdd7fb4: dialog: use memcpy to fill profile uid
by Daniel-Constantin Mierla 09 Nov '23

09 Nov '23

Module: kamailio Branch: master Commit: 7bdd7fb4aa666b5f56ae3e554770126ad5b68c2e URL: https://github.com/kamailio/kamailio/commit/7bdd7fb4aa666b5f56ae3e554770126… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-09T15:32:39+01:00 dialog: use memcpy to fill profile uid --- Modified: src/modules/dialog/dlg_profile.c --- Diff: https://github.com/kamailio/kamailio/commit/7bdd7fb4aa666b5f56ae3e554770126… Patch: https://github.com/kamailio/kamailio/commit/7bdd7fb4aa666b5f56ae3e554770126… --- diff --git a/src/modules/dialog/dlg_profile.c b/src/modules/dialog/dlg_profile.c index fd605d000c9..5dd3b372d49 100644 --- a/src/modules/dialog/dlg_profile.c +++ b/src/modules/dialog/dlg_profile.c @@ -603,7 +603,9 @@ int set_dlg_profile( } sruid_next_safe(&_dlg_profile_sruid); if(_dlg_profile_sruid.uid.len < SRUID_SIZE) { - strcpy(linker->hash_linker.puid, _dlg_profile_sruid.uid.s); + memcpy(linker->hash_linker.puid, _dlg_profile_sruid.uid.s, + _dlg_profile_sruid.uid.len); + linker->hash_linker.puid[_dlg_profile_sruid.uid.len] = '\0'; linker->hash_linker.puid_len = _dlg_profile_sruid.uid.len; } else { LM_ERR("sruid size is too large\n"); @@ -951,7 +953,7 @@ int dlg_set_timeout_by_profile( unsigned int h_id; unsigned int h_entry; struct dlg_map_list *next; - } * map_head, *map_scan, *map_scan_next; + } *map_head, *map_scan, *map_scan_next; map_head = NULL;

1 0

git:master:36806bea: imc: coverted some static global str variables to macros
by Daniel-Constantin Mierla 09 Nov '23

09 Nov '23

Module: kamailio Branch: master Commit: 36806bea261f7a29dc1d2a8aedac837a06043968 URL: https://github.com/kamailio/kamailio/commit/36806bea261f7a29dc1d2a8aedac837… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-09T14:54:13+01:00 imc: coverted some static global str variables to macros --- Modified: src/modules/imc/imc_cmd.c --- Diff: https://github.com/kamailio/kamailio/commit/36806bea261f7a29dc1d2a8aedac837… Patch: https://github.com/kamailio/kamailio/commit/36806bea261f7a29dc1d2a8aedac837…

1 0

git:master:9b01012b: core: use string building functions with explicit lenght
by Daniel-Constantin Mierla 09 Nov '23

09 Nov '23

Module: kamailio Branch: master Commit: 9b01012b5fab43ca3b1ddc7d7493b0edc69cdceb URL: https://github.com/kamailio/kamailio/commit/9b01012b5fab43ca3b1ddc7d7493b0e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-09T10:44:00+01:00 core: use string building functions with explicit lenght --- Modified: src/core/sr_module.c --- Diff: https://github.com/kamailio/kamailio/commit/9b01012b5fab43ca3b1ddc7d7493b0e… Patch: https://github.com/kamailio/kamailio/commit/9b01012b5fab43ca3b1ddc7d7493b0e… --- diff --git a/src/core/sr_module.c b/src/core/sr_module.c index 1b7ea7332d2..9660afce320 100644 --- a/src/core/sr_module.c +++ b/src/core/sr_module.c @@ -326,8 +326,7 @@ static int register_module(module_exports_t *e, char *path, void *handle) LM_ERR("too long module name: %s\n", mod->exports.name); goto error; } - strcpy(defmod, "MOD_"); - strcat(defmod, mod->exports.name); + snprintf(defmod, 64, "MOD_%s", mod->exports.name); pp_define_set_type(KSR_PPDEF_DEFINE); if(pp_define(strlen(defmod), defmod) < 0) { LM_ERR("unable to set cfg define for module: %s\n", mod->exports.name); @@ -402,6 +401,7 @@ int ksr_locate_module(char *mod_path, char **new_path) { struct stat stat_buf; str modname; + str modfile; char *mdir; char *nxt_mdir; char *path; @@ -412,11 +412,14 @@ int ksr_locate_module(char *mod_path, char **new_path) *new_path = NULL; path = mod_path; path_type = 0; - modname.s = path; - modname.len = strlen(mod_path); - if(modname.len > 3 && strcmp(modname.s + modname.len - 3, ".so") == 0) { + modfile.s = path; + modfile.len = strlen(mod_path); + modname.s = modfile.s; + if(modfile.len > 3 && strcmp(modfile.s + modfile.len - 3, ".so") == 0) { path_type = 1; - modname.len -= 3; + modname.len = modfile.len - 3; + } else { + modname.len = modfile.len; } if(!strchr(path, '/')) path_type |= 2; @@ -445,9 +448,12 @@ int ksr_locate_module(char *mod_path, char **new_path) len++; } path[len] = 0; - strcat(path, modname.s); - if(!(path_type & 1)) + if(path_type & 1) { + strncat(path, modfile.s, modfile.len); + } else { + strncat(path, modname.s, modname.len); strcat(path, ".so"); + } if(stat(path, &stat_buf) == -1) { LM_DBG("module file not found <%s>\n", path); @@ -470,9 +476,12 @@ int ksr_locate_module(char *mod_path, char **new_path) path[len] = 0; strncat(path, modname.s, modname.len); strcat(path, "/"); - strcat(path, modname.s); - if(!(path_type & 1)) + if(path_type & 1) { + strncat(path, modfile.s, modfile.len); + } else { + strncat(path, modname.s, modname.len); strcat(path, ".so"); + } if(stat(path, &stat_buf) == -1) { LM_DBG("module file not found <%s>\n", path);

1 0

git:master:af86d0e2: modules: readme files regenerated - ims_charging ... [skip ci]
by The Root 09 Nov '23

09 Nov '23

Module: kamailio Branch: master Commit: af86d0e27b9a66cff392fd5e462901864bc3dc18 URL: https://github.com/kamailio/kamailio/commit/af86d0e27b9a66cff392fd5e4629018… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: The Root <root(a)kamailio.org> Date: 2023-11-09T09:31:21+01:00 modules: readme files regenerated - ims_charging ... [skip ci] --- Modified: src/modules/ims_charging/README --- Diff: https://github.com/kamailio/kamailio/commit/af86d0e27b9a66cff392fd5e4629018… Patch: https://github.com/kamailio/kamailio/commit/af86d0e27b9a66cff392fd5e4629018…

1 0

git:master:8269b719: modules: readme files regenerated - rtpengine ... [skip ci]
by Kamailio Dev 09 Nov '23

09 Nov '23

Module: kamailio Branch: master Commit: 8269b719775ce704eade4a832ae8abb56af08841 URL: https://github.com/kamailio/kamailio/commit/8269b719775ce704eade4a832ae8abb… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-11-09T09:32:21+01:00 modules: readme files regenerated - rtpengine ... [skip ci] --- Modified: src/modules/rtpengine/README --- Diff: https://github.com/kamailio/kamailio/commit/8269b719775ce704eade4a832ae8abb… Patch: https://github.com/kamailio/kamailio/commit/8269b719775ce704eade4a832ae8abb… --- diff --git a/src/modules/rtpengine/README b/src/modules/rtpengine/README index b4e71c7eafa..96693dcd018 100644 --- a/src/modules/rtpengine/README +++ b/src/modules/rtpengine/README @@ -463,8 +463,8 @@ Chapter 1. Admin Guide would specify the weight 2 for this server, for example. The selection of the set is done from script prior using - rtpengine_delete(), rtpengine_offer() or rtpengine_answer() functions - - see the set_rtpengine_set() function. + rtpengine_delete(), rtpengine_offer(), rtpengine_answer() or + rtpengine_manage() functions - see the set_rtpengine_set() function. Another way to select the set is to define setid_avp module parameter and assign setid to the defined avp before calling rtpengine_offer() or @@ -2150,7 +2150,6 @@ modparam("rtpengine", "dtmf_events_sock", "127.0.0.1:2223") sends it back to the module to be placed back into the SIP message. This is useful if you have a set of RTP proxies that the caller must use, and another distinct set of RTP proxies that the callee must use. - This is supported by all rtpengine commands except rtpengine_manage(). This function can be used from REQUEST_ROUTE, ONREPLY_ROUTE, BRANCH_ROUTE.

1 0

git:master:aab0e4a3: rtpengine: remove mistaken statement for set_rtpengine_set() about rtpengine_manage()
by Daniel-Constantin Mierla 09 Nov '23

09 Nov '23

Module: kamailio Branch: master Commit: aab0e4a3b86f309f8a0333d20f632fec1158af9f URL: https://github.com/kamailio/kamailio/commit/aab0e4a3b86f309f8a0333d20f632fe… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-09T09:27:07+01:00 rtpengine: remove mistaken statement for set_rtpengine_set() about rtpengine_manage() --- Modified: src/modules/rtpengine/doc/rtpengine_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/aab0e4a3b86f309f8a0333d20f632fe… Patch: https://github.com/kamailio/kamailio/commit/aab0e4a3b86f309f8a0333d20f632fe… --- diff --git a/src/modules/rtpengine/doc/rtpengine_admin.xml b/src/modules/rtpengine/doc/rtpengine_admin.xml index cc1dc3025bf..1e394453493 100644 --- a/src/modules/rtpengine/doc/rtpengine_admin.xml +++ b/src/modules/rtpengine/doc/rtpengine_admin.xml @@ -52,8 +52,8 @@ </para> <para> The selection of the set is done from script prior using - rtpengine_delete(), rtpengine_offer() or rtpengine_answer() - functions - see the set_rtpengine_set() function. + rtpengine_delete(), rtpengine_offer(), rtpengine_answer() or + rtpengine_manage() functions - see the set_rtpengine_set() function. </para> <para> Another way to select the set is to define setid_avp @@ -2328,10 +2328,10 @@ modparam("rtpengine", "wsapi", "lwsc") <section id="rtpengine.p.dtmf_events_sock" xreflabel="dtmf_events_sock"> <title><varname>dtmf_events_sock</varname> (string)</title> <para> - Definition of IPv4/IPv6 UDP socket used to receive dtmf events from RTPEngine. + Definition of IPv4/IPv6 UDP socket used to receive dtmf events from RTPEngine. </para> <para> - DTMF events coming from RTPEngine will trigger rtpengine:dtmf-event route. + DTMF events coming from RTPEngine will trigger rtpengine:dtmf-event route. </para> <para> <emphasis> @@ -2374,8 +2374,7 @@ modparam("rtpengine", "dtmf_events_sock", "127.0.0.1:2223") another time and sends it back to the module to be placed back into the &sip; message. This is useful if you have a set of &rtp; proxies that the caller must use, and another distinct set of &rtp; proxies that the - callee must use. This is supported by all rtpengine commands except - rtpengine_manage(). + callee must use. </para> <para> This function can be used from REQUEST_ROUTE, ONREPLY_ROUTE, @@ -2519,7 +2518,7 @@ rtpengine_offer(); of ignoring endpoint addresses in the &sdp; body. </para></listitem> <listitem><para> - <emphasis>received-from=IP</emphasis> - Configure the SIP-source-address IP + <emphasis>received-from=IP</emphasis> - Configure the SIP-source-address IP explicitly, which will be useful when two kamailio is cascaded where first kamailio is handling NAT and second kamailio RTPEngine. </para></listitem>

1 0

git:master:12dcdd36: devcontainer: use prebuild image [skip ci]
by Victor Seva 08 Nov '23

08 Nov '23

Module: kamailio Branch: master Commit: 12dcdd3664bbb990cd749872bea3744bb7eff315 URL: https://github.com/kamailio/kamailio/commit/12dcdd3664bbb990cd749872bea3744… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-11-08T23:33:38+01:00 devcontainer: use prebuild image [skip ci] --- Modified: .devcontainer/devcontainer.json --- Diff: https://github.com/kamailio/kamailio/commit/12dcdd3664bbb990cd749872bea3744… Patch: https://github.com/kamailio/kamailio/commit/12dcdd3664bbb990cd749872bea3744… --- diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 7ab1083ed00..2a0413eae4d 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -4,6 +4,7 @@ */ "name": "Debian", "build": { + "cacheFrom": "ghcr.io/kamailio/kamailio-master-devcontainer", "context": "../pkg/kamailio/deb", "dockerfile": "Dockerfile" },

1 0

git:master:721bfc88: devcontainer: add github-cli
by Victor Seva 08 Nov '23

08 Nov '23

Module: kamailio Branch: master Commit: 721bfc880a7c01b1792e5770a26fc7d5fe4faa42 URL: https://github.com/kamailio/kamailio/commit/721bfc880a7c01b1792e5770a26fc7d… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-11-08T22:46:07+01:00 devcontainer: add github-cli --- Modified: .devcontainer/devcontainer.json --- Diff: https://github.com/kamailio/kamailio/commit/721bfc880a7c01b1792e5770a26fc7d… Patch: https://github.com/kamailio/kamailio/commit/721bfc880a7c01b1792e5770a26fc7d… --- diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index bc6019c6877..7ab1083ed00 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -10,7 +10,8 @@ // Features to add to the dev container. More info: https://containers.dev/features. "features": { - "ghcr.io/wxw-matt/devcontainer-features/command_runner:0": {} + "ghcr.io/wxw-matt/devcontainer-features/command_runner:0": {}, + "ghcr.io/devcontainers/features/github-cli:1": {} }, // Use 'forwardPorts' to make a list of ports inside the container available locally.

1 0

git:master:38585ea2: github: prebuild devcontainer image
by Victor Seva 08 Nov '23

08 Nov '23

Module: kamailio Branch: master Commit: 38585ea29773543d9c2fe3559005487511ac90ce URL: https://github.com/kamailio/kamailio/commit/38585ea29773543d9c2fe3559005487… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-11-08T22:45:54+01:00 github: prebuild devcontainer image --- Added: .github/workflows/devcontainer.yaml --- Diff: https://github.com/kamailio/kamailio/commit/38585ea29773543d9c2fe3559005487… Patch: https://github.com/kamailio/kamailio/commit/38585ea29773543d9c2fe3559005487… --- diff --git a/.github/workflows/devcontainer.yaml b/.github/workflows/devcontainer.yaml new file mode 100644 index 00000000000..3321b4feec4 --- /dev/null +++ b/.github/workflows/devcontainer.yaml @@ -0,0 +1,56 @@ + +--- +name: build devcontainer image +'on': + push: + branches: + - master + # Allows you to run this workflow manually from the Actions tab + workflow_dispatch: + +env: + DIST: bookworm + +jobs: + build: + runs-on: ubuntu-latest + permissions: + contents: read + packages: write + steps: + - uses: actions/checkout@v4 + with: + fetch-depth: 2 + + - name: print latest_commit + run: echo ${{ github.sha }} + + - name: Get changed files + id: changed-files + uses: tj-actions/changed-files@v40 + with: + since_last_remote_commit: true + + - name: changes in relevant files + id: changed-files-builder + uses: tj-actions/changed-files@v40 + with: + files: | + .devcontainer/** + pkg/kamailio/deb/${{ env.DIST }}/** + + - name: Login to GitHub Container Registry + if: steps.changed-files-builder.outputs.any_changed == 'true' + uses: docker/login-action@v3 + with: + registry: ghcr.io + username: ${{ github.repository_owner }} + password: ${{ secrets.GITHUB_TOKEN }} + + - name: Pre-build dev container image + if: steps.changed-files-builder.outputs.any_changed == 'true' + uses: devcontainers/ci(a)v0.3 + with: + imageName: ghcr.io/${{ github.repository_owner }}/kamailio-${{ github.ref_name }}-devcontainer + cacheFrom: ghcr.io/${{ github.repository_owner }}/kamailio-${{ github.ref_name }}-devcontainer + push: always

1 0

git:master:9b4fe94d: devcontainer: add gitlens extension [skip ci]
by Victor Seva 08 Nov '23

08 Nov '23

Module: kamailio Branch: master Commit: 9b4fe94d71c25e9ac3a43a5010a5dece7adaf14c URL: https://github.com/kamailio/kamailio/commit/9b4fe94d71c25e9ac3a43a5010a5dec… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-11-08T20:57:11+01:00 devcontainer: add gitlens extension [skip ci] --- Modified: .devcontainer/devcontainer.json --- Diff: https://github.com/kamailio/kamailio/commit/9b4fe94d71c25e9ac3a43a5010a5dec… Patch: https://github.com/kamailio/kamailio/commit/9b4fe94d71c25e9ac3a43a5010a5dec… --- diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index a0f156e25bb..bc6019c6877 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -25,6 +25,7 @@ "extensions": [ "ms-vscode.cpptools-extension-pack", "GitHub.vscode-github-actions", + "eamodio.gitlens", "xaver.clang-format" ] }

1 0

← Newer
1
...
31
32
33
34
35
36
37
...
40
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2023