sr-dev November 2023

sr-dev@lists.kamailio.org

15 participants
391 discussions

git:master:e17b554b: ims_charging: Various changes to make module compatible to other charging servers
by Daniel-Constantin Mierla 22 Nov '23

22 Nov '23

Module: kamailio Branch: master Commit: e17b554ba918dc33c60f41c2cee50ad2578fbbd3 URL: https://github.com/kamailio/kamailio/commit/e17b554ba918dc33c60f41c2cee50ad… Author: Morten Tryfoss <morten(a)tryfoss.no> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-22T09:36:44+01:00 ims_charging: Various changes to make module compatible to other charging servers - Use origin-host of CCR response as destination-host of subsequent CCR requests, to make sure those requests are routed to the same charging server (when using relay). - use str_dup and str_free from ims_getters instead of locally defined. - Honour AVP_Time_Quota_Threshold in CCR response, as an alternative to static configured modparam "timer_buffer". - Add new modparam "strip_plus_from_e164" to enable sending subscription id with correct format according to specified type in the AVP. - Moved subscription id formatting into a common function. - Handle CCR response without AVP_Validity_Time set correctly. Was interpreted as immediate expire. - Handle IMS_RAR (Re-auth) request from charging server. Triggers an immediate interim update if the session is alive. - Handle IMS_ASR (Abort) request from charging server. Triggers an immediate termination of the session/call. - Fixed issue with signed/unsigned int related to check for Expires header. cscf_get_expires_hdr() returns signed (-1 for not found), while that value was added to the outgoing diameter request unsigned. That again resulted in an Expires AVP with a really large value, and was rejected by the charging server. --- Modified: src/modules/ims_charging/Ro_data.c Modified: src/modules/ims_charging/Ro_data.h Modified: src/modules/ims_charging/ccr.c Modified: src/modules/ims_charging/config.h Modified: src/modules/ims_charging/dialog.c Modified: src/modules/ims_charging/doc/ims_charging_admin.xml Modified: src/modules/ims_charging/ims_charging_mod.c Modified: src/modules/ims_charging/ims_ro.c Modified: src/modules/ims_charging/ims_ro.h Modified: src/modules/ims_charging/ro_db_handler.c Modified: src/modules/ims_charging/ro_db_handler.h Modified: src/modules/ims_charging/ro_session_hash.c Modified: src/modules/ims_charging/ro_session_hash.h Modified: src/modules/ims_charging/ro_timer.c Modified: utils/kamctl/mysql/ims_charging-create.sql --- Diff: https://github.com/kamailio/kamailio/commit/e17b554ba918dc33c60f41c2cee50ad… Patch: https://github.com/kamailio/kamailio/commit/e17b554ba918dc33c60f41c2cee50ad…

1 0

git:master:6cd9f310: cdp: Add support for re-auth on ro sessions initiated from charging server
by Daniel-Constantin Mierla 22 Nov '23

22 Nov '23

Module: kamailio Branch: master Commit: 6cd9f310a0af9bf6024696d436b6b96491808832 URL: https://github.com/kamailio/kamailio/commit/6cd9f310a0af9bf6024696d436b6b96… Author: Morten Tryfoss <morten(a)tryfoss.no> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-22T09:36:44+01:00 cdp: Add support for re-auth on ro sessions initiated from charging server - handle missing valid_for in CCA correctly, for chargings server not using it - add AVP_Time_Quota_Threshold AVP, to support server controlled CCR-U threshold --- Modified: src/modules/cdp/acctstatemachine.c Modified: src/modules/cdp/diameter_code_avp.h Modified: src/modules/cdp/peerstatemachine.c Modified: src/modules/cdp/session.c --- Diff: https://github.com/kamailio/kamailio/commit/6cd9f310a0af9bf6024696d436b6b96… Patch: https://github.com/kamailio/kamailio/commit/6cd9f310a0af9bf6024696d436b6b96… --- diff --git a/src/modules/cdp/acctstatemachine.c b/src/modules/cdp/acctstatemachine.c index 398526d86d7..aad4ca1cc04 100644 --- a/src/modules/cdp/acctstatemachine.c +++ b/src/modules/cdp/acctstatemachine.c @@ -176,6 +176,8 @@ int cc_acc_client_stateful_sm_process( //nothing we can do here, we have sent callback, client needs to send CCR Update LM_DBG("Reservation close to expiring\n"); break; + case ACC_CC_EV_SESSION_MODIFIED: + break; default: LM_ERR("Received unknown event [%d] in state [%d]\n", event, x->state); diff --git a/src/modules/cdp/diameter_code_avp.h b/src/modules/cdp/diameter_code_avp.h index 32987538dee..262ab62c012 100644 --- a/src/modules/cdp/diameter_code_avp.h +++ b/src/modules/cdp/diameter_code_avp.h @@ -266,6 +266,8 @@ typedef enum AVP_Service_Selection = 493, //RFC5778 AVP_Call_Id = 494, + AVP_Time_Quota_Threshold = 868, // 3GPP TS 32.299 + } AAA_AVPCodeNr; enum diff --git a/src/modules/cdp/peerstatemachine.c b/src/modules/cdp/peerstatemachine.c index 24d5aed959e..74d119b70f2 100644 --- a/src/modules/cdp/peerstatemachine.c +++ b/src/modules/cdp/peerstatemachine.c @@ -1350,11 +1350,9 @@ void Rcv_Process(peer *p, AAAMessage *msg) switch(session->type) { case ACCT_CC_CLIENT: if(is_req(msg)) { - LM_WARN("unhandled receive request on Credit Control Acct " - "session\n"); - AAASessionsUnlock( - session->hash); //must be called because we don't call state machine here - session = 0; //we don't call SM here so we must not set to 0 + cc_acc_client_stateful_sm_process( + session, ACC_CC_EV_SESSION_MODIFIED, msg); + session = 0; } else { cc_acc_client_stateful_sm_process( session, ACC_CC_EV_RECV_ANS, msg); diff --git a/src/modules/cdp/session.c b/src/modules/cdp/session.c index e6e23fcbcf6..cd169f103ab 100644 --- a/src/modules/cdp/session.c +++ b/src/modules/cdp/session.c @@ -491,7 +491,7 @@ int cdp_sessions_timer(time_t now, void *ptr) 15; //15 seconds - TODO: add as config parameter //we should check for reservation expiring if the state is open if(x->u.cc_acc.state == ACC_CC_ST_OPEN) { - if(last_res_timestamp) { + if(last_res_timestamp && res_valid_for) { //we have obv already started reservations if((last_res_timestamp + res_valid_for) < (time(0) + last_reservation

1 0

[kamailio/kamailio] ims_charging: Various improvements to make module compatible to other charging server vendors (PR #3640)
by Morten Tryfoss 22 Nov '23

22 Nov '23

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description **Use origin-host of CCR response as destination-host of subsequent CCR requests** When connecting to a diameter node which using relay, it may load balance requests to multiple servers for handling. This change ensures that subsequent requests are sent to the same server. **Honour AVP_Time_Quota_Threshold in CCR response** Charging server indicates it want an interim update X number of seconds before all quota has been used. **Add new modparam «strip_plus_from_e164»** The existing formatitng routine check if it's a tel: or sip: uri, and sets E.164 or SIP according to that. If it's E.164, it strips "tel:" too. A subscription id with leading "+" is actually of type SIP. I didn't want to make a breaking change here, so I introduced a new setting which fixes the behaviour. **Moved subscription id formatting into a common function** For more clean code, and one place to make further adjustments. **Handle CCR response without AVP_Validity_Time** If missing, various places in the module reported immediate expire. **Handle IMS_RAR (Re-auth) request from charging server** Typical scenario is that there's a missing interim update, and the server want to check if the session is still alive. At reception we try a lookup and if found, schedule a new request. **Handle IMS_ASR (Abort) request from charging server** Similar handling as for re-auth, but for server-initiated termination of the call. **Fixed issue with signed/unsigned int related to check for Expires header** cscf_get_expires_hdr() returns signed (-1 for not found), while that value was added to the outgoing diameter request unsigned. That again resulted in an Expires AVP with a really large value, and was rejected by the charging server. Most probably cscf_get_expires_hdr() should be changed to return unsigned since the value theoretical can be that big, but since that is a common function for the ims modules it would require more testing than I'm capable of right now. **Use str_dup() and str_free() from ims_getters instead of locally defined** Those were needed more places. -- I'm a little bit unsure about updating a string allocated in shm, where the length is changed (look in ims_ro.c, credit_control_session_callback()). Is the correct way to do a shm_free() and then reallocate, or is there a more simple way of doing it? You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3640 -- Commit Summary -- * cdp: Add support for re-auth on ro sessions initiated from charging server * ims_charging: Various changes to make module compatible to other charging servers -- File Changes -- M src/modules/cdp/acctstatemachine.c (2) M src/modules/cdp/diameter_code_avp.h (2) M src/modules/cdp/peerstatemachine.c (8) M src/modules/cdp/session.c (2) M src/modules/ims_charging/Ro_data.c (40) M src/modules/ims_charging/Ro_data.h (5) M src/modules/ims_charging/ccr.c (8) M src/modules/ims_charging/config.h (1) M src/modules/ims_charging/dialog.c (18) M src/modules/ims_charging/doc/ims_charging_admin.xml (20) M src/modules/ims_charging/ims_charging_mod.c (59) M src/modules/ims_charging/ims_ro.c (234) M src/modules/ims_charging/ims_ro.h (3) M src/modules/ims_charging/ro_db_handler.c (43) M src/modules/ims_charging/ro_db_handler.h (5) M src/modules/ims_charging/ro_session_hash.c (45) M src/modules/ims_charging/ro_session_hash.h (6) M src/modules/ims_charging/ro_timer.c (8) M utils/kamctl/mysql/ims_charging-create.sql (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3640.patch https://github.com/kamailio/kamailio/pull/3640.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3640 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3640(a)github.com>

3 8

git:master:70449bfc: topos: reformat exports structures
by Daniel-Constantin Mierla 22 Nov '23

22 Nov '23

Module: kamailio Branch: master Commit: 70449bfcb04eb44260fc8bd80ab6b77a86e82339 URL: https://github.com/kamailio/kamailio/commit/70449bfcb04eb44260fc8bd80ab6b77… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-22T09:01:28+01:00 topos: reformat exports structures --- Modified: src/modules/topos/topos_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/70449bfcb04eb44260fc8bd80ab6b77… Patch: https://github.com/kamailio/kamailio/commit/70449bfcb04eb44260fc8bd80ab6b77…

1 0

[kamailio/kamailio] 5.6.4 debian htable dbmode=1 not writing at shutdown (Issue #3536)
by ednt 22 Nov '23

22 Nov '23

### Description I use debian 11 and Kamailio 5.6.x modparam("htable", "htable", "callpush=>size=10;autoexpire=86400;dbtable=callpush;dbmode=1") I can store the values in the table, but if I shutdown kamailio, the current values are not stored in the table. #### Reproduction Use a htable and dbtable and dbmode=1 and shutdown kamailio. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3536 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3536(a)github.com>

2 2

[kamailio/kamailio] Add Username support for authentication in redis and sentinel w.r.t NDB REDIS (Issue #3552)
by hemanth-vulavala 22 Nov '23

22 Nov '23

### Description The current issue revolves around the absence of username support within the NDB REDIS KAMALIO framework when dealing with Redis, particularly concerning the Redis and Sentinel components. While Redis inherently offers the capability to utilize both usernames and passwords during authentication, this capability is not currently extended to the NDB REDIS KAMALIO setup. As a result, when attempting to establish connections to Redis instances through NDB REDIS KAMALIO, there is no provision for providing a username as part of the authentication process. Instead, the framework only accommodates the usage of passwords for authentication. This stands in contrast to Redis, which permits the inclusion of both usernames and passwords for enhanced security measures. Consequently, the limitation within NDB REDIS KAMALIO can hinder organizations seeking to ensure comprehensive security practices, especially when the requirement is to employ both usernames and passwords for authentication. This divergence between the authentication capabilities of Redis and NDB REDIS KAMALIO can potentially compromise security standards and hinder compatibility with certain authentication setups. To address this issue, it would be essential for the development team behind NDB REDIS KAMALIO to enhance the framework's capabilities by incorporating support for username-based authentication in addition to passwords. This alignment with Redis's authentication model would ensure that organizations can confidently implement secure data interactions while maintaining consistency with established security policies  ### Expected behavior The expected behavior entails an improvement within the NDB REDIS KAMALIO framework to support both usernames and passwords for authentication when interacting with Redis instances, particularly in the Redis and Sentinel components. This enhancement would bring NDB REDIS KAMALIO in line with Redis's native authentication capabilities, where both usernames and passwords are accepted during the authentication process. Upon implementing this improvement, users of NDB REDIS KAMALIO should be able to configure their connections by providing both a username and a password as part of the authentication details. This allows NDB REDIS KAMALIO to establish connections to Redis instances that require both authentication credentials, thereby enhancing security and ensuring compatibility with various authentication setups. By incorporating support for usernames in addition to passwords, NDB REDIS KAMALIO can accommodate organizations that require comprehensive security measures, especially in scenarios where username-based authentication is mandated. This alignment with Redis's authentication model would enable organizations to effectively collect, manage, and interact with data while adhering to established security policies. In summary, the expected behavior is that NDB REDIS KAMALIO should be upgraded to offer support for usernames and passwords during authentication, mirroring Redis's capabilities. This enhancement ensures a consistent and secure approach to data interactions and supports various authentication requirements within Redis environments #### Actual observed behavior The current actual behavior is that NDB REDIS KAMALIO does not have the capability to accept usernames as part of the authentication process when connecting to Redis instances, specifically in both the Redis and Sentinel components. While Redis itself allows for the usage of both usernames and passwords for authentication, this feature is not currently integrated into the NDB REDIS KAMALIO framework. As a result, when configuring connections to Redis instances using NDB REDIS KAMALIO, there is no provision to include a username alongside the authentication details. The framework only accommodates the use of passwords for authentication purposes. This deviation from Redis's authentication model could lead to compatibility issues with certain authentication setups, particularly those that mandate the use of both usernames and passwords. In essence, the actual behavior is that NDB REDIS KAMALIO falls short of aligning with Redis's authentication capabilities, thereby potentially hindering secure data interactions and limiting compatibility with certain security policies. Users attempting to adhere to comprehensive authentication practices may face challenges when utilizing NDB REDIS KAMALIO due to its inability to support usernames during authentication. To address this actual behavior, it would be necessary to enhance NDB REDIS KAMALIO's capabilities to include support for both usernames and passwords during the authentication process. This enhancement would ensure that organizations can confidently utilize NDB REDIS KAMALIO while maintaining the security standards and authentication requirements necessary for their Redis environments. #### Debugging Data ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3552 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3552(a)github.com>

3 5

[kamailio/kamailio] Support for Password Authentication in Sentinel for NDB Redis in kamailio (Issue #3530)
by hemanth-vulavala 22 Nov '23

22 Nov '23

### Description Currently, kamailio NDB Redis integration with Sentinel does not offer support for password authentication, leading to potential security concerns in our system. As a result, we are unable to ensure the desired level of protection for sensitive data stored in Redis. *Expected Behavior:* We expect Kamailio to allow the configuration of password authentication for Sentinel in the NDB Redis integration, enabling a secure and password-protected connection to the Redis instances. *Proposed Solution:* To address this issue, we recommend implementing a feature that enables password authentication for the Sentinel-based NDB Redis connections. This improvement will provide an added layer of security, ensuring that only authorized users can access the Redis instances. *Impact:* The absence of password authentication support poses a security risk, making our system vulnerable to potential unauthorized access and data breaches. Implementing this enhancement will safeguard sensitive information and strengthen our Redis integration's security framework. Note: as of now NDB REDIS support redis authentication using password  ### Troubleshooting #### Reproduction Steps to Reproduce:* 1. Attempt to configure password authentication for Sentinel in kamailio NDB Redis integration. ex: modparam("ndb_redis", "server", "name=srvZ;sentinel_group=group_name;sentinel_master=1;sentinel=1.2.3.4:26379;sentinel=1.2.3.5:26379";pass=mypassword") *It is failed to connect the sentinel *  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3530 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3530(a)github.com>

2 2

[kamailio/kamailio] [rtpengine] Support syntax for new "sdp-attr" manipulations (Issue #3509)
by George Diamantopoulos 22 Nov '23

22 Nov '23

### Description Newer rtpengine versions support manipulating SDP "a=" lines directly. Although kamailio is quite versatile when it comes to editing SIP message body, this functionality is often rather frail, especially when forking and having to use msg_apply_changes several times. I believe it would be beneficial to be able to offload such functionality to rtpengine, especially if one wants to apply different manipulations per outgoing branch. ### Expected behavior There should be a way to issue rtpengine ng-control protocol commands compatible with the sdp-attr dictionary syntax. #### Actual observed behavior Currently sdp-attr tokens are not properly evaluated. For example, **doing**: > rtpengine_manage("ICE=remove rtcp-mux-demux trust-address replace-origin replace-session-connection replace-SDP-version direction=internal direction=external sdp-attr-audio-substitute=$avp(fmtp_line) sdp-attr-audio-substitute=fmtp:101 0-15"); _[NOTE: $avp(fmtp_line) seems to expand in empty string here, which is a config error, but it doesn't affect the syntax demonstration in this example IMO]_ **results in**: ``` { "supports": [ "load limit" ], "sdp": "...", "ICE": "remove", "sdp-attr-audio-substitute": "", "sdp-attr-audio-substitute": "fmtp:101", "direction": [ "internal", "external" ], "flags": [ "trust-address", "0-15" ], "replace": [ "origin", "session-connection", "SDP-version" ], "rtcp-mux": [ "demux" ], "call-id": "...", "received-from": [ "IP4", "..." ], "from-tag": "...", "to-tag": "...", "command": "answer" } ``` ### Possible Solutions Support the special syntax of sdp-attr as documented here: https://github.com/sipwise/rtpengine/blob/master/docs/ng_control_protocol.md Here's one way to do it (I guess). In order to get this: ``` "sdp-attr" : { "audio" : { "add" : [ "ptime:20", "sendrecv" ], "substitute": [["fmtp:101 0-15" , "fmtp:126 0-16" ]] }, "video": { "remove" : [ "rtpmap:101 telephone-event/8000" ] }, "none" : { "substitute": [[ "sendrecv" , "sendonly" ], [ "ptime:20" , "ptime:40" ]] } } ``` Use a syntax similar to the following: > rtpengine_manage("... sdp-attr-audio-add=ptime:20 sdp-attr-audio-add=sendrecv sdp-attr-audio-substitute=fmtp:101 0-15 sdp-attr-audio-substitute=fmtp:101 0-16 sdp-attr-video-remove=rtpmap:101 telephone-event/8000 sdp-attr-none-substitute=sendrecv sdp-attr-none-substitute=sendonly sdp-attr-none-substitute=ptime:20 sdp-attr-none-substitute=ptime:40 ..."); It's not very pretty, but it could work. Caveats: * How to handle whitespace (e.g. there's a space in "fmtp:101 0-15" and in "rtpmap:101 telephone-event/8000" ) * substitute commands must always be in pairs, data type is a list of lists containing exactly two items as value in "substitute" key Unfortunately my C skills are not up to this task, but if I can provide any other kind of help please let me know. Thanks! -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3509 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3509(a)github.com>

3 5

[kamailio/kamailio] pv: Add support to $hfl $hflc for Diversion header (PR #3650)
by Xenofon Karamanos 21 Nov '23

21 Nov '23

2 4

git:master:35e191e1: app_lua: use module name prefix for exports structure
by Daniel-Constantin Mierla 21 Nov '23

21 Nov '23

Module: kamailio Branch: master Commit: 35e191e1bea5463e766cb6f8f2ffb4862bd812a8 URL: https://github.com/kamailio/kamailio/commit/35e191e1bea5463e766cb6f8f2ffb48… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-21T15:43:11+01:00 app_lua: use module name prefix for exports structure --- Modified: src/modules/app_lua/app_lua_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/35e191e1bea5463e766cb6f8f2ffb48… Patch: https://github.com/kamailio/kamailio/commit/35e191e1bea5463e766cb6f8f2ffb48… --- diff --git a/src/modules/app_lua/app_lua_mod.c b/src/modules/app_lua/app_lua_mod.c index 1aa4579d489..a041ebecbc0 100644 --- a/src/modules/app_lua/app_lua_mod.c +++ b/src/modules/app_lua/app_lua_mod.c @@ -90,7 +90,7 @@ static cmd_export_t cmds[] = { {0, 0, 0, 0, 0, 0} }; -struct module_exports exports = { +struct module_exports _app_lua_exports = { "app_lua", /* module name */ DEFAULT_DLFLAGS, /* dlopen flags */ cmds, /* exported functions */

1 0

← Newer
1
...
19
20
21
22
23
24
25
...
40
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2023