sr-dev January 2023

sr-dev@lists.kamailio.org

14 participants
281 discussions

git:5.5:0622ff34: p_usrloc: fix default transaction isolation level (gh #3324)
by Henning Westerholt 09 Jan '23

09 Jan '23

Module: kamailio Branch: 5.5 Commit: 0622ff34dcdded39de06986e36f4758a8319e050 URL: https://github.com/kamailio/kamailio/commit/0622ff34dcdded39de06986e36f4758… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-01-09T07:59:32Z p_usrloc: fix default transaction isolation level (gh #3324) (cherry picked from commit ff647697724decb7440dfe3758857a06ab008979) (cherry picked from commit af7d9413385cd03da918777072e7246863849dbb) --- Modified: src/modules/p_usrloc/doc/p_usrloc_admin.xml Modified: src/modules/p_usrloc/p_usrloc_mod.h --- Diff: https://github.com/kamailio/kamailio/commit/0622ff34dcdded39de06986e36f4758… Patch: https://github.com/kamailio/kamailio/commit/0622ff34dcdded39de06986e36f4758… --- diff --git a/src/modules/p_usrloc/doc/p_usrloc_admin.xml b/src/modules/p_usrloc/doc/p_usrloc_admin.xml index 80d4233eeb9..2d8c6eb9762 100644 --- a/src/modules/p_usrloc/doc/p_usrloc_admin.xml +++ b/src/modules/p_usrloc/doc/p_usrloc_admin.xml @@ -472,14 +472,14 @@ modparam("p_usrloc", "db_use_transactions", "0") </para> <para> <emphasis> - Default value is <quote>READ UNCOMMITED</quote>. + Default value is <quote>READ UNCOMMITTED</quote>. </emphasis> </para> <example> <title>Set <varname>db_transaction_level</varname> parameter</title> <programlisting format="linespecific"> ... -modparam("p_usrloc", "db_transaction_level", "READ UNCOMMITED") +modparam("p_usrloc", "db_transaction_level", "READ UNCOMMITTED") ... </programlisting> </example> diff --git a/src/modules/p_usrloc/p_usrloc_mod.h b/src/modules/p_usrloc/p_usrloc_mod.h index 24368cf4705..6b0929f39bb 100644 --- a/src/modules/p_usrloc/p_usrloc_mod.h +++ b/src/modules/p_usrloc/p_usrloc_mod.h @@ -61,7 +61,7 @@ #define DB_RETRY 10 #define DB_DEFAULT_POLICY 0 #define DEFAULT_FAILOVER_LEVEL 1 -#define DB_DEFAULT_TRANSACTION_LEVEL "READ UNCOMMITED" +#define DB_DEFAULT_TRANSACTION_LEVEL "READ UNCOMMITTED" #define DB_DEFAULT_CONNECTION_EXPIRES 300 #define DEFAULT_DB_TYPE "single" #define DEFAULT_DOMAIN_DB "location=cluster,cfa=single"

1 0

git:5.6:af7d9413: p_usrloc: fix default transaction isolation level (gh #3324)
by Henning Westerholt 09 Jan '23

09 Jan '23

Module: kamailio Branch: 5.6 Commit: af7d9413385cd03da918777072e7246863849dbb URL: https://github.com/kamailio/kamailio/commit/af7d9413385cd03da918777072e7246… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-01-09T07:59:04Z p_usrloc: fix default transaction isolation level (gh #3324) (cherry picked from commit ff647697724decb7440dfe3758857a06ab008979) --- Modified: src/modules/p_usrloc/doc/p_usrloc_admin.xml Modified: src/modules/p_usrloc/p_usrloc_mod.h --- Diff: https://github.com/kamailio/kamailio/commit/af7d9413385cd03da918777072e7246… Patch: https://github.com/kamailio/kamailio/commit/af7d9413385cd03da918777072e7246… --- diff --git a/src/modules/p_usrloc/doc/p_usrloc_admin.xml b/src/modules/p_usrloc/doc/p_usrloc_admin.xml index ca8faa827f9..cab0c3878af 100644 --- a/src/modules/p_usrloc/doc/p_usrloc_admin.xml +++ b/src/modules/p_usrloc/doc/p_usrloc_admin.xml @@ -472,14 +472,14 @@ modparam("p_usrloc", "db_use_transactions", "0") </para> <para> <emphasis> - Default value is <quote>READ UNCOMMITED</quote>. + Default value is <quote>READ UNCOMMITTED</quote>. </emphasis> </para> <example> <title>Set <varname>db_transaction_level</varname> parameter</title> <programlisting format="linespecific"> ... -modparam("p_usrloc", "db_transaction_level", "READ UNCOMMITED") +modparam("p_usrloc", "db_transaction_level", "READ UNCOMMITTED") ... </programlisting> </example> diff --git a/src/modules/p_usrloc/p_usrloc_mod.h b/src/modules/p_usrloc/p_usrloc_mod.h index bfdcc2f45ca..800a71851a8 100644 --- a/src/modules/p_usrloc/p_usrloc_mod.h +++ b/src/modules/p_usrloc/p_usrloc_mod.h @@ -61,7 +61,7 @@ #define DB_RETRY 10 #define DB_DEFAULT_POLICY 0 #define DEFAULT_FAILOVER_LEVEL 1 -#define DB_DEFAULT_TRANSACTION_LEVEL "READ UNCOMMITED" +#define DB_DEFAULT_TRANSACTION_LEVEL "READ UNCOMMITTED" #define DB_DEFAULT_CONNECTION_EXPIRES 300 #define DEFAULT_DB_TYPE "single" #define DEFAULT_DOMAIN_DB "location=cluster,cfa=single"

1 0

[kamailio/kamailio] Invalid default transaction isolation level in p_usrloc (Issue #3324)
by Дилян Палаузов 09 Jan '23

09 Jan '23

The default transaction level in p_usrloc is `READ UNCOMMITED`. Since the correct spelling is `commiTTed`, this default transaction level `read uncommiTed` is not accepted by databases. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3324 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3324(a)github.com>

2 2

git:master:ff647697: p_usrloc: fix default transaction isolation level (gh #3324)
by Henning Westerholt 09 Jan '23

09 Jan '23

Module: kamailio Branch: master Commit: ff647697724decb7440dfe3758857a06ab008979 URL: https://github.com/kamailio/kamailio/commit/ff647697724decb7440dfe3758857a0… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-01-09T07:57:26Z p_usrloc: fix default transaction isolation level (gh #3324) --- Modified: src/modules/p_usrloc/doc/p_usrloc_admin.xml Modified: src/modules/p_usrloc/p_usrloc_mod.h --- Diff: https://github.com/kamailio/kamailio/commit/ff647697724decb7440dfe3758857a0… Patch: https://github.com/kamailio/kamailio/commit/ff647697724decb7440dfe3758857a0… --- diff --git a/src/modules/p_usrloc/doc/p_usrloc_admin.xml b/src/modules/p_usrloc/doc/p_usrloc_admin.xml index 6153dbcb00..37c84bf20b 100644 --- a/src/modules/p_usrloc/doc/p_usrloc_admin.xml +++ b/src/modules/p_usrloc/doc/p_usrloc_admin.xml @@ -472,14 +472,14 @@ modparam("p_usrloc", "db_use_transactions", "0") </para> <para> <emphasis> - Default value is <quote>READ UNCOMMITED</quote>. + Default value is <quote>READ UNCOMMITTED</quote>. </emphasis> </para> <example> <title>Set <varname>db_transaction_level</varname> parameter</title> <programlisting format="linespecific"> ... -modparam("p_usrloc", "db_transaction_level", "READ UNCOMMITED") +modparam("p_usrloc", "db_transaction_level", "READ UNCOMMITTED") ... </programlisting> </example> diff --git a/src/modules/p_usrloc/p_usrloc_mod.h b/src/modules/p_usrloc/p_usrloc_mod.h index bfdcc2f45c..800a71851a 100644 --- a/src/modules/p_usrloc/p_usrloc_mod.h +++ b/src/modules/p_usrloc/p_usrloc_mod.h @@ -61,7 +61,7 @@ #define DB_RETRY 10 #define DB_DEFAULT_POLICY 0 #define DEFAULT_FAILOVER_LEVEL 1 -#define DB_DEFAULT_TRANSACTION_LEVEL "READ UNCOMMITED" +#define DB_DEFAULT_TRANSACTION_LEVEL "READ UNCOMMITTED" #define DB_DEFAULT_CONNECTION_EXPIRES 300 #define DEFAULT_DB_TYPE "single" #define DEFAULT_DOMAIN_DB "location=cluster,cfa=single"

1 0

git:master:5fbc0c6b: xmlrpc: check if rpc command has execution limit with delta interval
by Daniel-Constantin Mierla 09 Jan '23

09 Jan '23

Module: kamailio Branch: master Commit: 5fbc0c6b88b171bb04e98d4319e57e6c2c6ed0d8 URL: https://github.com/kamailio/kamailio/commit/5fbc0c6b88b171bb04e98d4319e57e6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-01-09T08:45:01+01:00 xmlrpc: check if rpc command has execution limit with delta interval --- Modified: src/modules/xmlrpc/xmlrpc.c --- Diff: https://github.com/kamailio/kamailio/commit/5fbc0c6b88b171bb04e98d4319e57e6… Patch: https://github.com/kamailio/kamailio/commit/5fbc0c6b88b171bb04e98d4319e57e6… --- diff --git a/src/modules/xmlrpc/xmlrpc.c b/src/modules/xmlrpc/xmlrpc.c index fcd93e5001..96da9872b9 100644 --- a/src/modules/xmlrpc/xmlrpc.c +++ b/src/modules/xmlrpc/xmlrpc.c @@ -70,6 +70,7 @@ #include "../../core/script_cb.h" /* exec_*_script_cb */ #include "../../core/route.h" /* route_get */ #include "../../core/sip_msg_clone.h" /* sip_msg_shm_clone */ +#include "../../core/rpc_lookup.h" #include "../../core/kemi.h" #include "http.h" @@ -2601,20 +2602,27 @@ static int process_xmlrpc(sip_msg_t* msg) */ static int ki_dispatch_rpc(sip_msg_t* msg) { - rpc_export_t* exp; + rpc_exportx_t* exp; int ret = 1; + unsigned int rdata; if (init_context(&ctx, msg) < 0) goto skip; - exp = find_rpc_export(ctx.method, 0); - if (!exp || !exp->function) { + exp = rpc_lookupx(ctx.method, strlen(ctx.method), &rdata); + if (!exp || !exp->r.function) { rpc_fault(&ctx, 500, "Method Not Found"); goto skip; } - ctx.flags = exp->flags; - if ((exp->flags & RET_ARRAY) && + if (rdata & RPC_EXEC_DELTA) { + LM_ERR("execution of command [%s] is limited by delta [%d]\n", + ctx.method, ksr_rpc_exec_delta); + rpc_fault(&ctx, 500, "Command Executed Too Fast"); + goto skip; + } + ctx.flags = exp->r.flags; + if ((exp->r.flags & RET_ARRAY) && add_xmlrpc_reply(&ctx.reply, &array_prefix) < 0) goto skip; - exp->function(&func_param, &ctx); + exp->r.function(&func_param, &ctx); skip: /* The function may have sent the reply itself */

1 0

git:master:67f27ea2: clt: check if rpc command has execution limit with delta interval
by Daniel-Constantin Mierla 09 Jan '23

09 Jan '23

Module: kamailio Branch: master Commit: 67f27ea223a20721ac288508635b5148e6264d56 URL: https://github.com/kamailio/kamailio/commit/67f27ea223a20721ac288508635b514… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-01-07T12:45:01+01:00 clt: check if rpc command has execution limit with delta interval --- Modified: src/modules/ctl/binrpc_run.c Modified: src/modules/ctl/fifo_server.c --- Diff: https://github.com/kamailio/kamailio/commit/67f27ea223a20721ac288508635b514… Patch: https://github.com/kamailio/kamailio/commit/67f27ea223a20721ac288508635b514…

1 0

Re: [SR-Users] pkg memory leak when acc module cdr_enabled
by Henning Westerholt 06 Jan '23

06 Jan '23

(adding sr-dev) Hi Alex, the memory allocator of glibc was not really efficient regarding the particular needs of a SIP server (allocation of many small string objects). That has probably improved in the last years, also system performance just got much faster. Other programs/tools also use their own allocators, e.g. Firefox, Rust [1] for jemalloc. There is some (not really well tested) support in the core for using the system memory allocator by the #define SYS_MALLOC. It probably needs to be set in Makefile.defs, also deactivating the other PKG memory managers, but did not looked into it right now. Cheers, Henning [1] https://news.ycombinator.com/item?id=8612645 -- Henning Westerholt - https://skalatan.de/blog/ Kamailio services - https://gilawa.com -----Original Message----- From: Alex Balashov <abalashov(a)evaristesys.com> Sent: Thursday, January 5, 2023 3:59 PM To: Henning Westerholt <hw(a)gilawa.com> Cc: Kamailio (SER) - Users Mailing List <sr-users(a)lists.kamailio.org> Subject: Re: [SR-Users] pkg memory leak when acc module cdr_enabled > On Jan 5, 2023, at 9:40 AM, Henning Westerholt <hw(a)gilawa.com> wrote: > > Hello Alex, > > there might be some performance implications by switching to system malloc. There is also easier debugging by internal Kamailio memory manager support. > > In this particular example with the leak, Kamailio would use in the end all of the system memory, and the machine out of memory killer will then randomly processes. So the limited memory pool also helps to protect the system against this kind of leaks. I am in no position to assess the relative efficiencies of various memory allocators. But it seems a bit extraordinary to suppose that a custom allocator is more efficient than the general-purpose libc allocator, although it's obviously possible; some application-specific optimised allocators clearly make this argument (i.e. Redis + jemalloc). Also, I wonder if the answer to this has changed over 20 years. Unbounded allocation from leaks can certainly be a problem. But rendering a process useless by running out of (much more limited) package memory (much more quickly) can also be a problem. :-) -- Alex -- Alex Balashov Principal Consultant Evariste Systems LLC Web: https://evaristesys.com Tel: +1-706-510-6800

3 4

[kamailio/kamailio] tls.reload during TLS relaying in sipp test will cause memory coruption of tls module (Issue #3305)
by JiangHai2011 06 Jan '23

06 Jan '23

### Description during sipp "tls caller and tls callee" test, do tls.reload repeatedly, the sipp tls connection will be disconnected and tls.reload will report error and can not be recovered ### Troubleshooting #### Reproduction (1)write a simple request_route logic in kamailio.cfg, as follows: request_route { add_local_rport(); $du = "sip:192.168.131.190:1001;transport=tls"; forward(); } (2)start sipp caller to kamailio tls:0.0.0.0:5061 and kamailio will relay this request to callee (3)at the same time, in another console, run the following cmds: ((i = 0)); while true; do /opt/kamailio/sbin/kamcmd tls.reload && echo $i && ((i = i+1)); done; #### Debugging Data None #### Log Messages tls.reload will report the following error, and it can not work again until kamailio is restarted: error: 500 - Error while loading TLS configuration file (consult server log) at the same time, sipp tls connection is disconnected by kamailio, some error is shown in the kamailo.log: -------------------------------------------------------------------------------------------------------- Dec 14 10:59:54 localhost sipproxy[64723]: ERROR: tls [tls_server.c:1330]: tls_h_read_f(): protocol level error Dec 14 10:59:54 localhost sipproxy[64723]: ERROR: tls [tls_server.c:1334]: tls_h_read_f(): src addr: 192.168.131.190:59545 Dec 14 10:59:54 localhost sipproxy[64723]: ERROR: tls [tls_server.c:1337]: tls_h_read_f(): dst addr: 192.168.131.190:5061 Dec 14 10:59:54 localhost sipproxy[64723]: ERROR: <core> [core/tcp_read.c:1478]: tcp_read_req(): ERROR: tcp_read_req: error reading - c: 0x7f3f67c89ba8 r: 0x7f3f67c89cd0 (-1) -------------------------------------------------------------------------------------------------------- #### SIP Traffic  ``` ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.6.2 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled on 10:03:56 Dec 14 2022 with gcc 4.9.4 ``` * **Operating System**:  ``` Linux localhost.localdomain 3.10.0-327.el7.x86_64 #1 SMP Thu Nov 19 22:10:57 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3305 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3305(a)github.com>

4 16

git:5.6:efd90dc3: modules: readme files regenerated - modules ... [skip ci]
by Kamailio Dev 06 Jan '23

06 Jan '23

Module: kamailio Branch: 5.6 Commit: efd90dc303221208a714ecc69daf744c39d47f0d URL: https://github.com/kamailio/kamailio/commit/efd90dc303221208a714ecc69daf744… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-01-06T12:47:01+01:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/app_python/README Modified: src/modules/app_python3/README --- Diff: https://github.com/kamailio/kamailio/commit/efd90dc303221208a714ecc69daf744… Patch: https://github.com/kamailio/kamailio/commit/efd90dc303221208a714ecc69daf744… --- diff --git a/src/modules/app_python/README b/src/modules/app_python/README index a1269d14f0e..a9d0b02890d 100644 --- a/src/modules/app_python/README +++ b/src/modules/app_python/README @@ -77,6 +77,10 @@ Chapter 1. Admin Guide module, look at the files inside source tree located at 'modules/app_python/python_examples/'. + As python2 is deprecated in Debian and other distributions, please use + the ��app_python3�� module instead. This module will be removed future + releases. + 2. Dependencies 2.1. Kamailio Modules diff --git a/src/modules/app_python3/README b/src/modules/app_python3/README index 49bc5774445..914350572b6 100644 --- a/src/modules/app_python3/README +++ b/src/modules/app_python3/README @@ -87,6 +87,11 @@ Chapter 1. Admin Guide module, look at the files inside the source tree located at 'modules/app_python3/python_examples/'. + Note: if symbols exported to KEMI (module or function names) conflict + with Python's reserved keywords, use the 'getattr()' function or the + '__dict__' attribute for 'KSR' (e.g., + 'KSR.__dict__["async"].task_route("myroute")'). + 2. Dependencies 2.1. Kamailio Modules @@ -190,9 +195,9 @@ python_exec("my_python_function", "$rU"); in each worker when it next invokes a Python method. The module uses a worker process lock to prevent recursive reloads. - This function only reloads the user script and creates a new script - object. It does not reinitialize the interpreter. E.g., references in - the old module remain if not redefined by the new version. + This function only reloads (re-executes) the user script and creates a + new script object. It does not reinitialize the interpreter (references + in the old module remain if not redefined by the new version). Name: app_python.reload @@ -203,6 +208,24 @@ python_exec("my_python_function", "$rU"); kamcmd app_python.reload ... + Note that reload is done for the Python script provided as parameter to + this Kamailio module. To reload the Python libraries imported in this + script, use something like: +... +import mod1 +... +import modN +from importlib import reload + +def mod_init(): + reload(mod1) + ... + reload(modN) + return kamailio() +... + + Where "modX" are the modules imported at the top. + 5.2. app_python.api_list List the functions available via Kemi framework.

1 0

[kamailio/kamailio] uri_param_rm function not working (Issue #3321)
by iliesh 06 Jan '23

06 Jan '23

### Description I have the following URI: ```INVITE sip:123456789;phone-context=+1@192.168.1.1;transport=udp;user=phone SIP/2.0``` I want to remove the phone-context parameter from the URI, so I've tried to use the function: ```uri_param_rm``` from the siputils package: ``` if (uri_param_rm("phone-context")) { t_relay_to_udp("192.168.1.2", "5060"); exit; } ``` But this doesn't change anything, this parameter is still present in the URI. I tried to use ```msg_apply_changes``` (just in case) function before relaying it - the result it the same, the parameter is still there. Also, I've noticed that this function is not working either: ``` if (uri_param_any("phone-context")) { xlog("L_INFO", "Phone Context"); } ``` while this one: ```get_uri_param("phone-context", "$var(phoneCtx)");``` - seems to be working fine. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.6.2 (x86_64/linux) e292ba ``` * **Operating System**:  ``` CentOS 7 X64 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3321 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3321(a)github.com>

3 4

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2023