sr-dev January 2023

sr-dev@lists.kamailio.org

14 participants
276 discussions

git:master:3112e49a: websocket: example must listen on ports 80 and 443

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 3112e49aac274c75cc893693e820da894125403b URL: https://github.com/kamailio/kamailio/commit/3112e49aac274c75cc893693e820da8… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-01-20T11:49:51+01:00 websocket: example must listen on ports 80 and 443 otherwise the code below always matches: if ($Rp != 80 && $Rp != 443) { --- Modified: src/modules/websocket/doc/websocket_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/3112e49aac274c75cc893693e820da8… Patch: https://github.com/kamailio/kamailio/commit/3112e49aac274c75cc893693e820da8… --- diff --git a/src/modules/websocket/doc/websocket_admin.xml b/src/modules/websocket/doc/websocket_admin.xml index f12d109561..5d33184a85 100644 --- a/src/modules/websocket/doc/websocket_admin.xml +++ b/src/modules/websocket/doc/websocket_admin.xml @@ -44,6 +44,8 @@ <programlisting><![CDATA[ ... tcp_accept_no_cl=yes +listen=tcp:127.0.0.17:80 +listen=tls:127.0.0.17:443 ... loadmodule "sl.so" loadmodule "xhttp.so" @@ -135,6 +137,7 @@ event_route[xhttp:request] { ... loadmodule "sl.so" loadmodule "tm.so" +loadmodule "xhttp.so" ... loadmodule "websocket.so" ...

1 year, 3 months

[kamailio/kamailio] websocket: ignoring keepalive for socket in the removing state (PR #3331)

by sergey-safarov

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3278 #### Description When websocket is closed, then possible race condition websocket removal and websocket keepalive functions. [ws_frame.c:816](https://github.com/kamailio/kamailio/blob/ac4c2d4579f121395… - setting socked state `WS_S_CLOSING` [ws_conn.c:703](https://github.com/kamailio/kamailio/blob/master/src/modules… - setting socket state `WS_S_REMOVING` and updates `rmticks` value. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3331 -- Commit Summary -- * websocket: ignoring keepalive for socket in the removing state (GH #3278) -- File Changes -- M src/modules/websocket/ws_frame.c (5) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3331.patch https://github.com/kamailio/kamailio/pull/3331.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3331 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3331(a)github.com>

1 year, 3 months

[kamailio/kamailio] fedora 37 build warnings with gcc 12.2.1 (Issue #3330)

by sergey-safarov

``` CC (gcc) [kamailio] core/nonsip_hooks.o CC (gcc) [kamailio] core/onsend.o CC (gcc) [kamailio] core/pass_fd.o CC (gcc) [kamailio] core/ppcfg.o In file included from core/ppcfg.c:37: core/utils/snexpr.h: In function 'snexpr_create': core/utils/snexpr.h:1247:98: warning: '%d' directive output may be truncated writing between 1 and 11 bytes into a region of size 2 [-Wformat-truncation=] 1247 | snprintf(varname, sizeof(varname) - 1, "$%d", | ^~ core/utils/snexpr.h:1247:96: note: directive argument in the range [-2147483646, 2147483647] 1247 | snprintf(varname, sizeof(varname) - 1, "$%d", | ^~~~~ core/utils/snexpr.h:1247:57: note: 'snprintf' output between 3 and 13 bytes into a destination of size 3 1247 | snprintf(varname, sizeof(varname) - 1, "$%d", | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1248 | (j + 1)); | ~~~~~~~~ CC (gcc) [kamailio] core/proxy.o CC (gcc) [kamailio] core/pt.o CC (gcc) [kamailio] core/pv_core.o CC (gcc) [kamailio] core/pvapi.o ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3330 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3330(a)github.com>

1 year, 3 months

git:master:d5b42fca: core: snexpr - increase local buffer to avoid compile warning

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: d5b42fca13d2107590f9178c5d7c1a9d765adf73 URL: https://github.com/kamailio/kamailio/commit/d5b42fca13d2107590f9178c5d7c1a9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-01-20T11:34:14+01:00 core: snexpr - increase local buffer to avoid compile warning - GH #3330 --- Modified: src/core/utils/snexpr.h --- Diff: https://github.com/kamailio/kamailio/commit/d5b42fca13d2107590f9178c5d7c1a9… Patch: https://github.com/kamailio/kamailio/commit/d5b42fca13d2107590f9178c5d7c1a9… --- diff --git a/src/core/utils/snexpr.h b/src/core/utils/snexpr.h index 4fb6e3f3b7..0115a52fd8 100644 --- a/src/core/utils/snexpr.h +++ b/src/core/utils/snexpr.h @@ -1243,7 +1243,7 @@ static struct snexpr *snexpr_create(const char *s, size_t len, int j; /* Assign macro parameters */ for(j = 0; j < sne_vec_len(&arg.args); j++) { - char varname[4]; + char varname[14]; snprintf(varname, sizeof(varname) - 1, "$%d", (j + 1)); struct snexpr_var *v =

1 year, 3 months

[kamailio/kamailio] kamdbctl create - database engine not loaded error (Issue #3333)

by winarama

I am trying to create a docker image which contains a preconfigured Kamailio server in presence mode. My image is based off the official Kamailio docker image version **kamailio/kamailio:5.6.2-bullseye**. My **kamctlrc** file is as follows. ``` SIP_DOMAIN="my-domain.com" DBENGINE="DBTEXT" DB_PATH="/usr/share/kamailio/dbtext" MD5="md5sum" AWK="awk" GDB="gdb" GREP="grep" EGREP="egrep" SED="sed" LAST_LINE="tail -n 1" EXPR="expr" INSTALL_EXTRA_TABLES="yes" INSTALL_PRESENCE_TABLES="yes" INSTALL_DBUID_TABLES="yes" RPCFIFOPATH="/run/kamailio/kamailio_rpc.fifo" PID_FILE="/run/kamailio/kamailio.pid" ``` However, when I try to run **kamdbctl create** I get the following error. `'18 0.402 ** ERROR: database engine not loaded - tried 'DBTEXT` Can anyone shed any light on what I am doing wrong here? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3333 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3333(a)github.com>

1 year, 3 months

git:5.6:fe0c4d5e: pkg/kamailio/obs: used mariadb connector instead of mysql

by Sergey Safarov

Module: kamailio Branch: 5.6 Commit: fe0c4d5efdff79f76a20b3519f41388782fae710 URL: https://github.com/kamailio/kamailio/commit/fe0c4d5efdff79f76a20b3519f41388… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2023-01-19T13:24:19+03:00 pkg/kamailio/obs: used mariadb connector instead of mysql (cherry picked from commit ea99c8fc235334d4dd48868f74ab5c62662942e6) --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/fe0c4d5efdff79f76a20b3519f41388… Patch: https://github.com/kamailio/kamailio/commit/fe0c4d5efdff79f76a20b3519f41388… --- diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index f040ca5cd8..42c9bce60a 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -736,8 +736,7 @@ BuildRequires: zlib-devel Requires: libmysqlclient18 BuildRequires: libmysqlclient-devel %else -Requires: mysql-libs -BuildRequires: mysql-devel +BuildRequires: mariadb-devel %endif %description mysql

1 year, 3 months

git:master:ea99c8fc: pkg/kamailio/obs: used mariadb connector instead of mysql

by Sergey Safarov

Module: kamailio Branch: master Commit: ea99c8fc235334d4dd48868f74ab5c62662942e6 URL: https://github.com/kamailio/kamailio/commit/ea99c8fc235334d4dd48868f74ab5c6… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2023-01-19T11:59:03+03:00 pkg/kamailio/obs: used mariadb connector instead of mysql --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/ea99c8fc235334d4dd48868f74ab5c6… Patch: https://github.com/kamailio/kamailio/commit/ea99c8fc235334d4dd48868f74ab5c6… --- diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index 1291010a63..e9d67f9edb 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -736,8 +736,7 @@ BuildRequires: zlib-devel Requires: libmysqlclient18 BuildRequires: libmysqlclient-devel %else -Requires: mysql-libs -BuildRequires: mysql-devel +BuildRequires: mariadb-devel %endif %description mysql

1 year, 3 months

Call get disconnected 500 i am terribly Sorry

by Nitin Poojary

Hi Team, I am facing issue when using DNS loadbalancer on port 443 on transport=tls protocal when calling from voximplant provider i am getting call on my asterisk media server but getting error message 500 terribly on kamailio and asterisk sip log. Also getting error below error on kamailio : tm [ut.h:316]: uri2dst2(): no corresponding socket found for "69.167.178.6" af 2 (tls:69.167.178.6:5861) g150ZGSTD10adFJAOBMnCJir) tm [t_fwd.c:469]: prepare_new_uac(); can't fwd to af 2, proto 3 (no corresponding listening socket) g1s0ZGSTD10adFJAOBMnCJir) tm [t_fwd.c:1728]: t_forward_nonack(): failure to add branches 21s0ZGSTD10adFJAOBMnCJir) cfgtrace:request_route=[RELAY] c=[/etc/kamailio/kamailio.cfg] 1=659 a=24 n=s1_reply_error g1s0ZG5TD10adFJA0BMn(Jir) sl [sl_funcs.c:392]: sl_reply_error(): stateless error reply used: I'm terribly sorry, server error occurred (7/SL) 1s0ZG5TD10adFJAOBMnCJir) *** cfgtrace:request_route=[RELAY] c=[/etc/kamailio/kamailio.cfg] 1-661 a=2 n=exit Bcg1s0ZG5TD10adFJA0BMnCJir) acc [acc.c:279]: acc_log_request(): ACC: transaction answered: timestamp=1673014965; method=BYE; from_tag=as307e86b8;to_tag=WW Team pls need your help to solve it. Thanks in advance

1 year, 3 months

git:master:34c3c42b: websocket: ignore keepalive in state WS_S_REMOVING

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 34c3c42b7fe44dbe88110415ec78400a7defde61 URL: https://github.com/kamailio/kamailio/commit/34c3c42b7fe44dbe88110415ec78400… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-01-16T12:55:34+01:00 websocket: ignore keepalive in state WS_S_REMOVING - GH #3331 --- Modified: src/modules/websocket/ws_frame.c --- Diff: https://github.com/kamailio/kamailio/commit/34c3c42b7fe44dbe88110415ec78400… Patch: https://github.com/kamailio/kamailio/commit/34c3c42b7fe44dbe88110415ec78400… --- diff --git a/src/modules/websocket/ws_frame.c b/src/modules/websocket/ws_frame.c index 583e904052..c7927b16f4 100644 --- a/src/modules/websocket/ws_frame.c +++ b/src/modules/websocket/ws_frame.c @@ -809,13 +809,18 @@ void ws_keepalive(unsigned int ticks, void *param) LM_WARN("forcibly closing connection\n"); wsconn_close_now(wsc); } else if (ws_keepalive_mechanism == KEEPALIVE_MECHANISM_CONCHECK) { - tcp_connection_t *con = tcpconn_get(wsc->id, 0, 0, 0, 0); - if(con==NULL) { - LM_INFO("tcp connection has been lost (id: %d wsc: %p)\n", + if(wsc->state == WS_S_REMOVING) { + LM_DBG("ws (id: %d wsc: %p) in removing state ignoring keepalive\n", wsc->id, wsc); - wsc->state = WS_S_CLOSING; } else { - tcpconn_put(con); + tcp_connection_t *con = tcpconn_get(wsc->id, 0, 0, 0, 0); + if(con==NULL) { + LM_INFO("tcp connection has been lost (id: %d wsc: %p)\n", + wsc->id, wsc); + wsc->state = WS_S_CLOSING; + } else { + tcpconn_put(con); + } } } else { int opcode = (ws_keepalive_mechanism == KEEPALIVE_MECHANISM_PING)

1 year, 3 months

git:master:ac4c2d45: pkg/kamailio/obs: added new modules into pec file

by Sergey Safarov

Module: kamailio Branch: master Commit: ac4c2d4579f121395876de2cc6f7649f3cb2fba7 URL: https://github.com/kamailio/kamailio/commit/ac4c2d4579f121395876de2cc6f7649… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2023-01-15T06:18:54+03:00 pkg/kamailio/obs: added new modules into pec file --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/ac4c2d4579f121395876de2cc6f7649… Patch: https://github.com/kamailio/kamailio/commit/ac4c2d4579f121395876de2cc6f7649… --- diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index d1425f68740..1291010a634 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -2212,7 +2212,9 @@ fi %endif %if %{with python3} %doc %{_docdir}/kamailio/modules/README.app_python3 +%doc %{_docdir}/kamailio/modules/README.app_python3s %{_libdir}/kamailio/modules/app_python3.so +%{_libdir}/kamailio/modules/app_python3s.so %endif @@ -2280,7 +2282,9 @@ fi %files ruby %defattr(-,root,root) %doc %{_docdir}/kamailio/modules/README.app_ruby +%doc %{_docdir}/kamailio/modules/README.app_ruby_proc %{_libdir}/kamailio/modules/app_ruby.so +%{_libdir}/kamailio/modules/app_ruby_proc.so %endif

1 year, 3 months

← Newer
1
...
16
17
18
19
20
21
22
...
28
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2023