sr-dev February 2022

sr-dev@lists.kamailio.org

17 participants
243 discussions

git:5.5:ba6b3e8d: sms: fixed misleading-indentation warning GH #3012
by Daniel-Constantin Mierla 14 Feb '22

14 Feb '22

Module: kamailio Branch: 5.5 Commit: ba6b3e8d8a9cc898e54acf750f871b812911d972 URL: https://github.com/kamailio/kamailio/commit/ba6b3e8d8a9cc898e54acf750f871b8… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-02-14T13:01:01+01:00 sms: fixed misleading-indentation warning GH #3012 (cherry picked from commit adb2d539e0db7feb1d6758dcc040c22a5915f104) --- Modified: src/modules/sms/sms_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/ba6b3e8d8a9cc898e54acf750f871b8… Patch: https://github.com/kamailio/kamailio/commit/ba6b3e8d8a9cc898e54acf750f871b8… --- diff --git a/src/modules/sms/sms_funcs.c b/src/modules/sms/sms_funcs.c index 32efec520c..36b85a964e 100644 --- a/src/modules/sms/sms_funcs.c +++ b/src/modules/sms/sms_funcs.c @@ -883,21 +883,22 @@ void modem_process(struct modem *mdm) /* if any, let's get them */ if (used_mem) LM_DBG("%d new SMS on modem\n",used_mem); - for(i=1,k=1;k<=used_mem && i<=max_mem;i++) { - if (getsms(&sms,mdm,i)!=-1) { - k++; - LM_DBG("SMS Get from location %d\n",i); - /*for test ;-) -> to be remove*/ - LM_DBG("SMS RECEIVED:\n\rFrom: %s %s\n\r%.*s %.*s" - "\n\r\"%.*s\"\n\r",sms.sender,sms.name, - DATE_LEN,sms.date,TIME_LEN,sms.time, - sms.userdatalength,sms.ascii); - if (!sms.is_statusreport) - _send_sms_as_sip(&sms, mdm); - else - check_sms_report(&sms); - } + + for(i=1,k=1;k<=used_mem && i<=max_mem;i++) { + if (getsms(&sms,mdm,i)!=-1) { + k++; + LM_DBG("SMS Get from location %d\n",i); + /*for test ;-) -> to be remove*/ + LM_DBG("SMS RECEIVED:\n\rFrom: %s %s\n\r%.*s %.*s" + "\n\r\"%.*s\"\n\r",sms.sender,sms.name, + DATE_LEN,sms.date,TIME_LEN,sms.time, + sms.userdatalength,sms.ascii); + if (!sms.is_statusreport) + _send_sms_as_sip(&sms, mdm); + else + check_sms_report(&sms); } + } /* if reports are used, checks for expired records in report queue */ if (sms_report_type!=NO_REPORT)

1 0

git:master:5b4506b2: core: async task - do not close sockets for sip worker processes
by Daniel-Constantin Mierla 14 Feb '22

14 Feb '22

Module: kamailio Branch: master Commit: 5b4506b2b11600f9678a32a4b9f49a7aef837d94 URL: https://github.com/kamailio/kamailio/commit/5b4506b2b11600f9678a32a4b9f49a7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-02-14T14:10:43+01:00 core: async task - do not close sockets for sip worker processes --- Modified: src/core/async_task.c --- Diff: https://github.com/kamailio/kamailio/commit/5b4506b2b11600f9678a32a4b9f49a7… Patch: https://github.com/kamailio/kamailio/commit/5b4506b2b11600f9678a32a4b9f49a7… --- diff --git a/src/core/async_task.c b/src/core/async_task.c index 99e04dd989..b64e071a11 100644 --- a/src/core/async_task.c +++ b/src/core/async_task.c @@ -186,7 +186,8 @@ int async_task_child_init(int rank) } if(rank>0) { - async_task_close_sockets_parent(); + /* no need to close the socket from sip workers */ + /* async_task_close_sockets_parent(); */ return 0; } if (rank!=PROC_MAIN)

1 0

[kamailio/kamailio] Kamailio crash with in-memory publ_cache = 2 (Issue #3008)
by Joe Mordica 14 Feb '22

14 Feb '22

### Description Usage of `modparam("presence", "publ_cache", 2)` causes kamailio to crash shortly after starting up. This only happens when subscribe traffic is high (400 requests per second avg). ### Troubleshooting #### Reproduction The issue can be reproduced by starting up kamailio with the option above enabled and ~400 subscribe requests per second. The crash happens ~20 seconds after startup. #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` kernel: kamailio[25401]: segfault at 0 ip 00007f4a0a22d4d7 sp 00007fff6064a370 error 4 in presence.so[7f4a0a21e000+fe000] ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions Running with the default ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` Linux hostName 2.6.32-754.11.1.el6.x86_64 #1 SMP Tue Feb 26 15:38:56 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux version: kamailio 5.4.3 (x86_64/linux) e19ae3 flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: e19ae3 compiled on 18:24:43 Dec 14 2020 with gcc 4.4.7 ``` I realize this is an older version so if it's resolved in a newer one let me know. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3008 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3008(a)github.com>

2 9

[kamailio/kamailio] dialog keep-alive ignores listening ip/port (Issue #3018)
by Riccardo-78 14 Feb '22

14 Feb '22

### Description When dialog module needs to send keep-alive to caller and/or called it doens't check if the ip address and port of the dialog is the current listening ip/port. If you have two distinct kamailio instances sharing a single dialog database, both instances are sending the OPTIONS and not just the one which handled the call at setup time.  ### Troubleshooting #### Reproduction Start two instance with a shared dialog database and db_mode set to 1 (realtime), set property ka-src for every dialog in kamailio cfg. Setup a long call and restart the instance not involved in the call. You should see it starting to send OPTIONS. ### Possible Solutions In dlg_send_ka, if the ip/port stored in the dialog db is not present in the listening ip/port set, skip the check.  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.5.2 (x86_64/linux) 55e232 flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 55e232 compiled on 14:20:31 Aug 25 2021 with gcc 4.8.5 ``` * **Operating System**: Centos 7  -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3018 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3018(a)github.com>

2 3

git:master:12af4fb3: core: added tcp_script_mode global parameter
by Daniel-Constantin Mierla 14 Feb '22

14 Feb '22

Module: kamailio Branch: master Commit: 12af4fb33a02617288f0b598356310cdcdff49d6 URL: https://github.com/kamailio/kamailio/commit/12af4fb33a02617288f0b598356310c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-02-14T08:51:12+01:00 core: added tcp_script_mode global parameter - control if the tcp connection should be closed if received message processing resulted in error return code --- Modified: src/core/cfg.lex Modified: src/core/cfg.y Modified: src/core/globals.h Modified: src/core/tcp_read.c --- Diff: https://github.com/kamailio/kamailio/commit/12af4fb33a02617288f0b598356310c… Patch: https://github.com/kamailio/kamailio/commit/12af4fb33a02617288f0b598356310c…

1 0

[kamailio/kamailio] Setting rtpengine DTLS flags on specific user agents only? (Issue #3025)
by Ryan Gehrig 14 Feb '22

14 Feb '22

Hello, I need to enable DTLS (e.g. add "SDES-off DTLS" to my $var(rtpengine_flags), but only on specific endpoint device types. So far, on an inbound call, the SDP comes from Asterisk, and once it hits this specific endpoint, if no encryption is enabled, the endpoint rejects the call and I get "488 Not Acceptable Here". If I statically enable the DTLS options in kamailio, then the endpoint accepts it and the call connects. I need to do conditional logic in the kam config, so unless there is a way to reinvite a second time, adding DTLS, I am now trying to figure out a way to determine the destination user agent, potentially via the most recent sip registration or contact/location data saved, then based on the user agent that was registered, I can decide to enable or disable DTLS. Open to any and all ideas on the right way to do this! Thanks! Ryan -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3025 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3025(a)github.com>

2 2

Advertised Address in LRKProxy
by Mojtaba 12 Feb '22

12 Feb '22

Hello there, In regard to developing LRKPRoxy to use behind NAT, I am planning to add some features to support Advertised Address. For example, this feature could be used when the LRKProxy is used in AWS. Does anybody have any opinion in this regard? or some extra features? -- --Mojtaba Esfandiari.S

1 0

git:master:c15c1286: modules: readme files regenerated - dialog ... [skip ci]
by Kamailio Dev 11 Feb '22

11 Feb '22

Module: kamailio Branch: master Commit: c15c1286c41dc2ce519b46cfcdd8487c2b45ecbd URL: https://github.com/kamailio/kamailio/commit/c15c1286c41dc2ce519b46cfcdd8487… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-02-11T16:16:13+01:00 modules: readme files regenerated - dialog ... [skip ci] --- Modified: src/modules/dialog/README --- Diff: https://github.com/kamailio/kamailio/commit/c15c1286c41dc2ce519b46cfcdd8487… Patch: https://github.com/kamailio/kamailio/commit/c15c1286c41dc2ce519b46cfcdd8487… --- diff --git a/src/modules/dialog/README b/src/modules/dialog/README index 4258d3b3b1..73e16a5977 100644 --- a/src/modules/dialog/README +++ b/src/modules/dialog/README @@ -99,7 +99,7 @@ Julien Klingenmeyer 6.47. bridge_contact (string) 6.48. initial_cbs_inscript (int) 6.49. send_bye (int) - 6.50. ignore_non_local_dlg (int) + 6.50. dlg_filter_mode (int) 6.51. wait_ack (int) 6.52. ka_timer (int) 6.53. ka_interval (int) @@ -241,7 +241,7 @@ Julien Klingenmeyer 1.47. Set bridge_contact parameter 1.48. Set initial_cbs_inscript parameter 1.49. Set send_bye parameter - 1.50. Set ignore_non_local_dlg parameter + 1.50. Set dlg_filter_mode parameter 1.51. Set wait_ack parameter 1.52. Set ka_timer parameter 1.53. Set ka_interval parameter @@ -341,7 +341,7 @@ Chapter 1. Admin Guide 6.47. bridge_contact (string) 6.48. initial_cbs_inscript (int) 6.49. send_bye (int) - 6.50. ignore_non_local_dlg (int) + 6.50. dlg_filter_mode (int) 6.51. wait_ack (int) 6.52. ka_timer (int) 6.53. ka_interval (int) @@ -573,7 +573,7 @@ Chapter 1. Admin Guide 6.47. bridge_contact (string) 6.48. initial_cbs_inscript (int) 6.49. send_bye (int) - 6.50. ignore_non_local_dlg (int) + 6.50. dlg_filter_mode (int) 6.51. wait_ack (int) 6.52. ka_timer (int) 6.53. ka_interval (int) @@ -1230,16 +1230,19 @@ modparam("dialog", "initial_cbs_inscript", 0) modparam("dialog", "send_bye", 1) ... -6.50. ignore_non_local_dlg (int) +6.50. dlg_filter_mode (int) - If set to 1, don't send keepalives and do nothing on timeout if dialog - is non local. + Set dialog fitering mode, which can specify what dialogs are processed. + Its value can be a combination (the sum) of following flags: + * 1 - do not send keepalives and do not execute timeout function if + dialog is not local (if the associated bind address is not a local + socket). Default value is “0”. - Example 1.50. Set ignore_non_local_dlg parameter + Example 1.50. Set dlg_filter_mode parameter ... -modparam("dialog", "ignore_non_local_dlg", 1) +modparam("dialog", "dlg_filter_mode", 1) ... 6.51. wait_ack (int)

1 0

git:master:1581ef7a: dialog: docs for dlg_filter_mode parameter
by Daniel-Constantin Mierla 11 Feb '22

11 Feb '22

Module: kamailio Branch: master Commit: 1581ef7acbd6ac6459956cf8b327cd4fd7a14736 URL: https://github.com/kamailio/kamailio/commit/1581ef7acbd6ac6459956cf8b327cd4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-02-11T16:13:29+01:00 dialog: docs for dlg_filter_mode parameter --- Modified: src/modules/dialog/doc/dialog_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/1581ef7acbd6ac6459956cf8b327cd4… Patch: https://github.com/kamailio/kamailio/commit/1581ef7acbd6ac6459956cf8b327cd4… --- diff --git a/src/modules/dialog/doc/dialog_admin.xml b/src/modules/dialog/doc/dialog_admin.xml index 1850a08de6..f8cbfb2e9c 100644 --- a/src/modules/dialog/doc/dialog_admin.xml +++ b/src/modules/dialog/doc/dialog_admin.xml @@ -1299,22 +1299,29 @@ modparam("dialog", "send_bye", 1) </programlisting> </example> </section> - <section id="dialog.p.ignore_non_local_dlg"> - <title><varname>ignore_non_local_dlg</varname> (int)</title> + <section id="dialog.p.dlg_filter_mode"> + <title><varname>dlg_filter_mode</varname> (int)</title> <para> - If set to 1, don't send keepalives and - do nothing on timeout if dialog is non local. + Set dialog fitering mode, which can specify what dialogs are processed. + Its value can be a combination (the sum) of following flags: </para> + <itemizedlist> + <listitem><para> + <emphasis>1</emphasis> - do not send keepalives and do not + execute timeout function if dialog is not local (if the + associated bind address is not a local socket). + </para></listitem> + </itemizedlist> <para> <emphasis> Default value is <quote>0</quote>. </emphasis> </para> <example> - <title>Set <varname>ignore_non_local_dlg</varname> parameter</title> + <title>Set <varname>dlg_filter_mode</varname> parameter</title> <programlisting format="linespecific"> ... -modparam("dialog", "ignore_non_local_dlg", 1) +modparam("dialog", "dlg_filter_mode", 1) ... </programlisting> </example>

1 0

git:master:14348216: dialog: renamed ignore_non_local_dlg to dlg_filter_mode
by Daniel-Constantin Mierla 11 Feb '22

11 Feb '22

Module: kamailio Branch: master Commit: 14348216c4c993d582f54270fc73298c864403ad URL: https://github.com/kamailio/kamailio/commit/14348216c4c993d582f54270fc73298… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-02-11T16:13:29+01:00 dialog: renamed ignore_non_local_dlg to dlg_filter_mode --- Modified: src/modules/dialog/dialog.c Modified: src/modules/dialog/dlg_handlers.c Modified: src/modules/dialog/dlg_hash.h Modified: src/modules/dialog/dlg_req_within.c --- Diff: https://github.com/kamailio/kamailio/commit/14348216c4c993d582f54270fc73298… Patch: https://github.com/kamailio/kamailio/commit/14348216c4c993d582f54270fc73298… --- diff --git a/src/modules/dialog/dialog.c b/src/modules/dialog/dialog.c index ddcb3b134b..08f0a85882 100644 --- a/src/modules/dialog/dialog.c +++ b/src/modules/dialog/dialog.c @@ -104,7 +104,7 @@ str dlg_extra_hdrs = {NULL,0}; static int db_fetch_rows = 200; static int db_skip_load = 0; static int dlg_keep_proxy_rr = 0; -int dlg_ignore_non_local_dlg = 0; +int dlg_filter_mode = 0; int initial_cbs_inscript = 1; int dlg_wait_ack = 1; static int dlg_timer_procs = 0; @@ -328,7 +328,7 @@ static param_export_t mod_params[]={ { "h_id_start", PARAM_INT, &dlg_h_id_start }, { "h_id_step", PARAM_INT, &dlg_h_id_step }, { "keep_proxy_rr", INT_PARAM, &dlg_keep_proxy_rr }, - { "ignore_non_local_dlg", INT_PARAM, &dlg_ignore_non_local_dlg }, + { "dlg_filter_mode", INT_PARAM, &dlg_filter_mode }, { 0,0,0 } }; diff --git a/src/modules/dialog/dlg_handlers.c b/src/modules/dialog/dlg_handlers.c index dd8cef6fd8..bf49981b4c 100644 --- a/src/modules/dialog/dlg_handlers.c +++ b/src/modules/dialog/dlg_handlers.c @@ -71,7 +71,7 @@ extern int dlg_send_bye; extern int dlg_event_rt[DLG_EVENTRT_MAX]; extern int dlg_wait_ack; extern int dlg_enable_dmq; -extern int dlg_ignore_non_local_dlg; +extern int dlg_filter_mode; int spiral_detected = -1; extern struct rr_binds d_rrb; /*!< binding to record-routing module */ @@ -1582,7 +1582,7 @@ void dlg_ontimeout(struct dlg_tl *tl) dlg = ((struct dlg_cell*)((char *)(tl) - (unsigned long)(&((struct dlg_cell*)0)->tl))); - if (dlg_ignore_non_local_dlg) { + if (dlg_filter_mode & DLG_FILTER_LOCALONLY) { if (dlg->bind_addr[0] == NULL) { LM_DBG("skipping dialog without bind address\n"); return; @@ -1593,7 +1593,7 @@ void dlg_ontimeout(struct dlg_tl *tl) return; } } - + /* mark dialog as expired */ dlg->dflags |= DLG_FLAG_EXPIRED; diff --git a/src/modules/dialog/dlg_hash.h b/src/modules/dialog/dlg_hash.h index ed5cd7bef0..7367a1b783 100644 --- a/src/modules/dialog/dlg_hash.h +++ b/src/modules/dialog/dlg_hash.h @@ -92,6 +92,9 @@ #define DLG_EVENTRT_FAILED 2 #define DLG_EVENTRT_MAX 3 +/* flags for filtering dialogs processing */ +#define DLG_FILTER_LOCALONLY (1<<0) /*!< processing only local dialogs */ + /*! internal unique ide per dialog */ typedef struct dlg_iuid { unsigned int h_id; /*!< id in the hash table entry (seq nr in slot) */ diff --git a/src/modules/dialog/dlg_req_within.c b/src/modules/dialog/dlg_req_within.c index c38d2062cc..bd65d995d2 100644 --- a/src/modules/dialog/dlg_req_within.c +++ b/src/modules/dialog/dlg_req_within.c @@ -53,7 +53,7 @@ extern str dlg_extra_hdrs; extern str dlg_lreq_callee_headers; extern int dlg_ka_failed_limit; -extern int dlg_ignore_non_local_dlg; +extern int dlg_filter_mode; /** * @@ -453,7 +453,7 @@ int dlg_send_ka(dlg_cell_t *dlg, int dir) int result; dlg_iuid_t *iuid = NULL; - if (dlg_ignore_non_local_dlg) { + if (dlg_filter_mode & DLG_FILTER_LOCALONLY) { if (dlg->bind_addr[dir] == NULL) { LM_DBG("skipping dialog without bind address\n"); return 0;

1 0

← Newer
1
...
16
17
18
19
20
21
22
...
25
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2022