sr-dev December 2022

sr-dev@lists.kamailio.org

11 participants
266 discussions

[kamailio/kamailio] tls.reload during TLS relaying in sipp test will cause memory coruption of tls module (Issue #3305)

by JiangHai2011

### Description during sipp "tls caller and tls callee" test, do tls.reload repeatedly, the sipp tls connection will be disconnected and tls.reload will report error and can not be recovered ### Troubleshooting #### Reproduction (1)write a simple request_route logic in kamailio.cfg, as follows: request_route { add_local_rport(); $du = "sip:192.168.131.190:1001;transport=tls"; forward(); } (2)start sipp caller to kamailio tls:0.0.0.0:5061 and kamailio will relay this request to callee (3)at the same time, in another console, run the following cmds: ((i = 0)); while true; do /opt/kamailio/sbin/kamcmd tls.reload && echo $i && ((i = i+1)); done; #### Debugging Data None #### Log Messages tls.reload will report the following error, and it can not work again until kamailio is restarted: error: 500 - Error while loading TLS configuration file (consult server log) at the same time, sipp tls connection is disconnected by kamailio, some error is shown in the kamailo.log: -------------------------------------------------------------------------------------------------------- Dec 14 10:59:54 localhost sipproxy[64723]: ERROR: tls [tls_server.c:1330]: tls_h_read_f(): protocol level error Dec 14 10:59:54 localhost sipproxy[64723]: ERROR: tls [tls_server.c:1334]: tls_h_read_f(): src addr: 192.168.131.190:59545 Dec 14 10:59:54 localhost sipproxy[64723]: ERROR: tls [tls_server.c:1337]: tls_h_read_f(): dst addr: 192.168.131.190:5061 Dec 14 10:59:54 localhost sipproxy[64723]: ERROR: <core> [core/tcp_read.c:1478]: tcp_read_req(): ERROR: tcp_read_req: error reading - c: 0x7f3f67c89ba8 r: 0x7f3f67c89cd0 (-1) -------------------------------------------------------------------------------------------------------- #### SIP Traffic  ``` ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.6.2 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled on 10:03:56 Dec 14 2022 with gcc 4.9.4 ``` * **Operating System**:  ``` Linux localhost.localdomain 3.10.0-327.el7.x86_64 #1 SMP Thu Nov 19 22:10:57 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3305 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3305(a)github.com>

1 year, 12 months

[kamailio/kamailio] Permissions module `reload_delta` is not scoped to individual tables. (Issue #3318)

by Ben Kaufman

### Description The permissions module has two reload RPC commands, `permissions.addressReload` which reloads the `address` table, and `permissions.trustedReload`, which reloads the `trusted` table. The module parameter `reload_delta` exists to prevent concurrent reloading of a single table: > ##### 3.25. reload_delta (int) > The number of seconds that have to be waited before executing a new RPC reload. By default there is a rate limiting of maximum one reload in five seconds. > > If set to 0, no rate limit is configured. Note carefully: use this configuration only in tests environments because executing two RPC reloads of the same table at the same time can cause to kamailio to crash. If one of the reload rpc commands is issues (i.e. `permissions.addressReload`), then the OTHER reload command (`permissions.trustedReload`) will be blocked, despite acting against two separate tables. ### Troubleshooting Reproduced the issue. #### Reproduction _(DB config for permissions module omitted for brevity)_ ``` loadmodule "rtimer.so" loadmodule "permissions.so" loadmodule "jsonrpcs" modparamx("rtimer", "timer", "name=permissions_reload;mode=0;interval=300") modparam("rtimer", "exec", "timer=permissions_reload;route=RELOAD_PERMISSIONS") route[RELOAD_PERMISSIONS] { xnotice("Reloading trusted records\n"); jsonrpc_exec('{"jsonrpc": "2.0", "method": "permissions.trustedReload", "id": 1}'); xalert("jsonrpc response code: $jsonrpl(code) - the body is: $jsonrpl(body)\n"); xnotice("Reloading addresses\n"); jsonrpc_exec('{"jsonrpc": "2.0", "method": "permissions.addressReload", "id": 1}'); xalert("jsonrpc response code: $jsonrpl(code) - the body is: $jsonrpl(body)\n"); } ``` #### Debugging Data The above config yields output like this: ``` 2(8) NOTICE: <script>: Reloading trusted records 2(8) ALERT: <script>: jsonrpc response code: 200 - the body is: { "jsonrpc": "2.0", "result": "Reload OK", "id": 1 } 2(8) NOTICE: <script>: Reloading addresses 2(8) ERROR: permissions [rpc.c:42]: rpc_check_reload(): ongoing reload 2(8) ALERT: <script>: jsonrpc response code: 500 - the body is: { "jsonrpc": "2.0", "error": { "code": 500, "message": "ongoing reload" }, "id": 1 } ``` ### Possible Solutions Ideally each reload would be tracked separately. This could possibly involve separate `reload_delta` parameters for each table (although it seems excessive to change the interface). It's also possible that this behavior is by design, in which case, clarification of the documentation for the `reload_delta` parameter would be nice. ### Additional Information Problem occurs in kamailio 5.6.2. Likely within all version since the `reload_delta` parameter was added. * **Operating System**: Tested in Alpine, but OS seems irrelevant. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3318 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3318(a)github.com>

1 year, 12 months

DMQ Trials

by Olle E. Johansson

Dear Kamailians! I’m trying to figure out DMQ and see how it reacts to server outages and downtime - the base protocol. I’ve configured three nodes on different ports and run them locally. All have the others as notification peers plus one that is disabled. They are configured like this with transport: modparam("dmq", "notification_address", "sip:192.168.40.107:5060;transport=udp") It quickly turns out that DMQ has every node twice - when sending ut “notification_peer” messages, it sends all six. KDMQ sip:notification_peer@192.168.40.107:5070 SIP/2.0 Via: SIP/2.0/UDP 192.168.40.107:5080;branch=z9hG4bK96bc.875f2460000000000000000000000000.0 To: <sip:notification_peer@192.168.40.107:5070> From: <sip:notification_peer@192.168.40.107:5080>;tag=e0f3ecb7441aaf62d1734fc723545165-9deb0be2 CSeq: 10 KDMQ Call-ID: 0024de987491cd3e-30304(a)192.168.40.107 Content-Length: 234 User-agent: Kamailio Server 02 DMQtest Max-Forwards: 1 Content-Type: text/plain sip:192.168.40.107:5080;status=active sip:192.168.40.107:5060;status=active sip:192.168.40.107:5090;status=active sip:192.168.40.107:5090;status=active sip:192.168.40.107:5060;status=active sip:192.168.40.107:5080;status=active When I shut down one, it sends out a “disabled notification” where the other nodes responds that the other (copy) on the same IP/port is still active. Looking into dmq with kamctl I see that three have transport “udp” and three have transport “*” (asterisk). I don’t see transport being given as parameter in the notification_peer messages. It seems to me like there’s a bug in here somewhere. Or is this the way it’s supposed to work? /O

2 years

git:master:7364a8a6: xmlrpc: coherent check of RET_ARRAY as a flag

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 7364a8a67e19960d51a632108f39d7d2d289f8ce URL: https://github.com/kamailio/kamailio/commit/7364a8a67e19960d51a632108f39d7d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-12-28T10:37:35+01:00 xmlrpc: coherent check of RET_ARRAY as a flag --- Modified: src/modules/xmlrpc/xmlrpc.c --- Diff: https://github.com/kamailio/kamailio/commit/7364a8a67e19960d51a632108f39d7d… Patch: https://github.com/kamailio/kamailio/commit/7364a8a67e19960d51a632108f39d7d…

2 years

git:master:971ae411: modules: readme files regenerated - alias_db ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 971ae411a5eca66b2ce2bc95230b76510c132b09 URL: https://github.com/kamailio/kamailio/commit/971ae411a5eca66b2ce2bc95230b765… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-12-28T10:32:49+01:00 modules: readme files regenerated - alias_db ... [skip ci] --- Modified: src/modules/alias_db/README Modified: src/modules/app_perl/README Modified: src/modules/app_sqlang/README Modified: src/modules/avp/README Modified: src/modules/avpops/README Modified: src/modules/carrierroute/README Modified: src/modules/cfgutils/README Modified: src/modules/cplc/README Modified: src/modules/db2_ldap/README Modified: src/modules/db2_ops/README Modified: src/modules/db_text/README Modified: src/modules/dialog/README Modified: src/modules/dialplan/README Modified: src/modules/dlgs/README Modified: src/modules/dnssec/README Modified: src/modules/domainpolicy/README Modified: src/modules/erlang/README Modified: src/modules/exec/README Modified: src/modules/imc/README Modified: src/modules/ims_dialog/README Modified: src/modules/ims_registrar_scscf/README Modified: src/modules/ims_usrloc_scscf/README Modified: src/modules/jwt/README Modified: src/modules/keepalive/README Modified: src/modules/lrkproxy/README Modified: src/modules/mangler/README Modified: src/modules/maxfwd/README Modified: src/modules/msilo/README Modified: src/modules/nat_traversal/README Modified: src/modules/p_usrloc/README Modified: src/modules/permissions/README Modified: src/modules/pike/README Modified: src/modules/presence/README Modified: src/modules/pua/README Modified: src/modules/pua_bla/README Modified: src/modules/pua_xmpp/README Modified: src/modules/pv_headers/README Modified: src/modules/registrar/README Modified: src/modules/rls/README Modified: src/modules/rr/README Modified: src/modules/ruxc/README Modified: src/modules/seas/README Modified: src/modules/siptrace/README Modified: src/modules/siputils/README Modified: src/modules/sl/README Modified: src/modules/sms/README Modified: src/modules/snmpstats/README Modified: src/modules/sst/README Modified: src/modules/systemdops/README Modified: src/modules/textops/README Modified: src/modules/textopsx/README Modified: src/modules/tm/README Modified: src/modules/tmx/README Modified: src/modules/tsilo/README Modified: src/modules/uac/README Modified: src/modules/uac_redirect/README Modified: src/modules/uid_domain/README Modified: src/modules/uri_db/README Modified: src/modules/usrloc/README Modified: src/modules/websocket/README Modified: src/modules/xcap_client/README Modified: src/modules/xmlrpc/README --- Diff: https://github.com/kamailio/kamailio/commit/971ae411a5eca66b2ce2bc95230b765… Patch: https://github.com/kamailio/kamailio/commit/971ae411a5eca66b2ce2bc95230b765…

2 years

[kamailio/kamailio] Typos (PR #3313)

by Дилян Палаузов

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3313 -- Commit Summary -- * core: typos - succesSful * misc/examples: update comments * auth: typo statefulLy * ims_auth: typo succesSful * ims_registrar_pcscf: typo successfulLy * keepalive: typo unsuccesSful * nathelper: typo statefulLy * pipelimit: typo unsuccesSful * ratelimit: typo unsuccesSful * snmpstats: typo unsuccesSful * test/misc: typo sucesSful * tls: typo succesSfulLy * tls_wolfssl: type succesSfulLy * uid_avp_db: typo succesSful -- File Changes -- M misc/examples/kamailio/acc.cfg (2) M misc/examples/mixed/acc.cfg (2) M misc/examples/mixed/uas.cfg (2) M misc/examples/obsoleted/backup.cfg (2) M misc/examples/obsoleted/test.cfg (2) M misc/examples/obsoleted/tmtest.cfg (2) M src/core/tcp_main.c (2) M src/modules/auth/auth.xml (2) M src/modules/ims_auth/sip_messages.h (2) M src/modules/ims_registrar_pcscf/save.c (2) M src/modules/keepalive/doc/keepalive_admin.xml (2) M src/modules/nathelper/examples/nathelper.cfg (2) M src/modules/nathelper/examples/nathelper_rtpp.cfg (2) M src/modules/pipelimit/pl_statistics.c (2) M src/modules/ratelimit/rl_statistics.c (2) M src/modules/snmpstats/snmp_statistics.c (2) M src/modules/tls/tls_server.c (2) M src/modules/tls_wolfssl/tls_server.c (2) M src/modules/uid_avp_db/README (2) M src/modules/uid_avp_db/doc/avp_dialogs.cfg (2) M test/misc/cfg/acc-test.cfg (4) M test/misc/cfg/sf.cfg (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3313.patch https://github.com/kamailio/kamailio/pull/3313.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3313 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3313(a)github.com>

2 years

git: new commits in branch master

by Daniel-Constantin Mierla

- URL: https://github.com/kamailio/kamailio/commit/a8976a5ad77a2ca5ec21acf3f892c59… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 core: typos - URL: https://github.com/kamailio/kamailio/commit/7799920ef6074e466e265f003a3b605… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 lib/cds: typo asSigned - URL: https://github.com/kamailio/kamailio/commit/d712a568f3cc49cd724d0b6d24c70f0… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 lib/ims: typos succesS - URL: https://github.com/kamailio/kamailio/commit/509bd8e8f37996202442759acc2a925… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 lib/srdb1: add missing spaces - URL: https://github.com/kamailio/kamailio/commit/d7061b4aaeb84d1edf2b5144734729e… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 doc/tutorials: typos - URL: https://github.com/kamailio/kamailio/commit/e6bdf6579a800377786b054957f68fc… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 misc/examples: update comments - URL: https://github.com/kamailio/kamailio/commit/06ffb667b7fa4672cb9c7701d476047… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 acc: typo fuNction - URL: https://github.com/kamailio/kamailio/commit/d66b3fa5b7d00707d78d7023e4ac034… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 acc_diameter: typo - build �� built - URL: https://github.com/kamailio/kamailio/commit/db1dbfb5cd455ce852ea8d77caccea4… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 alias_db: space after comma - URL: https://github.com/kamailio/kamailio/commit/bd573ddda9df163b53fe2cccd72010b… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 app_lua: typo - URL: https://github.com/kamailio/kamailio/commit/5609b064bf53f2458c2eaf4468cc01a… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 app_perl: typos - URL: https://github.com/kamailio/kamailio/commit/d50905a2ee368e07c814939434e7cbe… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 app_sqlang: typo dor �� does - URL: https://github.com/kamailio/kamailio/commit/2e8f9829d360b22e611d5241fc034c2… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 auth: typo statefulLy - URL: https://github.com/kamailio/kamailio/commit/74467e57443e0550a53020c5248c046… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 auth_diameter: typo - build �� built - URL: https://github.com/kamailio/kamailio/commit/80ec8f8b0f5962f3e5dbd4e299d67a4… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 avp: space after comma - URL: https://github.com/kamailio/kamailio/commit/b920b8f267622280f307bc8cb12e3f9… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 avpops: typo singular/plural - URL: https://github.com/kamailio/kamailio/commit/e051cc907b3c4c452069e154aa4d239… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 carrierroute: missing space - URL: https://github.com/kamailio/kamailio/commit/721bb93454d914b972e4d021de238b8… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 cdp: typo - URL: https://github.com/kamailio/kamailio/commit/8178106a7a0a8ccd39f95565b144b21… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 cfgutils: typo - URL: https://github.com/kamailio/kamailio/commit/84876ec6c5b0b3ddad5cc2ebe588b88… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 corex: typo - URL: https://github.com/kamailio/kamailio/commit/972176b06a2004c60af212ef5824173… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 cplc: typos - URL: https://github.com/kamailio/kamailio/commit/3b39da405b8ddf1153bd883db4f7014… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 ctl: typos - URL: https://github.com/kamailio/kamailio/commit/1ebda62a4fb85d6d742bc5da518f834… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 db_text: typo singular/plural - URL: https://github.com/kamailio/kamailio/commit/f6a8f43482df5169ee778295d83f4ac… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 db2_ldap: typos - URL: https://github.com/kamailio/kamailio/commit/11591861fd1af1b83329f8cb6db4294… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 db2_ops: space after comma - URL: https://github.com/kamailio/kamailio/commit/b39af6aab4c1ec46dfaeda2387366cb… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 dialog: typos - URL: https://github.com/kamailio/kamailio/commit/809586788659c32fed73f5e6cb4eeaf… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 dialplan: typo - URL: https://github.com/kamailio/kamailio/commit/b3e1b3bbee181e3bfd4487c66bb63f7… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 dlgs: typos - URL: https://github.com/kamailio/kamailio/commit/255c34081bca441e17ae06ac8c16bdd… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 dnssec: missing space - URL: https://github.com/kamailio/kamailio/commit/2766455c77db644692469b7a22f0295… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 domainpolicy: typo build �� built - URL: https://github.com/kamailio/kamailio/commit/1453b2c6917f5b6b7f80a7bd7575a6f… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 erlang: typo - URL: https://github.com/kamailio/kamailio/commit/6d078c0fc0a3aa88f9af9f184c42b00… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 exec: typo variabLes - URL: https://github.com/kamailio/kamailio/commit/6b9d60a4a5d73cdcb3e46e40a7a856b… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 imc: typo joininG - URL: https://github.com/kamailio/kamailio/commit/fc827e31027c171826f2ae4a5572163… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 ims_auth: typo succesSful - URL: https://github.com/kamailio/kamailio/commit/dd99c7d5c67d0cabe1f825a0b4aa5e9… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 ims_dialog: typo this makeS sense - URL: https://github.com/kamailio/kamailio/commit/b254787c69ddc8973216ed674a98f41… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 ims_registrar_pcscf: typo successfulLy - URL: https://github.com/kamailio/kamailio/commit/88d9d2ddfb6d813c2089794c77f638f… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 fixup ims_registrar_pcscf - URL: https://github.com/kamailio/kamailio/commit/e9e0e8aeaa7f6f7aca85f4368eb334a… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 ims_registrar_scscf: 200OK �� 200 OK - URL: https://github.com/kamailio/kamailio/commit/920eb7208b5dd5a0b2504ff62eefc62… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 ims_usrloc_scscf: toggled comma-space - URL: https://github.com/kamailio/kamailio/commit/64786dbb33e6b24ed61d63a9ebcf0cd… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 ipops: typo singular/plural - URL: https://github.com/kamailio/kamailio/commit/8fbf69181c750f678ced602d45f187c… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 json: typo fuNction - URL: https://github.com/kamailio/kamailio/commit/7cf5a1cebae839c175a7ee7190cd6d2… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 jwt_admin: doc/jwt_generate - fix function declaration - URL: https://github.com/kamailio/kamailio/commit/f2938f16bb519a24584e38850e12fc2… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 kazoo: typo fuNction - URL: https://github.com/kamailio/kamailio/commit/1a3c580afdfd82f07b3c94fd33df037… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 keepalive: typo unsuccesSful - URL: https://github.com/kamailio/kamailio/commit/04c4b97d4bc1f09b6aa88b4c5dca7b1… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 lrkproxy: typo - URL: https://github.com/kamailio/kamailio/commit/f9d0ecb8ad7085e16afe8f28d31c2c4… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 mangler: missing space - URL: https://github.com/kamailio/kamailio/commit/9512b0e465ab521dbefb7e914e72a23… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 maxfwd: typo - URL: https://github.com/kamailio/kamailio/commit/3a630f40787577273a49e31f287f540… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 msilo: typos - URL: https://github.com/kamailio/kamailio/commit/e9c7513628b37d5920fcbf50236217f… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 nathelper: typo statefulLy - URL: https://github.com/kamailio/kamailio/commit/5d54a68bd06305fc722a14426ecd5d3… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 nat_traversal: typo build �� built - URL: https://github.com/kamailio/kamailio/commit/dccba45e556409c480cda657f4ccfe3… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 p_usrloc: typos - URL: https://github.com/kamailio/kamailio/commit/0f56abd0cd3596fed474d81ce291e0a… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 permissions: space after comma - URL: https://github.com/kamailio/kamailio/commit/170771546bfb15f9f265373fc7f7a7d… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 pike: typo build �� built - URL: https://github.com/kamailio/kamailio/commit/afaec13cafbcf7e0dd7058457f699d5… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 pipelimit: typo unsuccesSful - URL: https://github.com/kamailio/kamailio/commit/dba3b5d758fb69111d579fe441e958f… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 presence: typos - URL: https://github.com/kamailio/kamailio/commit/192ab41af01a5ae225c6f4b7c14803f… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 presence_conference: typo fuNction - URL: https://github.com/kamailio/kamailio/commit/9de462febb8a85302c741babdf5b0ef… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 presence_dialoginfo: typo fuNction - URL: https://github.com/kamailio/kamailio/commit/a9dade2b5db6077518c0940822d4154… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 presence_reginfo: typo fuNction - URL: https://github.com/kamailio/kamailio/commit/0b460c80a6409c0a5a27b638999776e… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 pua: typo - URL: https://github.com/kamailio/kamailio/commit/7e8193ed2ea47623c6bf79e078bc632… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 pua_bla: typo singular/plural - URL: https://github.com/kamailio/kamailio/commit/8513046cd76263211d2b4531e845821… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 pua_dialoginfo: typo - URL: https://github.com/kamailio/kamailio/commit/3ae6fdfddea2ed2192d91f7769bd06f… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 pua_xmpp: typo a/an xmpp - URL: https://github.com/kamailio/kamailio/commit/3c01356e1c02aabc40025aa5445c488… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 pv: typos - URL: https://github.com/kamailio/kamailio/commit/9592d9f39114bf1778e1020283f7a85… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 pv_headers: use flags numbers below 32 - URL: https://github.com/kamailio/kamailio/commit/ae89ec8da8689ffaf4aa5c57cbcbe14… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 ratelimit: typo unsuccesSful - URL: https://github.com/kamailio/kamailio/commit/dc245a45309c1aca3c6704d122a39f5… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 registrar: reword - URL: https://github.com/kamailio/kamailio/commit/67d8b44ead9c9a8b5f716269d2fb5b5… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 rls: typos - URL: https://github.com/kamailio/kamailio/commit/c58a6ec1cb87c79b3219df8e9f68ebf… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 rr: typos - URL: https://github.com/kamailio/kamailio/commit/8c228d9c41b5ab190ce33473b659424… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 rtpengine: formatting - URL: https://github.com/kamailio/kamailio/commit/731be1d0eef4f5cbf05f638a25a738f… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 rtpproxy: typo - URL: https://github.com/kamailio/kamailio/commit/8dc47d749a9a556f45453771746b0e2… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 ruxc: 200ok �� 200 OK - URL: https://github.com/kamailio/kamailio/commit/028693c2b94bf626f9e1ca94a0dbd00… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 seas: missing space - URL: https://github.com/kamailio/kamailio/commit/424dfe77cd8b304c72098e901479202… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 sipdump: typo fuNction - URL: https://github.com/kamailio/kamailio/commit/528dbe39af2f17f535b4098d844b7f2… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 siptrace: typo - URL: https://github.com/kamailio/kamailio/commit/6c09b14e08b1915fefb58ade46e5da5… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 siputils: typos - URL: https://github.com/kamailio/kamailio/commit/259373e3a19a38071dd61d6b317ea2c… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 sl: typos - URL: https://github.com/kamailio/kamailio/commit/f98980f53f50c79d911bc1dba1f1243… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 sms: typo a/an SMS - URL: https://github.com/kamailio/kamailio/commit/8d9a0d68ea37d57c5c46520ebeb4e66… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 snmpstats: typos - URL: https://github.com/kamailio/kamailio/commit/2402c8f30d76b347a8c381f72fcd96b… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 sst: clarify that sst_flag must be set and typos - URL: https://github.com/kamailio/kamailio/commit/16a99036161df45426ccd022606b620… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 stirshaken: typo wHich - URL: https://github.com/kamailio/kamailio/commit/d687f75b6afee6c3a5e00f9faa01639… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 systemdops: typo - URL: https://github.com/kamailio/kamailio/commit/b111ef210fa6044c5bc291d09eb1a85… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 textops: typos - URL: https://github.com/kamailio/kamailio/commit/5ac1ce58dfd5fe872c4b142d7a062f7… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 textopsx: typo build �� built - URL: https://github.com/kamailio/kamailio/commit/8bf11c857736983b66f2d5eba8bd66a… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 tls: typos - URL: https://github.com/kamailio/kamailio/commit/e3a2bf5a9f0b702259ffa47652975ba… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 tls_wolfssl: typos - URL: https://github.com/kamailio/kamailio/commit/2558c00599070a7af5110f653b9e60a… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 tm: typos - URL: https://github.com/kamailio/kamailio/commit/cb525b19f0ab73f692413fa8ccf6433… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 tmx: typo - URL: https://github.com/kamailio/kamailio/commit/257a176ccebf81ad754925bb488937f… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 tsilo: typos - URL: https://github.com/kamailio/kamailio/commit/0f4e6e3e03a038fbee6f93a0df311cc… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 uac: typos - URL: https://github.com/kamailio/kamailio/commit/7fd8c064e175f77697afe26bca3f393… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 uac_redirect: typos - URL: https://github.com/kamailio/kamailio/commit/d8d2c14ea0210532d3982fc5d9c5eb5… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 uid_avp_db: typo succesSful - URL: https://github.com/kamailio/kamailio/commit/42c5dccb0581cdd806771fbdeea814b… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 uid_domain: typos - URL: https://github.com/kamailio/kamailio/commit/d171f379135371d4d2503fc05143938… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 usrloc: typos - URL: https://github.com/kamailio/kamailio/commit/f0e12136e41aaae3c80a1606d6753cf… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 uri_db: typo its �� it is - URL: https://github.com/kamailio/kamailio/commit/6184fa0d0f20c47b839235ca094c15b… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 websocket: typo a/an Access-Control-Allow-Origin header - URL: https://github.com/kamailio/kamailio/commit/f209380de74dc6d34a3042d142efaff… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 xcap_client: typo - URL: https://github.com/kamailio/kamailio/commit/c35bdece4340ac669989bf7afb74c15… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 xmlrpc: typo typos - URL: https://github.com/kamailio/kamailio/commit/f1e0b326438eada3c074651f7cbf532… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 test: typos - URL: https://github.com/kamailio/kamailio/commit/31396205dfb02b75877a73b19584fcc… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 utils/kamclt: typo - URL: https://github.com/kamailio/kamailio/commit/182b948ae97dc2f797fc5dd01503cb8… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 .github/CONTRIBUTING.md: typo - URL: https://github.com/kamailio/kamailio/commit/6dadb322af4c7e9eff36b29e66680f6… Author: �� <git-dpa(a)aegee.org> Date: 2022-12-28T10:18:25+01:00 examples/kemi: align the list of unfriendly UAs to the native cnf file

2 years

Re: Fwd: git:master:5c90e6e2: DMQ: dmq_notification_address_list is initialized to NULL

by Daniel-Constantin Mierla

It is unlikely that this patch solves any eventual issues that you had. You changed the comparison of a pointer with NULL to 0 and, in C, NULL and 0 are the same in context of pointers: - https://c-faq.com/null/nullor0.html So practically there is not change in behaviour. Cheers, Daniel On 21.12.22 15:41, Olle E. Johansson wrote: > I suggest that this patch be backported :-) > > Cheers, > /O > >> Begin forwarded message: >> >> *From: *Olle E. Johansson <oej(a)edvina.net> >> *Subject: **[sr-dev] git:master:5c90e6e2: DMQ: >> dmq_notification_address_list is initialized to NULL* >> *Date: *21 December 2022 at 15:27:49 CET >> *To: *sr-dev(a)lists.kamailio.org >> *Reply-To: *"Kamailio (SER) - Development Mailing List" >> <sr-dev(a)lists.kamailio.org> >> >> Module: kamailio >> Branch: master >> Commit: 5c90e6e2885a60a1dc5de5ff697c93d6fe59a9cb >> URL: >> https://github.com/kamailio/kamailio/commit/5c90e6e2885a60a1dc5de5ff697c93d… >> >> Author: Olle E. Johansson <oej(a)edvina.net> >> Committer: Olle E. Johansson <oej(a)edvina.net> >> Date: 2022-12-21T15:27:28+01:00 >> >> DMQ: dmq_notification_address_list is initialized to NULL >> >> This code led to random and unpredictable behaviour when loading a >> configuration with >> multiple notification nodes. >> >> --- >> >> Modified: src/modules/dmq/dmq.c >> >> --- >> >> Diff: >> https://github.com/kamailio/kamailio/commit/5c90e6e2885a60a1dc5de5ff697c93d… >> Patch: >> https://github.com/kamailio/kamailio/commit/5c90e6e2885a60a1dc5de5ff697c93d… >> >> --- >> >> diff --git a/src/modules/dmq/dmq.c b/src/modules/dmq/dmq.c >> index 843b7e3e4d2..f4a66c3d847 100644 >> --- a/src/modules/dmq/dmq.c >> +++ b/src/modules/dmq/dmq.c >> @@ -379,7 +379,7 @@ static int >> dmq_add_notification_address(modparam_t type, void * val) >> } >> >> /* initial allocation */ >> -if (dmq_notification_address_list == 0) { >> +if (dmq_notification_address_list == NULL) { >> dmq_notification_address_list = pkg_malloc(sizeof(str_list_t)); >> if (dmq_notification_address_list == NULL) { >> PKG_MEM_ERROR; >> >> _______________________________________________ >> Kamailio (SER) - Development Mailing List >> To unsubscribe send an email to sr-dev-leave(a)lists.kamailio.org > -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda

2 years

git:master:c1813625: DMQ: Add debug line when creating list and adding first notification address

by Olle E. Johansson

Module: kamailio Branch: master Commit: c181362533ca2c7178218aa5b3724219d5deb58c URL: https://github.com/kamailio/kamailio/commit/c181362533ca2c7178218aa5b372421… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2022-12-21T15:27:28+01:00 DMQ: Add debug line when creating list and adding first notification address --- Modified: src/modules/dmq/dmq.c --- Diff: https://github.com/kamailio/kamailio/commit/c181362533ca2c7178218aa5b372421… Patch: https://github.com/kamailio/kamailio/commit/c181362533ca2c7178218aa5b372421… --- diff --git a/src/modules/dmq/dmq.c b/src/modules/dmq/dmq.c index f4a66c3d84..45d92d8400 100644 --- a/src/modules/dmq/dmq.c +++ b/src/modules/dmq/dmq.c @@ -388,6 +388,8 @@ static int dmq_add_notification_address(modparam_t type, void * val) dmq_tmp_list = dmq_notification_address_list; dmq_tmp_list->s = tmp_str; dmq_tmp_list->next = NULL; + LM_DBG("Created list and added new notification address to the list %.*s\n", + dmq_tmp_list->s.len, dmq_tmp_list->s.s); } else { dmq_tmp_list = append_str_list(tmp_str.s, tmp_str.len, &dmq_tmp_list, &total_list); if (dmq_tmp_list == NULL) {

2 years

git:master:5c90e6e2: DMQ: dmq_notification_address_list is initialized to NULL

by Olle E. Johansson

Module: kamailio Branch: master Commit: 5c90e6e2885a60a1dc5de5ff697c93d6fe59a9cb URL: https://github.com/kamailio/kamailio/commit/5c90e6e2885a60a1dc5de5ff697c93d… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2022-12-21T15:27:28+01:00 DMQ: dmq_notification_address_list is initialized to NULL This code led to random and unpredictable behaviour when loading a configuration with multiple notification nodes. --- Modified: src/modules/dmq/dmq.c --- Diff: https://github.com/kamailio/kamailio/commit/5c90e6e2885a60a1dc5de5ff697c93d… Patch: https://github.com/kamailio/kamailio/commit/5c90e6e2885a60a1dc5de5ff697c93d… --- diff --git a/src/modules/dmq/dmq.c b/src/modules/dmq/dmq.c index 843b7e3e4d2..f4a66c3d847 100644 --- a/src/modules/dmq/dmq.c +++ b/src/modules/dmq/dmq.c @@ -379,7 +379,7 @@ static int dmq_add_notification_address(modparam_t type, void * val) } /* initial allocation */ - if (dmq_notification_address_list == 0) { + if (dmq_notification_address_list == NULL) { dmq_notification_address_list = pkg_malloc(sizeof(str_list_t)); if (dmq_notification_address_list == NULL) { PKG_MEM_ERROR;

2 years

← Newer
1
...
9
10
11
12
13
14
15
...
27
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2022