You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3313
-- Commit Summary --
* core: typos - succesSful
* misc/examples: update comments
* auth: typo statefulLy
* ims_auth: typo succesSful
* ims_registrar_pcscf: typo successfulLy
* keepalive: typo unsuccesSful
* nathelper: typo statefulLy
* pipelimit: typo unsuccesSful
* ratelimit: typo unsuccesSful
* snmpstats: typo unsuccesSful
* test/misc: typo sucesSful
* tls: typo succesSfulLy
* tls_wolfssl: type succesSfulLy
* uid_avp_db: typo succesSful
-- File Changes --
M misc/examples/kamailio/acc.cfg (2)
M misc/examples/mixed/acc.cfg (2)
M misc/examples/mixed/uas.cfg (2)
M misc/examples/obsoleted/backup.cfg (2)
M misc/examples/obsoleted/test.cfg (2)
M misc/examples/obsoleted/tmtest.cfg (2)
M src/core/tcp_main.c (2)
M src/modules/auth/auth.xml (2)
M src/modules/ims_auth/sip_messages.h (2)
M src/modules/ims_registrar_pcscf/save.c (2)
M src/modules/keepalive/doc/keepalive_admin.xml (2)
M src/modules/nathelper/examples/nathelper.cfg (2)
M src/modules/nathelper/examples/nathelper_rtpp.cfg (2)
M src/modules/pipelimit/pl_statistics.c (2)
M src/modules/ratelimit/rl_statistics.c (2)
M src/modules/snmpstats/snmp_statistics.c (2)
M src/modules/tls/tls_server.c (2)
M src/modules/tls_wolfssl/tls_server.c (2)
M src/modules/uid_avp_db/README (2)
M src/modules/uid_avp_db/doc/avp_dialogs.cfg (2)
M test/misc/cfg/acc-test.cfg (4)
M test/misc/cfg/sf.cfg (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3313.patchhttps://github.com/kamailio/kamailio/pull/3313.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3313
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3313(a)github.com>
It is unlikely that this patch solves any eventual issues that you had.
You changed the comparison of a pointer with NULL to 0 and, in C, NULL
and 0 are the same in context of pointers:
- https://c-faq.com/null/nullor0.html
So practically there is not change in behaviour.
Cheers,
Daniel
On 21.12.22 15:41, Olle E. Johansson wrote:
> I suggest that this patch be backported :-)
>
> Cheers,
> /O
>
>> Begin forwarded message:
>>
>> *From: *Olle E. Johansson <oej(a)edvina.net>
>> *Subject: **[sr-dev] git:master:5c90e6e2: DMQ:
>> dmq_notification_address_list is initialized to NULL*
>> *Date: *21 December 2022 at 15:27:49 CET
>> *To: *sr-dev(a)lists.kamailio.org
>> *Reply-To: *"Kamailio (SER) - Development Mailing List"
>> <sr-dev(a)lists.kamailio.org>
>>
>> Module: kamailio
>> Branch: master
>> Commit: 5c90e6e2885a60a1dc5de5ff697c93d6fe59a9cb
>> URL:
>> https://github.com/kamailio/kamailio/commit/5c90e6e2885a60a1dc5de5ff697c93d…
>>
>> Author: Olle E. Johansson <oej(a)edvina.net>
>> Committer: Olle E. Johansson <oej(a)edvina.net>
>> Date: 2022-12-21T15:27:28+01:00
>>
>> DMQ: dmq_notification_address_list is initialized to NULL
>>
>> This code led to random and unpredictable behaviour when loading a
>> configuration with
>> multiple notification nodes.
>>
>> ---
>>
>> Modified: src/modules/dmq/dmq.c
>>
>> ---
>>
>> Diff:
>> https://github.com/kamailio/kamailio/commit/5c90e6e2885a60a1dc5de5ff697c93d…
>> Patch:
>> https://github.com/kamailio/kamailio/commit/5c90e6e2885a60a1dc5de5ff697c93d…
>>
>> ---
>>
>> diff --git a/src/modules/dmq/dmq.c b/src/modules/dmq/dmq.c
>> index 843b7e3e4d2..f4a66c3d847 100644
>> --- a/src/modules/dmq/dmq.c
>> +++ b/src/modules/dmq/dmq.c
>> @@ -379,7 +379,7 @@ static int
>> dmq_add_notification_address(modparam_t type, void * val)
>> }
>>
>> /* initial allocation */
>> -if (dmq_notification_address_list == 0) {
>> +if (dmq_notification_address_list == NULL) {
>> dmq_notification_address_list = pkg_malloc(sizeof(str_list_t));
>> if (dmq_notification_address_list == NULL) {
>> PKG_MEM_ERROR;
>>
>> _______________________________________________
>> Kamailio (SER) - Development Mailing List
>> To unsubscribe send an email to sr-dev-leave(a)lists.kamailio.org
>
--
Daniel-Constantin Mierla -- www.asipto.comwww.twitter.com/miconda -- www.linkedin.com/in/miconda