sr-dev November 2022

sr-dev@lists.kamailio.org

11 participants
214 discussions

git:master:d1c13663: lrkproxy: switch to long pvar field

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: d1c13663538349282915ce7f861b337f8923fff6 URL: https://github.com/kamailio/kamailio/commit/d1c13663538349282915ce7f861b337… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-11-16T16:49:30+01:00 lrkproxy: switch to long pvar field --- Modified: src/modules/lrkproxy/lrkproxy.c --- Diff: https://github.com/kamailio/kamailio/commit/d1c13663538349282915ce7f861b337… Patch: https://github.com/kamailio/kamailio/commit/d1c13663538349282915ce7f861b337… --- diff --git a/src/modules/lrkproxy/lrkproxy.c b/src/modules/lrkproxy/lrkproxy.c index cdd69bf75e..ef0734e9db 100644 --- a/src/modules/lrkproxy/lrkproxy.c +++ b/src/modules/lrkproxy/lrkproxy.c @@ -1613,7 +1613,7 @@ set_lrkproxy_set_f(struct sip_msg * msg, char * str1, char * str2) } selected_lrkp_set = select_lrkp_set(val.ri); if(selected_lrkp_set==NULL) { - LM_ERR("could not locate lrkproxy set %d\n", val.ri); + LM_ERR("could not locate lrkproxy set %ld\n", val.ri); return -1; } current_msg_id = msg->id;

1 year, 6 months

git:master:2aefad22: pv: switch to long pvar field

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 2aefad224788891f61b25e2ea683a9a6b35ac069 URL: https://github.com/kamailio/kamailio/commit/2aefad224788891f61b25e2ea683a9a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-11-16T16:49:30+01:00 pv: switch to long pvar field --- Modified: src/modules/pv/pv_trans.c --- Diff: https://github.com/kamailio/kamailio/commit/2aefad224788891f61b25e2ea683a9a… Patch: https://github.com/kamailio/kamailio/commit/2aefad224788891f61b25e2ea683a9a… --- diff --git a/src/modules/pv/pv_trans.c b/src/modules/pv/pv_trans.c index a2b546d02a..2cedfc2416 100644 --- a/src/modules/pv/pv_trans.c +++ b/src/modules/pv/pv_trans.c @@ -216,7 +216,7 @@ int tr_eval_string(struct sip_msg *msg, tr_param_t *tp, int subtype, case TR_S_INT: if(!(val->flags&PV_VAL_INT)) { - if(str2sint(&val->rs, &val->ri)!=0) + if(str2slong(&val->rs, &val->ri)!=0) return -1; } else { if(!(val->flags&PV_VAL_STR))

1 year, 6 months

git:master:d096290d: rtpengine: switch to long pvar field

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: d096290d7b9d27a5e817bc40eebd16e1e09be885 URL: https://github.com/kamailio/kamailio/commit/d096290d7b9d27a5e817bc40eebd16e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-11-16T16:49:30+01:00 rtpengine: switch to long pvar field --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/d096290d7b9d27a5e817bc40eebd16e… Patch: https://github.com/kamailio/kamailio/commit/d096290d7b9d27a5e817bc40eebd16e… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index d3f8e599db..2ae607fcdb 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -3801,7 +3801,7 @@ set_rtpengine_set_n(struct sip_msg *msg, rtpp_set_link_t *rtpl, struct rtpp_set } *out = select_rtpp_set(val.ri); if(*out==NULL) { - LM_ERR("could not locate rtpengine set %u\n", val.ri); + LM_ERR("could not locate rtpengine set %ld\n", val.ri); return -1; } current_msg_id = msg->id;

1 year, 6 months

git:master:721b7283: rtpproxy: switch to long pvar field

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 721b728356fa31bd35721d9ba5d047121f535d5e URL: https://github.com/kamailio/kamailio/commit/721b728356fa31bd35721d9ba5d0471… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-11-16T16:49:30+01:00 rtpproxy: switch to long pvar field --- Modified: src/modules/rtpproxy/rtpproxy.c --- Diff: https://github.com/kamailio/kamailio/commit/721b728356fa31bd35721d9ba5d0471… Patch: https://github.com/kamailio/kamailio/commit/721b728356fa31bd35721d9ba5d0471… --- diff --git a/src/modules/rtpproxy/rtpproxy.c b/src/modules/rtpproxy/rtpproxy.c index 46184310c4e..986959d0237 100644 --- a/src/modules/rtpproxy/rtpproxy.c +++ b/src/modules/rtpproxy/rtpproxy.c @@ -1696,7 +1696,7 @@ set_rtp_proxy_set_f(struct sip_msg * msg, char * str1, char * str2) } selected_rtpp_set = select_rtpp_set(val.ri); if(selected_rtpp_set==NULL) { - LM_ERR("could not locate rtpproxy set %d\n", val.ri); + LM_ERR("could not locate rtpproxy set %ld\n", val.ri); return -1; } current_msg_id = msg->id;

1 year, 6 months

git:master:0fccc094: sdpops: switch to long pvar field

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 0fccc0949ac682dc59a4a5e00f3ee895c244ee6a URL: https://github.com/kamailio/kamailio/commit/0fccc0949ac682dc59a4a5e00f3ee89… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-11-16T16:49:30+01:00 sdpops: switch to long pvar field --- Modified: src/modules/sdpops/sdpops_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/0fccc0949ac682dc59a4a5e00f3ee89… Patch: https://github.com/kamailio/kamailio/commit/0fccc0949ac682dc59a4a5e00f3ee89…

1 year, 6 months

git:master:9ecbdce1: call_control: switch to long pvar field

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 9ecbdce1a5ded2c5247a9a204b7841627f5e172a URL: https://github.com/kamailio/kamailio/commit/9ecbdce1a5ded2c5247a9a204b78416… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-11-16T16:49:30+01:00 call_control: switch to long pvar field --- Modified: src/modules/call_control/call_control.c --- Diff: https://github.com/kamailio/kamailio/commit/9ecbdce1a5ded2c5247a9a204b78416… Patch: https://github.com/kamailio/kamailio/commit/9ecbdce1a5ded2c5247a9a204b78416… --- diff --git a/src/modules/call_control/call_control.c b/src/modules/call_control/call_control.c index 98de64523d0..14455ec967f 100644 --- a/src/modules/call_control/call_control.c +++ b/src/modules/call_control/call_control.c @@ -589,7 +589,7 @@ make_custom_request(struct sip_msg *msg, CallInfo *call) } if (pt.flags & PV_VAL_INT) { len += snprintf(request + len0, sizeof(request)-len0, - "%.*s = %d ", al->name.len, al->name.s, + "%.*s = %ld ", al->name.len, al->name.s, pt.ri); } else if (pt.flags & PV_VAL_STR) { len += snprintf(request + len0, sizeof(request)-len0,

1 year, 6 months

git:master:90557633: core: pv - field for int value switched to long

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 9055763381d56fb78384fd33589c7c2e768f0572 URL: https://github.com/kamailio/kamailio/commit/9055763381d56fb78384fd33589c7c2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-11-16T16:49:30+01:00 core: pv - field for int value switched to long --- Modified: src/core/pvar.h --- Diff: https://github.com/kamailio/kamailio/commit/9055763381d56fb78384fd33589c7c2… Patch: https://github.com/kamailio/kamailio/commit/9055763381d56fb78384fd33589c7c2… --- diff --git a/src/core/pvar.h b/src/core/pvar.h index 155b0125fb..292a5b2f98 100644 --- a/src/core/pvar.h +++ b/src/core/pvar.h @@ -90,7 +90,7 @@ typedef void (*pv_name_free_f)(void*); typedef struct _pv_value { str rs; /*!< string value */ - int ri; /*!< integer value */ + long ri; /*!< long value */ int flags; /*!< flags about the type of value */ } pv_value_t, *pv_value_p; @@ -266,7 +266,7 @@ enum _tr_param_type { TR_PARAM_NONE=0, TR_PARAM_STRING, TR_PARAM_NUMBER, typedef struct _tr_param { int type; union { - int n; + long n; str s; void *data; } v;

1 year, 6 months

git:master:b8d74973: core: rename RV_INT to RV_LONG and RVE_INT_OP to RVE_LONG_OP

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: b8d74973cffc504a76c543f65940a4810633efe5 URL: https://github.com/kamailio/kamailio/commit/b8d74973cffc504a76c543f65940a48… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-11-16T16:49:30+01:00 core: rename RV_INT to RV_LONG and RVE_INT_OP to RVE_LONG_OP --- Modified: src/core/cfg.y Modified: src/core/lvalue.c Modified: src/core/route.c Modified: src/core/rvalue.c Modified: src/core/rvalue.h --- Diff: https://github.com/kamailio/kamailio/commit/b8d74973cffc504a76c543f65940a48… Patch: https://github.com/kamailio/kamailio/commit/b8d74973cffc504a76c543f65940a48…

1 year, 6 months

git:master:9762c5f0: modules: readme files regenerated - dialog ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 9762c5f0d8268e76d55030203b5f0021509fffe6 URL: https://github.com/kamailio/kamailio/commit/9762c5f0d8268e76d55030203b5f002… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-11-16T16:46:25+01:00 modules: readme files regenerated - dialog ... [skip ci] --- Modified: src/modules/dialog/README --- Diff: https://github.com/kamailio/kamailio/commit/9762c5f0d8268e76d55030203b5f002… Patch: https://github.com/kamailio/kamailio/commit/9762c5f0d8268e76d55030203b5f002…

1 year, 6 months

git:master:a6d9505b: dialog: deactivate print variable function which is only used for debugging

by Henning Westerholt

Module: kamailio Branch: master Commit: a6d9505b107204ffbe613d9f78beac22e09e8915 URL: https://github.com/kamailio/kamailio/commit/a6d9505b107204ffbe613d9f78beac2… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-11-16T15:35:25Z dialog: deactivate print variable function which is only used for debugging - deactivate print variable function which is only used for debugging - this function is not good for performance and might also cause race conditions --- Modified: src/modules/dialog/dialog.c Modified: src/modules/dialog/dlg_var.c Modified: src/modules/dialog/dlg_var.h Modified: src/modules/dialog/doc/dialog_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/a6d9505b107204ffbe613d9f78beac2… Patch: https://github.com/kamailio/kamailio/commit/a6d9505b107204ffbe613d9f78beac2… --- diff --git a/src/modules/dialog/dialog.c b/src/modules/dialog/dialog.c index 9fcff42fb9..2bcbd32833 100644 --- a/src/modules/dialog/dialog.c +++ b/src/modules/dialog/dialog.c @@ -144,6 +144,8 @@ stat_var *expired_dlgs = 0; stat_var *failed_dlgs = 0; stat_var *early_dlgs = 0; +int debug_variables_list = 0; + struct tm_binds d_tmb; struct rr_binds d_rrb; pv_spec_t timeout_avp; @@ -363,6 +365,7 @@ static param_export_t mod_params[]={ { "bye_early_code", PARAM_INT, &bye_early_code }, { "bye_early_reason", PARAM_STR, &bye_early_reason }, { "dlg_ctxiuid_mode", PARAM_INT, &dlg_ctxiuid_mode }, + { "debug_variables", PARAM_INT, &debug_variables_list }, { 0,0,0 } }; diff --git a/src/modules/dialog/dlg_var.c b/src/modules/dialog/dlg_var.c index 473736b437..0e165c5e49 100644 --- a/src/modules/dialog/dlg_var.c +++ b/src/modules/dialog/dlg_var.c @@ -449,7 +449,9 @@ int set_dlg_variable(struct dlg_cell *dlg, str *key, str *val) if ( dlg_db_mode==DB_MODE_REALTIME ) update_dialog_dbinfo(dlg); - print_lists(dlg); + if(unlikely(debug_variables_list)) { + print_lists(dlg); + } return 0; @@ -510,7 +512,9 @@ int pv_get_dlg_variable(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) } } - print_lists(dlg); + if(unlikely(debug_variables_list)) { + print_lists(dlg); + } /* unlock dialog */ if (dlg) { @@ -584,7 +588,9 @@ int pv_set_dlg_variable(struct sip_msg* msg, pv_param_t *param, int op, pv_value } dlg_unlock(d_table, &(d_table->entries[dlg->h_entry])); } - print_lists(dlg); + if(unlikely(debug_variables_list)) { + print_lists(dlg); + } dlg_release(dlg); return 0; diff --git a/src/modules/dialog/dlg_var.h b/src/modules/dialog/dlg_var.h index 292e9f701b..44bd6ecb73 100644 --- a/src/modules/dialog/dlg_var.h +++ b/src/modules/dialog/dlg_var.h @@ -89,6 +89,8 @@ extern stat_var *processed_dlgs; /*!< number of processed dialogs */ extern stat_var *expired_dlgs; /*!< number of expired dialogs */ extern stat_var *failed_dlgs; /*!< number of failed dialogs */ +extern int debug_variables_list; + int pv_get_dlg_ctx(sip_msg_t *msg, pv_param_t *param, pv_value_t *res); int pv_set_dlg_ctx(sip_msg_t *msg, pv_param_t *param, diff --git a/src/modules/dialog/doc/dialog_admin.xml b/src/modules/dialog/doc/dialog_admin.xml index 7a1a11c59a..cea057c797 100644 --- a/src/modules/dialog/doc/dialog_admin.xml +++ b/src/modules/dialog/doc/dialog_admin.xml @@ -1733,6 +1733,28 @@ modparam("dialog", "dlg_ctxiuid_mode", 1) </example> </section> + <section id="dialog.p.debug_variables"> + <title><varname>debug_variables</varname> (int)</title> + <para> + Activate additional debugging for printing internal lists for dialog variables. + This output is only visible at debug log level and should only be used for + debugging. By default its deactivated. + </para> + <para> + <emphasis> + Default value is <quote>0</quote>. + </emphasis> + </para> + <example> + <title>Set <varname>debug_variables</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("dialog", "debug_variables", 1) +... +</programlisting> + </example> + </section> + </section> <section>

1 year, 6 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2022