sr-dev August 2021

sr-dev@lists.kamailio.org

19 participants
267 discussions

[kamailio/kamailio] ndb_redis: fix SIGSEGV in redisc_check_auth (#2834)

by Dennis

Hi ! This issue appears when ndb_redis module connect to redis via proxy, in my case haproxy. Haproxy keeps front socket always open, when all backend redis servers become unavailable, haproxy just send RST to front, redisCommand function in tis case return NULL poiner, redisc_check_auth try to dereference it without NULL checking. kamailio log: `kernel: [7250430.508827] kamailio[21749]: segfault at 0 ip 00007f00d7bb106f sp 00007fffc523c620 error 4 in ndb_redis.so[7f00d7b94000+36000]` gdb: ``` # gdb /usr/sbin/kamailio core GNU gdb (Ubuntu 8.1.1-0ubuntu1) 8.1.1 Copyright (C) 2018 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-linux-gnu". Type "show configuration" for configuration details. For bug reporting instructions, please see: <http://www.gnu.org/software/gdb/bugs/>. Find the GDB manual and other documentation resources online at: <http://www.gnu.org/software/gdb/documentation/>. For help, type "help". Type "apropos word" to search for commands related to "word"... Reading symbols from /usr/sbin/kamailio...(no debugging symbols found)...done. [New LWP 21752] [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". Core was generated by `/usr/sbin/kamailio -P /run/kamailio/kamailio.pid -f /etc/kamailio/kamailio.cfg'. Program terminated with signal SIGSEGV, Segmentation fault. #0 0x00007f00d7bb106f in redisc_check_auth () from /usr/lib64/kamailio/modules/ndb_redis.so (gdb) bt #0 0x00007f00d7bb106f in redisc_check_auth () from /usr/lib64/kamailio/modules/ndb_redis.so #1 0x00007f00d7b9937a in redisc_init () from /usr/lib64/kamailio/modules/ndb_redis.so #2 0x00007f00d7bb4300 in print_redis_reply () from /usr/lib64/kamailio/modules/ndb_redis.so #3 0x0000561825796935 in ?? () #4 0x0000561825796550 in ?? () #5 0x0000561825796550 in ?? () #6 0x0000561825796550 in ?? () #7 0x0000561825796550 in ?? () #8 0x0000561825796550 in ?? () #9 0x0000561825796550 in ?? () #10 0x0000561825796550 in ?? () #11 0x0000561825796550 in ?? () #12 0x0000561825796550 in ?? () #13 0x0000561825796550 in ?? () #14 0x0000561825796550 in ?? () #15 0x0000561825796550 in ?? () #16 0x0000561825796550 in ?? () #17 0x000056182579722c in init_child () #18 0x00005618256f4520 in fork_process () #19 0x00005618255cfbf3 in main_loop () #20 0x00005618255dd095 in main () ```   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2834 -- Commit Summary -- * ndb_redis: fix SIGSEGV in redisc_check_auth -- File Changes -- M src/modules/ndb_redis/redis_client.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2834.patch https://github.com/kamailio/kamailio/pull/2834.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2834

3 years, 4 months

git:master:c32a0be8: ndb_redis: fix SIGSEGV in redisc_check_auth

by Victor Seva

Module: kamailio Branch: master Commit: c32a0be89cc92a0649277774d1e7aebf349b8b49 URL: https://github.com/kamailio/kamailio/commit/c32a0be89cc92a0649277774d1e7aeb… Author: Dennis Yurasov <dennis-y(a)yandex-team.ru> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2021-08-26T11:25:29+02:00 ndb_redis: fix SIGSEGV in redisc_check_auth - Added the check for NULL pointer. When TCP session to redis reset, redisCommand function can return NULL pointer. --- Modified: src/modules/ndb_redis/redis_client.c --- Diff: https://github.com/kamailio/kamailio/commit/c32a0be89cc92a0649277774d1e7aeb… Patch: https://github.com/kamailio/kamailio/commit/c32a0be89cc92a0649277774d1e7aeb… --- diff --git a/src/modules/ndb_redis/redis_client.c b/src/modules/ndb_redis/redis_client.c index befb69ab79..bb6adc20b1 100644 --- a/src/modules/ndb_redis/redis_client.c +++ b/src/modules/ndb_redis/redis_client.c @@ -1269,6 +1269,10 @@ int redisc_check_auth(redisc_server_t *rsrv, char *pass) int retval = 0; reply = redisCommand(rsrv->ctxRedis, "AUTH %s", pass); + if(!reply) { + LM_ERR("Redis authentication error\n"); + return -1; + } if (reply->type == REDIS_REPLY_ERROR) { LM_ERR("Redis authentication error\n"); retval = -1;

3 years, 4 months

git:master:79b3980b: modules: readme files regenerated - ruxc ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 79b3980b62d274a33365b8895d53fdf208ea0991 URL: https://github.com/kamailio/kamailio/commit/79b3980b62d274a33365b8895d53fdf… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2021-08-26T11:16:25+02:00 modules: readme files regenerated - ruxc ... [skip ci] --- Modified: src/modules/ruxc/README --- Diff: https://github.com/kamailio/kamailio/commit/79b3980b62d274a33365b8895d53fdf… Patch: https://github.com/kamailio/kamailio/commit/79b3980b62d274a33365b8895d53fdf… --- diff --git a/src/modules/ruxc/README b/src/modules/ruxc/README index 66aba00ef9..868faea5e6 100644 --- a/src/modules/ruxc/README +++ b/src/modules/ruxc/README @@ -40,6 +40,7 @@ Daniel-Constantin Mierla 4.1. ruxc_http_get(url, hdrs, respv) 4.2. ruxc_http_post(url, body, hdrs, respv) + 4.3. ruxc_http_delete(url, body, hdrs, respv) 5. Installation @@ -56,7 +57,8 @@ Daniel-Constantin Mierla 1.9. Set http_debug parameter 1.10. ruxc_http_get() usage 1.11. ruxc_http_post() usage - 1.12. Libruxc Usage + 1.12. ruxc_http_delete() usage + 1.13. Libruxc Usage Chapter 1. Admin Guide @@ -84,6 +86,7 @@ Chapter 1. Admin Guide 4.1. ruxc_http_get(url, hdrs, respv) 4.2. ruxc_http_post(url, body, hdrs, respv) + 4.3. ruxc_http_delete(url, body, hdrs, respv) 5. Installation @@ -256,6 +259,7 @@ modparam("ruxc", "http_debug", 1) 4.1. ruxc_http_get(url, hdrs, respv) 4.2. ruxc_http_post(url, body, hdrs, respv) + 4.3. ruxc_http_delete(url, body, hdrs, respv) 4.1. ruxc_http_get(url, hdrs, respv) @@ -302,6 +306,29 @@ switch ($rc) { } ... +4.3. ruxc_http_delete(url, body, hdrs, respv) + + Perform a HTTP DELETE request to "url", storing the response body in + the "respv" variable. The "body" and "hdrs" can be empty strings to + skip setting them. The first three parameters can contain variables + that are evaluated at runtime. The "respv" has to be the name of a + writable variable. + + The function returns response code of HTTP reply or negative value if + something went wrong. + + This function can be used from ANY_ROUTE. + + Example 1.12. ruxc_http_delete() usage +... +ruxc_http_delete("http://api.com/index.php?r_uri=$(ru{s.escape.param})&f_uri=$(f +u{s.escape.param})", + "", "X-Token: abc", "$var(result)"); +switch ($rc) { + ... +} +... + 5. Installation The module needs "libruxc" library, which is provided by "ruxc" project @@ -315,7 +342,7 @@ switch ($rc) { installed and its environment configured, then run the following commands: - Example 1.12. Libruxc Usage + Example 1.13. Libruxc Usage ... git clone https://github.com/miconda/ruxc cd ruxc

3 years, 4 months

git:master:ec9eb48d: ruxc: added ruxc_http_delete(...) to do HTTP DELETE request

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: ec9eb48dfde072630fd85a80d6d5c45e377816a3 URL: https://github.com/kamailio/kamailio/commit/ec9eb48dfde072630fd85a80d6d5c45… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-08-26T11:04:27+02:00 ruxc: added ruxc_http_delete(...) to do HTTP DELETE request --- Modified: src/modules/ruxc/doc/ruxc_admin.xml Modified: src/modules/ruxc/ruxc_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/ec9eb48dfde072630fd85a80d6d5c45… Patch: https://github.com/kamailio/kamailio/commit/ec9eb48dfde072630fd85a80d6d5c45…

3 years, 4 months

Troubleshooting segfault in shared memory

by Anthony Alba

Hi sr-dev, I have a pointer from one child process A that is available to another child process B (this is a custom module I am developing). The object should have been allocated in shared memory by A using ser_malloc and friends and thus accessible from B. However B is encountering a segfault when accessing this object. Given a pointer how can I tell whether the memory it is pointing to is valid in all children, i.e, the target is in kamailio shared memory? Thanks Anthony Alba

3 years, 4 months

Kamailio v5.5.2 Released

by Daniel-Constantin Mierla

Hello, Kamailio SIP Server v5.5.2 stable release is out. This is a maintenance release of the latest stable branch, 5.5, that includes fixes since the release of v5.5.1. There is no change to database schema or configuration language structure that you have to do on previous installations of v5.5.x. Deployments running previous v5.5.x versions are strongly recommended to be upgraded to v5.5.2. For more details about version 5.5.2 (including links and guidelines to download the tarball or from GIT repository), visit: * https://www.kamailio.org/w/2021/08/kamailio-v5-5-2-released/ RPM, Debian/Ubuntu packages will be available soon as well. Many thanks to all contributing and using Kamailio! Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda

3 years, 4 months

git:5.5:e5f5a8f4: Changelog: fix version for release 5.5.2

by Henning Westerholt

Module: kamailio Branch: 5.5 Commit: e5f5a8f46e74960308fe63336731fea2775b4e07 URL: https://github.com/kamailio/kamailio/commit/e5f5a8f46e74960308fe63336731fea… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2021-08-25T19:26:21Z Changelog: fix version for release 5.5.2 --- Modified: ChangeLog --- Diff: https://github.com/kamailio/kamailio/commit/e5f5a8f46e74960308fe63336731fea… Patch: https://github.com/kamailio/kamailio/commit/e5f5a8f46e74960308fe63336731fea… --- diff --git a/ChangeLog b/ChangeLog index 0a9031b24f..bcce4916fb 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,6 +1,6 @@ ===================== 2021-08-25 Version 5.5.2 Released ===================== -===================== Changes Since Version 5.5.2 =========================== +===================== Changes Since Version 5.5.1 =========================== commit 0d6832949e5e3e554d7a492f32448281d4988053 Author: Daniel-Constantin Mierla <miconda(a)gmail.com>

3 years, 4 months

[kamailio/kamailio] NATPING ERROR (#2835)

by JoelBorrego

we trying to configurate the pcscf.cfg file and we the following error Do you have an idea of the reason of this error?, 78(12285)ERROR: *** cfgtrace:dbg_cfg_trace(): request_route=[NATPING] c=[/etc/kamailio_pcscf/kamailio_pcscf.cfg] l=836 a=5 n=route 78(12285) ERROR: *** cfgtrace:dbg_cfg_trace(): request_route=[preload_pcscf] c=[/etc/kamailio_pcscf/kamailio_pcscf.cfg] l=895 a=16 n=if 78(12285) ERROR: *** cfgtrace:dbg_cfg_trace(): request_route=[preload_pcscf] c=[/etc/kamailio_pcscf/kamailio_pcscf.cfg] l=894 a=2 n=return 78(12285) ERROR: *** cfgtrace:dbg_cfg_trace(): request_route=[NATPING] c=[/etc/kamailio_pcscf/kamailio_pcscf.cfg] l=838 a=26 n=sht_iterator_start 78(12285) ERROR: *** cfgtrace:dbg_cfg_trace(): request_route=[NATPING] c=[/etc/kamailio_pcscf/kamailio_pcscf.cfg] l=848 a=23 n=while 78(12285) ERROR: *** cfgtrace:dbg_cfg_trace(): request_route=[NATPING] c=[/etc/kamailio_pcscf/kamailio_pcscf.cfg] l=839 a=25 n=sht_iterator_next 78(12285) ERROR: *** cfgtrace:dbg_cfg_trace(): request_route=[NATPING] c=[/etc/kamailio_pcscf/kamailio_pcscf.cfg] l=849 a=25 n=sht_iterator_end -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2835

3 years, 4 months

git:5.5:55e232dd: ChangeLog: content updated for v5.5.1

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.5 Commit: 55e232dd7fb43eb3e8c63d4908af9244e9a598c1 URL: https://github.com/kamailio/kamailio/commit/55e232dd7fb43eb3e8c63d4908af924… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-08-25T12:01:55+02:00 ChangeLog: content updated for v5.5.1 --- Modified: ChangeLog --- Diff: https://github.com/kamailio/kamailio/commit/55e232dd7fb43eb3e8c63d4908af924… Patch: https://github.com/kamailio/kamailio/commit/55e232dd7fb43eb3e8c63d4908af924…

3 years, 4 months

git:master:adfa9094: modules: readme files regenerated - lcr ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: adfa9094052c2eb74d9513b66b965e37410bedcf URL: https://github.com/kamailio/kamailio/commit/adfa9094052c2eb74d9513b66b965e3… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2021-08-25T09:31:20+02:00 modules: readme files regenerated - lcr ... [skip ci] --- Modified: src/modules/lcr/README --- Diff: https://github.com/kamailio/kamailio/commit/adfa9094052c2eb74d9513b66b965e3… Patch: https://github.com/kamailio/kamailio/commit/adfa9094052c2eb74d9513b66b965e3…

3 years, 4 months

← Newer
1
...
12
13
14
15
16
17
18
...
27
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev August 2021