sr-dev April 2021

sr-dev@lists.kamailio.org

14 participants
303 discussions

[kamailio/kamailio] domain: fix use after free on domain reload (#2712)

by Mancaș George

#### Pre-Submission Checklist - [*] Commit message has the format required by CONTRIBUTING guide - [*] Commits are split per component (core, individual modules, libs, utils, ...) - [*] Each component has a single commit (if not, squash them into one commit) - [*] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [*] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [*] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description I observed this when glancing over commit https://github.com/kamailio/kamailio/commit/f50177003c21f53564be6349c0bb493… The invalid access is pretty clear, and so is the fix. Cheers! You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2712 -- Commit Summary -- * domain: fix use after free on domain reload -- File Changes -- M src/modules/domain/hash.c (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2712.patch https://github.com/kamailio/kamailio/pull/2712.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2712

3 years, 8 months

git:master:62d981da: Merge pull request #2712 from mancasg/patch-1

by GitHub

Module: kamailio Branch: master Commit: 62d981daa5d8d61f3f4f72996a613b8ad8e88f26 URL: https://github.com/kamailio/kamailio/commit/62d981daa5d8d61f3f4f72996a613b8… Author: Olle E. Johansson <oej(a)edvina.net> Committer: GitHub <noreply(a)github.com> Date: 2021-04-19T08:20:20+02:00 Merge pull request #2712 from mancasg/patch-1 domain: fix use after free on domain reload --- Modified: src/modules/domain/hash.c --- Diff: https://github.com/kamailio/kamailio/commit/62d981daa5d8d61f3f4f72996a613b8… Patch: https://github.com/kamailio/kamailio/commit/62d981daa5d8d61f3f4f72996a613b8… --- diff --git a/src/modules/domain/hash.c b/src/modules/domain/hash.c index 4cb968e458..b085d8f9cb 100644 --- a/src/modules/domain/hash.c +++ b/src/modules/domain/hash.c @@ -204,8 +204,9 @@ void hash_table_free(struct domain_list **hash_table) shm_free(ap); ap = next_ap; } + next = np->next; shm_free(np); - np = np->next; + np = next; } hash_table[DOM_HASH_SIZE] = NULL;

3 years, 8 months

git:master:207d7ada: domain: fix use after free on domain reload

by GitHub

Module: kamailio Branch: master Commit: 207d7adae4ca5d9a197c38ae333ff98124c01b47 URL: https://github.com/kamailio/kamailio/commit/207d7adae4ca5d9a197c38ae333ff98… Author: MancaÈ George <mancasg(a)users.noreply.github.com> Committer: GitHub <noreply(a)github.com> Date: 2021-04-16T19:26:35+03:00 domain: fix use after free on domain reload --- Modified: src/modules/domain/hash.c --- Diff: https://github.com/kamailio/kamailio/commit/207d7adae4ca5d9a197c38ae333ff98… Patch: https://github.com/kamailio/kamailio/commit/207d7adae4ca5d9a197c38ae333ff98… --- diff --git a/src/modules/domain/hash.c b/src/modules/domain/hash.c index 4cb968e458..b085d8f9cb 100644 --- a/src/modules/domain/hash.c +++ b/src/modules/domain/hash.c @@ -204,8 +204,9 @@ void hash_table_free(struct domain_list **hash_table) shm_free(ap); ap = next_ap; } + next = np->next; shm_free(np); - np = np->next; + np = next; } hash_table[DOM_HASH_SIZE] = NULL;

3 years, 8 months

git:master:d02c0422: lost: fixing a memory leak and minor code refactoring and improvements

by Wolfgang Kampichler

Module: kamailio Branch: master Commit: d02c042259a5a0e7bdcc359f5de20c68af6b4211 URL: https://github.com/kamailio/kamailio/commit/d02c042259a5a0e7bdcc359f5de20c6… Author: Wolfgang Kampichler <dev(a)kampichler.info> Committer: Wolfgang Kampichler <dev(a)kampichler.info> Date: 2021-04-18T18:08:13+02:00 lost: fixing a memory leak and minor code refactoring and improvements --- Modified: src/modules/lost/functions.c Modified: src/modules/lost/lost.c Modified: src/modules/lost/utilities.c --- Diff: https://github.com/kamailio/kamailio/commit/d02c042259a5a0e7bdcc359f5de20c6… Patch: https://github.com/kamailio/kamailio/commit/d02c042259a5a0e7bdcc359f5de20c6…

3 years, 8 months

Info: regression for AVP with integer ID on v5.4.5

by Daniel-Constantin Mierla

Hello, a notification to inform about a regression to the AVPs with the integer IDs that was introduced in the v5.4.5 release when trying to fix an issue reported from a static code analyzer/fuzzer. The workaround is to use string names for AVPs, so if you have AVPs like $avp(i:123), they can be changed to $avp(s:123) in the kamailio.cfg (ie., replace i: with s: ). Regression is already fixed in the git branch 5.4, so if you install it from there, all should be ok. For Debian packages, you can wait till tomorrow and use the nightly builds of 5.4.x series from the repos listed at: * http://deb.kamailio.org/#dev54 Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training - Online May 17-20, 2021 (Europe Timezone) - June 7-10, 2021 (America Timezone) * https://www.asipto.com/sw/kamailio-advanced-training-online/

3 years, 8 months

RHEL 6 and CentOS 6 deprecated

by Sergey Safarov

I try to refresh the build image for CentOS 6 and can't do it now. This directory (and version of CentOS) is deprecated. Please see this FAQ concerning the CentOS release scheme: https://wiki.centos.org/FAQ/General Please keep in mind that 6.0, 6.1, 6.2, 6.3, 6.4 , 6.5, 6.6, 6.7, 6.8 , 6.9 and 6.10 no longer get any updates, nor any security fix's. The whole CentOS 6 is *dead* and *shouldn't* be used anywhere at *all* http://mirror.centos.org/centos/6/readme What our plans about Kamailio releases for RHEL 6 and Cent 6 dists?

3 years, 8 months

git:master:2df6f9d6: pkg/kamailio/obs: added lwsc module packaging

by Sergey Safarov

Module: kamailio Branch: master Commit: 2df6f9d6cb74bc115206e8b200af7234267f74d5 URL: https://github.com/kamailio/kamailio/commit/2df6f9d6cb74bc115206e8b200af723… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2021-04-16T15:28:43+03:00 pkg/kamailio/obs: added lwsc module packaging --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/2df6f9d6cb74bc115206e8b200af723… Patch: https://github.com/kamailio/kamailio/commit/2df6f9d6cb74bc115206e8b200af723… --- diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index 29d074cac4..4f5a833a57 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -661,6 +661,16 @@ Lua extensions for Kamailio. %endif +%package lwsc +Summary: Websocket client implementation to interact with external systems, similar to http client +Group: %{PKGGROUP} +Requires: libwebsockets, kamailio = %ver +BuildRequires: libwebsockets-devel + +%description lwsc +Websocket client implementation to interact with external systems, similar to http client. + + %if %{with memcached} %package memcached Summary: Memcached configuration file support for Kamailio @@ -1178,6 +1188,7 @@ make every-module skip_modules="app_mono db_cassandra db_oracle iptrtpproxy \ %if %{with lua} klua \ %endif + klwsc \ %if %{with memcached} kmemcached \ %endif @@ -1270,6 +1281,7 @@ make install-modules-all skip_modules="app_mono db_cassandra db_oracle \ %if %{with lua} klua \ %endif + klwsc \ %if %{with memcached} kmemcached \ %endif @@ -1932,6 +1944,11 @@ fi %endif +%files lwsc +%defattr(-,root,root) +%doc %{_docdir}/kamailio/modules/README.lwsc +%{_libdir}/kamailio/modules/lwsc.so + %if %{with memcached} %files memcached %defattr(-,root,root)

3 years, 8 months

[kamailio/kamailio] kamailio 5.4.5: "0 ID or NULL NAME AVP!" in lcr module (#2709)

by mdyrna

### Description  After upgrading kamailio from 5.4.4 to 5.4.5, the lcr module logs an error for outgoing calls. load_gws returns success (1), but does not populate the avps. Consequently, next_gw fails. ### Troubleshooting #### Reproduction  kamailio.cfg: ``` loadmodule "lcr.so" ... modparam("lcr", "db_url", "cluster://cls1") modparam("lcr", "gw_uri_avp", "$avp(i:709)") modparam("lcr", "ruri_user_avp", "$avp(i:500)") modparam("lcr", "tag_avp", "$avp(lcr_tag)") modparam("lcr", "flags_avp", "$avp(i:712)") modparam("lcr", "defunct_capability", 1) modparam("lcr", "lcr_id_avp", "$avp(s:lcr_id_avp)") modparam("lcr", "defunct_gw_avp", "$avp(s:defunct_gw_avp)") modparam("lcr", "ping_interval", 60) ... route[LCR] { if(!($rU=~"^[+0-9]")) return; if(is_method("INVITE")) { if (!($fU=~"^[+0-9]+$")) { append_hf("P-Asserted-Identity: <sip:+49xxxxxxxxxxx@xxxxx.de>\n"); append_hf("Privacy: id\n"); $fn = "Anonymous"; $fu = "sip:+49xxxxxxxxxxx@xxxxx.de"; } if(load_gws(1, $rU, $var(caller_uri)) != 1) { xlog("L_ERROR", "Couldn't load gateways\n"); sl_send_reply("500", "Server Internal Error - Cannot load gateways"); exit; } else { xlog("L_INFO", "GW Selected '$avp(i:709)'\n"); xlog("L_INFO", "Domain of destination: $dd\n"); xlog("L_INFO", "To URI: $tu\n"); } if(!next_gw()) { xlog("L_WARN", "No gateway configured for $rU\n"); sl_send_reply("503", "Service not available, no gateways found"); exit; } else { xlog("L_INFO", "Calling the first matched gateway\n"); xlog("L_INFO", "ruri_user_avp: '$avp(i:500)'\n"); xlog("L_INFO", "To URI after next_gw: $tu\n"); xlog("L_INFO", "Request URI: $ru\n"); } t_on_failure("MANAGE_FAILURE_LCR"); route(RELAY); exit; } } ``` #### Debugging Data  #### Log Messages  ``` Apr 15 20:59:27 x /usr/sbin/kamailio[879]: ERROR: <core> [core/usr_avp.c:152]: create_avp(): 0 ID or NULL NAME AVP! Apr 15 20:59:27 x /usr/sbin/kamailio[879]: ERROR: <core> [core/usr_avp.c:152]: create_avp(): 0 ID or NULL NAME AVP! Apr 15 20:59:27 x /usr/sbin/kamailio[879]: INFO: <script>: GW Selected '<null>' Apr 15 20:59:27 x /usr/sbin/kamailio[879]: INFO: <script>: Domain of destination: <null> Apr 15 20:59:27 x /usr/sbin/kamailio[879]: INFO: <script>: To URI: sip:+49177xxxxxxx@xx.xxx.x.xxx:5060 Apr 15 20:59:27 x /usr/sbin/kamailio[879]: WARNING: <script>: No gateway configured for +49177xxxxxxx ``` #### SIP Traffic  SIP request: ``` INVITE sip:+49177xxxxxxx@xx.xx.xx.xxx:5060 SIP/2.0 Via: SIP/2.0/UDP xxx.xx.xx.xxx:xxxxx;branch=z9hG4bK5d833a50 Max-Forwards: 70 From: <sip:+xxxxxxxxxxx@xxx.xx.xx.xxx:xxxxx>;tag=as18ff0d47 To: <sip:+49177xxxxxxx@xx.xx.xx.xxx:5060> Contact: <sip:+xxxxxxxxxxx@xxx.xx.xx.xxx:xxxxx> Call-ID: 7489c50703b43b2f03980574181a2f81@xxx.xx.xx.xxx:xxxxx CSeq: 102 INVITE User-Agent: Asterisk PBX 13.18.3~dfsg-1ubuntu4 Date: Thu, 15 Apr 2021 21:52:42 GMT Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY, INFO, PUBLISH, MESSAGE Supported: replaces, timer Content-Type: application/sdp Content-Length: 952 ... ``` SIP reply: ``` SIP/2.0 503 Service not available, no gateways found Via: SIP/2.0/UDP xxx.xx.xx.xxx:xxxxx;branch=z9hG4bK5d833a50;rport=50060;received=xx.xx.xx.xxx From: <sip:+xxxxxxxxxxx@xxx.xx.xx.xxx:xxxxx>;tag=as18ff0d47 To: <sip:+49177xxxxxxx@xx.xx.xx.xxx:5060>;tag=6a823999ce344a0b461cf8d85d526103.51611a36 Call-ID: 7489c50703b43b2f03980574181a2f81@xxx.xx.xx.xxx:xxxxx CSeq: 102 INVITE Server: kamailio (5.4.5 (x86_64/linux)) Content-Length: 0 ``` ### Possible Solutions  As a workaround, I downgraded to kamailio 5.3.8 because the previous Ubuntu release 5.4.4 is not available anymore at http://deb.kamailio.org/kamailio54/pool/main/k/kamailio/ (why actually?) ### Additional Information * **Kamailio Version** 5.4.5 * **Operating System**: Ubuntu 18.04  ### Root Cause Assumption https://github.com/kamailio/kamailio/commit/ca1821837dfe7dd6630f628d968ed4d… might be involved in the issue. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2709

3 years, 8 months

fresh GCC

by Sergey Safarov

I have created a pull request that allows the use of fresh GCC for the FreeSwitch project. https://github.com/signalwire/freeswitch/pull/1161 Think we can use the same approach to use fresh GCC for the Kamailio project. For RHEL based dist and old Debian dest. Is it a useful approach to use fresh GCC to build a master branch? Sergey

3 years, 8 months

git:5.4:967dd294: core: usr avp - fix detection of invalid name and ids

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.4 Commit: 967dd294ba424bf66e27bebe4d6261e0c8a66471 URL: https://github.com/kamailio/kamailio/commit/967dd294ba424bf66e27bebe4d6261e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-04-16T09:58:16+02:00 core: usr avp - fix detection of invalid name and ids - use the fields designated for str name or int id, code analyzers can follow properly the execution path - regression introduced in ca1821837dfe7dd6630f628d968ed4d1178c7040 (cherry picked from commit e4506385ca5a56d4861f36e85c1049599cba398f) --- Modified: src/core/usr_avp.c --- Diff: https://github.com/kamailio/kamailio/commit/967dd294ba424bf66e27bebe4d6261e… Patch: https://github.com/kamailio/kamailio/commit/967dd294ba424bf66e27bebe4d6261e… --- diff --git a/src/core/usr_avp.c b/src/core/usr_avp.c index e80e52d79d..8d8fa34603 100644 --- a/src/core/usr_avp.c +++ b/src/core/usr_avp.c @@ -148,16 +148,11 @@ avp_t *create_avp (avp_flags_t flags, avp_name_t name, avp_value_t val) struct str_str_data *ssd; int len; - if (name.s.s == NULL || name.s.len == 0) { - LM_ERR("0 ID or NULL NAME AVP!"); - goto error; - } - /* compute the required mem size */ len = sizeof(struct usr_avp); if (flags&AVP_NAME_STR) { if ( name.s.s==0 || name.s.len==0) { - LM_ERR("EMPTY NAME AVP!"); + LM_ERR("NULL or EMPTY NAME AVP!"); goto error; } if (flags&AVP_VAL_STR) { @@ -168,8 +163,14 @@ avp_t *create_avp (avp_flags_t flags, avp_name_t name, avp_value_t val) len += sizeof(struct str_int_data)-sizeof(union usr_avp_data) + name.s.len + 1; /* Terminating zero for regex search */ } - } else if (flags&AVP_VAL_STR) { - len += sizeof(str)-sizeof(union usr_avp_data) + val.s.len + 1; + } else { + if(name.n==0) { + LM_ERR("0 ID AVP!"); + goto error; + } + if (flags&AVP_VAL_STR) { + len += sizeof(str)-sizeof(union usr_avp_data) + val.s.len + 1; + } } avp = (struct usr_avp*)shm_malloc( len );

3 years, 8 months

← Newer
1
...
15
16
17
18
19
20
21
...
31
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2021