sr-dev February 2021

sr-dev@lists.kamailio.org

20 participants
248 discussions

When/why are OpenSSL objects free'd in a different process?

by Anthony Alba

Hi Daniel and kamailio devs, I am curious about when/why TLS objects are free'd especially by another (worker?) process instead of the routing process. Here we see TLS happening in PID 18722 8(18722) DEBUG: tls [tls_server.c:199]: tls_complete_init(): completing tls connection initialization Later we see 9(18723) DEBUG: tls [tls_server.c:684]: tls_h_tcpconn_close_f(): Closing SSL connection 0x7f4ef9732080 1. Is 9(PID 18723) a kind of "garbage collection" process that cleans up for the children? 2. How does 8 signal 9 that the connection is no longer used and should be cleaned up? Cheers Anthony

3 years, 3 months

git:master:d8643cd2: core: main - terminate using ksr_exit() instead of return

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: d8643cd2caf38aa1efaeff73783920fab1d9bf0d URL: https://github.com/kamailio/kamailio/commit/d8643cd2caf38aa1efaeff73783920f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-09T14:00:23+01:00 core: main - terminate using ksr_exit() instead of return --- Modified: src/main.c --- Diff: https://github.com/kamailio/kamailio/commit/d8643cd2caf38aa1efaeff73783920f… Patch: https://github.com/kamailio/kamailio/commit/d8643cd2caf38aa1efaeff73783920f… --- diff --git a/src/main.c b/src/main.c index ee0d712957..6f8b354d22 100644 --- a/src/main.c +++ b/src/main.c @@ -2903,7 +2903,7 @@ int main(int argc, char** argv) strerror(errno), errno); } /* else terminate process */ - return ret; + ksr_exit(ret); error: /*kill everything*/ @@ -2913,7 +2913,7 @@ int main(int argc, char** argv) fprintf(stderr, "error sending exit status: %s [%d]\n", strerror(errno), errno); } - return -1; + ksr_exit(-1); }

3 years, 3 months

git:master:346d99d1: core: cfg.lex - declare auto-generated yy_fatal_error() with unused attribute

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 346d99d1f98178a71d482e5724135f65257427dd URL: https://github.com/kamailio/kamailio/commit/346d99d1f98178a71d482e5724135f6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-09T13:27:34+01:00 core: cfg.lex - declare auto-generated yy_fatal_error() with unused attribute --- Modified: src/core/cfg.lex --- Diff: https://github.com/kamailio/kamailio/commit/346d99d1f98178a71d482e5724135f6… Patch: https://github.com/kamailio/kamailio/commit/346d99d1f98178a71d482e5724135f6… --- diff --git a/src/core/cfg.lex b/src/core/cfg.lex index 196ac408a8..591fb1e630 100644 --- a/src/core/cfg.lex +++ b/src/core/cfg.lex @@ -42,6 +42,7 @@ #include "daemonize.h" #include "ppcfg.h" + static void yynoreturn yy_fatal_error ( const char* msg ) __attribute__((unused)); static void yynoreturn ksr_yy_fatal_error(const char* msg); #define YY_FATAL_ERROR(msg) ksr_yy_fatal_error(msg);

3 years, 3 months

git:master:9f326234: core: cfg.lex - overwrite yy_fatal_error() to use ksr_exit() macro

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 9f326234f40f2c02f4833647112c3a4f4912aa17 URL: https://github.com/kamailio/kamailio/commit/9f326234f40f2c02f4833647112c3a4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-09T12:57:57+01:00 core: cfg.lex - overwrite yy_fatal_error() to use ksr_exit() macro --- Modified: src/core/cfg.lex --- Diff: https://github.com/kamailio/kamailio/commit/9f326234f40f2c02f4833647112c3a4… Patch: https://github.com/kamailio/kamailio/commit/9f326234f40f2c02f4833647112c3a4… --- diff --git a/src/core/cfg.lex b/src/core/cfg.lex index 90d6f685a7..196ac408a8 100644 --- a/src/core/cfg.lex +++ b/src/core/cfg.lex @@ -42,6 +42,9 @@ #include "daemonize.h" #include "ppcfg.h" + static void yynoreturn ksr_yy_fatal_error(const char* msg); + #define YY_FATAL_ERROR(msg) ksr_yy_fatal_error(msg); + /* states */ #define INITIAL_S 0 #define COMMENT_S 1 @@ -2164,3 +2167,8 @@ static void pp_endif() pp_update_state(); } +static void yynoreturn ksr_yy_fatal_error(const char* msg) +{ + fprintf( stderr, "%s\n", msg ); + ksr_exit( YY_EXIT_FAILURE ); +}

3 years, 3 months

git:master:4f6243e8: core: more use of ksr_exit() macro to follow --atexit param

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 4f6243e8e6e2012af35aae67da7b93af2127f02c URL: https://github.com/kamailio/kamailio/commit/4f6243e8e6e2012af35aae67da7b93a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-09T10:50:03+01:00 core: more use of ksr_exit() macro to follow --atexit param --- Modified: src/core/cfg.lex Modified: src/core/cfg.y Modified: src/core/sr_module.c Modified: src/core/tcp_read.c --- Diff: https://github.com/kamailio/kamailio/commit/4f6243e8e6e2012af35aae67da7b93a… Patch: https://github.com/kamailio/kamailio/commit/4f6243e8e6e2012af35aae67da7b93a… --- diff --git a/src/core/cfg.lex b/src/core/cfg.lex index 08037102cb..90d6f685a7 100644 --- a/src/core/cfg.lex +++ b/src/core/cfg.lex @@ -39,6 +39,7 @@ #include "select.h" #include "cfg.tab.h" #include "sr_compat.h" + #include "daemonize.h" #include "ppcfg.h" /* states */ @@ -1308,7 +1309,7 @@ IMPORTFILE "import_file" LM_CRIT( "error at %s line %d: '-' not allowed\n", (finame)?finame:"cfg", line); - exit(-1); + ksr_exit(-1); } <DEFINE_ID>{ID} { count(); ksr_cfg_print_part(yytext); @@ -1350,7 +1351,7 @@ IMPORTFILE "import_file" LM_CRIT( "error at %s line %d: '-' not allowed\n", (finame)?finame:"cfg", line); - exit(-1); + ksr_exit(-1); } <IFDEF_ID>{ID} { count(); pp_ifdef_var(yyleng, yytext); @@ -1404,7 +1405,7 @@ IMPORTFILE "import_file" if(sr_push_yy_state(s_buf.s, 0)<0) { LOG(L_CRIT, "error at %s line %d\n", (finame)?finame:"cfg", line); - exit(-1); + ksr_exit(-1); } memset(&s_buf, 0, sizeof(s_buf)); ksr_cfg_print_initial_state(); @@ -1418,7 +1419,7 @@ IMPORTFILE "import_file" if(sr_push_yy_state(s_buf.s, 1)<0) { LM_CRIT("error at %s line %d\n", (finame)?finame:"cfg", line); - exit(-1); + ksr_exit(-1); } memset(&s_buf, 0, sizeof(s_buf)); ksr_cfg_print_initial_state(); @@ -1439,7 +1440,7 @@ IMPORTFILE "import_file" ksr_cfg_print_part(yytext); if(pp_define_env(yytext, yyleng) < 0) { LM_CRIT("error at %s line %d\n", (finame)?finame:"cfg", line); - exit(-1); + ksr_exit(-1); } state = INITIAL; ksr_cfg_print_initial_state(); @@ -1610,7 +1611,7 @@ static char* addstr(struct str_buf* dst_b, char* src, int len) return dst_b->s; error: PKG_MEM_CRITICAL; - exit(-1); + ksr_exit(-1); } diff --git a/src/core/cfg.y b/src/core/cfg.y index 7d59805555..0d991ee98b 100644 --- a/src/core/cfg.y +++ b/src/core/cfg.y @@ -69,6 +69,7 @@ #include "ppcfg.h" #include "pvapi.h" #include "config.h" +#include "daemonize.h" #include "cfg_core.h" #include "cfg/cfg.h" #ifdef CORE_TLS @@ -3521,7 +3522,7 @@ cmd: if (mod_func_action != NULL) { LM_ERR("function used inside params of another function: %s\n", $1); yyerror("use of function execution inside params not allowed\n"); - exit(-1); + ksr_exit(-1); } mod_func_action = mk_action(MODULE0_T, 2, MODEXP_ST, NULL, NUMBER_ST, 0); } LPAREN func_params RPAREN { diff --git a/src/core/sr_module.c b/src/core/sr_module.c index 58624ea06e..3af6b310dd 100644 --- a/src/core/sr_module.c +++ b/src/core/sr_module.c @@ -45,6 +45,7 @@ #include "fmsg.h" #include "async_task.h" #include "shm_init.h" +#include "daemonize.h" #include <sys/stat.h> #include <regex.h> @@ -541,7 +542,7 @@ int load_module(char* mod_path) } /* version control */ if (!version_control(handle, path)) { - exit(-1); + ksr_exit(-1); } /* launch register */ mr = (mod_register_function)dlsym(handle, "mod_register"); diff --git a/src/core/tcp_read.c b/src/core/tcp_read.c index 50853cc5b6..48a683d32f 100644 --- a/src/core/tcp_read.c +++ b/src/core/tcp_read.c @@ -52,6 +52,7 @@ #include "ut.h" #include "trim.h" #include "pt.h" +#include "daemonize.h" #include "cfg/cfg_struct.h" #ifdef CORE_TLS #include "tls/tls_server.h" @@ -2009,7 +2010,7 @@ void tcp_receive_loop(int unix_sock) error: destroy_io_wait(&io_w); LM_CRIT("exiting..."); - exit(-1); + ksr_exit(-1); }

3 years, 3 months

git:5.4:a7170a4f: modules: readme files regenerated - modules ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: 5.4 Commit: a7170a4fa6f4b0498fb192291842eb497f6f9507 URL: https://github.com/kamailio/kamailio/commit/a7170a4fa6f4b0498fb192291842eb4… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2021-02-09T10:16:59+01:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/http_client/README Modified: src/modules/secsipid/README Modified: src/modules/siptrace/README Modified: src/modules/tm/README --- Diff: https://github.com/kamailio/kamailio/commit/a7170a4fa6f4b0498fb192291842eb4… Patch: https://github.com/kamailio/kamailio/commit/a7170a4fa6f4b0498fb192291842eb4…

3 years, 3 months

git: new commits in branch 5.4

by Daniel-Constantin Mierla

- URL: https://github.com/kamailio/kamailio/commit/9a793eeeb6c39b11b9125ca8455c2d5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-09T09:03:08+01:00 xhttp: clang format code (cherry picked from commit d620aab9d2bc16e7785d5be0ddecd016329055de) - URL: https://github.com/kamailio/kamailio/commit/82ca29e2c51667bbfb8962006c8b4a9… Author: balajeesv <balajee.sv(a)gmail.com> Date: 2021-02-09T09:03:53+01:00 evapi: export async_multicast() to kemi (cherry picked from commit ccaba976cd1c599ba64067df0896fdd4888af00f) - URL: https://github.com/kamailio/kamailio/commit/d992a7cf2d42e9c4efcb2153091f441… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-09T09:04:53+01:00 http_client: docs - section title to get proper entry in toc - bits of whitespacing fixing (cherry picked from commit fadc0fc499fb57a763aa71a76b24cff152bbd927) - URL: https://github.com/kamailio/kamailio/commit/ff5283b156f6aa934bd5f621537427d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-09T09:05:10+01:00 core: kemi - KSR.is_method_in() uses E/e to match PRACK (cherry picked from commit b04111b583b454b12ea0c6a265a14858c195b213) - URL: https://github.com/kamailio/kamailio/commit/0b98ddb1ea04603851ce581a6911158… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-09T09:05:56+01:00 core: info message made dbg when adding a subst expression (cherry picked from commit 80b3d5d036da493316a93594c770df1ef8218e5e) - URL: https://github.com/kamailio/kamailio/commit/d0af9aa7f46c90461288ef5241dba9c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-09T09:06:16+01:00 secsipid: docs - details of the acronyms (cherry picked from commit c1e06e029b192a4db45841fa78e9bcfee91f125d) - URL: https://github.com/kamailio/kamailio/commit/f64d41efc8bf08daa8f4a36cb81d462… Author: Dennis <dennis_y(a)mail.ru> Date: 2021-02-09T09:06:59+01:00 rtpengine: fixing wrong parsing the pair of IPv6 addr:port (#2592) - fixing wrong parsing the pair of IPv6 addr:port in rtpengine module, when loading node information from database. (cherry picked from commit 13d786e33d6f04a718af40ba345cf0827f752c2f) - URL: https://github.com/kamailio/kamailio/commit/252b0dd2d778c15ac6e96c7c4152966… Author: Paul Komkoff <i(a)stingr.net> Date: 2021-02-09T09:07:55+01:00 core: work around interface enum buffer overrun When a system has too many interfaces and too many addresses, 8 kilobytes isn't enough to fit all of the netlink responses. As the result, kamailio gets stuck in a loop where it tries to do a 0-length recv. Increase the buffer to 32K. It's a miniscule amount for modern times anyway. Also, add diagnostics to make further troubleshooting easier. Proper fix would be to switch to libnl here, which would make a good weekend project. (cherry picked from commit d2fd204b0ae35512a04702e480bb0d16878e98be) - URL: https://github.com/kamailio/kamailio/commit/23000a3ab3d88419d4f0ac797aae201… Author: Paul Komkoff <i(a)stingr.net> Date: 2021-02-09T09:08:12+01:00 core: fix unused argument in socket_info.c:get_flags get_flags has an argument - family - which is supposed to be used in netlink message, otherwise why would we need it? (cherry picked from commit 42f7702430c312b2c9caea8f617af4e3719ef12f) - URL: https://github.com/kamailio/kamailio/commit/df7ca5dce4c41ad6f05064fe2940943… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-09T09:09:10+01:00 app_jsdt: duktape interpreter upgraded to v2.6.0 (cherry picked from commit 2590165e278efb947edb9cb5a75104f2f760c4c2) - URL: https://github.com/kamailio/kamailio/commit/e085bdb9a35f7a5b4624b7afdef96ca… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-09T09:09:26+01:00 misc/examples/kemi: use kx functions instead of pv (cherry picked from commit 6e541feb9184e193f9c486c8f97d73360c69250d) - URL: https://github.com/kamailio/kamailio/commit/784ad65fe5abde677f5155e3d7ff0bf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-09T09:09:39+01:00 misc/examples/kemi: use local variable instead of many function calls for js (cherry picked from commit b4f439301c2dffbfc6a389354e840142fc3b965b) - URL: https://github.com/kamailio/kamailio/commit/9b5eade1faa8deeb3fcc8f9cb010f80… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-09T09:10:24+01:00 kamctl: option for rpc command to replace tokens in parameters - supported now: replace '=CRLF=' with '\r\n' - fix 'kamctl ping' command by replacing '=CRLF=' with '\r\n' in multi-headers parameter (cherry picked from commit 1c66f6a1a5d04c33f1912609a36729b06b6eebd7) - URL: https://github.com/kamailio/kamailio/commit/6769d44cfab686824a6b077bc8cbb4a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-09T09:10:43+01:00 kamctl: use tm.t_uac_wait for ping command (cherry picked from commit 20d075a17189961baf63ac000e4417d7f04d8a08) - URL: https://github.com/kamailio/kamailio/commit/c3f12eb469995a03166bf801bc4a391… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-09T09:11:04+01:00 core: utils - functions to shm-duplicate str in a block (cherry picked from commit 6684b57641396ba494716e7f63a0f15afc1d8637) - URL: https://github.com/kamailio/kamailio/commit/ff34dc44bba76c6ee2828a03655e030… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-09T09:11:15+01:00 tm: implemented t_uac_wait_block rpc command - it blocks while waiting for the reply to return the code and reason text (cherry picked from commit dc5a548a9e6327674615aa7ddc8708e0ba5252aa) - URL: https://github.com/kamailio/kamailio/commit/254790bdb27e081765958a8b0999212… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-09T09:11:25+01:00 tm: docs for rpc t_uac_wait_block (cherry picked from commit 89eea7edb8832124dc325d8303b23ea5f36c88f4) - URL: https://github.com/kamailio/kamailio/commit/4b606ec029703420a74f4246a7bcdb0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-09T09:11:35+01:00 kamctl: use tm.t_uac_wait_block rpc for ping command (cherry picked from commit 47a98532af5512a4597bbf9ad3834c62dd633256) - URL: https://github.com/kamailio/kamailio/commit/b8a7d2bfd1118d556c9e46dcab97fbc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-09T09:11:46+01:00 kamctl: use param evaluation mode for cisco restart command (cherry picked from commit 359050f9be40002aec1d3894dc43a2a8762ce8cc) - URL: https://github.com/kamailio/kamailio/commit/b6ab0ba329f11e7baabe194994c095b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-09T09:11:57+01:00 kamctl: removed condition on CTLENGINETYPE - done again inside ctl_cmd_run (cherry picked from commit 4a4f0475716cbf824b2ab9684457e21f6732aa74) - URL: https://github.com/kamailio/kamailio/commit/b0e29edea36778be91acfe1907a94a5… Author: Nicolas C <nchaigne(a)capgemini.fr> Date: 2021-02-09T09:12:10+01:00 core: fix to xavp_rm_internal (#2604) This fixes the following issue: https://github.com/kamailio/kamailio/issues/2604 Description of the issue: When called to remove a specific index from a given xavp, function xavp_rm_by_index removes the index (as expected) but also all others before it. E.g : If called with idx = 1, it removes indexes 0 and 1. Likewise if invoked with idx = 2 => the first 3 elements are removed. This bug is located in function xavp_rm_internal. An assignment was missing when looping over the xavp list. Same for xavi_rm_internal. (cherry picked from commit 12414972ad0c28ac50ece3c14f98134c3f06c522) - URL: https://github.com/kamailio/kamailio/commit/31f8466f1d493db8baaa215d34d4ed4… Author: Theo <theodor.scherney(a)kapsch.net> Date: 2021-02-09T09:12:48+01:00 tm: 200 OK not processed correctly by Proxy after final non-2xx Description: Problem: Forwarding of 200 OK while sent 488 waits for ACK, destroys the UAS send buffer Scenario: During suspension of 200 OK by ims_qos module function Rx_AAR() at terminating PCSCF, The PCRF sends an AA Answer with result code DIAMETER_TOO_BUSY (3004), which triggers the PCSCF to send a 488 âSorry no QoS availableâ to the originating side (ims_dialog module function dlg_terminate()). Afterwards neither the 200 OK nor the ACK(488) is processed correctly by the PCSCF. Solution: The UAS send buffer should not be overwritten during processing of 200 OK, because non-2xx is needed to associate the ACK message in a correct way. 200 OK must be forwarded statelessly. Side-Effect (potentially breaks existing function): Some callbacks cannot be called for the 200 OK, to avoid messing the stored 488. (cherry picked from commit 18410da04c7f7bbc9628820427fedb92cf893526) - URL: https://github.com/kamailio/kamailio/commit/be9081621e71965f90be490cdaa01f3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-09T09:12:57+01:00 tm: new parameter reply_relay_mode - control the behaviour introduced by 18410da0 - if set to 0, the behaviour is like before the commit referenced above, tm is attemptime to send suspended 200ok after another final response that was forwarded while 200ok was suspended - default is 1 (behave as the patch changed the forwarding policy, not to overwrite the response buffer) (cherry picked from commit 90dfc421dab438a8ef62cc8f68b2c1f7fb50b0dc) - URL: https://github.com/kamailio/kamailio/commit/0ff67c573f3bb59dc7872a48310c28d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-09T09:13:26+01:00 tm: docs for reply_relay_mode parameter (cherry picked from commit 00b1aba770c26f75c31cf2a28e7ca425f18788dc) - URL: https://github.com/kamailio/kamailio/commit/33da663ec8d730fa570018bbdb7239e… Author: Marat Gareev <maratkin94(a)gmail.com> Date: 2021-02-09T09:15:20+01:00 dispatcher: Log dest sets after variable update (cherry picked from commit f4b8bede6a247415eda84a7db9569747905f9fa0) - URL: https://github.com/kamailio/kamailio/commit/0ab7142d8f60d04c386674263f35f87… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-09T09:15:41+01:00 core: ut.h - add inline to static function to avoid warning from including files - for shm_str_dup_block() (cherry picked from commit 34301ea16812eccbb914ea14cafb0140ac9bba61) - URL: https://github.com/kamailio/kamailio/commit/989baffd9cbb934c8d0fd42dc9ef08d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-09T09:15:54+01:00 tm: prper timer cleanup of responses for rpc tm.t_uac_wait_block (cherry picked from commit 5a6a679985fecfc168b9b26f0be3c0e64e641e64) - URL: https://github.com/kamailio/kamailio/commit/a2e0e4912b5a81a88cccd2fb58652be… Author: Henning Westerholt <hw(a)skalatan.de> Date: 2021-02-09T09:16:56+01:00 xhttp: do not call memset on a null-pointer, related to GH #2619 (cherry picked from commit 2db8884945844e5040dfed2b24fe84de097c0b2b) - URL: https://github.com/kamailio/kamailio/commit/3027f8b9daed5ca4f36d0779cd6f79e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-09T09:17:22+01:00 kamctl: added srv debug subcommand - control server debug level via rpc (cherry picked from commit 6b5aa70f09e294338a65a0bf2fcae8b92fdc6fae) - URL: https://github.com/kamailio/kamailio/commit/ee7838842a175ffb4898dade606377c… Author: dvillaume <david.villaume(a)gmail.com> Date: 2021-02-09T09:17:34+01:00 rtpengine : add node fallback if node out of port When rtpengine answers with error-reason 'Ran out of ports' adopt the same behavor that when node answers 'Parallel session limit reached' (cherry picked from commit 853068a26c34deff86e17b63f49abea2c8f4403c) - URL: https://github.com/kamailio/kamailio/commit/73826e75b6699f3bd1bfb27eabf9582… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-09T09:18:13+01:00 siptrace: docs - fixed small typo (cherry picked from commit 7d846f928b75a3bc1b8e8c1a70e39bfede939c15) - URL: https://github.com/kamailio/kamailio/commit/95e7399481e61ec54bb226c122c5617… Author: Wolfgang Kampichler <dev(a)kampichler.info> Date: 2021-02-09T09:18:46+01:00 http_client: http_client_request to include default clientcert, clientkey,... - the lost module uses http_client API functions and in the course of NG112 client certificates are used for authentication when querying LIS or ECRF, the fix allows these to be read out via http_client module parameters. (cherry picked from commit 7d5868ab1242eb8166e6af1bb8a21b39001df663)

3 years, 3 months

git:master:d11a1250: core: added selval(evalexpr, valexp1, valexpr2)

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: d11a12502299bf7e6f85505c4b48a4486a647e31 URL: https://github.com/kamailio/kamailio/commit/d11a12502299bf7e6f85505c4b48a44… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-08T11:23:46+01:00 core: added selval(evalexpr, valexp1, valexpr2) - this is a core statement that return the 2nd parameter if the 1st parameter is evaluated to true, or 3rd parameter if the 1st parameter is evaluated to false - it can be considered a core function that is equivalent of ternary condition/operator - example: $var(x) = selval($Ts mod 2, "true/" + $ru, "false/" + $rd); - the first parameter is a conditional expression, like those used for IF, the 2nd and 3rd parameters can be expressions like those used in the right side of assignments --- Modified: src/core/cfg.lex Modified: src/core/cfg.y Modified: src/core/rvalue.c Modified: src/core/rvalue.h --- Diff: https://github.com/kamailio/kamailio/commit/d11a12502299bf7e6f85505c4b48a44… Patch: https://github.com/kamailio/kamailio/commit/d11a12502299bf7e6f85505c4b48a44…

3 years, 3 months

[kamailio/kamailio] authentificated INVITE badly managed when topos is activated (#2629)

by fgaisnon

### Description If topos is activated and kamailio responds a 407 "proxy authentication required" to a initial INVITE, INVITE received after with credentials (MD5 response in Proxy-Authorization header) is badly managed. Credentials are never validated and kamailio responds 407 again. If topoh is used instead topos all works fine and credential are validated. ### Troubleshooting #### Reproduction Always. #### SIP Traffic ### Possible Solutions I have tested with official kamailio 5.4.3-0. * **Operating System**: centos 7 (3.10.0-693.11.1.el7.x86_64) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2629

3 years, 3 months

git:5.4:218350f0: siputils: free params for contact param decode and remove

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.4 Commit: 218350f089be9c3b5505079079df63d25dd74cc4 URL: https://github.com/kamailio/kamailio/commit/218350f089be9c3b5505079079df63d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-08T12:04:38+01:00 siputils: free params for contact param decode and remove (cherry picked from commit d6504e28f7fef8d48480861ea12e9bd457288661) --- Modified: src/modules/siputils/contact_ops.c --- Diff: https://github.com/kamailio/kamailio/commit/218350f089be9c3b5505079079df63d… Patch: https://github.com/kamailio/kamailio/commit/218350f089be9c3b5505079079df63d… --- diff --git a/src/modules/siputils/contact_ops.c b/src/modules/siputils/contact_ops.c index a299db32e5..f21d7705b3 100644 --- a/src/modules/siputils/contact_ops.c +++ b/src/modules/siputils/contact_ops.c @@ -773,6 +773,7 @@ int ki_contact_param_decode(sip_msg_t *msg, str *nparam) } if(pit==NULL || pit->body.len<=0) { free_params(params); + params = NULL; continue; } @@ -816,6 +817,8 @@ int ki_contact_param_decode(sip_msg_t *msg, str *nparam) pkg_free(nval.s); return -2; } + free_params(params); + params = NULL; } return 1; @@ -974,6 +977,7 @@ int ki_contact_param_rm(sip_msg_t *msg, str *nparam) } if(pit==NULL) { free_params(params); + params = NULL; continue; } rms.s = pit->name.s; @@ -984,6 +988,7 @@ int ki_contact_param_rm(sip_msg_t *msg, str *nparam) LM_ERR("failed to find start of the parameter delimiter [%.*s]\n", c->uri.len, c->uri.s); free_params(params); + params = NULL; continue; } if(pit->body.len>0) { @@ -1004,6 +1009,7 @@ int ki_contact_param_rm(sip_msg_t *msg, str *nparam) continue; } free_params(params); + params = NULL; } return 1;

3 years, 3 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2021