sr-dev August 2020

sr-dev@lists.kamailio.org

17 participants
244 discussions

git:5.4:3a44d393: pua: convert to PKG/SHM memory logging helper functions

by Victor Seva

Module: kamailio Branch: 5.4 Commit: 3a44d393dc24d1f7caafedef90c0714c8ed74ff2 URL: https://github.com/kamailio/kamailio/commit/3a44d393dc24d1f7caafedef90c0714… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2020-08-01T10:42:29+02:00 pua: convert to PKG/SHM memory logging helper functions * remove trailing spaces (cherry picked from commit c91e852d203017b571ae15e48c289f73f4824136) --- Modified: src/modules/pua/add_events.c Modified: src/modules/pua/event_list.c Modified: src/modules/pua/hash.c Modified: src/modules/pua/pua.c Modified: src/modules/pua/pua_callback.c Modified: src/modules/pua/pua_db.c Modified: src/modules/pua/send_publish.c Modified: src/modules/pua/send_subscribe.c --- Diff: https://github.com/kamailio/kamailio/commit/3a44d393dc24d1f7caafedef90c0714… Patch: https://github.com/kamailio/kamailio/commit/3a44d393dc24d1f7caafedef90c0714…

3 years, 9 months

git:5.4:7a440bda: pua_dialoginfo: convert to PKG/SHM memory logging helper functions

by Victor Seva

Module: kamailio Branch: 5.4 Commit: 7a440bdaf8f174f5a97228fab32754daf5cad348 URL: https://github.com/kamailio/kamailio/commit/7a440bdaf8f174f5a97228fab32754d… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2020-08-01T10:42:16+02:00 pua_dialoginfo: convert to PKG/SHM memory logging helper functions (cherry picked from commit 7e5cc3aa21a243ef19ec092fec10043b1178cae7) --- Modified: src/modules/pua_dialoginfo/dialog_publish.c Modified: src/modules/pua_dialoginfo/pua_dialoginfo.c --- Diff: https://github.com/kamailio/kamailio/commit/7a440bdaf8f174f5a97228fab32754d… Patch: https://github.com/kamailio/kamailio/commit/7a440bdaf8f174f5a97228fab32754d… --- diff --git a/src/modules/pua_dialoginfo/dialog_publish.c b/src/modules/pua_dialoginfo/dialog_publish.c index 1abe8cb152..5c901a9845 100644 --- a/src/modules/pua_dialoginfo/dialog_publish.c +++ b/src/modules/pua_dialoginfo/dialog_publish.c @@ -240,7 +240,7 @@ str* build_dialoginfo(char *state, str *entity, str *peer, str *callid, body = (str*)pkg_malloc(sizeof(str)); if(body == NULL) { - LM_ERR("while allocating memory\n"); + PKG_MEM_ERROR; goto error; } memset(body, 0, sizeof(str)); @@ -327,7 +327,7 @@ void dialog_publish(char *state, str* ruri, str *entity, str *peer, str *callid, publ= (publ_info_t*)pkg_malloc(size); if(publ== NULL) { - LM_ERR("no more share memory\n"); + PKG_MEM_ERROR; goto error; } memset(publ, 0, size); diff --git a/src/modules/pua_dialoginfo/pua_dialoginfo.c b/src/modules/pua_dialoginfo/pua_dialoginfo.c index f3932493aa..eb37c61156 100644 --- a/src/modules/pua_dialoginfo/pua_dialoginfo.c +++ b/src/modules/pua_dialoginfo/pua_dialoginfo.c @@ -448,7 +448,7 @@ struct str_list* get_str_list(unsigned short avp_flags, int_str avp_name) { } if (list_current==0) { - LM_ERR("no more shm mem (%d)\n",len); + SHM_MEM_ERROR; return 0; } @@ -483,7 +483,7 @@ struct dlginfo_cell* get_dialog_data(struct dlg_cell *dlg, int type) dlginfo = (struct dlginfo_cell*)shm_malloc( len ); if (dlginfo==0) { - LM_ERR("no more shm mem (%d)\n",len); + SHM_MEM_ERROR; return NULL; } memset( dlginfo, 0, len); @@ -531,7 +531,7 @@ struct dlginfo_cell* get_dialog_data(struct dlg_cell *dlg, int type) dlginfo->pubruris_caller = (struct str_list*)shm_malloc( sizeof(struct str_list) ); if (dlginfo->pubruris_caller==0) { - LM_ERR("no more shm mem (%d)\n", (int) sizeof(struct str_list)); + SHM_MEM_ERROR; free_dlginfo_cell(dlginfo); return NULL; } @@ -546,7 +546,7 @@ struct dlginfo_cell* get_dialog_data(struct dlg_cell *dlg, int type) dlginfo->pubruris_callee = (struct str_list*)shm_malloc( sizeof(struct str_list) ); if (dlginfo->pubruris_callee==0) { - LM_ERR("no more shm mem (%d)\n", (int) sizeof(struct str_list)); + SHM_MEM_ERROR; free_dlginfo_cell(dlginfo); return NULL; } @@ -567,7 +567,7 @@ struct dlginfo_cell* get_dialog_data(struct dlg_cell *dlg, int type) dlginfo->pubruris_caller = (struct str_list*)shm_malloc( sizeof(struct str_list) ); if (dlginfo->pubruris_caller==0) { - LM_ERR("no more shm mem (%d)\n", (int) sizeof(struct str_list)); + SHM_MEM_ERROR; free_dlginfo_cell(dlginfo); return NULL; } @@ -577,7 +577,7 @@ struct dlginfo_cell* get_dialog_data(struct dlg_cell *dlg, int type) dlginfo->pubruris_callee = (struct str_list*)shm_malloc( sizeof(struct str_list) ); if (dlginfo->pubruris_callee==0) { - LM_ERR("no more shm mem (%d)\n", (int) sizeof(struct str_list)); + SHM_MEM_ERROR; free_dlginfo_cell(dlginfo); return NULL; }

3 years, 9 months

[kamailio/kamailio] pua: update_version_puadb() use pres_id to select record (#2420)

by Victor Seva

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #2414 #### Description * only relevant when db_mode is PUA_DB_ONLY * call_id/to_tag/from_tag values can be "", for instance with DIALOG_PUBLISH.* records. Then **ALL** records get version field update * update_vesion_puadb() is called from send_publish() and pres->id value is valid after a call to get_record_puadb() You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2420 -- Commit Summary -- * pua: update_version_puadb() use pres_id to select record -- File Changes -- M src/modules/pua/pua_db.c (20) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2420.patch https://github.com/kamailio/kamailio/pull/2420.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2420

3 years, 9 months

git:master:e4aed5c2: pua: update_version_puadb() use pres_id to select record

by Victor Seva

Module: kamailio Branch: master Commit: e4aed5c272c8144dd1ddf58163c3ba501bb46a5b URL: https://github.com/kamailio/kamailio/commit/e4aed5c272c8144dd1ddf58163c3ba5… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2020-08-01T10:34:35+02:00 pua: update_version_puadb() use pres_id to select record * only relevant when db_mode is PUA_DB_ONLY * call_id/to_tag/from_tag values can be "", for instance with DIALOG_PUBLISH.* records. Then **ALL** records get version field update * update_vesion_puadb() is called from send_publish() and pres->id value is valid after a call to get_record_puadb() related to #2414 --- Modified: src/modules/pua/pua_db.c --- Diff: https://github.com/kamailio/kamailio/commit/e4aed5c272c8144dd1ddf58163c3ba5… Patch: https://github.com/kamailio/kamailio/commit/e4aed5c272c8144dd1ddf58163c3ba5… --- diff --git a/src/modules/pua/pua_db.c b/src/modules/pua/pua_db.c index 9a5c34b8ec..9f9b36cab4 100644 --- a/src/modules/pua/pua_db.c +++ b/src/modules/pua/pua_db.c @@ -1485,8 +1485,8 @@ int update_contact_puadb(ua_pres_t *pres, str *contact) int update_version_puadb(ua_pres_t *pres) { - db_key_t q_cols[3], db_cols[1]; - db_val_t q_vals[3], db_vals[1]; + db_key_t q_cols[1], db_cols[1]; + db_val_t q_vals[1], db_vals[1]; int n_query_cols= 0, n_update_cols=0; if (pres==NULL) @@ -1496,22 +1496,10 @@ int update_version_puadb(ua_pres_t *pres) } /* cols and values used for search query */ - q_cols[n_query_cols] = &str_call_id_col; - q_vals[n_query_cols].type = DB1_STR; - q_vals[n_query_cols].nul = 0; - q_vals[n_query_cols].val.str_val = pres->call_id; - n_query_cols++; - - q_cols[n_query_cols] = &str_to_tag_col; - q_vals[n_query_cols].type = DB1_STR; - q_vals[n_query_cols].nul = 0; - q_vals[n_query_cols].val.str_val = pres->to_tag; - n_query_cols++; - - q_cols[n_query_cols] = &str_from_tag_col; + q_cols[n_query_cols] = &str_pres_id_col; q_vals[n_query_cols].type = DB1_STR; q_vals[n_query_cols].nul = 0; - q_vals[n_query_cols].val.str_val = pres->from_tag; + q_vals[n_query_cols].val.str_val = pres->id; n_query_cols++; /* we overwrite contact even if not changed */

3 years, 9 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev August 2020