sr-dev July 2020

sr-dev@lists.kamailio.org

26 participants
389 discussions

Re: [sr-dev] [kamailio/kamailio] db_redis: allow deletion of all rows (bf2ecd4)

by Richard Fuchs

Hello @rdboisvert and @henningw We bumped into this commit on our deployments because it was causing some issues. In particular it makes the Redis SETs that we use a pseudo-indexes being left over in the Redis DB after a delete operation. The reason is that even for deletes that can be done directly (no/empty "manual keys") the contents of the entry still need to be fetched because the contents are part of the key names used for pseudo-index SETs. The patch we came up with is exactly the reversal of this commit, so obviously I need to ask about the intentions behind it, since I'm sure you had a good reason to do it :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/bf2ecd4dec55d5009e0904392d083e1…

3 years, 10 months

Re: [sr-dev] [kamailio/kamailio] Kamailio 5.1.10 crash in EVP_DecryptUpdate() (#2394)

by Henning Westerholt

Closed #2394. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2394#event-3520292045

3 years, 10 months

Re: [sr-dev] [kamailio/kamailio] Kamailio 5.1.10 crash in EVP_DecryptUpdate() (#2394)

by Henning Westerholt

Confirmed, close this one. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2394#issuecomment-654838357

3 years, 10 months

Re: [sr-dev] [kamailio/kamailio] Kamailio 5.1.10 crash in EVP_DecryptUpdate() (#2394)

by Sebastian Damm

``` root@sip-tcploadbalancer02.live.sipgate.net:/usr/lib/x86_64-linux-gnu/kamailio# ldd modules/tls.so linux-vdso.so.1 (0x00007ffef73a7000) libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f7cc66c6000) libssl.so.1.1 => /usr/lib/x86_64-linux-gnu/libssl.so.1.1 (0x00007f7cc6634000) libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f7cc6613000) libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f7cc6452000) /lib64/ld-linux-x86-64.so.2 (0x00007f7cc6760000) libcrypto.so.1.1 => /usr/lib/x86_64-linux-gnu/libcrypto.so.1.1 (0x00007f7cc6169000) ``` Okay, then this might be the first step to upgrading our Kamailio loadbalancers. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2394#issuecomment-654829933

3 years, 10 months

Re: [sr-dev] [kamailio/kamailio] Kamailio 5.1.10 crash in EVP_DecryptUpdate() (#2394)

by Daniel-Constantin Mierla

To have it clear: Kamailio version less than 5.2.7 (or a few minor release before) is incompatible with libssl 1.1. I am waiting to confirm tls.so is linked against libssl 1.1 before closing this one -- you can do `ldd tls.so` to see it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2394#issuecomment-654824430

3 years, 10 months

Re: [sr-dev] [kamailio/kamailio] Kamailio 5.1.10 crash in EVP_DecryptUpdate() (#2394)

by Daniel-Constantin Mierla

Reopened #2394. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2394#event-3520186587

3 years, 10 months

Re: [sr-dev] [kamailio/kamailio] Kamailio 5.1.10 crash in EVP_DecryptUpdate() (#2394)

by Daniel-Constantin Mierla

Closed #2394. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2394#event-3520185874

3 years, 10 months

Re: [sr-dev] [kamailio/kamailio] Kamailio 5.1.10 crash in EVP_DecryptUpdate() (#2394)

by Daniel-Constantin Mierla

If tls module is compiled against libssl 1.1, the options are: * downgrade OS back to a version shipping libssl 1.0 * install somehow libssl 1.0 and compile kamailio against it * upgrade kamailio to use at least latest kamailio 5.2.x The libssl did major internal changes in libssl 1.1, older kamailio versions were released earlier than libssl 1.1 became shipped by stable linux distros, so they do not support libssl 1.1 properly. Kamailio 5.1 is out of maintenance, but you can try to backport from 5.2, however there were a lot of changes related to support of libssl 1.1 that I do not think it worth doing it compared with just upgrading kamailio config for a newer version. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2394#issuecomment-654822869

3 years, 10 months

git:master:65159728: carrierroute: do not test return for strcpy() and strcat()

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 65159728a4425f45559de55fd5549731e717d74e URL: https://github.com/kamailio/kamailio/commit/65159728a4425f45559de55fd554973… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-07-06T09:03:32+02:00 carrierroute: do not test return for strcpy() and strcat() - they return the dst or src parameter, resulting in code analyzer reporting --- Modified: src/modules/carrierroute/cr_config.c --- Diff: https://github.com/kamailio/kamailio/commit/65159728a4425f45559de55fd554973… Patch: https://github.com/kamailio/kamailio/commit/65159728a4425f45559de55fd554973… --- diff --git a/src/modules/carrierroute/cr_config.c b/src/modules/carrierroute/cr_config.c index 920ae4142c..e65ad0789e 100644 --- a/src/modules/carrierroute/cr_config.c +++ b/src/modules/carrierroute/cr_config.c @@ -121,14 +121,8 @@ static int backup_config(void) { PKG_MEM_ERROR; return -1; } - if(!strcpy(backup_file, config_file)){ - LM_ERR("can't copy filename\n"); - goto errout; - } - if(!strcat(backup_file, ".bak")){ - LM_ERR("can't attach suffix\n"); - goto errout; - } + strcpy(backup_file, config_file); + strcat(backup_file, ".bak"); /* open source file */ if ((from = fopen(config_file, "rb"))==NULL) { LM_ERR("Cannot open source file.\n");

3 years, 10 months

git:master:0cc1e167: db_redis: use safer localtime_r() function

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 0cc1e167b9e54bb4a652162445efe89b02939eed URL: https://github.com/kamailio/kamailio/commit/0cc1e167b9e54bb4a652162445efe89… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-07-06T08:50:00+02:00 db_redis: use safer localtime_r() function --- Modified: src/modules/db_redis/redis_dbase.c --- Diff: https://github.com/kamailio/kamailio/commit/0cc1e167b9e54bb4a652162445efe89… Patch: https://github.com/kamailio/kamailio/commit/0cc1e167b9e54bb4a652162445efe89… --- diff --git a/src/modules/db_redis/redis_dbase.c b/src/modules/db_redis/redis_dbase.c index ea1a6aa43e..9c81385a39 100644 --- a/src/modules/db_redis/redis_dbase.c +++ b/src/modules/db_redis/redis_dbase.c @@ -1152,6 +1152,7 @@ static int db_redis_compare_column(db_key_t k, db_val_t *v, db_op_t op, redisRep double d_value; str *tmpstr; char tmp[32] = ""; + struct tm _time; int vtype = VAL_TYPE(v); @@ -1283,7 +1284,8 @@ static int db_redis_compare_column(db_key_t k, db_val_t *v, db_op_t op, redisRep return -1; case DB1_DATETIME: // TODO: insert int value to db for faster comparison! - strftime(tmp, sizeof(tmp), "%Y-%m-%d %H:%M:%S", localtime(&(VAL_TIME(v)))); + localtime_r(&(VAL_TIME(v)), &_time); + strftime(tmp, sizeof(tmp), "%Y-%m-%d %H:%M:%S", &_time); LM_DBG("comparing DATETIME %s %s %s\n", reply->str, op, tmp); if (!strcmp(op, OP_EQ)) { return (strcmp(reply->str, tmp) == 0) ? 0 : -1;

3 years, 10 months

← Newer
1
...
29
30
31
32
33
34
35
...
39
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2020