sr-dev June 2020

sr-dev@lists.kamailio.org

24 participants
395 discussions

git:5.3:5284b907: ims_charging: fix missing line-breaks for log messages

by Henning Westerholt

Module: kamailio Branch: 5.3 Commit: 5284b907357aa0dab0aa8eb655eeac81a7af60e9 URL: https://github.com/kamailio/kamailio/commit/5284b907357aa0dab0aa8eb655eeac8… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-06-10T11:52:04Z ims_charging: fix missing line-breaks for log messages (cherry picked from commit 508786fcdbbc120215b3e7dd90d92ab40c3b1e4e) --- Modified: src/modules/ims_charging/ccr.c Modified: src/modules/ims_charging/dialog.c Modified: src/modules/ims_charging/diameter_ro.c Modified: src/modules/ims_charging/ims_charging_mod.c Modified: src/modules/ims_charging/ims_ro.c Modified: src/modules/ims_charging/ro_db_handler.c Modified: src/modules/ims_charging/ro_session_hash.c Modified: src/modules/ims_charging/ro_session_hash.h Modified: src/modules/ims_charging/ro_timer.c --- Diff: https://github.com/kamailio/kamailio/commit/5284b907357aa0dab0aa8eb655eeac8… Patch: https://github.com/kamailio/kamailio/commit/5284b907357aa0dab0aa8eb655eeac8…

3 years, 10 months

git:5.3:ccf7347e: cdp: add missing line-breaks for log messages

by Henning Westerholt

Module: kamailio Branch: 5.3 Commit: ccf7347e9f756b36e5baa65d93dab520098d3993 URL: https://github.com/kamailio/kamailio/commit/ccf7347e9f756b36e5baa65d93dab52… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-06-10T11:52:04Z cdp: add missing line-breaks for log messages (cherry picked from commit 32a0d8073eb1b7f01190d305d318b43268811be8) --- Modified: src/modules/cdp/acctstatemachine.c Modified: src/modules/cdp/peerstatemachine.c Modified: src/modules/cdp/receiver.c Modified: src/modules/cdp/worker.c --- Diff: https://github.com/kamailio/kamailio/commit/ccf7347e9f756b36e5baa65d93dab52… Patch: https://github.com/kamailio/kamailio/commit/ccf7347e9f756b36e5baa65d93dab52… --- diff --git a/src/modules/cdp/acctstatemachine.c b/src/modules/cdp/acctstatemachine.c index 4e9272980f..a0c5f26ad8 100644 --- a/src/modules/cdp/acctstatemachine.c +++ b/src/modules/cdp/acctstatemachine.c @@ -40,7 +40,7 @@ void update_gsu_response_timers(cdp_cc_acc_session_t* session, AAAMessage* msg) AAA_AVP *mscc_avp = mscc_avp_list.head; while (mscc_avp != NULL ) { - LM_DBG("MSCC AVP code is [%i] and data length is [%i]", mscc_avp->code, mscc_avp->data.len); + LM_DBG("MSCC AVP code is [%i] and data length is [%i]\n", mscc_avp->code, mscc_avp->data.len); switch (mscc_avp->code) { case AVP_Granted_Service_Unit: y = AAAUngroupAVPS(mscc_avp->data); diff --git a/src/modules/cdp/peerstatemachine.c b/src/modules/cdp/peerstatemachine.c index 5d26605c70..ed49a3ad30 100644 --- a/src/modules/cdp/peerstatemachine.c +++ b/src/modules/cdp/peerstatemachine.c @@ -695,7 +695,7 @@ int count_Supported_Vendor_Id_AVPS(AAAMessage *msg) break; avp_vendor = AAAFindMatchingAVP(msg,avp_vendor->next,AVP_Supported_Vendor_Id,0,0); } - LM_DBG("Found %i Supported_Vendor AVPS", avp_vendor_cnt); + LM_DBG("Found %i Supported_Vendor AVPS\n", avp_vendor_cnt); return avp_vendor_cnt; } diff --git a/src/modules/cdp/receiver.c b/src/modules/cdp/receiver.c index c33554457a..5aed0a36f4 100644 --- a/src/modules/cdp/receiver.c +++ b/src/modules/cdp/receiver.c @@ -396,7 +396,7 @@ static int receive_fd(int pipe_fd, int* fd,peer **p) *fd = *tmp; }else{ if(!cmsg) - LM_ERR("receive_fd: no descriptor passed, empty control message"); + LM_ERR("receive_fd: no descriptor passed, empty control message\n"); else LM_ERR("receive_fd: no descriptor passed, cmsg=%p," "len=%d\n", cmsg, (unsigned)cmsg->cmsg_len); @@ -768,7 +768,7 @@ int receive_loop(peer *original_peer) } LM_DBG("select_recv(): Send pipe says [%p] %d\n",msg,cnt); if (sp->tcp_socket<0){ - LM_ERR("select_recv(): got a signal to send something, but the connection was not opened"); + LM_ERR("select_recv(): got a signal to send something, but the connection was not opened\n"); } else { while( (cnt=write(sp->tcp_socket,msg->buf.s,msg->buf.len))==-1 ) { if (errno==EINTR) @@ -883,7 +883,7 @@ int peer_connect(peer *p) /* try to set the local socket used to connect to the peer */ if (p->src_addr.s && p->src_addr.len > 0) { - LM_DBG("peer_connect(): connetting to peer via src addr=%.*s",p->src_addr.len, p->src_addr.s); + LM_DBG("peer_connect(): connecting to peer via src addr=%.*s\n",p->src_addr.len, p->src_addr.s); memset (&hints, 0, sizeof(hints)); hints.ai_flags = AI_NUMERICHOST; hints.ai_socktype = SOCK_STREAM; diff --git a/src/modules/cdp/worker.c b/src/modules/cdp/worker.c index 30d7a1b0fe..64ba70679f 100644 --- a/src/modules/cdp/worker.c +++ b/src/modules/cdp/worker.c @@ -258,11 +258,11 @@ int put_task(peer *p, AAAMessage *msg) { length_percentage = num_tasks/tasks->max*100; if(length_percentage > workerq_length_threshold_percentage) { LM_WARN("Queue length has exceeded length threshold percentage" - " [%i] and is length [%i]", length_percentage, num_tasks); + " [%i] and is length [%i]\n", length_percentage, num_tasks); } } //int num_tasks = tasks->end - tasks->start; - //LM_ERR("Added task to task queue. Queue length [%i]", num_tasks); + //LM_ERR("Added task to task queue. Queue length [%i]\n", num_tasks); return 1; @@ -300,7 +300,7 @@ task_t take_task() { lock_release(tasks->lock); //int num_tasks = tasks->end - tasks->start; - //LM_ERR("Taken task from task queue. Queue length [%i]", num_tasks); + //LM_ERR("Taken task from task queue. Queue length [%i]\n", num_tasks); return t;

3 years, 10 months

git:master:508786fc: ims_charging: fix missing line-breaks for log messages

by Henning Westerholt

Module: kamailio Branch: master Commit: 508786fcdbbc120215b3e7dd90d92ab40c3b1e4e URL: https://github.com/kamailio/kamailio/commit/508786fcdbbc120215b3e7dd90d92ab… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-06-10T11:51:27Z ims_charging: fix missing line-breaks for log messages --- Modified: src/modules/ims_charging/ccr.c Modified: src/modules/ims_charging/dialog.c Modified: src/modules/ims_charging/diameter_ro.c Modified: src/modules/ims_charging/ims_charging_mod.c Modified: src/modules/ims_charging/ims_ro.c Modified: src/modules/ims_charging/ro_db_handler.c Modified: src/modules/ims_charging/ro_session_hash.c Modified: src/modules/ims_charging/ro_session_hash.h Modified: src/modules/ims_charging/ro_timer.c --- Diff: https://github.com/kamailio/kamailio/commit/508786fcdbbc120215b3e7dd90d92ab… Patch: https://github.com/kamailio/kamailio/commit/508786fcdbbc120215b3e7dd90d92ab…

3 years, 10 months

git:master:32a0d807: cdp: add missing line-breaks for log messages

by Henning Westerholt

Module: kamailio Branch: master Commit: 32a0d8073eb1b7f01190d305d318b43268811be8 URL: https://github.com/kamailio/kamailio/commit/32a0d8073eb1b7f01190d305d318b43… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-06-10T11:51:27Z cdp: add missing line-breaks for log messages --- Modified: src/modules/cdp/acctstatemachine.c Modified: src/modules/cdp/peerstatemachine.c Modified: src/modules/cdp/receiver.c Modified: src/modules/cdp/worker.c --- Diff: https://github.com/kamailio/kamailio/commit/32a0d8073eb1b7f01190d305d318b43… Patch: https://github.com/kamailio/kamailio/commit/32a0d8073eb1b7f01190d305d318b43… --- diff --git a/src/modules/cdp/acctstatemachine.c b/src/modules/cdp/acctstatemachine.c index 4e9272980f..a0c5f26ad8 100644 --- a/src/modules/cdp/acctstatemachine.c +++ b/src/modules/cdp/acctstatemachine.c @@ -40,7 +40,7 @@ void update_gsu_response_timers(cdp_cc_acc_session_t* session, AAAMessage* msg) AAA_AVP *mscc_avp = mscc_avp_list.head; while (mscc_avp != NULL ) { - LM_DBG("MSCC AVP code is [%i] and data length is [%i]", mscc_avp->code, mscc_avp->data.len); + LM_DBG("MSCC AVP code is [%i] and data length is [%i]\n", mscc_avp->code, mscc_avp->data.len); switch (mscc_avp->code) { case AVP_Granted_Service_Unit: y = AAAUngroupAVPS(mscc_avp->data); diff --git a/src/modules/cdp/peerstatemachine.c b/src/modules/cdp/peerstatemachine.c index 5d26605c70..ed49a3ad30 100644 --- a/src/modules/cdp/peerstatemachine.c +++ b/src/modules/cdp/peerstatemachine.c @@ -695,7 +695,7 @@ int count_Supported_Vendor_Id_AVPS(AAAMessage *msg) break; avp_vendor = AAAFindMatchingAVP(msg,avp_vendor->next,AVP_Supported_Vendor_Id,0,0); } - LM_DBG("Found %i Supported_Vendor AVPS", avp_vendor_cnt); + LM_DBG("Found %i Supported_Vendor AVPS\n", avp_vendor_cnt); return avp_vendor_cnt; } diff --git a/src/modules/cdp/receiver.c b/src/modules/cdp/receiver.c index c33554457a..5aed0a36f4 100644 --- a/src/modules/cdp/receiver.c +++ b/src/modules/cdp/receiver.c @@ -396,7 +396,7 @@ static int receive_fd(int pipe_fd, int* fd,peer **p) *fd = *tmp; }else{ if(!cmsg) - LM_ERR("receive_fd: no descriptor passed, empty control message"); + LM_ERR("receive_fd: no descriptor passed, empty control message\n"); else LM_ERR("receive_fd: no descriptor passed, cmsg=%p," "len=%d\n", cmsg, (unsigned)cmsg->cmsg_len); @@ -768,7 +768,7 @@ int receive_loop(peer *original_peer) } LM_DBG("select_recv(): Send pipe says [%p] %d\n",msg,cnt); if (sp->tcp_socket<0){ - LM_ERR("select_recv(): got a signal to send something, but the connection was not opened"); + LM_ERR("select_recv(): got a signal to send something, but the connection was not opened\n"); } else { while( (cnt=write(sp->tcp_socket,msg->buf.s,msg->buf.len))==-1 ) { if (errno==EINTR) @@ -883,7 +883,7 @@ int peer_connect(peer *p) /* try to set the local socket used to connect to the peer */ if (p->src_addr.s && p->src_addr.len > 0) { - LM_DBG("peer_connect(): connetting to peer via src addr=%.*s",p->src_addr.len, p->src_addr.s); + LM_DBG("peer_connect(): connecting to peer via src addr=%.*s\n",p->src_addr.len, p->src_addr.s); memset (&hints, 0, sizeof(hints)); hints.ai_flags = AI_NUMERICHOST; hints.ai_socktype = SOCK_STREAM; diff --git a/src/modules/cdp/worker.c b/src/modules/cdp/worker.c index 30d7a1b0fe..64ba70679f 100644 --- a/src/modules/cdp/worker.c +++ b/src/modules/cdp/worker.c @@ -258,11 +258,11 @@ int put_task(peer *p, AAAMessage *msg) { length_percentage = num_tasks/tasks->max*100; if(length_percentage > workerq_length_threshold_percentage) { LM_WARN("Queue length has exceeded length threshold percentage" - " [%i] and is length [%i]", length_percentage, num_tasks); + " [%i] and is length [%i]\n", length_percentage, num_tasks); } } //int num_tasks = tasks->end - tasks->start; - //LM_ERR("Added task to task queue. Queue length [%i]", num_tasks); + //LM_ERR("Added task to task queue. Queue length [%i]\n", num_tasks); return 1; @@ -300,7 +300,7 @@ task_t take_task() { lock_release(tasks->lock); //int num_tasks = tasks->end - tasks->start; - //LM_ERR("Taken task from task queue. Queue length [%i]", num_tasks); + //LM_ERR("Taken task from task queue. Queue length [%i]\n", num_tasks); return t;

3 years, 10 months

git:master:97593d20: sipdump: make month in the file name from 1 to 12

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 97593d20875d26c38511f564fd7071bf79baa56b URL: https://github.com/kamailio/kamailio/commit/97593d20875d26c38511f564fd7071b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-06-09T20:02:21+02:00 sipdump: make month in the file name from 1 to 12 - tm_mon is from 0-11 --- Modified: src/modules/sipdump/sipdump_write.c --- Diff: https://github.com/kamailio/kamailio/commit/97593d20875d26c38511f564fd7071b… Patch: https://github.com/kamailio/kamailio/commit/97593d20875d26c38511f564fd7071b… --- diff --git a/src/modules/sipdump/sipdump_write.c b/src/modules/sipdump/sipdump_write.c index 29face97c4..6730d4f602 100644 --- a/src/modules/sipdump/sipdump_write.c +++ b/src/modules/sipdump/sipdump_write.c @@ -202,7 +202,7 @@ static int sipdump_rotate_file(void) n = snprintf(_sipdump_fpath+_sipdump_fpath_prefix.len, SIPDUMP_FPATH_SIZE-_sipdump_fpath_prefix.len, "%d-%02d-%02d--%02d-%02d-%02d.data", - 1900+ti.tm_year, ti.tm_mon, ti.tm_mday, + 1900+ti.tm_year, ti.tm_mon+1, ti.tm_mday, ti.tm_hour, ti.tm_min, ti.tm_sec); LM_DBG("writing to file: %s (%d)\n", _sipdump_fpath, n); _sipdump_file = fopen( _sipdump_fpath, "w" );

3 years, 10 months

missing SAR messages

by Georgi Rosenov Stefanov

I expect to 2000 of xlog("L_ERR", "GEORGI pcscf_save_pending"); on each try no matter how many registrations/sec I do

3 years, 10 months

git:5.3:249d558c: pkg/docker: updated alpine docker packaging submodule

by Sergey Safarov

Module: kamailio Branch: 5.3 Commit: 249d558c0e3ae0c0e24d508d2e7a9c2853078a8f URL: https://github.com/kamailio/kamailio/commit/249d558c0e3ae0c0e24d508d2e7a9c2… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2020-06-09T14:02:50+03:00 pkg/docker: updated alpine docker packaging submodule --- Modified: pkg/docker --- Diff: https://github.com/kamailio/kamailio/commit/249d558c0e3ae0c0e24d508d2e7a9c2… Patch: https://github.com/kamailio/kamailio/commit/249d558c0e3ae0c0e24d508d2e7a9c2… --- diff --git a/pkg/docker b/pkg/docker index a6955b1834..9fa73e31e6 160000 --- a/pkg/docker +++ b/pkg/docker @@ -1 +1 @@ -Subproject commit a6955b1834dbd3180bbc1cc256ba8aac0269739b +Subproject commit 9fa73e31e6b636148c57a1270692eb8bb967ee77

3 years, 10 months

[kamailio/kamailio] Intermittent failed assertion in app_python3 (#2335)

by Alex Balashov

Submitting this on behalf of Jacob Greene, who posted a day or two ago: https://lists.kamailio.org/pipermail/sr-users/2020-May/109315.html Version in production is Debian 9 and Kamailio 5.3.4 from Debian packages: ``` ii kamailio 5.3.4+bpo9 amd64 very fast, dynamic and configurable SIP server ii kamailio-postgres-modules:amd64 5.3.4+bpo9 amd64 PostgreSQL database connectivity module for the Kamailio SIP server ii kamailio-presence-modules:amd64 5.3.4+bpo9 amd64 SIP presence modules for Kamailio ii kamailio-python3-modules:amd64 5.3.4+bpo9 amd64 The app_python3 module for the Kamailio SIP server rc kamailio-xml-modules:amd64 5.2.6+stretch amd64 XML based extensions for Kamailio's Management Interface ``` Anyway, a Kamailio child process periodically exits -- about ten times a day -- with a `SIGABRT` set off by a failed assertion somewhere inside the `app_python3` bureaucracy: ``` (gdb) where #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51 #1 0x00007f2c2f76042a in __GI_abort () at abort.c:89 #2 0x00007f2c2f757e67 in __assert_fail_base (fmt=<optimized out>, assertion=assertion@entry=0x7f2c2892bda8 "PyBytes_Check(pframe->f_code->co_name)", file=file@entry=0x7f2c2892bd9c "apy_kemi.c", line=line@entry=1819, function=function@entry=0x7f2c2892d0b0 "sr_apy_kemi_exec_func") at assert.c:92 #3 0x00007f2c2f757f12 in __GI___assert_fail (assertion=0x7f2c2892bda8 "PyBytes_Check(pframe->f_code->co_name)", file=0x7f2c2892bd9c "apy_kemi.c", line=1819, function=0x7f2c2892d0b0 "sr_apy_kemi_exec_func") at assert.c:101 #4 0x00007f2c2890bd57 in sr_apy_kemi_exec_func () from /usr/lib/x86_64-linux-gnu/kamailio/modules/app_python3.so #5 0x00007f2c288d525c in ?? () from /usr/lib/x86_64-linux-gnu/kamailio/modules/app_python3.so #6 0x00007f2c282ad259 in PyCFunction_Call () from /usr/lib/x86_64-linux-gnu/libpython3.5m.so.1.0 #7 0x00007f2c283de739 in PyEval_EvalFrameEx () from /usr/lib/x86_64-linux-gnu/libpython3.5m.so.1.0 #8 0x00007f2c283de6ad in PyEval_EvalFrameEx () from /usr/lib/x86_64-linux-gnu/libpython3.5m.so.1.0 #9 0x00007f2c284a0074 in ?? () from /usr/lib/x86_64-linux-gnu/libpython3.5m.so.1.0 #10 0x00007f2c283dcadf in PyEval_EvalFrameEx () from /usr/lib/x86_64-linux-gnu/libpython3.5m.so.1.0 #11 0x00007f2c283de6ad in PyEval_EvalFrameEx () from /usr/lib/x86_64-linux-gnu/libpython3.5m.so.1.0 #12 0x00007f2c284a0074 in ?? () from /usr/lib/x86_64-linux-gnu/libpython3.5m.so.1.0 #13 0x00007f2c284a0153 in PyEval_EvalCodeEx () from /usr/lib/x86_64-linux-gnu/libpython3.5m.so.1.0 #14 0x00007f2c28333558 in ?? () from /usr/lib/x86_64-linux-gnu/libpython3.5m.so.1.0 #15 0x00007f2c2840fa37 in PyObject_Call () from /usr/lib/x86_64-linux-gnu/libpython3.5m.so.1.0 #16 0x00007f2c2845b95c in ?? () from /usr/lib/x86_64-linux-gnu/libpython3.5m.so.1.0 #17 0x00007f2c2840fa37 in PyObject_Call () from /usr/lib/x86_64-linux-gnu/libpython3.5m.so.1.0 #18 0x00007f2c2849eb77 in PyEval_CallObjectWithKeywords () from /usr/lib/x86_64-linux-gnu/libpython3.5m.so.1.0 #19 0x00007f2c2891c136 in apy_exec () from /usr/lib/x86_64-linux-gnu/kamailio/modules/app_python3.so #20 0x00007f2c288dfe94 in sr_kemi_config_engine_python () from /usr/lib/x86_64-linux-gnu/kamailio/modules/app_python3.so #21 0x0000558ec29ba7b4 in sr_kemi_route () #22 0x0000558ec2ab7c03 in receive_msg () #23 0x0000558ec2997e4a in udp_rcv_loop () #24 0x0000558ec28de718 in main_loop () #25 0x0000558ec28e7a39 in main () ``` The fuller backtrace for the top few frames: ``` Thread 1 (Thread 0x7f2c3031db40 (LWP 26211)): #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51 set = {__val = {0, 140720998929208, 139827752272384, 139827751795724, 140724530937856, 94071669029552, 94071669029653, 94071669029552, 94071669029552, 94071669029661, 94071669029852, 94071669029552, 94071669029852, 0, 0, 0}} pid = <optimized out> tid = <optimized out> #1 0x00007f2c2f76042a in __GI_abort () at abort.c:89 save_stage = 2 act = {__sigaction_handler = {sa_handler = 0x558ec469d990, sa_sigaction = 0x558ec469d990}, sa_mask = {__val = { 139827751803746, 140720998929248, 109, 139827755099200, 1819, 139827635998896, 139827635638836, 139827752272384, 139827751811289, 139827755115808, 139827751803256, 139827752815328, 139827752801040, 94071641717939, 139827763892224, 139827635994024}}, sa_flags = 1819, sa_restorer = 0x7f2c2892d0b0} sigs = {__val = {32, 0 <repeats 15 times>}} #2 0x00007f2c2f757e67 in __assert_fail_base (fmt=<optimized out>, assertion=assertion@entry=0x7f2c2892bda8 "PyBytes_Check(pframe->f_code->co_name)", file=file@entry=0x7f2c2892bd9c "apy_kemi.c", line=line@entry=1819, function=function@entry=0x7f2c2892d0b0 "sr_apy_kemi_exec_func") at assert.c:92 str = 0x558ec466a760 "" total = 4096 #3 0x00007f2c2f757f12 in __GI___assert_fail (assertion=0x7f2c2892bda8 "PyBytes_Check(pframe->f_code->co_name)", file=0x7f2c2892bd9c "apy_kemi.c", line=1819, function=0x7f2c2892d0b0 "sr_apy_kemi_exec_func") at assert.c:101 No locals. #4 0x00007f2c2890bd57 in sr_apy_kemi_exec_func () from /usr/lib/x86_64-linux-gnu/kamailio/modules/app_python3.so No symbol table info available. #5 0x00007f2c288d525c in ?? () from /usr/lib/x86_64-linux-gnu/kamailio/modules/app_python3.so No symbol table info available. #6 0x00007f2c282ad259 in PyCFunction_Call () from /usr/lib/x86_64-linux-gnu/libpython3.5m.so.1.0 No symbol table info available. #7 0x00007f2c283de739 in PyEval_EvalFrameEx () from /usr/lib/x86_64-linux-gnu/libpython3.5m.so.1.0 No symbol table info available. #8 0x00007f2c283de6ad in PyEval_EvalFrameEx () from /usr/lib/x86_64-linux-gnu/libpython3.5m.so.1.0 No symbol table info available. #9 0x00007f2c284a0074 in ?? () from /usr/lib/x86_64-linux-gnu/libpython3.5m.so.1.0 No symbol table info available. #10 0x00007f2c283dcadf in PyEval_EvalFrameEx () from /usr/lib/x86_64-linux-gnu/libpython3.5m.so.1.0 No symbol table info available. #11 0x00007f2c283de6ad in PyEval_EvalFrameEx () from /usr/lib/x86_64-linux-gnu/libpython3.5m.so.1.0 No symbol table info available. #12 0x00007f2c284a0074 in ?? () from /usr/lib/x86_64-linux-gnu/libpython3.5m.so.1.0 No symbol table info available. #13 0x00007f2c284a0153 in PyEval_EvalCodeEx () from /usr/lib/x86_64-linux-gnu/libpython3.5m.so.1.0 No symbol table info available. #14 0x00007f2c28333558 in ?? () from /usr/lib/x86_64-linux-gnu/libpython3.5m.so.1.0 No symbol table info available. #15 0x00007f2c2840fa37 in PyObject_Call () from /usr/lib/x86_64-linux-gnu/libpython3.5m.so.1.0 No symbol table info available. #16 0x00007f2c2845b95c in ?? () from /usr/lib/x86_64-linux-gnu/libpython3.5m.so.1.0 No symbol table info available. #17 0x00007f2c2840fa37 in PyObject_Call () from /usr/lib/x86_64-linux-gnu/libpython3.5m.so.1.0 No symbol table info available. #18 0x00007f2c2849eb77 in PyEval_CallObjectWithKeywords () from /usr/lib/x86_64-linux-gnu/libpython3.5m.so.1.0 No symbol table info available. #19 0x00007f2c2891c136 in apy_exec () from /usr/lib/x86_64-linux-gnu/kamailio/modules/app_python3.so No symbol table info available. #20 0x00007f2c288dfe94 in sr_kemi_config_engine_python () from /usr/lib/x86_64-linux-gnu/kamailio/modules/app_python3.so No symbol table info available. #21 0x0000558ec29ba7b4 in sr_kemi_route () No symbol table info available. #22 0x0000558ec2ab7c03 in receive_msg () No symbol table info available. #23 0x0000558ec2997e4a in udp_rcv_loop () No symbol table info available. #24 0x0000558ec28de718 in main_loop () No symbol table info available. #25 0x0000558ec28e7a39 in main () No symbol table info available. ``` For what it's worth, line 1819 in `apy_kemi.c` in the latest 5.3 `HEAD` (which I'm not sure this binary package reflects) is: ``` 1801 if(unlikely(cfg_get(core, core_cfg, latency_limit_action)>0) 1802 && is_printable(cfg_get(core, core_cfg, latency_log))) { 1803 gettimeofday(&tve, &tz); 1804 tdiff = (tve.tv_sec - tvb.tv_sec) * 1000000 1805 + (tve.tv_usec - tvb.tv_usec); 1806 if(tdiff >= cfg_get(core, core_cfg, latency_limit_action)) { 1807 pstate = PyThreadState_GET(); 1808 if (pstate != NULL && pstate->frame != NULL) { 1809 pframe = pstate->frame; 1810 } 1811 1812 LOG(cfg_get(core, core_cfg, latency_log), 1813 "alert - action KSR.%s%s%s(...)" 1814 " took too long [%u ms] (file:%s func:%s line:%d)\n", 1815 (ket->mname.len>0)?ket->mname.s:"", 1816 (ket->mname.len>0)?".":"", ket->fname.s, tdiff, 1817 (pframe)?PyBytes_AS_STRING(pframe->f_code->co_filename):"", 1818 (pframe)?PyBytes_AS_STRING(pframe->f_code->co_name):"", 1819 (pframe)?PyCode_Addr2Line(pframe->f_code, pframe->f_lasti):0); 1820 } 1821 } 1822 1823 return ret; 1824 } 1825 ``` That's inside `sr_apy_kemi_exec_func()`. Some suspicion falls upon this Python function: ``` def set_send_socket(self): KSR.info('[socket] forced_socket is: {}'.format(KSR.pv.get('$fs'))) if KSR.pv.get('$fs'): KSR.info('[socket] socket already set') return elif not self.is_local(): KSR.info('[socket] set socket to 5065') KSR.corex.set_send_socket(MY_IP + ':5065') else: KSR.info('[socket] set socket to 5060') KSR.corex.set_send_socket(MY_IP + ':5060') KSR.info('[socket] socket set') ``` ... simply because the last message out of KEMI which appears prior to the crash is one of its log emissions ... ``` May 21 18:20:25 proxy1 /usr/sbin/kamailio[26210]: INFO: 1697311439-5060-88(a)BA.CFC.EH.IF - {NOTIFY}: <core> [core/kemi.c:104]: sr_kemi_core_info(): domain exists result: None May 21 18:20:25 proxy1 /usr/sbin/kamailio[26211]: INFO: 1361696919-5060-39(a)BA.CFC.EH.BFC - {NOTIFY}: <core> [core/kemi.c:104]: sr_kemi_core_info(): [socket] forced_socket is: None May 21 18:20:25 proxy1 /usr/sbin/kamailio[26213]: INFO: 813204231-5060-53(a)BA.BF.J.CBF - {NOTIFY}: <core> [core/receive.c:518]: receive_msg(): reply-route executed in: 260 usec May 21 18:20:25 proxy1 /usr/sbin/kamailio[26212]: INFO: 1941306664-5060-17(a)BA.CFC.EH.CAG - {NOTIFY}: <core> [core/receive.c:518]: receive_msg(): reply-route executed in: 412 usec May 21 18:20:25 proxy1 /usr/sbin/kamailio[26209]: ALERT: <core> [main.c:766]: handle_sigs(): child process 26210 exited by a signal 6 May 21 18:20:25 proxy1 /usr/sbin/kamailio[26209]: ALERT: <core> [main.c:769]: handle_sigs(): core was not generated May 21 18:20:25 proxy1 /usr/sbin/kamailio[26209]: INFO: <core> [main.c:792]: handle_sigs(): terminating due to SIGCHLD ``` However, it's hard to troubleshoot without debug symbols and due to the third-party binary libraries, of course. Furthermore, the problem is not possible to reproduce on demand, though its incidence does seem to correlate to higher call volumes. Would building from source to provide more flexibility be recommended at this stage? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2335

3 years, 10 months

git:master:b02c2470: app_python: check if f_code field in frame is set before using in log message

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: b02c247023ea3ea0ef9753efdb04aff7d5d3bbb4 URL: https://github.com/kamailio/kamailio/commit/b02c247023ea3ea0ef9753efdb04aff… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-06-09T10:53:22+02:00 app_python: check if f_code field in frame is set before using in log message --- Modified: src/modules/app_python/apy_kemi.c --- Diff: https://github.com/kamailio/kamailio/commit/b02c247023ea3ea0ef9753efdb04aff… Patch: https://github.com/kamailio/kamailio/commit/b02c247023ea3ea0ef9753efdb04aff… --- diff --git a/src/modules/app_python/apy_kemi.c b/src/modules/app_python/apy_kemi.c index 5320b02155..43a47d28ad 100644 --- a/src/modules/app_python/apy_kemi.c +++ b/src/modules/app_python/apy_kemi.c @@ -1814,9 +1814,9 @@ PyObject *sr_apy_kemi_exec_func(PyObject *self, PyObject *args, int idx) " took too long [%u us] (file:%s func:%s line:%d)\n", (ket->mname.len>0)?ket->mname.s:"", (ket->mname.len>0)?".":"", ket->fname.s, tdiff, - (pframe)?PyString_AsString(pframe->f_code->co_filename):"", - (pframe)?PyString_AsString(pframe->f_code->co_name):"", - (pframe)?PyCode_Addr2Line(pframe->f_code, pframe->f_lasti):0); + (pframe && pframe->f_code)?PyString_AsString(pframe->f_code->co_filename):"", + (pframe && pframe->f_code)?PyString_AsString(pframe->f_code->co_name):"", + (pframe && pframe->f_code)?PyCode_Addr2Line(pframe->f_code, pframe->f_lasti):0); } }

3 years, 10 months

git:master:e680dd6e: app_python3: use safer function PyBytes_AsString() instead of macro

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: e680dd6ed672e63012e960c68c0030e3f188654b URL: https://github.com/kamailio/kamailio/commit/e680dd6ed672e63012e960c68c0030e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-06-09T10:49:22+02:00 app_python3: use safer function PyBytes_AsString() instead of macro - check if f_code filed in frame is set before using in log message - GH #2335 --- Modified: src/modules/app_python3/apy_kemi.c --- Diff: https://github.com/kamailio/kamailio/commit/e680dd6ed672e63012e960c68c0030e… Patch: https://github.com/kamailio/kamailio/commit/e680dd6ed672e63012e960c68c0030e… --- diff --git a/src/modules/app_python3/apy_kemi.c b/src/modules/app_python3/apy_kemi.c index 2c4d73eb72..7af949de6e 100644 --- a/src/modules/app_python3/apy_kemi.c +++ b/src/modules/app_python3/apy_kemi.c @@ -1822,9 +1822,9 @@ PyObject *sr_apy_kemi_exec_func(PyObject *self, PyObject *args, int idx) " took too long [%u ms] (file:%s func:%s line:%d)\n", (ket->mname.len>0)?ket->mname.s:"", (ket->mname.len>0)?".":"", ket->fname.s, tdiff, - (pframe)?PyBytes_AS_STRING(pframe->f_code->co_filename):"", - (pframe)?PyBytes_AS_STRING(pframe->f_code->co_name):"", - (pframe)?PyCode_Addr2Line(pframe->f_code, pframe->f_lasti):0); + (pframe && pframe->f_code)?PyBytes_AsString(pframe->f_code->co_filename):"", + (pframe && pframe->f_code)?PyBytes_AsString(pframe->f_code->co_name):"", + (pframe && pframe->f_code)?PyCode_Addr2Line(pframe->f_code, pframe->f_lasti):0); } }

3 years, 10 months

← Newer
1
...
29
30
31
32
33
34
35
...
40
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2020