<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
- Adds a new methods_blacklist_auto modparam that allows to
ignore SIP method ids before mirroring traffic to a SIP capture
server when trace_mode=1.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2374
-- Commit Summary --
* siptrace: add methods_blacklist_auto modparam
-- File Changes --
M src/modules/siptrace/README (98)
M src/modules/siptrace/doc/siptrace_admin.xml (109)
M src/modules/siptrace/siptrace.c (56)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2374.patchhttps://github.com/kamailio/kamailio/pull/2374.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2374
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ X] Commit message has the format required by CONTRIBUTING guide
- [ X] Commits are split per component (core, individual modules, libs, utils, ...)
- [ X] Each component has a single commit (if not, squash them into one commit)
- [ X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [X ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ X] Tested changes locally
- [ X] Related to issue #2361
#### Description
When a destination is selected using one of the hash algorithms (over Call-ID, From, etc.)
and destination is not available, then the next is selected. This causes the following problem :
All messages to the unavailable destination will be sent to the same unique destination.
This will cause that one destination will receive double load and the rest will continue with the same.
Solution : To better distribute messages, while also guaranteeing the same distribution of the hash, a re-hash of the hash is made.
As the rehash could select the same or other failed destination, it can rehash several times. The number of rehashes made is controlled by :
modparam("dispatcher", "ds_rehash_max", -1)
Which can take the following values :
-1 : The total count of destinations is used
0 : Disabled. Reverts to original implementation.
Positive number. Maximum number of rehashes.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2363
-- Commit Summary --
* dispatcher : better distribution when using hash and destination is not available
-- File Changes --
M src/modules/dispatcher/dispatch.c (49)
M src/modules/dispatcher/dispatcher.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2363.patchhttps://github.com/kamailio/kamailio/pull/2363.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2363
Function "tcp_get_conid" from tcpops module does not write the conid into target variable
I followed the documentation on https://www.kamailio.org/docs/modules/devel/modules/tcpops.html#tcpops.f.tc…
And with debug enabled, you see the connection is found:
`Jun 30 14:13:47 kamailio-dev-2 /usr/sbin/kamailio[121285]: DEBUG: <core> [core/tcp_main.c:1670]: _tcpconn_find(): found connection by peer address (id: 14)`
But the given variable $var(conid) is always empty.
After a lookup("location") the code is like:
```
if(tcp_get_conid("$dd:$dp", "$var(conid)")) {
xlog("connection id is: $var(conid)\n");
}
```
But the given variable $var(conid) is always empty.
Version used: kamailio 5.3.5 (x86_64/linux)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2382
I'm using set_contact_alias() to fix nat registrations, in this case with a Bria client.
Somehow Bria learns that I'm using this - probably through the Contact in the 200 OK reply of save(). Bria then adds this to the Contact when replying to incoming INVITE.
After some time, something happens in the network at client side and the connection gets a new port through the router. Bria does not notice and still sends the old alias-parameter with the port not used anymore. When I'm calling handle_ruri_alias(), Kamailio reads this instead of the actual port and the ACK to 200 OK is sent to a port not used anymore.
This can probably be solved by either, in preferred order:
- rewrite set_contact_alias() and add_contact_alias() to replace existing alias parameters
- regexp remove of alias parameter from Contact of all messages coming from clients
- regexp remove of alias parameter from Contact returned by save()
Br,
Morten
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2308
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] New feature (non-breaking change which adds new functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] Tested changes locally
#### Description
- adding support for persistent mqueue in a DB
```
modparam("mqueue", "db_url", "sqlite:////kamailio_db/mqueue.sqlite")
modparam("mqueue", "mqueue", "name=acc_events;size=1000000;dbmode=1")
modparam("acc_json", "output_mqueue", "acc_events")
```
#### Todo
- make sure the mqueue order is preserved, I will have to use incremental ID
- review and more tests
- documentation
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2359
-- Commit Summary --
* mqueue: add db
-- File Changes --
M src/modules/mqueue/Makefile (3)
M src/modules/mqueue/README (0)
M src/modules/mqueue/api.h (0)
M src/modules/mqueue/mqueue_api.c (28)
M src/modules/mqueue/mqueue_api.h (2)
A src/modules/mqueue/mqueue_db.c (331)
A src/modules/mqueue/mqueue_db.h (33)
M src/modules/mqueue/mqueue_mod.c (15)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2359.patchhttps://github.com/kamailio/kamailio/pull/2359.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2359
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ x] Commit message has the format required by CONTRIBUTING guide
- [ x] Commits are split per component (core, individual modules, libs, utils, ...)
- [ x] Each component has a single commit (if not, squash them into one commit)
- [ x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x ] PR should be backported to stable branches
- [x ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
When cnxcc receives a message wih a registered CID (for example in a re-INVITE) it saves as a new call and this is a problem:
- cnxcc store 2 times the same call and it discounts credit for both
- when the call is finished, cnxcc only remove one record and the other continues discounting credit.
- when credit is finished (of an non active call), all active calls are killed
An example:
kamcmd> cnxcc.check_client test
id:0,confirmed:no,local_consumed_amount:0.004800,global_consumed_amount:3.126200,local_max_amount:30.000000,global_max_amount:30.000000,call_id:41211f7e0a65b41c4ca7181b18db0f1e@185.47.15.56:5080,start_timestamp:0,inip:1,finp:1,connect:0.000000,cps:0.004800;
id:1,confirmed:no,local_consumed_amount:0.004800,global_consumed_amount:3.126200,local_max_amount:30.000000,global_max_amount:30.000000,call_id:41211f7e0a65b41c4ca7181b18db0f1e@185.47.15.56:5080,start_timestamp:0,inip:1,finp:1,connect:0.000000,cps:0.004800;
id:2,confirmed:no,local_consumed_amount:0.000200,global_consumed_amount:3.126200,local_max_amount:30.000000,global_max_amount:30.000000,call_id:5e911ab1452cf1a3165af5262b519977@185.47.15.56:5080,start_timestamp:0,inip:1,finp:1,connect:0.000000,cps:0.000200;
id:3,confirmed:no,local_consumed_amount:0.000200,global_consumed_amount:3.126200,local_max_amount:30.000000,global_max_amount:30.000000,call_id:5e911ab1452cf1a3165af5262b519977@185.47.15.56:5080,start_timestamp:0,inip:1,finp:1,connect:0.000000,cps:0.000200;
id:4,confirmed:no,local_consumed_amount:0.000800,global_consumed_amount:3.126200,local_max_amount:30.000000,global_max_amount:30.000000,call_id:0f44fbc63883e52d72c9f52f49253476@185.47.15.56:5080,start_timestamp:0,inip:1,finp:1,connect:0.000000,cps:0.000800;
- id 0 and id 1 are the same call that has been inserted twice.
- id 2 and id 3 are the same call that has been inserted twice.
- id 4 is a finished call that has not been removed from the stack and continues discounting credit.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2383
-- Commit Summary --
* cnxcc: remove duplicated entries with a same CID value
-- File Changes --
M src/modules/cnxcc/cnxcc_mod.c (50)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2383.patchhttps://github.com/kamailio/kamailio/pull/2383.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2383
Hello,
Just noticed this, not sure if this is caused from work in progress code:
henning@static:~/repositories/kamailio/src/modules/dlgs$ make
CC (gcc) [M dlgs.so] dlgs_mod.o
dlgs_mod.c:264:12: warning: 'w_dlgs_tags_count' defined but not used [-Wunused-function]
264 | static int w_dlgs_tags_count(sip_msg_t *msg, char *ptags, char *p2)
|
Cheers,
Henning
--
Henning Westerholt - https://skalatan.de/blog/
Kamailio services - https://gilawa.com<https://gilawa.com/>