sr-dev May 2020

sr-dev@lists.kamailio.org

24 participants
393 discussions

git:master:b0f1486f: srdb1: default value set to 0 for number types

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: b0f1486f8a656922aac02020c9e3141639f2ecb9 URL: https://github.com/kamailio/kamailio/commit/b0f1486f8a656922aac02020c9e3141… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-05-07T08:19:05+02:00 srdb1: default value set to 0 for number types --- Modified: src/lib/srdb1/schema/secfilter.xml --- Diff: https://github.com/kamailio/kamailio/commit/b0f1486f8a656922aac02020c9e3141… Patch: https://github.com/kamailio/kamailio/commit/b0f1486f8a656922aac02020c9e3141… --- diff --git a/src/lib/srdb1/schema/secfilter.xml b/src/lib/srdb1/schema/secfilter.xml index 4edab34e6c..0b3cbc8878 100644 --- a/src/lib/srdb1/schema/secfilter.xml +++ b/src/lib/srdb1/schema/secfilter.xml @@ -37,14 +37,14 @@ <column id="action"> <name>action</name> <type>short</type> - <default/> + <default>0</default> <description>Action to do (0=blacklisted data, 1=whitelisted data, 2=blacklisted destination).</description> </column> <column id="type"> <name>type</name> <type>short</type> - <default/> + <default>0</default> <description>Type of data (0=user-agent, 1=country, 2=domain, 3=IP address, 4=user).</description> </column>

4 years

ICMP port-unreachable for UDP INVITEs

by James Browne

I've searched, but I cannot find anything recent about this. My kamailio 5.0.8 proxy sends an INVITE downstream over UDP and gets an ICMP port-unreachable response from the UAS. Apparently ignoring this, it re-transmits the INVITEs and eventually times out and sends to the next host (from the SRV lookup). According to RFC 3261 (https://tools.ietf.org/html/rfc3261#section-8.1.3.1), If a fatal transport error is reported by the transport layer (generally, due to fatal ICMP errors in UDP or connection failures in TCP), the condition MUST be treated as a 503 (Service Unavailable) status code. Does kamailio support handling ICMP responses to INVITEs (and therefore either failing over immediately, or sending 503 upstream immediately)? I don't know for sure the "correct" behavior because the RFC3261 is so old and because ICMP responses are limited in size and therefore can't guarantee to uniquely identify the transactions that caused them.

4 years

git:master:07664979: pua: use file name specific include guard

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 076649793bfdbdc4f03f96961f23997c87ce4268 URL: https://github.com/kamailio/kamailio/commit/076649793bfdbdc4f03f96961f23997… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-05-06T17:15:36+02:00 pua: use file name specific include guard --- Modified: src/modules/pua/hash.h Modified: src/modules/pua/pua.h --- Diff: https://github.com/kamailio/kamailio/commit/076649793bfdbdc4f03f96961f23997… Patch: https://github.com/kamailio/kamailio/commit/076649793bfdbdc4f03f96961f23997… --- diff --git a/src/modules/pua/hash.h b/src/modules/pua/hash.h index cc73d3e761..454e4bb853 100644 --- a/src/modules/pua/hash.h +++ b/src/modules/pua/hash.h @@ -15,8 +15,8 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ diff --git a/src/modules/pua/pua.h b/src/modules/pua/pua.h index 57cc379ebe..908f5b0cb3 100644 --- a/src/modules/pua/pua.h +++ b/src/modules/pua/pua.h @@ -15,13 +15,13 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ -#ifndef PUBLISH_H -#define PUBLISH_H +#ifndef _PUA_H_ +#define _PUA_H_ #include "../../core/str.h" #include "../../lib/srdb1/db.h"

4 years

git:master:a6a40467: htable: use localtime_r() for a safer multi-thread usage

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: a6a4046757c2cac79455aa4a2d2ac632faa5e379 URL: https://github.com/kamailio/kamailio/commit/a6a4046757c2cac79455aa4a2d2ac63… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-05-06T17:13:16+02:00 htable: use localtime_r() for a safer multi-thread usage --- Modified: src/modules/htable/htable.c --- Diff: https://github.com/kamailio/kamailio/commit/a6a4046757c2cac79455aa4a2d2ac63… Patch: https://github.com/kamailio/kamailio/commit/a6a4046757c2cac79455aa4a2d2ac63… --- diff --git a/src/modules/htable/htable.c b/src/modules/htable/htable.c index a1a8e04c48..55717ecd94 100644 --- a/src/modules/htable/htable.c +++ b/src/modules/htable/htable.c @@ -1322,7 +1322,7 @@ static void htable_rpc_get(rpc_t* rpc, void* c) { ht_cell_t *htc; /*!< One HT cell */ void* th; void* vh; - struct tm *_expire_t; + struct tm _expire_t; char expire_buf[RPC_DATE_BUF_LEN]="NEVER"; if (rpc->scan(c, "SS", &htname, &keyname) < 2) { @@ -1357,9 +1357,9 @@ static void htable_rpc_get(rpc_t* rpc, void* c) { } if (htc->expire) { - _expire_t = localtime(&htc->expire); + localtime_r(&htc->expire, &_expire_t); strftime(expire_buf, RPC_DATE_BUF_LEN - 1, - "%Y-%m-%d %H:%M:%S", _expire_t); + "%Y-%m-%d %H:%M:%S", &_expire_t); } if(htc->flags&AVP_VAL_STR) {

4 years

git:master:14645b55: pv: use localtime_r() for a safer multi-thread usage

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 14645b550cf9500e6a6e4a7d2ed8749e9aa174dc URL: https://github.com/kamailio/kamailio/commit/14645b550cf9500e6a6e4a7d2ed8749… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-05-06T17:03:45+02:00 pv: use localtime_r() for a safer multi-thread usage --- Modified: src/modules/pv/pv_trans.c --- Diff: https://github.com/kamailio/kamailio/commit/14645b550cf9500e6a6e4a7d2ed8749… Patch: https://github.com/kamailio/kamailio/commit/14645b550cf9500e6a6e4a7d2ed8749… --- diff --git a/src/modules/pv/pv_trans.c b/src/modules/pv/pv_trans.c index 826fa9c2ef..d07e55e719 100644 --- a/src/modules/pv/pv_trans.c +++ b/src/modules/pv/pv_trans.c @@ -195,6 +195,7 @@ int tr_eval_string(struct sip_msg *msg, tr_param_t *tp, int subtype, pv_value_t v, w; time_t t; uint32_t sz1, sz2; + struct tm tmv; if(val==NULL || val->flags&PV_VAL_NULL) return -1; @@ -1045,8 +1046,8 @@ int tr_eval_string(struct sip_msg *msg, tr_param_t *tp, int subtype, memcpy(s, st.s, st.len); s[st.len] = '\0'; t = val->ri; - val->rs.len = strftime(_tr_buffer, TR_BUFFER_SIZE-1, s, - localtime(&t)); + localtime_r(&t, &tmv); + val->rs.len = strftime(_tr_buffer, TR_BUFFER_SIZE-1, s, &tmv); pkg_free(s); val->flags = PV_VAL_STR; val->rs.s = _tr_buffer;

4 years

Kamailio v5.3.4 Released

by Daniel-Constantin Mierla

Hello, Kamailio SIP Server v5.3.4 stable release is out. This is a maintenance release of the latest stable branch, 5.3, that includes fixes since the release of v5.3.3. There is no change to database schema or configuration language structure that you have to do on previous installations of v5.3.x. Deployments running previous v5.3.x versions are strongly recommended to be upgraded to v5.3.4. For more details about version 5.3.4 (including links and guidelines to download the tarball or from GIT repository), visit: * https://www.kamailio.org/w/2020/05/kamailio-v5-3-4-released/ RPM, Debian/Ubuntu packages will be available soon as well. Many thanks to all contributing and using Kamailio! Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda

4 years

git:5.3:117ff918: ChangeLog: content updated for v5.3.4

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.3 Commit: 117ff918b9df221475682d1755d6dfbd704c846e URL: https://github.com/kamailio/kamailio/commit/117ff918b9df221475682d1755d6dfb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-05-06T13:24:27+02:00 ChangeLog: content updated for v5.3.4 --- Modified: ChangeLog --- Diff: https://github.com/kamailio/kamailio/commit/117ff918b9df221475682d1755d6dfb… Patch: https://github.com/kamailio/kamailio/commit/117ff918b9df221475682d1755d6dfb…

4 years

git:5.3:195c2602: Makefile.defs: version set to 5.3.4

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.3 Commit: 195c2602db69b37db66662e736e6e43dc65a16b1 URL: https://github.com/kamailio/kamailio/commit/195c2602db69b37db66662e736e6e43… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-05-06T13:21:19+02:00 Makefile.defs: version set to 5.3.4 --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/195c2602db69b37db66662e736e6e43… Patch: https://github.com/kamailio/kamailio/commit/195c2602db69b37db66662e736e6e43… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index 5555ba0957..ea5545681a 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -106,7 +106,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) # version number VERSION = 5 PATCHLEVEL = 3 -SUBLEVEL = 3 +SUBLEVEL = 4 EXTRAVERSION = # memory manager switcher

4 years

git:5.3:9f2af321: pkg: set version to 5.3.4 for pkg specs

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.3 Commit: 9f2af321f677c0b5173ea4f99bef667fd6320a1f URL: https://github.com/kamailio/kamailio/commit/9f2af321f677c0b5173ea4f99bef667… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-05-06T12:48:04+02:00 pkg: set version to 5.3.4 for pkg specs --- Modified: pkg/kamailio/alpine/APKBUILD Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/9f2af321f677c0b5173ea4f99bef667… Patch: https://github.com/kamailio/kamailio/commit/9f2af321f677c0b5173ea4f99bef667… --- diff --git a/pkg/kamailio/alpine/APKBUILD b/pkg/kamailio/alpine/APKBUILD index 4f2b286946..0d421c624c 100644 --- a/pkg/kamailio/alpine/APKBUILD +++ b/pkg/kamailio/alpine/APKBUILD @@ -4,7 +4,7 @@ # Maintainer: Nathan Angelacos <nangel(a)alpinelinux.org> pkgname=kamailio -pkgver=5.3.3 +pkgver=5.3.4 pkgrel=0 # If building from a git snapshot, specify the gitcommit diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index 92729b8e82..76c08aa81c 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -1,5 +1,5 @@ %define name kamailio -%define ver 5.3.3 +%define ver 5.3.4 %define rel dev1.0%{dist} %if 0%{?fedora}

4 years

git:5.3:4322479f: modules: readme files regenerated - modules ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: 5.3 Commit: 4322479f914cc4a256000c1dae44129939d4dd10 URL: https://github.com/kamailio/kamailio/commit/4322479f914cc4a256000c1dae44129… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-05-06T12:31:52+02:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/htable/README --- Diff: https://github.com/kamailio/kamailio/commit/4322479f914cc4a256000c1dae44129… Patch: https://github.com/kamailio/kamailio/commit/4322479f914cc4a256000c1dae44129… --- diff --git a/src/modules/htable/README b/src/modules/htable/README index 78b7547085..5acb910b23 100644 --- a/src/modules/htable/README +++ b/src/modules/htable/README @@ -442,11 +442,17 @@ $ kamcmd htable.dump htable configuration file. * htname - string specifying the name of the hash table. This string is used by $sht(...) to refer to the hash table. - * size - number specifying the size of hash table. Larger value means - less collisions. The number of entries (aka slots or buckets) in - the table is 2^size. The possible range for this value is from 2 to - 31, smaller or larger values will be increased to 3 (8 slots) or - decreased to 14 (16384 slots). + * size - number to control how many slots (buckets) to create for the + hash table. Larger value means more slots with higher probability + for less collisions. The actual number slots (or buckets) created + for the table is 2^size. The possible range for this value is from + 2 to 31, smaller or larger values will be increased to 3 (8 slots) + or decreased to 14 (16384 slots). Note that each slot can store + more than one item, when there are collisions of hash ids computed + for keys. The items in the same slot are stored in a linked list. + In other words, the size is not setting a limit of how many items + can be stored in a hash table, as long as there is enough free + shared memory, new items can be added. * autoexpire -time in seconds to delete an item from a hash table if no update was done to it. If is missing or set to 0, the items won't expire.

4 years

← Newer
1
...
28
29
30
31
32
33
34
...
40
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2020