sr-dev March 2020

sr-dev@lists.kamailio.org

27 participants
473 discussions

Start a nNew thread

Jenkins build is back to normal : kamailiodev-nightly-binaries » amd64,buster #1595
by kamailio＠sipwise.com 03 Mar '20

03 Mar '20

See <https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…>

1 0

Jenkins build is back to normal : kamailiodev-nightly-binaries » i386,buster #1595
by kamailio＠sipwise.com 03 Mar '20

03 Mar '20

See <https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…>

1 0

Jenkins build is back to normal : kamailiodev-nightly-binaries » amd64,precise #1595
by kamailio＠sipwise.com 03 Mar '20

03 Mar '20

See <https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…>

1 0

Jenkins build is back to normal : kamailiodev-nightly-binaries » i386,precise #1595
by kamailio＠sipwise.com 03 Mar '20

03 Mar '20

See <https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…>

1 0

git:master:8156dd87: ims_auth: declare extern the stats variables in header file
by Daniel-Constantin Mierla 03 Mar '20

03 Mar '20

Module: kamailio Branch: master Commit: 8156dd87a977a011abb9652a997f4ba61eb3e642 URL: https://github.com/kamailio/kamailio/commit/8156dd87a977a011abb9652a997f4ba… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-03T13:28:30+01:00 ims_auth: declare extern the stats variables in header file --- Modified: src/modules/ims_auth/ims_auth_mod.c Modified: src/modules/ims_auth/stats.h --- Diff: https://github.com/kamailio/kamailio/commit/8156dd87a977a011abb9652a997f4ba… Patch: https://github.com/kamailio/kamailio/commit/8156dd87a977a011abb9652a997f4ba… --- diff --git a/src/modules/ims_auth/ims_auth_mod.c b/src/modules/ims_auth/ims_auth_mod.c index 20e148b089..3fd7ca923f 100644 --- a/src/modules/ims_auth/ims_auth_mod.c +++ b/src/modules/ims_auth/ims_auth_mod.c @@ -62,6 +62,10 @@ MODULE_VERSION +stat_var* stat_mar_timeouts = NULL; +stat_var* mar_replies_received = NULL; +stat_var* mar_replies_response_time = NULL; + static void destroy(void); static int mod_init(void); diff --git a/src/modules/ims_auth/stats.h b/src/modules/ims_auth/stats.h index 321feed279..98499c1b56 100644 --- a/src/modules/ims_auth/stats.h +++ b/src/modules/ims_auth/stats.h @@ -47,9 +47,9 @@ #include "../../core/counters.h" #include "ims_auth_mod.h" -stat_var* stat_mar_timeouts; -stat_var* mar_replies_received; -stat_var* mar_replies_response_time; +extern stat_var* stat_mar_timeouts; +extern stat_var* mar_replies_received; +extern stat_var* mar_replies_response_time; int register_stats(); unsigned long get_avg_mar_response_time();

1 0

git:master:15d5676f: ims_dialog: declare extern dlg stats structure in header file
by Daniel-Constantin Mierla 03 Mar '20

03 Mar '20

Module: kamailio Branch: master Commit: 15d5676fd7b6d64616fbf8ebf9517f0d56a47f5c URL: https://github.com/kamailio/kamailio/commit/15d5676fd7b6d64616fbf8ebf9517f0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-03T11:40:40+01:00 ims_dialog: declare extern dlg stats structure in header file --- Modified: src/modules/ims_dialog/dlg_ng_stats.c Modified: src/modules/ims_dialog/dlg_ng_stats.h --- Diff: https://github.com/kamailio/kamailio/commit/15d5676fd7b6d64616fbf8ebf9517f0… Patch: https://github.com/kamailio/kamailio/commit/15d5676fd7b6d64616fbf8ebf9517f0… --- diff --git a/src/modules/ims_dialog/dlg_ng_stats.c b/src/modules/ims_dialog/dlg_ng_stats.c index 6cc2a9ebdd..744a394dc8 100644 --- a/src/modules/ims_dialog/dlg_ng_stats.c +++ b/src/modules/ims_dialog/dlg_ng_stats.c @@ -1,6 +1,6 @@ #include "dlg_ng_stats.h" -struct dialog_ng_counters_h dialog_ng_cnts_h; +struct dialog_ng_counters_h dialog_ng_cnts_h = {0}; /* dialog_ng counters definitions */ counter_def_t dialog_ng_cnt_defs[] = { @@ -31,4 +31,4 @@ int dialog_ng_stats_init() void dialog_ng_stats_destroy() { /* do nothing */ -} \ No newline at end of file +} diff --git a/src/modules/ims_dialog/dlg_ng_stats.h b/src/modules/ims_dialog/dlg_ng_stats.h index f162a34886..9dfd53a182 100644 --- a/src/modules/ims_dialog/dlg_ng_stats.h +++ b/src/modules/ims_dialog/dlg_ng_stats.h @@ -11,9 +11,9 @@ struct dialog_ng_counters_h { }; -struct dialog_ng_counters_h dialog_ng_cnts_h; +extern struct dialog_ng_counters_h dialog_ng_cnts_h; int dialog_ng_stats_init(); void dialog_ng_stats_destroy(); -#endif /* DIALOG_NG_STATS_H */ \ No newline at end of file +#endif /* DIALOG_NG_STATS_H */

1 0

git:master:047fdebf: core: cfg.y - detect use of function call as parameter of another function
by Daniel-Constantin Mierla 03 Mar '20

03 Mar '20

Module: kamailio Branch: master Commit: 047fdebff732c847fcde5b066ce1acd5f6c2219a URL: https://github.com/kamailio/kamailio/commit/047fdebff732c847fcde5b066ce1acd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-03T11:30:04+01:00 core: cfg.y - detect use of function call as parameter of another function - GH #2227 --- Modified: src/core/cfg.y --- Diff: https://github.com/kamailio/kamailio/commit/047fdebff732c847fcde5b066ce1acd… Patch: https://github.com/kamailio/kamailio/commit/047fdebff732c847fcde5b066ce1acd… --- diff --git a/src/core/cfg.y b/src/core/cfg.y index 394386bb1b..23ab69ee08 100644 --- a/src/core/cfg.y +++ b/src/core/cfg.y @@ -3390,8 +3390,14 @@ cmd: } | CFG_RESET error { $$=0; yyerror("missing '(' or ')' ?"); } | CFG_RESET LPAREN error RPAREN { $$=0; yyerror("bad arguments, string expected"); } - | ID {mod_func_action = mk_action(MODULE0_T, 2, MODEXP_ST, NULL, NUMBER_ST, - 0); } LPAREN func_params RPAREN { + | ID { + if (mod_func_action != NULL) { + LM_ERR("function used inside params of another function: %s\n", $1); + yyerror("use of function execution inside params not allowed\n"); + exit(-1); + } + mod_func_action = mk_action(MODULE0_T, 2, MODEXP_ST, NULL, NUMBER_ST, 0); + } LPAREN func_params RPAREN { mod_func_action->val[0].u.data = find_export_record($1, mod_func_action->val[1].u.number, rt); if (mod_func_action->val[0].u.data == 0) { @@ -3415,6 +3421,7 @@ cmd: } $$ = mod_func_action; set_cfg_pos($$); + mod_func_action = NULL; } | ID error { yyerror("'('')' expected (function call)");} ;

1 0

git:master:8c5b92ee: core: cfg.y - init static global variables
by Daniel-Constantin Mierla 03 Mar '20

03 Mar '20

Module: kamailio Branch: master Commit: 8c5b92ee638a33e612e68cf85a1d37ab5e5d2c22 URL: https://github.com/kamailio/kamailio/commit/8c5b92ee638a33e612e68cf85a1d37a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-03T11:01:53+01:00 core: cfg.y - init static global variables --- Modified: src/core/cfg.y --- Diff: https://github.com/kamailio/kamailio/commit/8c5b92ee638a33e612e68cf85a1d37a… Patch: https://github.com/kamailio/kamailio/commit/8c5b92ee638a33e612e68cf85a1d37a… --- diff --git a/src/core/cfg.y b/src/core/cfg.y index 56a8c9ab8c..394386bb1b 100644 --- a/src/core/cfg.y +++ b/src/core/cfg.y @@ -134,21 +134,21 @@ extern char* yy_number_str; static void yyerror(char* s, ...); static void yyerror_at(struct cfg_pos* pos, char* s, ...); -static char* tmp; -static int i_tmp; -static struct socket_id* lst_tmp; -static struct name_lst* nl_tmp; -static int rt; /* Type of route block for find_export */ -static str* str_tmp; -static str s_tmp; -static struct ip_addr* ip_tmp; -static struct avp_spec* s_attr; +static char* tmp = NULL; +static int i_tmp = 0; +static struct socket_id* lst_tmp = NULL; +static struct name_lst* nl_tmp = NULL; +static int rt = 0; /* Type of route block for find_export */ +static str* str_tmp = NULL; +static str s_tmp = STR_NULL; +static struct ip_addr* ip_tmp = NULL; +static struct avp_spec* s_attr = NULL; static select_t sel; -static select_t* sel_ptr; -static pv_spec_t* pv_spec; -static struct action *mod_func_action; -static struct lvalue* lval_tmp; -static struct rvalue* rval_tmp; +static select_t* sel_ptr = NULL; +static pv_spec_t* pv_spec = NULL; +static struct action *mod_func_action = NULL; +static struct lvalue* lval_tmp = NULL; +static struct rvalue* rval_tmp = NULL; static void warn(char* s, ...); static void warn_at(struct cfg_pos* pos, char* s, ...); @@ -165,7 +165,7 @@ static struct socket_id* mk_listen_id2(struct name_lst*, int, int); static void free_name_lst(struct name_lst* lst); static void free_socket_id_lst(struct socket_id* i); -static struct case_stms* mk_case_stm(struct rval_expr* ct, int is_re, +static struct case_stms* mk_case_stm(struct rval_expr* ct, int is_re, struct action* a, int* err); static int case_check_type(struct case_stms* stms); static int case_check_default(struct case_stms* stms);

1 0

git:master:a88cf96b: cdp: global variables declared extern in header file
by Daniel-Constantin Mierla 03 Mar '20

03 Mar '20

Module: kamailio Branch: master Commit: a88cf96b8ba3358c08e0e210f76320f6d7926b7d URL: https://github.com/kamailio/kamailio/commit/a88cf96b8ba3358c08e0e210f76320f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-03T10:34:02+01:00 cdp: global variables declared extern in header file --- Modified: src/modules/cdp/diameter_peer.h --- Diff: https://github.com/kamailio/kamailio/commit/a88cf96b8ba3358c08e0e210f76320f… Patch: https://github.com/kamailio/kamailio/commit/a88cf96b8ba3358c08e0e210f76320f… --- diff --git a/src/modules/cdp/diameter_peer.h b/src/modules/cdp/diameter_peer.h index 378a281dd5..f092f74ccc 100644 --- a/src/modules/cdp/diameter_peer.h +++ b/src/modules/cdp/diameter_peer.h @@ -65,10 +65,10 @@ typedef struct { pid_list_t *head,*tail; } pid_list_head_t; -pid_t *dp_first_pid; /**< first pid that we started from */ +extern pid_t *dp_first_pid; /**< first pid that we started from */ -pid_list_head_t *pid_list; /**< list of local processes */ -gen_lock_t *pid_list_lock; /**< lock for list of local processes */ +extern pid_list_head_t *pid_list; /**< list of local processes */ +extern gen_lock_t *pid_list_lock; /**< lock for list of local processes */ int diameter_peer_init_str(str config_str); int diameter_peer_init(char *cfg_filename);

1 0

git:master:16bc1515: sipcapture: declare extern heptime in hep.c and init it to null
by Daniel-Constantin Mierla 03 Mar '20

03 Mar '20

Module: kamailio Branch: master Commit: 16bc15156ecc8a8f4f66c44b064db854d0e3e4e0 URL: https://github.com/kamailio/kamailio/commit/16bc15156ecc8a8f4f66c44b064db85… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-03T09:11:59+01:00 sipcapture: declare extern heptime in hep.c and init it to null --- Modified: src/modules/sipcapture/hep.c Modified: src/modules/sipcapture/sipcapture.c --- Diff: https://github.com/kamailio/kamailio/commit/16bc15156ecc8a8f4f66c44b064db85… Patch: https://github.com/kamailio/kamailio/commit/16bc15156ecc8a8f4f66c44b064db85… --- diff --git a/src/modules/sipcapture/hep.c b/src/modules/sipcapture/hep.c index 7606241074..2934c2c0d2 100644 --- a/src/modules/sipcapture/hep.c +++ b/src/modules/sipcapture/hep.c @@ -37,7 +37,7 @@ static int count = 0; -struct hep_timeinfo *heptime; +extern struct hep_timeinfo *heptime; /* HEPv2 HEPv3 */ int hepv2_received(char *buf, unsigned int len, struct receive_info *ri); diff --git a/src/modules/sipcapture/sipcapture.c b/src/modules/sipcapture/sipcapture.c index 5da37cbde7..094d6ea168 100644 --- a/src/modules/sipcapture/sipcapture.c +++ b/src/modules/sipcapture/sipcapture.c @@ -294,7 +294,7 @@ enum hash_source source = hs_error; //unsigned int rr_idx = 0; -struct hep_timeinfo *heptime; +struct hep_timeinfo *heptime = NULL; /*! \brief * Exported functions

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2020