sr-dev November 2020

sr-dev@lists.kamailio.org

22 participants
311 discussions

git:master:eb8049fe: Merge pull request #2550 from amessina/master

by GitHub

Module: kamailio Branch: master Commit: eb8049fee6695744731b2c17735bf3d7788744ac URL: https://github.com/kamailio/kamailio/commit/eb8049fee6695744731b2c17735bf3d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2020-11-16T09:04:05+01:00 Merge pull request #2550 from amessina/master acc: docs - database column constraint alteration for acc_extra_nullaâ¦ --- Modified: src/modules/acc/doc/acc_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/eb8049fee6695744731b2c17735bf3d… Patch: https://github.com/kamailio/kamailio/commit/eb8049fee6695744731b2c17735bf3d… --- diff --git a/src/modules/acc/doc/acc_admin.xml b/src/modules/acc/doc/acc_admin.xml index d1c007312e..f88d403d2b 100644 --- a/src/modules/acc/doc/acc_admin.xml +++ b/src/modules/acc/doc/acc_admin.xml @@ -634,6 +634,10 @@ modparam("acc", "acc_prepare_always", 1) set to 0, the value is saved as empty string (the existing behavior). </para> <para> + Database columns may need to be altered to DROP NOT NULL constraints + and DROP DEFAULT values in order to accept NULL values. + </para> + <para> Default value is 0. </para> <example> @@ -1157,6 +1161,10 @@ modparam("acc", "cdr_extra", "c1=$dlg_var(caller);c2=$dlg_var(callee)" If set to 1, custom CDR fields not defined in config operation (or set to $null) will be saved as NULL. </para> <para> + Database columns may need to be altered to DROP NOT NULL constraints + and DROP DEFAULT values in order to accept NULL values. + </para> + <para> Default value is 0. </para> <example>

3 years, 5 months

[kamailio/kamailio] [RFE]: Allow NULL for acc db_extra and multi_leg_info (#2531)

by Anthony Messina

### Description  Just as in #1378, allowing nullable entries for SQL would be appreciated in acc `db_extra` and acc `multi_leg_info`. ### Expected behavior Empty/NULL values should be inserted with `NULL`. For example, I can't create a `timestamp without time zone` to be used with multi-leg-accounting as follows. ``` modparam("acc", "multi_leg_info", "leg_dst_user=$avp(leg_dst_user);" "leg_dst_domain=$avp(leg_dst_domain);" "leg_sip_code=$avp(leg_sip_code);" "leg_time=$avp(leg_time);" "leg_to_tag=$avp(leg_to_tag)") $avp(leg_time)=$timef(%F %T) ``` #### Actual observed behavior Emplty/NULL values are inserted with `''` which fails as `''` is invalid input for a `timestamp without time zone` column. #### Log Messages  ``` db_postgres [km_dbase.c:266]: db_postgres_submit_query(): 0x7f26f7fb6cc8 PQsendQuery Error: ERROR: invalid input syntax for type timestamp: "" ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` ersion: kamailio 5.4.1-8.gitd43872c11e.fc32.2 (x86_64/linux) 09fd6a flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 09fd6a compiled on 00:00:00 Oct 22 2020 with gcc 10.2.1 ``` * **Operating System**:  ``` Linux host 5.8.15-201.fc32.x86_64 #1 SMP Thu Oct 15 15:56:44 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2531

3 years, 5 months

[kamailio/kamailio] RR param static buffer not emptied, when using record_route_advertised_address() (#2486)

by thomas-lentz

### Description When specifying a _record_route_advertised_address()_ before using the uac_replace function (for changing the FROM and TO Header field URIs), the rr param static buffer doesn't get emptied and a fallowing CALL (not a request in the same call) contains the rr params of the first call placed after restarting kamailio (to get the buffer resetted). ### Troubleshooting Restarting kamailio will reset the wrong buffer pointer and gets you another functioning call. Alternatively place the _record_route_advertised_address()_ after using uac_replace function. #### Reproduction use record_route_advertised_address() before doing a uac_replace. This will get the vst and vsf parameters doubled in the rr of the second call after kamailio is restarted. When you place a call the first call proxied will carry only one set of vsf & vst parameters in the RR. The second call will carry the vst & vsf of the first call and a set of vst & vsf of the second call. If the uac_replace is replacing the same URIs the contents of the two sets of vsf and vst parameters in the RR Header will be identical. uac.so config: loadmodule "uac.so" modparam("uac", "restore_mode","auto"); #### Analysis record_route() empties the RR param static buffer as follows, if it contains other message's params: if (rr_param_buf.len && rr_param_msg!=_m->id) { /* rr_params were set for a different message -> reset buffer */ rr_param_buf.len = 0; } But unfortunately, record_route_advertised_address() / record_route_preset() does not do this – it does NOT check/clean the buffer before adding RR. So if the static buffer contains old entries (e.g. from an old call's subsequent request), wrong rr parameters are added. This happens with uac module: restore_uri() is called for subsequent requests (via callback). restore_uri() calls (unnecessarily): if ( uac_rrb.add_rr_param(msg, &add_to_rr)!=0 ) { LM_ERR("add rr param failed\n"); goto failed; } So, if record_route has not yet been performed at this stage, add_rr_param() adds an entry to the static rr param buffer. (for subsequent request, record_route won't be performed) If, for a following call, record_route_advertised_address() / record_route_preset() is called, the buffer is not checked/emptied, and old/wrong rr params are added.--> ``` #### SIP Traffic ``` Record-Route URI [truncated]: sip:my.node.com;transport=tls;r2=on;ftag=2ccb63ad;lr;vsf=AAAAAAAAAAAAAAAAAAAAADkIA0Mdsdfsdfhc2guY29tO3VzZXI9cGhvN0LmNvbQbmU-;vst=AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAMQEEEESwksdfsdfhddCBteAgccAQN0LmNvbQ- Record-Route Host Part: my.node.com Record-Route URI parameter: transport=tls Record-Route URI parameter: r2=on Record-Route URI parameter: ftag=2ccb63ad Record-Route URI parameter: lr Record-Route URI parameter: vsf=AAAAAAAAAAAAAAAAAAAAADkIA0Mdsdfsdfhc2guY29tO3VzZXI9cGhvN0LmNvbQbmU- Record-Route URI parameter: vst=AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAMQEEEESwksdfsdfhddCBteAgccAQN0LmNvbQ-- Record-Route URI parameter: vst=AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAMQEEEESwksdfsdfhddCBteAgccAQN0LmNvbQ-- Record-Route URI parameter: vsf=AAAAAAAAAAAAAAAAAAAAADkIA0Mdsdfsdfhc2guY29tO3VzZXI9cGhvN0LmNvbQbmU- Record-Route URI parameter: did=4a8.56a2 URI, vsf & vst anonymised ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.2.7 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 8.3.0 ``` * **Operating System**: ``` 4.19.0-10-amd64 #1 SMP Debian 4.19.132-1 (2020-07-24) x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2486

3 years, 6 months

git:master:03a1454c: sipsecid: docs - fix sections id prefix

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 03a1454c4bfef67ef214c13bffd02a0b4e4688e1 URL: https://github.com/kamailio/kamailio/commit/03a1454c4bfef67ef214c13bffd02a0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-11-12T17:38:08+01:00 sipsecid: docs - fix sections id prefix --- Modified: src/modules/secsipid/doc/secsipid_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/03a1454c4bfef67ef214c13bffd02a0… Patch: https://github.com/kamailio/kamailio/commit/03a1454c4bfef67ef214c13bffd02a0… --- diff --git a/src/modules/secsipid/doc/secsipid_admin.xml b/src/modules/secsipid/doc/secsipid_admin.xml index ca87f563b0..8f0a3d48db 100644 --- a/src/modules/secsipid/doc/secsipid_admin.xml +++ b/src/modules/secsipid/doc/secsipid_admin.xml @@ -140,7 +140,7 @@ modparam("secsipid", "cache_expire", 7200) <section> <title>Functions</title> - <section id="async.f.secsipid_check_identity"> + <section id="secsipid.f.secsipid_check_identity"> <title> <function moreinfo="none">secsipid_check_identity(keyPath)</function> </title> @@ -179,7 +179,7 @@ request_route { together with jansson module. </para> </section> - <section id="async.f.secsipid_add_identity"> + <section id="secsipid.f.secsipid_add_identity"> <title> <function moreinfo="none">secsipid_add_identity(origTN, destTN, attest, origID, x5u, keyPath)</function> </title> @@ -212,7 +212,7 @@ request_route { </example> </section> </section> - <section> + <section id="secsipid.s.installation"> <title>Installation</title> <para> The module depends on "libsecsipid", which is a component of "sipsecidx"

3 years, 6 months

git:master:8c160558: modules: readme files regenerated - secsipid ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 8c16055853a697d1a13ef760da06a30544dc4fd8 URL: https://github.com/kamailio/kamailio/commit/8c16055853a697d1a13ef760da06a30… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-11-12T14:46:14+01:00 modules: readme files regenerated - secsipid ... [skip ci] --- Modified: src/modules/secsipid/README --- Diff: https://github.com/kamailio/kamailio/commit/8c16055853a697d1a13ef760da06a30… Patch: https://github.com/kamailio/kamailio/commit/8c16055853a697d1a13ef760da06a30… --- diff --git a/src/modules/secsipid/README b/src/modules/secsipid/README index a58d511078..a65afcf78e 100644 --- a/src/modules/secsipid/README +++ b/src/modules/secsipid/README @@ -28,6 +28,8 @@ Daniel-Constantin Mierla 3.1. expire (int) 3.2. timeout (int) + 3.3. cache_dir (str) + 3.4. cache_expire (int) 4. Functions @@ -41,9 +43,11 @@ Daniel-Constantin Mierla 1.1. Set expire parameter 1.2. Set timeout parameter - 1.3. secsipid_check_identity usage - 1.4. secsipid_add_identity usage - 1.5. Libsecsipid usage + 1.3. Set cache_dir parameter + 1.4. Set cache_expire parameter + 1.5. secsipid_check_identity usage + 1.6. secsipid_add_identity usage + 1.7. Libsecsipid usage Chapter 1. Admin Guide @@ -59,6 +63,8 @@ Chapter 1. Admin Guide 3.1. expire (int) 3.2. timeout (int) + 3.3. cache_dir (str) + 3.4. cache_expire (int) 4. Functions @@ -95,6 +101,8 @@ Chapter 1. Admin Guide 3.1. expire (int) 3.2. timeout (int) + 3.3. cache_dir (str) + 3.4. cache_expire (int) 3.1. expire (int) @@ -120,6 +128,30 @@ modparam("secsipid", "expire", 600) modparam("secsipid", "timeout", 2) ... +3.3. cache_dir (str) + + The path to the directory where to save cached pyblic keys. If set, it + activates the public key file caching in the libsecsipid library. + + Default value is "". + + Example 1.3. Set cache_dir parameter +... +modparam("secsipid", "cache_dir", "/tmp/kamailio/secsipid") +... + +3.4. cache_expire (int) + + The interval in seconds after which a cached public key is considered + expired. This value is passed to the libsecsipid library. + + Default value is 3600. + + Example 1.4. Set cache_expire parameter +... +modparam("secsipid", "cache_expire", 7200) +... + 4. Functions 4.1. secsipid_check_identity(keyPath) @@ -139,7 +171,7 @@ modparam("secsipid", "timeout", 2) This function can be used from ANY_ROUTE. - Example 1.3. secsipid_check_identity usage + Example 1.5. secsipid_check_identity usage ... request_route { ... @@ -168,7 +200,7 @@ request_route { This function can be used from ANY_ROUTE. - Example 1.4. secsipid_add_identity usage + Example 1.6. secsipid_add_identity usage ... request_route { ... @@ -192,7 +224,7 @@ request_route { installed and its environment configured, then run the following commands: - Example 1.5. Libsecsipid usage + Example 1.7. Libsecsipid usage ... go get https://github.com/asipto/secsipidx cd $GOPATH/src/github.com/asipto/secsipidx/csecsipid/

3 years, 6 months

git:master:40cd54b2: secsipid: docs for cache parameters

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 40cd54b2853667c0143ff96ae899991e6fdd30dc URL: https://github.com/kamailio/kamailio/commit/40cd54b2853667c0143ff96ae899991… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-11-12T14:39:05+01:00 secsipid: docs for cache parameters --- Modified: src/modules/secsipid/doc/secsipid_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/40cd54b2853667c0143ff96ae899991… Patch: https://github.com/kamailio/kamailio/commit/40cd54b2853667c0143ff96ae899991… --- diff --git a/src/modules/secsipid/doc/secsipid_admin.xml b/src/modules/secsipid/doc/secsipid_admin.xml index 510da9159d..ca87f563b0 100644 --- a/src/modules/secsipid/doc/secsipid_admin.xml +++ b/src/modules/secsipid/doc/secsipid_admin.xml @@ -92,6 +92,46 @@ modparam("secsipid", "expire", 600) ... modparam("secsipid", "timeout", 2) ... +</programlisting> + </example> + </section> + <section> + <title><varname>cache_dir</varname> (str)</title> + <para> + The path to the directory where to save cached pyblic keys. If set, + it activates the public key file caching in the libsecsipid library. + </para> + <para> + <emphasis> + Default value is "". + </emphasis> + </para> + <example> + <title>Set <varname>cache_dir</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("secsipid", "cache_dir", "/tmp/kamailio/secsipid") +... +</programlisting> + </example> + </section> + <section> + <title><varname>cache_expire</varname> (int)</title> + <para> + The interval in seconds after which a cached public key is considered + expired. This value is passed to the libsecsipid library. + </para> + <para> + <emphasis> + Default value is 3600. + </emphasis> + </para> + <example> + <title>Set <varname>cache_expire</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("secsipid", "cache_expire", 7200) +... </programlisting> </example> </section>

3 years, 6 months

git:master:cac73df6: secsipid: added modparams to set url file cache options

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: cac73df6e2f90b6f6d8c051fb1e65c2d9ae01e0f URL: https://github.com/kamailio/kamailio/commit/cac73df6e2f90b6f6d8c051fb1e65c2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-11-12T13:18:06+01:00 secsipid: added modparams to set url file cache options --- Modified: src/modules/secsipid/libsecsipid.h Modified: src/modules/secsipid/secsipid_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/cac73df6e2f90b6f6d8c051fb1e65c2… Patch: https://github.com/kamailio/kamailio/commit/cac73df6e2f90b6f6d8c051fb1e65c2… --- diff --git a/src/modules/secsipid/libsecsipid.h b/src/modules/secsipid/libsecsipid.h index 77cddcb5af..952e480e85 100644 --- a/src/modules/secsipid/libsecsipid.h +++ b/src/modules/secsipid/libsecsipid.h @@ -70,20 +70,19 @@ extern "C" { // SecSIPIDSignJSONHP -- - -extern int SecSIPIDSignJSONHP(char* p0, char* p1, char* p2, char** p3); +extern int SecSIPIDSignJSONHP(char* headerJSON, char* payloadJSON, char* prvkeyPath, char** outPtr); // SecSIPIDGetIdentity -- - -extern int SecSIPIDGetIdentity(char* p0, char* p1, char* p2, char* p3, char* p4, char* p5, char** p6); +extern int SecSIPIDGetIdentity(char* origTN, char* destTN, char* attestVal, char* origID, char* x5uVal, char* prvkeyPath, char** outPtr); // SecSIPIDCheck -- - -extern int SecSIPIDCheck(char* p0, int p1, int p2, char* p3, int p4); +extern int SecSIPIDCheck(char* identityVal, int identityLen, int expireVal, char* pubkeyPath, int timeoutVal); // SecSIPIDCheckFull -- +extern int SecSIPIDCheckFull(char* identityVal, int identityLen, int expireVal, char* pubkeyPath, int timeoutVal); -extern int SecSIPIDCheckFull(char* p0, int p1, int p2, char* p3, int p4); +// SecSIPIDSetFileCacheOptions -- +extern int SecSIPIDSetFileCacheOptions(char* dirPath, int expireVal); #ifdef __cplusplus } diff --git a/src/modules/secsipid/secsipid_mod.c b/src/modules/secsipid/secsipid_mod.c index d3ad1c896e..bd757b173d 100644 --- a/src/modules/secsipid/secsipid_mod.c +++ b/src/modules/secsipid/secsipid_mod.c @@ -38,6 +38,9 @@ MODULE_VERSION static int secsipid_expire = 300; static int secsipid_timeout = 5; +static int secsipid_cache_expire = 3600; +static str secsipid_cache_dir = str_init(""); + static int mod_init(void); static int child_init(int); static void mod_destroy(void); @@ -57,8 +60,10 @@ static cmd_export_t cmds[]={ }; static param_export_t params[]={ - {"expire", PARAM_INT, &secsipid_expire}, - {"timeout", PARAM_INT, &secsipid_timeout}, + {"expire", PARAM_INT, &secsipid_expire}, + {"timeout", PARAM_INT, &secsipid_timeout}, + {"cache_expire", PARAM_INT, &secsipid_cache_expire}, + {"cache_dir", PARAM_STR, &secsipid_cache_dir}, {0, 0, 0} }; @@ -127,6 +132,9 @@ static int ki_secsipid_check_identity(sip_msg_t *msg, str *keypath) ibody = hf->body; + if(secsipid_cache_dir.len > 0) { + SecSIPIDSetFileCacheOptions(secsipid_cache_dir.s, secsipid_cache_expire); + } ret = SecSIPIDCheckFull(ibody.s, ibody.len, secsipid_expire, keypath->s, secsipid_timeout); @@ -281,4 +289,4 @@ int mod_register(char *path, int *dlflags, void *p1, void *p2) { sr_kemi_modules_add(sr_kemi_secsipid_exports); return 0; -} \ No newline at end of file +}

3 years, 6 months

[kamailio/kamailio] NATHELPER: fix_nated_sdp does not support a=rtcp headers (#2459)

by Olle E. Johansson

3 years, 6 months

[kamailio/kamailio] some build warnings (#2543)

by sergey-safarov

**1** ``` CC (gcc) [kamailio] core/dst_blocklist.o CC (gcc) [kamailio] core/endianness.o CC (gcc) [kamailio] core/error.o core/dns_cache.c: In function 'dns_sip_resolve': core/dns_cache.c:3303:19: warning: 'origproto' may be used uninitialized in this function [-Wmaybe-uninitialized] 3303 | if(proto) *proto=origproto; | ~~~~~~^~~~~~~~~~ core/dns_cache.c:3257:16: note: 'origproto' was declared here 3257 | char n_proto, origproto; | ^~~~~~~~~ CC (gcc) [kamailio] core/events.o CC (gcc) [kamailio] core/flags.o CC (gcc) [kamailio] core/fmsg.o CC (gcc) [kamailio] core/forward.o CC (gcc) [kamailio] core/hash_func.o ``` **2** ``` CC (gcc) [M crypto.so] api.o CC (gcc) [M crypto.so] crypto_aes.o CC (gcc) [M crypto.so] crypto_evcb.o CC (gcc) [M crypto.so] crypto_mod.o crypto_mod.c: In function 'ki_crypto_hmac_sha256_helper': crypto_mod.c:316:29: warning: pointer targets in passing argument 1 of 'base64url_enc' differ in signedness [-Wpointer-sign] 316 | val.rs.len = base64url_enc((unsigned char *)digest, digest_len, (unsigned char *)val.rs.s, pv_get_buffer_size()-1); | ^~~~~~~~~~~~~~~~~~~~~~~ | | | unsigned char * In file included from crypto_mod.c:33: ../../core/basex.h:867:25: note: expected 'char *' but argument is of type 'unsigned char *' 867 | int base64url_enc(char *in, int ilen, char *out, int osize); | ~~~~~~^~ crypto_mod.c:316:66: warning: pointer targets in passing argument 3 of 'base64url_enc' differ in signedness [-Wpointer-sign] 316 | val.rs.len = base64url_enc((unsigned char *)digest, digest_len, (unsigned char *)val.rs.s, pv_get_buffer_size()-1); | ^~~~~~~~~~~~~~~~~~~~~~~~~ | | | unsigned char * In file included from crypto_mod.c:33: ../../core/basex.h:867:45: note: expected 'char *' but argument is of type 'unsigned char *' 867 | int base64url_enc(char *in, int ilen, char *out, int osize); | ~~~~~~^~~ At top level: crypto_mod.c:343:12: warning: 'ki_crypto_hmac_sha256' defined but not used [-Wunused-function] 343 | static int ki_crypto_hmac_sha256(sip_msg_t* msg, str *ins, str *keys, str *dpv) | ^~~~~~~~~~~~~~~~~~~~~ CC (gcc) [M crypto.so] crypto_uuid.o LD (gcc) [M crypto.so] crypto.so ``` **3** ``` LD (gcc) [M janssonrpcc.so] janssonrpcc.so CC (gcc) [M http_async_client.so] async_http.o CC (gcc) [M http_async_client.so] hm_hash.o In file included from http_multi.h:40, from async_http.h:48, from async_http.c:53: /usr/include/sys/poll.h:1:2: warning: #warning redirecting incorrect #include <sys/poll.h> to <poll.h> [-Wcpp] 1 | #warning redirecting incorrect #include <sys/poll.h> to <poll.h> | ^~~~~~~ CC (gcc) [M http_async_client.so] http_async_client_mod.o In file included from http_multi.h:40, from async_http.h:48, from http_async_client_mod.c:59: /usr/include/sys/poll.h:1:2: warning: #warning redirecting incorrect #include <sys/poll.h> to <poll.h> [-Wcpp] 1 | #warning redirecting incorrect #include <sys/poll.h> to <poll.h> | ^~~~~~~ CC (gcc) [M http_async_client.so] http_multi.o In file included from http_multi.h:40, from http_multi.c:35: /usr/include/sys/poll.h:1:2: warning: #warning redirecting incorrect #include <sys/poll.h> to <poll.h> [-Wcpp] 1 | #warning redirecting incorrect #include <sys/poll.h> to <poll.h> | ^~~~~~~ LD (gcc) [M http_async_client.so] http_async_client.so CC (gcc) [M kazoo.so] const.o CC (gcc) [M kazoo.so] kazoo.o CC (gcc) [M kazoo.so] kz_amqp.o ``` **4** ``` CC (gcc) [M sctp.so] sctp_rpc.o CC (gcc) [M sctp.so] sctp_server.o CC (gcc) [M sctp.so] sctp_stats.o sctp_server.c: In function 'sctp_handle_notification': sctp_server.c:2314:48: warning: taking address of packed member of 'struct sctp_paddr_change' may result in an unaligned pointer value [-Waddress-of-packed-member] 2314 | strcpy(su_buf, su2a((union sockaddr_union *)&snp->sn_paddr_change | ^~~~~~~~~~~~~~~~~~~~~ 2315 | .spc_aaddr, | ~~~~~~~~~~ LD (gcc) [M sctp.so] sctp.so CC (gcc) [M acc_radius.so] acc_radius_mod.o LD (gcc) [M acc_radius.so] acc_radius.so CC (gcc) [M auth_radius.so] auth_radius.o ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2543

3 years, 6 months

git:master:3f47038f: tm: update local via if internal flags are set for local request

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 3f47038f3feaf13d080da289ecd39d9e37786ec3 URL: https://github.com/kamailio/kamailio/commit/3f47038f3feaf13d080da289ecd39d9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-11-12T09:33:11+01:00 tm: update local via if internal flags are set for local request --- Modified: src/modules/tm/uac.c --- Diff: https://github.com/kamailio/kamailio/commit/3f47038f3feaf13d080da289ecd39d9… Patch: https://github.com/kamailio/kamailio/commit/3f47038f3feaf13d080da289ecd39d9… --- diff --git a/src/modules/tm/uac.c b/src/modules/tm/uac.c index f8cee24a6a..d01c722844 100644 --- a/src/modules/tm/uac.c +++ b/src/modules/tm/uac.c @@ -305,16 +305,20 @@ static inline int t_run_local_req( setsflagsval(sflag_bk); if (unlikely(ra_ctx.run_flags&DROP_R_F)) { - LM_DBG("tm:local-request dropped msg. to %.*s\n", + LM_DBG("tm:local-request dropped msg. to %.*s\n", lreq.dst_uri.len, lreq.dst_uri.s); refresh_shortcuts = E_DROP; goto clean; } + /* rebuild the new message content */ - if(lreq.force_send_socket != uac_r->dialog->send_sock) { - LM_DBG("Send socket updated to: %.*s", + if((lreq.force_send_socket != uac_r->dialog->send_sock) + || (lreq.msg_flags&(FL_ADD_LOCAL_RPORT|FL_ADD_SRVID + |FL_ADD_XAVP_VIA_PARAMS|FL_USE_XAVP_VIA_FIELDS))) { + LM_DBG("local Via update - socket: [%.*s] - msg-flags: %u", lreq.force_send_socket->address_str.len, - lreq.force_send_socket->address_str.s); + lreq.force_send_socket->address_str.s, + lreq.msg_flags); /* rebuild local Via - remove previous value * and add the one for the new send socket */

3 years, 6 months

← Newer
1
...
19
20
21
22
23
24
25
...
32
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2020