sr-dev October 2020

sr-dev@lists.kamailio.org

19 participants
526 discussions

git:master:46e73449: Fix typo on cplc module: Consecutives 'the'

by Henning Westerholt

Module: kamailio Branch: master Commit: 46e73449d52df3e7af2cb6dd631bc42c61ceed35 URL: https://github.com/kamailio/kamailio/commit/46e73449d52df3e7af2cb6dd631bc42… Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-10-02T15:48:22+02:00 Fix typo on cplc module: Consecutives 'the' --- Modified: src/modules/cplc/doc/cplc_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/46e73449d52df3e7af2cb6dd631bc42… Patch: https://github.com/kamailio/kamailio/commit/46e73449d52df3e7af2cb6dd631bc42… --- diff --git a/src/modules/cplc/doc/cplc_admin.xml b/src/modules/cplc/doc/cplc_admin.xml index 0c9f15b62e..d83b9271a8 100644 --- a/src/modules/cplc/doc/cplc_admin.xml +++ b/src/modules/cplc/doc/cplc_admin.xml @@ -175,7 +175,7 @@ modparam("cpl-c","domain_column","domain") <title><varname>cpl_xml_column</varname> (string)</title> <para> Indicates the name of the column used for storing the - the XML version of the cpl script. + XML version of the cpl script. </para> <para> <emphasis> @@ -195,7 +195,7 @@ modparam("cpl-c","cpl_xml_column","cpl_xml") <title><varname>cpl_bin_column</varname> (string)</title> <para> Indicates the name of the column used for storing the - the binary version of the cpl script (compiled version). + binary version of the cpl script (compiled version). </para> <para> <emphasis>

3 years, 7 months

git:master:14e3e485: Fix typo on counters module: Consecutives 'the'

by Henning Westerholt

Module: kamailio Branch: master Commit: 14e3e4859987ffb39d885d3f075cb4bc200fa748 URL: https://github.com/kamailio/kamailio/commit/14e3e4859987ffb39d885d3f075cb4b… Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-10-02T15:48:22+02:00 Fix typo on counters module: Consecutives 'the' --- Modified: src/modules/counters/counters.c --- Diff: https://github.com/kamailio/kamailio/commit/14e3e4859987ffb39d885d3f075cb4b… Patch: https://github.com/kamailio/kamailio/commit/14e3e4859987ffb39d885d3f075cb4b… --- diff --git a/src/modules/counters/counters.c b/src/modules/counters/counters.c index 5ddbac3e68..696bc0be35 100644 --- a/src/modules/counters/counters.c +++ b/src/modules/counters/counters.c @@ -132,7 +132,7 @@ struct module_exports exports = { -/** parse the the script_counter modparam. +/** parse the script_counter modparam. * Format: [grp.]name[( |:)desc] * E.g.: * "name" => new counter: *cnt_script_grp."name" @@ -554,4 +554,4 @@ int mod_register(char *path, int *dlflags, void *p1, void *p2) return 0; } -/* vi: set ts=4 sw=4 tw=79:ai:cindent: */ \ No newline at end of file +/* vi: set ts=4 sw=4 tw=79:ai:cindent: */

3 years, 7 months

git:master:8e78b771: Fix typo on carrierroute module: Consecutives 'the'

by Henning Westerholt

Module: kamailio Branch: master Commit: 8e78b771e5bc8a1be2b8c0fe4d5448e66b2dc596 URL: https://github.com/kamailio/kamailio/commit/8e78b771e5bc8a1be2b8c0fe4d5448e… Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-10-02T15:48:22+02:00 Fix typo on carrierroute module: Consecutives 'the' --- Modified: src/modules/carrierroute/doc/carrierroute_db.xml --- Diff: https://github.com/kamailio/kamailio/commit/8e78b771e5bc8a1be2b8c0fe4d5448e… Patch: https://github.com/kamailio/kamailio/commit/8e78b771e5bc8a1be2b8c0fe4d5448e… --- diff --git a/src/modules/carrierroute/doc/carrierroute_db.xml b/src/modules/carrierroute/doc/carrierroute_db.xml index cc88b19887..f755d08a40 100644 --- a/src/modules/carrierroute/doc/carrierroute_db.xml +++ b/src/modules/carrierroute/doc/carrierroute_db.xml @@ -273,7 +273,7 @@ modparam("carrierroute", "carrierfailureroute_domain_col", "domain") </section> <section> <title><varname>carrierfailureroute_scan_prefix_col</varname> (string)</title> - <para>Name of column contains the the scan prefixes. Scan prefixes define the matching + <para>Name of column contains the scan prefixes. Scan prefixes define the matching portion of a phone number, e.g. we have the scan prefixes 49721 and 49, the called number is 49721913740, it matches 49721, because the longest match is taken. If no prefix matches, the number is not failure routed. To prevent this, an empty prefix value of

3 years, 7 months

git:master:8b9fa160: Fix typo on avp module: Consecutives 'the'

by Henning Westerholt

Module: kamailio Branch: master Commit: 8b9fa1605823086e2e9aa35ed90ffa0d4b34236f URL: https://github.com/kamailio/kamailio/commit/8b9fa1605823086e2e9aa35ed90ffa0… Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-10-02T15:48:22+02:00 Fix typo on avp module: Consecutives 'the' --- Modified: src/modules/avp/avp.xml --- Diff: https://github.com/kamailio/kamailio/commit/8b9fa1605823086e2e9aa35ed90ffa0… Patch: https://github.com/kamailio/kamailio/commit/8b9fa1605823086e2e9aa35ed90ffa0… --- diff --git a/src/modules/avp/avp.xml b/src/modules/avp/avp.xml index 93fdea7fc6..fa47e88cb2 100644 --- a/src/modules/avp/avp.xml +++ b/src/modules/avp/avp.xml @@ -168,7 +168,7 @@ <para> The <function>attr_equals()</function> function checks whether the attribute identified by the argument <symbol>attribute</symbol> - exists and its value is identical the the value given by the + exists and its value is identical the value given by the argument <symbol>value</symbol>. If so, it returns <literal>true</literal> and <literal>false</literal> otherwise. </para>

3 years, 7 months

git:master:21add720: Fix typo on app_jsdt module: Consecutives 'the'

by Henning Westerholt

Module: kamailio Branch: master Commit: 21add7206554d47023da9565345f7889016dc8c8 URL: https://github.com/kamailio/kamailio/commit/21add7206554d47023da9565345f788… Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-10-02T15:48:22+02:00 Fix typo on app_jsdt module: Consecutives 'the' --- Modified: src/modules/app_jsdt/duktape.c --- Diff: https://github.com/kamailio/kamailio/commit/21add7206554d47023da9565345f788… Patch: https://github.com/kamailio/kamailio/commit/21add7206554d47023da9565345f788… --- diff --git a/src/modules/app_jsdt/duktape.c b/src/modules/app_jsdt/duktape.c index 366883c533..9e05804065 100644 --- a/src/modules/app_jsdt/duktape.c +++ b/src/modules/app_jsdt/duktape.c @@ -20026,7 +20026,7 @@ DUK_EXTERNAL void *duk_require_buffer(duk_hthread *thr, duk_idx_t idx, duk_size_ } /* Get the active buffer data area for a plain buffer or a buffer object. - * Return NULL if the the value is not a buffer. Note that a buffer may + * Return NULL if the value is not a buffer. Note that a buffer may * have a NULL data pointer when its size is zero, the optional 'out_isbuffer' * argument allows caller to detect this reliably. */ @@ -56844,7 +56844,7 @@ DUK_INTERNAL duk_uint_fast32_t duk_hobject_pc2line_query(duk_hthread *thr, duk_i * duk_tval copies is not problematic with respect to side effects; * care must be taken when holding and using argument duk_tval pointers. * - * - If a finalizer is executed, it may operate on the the same object + * - If a finalizer is executed, it may operate on the same object * we're currently dealing with. For instance, the finalizer might * delete a certain property which has already been looked up and * confirmed to exist. Ideally finalizers would be disabled if GC

3 years, 7 months

git:master:f603f9da: Fix typo on srdb1 lib: Consecutive 'the'

by Henning Westerholt

Module: kamailio Branch: master Commit: f603f9dac139e09d6877ab199d02ed784234d6f0 URL: https://github.com/kamailio/kamailio/commit/f603f9dac139e09d6877ab199d02ed7… Author: Jorge Vallecillo <jorgevallecilloc(a)gmail.com> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-10-02T15:48:22+02:00 Fix typo on srdb1 lib: Consecutive 'the' --- Modified: src/lib/srdb1/schema/carrierfailureroute.xml --- Diff: https://github.com/kamailio/kamailio/commit/f603f9dac139e09d6877ab199d02ed7… Patch: https://github.com/kamailio/kamailio/commit/f603f9dac139e09d6877ab199d02ed7… --- diff --git a/src/lib/srdb1/schema/carrierfailureroute.xml b/src/lib/srdb1/schema/carrierfailureroute.xml index 2de707c59f..58a05e7865 100644 --- a/src/lib/srdb1/schema/carrierfailureroute.xml +++ b/src/lib/srdb1/schema/carrierfailureroute.xml @@ -59,7 +59,7 @@ <type>string</type> <size>&user_len;</size> <default/> - <description>Name of column contains the the scan prefixes. Scan prefixes define the matching + <description>Name of column contains the scan prefixes. Scan prefixes define the matching portion of a phone number, e.g. we have the scan prefixes 49721 and 49, the called number is 49721913740, it matches 49721, because the longest match is taken. If no prefix matches, the number is not failure routed. To prevent this, an empty prefix value of <quote></quote>

3 years, 7 months

git:5.2:b75d88fb: Changelog: fix wrong date (year) for last releases

by Henning Westerholt

Module: kamailio Branch: 5.2 Commit: b75d88fba00948bd4ff48f07ebd53c9ab4df18d9 URL: https://github.com/kamailio/kamailio/commit/b75d88fba00948bd4ff48f07ebd53c9… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-10-02T13:35:21Z Changelog: fix wrong date (year) for last releases --- Modified: ChangeLog --- Diff: https://github.com/kamailio/kamailio/commit/b75d88fba00948bd4ff48f07ebd53c9… Patch: https://github.com/kamailio/kamailio/commit/b75d88fba00948bd4ff48f07ebd53c9… --- diff --git a/ChangeLog b/ChangeLog index b763274d80..eab369de04 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,4 +1,4 @@ -===================== 2019-05-13 Version 5.2.7 Released ===================== +===================== 2020-05-13 Version 5.2.7 Released ===================== ===================== Changes Since Version 5.2.6 =========================== @@ -1906,7 +1906,7 @@ Date: Thu Nov 21 17:12:37 2019 +0300 (cherry picked from commit 6677dfdba3534a0f50c15fe5b43b8220444b18ad) -===================== 2019-01-24 Version 5.2.6 Released ===================== +===================== 2020-01-24 Version 5.2.6 Released ===================== ===================== Changes Since Version 5.2.5 ===========================

3 years, 7 months

Releasing Kamailio 5.2.8

by Henning Westerholt

Hello, I am planning to release next week (likely on Friday 2nd October) the next minor version out of branch 5.2, version 5.2.8. Backports of fixed issues from git master will be integrated as usual. If you are aware of new issues which were not yet reported, let us know (by creating an issue on the tracker). Unless major regressions are discovered after the release, this will be the last release of the 5.2 stable branch. The current stable branches 5.3 and 5.4 will continue to be maintained. Cheers, Henning -- Henning Westerholt - https://skalatan.de/blog/ Kamailio services - https://gilawa.com<https://gilawa.com/>

3 years, 7 months

[kamailio/kamailio] TOPOS not handling change of to-tag in provisional responses (#2489)

by James Brown

### Description TOPOS Module is not handling change of to-tags in provisional responses. When the B party sends two provisional responses (to an INVITE) with different to tags, a subsequent PRACK does not get handled/routed correctly. In this deployment, dbtext is used. ### Troubleshooting The TOPOS module is enabled in kamailio 5.3.6. ``` A1 Kamailio B1 INVITE --> <-- 100 INVITE --> <-- 100 <-- 180 (to-tag = randomtag20354) <-- 180 (to-tag = randomtag20354) <-- 183 (to-tag = randomtag20354DAE) <-- 183 (to-tag = randomtag20354DAE) PRACK (to-tag = randomtag20354DAE) --> <-- 403 PRACK ``` The 180-Ringing response does not have a Require header field with 100rel, but the 183-Session-Progress response does have `Require:100rel` in it. When the A1 sends the PRACK request, the to-tag matches that in the 183-Session-Progress response, but the TOPOS module does not decode the message. Then, when kamailio processes this PRACK request, it does not have the expected Route header fields or expected RURI and cannot be routed to B1 (so a 403 response happens). #### Reproduction - enable TOPOS module with text database and apply it to all transactions - make an INVITE through the proxy, with `Supported:100rel` - send a 180-Ringing response from the B party - send a 183-Session-Progress response from the B party, with `Require:100rel` and a different to-tag - watch the PRACK request fail #### Debugging Data ``` I can provide debugging data later. ``` #### Log Messages ``` I can provide logging data later. ``` #### SIP Traffic  ``` https://pastebin.com/XEf2Ndh2 ``` ### Possible Solutions Unknown  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.3.6 (x86_64/linux) bf6c08 flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: bf6c08 compiled on 09:57:03 Sep 10 2020 with gcc 8.3.0 ``` * **Operating System**: ``` Debian 10.4 in docker 4.15.0-51-generic Client: Docker Engine - Community Version: 19.03.5 API version: 1.40 Go version: go1.12.12 Git commit: 633a0ea838 Built: Wed Nov 13 07:29:52 2019 OS/Arch: linux/amd64 Experimental: false Server: Docker Engine - Community Engine: Version: 19.03.5 API version: 1.40 (minimum version 1.12) Go version: go1.12.12 Git commit: 633a0ea838 Built: Wed Nov 13 07:28:22 2019 OS/Arch: linux/amd64 Experimental: false containerd: Version: 1.2.10 GitCommit: b34a5c8af56e510852c35414db4c1f4fa6172339 runc: Version: 1.0.0-rc8+dev GitCommit: 3e425f80a8c931f88e6d94a8c831b9d5aa481657 docker-init: Version: 0.18.0 GitCommit: fec3683 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2489

3 years, 7 months

git:5.2:2e4fce40: topos: update to-tag and rr on reply even to-tag is already set

by Henning Westerholt

Module: kamailio Branch: 5.2 Commit: 2e4fce406eab4b4ee780381755af17005b172c4e URL: https://github.com/kamailio/kamailio/commit/2e4fce406eab4b4ee780381755af170… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-10-01T17:21:37Z topos: update to-tag and rr on reply even to-tag is already set - GH #2489 (cherry picked from commit acd7f6f1703d12aa8f2dce87e1b8e4b74d6b4d96) --- Modified: src/modules/topos/tps_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/2e4fce406eab4b4ee780381755af170… Patch: https://github.com/kamailio/kamailio/commit/2e4fce406eab4b4ee780381755af170… --- diff --git a/src/modules/topos/tps_storage.c b/src/modules/topos/tps_storage.c index 3bae45ec13..a4e6a6802b 100644 --- a/src/modules/topos/tps_storage.c +++ b/src/modules/topos/tps_storage.c @@ -1226,7 +1226,7 @@ int tps_db_update_branch(sip_msg_t *msg, tps_data_t *md, tps_data_t *sd, nr_keys = 0; nr_ucols = 0; - db_keys[nr_keys]=&td_col_a_uuid; + db_keys[nr_keys]=&tt_col_a_uuid; db_ops[nr_keys]=OP_EQ; db_vals[nr_keys].type = DB1_STR; db_vals[nr_keys].nul = 0; @@ -1249,8 +1249,7 @@ int tps_db_update_branch(sip_msg_t *msg, tps_data_t *md, tps_data_t *sd, } if((mode & TPS_DBU_RPLATTRS) && msg->first_line.type==SIP_REPLY) { - if(sd->b_tag.len<=0 - && msg->first_line.u.reply.statuscode>=180 + if(msg->first_line.u.reply.statuscode>=180 && msg->first_line.u.reply.statuscode<200) { db_ucols[nr_ucols] = &tt_col_y_rr;

3 years, 7 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2020