sr-dev May 2019

sr-dev@lists.kamailio.org

29 participants
308 discussions

still no fix to siptrace
by Juha Heinanen 07 May '19

07 May '19

siptrace module is still broken. would it be high time to revert back to 5.2 level and then make a new commit when the problem is fixed and fix properly tested? -- Juha

1 0

[kamailio/kamailio] Move not core modules to own packages (#1862)
by sergey-safarov 07 May '19

07 May '19

### Description Current kamailio package (checked via RPM) is contains lot of modules. Some of this is not important to include in every kamailio installation. May be create own packages for this modules and other in next 5.3 branch? Modules examples: ``` benchmark.so db_cluster.so db_text.so rtpengine.so rtpproxy.so sipcapture.so siptrace.so sipt.so sms.so smsops.so ss7ops.so ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1862

3 5

git:5.2:75f743d9: usrloc: udomain_contact_expired_cb fix memory leak
by Victor Seva 07 May '19

07 May '19

Module: kamailio Branch: 5.2 Commit: 75f743d9501faaead7a173c8f459d4b2adfcb41d URL: https://github.com/kamailio/kamailio/commit/75f743d9501faaead7a173c8f459d4b… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2019-05-07T09:29:45+02:00 usrloc: udomain_contact_expired_cb fix memory leak We need to call release_urecord in order to free the ucontacts generated at get_urecord() on shared memory (cherry picked from commit 48fd1a23cc3ddcb0df082bc24669dbf3a9fdc203) --- Modified: src/modules/usrloc/udomain.c --- Diff: https://github.com/kamailio/kamailio/commit/75f743d9501faaead7a173c8f459d4b… Patch: https://github.com/kamailio/kamailio/commit/75f743d9501faaead7a173c8f459d4b… --- diff --git a/src/modules/usrloc/udomain.c b/src/modules/usrloc/udomain.c index c28c881790..11378aadee 100644 --- a/src/modules/usrloc/udomain.c +++ b/src/modules/usrloc/udomain.c @@ -1019,7 +1019,7 @@ int udomain_contact_expired_cb(db1_con_t* _c, udomain_t* _d) if ( (c=mem_insert_ucontact(r, &contact, ci)) == 0) { LM_ERR("inserting contact failed\n"); - free_ucontact(c); + release_urecord(r); unlock_udomain(_d, &user); goto error; } @@ -1029,7 +1029,7 @@ int udomain_contact_expired_cb(db1_con_t* _c, udomain_t* _d) run_ul_callbacks( UL_CONTACT_EXPIRE, c); } c->state = CS_SYNC; - free_ucontact(c); + release_urecord(r); unlock_udomain(_d, &user); }

1 0

[kamailio/kamailio] usrloc: udomain_contact_expired_cb fix memory leak (#1947)
by Victor Seva 07 May '19

07 May '19

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [] Related to issue #XXXX (replace XXXX with an open issue number) #### Description 9757bb8c0e2fea5173f4fa3dd7798d61759f04af introduced a memory leak due to not cleaning all the ucontacts created at get_urecord() so every time that there are expired contacts in the db we will leave some ucontacts in shared mem and will be never free This only happens on DB_ONLY mode You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1947 -- Commit Summary -- * usrloc: udomain_contact_expired_cb fix memory leak -- File Changes -- M src/modules/usrloc/udomain.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1947.patch https://github.com/kamailio/kamailio/pull/1947.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1947

2 2

git:master:48fd1a23: usrloc: udomain_contact_expired_cb fix memory leak
by Victor Seva 07 May '19

07 May '19

Module: kamailio Branch: master Commit: 48fd1a23cc3ddcb0df082bc24669dbf3a9fdc203 URL: https://github.com/kamailio/kamailio/commit/48fd1a23cc3ddcb0df082bc24669dbf… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2019-05-07T09:27:42+02:00 usrloc: udomain_contact_expired_cb fix memory leak We need to call release_urecord in order to free the ucontacts generated at get_urecord() on shared memory --- Modified: src/modules/usrloc/udomain.c --- Diff: https://github.com/kamailio/kamailio/commit/48fd1a23cc3ddcb0df082bc24669dbf… Patch: https://github.com/kamailio/kamailio/commit/48fd1a23cc3ddcb0df082bc24669dbf… --- diff --git a/src/modules/usrloc/udomain.c b/src/modules/usrloc/udomain.c index c28c881790..11378aadee 100644 --- a/src/modules/usrloc/udomain.c +++ b/src/modules/usrloc/udomain.c @@ -1019,7 +1019,7 @@ int udomain_contact_expired_cb(db1_con_t* _c, udomain_t* _d) if ( (c=mem_insert_ucontact(r, &contact, ci)) == 0) { LM_ERR("inserting contact failed\n"); - free_ucontact(c); + release_urecord(r); unlock_udomain(_d, &user); goto error; } @@ -1029,7 +1029,7 @@ int udomain_contact_expired_cb(db1_con_t* _c, udomain_t* _d) run_ul_callbacks( UL_CONTACT_EXPIRE, c); } c->state = CS_SYNC; - free_ucontact(c); + release_urecord(r); unlock_udomain(_d, &user); }

1 0

git:master:db89b4ba: modules: readme files regenerated - dialplan ... [skip ci]
by Kamailio Dev 06 May '19

06 May '19

Module: kamailio Branch: master Commit: db89b4baca48c96df613d441703b63de3522e6d5 URL: https://github.com/kamailio/kamailio/commit/db89b4baca48c96df613d441703b63d… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2019-05-06T16:31:53+02:00 modules: readme files regenerated - dialplan ... [skip ci] --- Modified: src/modules/dialplan/README --- Diff: https://github.com/kamailio/kamailio/commit/db89b4baca48c96df613d441703b63d… Patch: https://github.com/kamailio/kamailio/commit/db89b4baca48c96df613d441703b63d… --- diff --git a/src/modules/dialplan/README b/src/modules/dialplan/README index c5bdaea8eb..3b89fbd7da 100644 --- a/src/modules/dialplan/README +++ b/src/modules/dialplan/README @@ -55,6 +55,7 @@ Luis Martin 5.12. fetch_rows (int) 5.13. match_dynamic (int) 5.14. append_branch (int) + 5.15. reload_delta (int) 6. Functions @@ -89,11 +90,12 @@ Luis Martin 1.12. Set fetch_rows parameter 1.13. Set match_dynamic parameter 1.14. Set append_branch parameter - 1.15. dp_replace usage - 1.16. dp_match usage - 1.17. dp_translate usage + 1.15. Set reload_delta parameter + 1.16. dp_replace usage + 1.17. dp_match usage 1.18. dp_translate usage - 1.19. Example of rules + 1.19. dp_translate usage + 1.20. Example of rules Chapter 1. Admin Guide @@ -123,6 +125,7 @@ Chapter 1. Admin Guide 5.12. fetch_rows (int) 5.13. match_dynamic (int) 5.14. append_branch (int) + 5.15. reload_delta (int) 6. Functions @@ -223,6 +226,7 @@ Chapter 1. Admin Guide 5.12. fetch_rows (int) 5.13. match_dynamic (int) 5.14. append_branch (int) + 5.15. reload_delta (int) 5.1. db_url (string) @@ -393,6 +397,23 @@ modparam("dialplan", "match_dynamic", 1) modparam("dialplan", "append_branch", 0) ... +5.15. reload_delta (int) + + The number of seconds that have to be waited before executing a new + reload of dialplan rules. By default there is a rate limiting of + maximum one reload in five seconds. + + If set to 0, no rate limit is configured. Note carefully: use this + configuration only in tests environments because executing two dialplan + reloads at the same time can cause to kamailio to crash. + + Default value is “5”. + + Example 1.15. Set reload_delta parameter +... +modparam("dialplan", "reload_delta", 1) +... + 6. Functions 6.1. dp_replace(dpid, inval, outvar) @@ -423,7 +444,7 @@ modparam("dialplan", "append_branch", 0) This function can be used from ANY_ROUTE. - Example 1.15. dp_replace usage + Example 1.16. dp_replace usage ... dp_replace("240", "$rU", "$var(newru)"); xlog("'$rU' was translated to '$var(newru)'\n"); @@ -450,7 +471,7 @@ dp_replace("240", "+49$rU", "$var(newval)"); This function can be used from ANY_ROUTE. - Example 1.16. dp_match usage + Example 1.17. dp_match usage ... dp_match("240", "+49$rU"); xlog("the attributes associated with '+49$rU' are '$var(attrs)'\n"); @@ -491,13 +512,13 @@ xlog("the attributes associated with '+49$rU' are '$var(attrs)'\n"); This function can be used from ANY_ROUTE. - Example 1.17. dp_translate usage + Example 1.18. dp_translate usage ... dp_translate("240", "$ruri.user/$avp(s:dest)"); xlog("translated to var $avp(s:dest) \n"); ... - Example 1.18. dp_translate usage + Example 1.19. dp_translate usage ... $avp(s:src) = $ruri.user; dp_translate("$var(x)", "$avp(s:src)/$var(y)"); @@ -507,7 +528,8 @@ xlog("translated to var $var(y) \n"); 6.4. dp_reload() Reload the translation rules from the database. Note that there is a - rate limiting of maximum one reload in five seconds. + rate limiting defined by 'reload_delta' paramenter. By default is + allowed maximum one reload in five seconds. Name: dp_reload @@ -571,7 +593,7 @@ xlog("translated to var $var(y) \n"); Some sample records from a dialplan table are presented in the next figure. - Example 1.19. Example of rules + Example 1.20. Example of rules ... dpid: 1 pr: 1

1 0

[kamailio/kamailio] dialplan: add reload_delta parameter (#1946)
by Marco Capetta 06 May '19

06 May '19

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  In commit 99d5da8d595961063249f871a5d150474fa6f317 a mechanism for basic safety in case of concurent rpc reload were added. This works fine but it is limiting our test scenarios where multiple changes should happen quickly. The new dialplan paramenter reload_delta allows everyone to configure rpc reload rate limit to the preferred number of seconds. In case the parameter is not specified. the default value is 5 seconds. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1946 -- Commit Summary -- * dialplan: add reload_delta parameter -- File Changes -- M src/modules/dialplan/dialplan.c (7) M src/modules/dialplan/doc/dialplan_admin.xml (32) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1946.patch https://github.com/kamailio/kamailio/pull/1946.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1946

2 3

git:master:926a97f4: dialplan: add reload_delta parameter
by Victor Seva 06 May '19

06 May '19

Module: kamailio Branch: master Commit: 926a97f4eb741401b193fb711e6c439555c646ab URL: https://github.com/kamailio/kamailio/commit/926a97f4eb741401b193fb711e6c439… Author: Marco Capetta <mcapetta(a)sipwise.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2019-05-06T16:29:48+02:00 dialplan: add reload_delta parameter - make the rate limit of maximum allowed dialplan reload configurable using the new 'reload_delta' paramenter. --- Modified: src/modules/dialplan/dialplan.c Modified: src/modules/dialplan/doc/dialplan_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/926a97f4eb741401b193fb711e6c439… Patch: https://github.com/kamailio/kamailio/commit/926a97f4eb741401b193fb711e6c439… --- diff --git a/src/modules/dialplan/dialplan.c b/src/modules/dialplan/dialplan.c index d8685d52f2..20b7744e21 100644 --- a/src/modules/dialplan/dialplan.c +++ b/src/modules/dialplan/dialplan.c @@ -87,6 +87,7 @@ dp_param_p default_par2 = NULL; int dp_fetch_rows = 1000; int dp_match_dynamic = 0; int dp_append_branch = 1; +int dp_reload_delta = 5; static time_t *dp_rpc_reload_time = NULL; @@ -105,6 +106,7 @@ static param_export_t mod_params[]={ { "fetch_rows", PARAM_INT, &dp_fetch_rows }, { "match_dynamic", PARAM_INT, &dp_match_dynamic }, { "append_branch", PARAM_INT, &dp_append_branch }, + { "reload_delta", PARAM_INT, &dp_reload_delta }, {0,0,0} }; @@ -182,6 +184,9 @@ static int mod_init(void) if(dp_fetch_rows<=0) dp_fetch_rows = 1000; + if(dp_reload_delta<0) + dp_reload_delta = 5; + if(init_data() != 0) { LM_ERR("could not initialize data\n"); return -1; @@ -619,7 +624,7 @@ static void dialplan_rpc_reload(rpc_t* rpc, void* ctx) rpc->fault(ctx, 500, "Not ready for reload"); return; } - if(*dp_rpc_reload_time!=0 && *dp_rpc_reload_time > time(NULL) - 5) { + if(*dp_rpc_reload_time!=0 && *dp_rpc_reload_time > time(NULL) - dp_reload_delta) { LM_ERR("ongoing reload\n"); rpc->fault(ctx, 500, "ongoing reload"); return; diff --git a/src/modules/dialplan/doc/dialplan_admin.xml b/src/modules/dialplan/doc/dialplan_admin.xml index 371120fac4..e524524fb8 100644 --- a/src/modules/dialplan/doc/dialplan_admin.xml +++ b/src/modules/dialplan/doc/dialplan_admin.xml @@ -410,6 +410,33 @@ modparam("dialplan", "append_branch", 0) </example> </section> + <section id="dialplan.p.reload_delta"> + <title><varname>reload_delta</varname> (int)</title> + <para> + The number of seconds that have to be waited before executing a new reload + of dialplan rules. By default there is a rate limiting of maximum one reload + in five seconds. + </para> + <para> + If set to 0, no rate limit is configured. Note carefully: use this configuration + only in tests environments because executing two dialplan reloads at the same + time can cause to kamailio to crash. + </para> + <para> + <emphasis> + Default value is <quote>5</quote>. + </emphasis> + </para> + <example> + <title>Set <varname>reload_delta</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("dialplan", "reload_delta", 1) +... + </programlisting> + </example> + </section> + </section> @@ -620,8 +647,9 @@ xlog("translated to var $var(y) \n"); <function moreinfo="none">dp_reload()</function> </title> <para> - Reload the translation rules from the database. Note that there is - a rate limiting of maximum one reload in five seconds. + Reload the translation rules from the database. Note that there is a + rate limiting defined by 'reload_delta' paramenter. By default is allowed + maximum one reload in five seconds. </para> <para> Name: <emphasis>dp_reload</emphasis>

1 0

git:master:02d67f80: rtp_media_server: fix incompatible media format
by Julien Chavanton 05 May '19

05 May '19

Module: kamailio Branch: master Commit: 02d67f80580ca813b98198dcd408c3fcf0b7976a URL: https://github.com/kamailio/kamailio/commit/02d67f80580ca813b98198dcd408c3f… Author: Julien Chavanton <jchavanton(a)gmail.com> Committer: Julien Chavanton <jchavanton(a)gmail.com> Date: 2019-05-05T19:25:04Z rtp_media_server: fix incompatible media format --- Modified: src/modules/rtp_media_server/rms_dialog_info.c Modified: src/modules/rtp_media_server/rms_sdp.c --- Diff: https://github.com/kamailio/kamailio/commit/02d67f80580ca813b98198dcd408c3f… Patch: https://github.com/kamailio/kamailio/commit/02d67f80580ca813b98198dcd408c3f… --- diff --git a/src/modules/rtp_media_server/rms_dialog_info.c b/src/modules/rtp_media_server/rms_dialog_info.c index f312cff298..4b1d8269b4 100644 --- a/src/modules/rtp_media_server/rms_dialog_info.c +++ b/src/modules/rtp_media_server/rms_dialog_info.c @@ -25,6 +25,7 @@ extern int in_rms_process; static void rms_action_free(rms_dialog_info_t *si) { rms_action_t *a, *tmp; + if (!si->action.prev) return; clist_foreach(&si->action, a, next) { tmp = a; diff --git a/src/modules/rtp_media_server/rms_sdp.c b/src/modules/rtp_media_server/rms_sdp.c index 304fee2b9c..55277987b4 100644 --- a/src/modules/rtp_media_server/rms_sdp.c +++ b/src/modules/rtp_media_server/rms_sdp.c @@ -186,7 +186,7 @@ PayloadType *rms_sdp_check_payload(rms_sdp_info_t *sdp) char *payloads = sdp->payloads.s; char *payload_type_number = strtok(payloads, " "); if(!payload_type_number) { - payload_type_destroy(pt); + shm_free(pt); // payload_type_destroy(pt); return NULL; } pt->type = atoi(payload_type_number); @@ -225,7 +225,7 @@ PayloadType *rms_sdp_check_payload(rms_sdp_info_t *sdp) break; payload_type_number = strtok(NULL, " "); if(!payload_type_number) { - payload_type_destroy(pt); + shm_free(pt); // payload_type_destroy(pt); return NULL; } pt->type = atoi(payload_type_number);

1 0

git:master:e4af8e5a: rtp_media_server: adding docker files
by Julien Chavanton 05 May '19

05 May '19

Module: kamailio Branch: master Commit: e4af8e5a205342dd309493a7bdd1e2cd9335c881 URL: https://github.com/kamailio/kamailio/commit/e4af8e5a205342dd309493a7bdd1e2c… Author: Julien Chavanton <jchavanton(a)gmail.com> Committer: Julien Chavanton <jchavanton(a)gmail.com> Date: 2019-05-05T18:54:55Z rtp_media_server: adding docker files --- Added: src/modules/rtp_media_server/docker/Dockerfile Added: src/modules/rtp_media_server/docker/build.sh Added: src/modules/rtp_media_server/docker/rtp_media_server.sh Modified: src/modules/rtp_media_server/config_example/kamailio.cfg --- Diff: https://github.com/kamailio/kamailio/commit/e4af8e5a205342dd309493a7bdd1e2c… Patch: https://github.com/kamailio/kamailio/commit/e4af8e5a205342dd309493a7bdd1e2c…

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2019