sr-dev March 2019

sr-dev@lists.kamailio.org

28 participants
322 discussions

git:master:5e48786a: Merge pull request #1890 from ionutionita92/issue-1871

by GitHub

Module: kamailio Branch: master Commit: 5e48786aef8e8d46ef936fc111d6b926acf79635 URL: https://github.com/kamailio/kamailio/commit/5e48786aef8e8d46ef936fc111d6b92… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2019-03-13T14:28:13+01:00 Merge pull request #1890 from ionutionita92/issue-1871 tm: remove unnecessary TMCB_ACK_NEG_IN callback call --- Modified: src/modules/tm/t_reply.c --- Diff: https://github.com/kamailio/kamailio/commit/5e48786aef8e8d46ef936fc111d6b92… Patch: https://github.com/kamailio/kamailio/commit/5e48786aef8e8d46ef936fc111d6b92… --- diff --git a/src/modules/tm/t_reply.c b/src/modules/tm/t_reply.c index 33910e1f8c..202b8d826f 100644 --- a/src/modules/tm/t_reply.c +++ b/src/modules/tm/t_reply.c @@ -2303,14 +2303,6 @@ int reply_received( struct sip_msg *p_msg ) t, &onsend_params); } } - if (unlikely(has_tran_tmcbs(t, TMCB_ACK_NEG_IN))){ - INIT_TMCB_ONSEND_PARAMS(onsend_params, - t->uas.request, p_msg, &uac->request, - &uac->request.dst, ack, ack_len, - TMCB_LOCAL_F, branch, TYPE_LOCAL_ACK); - run_trans_callbacks_off_params(TMCB_ACK_NEG_IN, - t, &onsend_params); - } shm_free(ack); } } else if (is_local(t) /*&& 200 <= msg_status < 300*/) {

5 years, 9 months

git:master:cd6ef63a: tm: remove unnecessary TMCB_ACK_NEG_IN callback call

by iionita

Module: kamailio Branch: master Commit: cd6ef63a1eb5951ccb38276a91e150187702b352 URL: https://github.com/kamailio/kamailio/commit/cd6ef63a1eb5951ccb38276a91e1501… Author: iionita <ionut-razvan.ionita(a)1and1.ro> Committer: iionita <ionut-razvan.ionita(a)1and1.ro> Date: 2019-03-12T16:19:01+02:00 tm: remove unnecessary TMCB_ACK_NEG_IN callback call - TMCB_ACK_NEG_IN was called in an if branch where the initial condition was the message to be an INVITE; this was not affecting anything for the moment since this callback wasn't used but in case some piece of code would have used this callback it would be called not only for hop-by-hop ACKs but also INVITEs Closes #1871 --- Modified: src/modules/tm/t_reply.c --- Diff: https://github.com/kamailio/kamailio/commit/cd6ef63a1eb5951ccb38276a91e1501… Patch: https://github.com/kamailio/kamailio/commit/cd6ef63a1eb5951ccb38276a91e1501… --- diff --git a/src/modules/tm/t_reply.c b/src/modules/tm/t_reply.c index 33910e1f8c..202b8d826f 100644 --- a/src/modules/tm/t_reply.c +++ b/src/modules/tm/t_reply.c @@ -2303,14 +2303,6 @@ int reply_received( struct sip_msg *p_msg ) t, &onsend_params); } } - if (unlikely(has_tran_tmcbs(t, TMCB_ACK_NEG_IN))){ - INIT_TMCB_ONSEND_PARAMS(onsend_params, - t->uas.request, p_msg, &uac->request, - &uac->request.dst, ack, ack_len, - TMCB_LOCAL_F, branch, TYPE_LOCAL_ACK); - run_trans_callbacks_off_params(TMCB_ACK_NEG_IN, - t, &onsend_params); - } shm_free(ack); } } else if (is_local(t) /*&& 200 <= msg_status < 300*/) {

5 years, 9 months

Planning next IRC devel meeting

by Daniel-Constantin Mierla

Hello, wondering if we we should do a new IRC devel meeting in the near future to sync on development plans. One of the decisions we should take is whether we should target to release the new major version (5.3) before the summer holidays or we leave it for the autumn. If many wants to do it, then a first proposal for a date would be: March 07, 2019, at 15:00 UTC (16:00 Berlin time). As usual, I created a wiki page to track the availability and the topics that should be approched: * https://www.kamailio.org/wiki/devel/irc-meetings/2019a Feel free to add yourself there, propose topics, etc... Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio World Conference - May 6-8, 2019 -- www.kamailioworld.com Kamailio Advanced Training - Mar 4-6, 2019 in Berlin; Mar 25-27, 2019, in Washington, DC, USA -- www.asipto.com

5 years, 9 months

git:master:0bf9c5d7: modules: readme files regenerated - secfilter ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 0bf9c5d7c4ead4d71e0ae041d41cbf144ce1df86 URL: https://github.com/kamailio/kamailio/commit/0bf9c5d7c4ead4d71e0ae041d41cbf1… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2019-03-12T14:01:42+01:00 modules: readme files regenerated - secfilter ... [skip ci] --- Modified: src/modules/secfilter/README --- Diff: https://github.com/kamailio/kamailio/commit/0bf9c5d7c4ead4d71e0ae041d41cbf1… Patch: https://github.com/kamailio/kamailio/commit/0bf9c5d7c4ead4d71e0ae041d41cbf1…

5 years, 9 months

git:master:7d7c5b1d: secfilter: added locks and an RPC command to reset stats

by Jose Luis Verdeguer

Module: kamailio Branch: master Commit: 7d7c5b1d19bc21e0b4552e74ae80ca21b741248c URL: https://github.com/kamailio/kamailio/commit/7d7c5b1d19bc21e0b4552e74ae80ca2… Author: Jose Luis Verdeguer <pepeluxx(a)gmail.com> Committer: Jose Luis Verdeguer <pepeluxx(a)gmail.com> Date: 2019-03-12T13:51:31+01:00 secfilter: added locks and an RPC command to reset stats --- Modified: src/modules/secfilter/doc/secfilter_admin.xml Modified: src/modules/secfilter/secfilter.c Modified: src/modules/secfilter/secfilter.h Modified: src/modules/secfilter/secfilter_rpc.c --- Diff: https://github.com/kamailio/kamailio/commit/7d7c5b1d19bc21e0b4552e74ae80ca2… Patch: https://github.com/kamailio/kamailio/commit/7d7c5b1d19bc21e0b4552e74ae80ca2…

5 years, 9 months

git:master:d8662226: secfilter: update readme [skip ci]

by Jose Luis Verdeguer

Module: kamailio Branch: master Commit: d86622266baa51eda6d324cde6ddbf01dea6ab19 URL: https://github.com/kamailio/kamailio/commit/d86622266baa51eda6d324cde6ddbf0… Author: Jose Luis Verdeguer <pepeluxx(a)gmail.com> Committer: Jose Luis Verdeguer <pepeluxx(a)gmail.com> Date: 2019-03-12T13:51:31+01:00 secfilter: update readme [skip ci] --- Modified: src/modules/secfilter/doc/secfilter_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/d86622266baa51eda6d324cde6ddbf0… Patch: https://github.com/kamailio/kamailio/commit/d86622266baa51eda6d324cde6ddbf0… --- diff --git a/src/modules/secfilter/doc/secfilter_admin.xml b/src/modules/secfilter/doc/secfilter_admin.xml index c5bf63d5e6..4e599fd7e5 100644 --- a/src/modules/secfilter/doc/secfilter_admin.xml +++ b/src/modules/secfilter/doc/secfilter_admin.xml @@ -609,6 +609,26 @@ </example> </section> + <section id="secfilter.r.stats"> + <title> + <function moreinfo="none">secfilter.stats</function> + </title> + + <para> + Print statistics of blocked and allowed messages. + </para> + + <example> + <title><function>secfilter.stats</function> usage</title> + + <programlisting format="linespecific"> + ... + &kamcmd; secfilter.stats + ... + </programlisting> + </example> + </section> + <section id="secfilter.r.add_dst"> <title> <function moreinfo="none">secfilter.add_dst</function> @@ -760,5 +780,94 @@ </para> </section> </section> + + <section> + <title>Some examples</title> + + <section> + <title>Print data</title> + + <example> + <title>kamcmd secfilter.print ua</title> + + <programlisting format="linespecific"> + ... +User-agent +========== +[+] Blacklisted + ----------- + 0001 -> friendly-scanner + 0002 -> pplsip + 0003 -> sipcli + 0004 -> sundayddr + 0005 -> iWar + 0006 -> sipsak + 0007 -> VaxSIPUserAgent + 0008 -> SimpleSIP + 0009 -> SIP Call + 0010 -> Ozeki + 0011 -> VoIPSec + 0012 -> SIPScan + 0013 -> Conaito + 0014 -> UsaAirport + 0015 -> PortSIP VoIP SDK + 0016 -> zxcvfdf11 + 0017 -> fdgddfg546df4g8d5f + +[+] Whitelisted + ----------- + 0001 -> my custom ua + ... + </programlisting> + </example> + </section> + + <section> + <title>Statistics</title> + + <example> + <title>kamcmd secfilter.stats</title> + + <programlisting format="linespecific"> + ... +Blocked messages (blacklist) +============================ +[+] By user-agent : 1256 +[+] By country : 45 +[+] By from domain : 0 +[+] By to domain : 0 +[+] By contact domain: 1 +[+] By IP address : 2552 +[+] By from name : 0 +[+] By to name : 0 +[+] By contact name : 0 +[+] By from user : 316 +[+] By to user : 134 +[+] By contact user : 0 + +Allowed messages (whitelist) +============================ +[+] By user-agent : 0 +[+] By country : 478 +[+] By from domain : 0 +[+] By to domain : 0 +[+] By contact domain: 0 +[+] By IP address : 0 +[+] By from name : 0 +[+] By to name : 0 +[+] By contact name : 0 +[+] By from user : 0 +[+] By to user : 0 +[+] By contact user : 0 + +Other blocked messages +====================== +[+] Destinations : 0 +[+] SQL injection : 213 + ... + </programlisting> + </example> + </section> + </section> </chapter>

5 years, 9 months

git:master:60b2fcb2: secfilter: print statistics of blocked and allowed messages using RPC commands

by Jose Luis Verdeguer

Module: kamailio Branch: master Commit: 60b2fcb2da7bcda734178d0de4d94ce00c423b30 URL: https://github.com/kamailio/kamailio/commit/60b2fcb2da7bcda734178d0de4d94ce… Author: Jose Luis Verdeguer <pepeluxx(a)gmail.com> Committer: Jose Luis Verdeguer <pepeluxx(a)gmail.com> Date: 2019-03-12T13:51:31+01:00 secfilter: print statistics of blocked and allowed messages using RPC commands --- Modified: src/modules/secfilter/secfilter.c Modified: src/modules/secfilter/secfilter.h Modified: src/modules/secfilter/secfilter_rpc.c --- Diff: https://github.com/kamailio/kamailio/commit/60b2fcb2da7bcda734178d0de4d94ce… Patch: https://github.com/kamailio/kamailio/commit/60b2fcb2da7bcda734178d0de4d94ce…

5 years, 9 months

[kamailio/kamailio] secfilter: print statistics of blocked and allowed messages using RPC commands (#1888)

by Jose Luis Verdeguer

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1888 -- Commit Summary -- * secfilter: print statistics of blocked and allowed messages using RPC commands -- File Changes -- M src/modules/secfilter/doc/secfilter_admin.xml (109) M src/modules/secfilter/secfilter.c (86) M src/modules/secfilter/secfilter.h (30) M src/modules/secfilter/secfilter_rpc.c (44) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1888.patch https://github.com/kamailio/kamailio/pull/1888.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1888

5 years, 9 months

git:master:b50159d6: secfilter: avoid dereferences null

by Jose Luis Verdeguer

Module: kamailio Branch: master Commit: b50159d60dec4ffc671e424cc849e4cde4e9bfb5 URL: https://github.com/kamailio/kamailio/commit/b50159d60dec4ffc671e424cc849e4c… Author: Jose Luis Verdeguer <pepeluxx(a)gmail.com> Committer: Jose Luis Verdeguer <pepeluxx(a)gmail.com> Date: 2019-03-12T11:13:41+01:00 secfilter: avoid dereferences null --- Modified: src/modules/secfilter/secfilter.c --- Diff: https://github.com/kamailio/kamailio/commit/b50159d60dec4ffc671e424cc849e4c… Patch: https://github.com/kamailio/kamailio/commit/b50159d60dec4ffc671e424cc849e4c… --- diff --git a/src/modules/secfilter/secfilter.c b/src/modules/secfilter/secfilter.c index 4816c4ad9d..d229031f30 100644 --- a/src/modules/secfilter/secfilter.c +++ b/src/modules/secfilter/secfilter.c @@ -424,6 +424,10 @@ static int check_user(struct sip_msg *msg, int type) if(res != 0) { return res; } + + if (user.s == NULL || domain.s == NULL) { + return -1; + } nlen = name.len; ulen = user.len; @@ -434,9 +438,11 @@ static int check_user(struct sip_msg *msg, int type) while(list) { if(name.len > list->s.len) name.len = list->s.len; - res = cmpi_str(&list->s, &name); - if(res == 0) { - return 4; + if (name.s != NULL) { + res = cmpi_str(&list->s, &name); + if(res == 0) { + return 4; + } } if(user.len > list->s.len) user.len = list->s.len; @@ -453,9 +459,11 @@ static int check_user(struct sip_msg *msg, int type) while(list) { if(name.len > list->s.len) name.len = list->s.len; - res = cmpi_str(&list->s, &name); - if(res == 0) { - return -4; + if (name.s != NULL) { + res = cmpi_str(&list->s, &name); + if(res == 0) { + return -4; + } } if(user.len > list->s.len) user.len = list->s.len;

5 years, 9 months

[kamailio/kamailio] secfilter: avoid dereferences null (#1887)

by Jose Luis Verdeguer

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1887 -- Commit Summary -- * secfilter: avoid dereferences null -- File Changes -- M src/modules/secfilter/secfilter.c (20) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1887.patch https://github.com/kamailio/kamailio/pull/1887.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1887

5 years, 9 months

← Newer
1
...
21
22
23
24
25
26
27
...
33
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2019