February 2019 - sr-dev - kamailio.org

git:master:5b23ce26: dispatcher: Don't take modulus of hash twice
by Henning Westerholt 05 Feb '19

05 Feb '19

Module: kamailio Branch: master Commit: 5b23ce265b43adda75731a90fdf1a3a47daa3a51 URL: https://github.com/kamailio/kamailio/commit/5b23ce265b43adda75731a90fdf1a3a… Author: Alex Hermann <alex(a)hexla.nl> Committer: Henning Westerholt <henningw(a)users.noreply.github.com> Date: 2019-02-05T21:11:03+01:00 dispatcher: Don't take modulus of hash twice --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/5b23ce265b43adda75731a90fdf1a3a… Patch: https://github.com/kamailio/kamailio/commit/5b23ce265b43adda75731a90fdf1a3a… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index 9255e9eae6..2a4fd853b2 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -2089,7 +2089,7 @@ int ds_manage_routes(sip_msg_t *msg, ds_select_state_t *rstate) } break; case DS_ALG_RANDOM: /* 6 - random selection */ - hash = kam_rand() % idx->nr; + hash = kam_rand(); break; case DS_ALG_HASHPV: /* 7 - hash on PV value */ if(ds_hash_pvar(msg, &hash) != 0) {

1 0

git:master:73d29ddd: siputils: Return true if options_reply() succeeds
by Henning Westerholt 05 Feb '19

05 Feb '19

Module: kamailio Branch: master Commit: 73d29ddde2b38cfea2c9ca4a84f4b8a246b7da50 URL: https://github.com/kamailio/kamailio/commit/73d29ddde2b38cfea2c9ca4a84f4b8a… Author: Alex Hermann <alex(a)hexla.nl> Committer: Henning Westerholt <henningw(a)users.noreply.github.com> Date: 2019-02-05T21:11:03+01:00 siputils: Return true if options_reply() succeeds --- Modified: src/modules/siputils/options.c --- Diff: https://github.com/kamailio/kamailio/commit/73d29ddde2b38cfea2c9ca4a84f4b8a… Patch: https://github.com/kamailio/kamailio/commit/73d29ddde2b38cfea2c9ca4a84f4b8a… --- diff --git a/src/modules/siputils/options.c b/src/modules/siputils/options.c index 67cf07856d..484c65f75f 100644 --- a/src/modules/siputils/options.c +++ b/src/modules/siputils/options.c @@ -112,7 +112,7 @@ int opt_reply(struct sip_msg* _msg, char* _foo, char* _bar) { return -1; } else - return 0; + return 1; } else { pkg_free(rpl_hf.s); LM_ERR("add_lump_rpl failed\n"); @@ -124,6 +124,6 @@ int opt_reply(struct sip_msg* _msg, char* _foo, char* _bar) { return -1; } else - return 0; + return 1; }

1 0

git:master:0125c1c8: jansson: Fix reverse logic for JSON boolean
by Henning Westerholt 05 Feb '19

05 Feb '19

Module: kamailio Branch: master Commit: 0125c1c8d8c1179670def9dc4b3e66d6a8e58360 URL: https://github.com/kamailio/kamailio/commit/0125c1c8d8c1179670def9dc4b3e66d… Author: Alex Hermann <alex(a)hexla.nl> Committer: Henning Westerholt <henningw(a)users.noreply.github.com> Date: 2019-02-05T21:11:03+01:00 jansson: Fix reverse logic for JSON boolean --- Modified: src/modules/jansson/jansson_utils.c --- Diff: https://github.com/kamailio/kamailio/commit/0125c1c8d8c1179670def9dc4b3e66d… Patch: https://github.com/kamailio/kamailio/commit/0125c1c8d8c1179670def9dc4b3e66d… --- diff --git a/src/modules/jansson/jansson_utils.c b/src/modules/jansson/jansson_utils.c index 29ffc306f6..ae2040bc7c 100644 --- a/src/modules/jansson/jansson_utils.c +++ b/src/modules/jansson/jansson_utils.c @@ -45,7 +45,7 @@ int jansson_to_val(pv_value_t* val, char** freeme, json_t* v) { val->rs.len = strlen(value); val->flags = PV_VAL_STR; }else if(json_is_boolean(v)) { - val->ri = json_is_true(v) ? 0 : 1; + val->ri = json_is_true(v) ? 1 : 0; val->flags = PV_TYPE_INT|PV_VAL_INT; }else if(json_is_real(v)) { char* value = NULL;

1 0

git:master:684da612: dispatcher: remove duplicate code in ds_load_remove()
by Henning Westerholt 05 Feb '19

05 Feb '19

Module: kamailio Branch: master Commit: 684da61208bcf5a3077a931b2808563d4d71e0e8 URL: https://github.com/kamailio/kamailio/commit/684da61208bcf5a3077a931b2808563… Author: Alex Hermann <alex(a)hexla.nl> Committer: Henning Westerholt <henningw(a)users.noreply.github.com> Date: 2019-02-05T21:11:03+01:00 dispatcher: remove duplicate code in ds_load_remove() --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/684da61208bcf5a3077a931b2808563… Patch: https://github.com/kamailio/kamailio/commit/684da61208bcf5a3077a931b2808563… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index 727dbe0cc0..9255e9eae6 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -1613,83 +1613,57 @@ int ds_load_replace(struct sip_msg *msg, str *duid) /** * */ -int ds_load_remove(struct sip_msg *msg) +int ds_load_remove_byid(int set, str *duid) { - ds_cell_t *it; - int set; int olddst; ds_set_t *idx = NULL; int i; - if((it = ds_get_cell(_dsht_load, &msg->callid->body)) == NULL) { - LM_ERR("cannot find load for (%.*s)\n", msg->callid->body.len, - msg->callid->body.s); - return -1; - } - set = it->dset; /* get the index of the set */ if(ds_get_index(set, *crt_idx, &idx) != 0) { - ds_unlock_cell(_dsht_load, &msg->callid->body); LM_ERR("destination set [%d] not found\n", set); return -1; } olddst = -1; for(i = 0; i < idx->nr; i++) { - if(idx->dlist[i].attrs.duid.len == it->duid.len - && strncasecmp( - idx->dlist[i].attrs.duid.s, it->duid.s, it->duid.len) + if(idx->dlist[i].attrs.duid.len == duid->len + && strncasecmp(idx->dlist[i].attrs.duid.s, duid->s, duid->len) == 0) { olddst = i; break; } } if(olddst == -1) { - ds_unlock_cell(_dsht_load, &msg->callid->body); LM_ERR("old destination address not found for [%d, %.*s]\n", set, - it->duid.len, it->duid.s); + duid->len, duid->s); return -1; } - ds_unlock_cell(_dsht_load, &msg->callid->body); - ds_del_cell(_dsht_load, &msg->callid->body); if(idx->dlist[olddst].dload > 0) idx->dlist[olddst].dload--; return 0; } - /** * */ -int ds_load_remove_byid(int set, str *duid) +int ds_load_remove(struct sip_msg *msg) { - int olddst; - ds_set_t *idx = NULL; - int i; + ds_cell_t *it; - /* get the index of the set */ - if(ds_get_index(set, *crt_idx, &idx) != 0) { - LM_ERR("destination set [%d] not found\n", set); + if((it = ds_get_cell(_dsht_load, &msg->callid->body)) == NULL) { + LM_ERR("cannot find load for (%.*s)\n", msg->callid->body.len, + msg->callid->body.s); return -1; } - olddst = -1; - for(i = 0; i < idx->nr; i++) { - if(idx->dlist[i].attrs.duid.len == duid->len - && strncasecmp(idx->dlist[i].attrs.duid.s, duid->s, duid->len) - == 0) { - olddst = i; - break; - } - } - if(olddst == -1) { - LM_ERR("old destination address not found for [%d, %.*s]\n", set, - duid->len, duid->s); + + if (ds_load_remove_byid(it->dset, &it->duid) < 0) { + ds_unlock_cell(_dsht_load, &msg->callid->body); return -1; } - - if(idx->dlist[olddst].dload > 0) - idx->dlist[olddst].dload--; + ds_unlock_cell(_dsht_load, &msg->callid->body); + ds_del_cell(_dsht_load, &msg->callid->body); return 0; }

1 0

git:master:7a66f445: dispatcher: Stop searching if entry is found
by Henning Westerholt 05 Feb '19

05 Feb '19

Module: kamailio Branch: master Commit: 7a66f44506e4897fef68b5ff927cf276678d3473 URL: https://github.com/kamailio/kamailio/commit/7a66f44506e4897fef68b5ff927cf27… Author: Alex Hermann <alex(a)hexla.nl> Committer: Henning Westerholt <henningw(a)users.noreply.github.com> Date: 2019-02-05T21:11:03+01:00 dispatcher: Stop searching if entry is found --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/7a66f44506e4897fef68b5ff927cf27… Patch: https://github.com/kamailio/kamailio/commit/7a66f44506e4897fef68b5ff927cf27… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index 072869010e..727dbe0cc0 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -2590,7 +2590,6 @@ int ds_update_latency(int group, str *address, int code) int ds_get_state(int group, str *address) { int i = 0; - int state = 0; ds_set_t *idx = NULL; if(_ds_list == NULL || _ds_list_nr <= 0) { @@ -2609,11 +2608,11 @@ int ds_get_state(int group, str *address) && strncasecmp(idx->dlist[i].uri.s, address->s, address->len) == 0) { /* destination address found */ - state = idx->dlist[i].flags; + return idx->dlist[i].flags; } i++; } - return state; + return 0; } /**

1 0

git:master:614b6b05: dispatcher: Fix memleak in destination attributes
by Henning Westerholt 05 Feb '19

05 Feb '19

Module: kamailio Branch: master Commit: 614b6b05028ea8d364f7acb95a6367f7c9ea1a6d URL: https://github.com/kamailio/kamailio/commit/614b6b05028ea8d364f7acb95a6367f… Author: Alex Hermann <alex(a)hexla.nl> Committer: Henning Westerholt <henningw(a)users.noreply.github.com> Date: 2019-02-05T21:11:03+01:00 dispatcher: Fix memleak in destination attributes --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/614b6b05028ea8d364f7acb95a6367f… Patch: https://github.com/kamailio/kamailio/commit/614b6b05028ea8d364f7acb95a6367f… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index 4956623cc7..072869010e 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -461,6 +461,8 @@ ds_dest_t *pack_dest(str iuri, int flags, int priority, str *attrs) if(dp != NULL) { if(dp->uri.s != NULL) shm_free(dp->uri.s); + if(dp->attrs.body.s != NULL) + shm_free(dp->attrs.body.s); shm_free(dp); } @@ -517,6 +519,8 @@ int add_dest2list(int id, str uri, int flags, int priority, str *attrs, if(dp != NULL) { if(dp->uri.s != NULL) shm_free(dp->uri.s); + if(dp->attrs.body.s != NULL) + shm_free(dp->attrs.body.s); shm_free(dp); } @@ -3306,6 +3310,10 @@ void ds_avl_destroy(ds_set_t **node_ptr) shm_free(dest->uri.s); dest->uri.s = NULL; } + if (dest->attrs.body.s != NULL) { + shm_free(dest->attrs.body.s); + dest->attrs.body.s = NULL; + } } if(node->dlist != NULL) shm_free(node->dlist);

1 0

git:master:499c45fd: Merge pull request #1835 from ycaner06/patch-13
by GitHub 05 Feb '19

05 Feb '19

Module: kamailio Branch: master Commit: 499c45fd8cb8dbf7afcf34d938d48e289422a3af URL: https://github.com/kamailio/kamailio/commit/499c45fd8cb8dbf7afcf34d938d48e2… Author: ng-voice GmbH <info(a)ng-voice.com> Committer: GitHub <noreply(a)github.com> Date: 2019-02-05T07:53:19+01:00 Merge pull request #1835 from ycaner06/patch-13 ims_usrloc_scscf : documentation is added --- Added: src/modules/ims_usrloc_scscf/doc/Makefile Added: src/modules/ims_usrloc_scscf/doc/ims_usrloc_scscf.xml Added: src/modules/ims_usrloc_scscf/doc/ims_usrloc_scscf_admin.xml Added: src/modules/ims_usrloc_scscf/doc/ims_usrloc_scscf_faq.xml Modified: src/modules/ims_registrar_scscf/config.c Removed: src/modules/ims_registrar_scscf/screensharing.log Removed: src/modules/ims_usrloc_scscf/NewFile.xml --- Diff: https://github.com/kamailio/kamailio/commit/499c45fd8cb8dbf7afcf34d938d48e2… Patch: https://github.com/kamailio/kamailio/commit/499c45fd8cb8dbf7afcf34d938d48e2…

1 0

git:master:44049e9a: ims_usrloc_scscf: doc is added
by Yasin CANER 05 Feb '19

05 Feb '19

Module: kamailio Branch: master Commit: 44049e9a9793824a8ef09759813b3cc8b5864103 URL: https://github.com/kamailio/kamailio/commit/44049e9a9793824a8ef09759813b3cc… Author: Yasin CANER <caner_yaso(a)hotmail.com> Committer: Yasin CANER <caner_yaso(a)hotmail.com> Date: 2019-02-04T21:09:24+03:00 ims_usrloc_scscf: doc is added documentation is added for ims_usrloc_scscf --- Added: src/modules/ims_usrloc_scscf/doc/Makefile Added: src/modules/ims_usrloc_scscf/doc/ims_usrloc_scscf.xml Added: src/modules/ims_usrloc_scscf/doc/ims_usrloc_scscf_admin.xml Added: src/modules/ims_usrloc_scscf/doc/ims_usrloc_scscf_faq.xml --- Diff: https://github.com/kamailio/kamailio/commit/44049e9a9793824a8ef09759813b3cc… Patch: https://github.com/kamailio/kamailio/commit/44049e9a9793824a8ef09759813b3cc…

1 0

git:master:e5fb74f6: ims_usrloc_scscf: removed NewFile.xml file
by Yasin CANER 05 Feb '19

05 Feb '19

Module: kamailio Branch: master Commit: e5fb74f6d37b3168c7b6b1c58ce783e453b40a88 URL: https://github.com/kamailio/kamailio/commit/e5fb74f6d37b3168c7b6b1c58ce783e… Author: Yasin CANER <caner_yaso(a)hotmail.com> Committer: Yasin CANER <caner_yaso(a)hotmail.com> Date: 2019-02-03T16:48:17+03:00 ims_usrloc_scscf: removed NewFile.xml file --- Removed: src/modules/ims_usrloc_scscf/NewFile.xml --- Diff: https://github.com/kamailio/kamailio/commit/e5fb74f6d37b3168c7b6b1c58ce783e… Patch: https://github.com/kamailio/kamailio/commit/e5fb74f6d37b3168c7b6b1c58ce783e… --- diff --git a/src/modules/ims_usrloc_scscf/NewFile.xml b/src/modules/ims_usrloc_scscf/NewFile.xml deleted file mode 100644 index 4cf67f074c..0000000000 --- a/src/modules/ims_usrloc_scscf/NewFile.xml +++ /dev/null @@ -1,9 +0,0 @@ -<?xml version="1.0"?> -<methodResponse> -<params> -<param> -<value><struct><member><name>Domain</name><value><string>location</string></value></member><member><name>Size</name><value><int>512</int></value></member><member><name>IMPUs</name><value><struct><member><name>IMPU</name><value><struct><member><name>IMPU</name><value><string>sip:123456789012345@ims.smilecoms.com</string></value></member><member><name>IMPI/Subscription</name><value><string>123456789012345(a)private.ims.smilecoms.com</string></value></member><member><name>State</name><value><string>registered</string></value></member><member><name>Barred</name><value><int>1</int></value></member><member><name>ccf1</name><value><string>aaa://priccfaddress:1234</string></value></member><member><name>ecf1</name><value><string></string></value></member><member><name>ccf2</name><value><string></string></value></member><member><name>ecf2</name><value><string></string></value></member></struct></value></member><member><name>IMPU</name><value><struct><member><name>IMPU</name><value><string>sip:27832837000@ims.smilecoms.com</string></value></member><member><name>IMPI/Subscription</name><value><string>123456789012345(a)private.ims.smilecoms.com</string></value></member><member><name>State</name><value><string>registered</string></value></member><member><name>Barred</name><value><int>0</int></value></member><member><name>ccf1</name><value><string>aaa://priccfaddress:1234</string></value></member><member><name>ecf1</name><value><string></string></value></member><member><name>ccf2</name><value><string></string></value></member><member><name>ecf2</name><value><string></string></value></member></struct></value></member></struct></value></member><member><name>Stats</name><value><struct><member><name>Records</name><value><int>2</int></value></member><member><name>Max-Slots</name><value><int>1</int></value></member></struct></value></member></struct> -</value> -</param> -</params> -</methodResponse> \ No newline at end of file

1 0

git:master:03c9259d: ims_registrar_scscf: removed screensharing log file.
by Yasin CANER 05 Feb '19

05 Feb '19

Module: kamailio Branch: master Commit: 03c9259d87275e63cc8ea8fbc1406ef95f04d186 URL: https://github.com/kamailio/kamailio/commit/03c9259d87275e63cc8ea8fbc1406ef… Author: Yasin CANER <caner_yaso(a)hotmail.com> Committer: Yasin CANER <caner_yaso(a)hotmail.com> Date: 2019-02-03T16:46:00+03:00 ims_registrar_scscf: removed screensharing log file. unnecessary log file removed --- Removed: src/modules/ims_registrar_scscf/screensharing.log --- Diff: https://github.com/kamailio/kamailio/commit/03c9259d87275e63cc8ea8fbc1406ef… Patch: https://github.com/kamailio/kamailio/commit/03c9259d87275e63cc8ea8fbc1406ef…

1 0

git:master:7f217aa5: ims_registrar_scscf : fixed wrong comment for emergency register
by GitHub 05 Feb '19

05 Feb '19

Module: kamailio Branch: master Commit: 7f217aa53262a4d4d9c99239eda335b954d08179 URL: https://github.com/kamailio/kamailio/commit/7f217aa53262a4d4d9c99239eda335b… Author: Yasin CANER <caner_yaso(a)hotmail.com> Committer: GitHub <noreply(a)github.com> Date: 2019-02-03T16:42:08+03:00 ims_registrar_scscf : fixed wrong comment for emergency register ims_registrar_scscf : fixed wrong comment for emergency register --- Modified: src/modules/ims_registrar_scscf/config.c --- Diff: https://github.com/kamailio/kamailio/commit/7f217aa53262a4d4d9c99239eda335b… Patch: https://github.com/kamailio/kamailio/commit/7f217aa53262a4d4d9c99239eda335b… --- diff --git a/src/modules/ims_registrar_scscf/config.c b/src/modules/ims_registrar_scscf/config.c index c81114f48c..0c55f11100 100644 --- a/src/modules/ims_registrar_scscf/config.c +++ b/src/modules/ims_registrar_scscf/config.c @@ -36,8 +36,8 @@ struct cfg_group_registrar default_registrar_cfg = { 60, /* min_expires */ 0, /* max_expires */ 3600, /* emergency contact default expires */ - 60, /* emergency contact min expires */ - 0, /* emergency contact max expires */ + 60, /* emergency contact max expires */ + 0, /* emergency contact min expires */ 0, /* max_contacts */ 0, /* retry_after */ 0, /* case_sensitive */

1 0

git:master:065b1d64: mqueue: added missing license header, removed svn ids
by Daniel-Constantin Mierla 04 Feb '19

04 Feb '19

Module: kamailio Branch: master Commit: 065b1d64453d8b5709069f50cfd705901206feb3 URL: https://github.com/kamailio/kamailio/commit/065b1d64453d8b5709069f50cfd7059… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-02-04T18:09:47+01:00 mqueue: added missing license header, removed svn ids --- Modified: src/modules/mqueue/api.h Modified: src/modules/mqueue/mqueue_api.c Modified: src/modules/mqueue/mqueue_api.h --- Diff: https://github.com/kamailio/kamailio/commit/065b1d64453d8b5709069f50cfd7059… Patch: https://github.com/kamailio/kamailio/commit/065b1d64453d8b5709069f50cfd7059… --- diff --git a/src/modules/mqueue/api.h b/src/modules/mqueue/api.h index 3c67f2fdbd..e00b474c92 100644 --- a/src/modules/mqueue/api.h +++ b/src/modules/mqueue/api.h @@ -1,3 +1,25 @@ +/** + * Copyright (C) 2010 Elena-Ramona Modroiu (asipto.com) + * + * This file is part of Kamailio, a free SIP server. + * + * This file is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version + * + * This file is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + * + */ + + #ifndef _MQUEUE_EXT_API_H_ #define _MQUEUE_EXT_API_H_ diff --git a/src/modules/mqueue/mqueue_api.c b/src/modules/mqueue/mqueue_api.c index d83c3ce6ce..55833790f8 100644 --- a/src/modules/mqueue/mqueue_api.c +++ b/src/modules/mqueue/mqueue_api.c @@ -1,6 +1,4 @@ /** - * $Id$ - * * Copyright (C) 2010 Elena-Ramona Modroiu (asipto.com) * * This file is part of Kamailio, a free SIP server. diff --git a/src/modules/mqueue/mqueue_api.h b/src/modules/mqueue/mqueue_api.h index 79996805f7..bc976b6ff7 100644 --- a/src/modules/mqueue/mqueue_api.h +++ b/src/modules/mqueue/mqueue_api.h @@ -1,6 +1,4 @@ /** - * $Id$ - * * Copyright (C) 2010 Elena-Ramona Modroiu (asipto.com) * * This file is part of Kamailio, a free SIP server.

1 0

git:master:25173335: misc/examples: exec.cfg updated for latest releases
by Daniel-Constantin Mierla 04 Feb '19

04 Feb '19

Module: kamailio Branch: master Commit: 25173335dda3142e01243f209d24ba571d61578d URL: https://github.com/kamailio/kamailio/commit/25173335dda3142e01243f209d24ba5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-02-03T07:35:08+01:00 misc/examples: exec.cfg updated for latest releases --- Modified: misc/examples/exec/exec.cfg --- Diff: https://github.com/kamailio/kamailio/commit/25173335dda3142e01243f209d24ba5… Patch: https://github.com/kamailio/kamailio/commit/25173335dda3142e01243f209d24ba5… --- diff --git a/misc/examples/exec/exec.cfg b/misc/examples/exec/exec.cfg index b0cfe43eaa..30a3a6ed8b 100644 --- a/misc/examples/exec/exec.cfg +++ b/misc/examples/exec/exec.cfg @@ -1,5 +1,4 @@ -# -# $Id$ +#!KAMAILIO # # this example shows use of ser as stateless redirect server # which rewrites URIs using an exernal utility @@ -7,17 +6,18 @@ # ------------------ module loading ---------------------------------- -loadmodule "modules/exec/exec.so" -loadmodule "modules/sl/sl.so" +loadmodule "exec.so" +loadmodule "sl.so" +loadmodule "xlog.so" # ------------------------- request routing logic ------------------- # main routing logic -route{ +request_route { # for testing purposes, simply okay all REGISTERs if (method=="REGISTER") { - log("REGISTER"); + xlog("REGISTER"); sl_send_reply("200", "ok"); break; }; @@ -30,7 +30,7 @@ route{ sl_send_reply("300", "Redirect"); } else { sl_reply_error(); - log(1, "alas, rewriting failed\n"); + xlog("rewriting failed\n"); }; }

1 0

Planning Fosdem 2019
by Daniel-Constantin Mierla 02 Feb '19

02 Feb '19

Hello, Fosdem 2019 is approaching, so I am writing to see if any of you plans to go to the event. If there is interest, we can try to organize again a dinner on Saturday evening, a tradition for our project at the past 10 editions or even more. Henning Westerholt will give a presentation about Kamailio in the RTC Devroom, I will be around as well. I know few more developers that plan to go to the event, so let's see who else from the community wants to join us. As usual, at Fosdem will be developers from other VoIP projects, like Asterisk, Janus, CGRates, Homer, Jitsi, ... At the past editions we typically had two "kamailio" events: 1) an "ad-hoc" developers meeting in the cantina (or other available room around) to discuss about short term plans for Kamailio -- time and place being decided as we meet there between us (expected in the afternoon of Saturday or during Sunday). 2) a dinner at a place nearby, with other VoIP folks joining us Reply if you plan to go to Fosdem and say if you want to join for a dinner. Just be aware that you have to pay for your food and drinks at the dinner, unless we are going to be surprised again by a generous sponsor that covers partially or completely to dinner. If you need more details about Fosdem, the website is: - https://fosdem.org Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio World Conference - May 6-8, 2019 -- www.kamailioworld.com Kamailio Advanced Training - Mar 4-6, 2019 in Berlin; Mar 25-27, 2019, in Washington, DC, USA -- www.asipto.com

4 6

git:master:18835e0d: Merge pull request #1825 from ycaner06/patch-11
by GitHub 01 Feb '19

01 Feb '19

Module: kamailio Branch: master Commit: 18835e0d8bfc55dd63b1a07faa9bde8dfafa8b70 URL: https://github.com/kamailio/kamailio/commit/18835e0d8bfc55dd63b1a07faa9bde8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2019-02-01T19:59:35+01:00 Merge pull request #1825 from ycaner06/patch-11 ims_isc : fixed P-associated-uri header constructing --- Modified: src/modules/ims_isc/third_party_reg.c --- Diff: https://github.com/kamailio/kamailio/commit/18835e0d8bfc55dd63b1a07faa9bde8… Patch: https://github.com/kamailio/kamailio/commit/18835e0d8bfc55dd63b1a07faa9bde8…

1 0

[kamailio/kamailio] ims_isc : fixed P-associated-uri header constructing (#1825)
by Yasin CANER 01 Feb '19

01 Feb '19

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  fixed P-associated-uri header construncting. it now creates sip and tel uri and appending them to P-header You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1825 -- Commit Summary -- * ims_isc : fixed memory leak * ims_isc : fixed P-associated-uri header constructing -- File Changes -- M src/modules/ims_isc/third_party_reg.c (61) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1825.patch https://github.com/kamailio/kamailio/pull/1825.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1825

2 3

git:master:a704f7d6: ims_isc : fixed wrong type for memcpy
by Yasin CANER 01 Feb '19

01 Feb '19

Module: kamailio Branch: master Commit: a704f7d68dddfaa9719acb7b04f4058a1cdf5673 URL: https://github.com/kamailio/kamailio/commit/a704f7d68dddfaa9719acb7b04f4058… Author: Yasin CANER <caner_yaso(a)hotmail.com> Committer: Yasin CANER <caner_yaso(a)hotmail.com> Date: 2019-01-30T07:59:32+03:00 ims_isc : fixed wrong type for memcpy fixed wrong type for memcpy --- Modified: src/modules/ims_isc/third_party_reg.c --- Diff: https://github.com/kamailio/kamailio/commit/a704f7d68dddfaa9719acb7b04f4058… Patch: https://github.com/kamailio/kamailio/commit/a704f7d68dddfaa9719acb7b04f4058… --- diff --git a/src/modules/ims_isc/third_party_reg.c b/src/modules/ims_isc/third_party_reg.c index f5c780feed..b07773efa8 100644 --- a/src/modules/ims_isc/third_party_reg.c +++ b/src/modules/ims_isc/third_party_reg.c @@ -173,7 +173,7 @@ int build_p_associated_uri(ims_subscription* s) { if (cnt == 0 && cnttel == 0){ *p++ = '<'; } else if(cnttel != 0 && cnt == 0){ - memcpy(p, ", <", 2); + memcpy(p, ", <", 3); p += 3; } else { memcpy(p, ">, <", 4);

1 0

git:master:91408caf: ims_isc : fixed P-associated-uri header constructing
by Yasin CANER 01 Feb '19

01 Feb '19

Module: kamailio Branch: master Commit: 91408cafec655f98a7f5915fbee33be27ec299fa URL: https://github.com/kamailio/kamailio/commit/91408cafec655f98a7f5915fbee33be… Author: Yasin CANER <caner_yaso(a)hotmail.com> Committer: Yasin CANER <caner_yaso(a)hotmail.com> Date: 2019-01-30T07:47:17+03:00 ims_isc : fixed P-associated-uri header constructing fixed P-associated-uri header construncting. it now creates sip and tel uri and appending to header. --- Modified: src/modules/ims_isc/third_party_reg.c --- Diff: https://github.com/kamailio/kamailio/commit/91408cafec655f98a7f5915fbee33be… Patch: https://github.com/kamailio/kamailio/commit/91408cafec655f98a7f5915fbee33be…

1 0

git:master:414bceec: ims_isc : fixed memory leak
by GitHub 01 Feb '19

01 Feb '19

Module: kamailio Branch: master Commit: 414bceec25ba7cbfdd5ef607f772e7d2a8335d34 URL: https://github.com/kamailio/kamailio/commit/414bceec25ba7cbfdd5ef607f772e7d… Author: Yasin CANER <caner_yaso(a)hotmail.com> Committer: GitHub <noreply(a)github.com> Date: 2019-01-30T07:24:05+03:00 ims_isc : fixed memory leak fixed memory leak for third_part_registration body value. --- Modified: src/modules/ims_isc/third_party_reg.c --- Diff: https://github.com/kamailio/kamailio/commit/414bceec25ba7cbfdd5ef607f772e7d… Patch: https://github.com/kamailio/kamailio/commit/414bceec25ba7cbfdd5ef607f772e7d… --- diff --git a/src/modules/ims_isc/third_party_reg.c b/src/modules/ims_isc/third_party_reg.c index b54d4e07d4..62cac53f54 100644 --- a/src/modules/ims_isc/third_party_reg.c +++ b/src/modules/ims_isc/third_party_reg.c @@ -403,9 +403,9 @@ int r_send_third_party_reg(r_third_party_registration *r, int expires) { } if (r->cv.len) { - STR_APPEND(h, p_charging_vector_s); - STR_APPEND(h, r->cv); - STR_APPEND(h, p_charging_vector_e); + STR_APPEND(h, p_charging_vector_s); + STR_APPEND(h, r->cv); + STR_APPEND(h, p_charging_vector_e); } if (p_associated_uri.data_len > 0) { @@ -436,11 +436,15 @@ int r_send_third_party_reg(r_third_party_registration *r, int expires) { } if (h.s) pkg_free(h.s); + if (b.s) + pkg_free(b.s); return 1; error: if (h.s) pkg_free(h.s); + if (b.s) + pkg_free(b.s); return 0; }

1 0

git:master:4d775faf: Merge pull request #1824 from jchavanton/dns_slow_query
by GitHub 01 Feb '19

01 Feb '19

Module: kamailio Branch: master Commit: 4d775fafa9f2dba6630fc0318616f26f7b72886e URL: https://github.com/kamailio/kamailio/commit/4d775fafa9f2dba6630fc0318616f26… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2019-02-01T19:59:00+01:00 Merge pull request #1824 from jchavanton/dns_slow_query core: dns slow queries reporting --- Modified: src/core/cfg.lex Modified: src/core/cfg.y Modified: src/core/cfg_core.c Modified: src/core/cfg_core.h Modified: src/core/resolve.c Modified: src/core/resolve.h --- Diff: https://github.com/kamailio/kamailio/commit/4d775fafa9f2dba6630fc0318616f26… Patch: https://github.com/kamailio/kamailio/commit/4d775fafa9f2dba6630fc0318616f26…

1 0

[kamailio/kamailio] core: dns slow queries reporting (#1824)
by Julien Chavanton 01 Feb '19

01 Feb '19

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description I remember there was some discussion about adding DNS statistics, I think I remember a discussion involving @ngvoice Carsten ? This is adding a parameter to the core `dns_slow_query_ms` Example: ``` dns_slow_query_ms=100 ``` When using the internal resolver any query taking more than `dns_slow_query_ms` will be lodged as a warning : ``` dns_slow_query_ms=10 (example with 10ms) 5(5960) WARNING: <core> [core/resolve.c:752]: get_record(): res_search[35][us-west-wa.sip.flowroute.com]elapsed[12ms] 5(5960) WARNING: <core> [core/resolve.c:752]: get_record(): res_search[1][ep-us-west-wa-01.flowroute.com]elapsed[12ms] ``` and a statistic counter will be incremented : ``` kamcmd stats.fetch dns:slow_dns_request { dns.slow_dns_request: 1 } ``` I think this will be a good start to monitor the impact of slow DNS queries on Kamailio. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1824 -- Commit Summary -- * core: dns slow queries reporting -- File Changes -- M src/core/cfg.lex (3) M src/core/cfg.y (3) M src/core/cfg_core.c (3) M src/core/cfg_core.h (1) M src/core/resolve.c (17) M src/core/resolve.h (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1824.patch https://github.com/kamailio/kamailio/pull/1824.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1824

2 4

git:master:9a69321c: core: dns slow queries reporting
by Julien Chavanton 01 Feb '19

01 Feb '19

Module: kamailio Branch: master Commit: 9a69321c5cc1f69b1c62d0d0190d6e79a41647e3 URL: https://github.com/kamailio/kamailio/commit/9a69321c5cc1f69b1c62d0d0190d6e7… Author: Julien Chavanton <jchavanton(a)gmail.com> Committer: Julien Chavanton <jchavanton(a)gmail.com> Date: 2019-01-31T20:39:08Z core: dns slow queries reporting --- Modified: src/core/cfg.lex Modified: src/core/cfg.y Modified: src/core/cfg_core.c Modified: src/core/cfg_core.h Modified: src/core/resolve.c Modified: src/core/resolve.h --- Diff: https://github.com/kamailio/kamailio/commit/9a69321c5cc1f69b1c62d0d0190d6e7… Patch: https://github.com/kamailio/kamailio/commit/9a69321c5cc1f69b1c62d0d0190d6e7…

1 0

Re: [sr-dev] [kamailio/kamailio] dialog: do not require dlg_flag parameter to be set (404f403)
by PICCORO Lenz McKAY 01 Feb '19

01 Feb '19

this fix are need by 5.1 and 5.2 to property wrok the BLF feature... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/404f403786478a917637186446bb285…

1 0

git:5.1:82aad65c: Merge pull request #1826 from sergey-safarov/5.1
by GitHub 01 Feb '19

01 Feb '19

Module: kamailio Branch: 5.1 Commit: 82aad65cb991c4690076ad44df5449662a2b683a URL: https://github.com/kamailio/kamailio/commit/82aad65cb991c4690076ad44df54496… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2019-02-01T19:42:18+01:00 Merge pull request #1826 from sergey-safarov/5.1 [5.1] set of cherry-pick to properly package on alpine dists --- Modified: pkg/docker Modified: pkg/kamailio/alpine/APKBUILD Modified: pkg/kamailio/alpine/kamailio.initd Removed: pkg/kamailio/alpine/0004-src_core_tcp_read_c.patch Removed: pkg/kamailio/alpine/kamctl_build.patch --- Diff: https://github.com/kamailio/kamailio/commit/82aad65cb991c4690076ad44df54496… Patch: https://github.com/kamailio/kamailio/commit/82aad65cb991c4690076ad44df54496…

1 0

git:5.1:78e948d9: kamdbctl: Merged patch from alpine packaging (#1786)
by Sergey Safarov 01 Feb '19

01 Feb '19

Module: kamailio Branch: 5.1 Commit: 78e948d9e8003c716ed67ff82cf8c7803e35e7df URL: https://github.com/kamailio/kamailio/commit/78e948d9e8003c716ed67ff82cf8c78… Author: sergey-safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2019-01-31T16:19:03+03:00 kamdbctl: Merged patch from alpine packaging (#1786) - kamdbctl: Merged patch from alpine packaging (#1786) - add proper quoting for DB table and module definitions (cherry picked from commit c6e62f932495af188c89bf06b468d1bb19579267) --- Modified: pkg/kamailio/alpine/APKBUILD --- Diff: https://github.com/kamailio/kamailio/commit/78e948d9e8003c716ed67ff82cf8c78… Patch: https://github.com/kamailio/kamailio/commit/78e948d9e8003c716ed67ff82cf8c78… --- diff --git a/pkg/kamailio/alpine/APKBUILD b/pkg/kamailio/alpine/APKBUILD index 5e2b11d035..acf61eb249 100644 --- a/pkg/kamailio/alpine/APKBUILD +++ b/pkg/kamailio/alpine/APKBUILD @@ -250,7 +250,6 @@ for _i in db postgres sqlite dbtext mysql \ done source="${pkgname}-${pkgver}${_suffix}.tar.gz::https://github.com/kamailio/$pkgname/archive/$_gitcommit.tar.gz - 0001-kamdbctl.base.patch kamailio.initd " @@ -549,5 +548,4 @@ sipdump() { } sha512sums="51ea5fccd27a9d3d1783cfc5596eb28ab27e34faeec3268600363f43c48a3634c3c584c479ba874fdb53b85766a0ce8fe7df0e20954c9c6514b1d9d41d9237e6 kamailio-5.1.0.20171125-991fe9b.tar.gz -6badfb611c02ffcb4c2e9937731162ea1a4b737f042ed52120e2f96ebb80b5b7d240b5612c9ca565e693eec9b8c52c1ee5db04dfc47d204501021f984b4b11db 0001-kamdbctl.base.patch 321b1b160434150bcde3c0ad7f47ddf259791b68d4ce74ba4c35034026421a2bc6f5e86f26f393f5fcdb523d8cd75f944709473065553ce860b0ea06b3dc2a1b kamailio.initd"

1 0

git:5.1:889b9295: pkg/docker: Alpine switched to use openssl. Updated rules for alpine docker container
by Sergey Safarov 01 Feb '19

01 Feb '19

Module: kamailio Branch: 5.1 Commit: 889b929539a2fe2e44bc61f82c8fd407e8eae643 URL: https://github.com/kamailio/kamailio/commit/889b929539a2fe2e44bc61f82c8fd40… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2019-01-31T15:01:52+03:00 pkg/docker: Alpine switched to use openssl. Updated rules for alpine docker container (cherry picked from commit 37bff4588803a70873babdb483804e3734b42900) --- Modified: pkg/kamailio/alpine/APKBUILD Removed: pkg/kamailio/alpine/0004-src_core_tcp_read_c.patch --- Diff: https://github.com/kamailio/kamailio/commit/889b929539a2fe2e44bc61f82c8fd40… Patch: https://github.com/kamailio/kamailio/commit/889b929539a2fe2e44bc61f82c8fd40… --- diff --git a/pkg/kamailio/alpine/0004-src_core_tcp_read_c.patch b/pkg/kamailio/alpine/0004-src_core_tcp_read_c.patch deleted file mode 100644 index 08308f77b1..0000000000 --- a/pkg/kamailio/alpine/0004-src_core_tcp_read_c.patch +++ /dev/null @@ -1,20 +0,0 @@ -$OpenBSD: patch-src_core_tcp_read_c,v 1.1 2017/07/03 22:14:20 sthen Exp $ - -Index: a/src/core/tcp_read.c ---- a/src/core/tcp_read.c.orig -+++ a/src/core/tcp_read.c -@@ -1497,6 +1497,14 @@ void release_tcpconn(struct tcp_connection* c, long st - ip_addr2a(&c->rcv.src_ip), c->rcv.src_port, - ip_addr2a(&c->rcv.dst_ip), c->rcv.dst_port); - LM_DBG("extra_data %p\n", c->extra_data); -+ -+ /* experimental fix tls crash with libressl */ -+ /* add cleanup SSL structure in child process, in parent process SSL structure is empty */ -+ if ((c->type==PROTO_TLS || c->type==PROTO_WSS) && (c->extra_data) && c->fd != -1) { -+ tls_close(c, c->fd); -+ tls_tcpconn_clean(c); -+ } -+ - /* release req & signal the parent */ - c->reader_pid=0; /* reset it */ - if (c->fd!=-1){ diff --git a/pkg/kamailio/alpine/APKBUILD b/pkg/kamailio/alpine/APKBUILD index 9d1497b3f9..5e2b11d035 100644 --- a/pkg/kamailio/alpine/APKBUILD +++ b/pkg/kamailio/alpine/APKBUILD @@ -27,7 +27,7 @@ depends="gawk" options="!check" makedepends="bison db-dev flex freeradius-client-dev expat-dev lksctp-tools-dev perl-dev postgresql-dev python2-dev pcre-dev mariadb-dev libxml2-dev curl-dev unixodbc-dev confuse-dev ncurses-dev sqlite-dev - lua-dev openldap-dev libressl-dev net-snmp-dev libuuid libev-dev + lua-dev openldap-dev openssl-dev net-snmp-dev libuuid libev-dev jansson-dev json-c-dev libevent-dev linux-headers libmemcached-dev rabbitmq-c-dev hiredis-dev libmaxminddb-dev libunistring-dev" install="$pkgname.pre-install $pkgname.pre-upgrade" @@ -250,7 +250,7 @@ for _i in db postgres sqlite dbtext mysql \ done source="${pkgname}-${pkgver}${_suffix}.tar.gz::https://github.com/kamailio/$pkgname/archive/$_gitcommit.tar.gz - 0004-src_core_tcp_read_c.patch + 0001-kamdbctl.base.patch kamailio.initd " @@ -549,5 +549,5 @@ sipdump() { } sha512sums="51ea5fccd27a9d3d1783cfc5596eb28ab27e34faeec3268600363f43c48a3634c3c584c479ba874fdb53b85766a0ce8fe7df0e20954c9c6514b1d9d41d9237e6 kamailio-5.1.0.20171125-991fe9b.tar.gz -af8362201957eae6b66baf7368c9ca884024209a396d77c5c52180c9aabe13772e9c6513e59721d39503e5bb7a8c1030f5c10301ea9055bddafb7f01ee2f3076 0004-src_core_tcp_read_c.patch +6badfb611c02ffcb4c2e9937731162ea1a4b737f042ed52120e2f96ebb80b5b7d240b5612c9ca565e693eec9b8c52c1ee5db04dfc47d204501021f984b4b11db 0001-kamdbctl.base.patch 321b1b160434150bcde3c0ad7f47ddf259791b68d4ce74ba4c35034026421a2bc6f5e86f26f393f5fcdb523d8cd75f944709473065553ce860b0ea06b3dc2a1b kamailio.initd"

1 0

git:5.1:d56615e7: pkg/kamailio/alpine: Update APKBUILD
by Sergey Safarov 01 Feb '19

01 Feb '19

Module: kamailio Branch: 5.1 Commit: d56615e76622c428985d6fc9a3d31bf9e4943543 URL: https://github.com/kamailio/kamailio/commit/d56615e76622c428985d6fc9a3d31bf… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2019-01-31T14:59:20+03:00 pkg/kamailio/alpine: Update APKBUILD (cherry picked from commit 6aca6c0ddc201882d1ab75e662299450f578aa32) --- Modified: pkg/kamailio/alpine/APKBUILD Modified: pkg/kamailio/alpine/kamailio.initd Removed: pkg/kamailio/alpine/kamctl_build.patch --- Diff: https://github.com/kamailio/kamailio/commit/d56615e76622c428985d6fc9a3d31bf… Patch: https://github.com/kamailio/kamailio/commit/d56615e76622c428985d6fc9a3d31bf…

1 0

git:5.1:08161fe7: pkg/docker: Updated submodule
by Sergey Safarov 01 Feb '19

01 Feb '19

Module: kamailio Branch: 5.1 Commit: 08161fe70a0dc25d7aaf377f7c362f81984ce068 URL: https://github.com/kamailio/kamailio/commit/08161fe70a0dc25d7aaf377f7c362f8… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2019-01-31T14:55:03+03:00 pkg/docker: Updated submodule --- Modified: pkg/docker --- Diff: https://github.com/kamailio/kamailio/commit/08161fe70a0dc25d7aaf377f7c362f8… Patch: https://github.com/kamailio/kamailio/commit/08161fe70a0dc25d7aaf377f7c362f8… --- diff --git a/pkg/docker b/pkg/docker index 3c8a156abe..b92a1c899b 160000 --- a/pkg/docker +++ b/pkg/docker @@ -1 +1 @@ -Subproject commit 3c8a156abef2a034d9a21df5bf73f4b5cc4d3e05 +Subproject commit b92a1c899b8c474afadd0cf29dd7cb4ea01a3466

1 0

[kamailio/kamailio] [5.1] set of cherry-pick to properly package on alpine dists (#1826)
by sergey-safarov 01 Feb '19

01 Feb '19

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1826 -- Commit Summary -- * pkg/docker: Updated submodule * pkg/kamailio/alpine: Update APKBUILD * pkg/docker: Alpine switched to use openssl. Updated rules for alpine docker container * kamdbctl: Merged patch from alpine packaging (#1786) -- File Changes -- M pkg/docker (2) D pkg/kamailio/alpine/0004-src_core_tcp_read_c.patch (20) M pkg/kamailio/alpine/APKBUILD (12) M pkg/kamailio/alpine/kamailio.initd (2) D pkg/kamailio/alpine/kamctl_build.patch (236) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1826.patch https://github.com/kamailio/kamailio/pull/1826.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1826

2 4

git:master:ec993297: modules: readme files regenerated - rr ... [skip ci]
by Kamailio Dev 01 Feb '19

01 Feb '19

Module: kamailio Branch: master Commit: ec993297b38b5d90e88d838f7d126317d6ab4641 URL: https://github.com/kamailio/kamailio/commit/ec993297b38b5d90e88d838f7d12631… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2019-02-01T19:31:45+01:00 modules: readme files regenerated - rr ... [skip ci] --- Modified: src/modules/rr/README --- Diff: https://github.com/kamailio/kamailio/commit/ec993297b38b5d90e88d838f7d12631… Patch: https://github.com/kamailio/kamailio/commit/ec993297b38b5d90e88d838f7d12631… --- diff --git a/src/modules/rr/README b/src/modules/rr/README index 9feab35738..4fe696ee3a 100644 --- a/src/modules/rr/README +++ b/src/modules/rr/README @@ -408,6 +408,7 @@ modparam("rr", "ignore_sips", 1) * 2 - route calculation based on flow-token has been successful * -1 - route calculation has been unsuccessful * -2 - outbound flow-token shows evidence of tampering + * -3 - next hop is taken from a preloaded route set This function can be used from REQUEST_ROUTE.

1 0

git:master:98056258: Merge pull request #1830 from gaaf/rr-lr-retval
by GitHub 01 Feb '19

01 Feb '19

Module: kamailio Branch: master Commit: 98056258b7ebdc65c8147d9d057bc350a38e55f8 URL: https://github.com/kamailio/kamailio/commit/98056258b7ebdc65c8147d9d057bc35… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2019-02-01T19:25:34+01:00 Merge pull request #1830 from gaaf/rr-lr-retval rr: Add new return value for preloaded route set to loose_route() --- Modified: src/modules/rr/doc/rr_admin.xml Modified: src/modules/rr/loose.c --- Diff: https://github.com/kamailio/kamailio/commit/98056258b7ebdc65c8147d9d057bc35… Patch: https://github.com/kamailio/kamailio/commit/98056258b7ebdc65c8147d9d057bc35… --- diff --git a/src/modules/rr/doc/rr_admin.xml b/src/modules/rr/doc/rr_admin.xml index 7dd1868e2a..74e59abe82 100644 --- a/src/modules/rr/doc/rr_admin.xml +++ b/src/modules/rr/doc/rr_admin.xml @@ -364,7 +364,7 @@ modparam("rr", "ignore_sips", 1) <listitem> <para><emphasis>2</emphasis> - route calculation based on - flow-token has been successful</para> + flow-token has been successful</para> </listitem> <listitem> @@ -376,6 +376,11 @@ modparam("rr", "ignore_sips", 1) <para><emphasis>-2</emphasis> - outbound flow-token shows evidence of tampering</para> </listitem> + + <listitem> + <para><emphasis>-3</emphasis> - next hop is taken from + a preloaded route set</para> + </listitem> </itemizedlist> <para>This function can be used from REQUEST_ROUTE.</para> diff --git a/src/modules/rr/loose.c b/src/modules/rr/loose.c index 6e9e888a2b..efe428a1cd 100644 --- a/src/modules/rr/loose.c +++ b/src/modules/rr/loose.c @@ -48,6 +48,7 @@ #define RR_OB_DRIVEN 2 /*!< The next hop is determined from the route set based on flow-token */ #define NOT_RR_DRIVEN -1 /*!< The next hop is not determined from the route set */ #define FLOW_TOKEN_BROKEN -2 /*!< Outbound flow-token shows evidence of tampering */ +#define RR_PRELOADED -3 /*!< The next hop is determined from a preloaded route set */ #define RR_ROUTE_PREFIX ROUTE_PREFIX "<" #define RR_ROUTE_PREFIX_LEN (sizeof(RR_ROUTE_PREFIX)-1) @@ -840,7 +841,7 @@ static inline int after_loose(struct sip_msg* _m, int preloaded) } if (res > 0) { /* No next route found */ LM_DBG("No next URI found\n"); - status = (preloaded ? NOT_RR_DRIVEN : RR_DRIVEN); + status = (preloaded ? RR_PRELOADED : RR_DRIVEN); goto done; } rt = (rr_t*)hdr->parsed; @@ -873,7 +874,7 @@ static inline int after_loose(struct sip_msg* _m, int preloaded) } if (res > 0) { /* No next route found */ LM_DBG("no next URI found\n"); - status = (preloaded ? NOT_RR_DRIVEN : RR_DRIVEN); + status = (preloaded ? RR_PRELOADED : RR_DRIVEN); goto done; } rt = (rr_t*)hdr->parsed;

1 0

git:master:c5b8e5b3: rr: Add new return value for preloaded route set to loose_route()
by Alex Hermann 01 Feb '19

01 Feb '19

Module: kamailio Branch: master Commit: c5b8e5b3a82ac0f61a059f69921866952405ffe5 URL: https://github.com/kamailio/kamailio/commit/c5b8e5b3a82ac0f61a059f699218669… Author: Alex Hermann <alex(a)hexla.nl> Committer: Alex Hermann <alex(a)hexla.nl> Date: 2019-02-01T11:14:10+01:00 rr: Add new return value for preloaded route set to loose_route() Instead of returning just -1 (error), return a dedicated value. Now it is possible to detect from the script if a preloaded Route header was removed that pointed at the local proxy. The new return code is kept negative, so all code checking for failure response keeps working. --- Modified: src/modules/rr/doc/rr_admin.xml Modified: src/modules/rr/loose.c --- Diff: https://github.com/kamailio/kamailio/commit/c5b8e5b3a82ac0f61a059f699218669… Patch: https://github.com/kamailio/kamailio/commit/c5b8e5b3a82ac0f61a059f699218669… --- diff --git a/src/modules/rr/doc/rr_admin.xml b/src/modules/rr/doc/rr_admin.xml index 7dd1868e2a..74e59abe82 100644 --- a/src/modules/rr/doc/rr_admin.xml +++ b/src/modules/rr/doc/rr_admin.xml @@ -364,7 +364,7 @@ modparam("rr", "ignore_sips", 1) <listitem> <para><emphasis>2</emphasis> - route calculation based on - flow-token has been successful</para> + flow-token has been successful</para> </listitem> <listitem> @@ -376,6 +376,11 @@ modparam("rr", "ignore_sips", 1) <para><emphasis>-2</emphasis> - outbound flow-token shows evidence of tampering</para> </listitem> + + <listitem> + <para><emphasis>-3</emphasis> - next hop is taken from + a preloaded route set</para> + </listitem> </itemizedlist> <para>This function can be used from REQUEST_ROUTE.</para> diff --git a/src/modules/rr/loose.c b/src/modules/rr/loose.c index 6e9e888a2b..efe428a1cd 100644 --- a/src/modules/rr/loose.c +++ b/src/modules/rr/loose.c @@ -48,6 +48,7 @@ #define RR_OB_DRIVEN 2 /*!< The next hop is determined from the route set based on flow-token */ #define NOT_RR_DRIVEN -1 /*!< The next hop is not determined from the route set */ #define FLOW_TOKEN_BROKEN -2 /*!< Outbound flow-token shows evidence of tampering */ +#define RR_PRELOADED -3 /*!< The next hop is determined from a preloaded route set */ #define RR_ROUTE_PREFIX ROUTE_PREFIX "<" #define RR_ROUTE_PREFIX_LEN (sizeof(RR_ROUTE_PREFIX)-1) @@ -840,7 +841,7 @@ static inline int after_loose(struct sip_msg* _m, int preloaded) } if (res > 0) { /* No next route found */ LM_DBG("No next URI found\n"); - status = (preloaded ? NOT_RR_DRIVEN : RR_DRIVEN); + status = (preloaded ? RR_PRELOADED : RR_DRIVEN); goto done; } rt = (rr_t*)hdr->parsed; @@ -873,7 +874,7 @@ static inline int after_loose(struct sip_msg* _m, int preloaded) } if (res > 0) { /* No next route found */ LM_DBG("no next URI found\n"); - status = (preloaded ? NOT_RR_DRIVEN : RR_DRIVEN); + status = (preloaded ? RR_PRELOADED : RR_DRIVEN); goto done; } rt = (rr_t*)hdr->parsed;

1 0

[kamailio/kamailio] rr: Add new return value for preloaded route set to loose_route() (#1830)
by Alex Hermann 01 Feb '19

01 Feb '19

Instead of returning just -1 (error), return a dedicated value. Now it is possible to detect from the script if a preloaded Route header was removed that pointed at the local proxy. The new return code is kept negative, so all code checking for failure response keeps working.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1830 -- Commit Summary -- * rr: Add new return value for preloaded route set to loose_route() -- File Changes -- M src/modules/rr/doc/rr_admin.xml (7) M src/modules/rr/loose.c (5) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1830.patch https://github.com/kamailio/kamailio/pull/1830.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1830

2 2

git:master:9f9ec197: src/Makefile: added target to install files for systemd on Centos 7 (#1831)
by Daniel-Constantin Mierla 01 Feb '19

01 Feb '19

Module: kamailio Branch: master Commit: 9f9ec197e029dca44ac57575b214a32916c838cb URL: https://github.com/kamailio/kamailio/commit/9f9ec197e029dca44ac57575b214a32… Author: Yasin CANER <caner_yaso(a)hotmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-02-01T19:23:56+01:00 src/Makefile: added target to install files for systemd on Centos 7 (#1831) * src/Makefile: added target to install files for systemd on Centos 7 added target to install systemd and sysconfig files for systemd service installation method : make install-systemd-centos * src/makefile : add --system parameter for user src/makefile : add --system parameter for user after rebooting , /run/kamailio folder is survived. --- Modified: src/Makefile --- Diff: https://github.com/kamailio/kamailio/commit/9f9ec197e029dca44ac57575b214a32… Patch: https://github.com/kamailio/kamailio/commit/9f9ec197e029dca44ac57575b214a32… --- diff --git a/src/Makefile b/src/Makefile index 593da28166..cd772c877b 100644 --- a/src/Makefile +++ b/src/Makefile @@ -1041,6 +1041,28 @@ install_systemd_debian install-systemd-debian: @echo "* to enable kamailio service run:" @echo " systemctl enable kamailio" @echo " systemctl daemon-reload" +.PHONY: install_systemd_centos install-systemd-centos +install_systemd_centos install-systemd-centos: + sed -e "s#ExecStart=/usr/sbin/kamailio#ExecStart=$(bin_prefix)/$(bin_dir)$(NAME)#g" \ + -e "s#Description=Kamailio#Description=$(NAME)#g" \ + -e "s#/var/run/kamailio/kamailio.pid#/var/run/$(NAME)/$(NAME).pid#g" \ + -e "s#EnvironmentFile=-/etc/sysconfig/kamailio#EnvironmentFile=-/etc/sysconfig/$(NAME)#g" \ + -e "s#CFGFILE=/etc/kamailio/kamailio.cfg#CFGFILE=$(cfg_prefix)/$(cfg_dir)$(NAME).cfg#g" \ + < ../pkg/kamailio/obs/kamailio.service \ + > /etc/systemd/system/$(NAME).service + cp ../pkg/kamailio/obs/kamailio.sysconfig \ + /etc/sysconfig/$(NAME) + mkdir -p /var/run/$(NAME) + chmod 0700 /var/run/$(NAME) + groupadd --system $(NAME) + useradd $(NAME) --system --shell /sbin/nologin -g $(NAME) --home /var/run/$(NAME) + chown $(NAME):$(NAME) /var/run/$(NAME) + echo "D /run/$(NAME) 0700 $(NAME) $(NAME) -" > /etc/tmpfiles.d/$(NAME).conf + @echo + @echo "* to enable kamailio service run:" + @echo " systemctl daemon-reload" + @echo " systemctl enable kamailio" + @echo " systemctl start kamailio" .PHONY: dbschema dbschema:

1 0

[kamailio/kamailio] src/Makefile: added target to install files for systemd on Centos 7 (#1831)
by Yasin CANER 01 Feb '19

01 Feb '19

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  added target to install systemd and sysconfig files for systemd service installation method : make install-systemd-centos You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1831 -- Commit Summary -- * src/Makefile: added target to install files for systemd on Centos 7 -- File Changes -- M src/Makefile (21) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1831.patch https://github.com/kamailio/kamailio/pull/1831.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1831

2 4

[kamailio/kamailio] bug: RPCFIFOPATH / DEFINE_FIFO_NAME invalid acces due changed to root at run (#1827)
by PICCORO Lenz McKAY 01 Feb '19

01 Feb '19

### Description the /var/run/kamailio directory for the fifo and crtl files are denied for acces to the service as i can see directory are owed byt root and only ower and group have access kamailio 4.4 backported by me for Debian jessie have this: `drwxr-xr-x 2 kamailio kamailio 100 Aug 15 17:33 kamailio` kamailio 5.2 installed on buster/testing build from sources: `drwxr-x--- 2 root root 120 Jan 30 09:35 kamailio` **NOTE** no definiton are setup, and surprise if i defined some, the only working dir are /tmp !!! ### Troubleshooting kamailio 4.4 backported by me for Debian jessie have this: `drwxr-xr-x 2 kamailio kamailio 100 Aug 15 17:33 kamailio` kamailio 5.2 installed on buster/testing build from sources: `drwxr-x--- 2 root root 120 Jan 30 09:35 kamailio` due that several issues are happened if we started using some modules due unable to manage the socket control: ``` Jan 31 15:35:51 venenux-debian kamailio[16861]: 17(16889) ERROR: <core> [core/io_wait.h:1040]: io_wait_loop_epoll(): epoll_wait(7, 0x7f6ed6f88d88, 0, 5000): Invalid argument [22] Jan 31 15:35:51 venenux-debian kamailio[16861]: 0(16863) ERROR: ctl [ctl.c:390]: mod_destroy(): ERROR: ctl: could not delete unix socket /var/run/kamailio//kamailio_ctl: Permission denied (13) Jan 31 15:35:51 venenux-debian kamailio[16861]: 0(16863) DEBUG: <core> [db_pool.c:100]: pool_remove(): removing connection from the pool Jan 31 15:35:51 venenux-debian kamailio[16861]: 0(16863) DEBUG: tm [t_funcs.c:85]: tm_shutdown(): start Jan 31 15:35:51 venenux-debian kamailio[16861]: 0(16863) DEBUG: tm [t_funcs.c:88]: tm_shutdown(): emptying hash table Jan 31 15:35:51 venenux-debian kamailio[16861]: 0(16863) DEBUG: tm [t_funcs.c:90]: tm_shutdown(): removing semaphores Jan 31 15:35:51 venenux-debian kamailio[16861]: 0(16863) DEBUG: tm [t_funcs.c:92]: tm_shutdown(): destroying tmcb lists Jan 31 15:35:51 venenux-debian kamailio[16861]: 0(16863) DEBUG: tm [t_funcs.c:95]: tm_shutdown(): done Jan 31 15:35:51 venenux-debian kamailio[16861]: 0(16863) ERROR: jsonrpcs [jsonrpcs_fifo.c:599]: jsonrpc_fifo_destroy(): FIFO stat failed: Permission denied Jan 31 15:35:51 venenux-debian kamailio[16861]: 0(16863) ERROR: jsonrpcs [jsonrpcs_sock.c:516]: jsonrpc_dgram_destroy(): socket stat failed: Permission denied ``` #### Reproduction build from sources with default values enable dialog, blf support and asterisk and start service.. when try to control using socket kamailio cannot comunicate with itselft! very ironic! #### Log Messages ``` Jan 31 15:35:51 venenux-debian kamailio[16861]: 17(16889) ERROR: <core> [core/io_wait.h:1040]: io_wait_loop_epoll(): epoll_wait(7, 0x7f6ed6f88d88, 0, 5000): Invalid argument [22] Jan 31 15:35:51 venenux-debian kamailio[16861]: 0(16863) ERROR: ctl [ctl.c:390]: mod_destroy(): ERROR: ctl: could not delete unix socket /var/run/kamailio//kamailio_ctl: Permission denied (13) Jan 31 15:35:51 venenux-debian kamailio[16861]: 0(16863) DEBUG: <core> [db_pool.c:100]: pool_remove(): removing connection from the pool Jan 31 15:35:51 venenux-debian kamailio[16861]: 0(16863) DEBUG: tm [t_funcs.c:85]: tm_shutdown(): start Jan 31 15:35:51 venenux-debian kamailio[16861]: 0(16863) DEBUG: tm [t_funcs.c:88]: tm_shutdown(): emptying hash table Jan 31 15:35:51 venenux-debian kamailio[16861]: 0(16863) DEBUG: tm [t_funcs.c:90]: tm_shutdown(): removing semaphores Jan 31 15:35:51 venenux-debian kamailio[16861]: 0(16863) DEBUG: tm [t_funcs.c:92]: tm_shutdown(): destroying tmcb lists Jan 31 15:35:51 venenux-debian kamailio[16861]: 0(16863) DEBUG: tm [t_funcs.c:95]: tm_shutdown(): done Jan 31 15:35:51 venenux-debian kamailio[16861]: 0(16863) ERROR: jsonrpcs [jsonrpcs_fifo.c:599]: jsonrpc_fifo_destroy(): FIFO stat failed: Permission denied Jan 31 15:35:51 venenux-debian kamailio[16861]: 0(16863) ERROR: jsonrpcs [jsonrpcs_sock.c:516]: jsonrpc_dgram_destroy(): socket stat failed: Permission denied ``` #### SIP Traffic NOT RELATED ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.2.1 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 4.9.2 ``` * **Operating System**: ``` Debian buster/testing ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1827

2 2

git:5.2:9ead1778: src/Makefile: added target to install files for systemd on debian
by Daniel-Constantin Mierla 01 Feb '19

01 Feb '19

Module: kamailio Branch: 5.2 Commit: 9ead1778f6df817192b9cbf805169895bb647035 URL: https://github.com/kamailio/kamailio/commit/9ead1778f6df817192b9cbf80516989… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-02-01T08:17:53+01:00 src/Makefile: added target to install files for systemd on debian * make install-systemd-debian (cherry picked from commit ddbf18352f189b8aa1ae5e5f1d83d42db6fcc0d2) --- Modified: src/Makefile --- Diff: https://github.com/kamailio/kamailio/commit/9ead1778f6df817192b9cbf80516989… Patch: https://github.com/kamailio/kamailio/commit/9ead1778f6df817192b9cbf80516989… --- diff --git a/src/Makefile b/src/Makefile index 5b67d7ad67..593da28166 100644 --- a/src/Makefile +++ b/src/Makefile @@ -1019,6 +1019,29 @@ install_initd_centos install-initd-centos: -d /var/run/$(NAME) $(NAME) chown $(NAME):$(NAME) /var/run/$(NAME) +.PHONY: install_systemd_debian install-systemd-debian +install_systemd_debian install-systemd-debian: + sed -e "s#ExecStart=/usr/sbin/kamailio#ExecStart=$(bin_prefix)/$(bin_dir)$(NAME)#g" \ + -e "s#Description=Kamailio#Description=$(NAME)#g" \ + -e "s#/var/run/kamailio/kamailio.pid#/var/run/$(NAME)/$(NAME).pid#g" \ + -e "s#EnvironmentFile=-/etc/default/kamailio#EnvironmentFile=-/etc/default/$(NAME)#g" \ + -e "s#CFGFILE=/etc/kamailio/kamailio.cfg#CFGFILE=$(cfg_prefix)/$(cfg_dir)$(NAME).cfg#g" \ + < ../pkg/kamailio/deb/debian/kamailio.service \ + > /etc/systemd/system/$(NAME).service + sed -e "s#RUN_KAMAILIO=no#RUN_KAMAILIO=yes#g" \ + < ../pkg/kamailio/deb/debian/kamailio.default \ + > /etc/default/$(NAME) + mkdir -p /var/run/$(NAME) + adduser --quiet --system --group --disabled-password \ + --shell /bin/false --gecos "$(NAME)" \ + --home /var/run/$(NAME) $(NAME) + chown $(NAME):$(NAME) /var/run/$(NAME) + echo "D /run/$(NAME) 0700 $(NAME) $(NAME) -" > /etc/tmpfiles.d/$(NAME).conf + @echo + @echo "* to enable kamailio service run:" + @echo " systemctl enable kamailio" + @echo " systemctl daemon-reload" + .PHONY: dbschema dbschema: -@echo "Build database schemas"

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2019