sr-dev November 2019

sr-dev@lists.kamailio.org

22 participants
381 discussions

[kamailio/kamailio] kafka: module to produce and send messages to a Kafka server (#2112)
by vhernando 04 Nov '19

04 Nov '19

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Module to produce and send messages to a Kafka server busing librdkafka library. I copy part of README file here: Chapter 1. Admin Guide Table of Contents 1. Overview 2. Dependencies 2.1. Kamailio Modules 2.2. External Libraries or Applications 2.3. Parameters 2.3.1. brokers (string) 2.3.2. configuration (string) 2.3.3. topic (string) 2.4. Functions 2.4.1. kafka_send(topic, msg) 2.5. RPC Commands 2.5.1. kafka.stats 2.5.2. kafka.stats_topic 1. Overview This module produces and sends messages to a Kafka server. 2. Dependencies 2.1. Kamailio Modules 2.2. External Libraries or Applications 2.3. Parameters 2.3.1. brokers (string) 2.3.2. configuration (string) 2.3.3. topic (string) 2.4. Functions 2.4.1. kafka_send(topic, msg) 2.5. RPC Commands 2.5.1. kafka.stats 2.5.2. kafka.stats_topic 2.1. Kamailio Modules The following modules must be loaded before this module: * none. 2.2. External Libraries or Applications The following libraries or applications must be installed before running Kamailio with this module loaded: * librdkafka: the Apache Kafka C/C++ client library. https://github.com/edenhill/librdkafka 2.3. Parameters 2.3.1. brokers (string) Specifies a list of brokers separated by commas. From librdkafka documentation: brokerlist is a ,-separated list of brokers in the format: <broker1>,<broker2>, Where each broker is in either the host or URL based format: * <host>[:<port>] * <proto>://<host>[:port] <proto> is either PLAINTEXT, SSL, SASL, SASL_PLAINTEXT The two formats can be mixed but ultimately the value of the security.protocol config property decides what brokers are allowed. This parameter is mandatory. There is no default value. Example 1.1. Set brokers parameter ... modparam("kafka", "brokers", "localhost:9092") modparam("kafka", "brokers", "broker1:10000,broker2") modparam("kafka", "brokers", "SSL://broker3:9000,ssl://broker2") ... 2.3.2. configuration (string) Specifies a set of general properties. Each configuration property follows: name = value pattern. And configuration properties are separated by ; This parameter is optional, but if it exists it can be configured only once. Example 1.2. Set configuration parameter ... modparam("kafka", "configuration", "topic.metadata.refresh.interval.ms=20000;que ue.buffering.max.messages=1000000;metadata.request.timeout.ms=90000") modparam("kafka", "configuration", "topic.metadata.refresh.interval.ms=20000;que ue.buffering.max.messages=500000;debug=all;metadata.request.timeout.ms=900000") ... 2.3.3. topic (string) Specifies a topic name and a set of topic properties. The topic defined in topic parameter has to already exist in Kafka servers. Each topic property is a list of attribute = value separated by semicolon. name atribute indicates the topic name. It is mandatory. Other attributes mean names of properties and are optional. This parameter is optional. Each topic needs a topic parameter so several topic parameters are allowed. Example 1.3. Set topic parameter ... modparam("kafka", "topic", "name=my_topic;request.required.acks=0;request.timeou t.ms=10000") modparam("kafka", "topic", "name=second_topic;request.required.acks=0;request.ti meout.ms=10000") modparam("kafka", "topic", "name=third_topic") ... 2.4. Functions 2.4.1. kafka_send(topic, msg) Send a message to a specific topic via Kafka server. Parameters: * topic: (string) name of the topic. It is mandatory. * msg: (string) message to send. It is mandatory. Available via KEMI framework as kafka.send. Example 1.4. kafka_send usage ... # Send "test message" to topic "my_topic" kafka_send("my_topic", "test message"); ... 2.5. RPC Commands 2.5.1. kafka.stats Show statistics about total sent messages and failed to deliver ones. Example 1.5. kafka.stats usage ... kamcmd kafka.stats Total messages: 26 Errors: 0 ... 2.5.2. kafka.stats_topic Show statistics about sent messages and failed to deliver ones for a specific topic. Parameter: topic (string) name of the topic. Required. Example 1.6. kafka.stats usage ... # Show statistics for my_topic. kamcmd kafka.stats_topic "my_topic" Topic: my_topic Total messages: 17 Errors: 0 ... You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2112 -- Commit Summary -- * kafka: module to produce and send messages to a Kafka server -- File Changes -- A src/modules/kafka/Makefile (23) A src/modules/kafka/doc/Makefile (4) A src/modules/kafka/doc/kafka.xml (41) A src/modules/kafka/doc/kafka_admin.xml (221) A src/modules/kafka/kafka_mod.c (335) A src/modules/kafka/kfk.c (1175) A src/modules/kafka/kfk.h (96) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2112.patch https://github.com/kamailio/kamailio/pull/2112.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2112

2 12

git:master:f5539642: kafka: associate LOG_NOTICE to LM_NOTICE in kfk_logger
by Vicente Hernando 04 Nov '19

04 Nov '19

Module: kamailio Branch: master Commit: f5539642dfda861e884283da3adb83338979e7b6 URL: https://github.com/kamailio/kamailio/commit/f5539642dfda861e884283da3adb833… Author: Vicente Hernando <vhernando(a)systemonenoc.com> Committer: Vicente Hernando <vhernando(a)systemonenoc.com> Date: 2019-10-30T22:27:55+01:00 kafka: associate LOG_NOTICE to LM_NOTICE in kfk_logger --- Modified: src/modules/kafka/kfk.c --- Diff: https://github.com/kamailio/kamailio/commit/f5539642dfda861e884283da3adb833… Patch: https://github.com/kamailio/kamailio/commit/f5539642dfda861e884283da3adb833… --- diff --git a/src/modules/kafka/kfk.c b/src/modules/kafka/kfk.c index 94b181e3db..b942020e5f 100644 --- a/src/modules/kafka/kfk.c +++ b/src/modules/kafka/kfk.c @@ -155,12 +155,17 @@ static void kfk_logger (const rd_kafka_t *rk, int level, break; case LOG_WARNING: - case LOG_NOTICE: LM_WARN("RDKAFKA fac: %s : %s : %s\n", fac, rk ? rd_kafka_name(rk) : NULL, buf); break; + case LOG_NOTICE: + LM_NOTICE("RDKAFKA fac: %s : %s : %s\n", + fac, rk ? rd_kafka_name(rk) : NULL, + buf); + break; + case LOG_INFO: LM_INFO("RDKAFKA fac: %s : %s : %s\n", fac, rk ? rd_kafka_name(rk) : NULL,

1 0

git:master:a58e2f8b: kafka: delete some debug code
by Vicente Hernando 04 Nov '19

04 Nov '19

Module: kamailio Branch: master Commit: a58e2f8bf7912f8c1d756cda346e0665edce9122 URL: https://github.com/kamailio/kamailio/commit/a58e2f8bf7912f8c1d756cda346e066… Author: Vicente Hernando <vhernando(a)systemonenoc.com> Committer: Vicente Hernando <vhernando(a)systemonenoc.com> Date: 2019-10-30T22:33:13+01:00 kafka: delete some debug code --- Modified: src/modules/kafka/kfk.c --- Diff: https://github.com/kamailio/kamailio/commit/a58e2f8bf7912f8c1d756cda346e066… Patch: https://github.com/kamailio/kamailio/commit/a58e2f8bf7912f8c1d756cda346e066… --- diff --git a/src/modules/kafka/kfk.c b/src/modules/kafka/kfk.c index b942020e5f..b33dde7df5 100644 --- a/src/modules/kafka/kfk.c +++ b/src/modules/kafka/kfk.c @@ -233,24 +233,6 @@ int kfk_init(char *brokers) */ rk_conf = rd_kafka_conf_new(); - /* Log level range 0-7 7 == LOG_DEBUG */ - /* char *rk_log_level = "4"; */ - /* if (rd_kafka_conf_set(rk_conf, "log_level", rk_log_level, */ - /* errstr, sizeof(errstr)) != RD_KAFKA_CONF_OK) { */ - /* LM_ERR("Cannot set loglevel (%s): %s\n", rk_log_level, errstr); */ - /* return -1; */ - /* } */ - - /* char *debug_option = "all"; */ - /* if (rd_kafka_conf_set(rk_conf, "debug", debug_option, */ - /* errstr, sizeof(errstr)) != */ - /* RD_KAFKA_CONF_OK) { */ - /* LM_ERR("Debug configuration failed: " */ - /* "%s: %s\n", */ - /* errstr, debug_option); */ - /* return -1; */ - /* } */ - /* Set logger */ rd_kafka_conf_set_log_cb(rk_conf, kfk_logger);

1 0

git:master:2e3f8ebd: kafka: module to produce and send messages to a Kafka server
by Vicente Hernando 04 Nov '19

04 Nov '19

Module: kamailio Branch: master Commit: 2e3f8ebdca5d734ee4c523044da65c655ffc920b URL: https://github.com/kamailio/kamailio/commit/2e3f8ebdca5d734ee4c523044da65c6… Author: Vicente Hernando <vhernando(a)systemonenoc.com> Committer: Vicente Hernando <vhernando(a)systemonenoc.com> Date: 2019-10-30T19:45:11+01:00 kafka: module to produce and send messages to a Kafka server --- Added: src/modules/kafka/Makefile Added: src/modules/kafka/doc/Makefile Added: src/modules/kafka/doc/kafka.xml Added: src/modules/kafka/doc/kafka_admin.xml Added: src/modules/kafka/kafka_mod.c Added: src/modules/kafka/kfk.c Added: src/modules/kafka/kfk.h --- Diff: https://github.com/kamailio/kamailio/commit/2e3f8ebdca5d734ee4c523044da65c6… Patch: https://github.com/kamailio/kamailio/commit/2e3f8ebdca5d734ee4c523044da65c6…

1 0

[kamailio/kamailio] ims_usrloc_scscf: added '\n' for debug messages (#2122)
by alexyosifov 04 Nov '19

04 Nov '19

- added a new line to the end of some debug logs for better formatting.   #### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2122 -- Commit Summary -- * ims_usrloc_scscf: added '\n' for debug messages -- File Changes -- M src/modules/ims_usrloc_scscf/subscribe.c (48) M src/modules/ims_usrloc_scscf/udomain.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2122.patch https://github.com/kamailio/kamailio/pull/2122.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2122

2 2

git:master:90ff57e1: ims_usrloc_scscf: added '\n' for debug messages
by Henning Westerholt 04 Nov '19

04 Nov '19

Module: kamailio Branch: master Commit: 90ff57e10f1b456b35dc8ac262457dbb2c497997 URL: https://github.com/kamailio/kamailio/commit/90ff57e10f1b456b35dc8ac262457db… Author: Aleksandar Yosifov <alexyosifov(a)gmail.com> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-11-04T17:01:06+01:00 ims_usrloc_scscf: added '\n' for debug messages - added a new line to the end of some debug logs for better formatting. --- Modified: src/modules/ims_usrloc_scscf/subscribe.c Modified: src/modules/ims_usrloc_scscf/udomain.c --- Diff: https://github.com/kamailio/kamailio/commit/90ff57e10f1b456b35dc8ac262457db… Patch: https://github.com/kamailio/kamailio/commit/90ff57e10f1b456b35dc8ac262457db…

1 0

git:master:bf1ba8d2: core: qmalloc - print details of prev fragment when its tail is overwritten
by Daniel-Constantin Mierla 03 Nov '19

03 Nov '19

Module: kamailio Branch: master Commit: bf1ba8d2d4519af50d44acfce5f34535fd1db8e0 URL: https://github.com/kamailio/kamailio/commit/bf1ba8d2d4519af50d44acfce5f3453… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-11-03T10:30:09+01:00 core: qmalloc - print details of prev fragment when its tail is overwritten - do it when check2 field is not touched --- Modified: src/core/mem/q_malloc.c --- Diff: https://github.com/kamailio/kamailio/commit/bf1ba8d2d4519af50d44acfce5f3453… Patch: https://github.com/kamailio/kamailio/commit/bf1ba8d2d4519af50d44acfce5f3453… --- diff --git a/src/core/mem/q_malloc.c b/src/core/mem/q_malloc.c index b718dfa3bf..2fd45fe50e 100644 --- a/src/core/mem/q_malloc.c +++ b/src/core/mem/q_malloc.c @@ -118,6 +118,7 @@ static void qm_debug_check_frag(struct qm_block* qm, struct qm_frag* f, const char* file, unsigned int line, const char* efile, unsigned int eline) { + struct qm_frag *p; if (f->check!=ST_CHECK_PATTERN){ LM_CRIT("BUG: qm: fragm. %p (address %p) " "beginning overwritten (%lx)! Memory allocator was called " @@ -147,6 +148,12 @@ static void qm_debug_check_frag(struct qm_block* qm, struct qm_frag* f, PREV_FRAG_END(f)->check1, PREV_FRAG_END(f)->check2, f, (char*)f+sizeof(struct qm_frag), file, line, f->file, f->line, efile, eline); + if(PREV_FRAG_END(f)->check2==END_CHECK_PATTERN2) { + p = FRAG_PREV(f); + LM_CRIT("BUG: qm: prev. fragm. tail overwritten [%p:%p]" + " - fragment marked by %s:%lu\n", p, + (char*)p+sizeof(struct qm_frag), p->file, p->line); + } qm_status(qm); abort(); }

1 0

git:master:7261efbc: textops: remove check done in the called function
by Daniel-Constantin Mierla 03 Nov '19

03 Nov '19

Module: kamailio Branch: master Commit: 7261efbcd0826014227fbe814e4142cec0c79368 URL: https://github.com/kamailio/kamailio/commit/7261efbcd0826014227fbe814e4142c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-11-02T18:04:55+01:00 textops: remove check done in the called function --- Modified: src/modules/textopsx/textopsx.c --- Diff: https://github.com/kamailio/kamailio/commit/7261efbcd0826014227fbe814e4142c… Patch: https://github.com/kamailio/kamailio/commit/7261efbcd0826014227fbe814e4142c… --- diff --git a/src/modules/textopsx/textopsx.c b/src/modules/textopsx/textopsx.c index 3554c3263e..317abb6002 100644 --- a/src/modules/textopsx/textopsx.c +++ b/src/modules/textopsx/textopsx.c @@ -177,11 +177,6 @@ static int ki_msg_set_buffer(sip_msg_t *msg, str *obuf) */ static int ki_msg_apply_changes(sip_msg_t *msg) { - if(msg->first_line.type != SIP_REPLY && get_route_type() != REQUEST_ROUTE) { - LM_ERR("invalid usage - not in request route or a reply\n"); - return -1; - } - return sip_msg_apply_changes(msg); } @@ -190,7 +185,7 @@ static int ki_msg_apply_changes(sip_msg_t *msg) */ static int msg_apply_changes_f(sip_msg_t *msg, char *str1, char *str2) { - return ki_msg_apply_changes(msg); + return sip_msg_apply_changes(msg); } /**

1 0

git:master:d9ceadf1: pkg/docker: updated submodule [skip ci]
by Sergey Safarov 02 Nov '19

02 Nov '19

Module: kamailio Branch: master Commit: d9ceadf16906b4687cddb482b4fd2ee96744aa23 URL: https://github.com/kamailio/kamailio/commit/d9ceadf16906b4687cddb482b4fd2ee… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2019-11-02T04:49:22+03:00 pkg/docker: updated submodule [skip ci] --- Modified: pkg/docker --- Diff: https://github.com/kamailio/kamailio/commit/d9ceadf16906b4687cddb482b4fd2ee… Patch: https://github.com/kamailio/kamailio/commit/d9ceadf16906b4687cddb482b4fd2ee… --- diff --git a/pkg/docker b/pkg/docker index 4b81cba4c2..0a9a2f2633 160000 --- a/pkg/docker +++ b/pkg/docker @@ -1 +1 @@ -Subproject commit 4b81cba4c293f79ef3b4ae4a8c391d0da220878e +Subproject commit 0a9a2f26337a98d5a349cfb4fc16d588df9912c7

1 0

git:master:fb8c7058: modules: readme files regenerated - dialog ... [skip ci]
by Kamailio Dev 01 Nov '19

01 Nov '19

Module: kamailio Branch: master Commit: fb8c70584e331fd6573b596031baf9d4a2662bd1 URL: https://github.com/kamailio/kamailio/commit/fb8c70584e331fd6573b596031baf9d… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2019-11-01T10:31:22+01:00 modules: readme files regenerated - dialog ... [skip ci] --- Modified: src/modules/dialog/README --- Diff: https://github.com/kamailio/kamailio/commit/fb8c70584e331fd6573b596031baf9d… Patch: https://github.com/kamailio/kamailio/commit/fb8c70584e331fd6573b596031baf9d… --- diff --git a/src/modules/dialog/README b/src/modules/dialog/README index 3b9d71b959..31eda51225 100644 --- a/src/modules/dialog/README +++ b/src/modules/dialog/README @@ -160,6 +160,7 @@ Julien Klingenmeyer 9.12. dlg.bridge_dlg 9.13. dlg.stats_active 9.14. dlg.is_alive + 9.15. dlg.briefing 10. Exported Variables @@ -396,6 +397,7 @@ Chapter 1. Admin Guide 9.12. dlg.bridge_dlg 9.13. dlg.stats_active 9.14. dlg.is_alive + 9.15. dlg.briefing 10. Exported Variables @@ -1918,6 +1920,7 @@ if(has_totag()) { 9.12. dlg.bridge_dlg 9.13. dlg.stats_active 9.14. dlg.is_alive + 9.15. dlg.briefing 9.1. dlg.list @@ -2190,6 +2193,20 @@ kamcmd dlg.stats_active kamcmd dlg.is_alive callid123 fromtag123 totag123 ... +9.15. dlg.briefing + + Lists fewer attributes for dialog records in memory. + + Name: dlg.briefing + + Parameters: + * none - no parameter + + RPC Command Example: +... +kamctl rpc dlg.briefing +... + 10. Exported Variables 10.1. $DLG_count

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2019