October 2019 - sr-dev - kamailio.org

Development is open for future release of v5.4.x series
by Daniel-Constantin Mierla 03 Oct '19

03 Oct '19

Hello, the branch 5.3 was created late last evening, therefore the master branch is open for adding new features, to be part of future release series v5.4.x. Any bug fix committed to master that applies to 5.3.x or older stable branches should be backported as usual with "git cherry-pick -x ..." to appropriate branches like 5.3 or 5.2. Expect that v5.3.0 will be released in a few weeks from now. Based on the workflow used during the past years, the next future release v5.4.0 should be out after another 8-10 months of development, plus 1-2 months of testing, so sometime in close to the end of spring 2020 or afterwards. Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training, Oct 21-23, 2019, Berlin, Germany -- https://asipto.com/u/kat

1 0

Branch 5.3 has been created
by Daniel-Constantin Mierla 03 Oct '19

03 Oct '19

Hello, the branch 5.3 has been created, to be used for releasing v5.3.x series. To check out this branch, the following commands can be used: git clone https://github.com/kamailio/kamailio kamailio-5.3 cd kamailio-5.3 git checkout -b 5.3 origin/5.3 Pushing commits in this branch: git push origin 5.3:5.3 Note that 5.3 is an official stable branch, so only bug fixes, missing kemi exports (discuss on sr-dev if not sure) or improvements to documentation or helper tools can be pushed to this branch. You may notice a bit of more activity on tls (some issue is under work) and siptrace (a bit of cleanup for coherence might be done) modules, but over all no new features will be pushed there. As usual, if there is a bug fixed, commit and push first to master branch and then cherry pick to 5.2 branch: git cherry-pick -x COMMITID In few weeks, the first release from branch 5.3 will be out, respectively Kamailio v5.3.0. Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training, Oct 21-23, 2019, Berlin, Germany -- https://asipto.com/u/kat

1 0

Branching 5.3
by Daniel-Constantin Mierla 02 Oct '19

02 Oct '19

Hello, if there are no strong opinions against, then it is time to branch 5.3 on git repository. I am considering to do it by the end of the day on Wednesday, October 2, 2019. After that, the master will be again open for new features, while 5.3 branch will continue to get the only fixes and improvements to documentation and tools. 2-3 weeks later we should release v5.3.0, the first stable version in 5.3.x series. Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training, Oct 21-23, 2019, Berlin, Germany -- https://asipto.com/u/kat

2 3

git:5.3:726ad857: Makefile.defs: version set to 5.3.0-rc0
by Daniel-Constantin Mierla 02 Oct '19

02 Oct '19

Module: kamailio Branch: 5.3 Commit: 726ad8579d75e0cd6fd3537140690c997601435c URL: https://github.com/kamailio/kamailio/commit/726ad8579d75e0cd6fd3537140690c9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-02T23:45:11+02:00 Makefile.defs: version set to 5.3.0-rc0 - branch 5.3 for v5.3.x release series --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/726ad8579d75e0cd6fd3537140690c9… Patch: https://github.com/kamailio/kamailio/commit/726ad8579d75e0cd6fd3537140690c9… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index 5242d223d9..0161d2120b 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -107,7 +107,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) VERSION = 5 PATCHLEVEL = 3 SUBLEVEL = 0 -EXTRAVERSION = -pre2 +EXTRAVERSION = -rc0 # memory manager switcher # 0 - f_malloc (fast malloc)

1 0

git:master:685fc6bd: Makefile.defs: version set to 5.4.0-dev0
by Daniel-Constantin Mierla 02 Oct '19

02 Oct '19

Module: kamailio Branch: master Commit: 685fc6bd5388d2dedd07da7420c89f47af69ad42 URL: https://github.com/kamailio/kamailio/commit/685fc6bd5388d2dedd07da7420c89f4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-02T23:35:22+02:00 Makefile.defs: version set to 5.4.0-dev0 - master branch is open for new features to be part of v5.4.x series --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/685fc6bd5388d2dedd07da7420c89f4… Patch: https://github.com/kamailio/kamailio/commit/685fc6bd5388d2dedd07da7420c89f4… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index 5242d223d9..3313524469 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -105,9 +105,9 @@ INSTALL_FLAVOUR=$(FLAVOUR) # version number VERSION = 5 -PATCHLEVEL = 3 +PATCHLEVEL = 4 SUBLEVEL = 0 -EXTRAVERSION = -pre2 +EXTRAVERSION = -dev0 # memory manager switcher # 0 - f_malloc (fast malloc)

1 0

git:master:08ae663b: Makefile.defs: version set to 5.3.0-pre2
by Daniel-Constantin Mierla 02 Oct '19

02 Oct '19

Module: kamailio Branch: master Commit: 08ae663b82ec955cc349c5550b8bea796f148295 URL: https://github.com/kamailio/kamailio/commit/08ae663b82ec955cc349c5550b8bea7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-02T23:32:02+02:00 Makefile.defs: version set to 5.3.0-pre2 --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/08ae663b82ec955cc349c5550b8bea7… Patch: https://github.com/kamailio/kamailio/commit/08ae663b82ec955cc349c5550b8bea7… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index e5fa7fdda1..5242d223d9 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -107,7 +107,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) VERSION = 5 PATCHLEVEL = 3 SUBLEVEL = 0 -EXTRAVERSION = -pre1 +EXTRAVERSION = -pre2 # memory manager switcher # 0 - f_malloc (fast malloc)

1 0

git:master:c0381899: crypto: remove FIXME, add proper log level for debug statement, rephrase log
by Henning Westerholt 02 Oct '19

02 Oct '19

Module: kamailio Branch: master Commit: c03818998f0bd679a1db67ef3b487dd7f1ec256b URL: https://github.com/kamailio/kamailio/commit/c03818998f0bd679a1db67ef3b487dd… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-10-02T16:29:46+02:00 crypto: remove FIXME, add proper log level for debug statement, rephrase log --- Modified: src/modules/crypto/crypto_uuid.c --- Diff: https://github.com/kamailio/kamailio/commit/c03818998f0bd679a1db67ef3b487dd… Patch: https://github.com/kamailio/kamailio/commit/c03818998f0bd679a1db67ef3b487dd… --- diff --git a/src/modules/crypto/crypto_uuid.c b/src/modules/crypto/crypto_uuid.c index 86a6aa66ff..a4049e6282 100644 --- a/src/modules/crypto/crypto_uuid.c +++ b/src/modules/crypto/crypto_uuid.c @@ -218,9 +218,8 @@ int crypto_generate_SHA1(str* in, str* hash) void* ret; if ((ret=SHA1((unsigned char *)in->s, in->len, crypto_buf)) != crypto_buf) { - LM_ERR("SHA1 algo failed!\n"); - /* FIXME remove LM_BUG */ - LM_BUG("Pointer value %p\n", ret); + LM_ERR("SHA1 algorithm failed!\n"); + LM_DBG("return value from library %p\n", ret); return -1; }

1 0

git:master:9a268f13: crypto: spelling fix in comment
by Henning Westerholt 02 Oct '19

02 Oct '19

Module: kamailio Branch: master Commit: 9a268f13454c498fd374ca24b1a876e057ff155d URL: https://github.com/kamailio/kamailio/commit/9a268f13454c498fd374ca24b1a876e… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-10-02T16:27:40+02:00 crypto: spelling fix in comment --- Modified: src/modules/crypto/api.h --- Diff: https://github.com/kamailio/kamailio/commit/9a268f13454c498fd374ca24b1a876e… Patch: https://github.com/kamailio/kamailio/commit/9a268f13454c498fd374ca24b1a876e… --- diff --git a/src/modules/crypto/api.h b/src/modules/crypto/api.h index fa87923304..ce79c72229 100644 --- a/src/modules/crypto/api.h +++ b/src/modules/crypto/api.h @@ -41,7 +41,7 @@ typedef int (*load_crypto_f)( struct crypto_binds* ); int load_crypto( struct crypto_binds *cb ); /*! - * \brief Function to be called directly from other modules to load the CRYTPO API + * \brief Function to be called directly from other modules to load the CRYPTO API * \param cb crypto API export binding * \return 0 on success, -1 if the API loader could not imported */

1 0

git:5.1:0b6785d8: core: fix compile error related to missing T_OPT in older (<2.25) glibc (GH #2087)
by Henning Westerholt 02 Oct '19

02 Oct '19

Module: kamailio Branch: 5.1 Commit: 0b6785d8cffad33ff9ed05b1f345426e81fc0c4c URL: https://github.com/kamailio/kamailio/commit/0b6785d8cffad33ff9ed05b1f345426… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-10-02T12:45:13+02:00 core: fix compile error related to missing T_OPT in older (<2.25) glibc (GH #2087) (cherry picked from commit 325d1e6d53b3db3265d6f76ec34bb3d6a31419c4) --- Modified: src/core/resolve.c --- Diff: https://github.com/kamailio/kamailio/commit/0b6785d8cffad33ff9ed05b1f345426… Patch: https://github.com/kamailio/kamailio/commit/0b6785d8cffad33ff9ed05b1f345426… --- diff --git a/src/core/resolve.c b/src/core/resolve.c index a5ffb86d7d..439435791a 100644 --- a/src/core/resolve.c +++ b/src/core/resolve.c @@ -32,6 +32,13 @@ #include <resolv.h> #include <string.h> +/* older glibc < 2.25 does not include T_OPT in nameser_compat.h yet */ +#if __GLIBC__ == 2 && __GLIBC_MINOR__ < 25 +#ifndef T_OPT +#define T_OPT ns_t_opt +#endif +#endif + #include "resolve.h" #include "compiler_opt.h" #include "dprint.h"

1 0

git:5.1:f2920c46: core: skip get_record for DNS extensions e.g. for EDNS0 (GH #2087)
by Henning Westerholt 02 Oct '19

02 Oct '19

Module: kamailio Branch: 5.1 Commit: f2920c4681e10b852e94a3378e1f6920597593ae URL: https://github.com/kamailio/kamailio/commit/f2920c4681e10b852e94a3378e1f692… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-10-02T12:44:39+02:00 core: skip get_record for DNS extensions e.g. for EDNS0 (GH #2087) (cherry picked from commit aeea940adaddc12c1467a0ac8f5e34d14b1339be) --- Modified: src/core/resolve.c --- Diff: https://github.com/kamailio/kamailio/commit/f2920c4681e10b852e94a3378e1f692… Patch: https://github.com/kamailio/kamailio/commit/f2920c4681e10b852e94a3378e1f692… --- diff --git a/src/core/resolve.c b/src/core/resolve.c index 2b1441e36d..a5ffb86d7d 100644 --- a/src/core/resolve.c +++ b/src/core/resolve.c @@ -937,6 +937,12 @@ struct rdata* get_record(char* name, int type, int flags) *last=rd; last=&(rd->next); break; + case T_OPT: + /* skip DNS extensions, e.g. EDNS0 */ + rd->rdata=0; + *last=rd; + last=&(rd->next); + break; default: LM_ERR("unknown type %d\n", rtype); rd->rdata=0;

1 0

git:5.2:cd4f3c7a: core: fix compile error related to missing T_OPT in older (<2.25) glibc (GH #2087)
by Henning Westerholt 02 Oct '19

02 Oct '19

Module: kamailio Branch: 5.2 Commit: cd4f3c7ad82ef11e73a8c5a53cea2fb812b7dd60 URL: https://github.com/kamailio/kamailio/commit/cd4f3c7ad82ef11e73a8c5a53cea2fb… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-10-02T12:45:05+02:00 core: fix compile error related to missing T_OPT in older (<2.25) glibc (GH #2087) (cherry picked from commit 325d1e6d53b3db3265d6f76ec34bb3d6a31419c4) --- Modified: src/core/resolve.c --- Diff: https://github.com/kamailio/kamailio/commit/cd4f3c7ad82ef11e73a8c5a53cea2fb… Patch: https://github.com/kamailio/kamailio/commit/cd4f3c7ad82ef11e73a8c5a53cea2fb… --- diff --git a/src/core/resolve.c b/src/core/resolve.c index fd74441bf6..9f9705341e 100644 --- a/src/core/resolve.c +++ b/src/core/resolve.c @@ -32,6 +32,13 @@ #include <resolv.h> #include <string.h> +/* older glibc < 2.25 does not include T_OPT in nameser_compat.h yet */ +#if __GLIBC__ == 2 && __GLIBC_MINOR__ < 25 +#ifndef T_OPT +#define T_OPT ns_t_opt +#endif +#endif + #include "resolve.h" #include "compiler_opt.h" #include "dprint.h"

1 0

git:5.2:f24fb5cd: core: skip get_record for DNS extensions e.g. for EDNS0 (GH #2087)
by Henning Westerholt 02 Oct '19

02 Oct '19

Module: kamailio Branch: 5.2 Commit: f24fb5cd5509dd7c539bf1c36b2676220dc1e826 URL: https://github.com/kamailio/kamailio/commit/f24fb5cd5509dd7c539bf1c36b26762… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-10-02T12:44:25+02:00 core: skip get_record for DNS extensions e.g. for EDNS0 (GH #2087) (cherry picked from commit aeea940adaddc12c1467a0ac8f5e34d14b1339be) --- Modified: src/core/resolve.c --- Diff: https://github.com/kamailio/kamailio/commit/f24fb5cd5509dd7c539bf1c36b26762… Patch: https://github.com/kamailio/kamailio/commit/f24fb5cd5509dd7c539bf1c36b26762… --- diff --git a/src/core/resolve.c b/src/core/resolve.c index 80020a96ff..fd74441bf6 100644 --- a/src/core/resolve.c +++ b/src/core/resolve.c @@ -937,6 +937,12 @@ struct rdata* get_record(char* name, int type, int flags) *last=rd; last=&(rd->next); break; + case T_OPT: + /* skip DNS extensions, e.g. EDNS0 */ + rd->rdata=0; + *last=rd; + last=&(rd->next); + break; default: LM_ERR("unknown type %d\n", rtype); rd->rdata=0;

1 0

[kamailio/kamailio] Kamailio logs errors due to unsupported EDNS0 extension in DNS responses (#2087)
by Florian Floimair 02 Oct '19

02 Oct '19

### Description We are running Kamailio in a Microsoft Azure VM. Azure started adding EDNS0 support - in the form of OPT pseudo-records at the end of replies - a few weeks ago and since then we see a lot of ERROR entries in Kamailio log. These do however have no function impact. >From what I can see they are simply not handled in core/resolv.c (EDNS0 is type 41). Version in use is latest 5.2 package from Kamailio repo on Debian 9 (Stretch). Log entries provided below ### Troubleshooting None, as this has no functional impact aside from filling the logs. #### Reproduction I can provide pcap of DNS traffic that contains EDNS0 OPT pseudo-entries on request. #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` Oct 1 14:02:01 kamailio /usr/sbin/kamailio[78878]: ERROR: <core> [core/resolve.c:941]: get_record(): unknown type 41 ``` These lines are seen repeatedly only differing in timestamp and PID of kamailio process. In total about 40% of log entries are like the one above. #### SIP Traffic  not related to SIP, but to DNS ### Possible Solutions Add EDNS0 type 41 in core/resolv.c and don't fire an ERROR in the logs. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.2.4 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 6.3.0 ``` * **Operating System**:  ``` Debian 9.11 Linux kamailio 4.19.0-0.bpo.5-cloud-amd64 #1 SMP Debian 4.19.37-3~bpo9+1 (2019-05-18) x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2087

2 8

git:master:58047ba6: app_perl: first destroy old interpreter before creating the new one
by Daniel-Constantin Mierla 02 Oct '19

02 Oct '19

Module: kamailio Branch: master Commit: 58047ba61d0cbceebc8c85590970a573fc396aa5 URL: https://github.com/kamailio/kamailio/commit/58047ba61d0cbceebc8c85590970a57… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-02T08:32:21+02:00 app_perl: first destroy old interpreter before creating the new one - on interpreter reset, the new one may inherit globals from the old one, if that is not yet destroyed --- Modified: src/modules/app_perl/app_perl_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/58047ba61d0cbceebc8c85590970a57… Patch: https://github.com/kamailio/kamailio/commit/58047ba61d0cbceebc8c85590970a57… --- diff --git a/src/modules/app_perl/app_perl_mod.c b/src/modules/app_perl/app_perl_mod.c index 942581c6d6..954b354638 100644 --- a/src/modules/app_perl/app_perl_mod.c +++ b/src/modules/app_perl/app_perl_mod.c @@ -262,6 +262,8 @@ PerlInterpreter *parser_init(void) { * */ int unload_perl(PerlInterpreter *p) { + /* clean and reset everything */ + PL_perl_destruct_level = 1; perl_destruct(p); perl_free(p); @@ -276,26 +278,26 @@ int unload_perl(PerlInterpreter *p) { */ int perl_reload(void) { - - PerlInterpreter *new_perl; - - new_perl = parser_init(); - - if (new_perl) { + if(my_perl) { unload_perl(my_perl); - my_perl = new_perl; + } + my_perl = parser_init(); + #ifdef PERL_EXIT_DESTRUCT_END - PL_exit_flags |= PERL_EXIT_DESTRUCT_END; + PL_exit_flags |= PERL_EXIT_DESTRUCT_END; #else #warning Perl 5.8.x should be used. Please upgrade. #warning This binary will be unsupported. - PL_exit_flags |= PERL_EXIT_EXPECTED; + PL_exit_flags |= PERL_EXIT_EXPECTED; #endif + + if(my_perl) { + LM_DBG("new perl interpreter initialized\n"); return 0; } else { - return -1; + LM_CRIT("failed to initialize a new perl interpreter - exiting\n"); + exit(-1); } - }

1 0

git:master:fc542100: tls: option to set custom random bytess generator
by Daniel-Constantin Mierla 01 Oct '19

01 Oct '19

Module: kamailio Branch: master Commit: fc542100d85a013272dde869e54173a7d5a062f4 URL: https://github.com/kamailio/kamailio/commit/fc542100d85a013272dde869e54173a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-01T23:07:54+02:00 tls: option to set custom random bytess generator - attempt to fix GH #2077 which exposes a crash in the libssl v1.1 default random bytes generator --- Added: src/modules/tls/tls_rand.c Added: src/modules/tls/tls_rand.h Modified: src/modules/tls/tls_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/fc542100d85a013272dde869e54173a… Patch: https://github.com/kamailio/kamailio/commit/fc542100d85a013272dde869e54173a…

1 0

[kamailio/kamailio] Create reverse-of-a-number (#2088)
by ankit-proton 01 Oct '19

01 Oct '19

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2088 -- Commit Summary -- * Create reverse-of-a-number -- File Changes -- A reverse-of-a-number (14) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2088.patch https://github.com/kamailio/kamailio/pull/2088.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2088

2 2

git:master:325d1e6d: core: fix compile error related to missing T_OPT in older (<2.25) glibc (GH #2087)
by Henning Westerholt 01 Oct '19

01 Oct '19

Module: kamailio Branch: master Commit: 325d1e6d53b3db3265d6f76ec34bb3d6a31419c4 URL: https://github.com/kamailio/kamailio/commit/325d1e6d53b3db3265d6f76ec34bb3d… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-10-01T18:02:44+02:00 core: fix compile error related to missing T_OPT in older (<2.25) glibc (GH #2087) --- Modified: src/core/resolve.c --- Diff: https://github.com/kamailio/kamailio/commit/325d1e6d53b3db3265d6f76ec34bb3d… Patch: https://github.com/kamailio/kamailio/commit/325d1e6d53b3db3265d6f76ec34bb3d… --- diff --git a/src/core/resolve.c b/src/core/resolve.c index de5a30398e..6edc47e506 100644 --- a/src/core/resolve.c +++ b/src/core/resolve.c @@ -32,6 +32,13 @@ #include <resolv.h> #include <string.h> +/* older glibc < 2.25 does not include T_OPT in nameser_compat.h yet */ +#if __GLIBC__ == 2 && __GLIBC_MINOR__ < 25 +#ifndef T_OPT +#define T_OPT ns_t_opt +#endif +#endif + #include "resolve.h" #include "compiler_opt.h" #include "dprint.h"

1 0

git:master:dd594481: modules: readme files regenerated - siptrace ... [skip ci]
by Kamailio Dev 01 Oct '19

01 Oct '19

Module: kamailio Branch: master Commit: dd594481ee5478d4509c2e53d88a4e309e7dad67 URL: https://github.com/kamailio/kamailio/commit/dd594481ee5478d4509c2e53d88a4e3… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2019-10-01T13:46:53+02:00 modules: readme files regenerated - siptrace ... [skip ci] --- Modified: src/modules/siptrace/README --- Diff: https://github.com/kamailio/kamailio/commit/dd594481ee5478d4509c2e53d88a4e3… Patch: https://github.com/kamailio/kamailio/commit/dd594481ee5478d4509c2e53d88a4e3…

2 1

git:master:51e72659: modules: readme files regenerated - siptrace ... [skip ci]
by Kamailio Dev 01 Oct '19

01 Oct '19

Module: kamailio Branch: master Commit: 51e72659699b5f15b1a4b8827247e0bcdd587fab URL: https://github.com/kamailio/kamailio/commit/51e72659699b5f15b1a4b8827247e0b… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2019-10-01T17:01:51+02:00 modules: readme files regenerated - siptrace ... [skip ci] --- Modified: src/modules/siptrace/README --- Diff: https://github.com/kamailio/kamailio/commit/51e72659699b5f15b1a4b8827247e0b… Patch: https://github.com/kamailio/kamailio/commit/51e72659699b5f15b1a4b8827247e0b…

1 0

git:master:1d014c04: siptrace: fix (copy and paste) errors in siptrace docs
by Henning Westerholt 01 Oct '19

01 Oct '19

Module: kamailio Branch: master Commit: 1d014c04cfc67d5ed7c3bd440bcf05eb76b1fc73 URL: https://github.com/kamailio/kamailio/commit/1d014c04cfc67d5ed7c3bd440bcf05e… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-10-01T17:00:36+02:00 siptrace: fix (copy and paste) errors in siptrace docs --- Modified: src/modules/siptrace/doc/siptrace_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/1d014c04cfc67d5ed7c3bd440bcf05e… Patch: https://github.com/kamailio/kamailio/commit/1d014c04cfc67d5ed7c3bd440bcf05e… --- diff --git a/src/modules/siptrace/doc/siptrace_admin.xml b/src/modules/siptrace/doc/siptrace_admin.xml index df8fe2f017..abf3f47c26 100644 --- a/src/modules/siptrace/doc/siptrace_admin.xml +++ b/src/modules/siptrace/doc/siptrace_admin.xml @@ -571,7 +571,7 @@ sip_trace("sip:10.1.1.2:5085", "$ci-abc", "d"); <section id="siptrace.f.sip_trace_mode"> <title> - <function moreinfo="none">sip_trace_mode(tmode])</function> + <function moreinfo="none">sip_trace_mode(tmode)</function> </title> <para> Set the tracing mode: message, transaction or dialog. Only the first @@ -587,7 +587,6 @@ sip_trace("sip:10.1.1.2:5085", "$ci-abc", "d"); <para> This function can be used in ANY_ROUTE. </para> - </emphasis> <example> <title><function>sip_trace_mode()</function> usage</title> <programlisting format="linespecific">

1 0

git:master:aeea940a: core: skip get_record for DNS extensions e.g. for EDNS0 (GH #2087)
by Henning Westerholt 01 Oct '19

01 Oct '19

Module: kamailio Branch: master Commit: aeea940adaddc12c1467a0ac8f5e34d14b1339be URL: https://github.com/kamailio/kamailio/commit/aeea940adaddc12c1467a0ac8f5e34d… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-10-01T16:41:19+02:00 core: skip get_record for DNS extensions e.g. for EDNS0 (GH #2087) --- Modified: src/core/resolve.c --- Diff: https://github.com/kamailio/kamailio/commit/aeea940adaddc12c1467a0ac8f5e34d… Patch: https://github.com/kamailio/kamailio/commit/aeea940adaddc12c1467a0ac8f5e34d… --- diff --git a/src/core/resolve.c b/src/core/resolve.c index 5169c85cab..de5a30398e 100644 --- a/src/core/resolve.c +++ b/src/core/resolve.c @@ -951,6 +951,12 @@ struct rdata* get_record(char* name, int type, int flags) *last=rd; last=&(rd->next); break; + case T_OPT: + /* skip DNS extensions, e.g. EDNS0 */ + rd->rdata=0; + *last=rd; + last=&(rd->next); + break; default: LM_ERR("unknown type %d\n", rtype); rd->rdata=0;

1 0

[kamailio/kamailio] Create lol (#2086)
by Amiya Chaturvedi 01 Oct '19

01 Oct '19

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2086 -- Commit Summary -- * Create lol -- File Changes -- A Amiya_Chaturvedi/lol (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2086.patch https://github.com/kamailio/kamailio/pull/2086.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2086

2 2

git:master:3033a26a: siptrace: docs for sip_trace_mode() function
by Daniel-Constantin Mierla 01 Oct '19

01 Oct '19

Module: kamailio Branch: master Commit: 3033a26a6a8a8e7075dd5a86bf376c73830f2bbe URL: https://github.com/kamailio/kamailio/commit/3033a26a6a8a8e7075dd5a86bf376c7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-01T13:31:47+02:00 siptrace: docs for sip_trace_mode() function --- Modified: src/modules/siptrace/doc/siptrace_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/3033a26a6a8a8e7075dd5a86bf376c7… Patch: https://github.com/kamailio/kamailio/commit/3033a26a6a8a8e7075dd5a86bf376c7… --- diff --git a/src/modules/siptrace/doc/siptrace_admin.xml b/src/modules/siptrace/doc/siptrace_admin.xml index 21d6090c74..df8fe2f017 100644 --- a/src/modules/siptrace/doc/siptrace_admin.xml +++ b/src/modules/siptrace/doc/siptrace_admin.xml @@ -512,7 +512,7 @@ modparam("siptrace", "auth_key", "spoihepuirthpeuia") </example> </section> </section> - + <section> <title>Functions</title> <section id="siptrace.f.sip_trace"> @@ -569,6 +569,35 @@ sip_trace("sip:10.1.1.2:5085", "$ci-abc", "d"); </example> </section> + <section id="siptrace.f.sip_trace_mode"> + <title> + <function moreinfo="none">sip_trace_mode(tmode])</function> + </title> + <para> + Set the tracing mode: message, transaction or dialog. Only the first + character of the parameter matters: m or M for message; t or T for + transaction; d or D for dialog. + </para> + <para> + In message tracing mode only the current message is stored or mirrored. + In transaction tracing mode, all the messages of the current transaction + are stored or mirrored. In dialog tracing mode, all the messages of the + current dialog are stored or mirrored. + </para> + <para> + This function can be used in ANY_ROUTE. + </para> + </emphasis> + <example> + <title><function>sip_trace_mode()</function> usage</title> + <programlisting format="linespecific"> +... +sip_trace_mode("t"); +... +</programlisting> + </example> + </section> + <section id="siptrace.f.hlog"> <title> <function moreinfo="none">hlog([correlation_id,] message)</function>

1 0

git:master:929ff145: siptrace: added sip_trace_mode(tmode)
by Daniel-Constantin Mierla 01 Oct '19

01 Oct '19

Module: kamailio Branch: master Commit: 929ff145d78b70f29c388b31e76f84c4b438ee90 URL: https://github.com/kamailio/kamailio/commit/929ff145d78b70f29c388b31e76f84c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-01T13:23:06+02:00 siptrace: added sip_trace_mode(tmode) - function to specify the tracing mode: message, transaction, dialog - a short form of siptrace with 3 params when the duplicate uri and correlation id are not used - the variant for the older setflag(...)/sip_trace(...) to track all the messages in a transaction --- Modified: src/modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/929ff145d78b70f29c388b31e76f84c… Patch: https://github.com/kamailio/kamailio/commit/929ff145d78b70f29c388b31e76f84c… --- diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c index 544fb5392a..20c0c8a907 100644 --- a/src/modules/siptrace/siptrace.c +++ b/src/modules/siptrace/siptrace.c @@ -87,6 +87,7 @@ static int w_sip_trace1(struct sip_msg *, char *dest, char *p2); static int w_sip_trace2(struct sip_msg *, char *dest, char *correlation_id); static int w_sip_trace3(struct sip_msg *, char *dest, char *correlation_id, char *trace_type); static int fixup_siptrace(void **param, int param_no); +static int w_sip_trace_mode(sip_msg_t *msg, char *pmode, char *p2); static int parse_siptrace_uri(str* duri, dest_info_t* dst); static enum siptrace_type_t parse_siptrace_flag(str* sflags); @@ -198,6 +199,8 @@ static cmd_export_t cmds[] = { ANY_ROUTE}, {"hlog", (cmd_function)w_hlog2, 2, fixup_spve_spve, 0, ANY_ROUTE}, + {"sip_trace_mode", (cmd_function)w_sip_trace_mode, 1, fixup_spve_null, + fixup_free_spve_null, ANY_ROUTE}, {0, 0, 0, 0, 0, 0} }; @@ -1182,6 +1185,54 @@ static int sip_trace(sip_msg_t *msg, dest_info_t *dst, return sip_trace_store(&sto, dst, correlation_id_str); } + +/** + * + */ +static int ki_sip_trace_mode(sip_msg_t *msg, str *smode) +{ + enum siptrace_type_t trace_type; + + if(smode==NULL || smode->s==NULL || smode->len<=0) { + LM_INFO("no tracing mode - trace message\n"); + trace_type = SIPTRACE_MESSAGE; + } else { + switch(smode->s[0]) { + case 'M': + case 'm': + trace_type = SIPTRACE_MESSAGE; + break; + case 'T': + case 't': + trace_type = SIPTRACE_TRANSACTION; + break; + case 'D': + case 'd': + trace_type = SIPTRACE_DIALOG; + break; + default: + trace_type = SIPTRACE_MESSAGE; + LM_INFO("unexpected tracing mode [%.*s] - trace message\n", + smode->len, smode->s); + } + } + + return sip_trace_helper(msg, NULL, NULL, NULL, NULL, trace_type); +} + +/** + * + */ +static int w_sip_trace_mode(sip_msg_t *msg, char *pmode, char *p2) +{ + str smode = STR_NULL; + if(fixup_get_svalue(msg, (gparam_t*)pmode, &smode)<0) { + LM_ERR("failed to get tracing mode parameter\n"); + return -1; + } + return ki_sip_trace_mode(msg, &smode); +} + static void trace_onreq_out(struct cell *t, int type, struct tmcb_params *ps) { siptrace_data_t sto; @@ -2134,6 +2185,11 @@ static sr_kemi_t sr_kemi_siptrace_exports[] = { { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("siptrace"), str_init("sip_trace_mode"), + SR_KEMIP_INT, ki_sip_trace_mode, + { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { {0, 0}, {0, 0}, 0, NULL, { 0, 0, 0, 0, 0, 0 } } };

1 0

git:master:41f6ddb8: modules: readme files regenerated - siptrace ... [skip ci]
by Kamailio Dev 01 Oct '19

01 Oct '19

Module: kamailio Branch: master Commit: 41f6ddb8162960633b005c759b74efd86296d021 URL: https://github.com/kamailio/kamailio/commit/41f6ddb8162960633b005c759b74efd… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2019-10-01T10:17:03+02:00 modules: readme files regenerated - siptrace ... [skip ci] --- Modified: src/modules/siptrace/README --- Diff: https://github.com/kamailio/kamailio/commit/41f6ddb8162960633b005c759b74efd… Patch: https://github.com/kamailio/kamailio/commit/41f6ddb8162960633b005c759b74efd… --- diff --git a/src/modules/siptrace/README b/src/modules/siptrace/README index 35b1dd78a3..951482065d 100644 --- a/src/modules/siptrace/README +++ b/src/modules/siptrace/README @@ -435,8 +435,9 @@ modparam("siptrace", "force_send_sock", "sip:10.1.1.2:5000") If set to 1, the module uses core events triggered when receiving or sending SIP traffic to mirror traffic to a SIP capture server using - HEP. It will automatically do the mirroring of all traffic, no need to - set the siptrace flag per request. + HEP. It will automatically do the mirroring of all SIP traffic. It is + no longer needed to set the siptrace flag per request or execute + sip_trace(), if it is done, then there mirroring is duplicated. If set to 0, no automatic mirroring of SIP traffic via HEP.

4 4

git:master:47e0649e: pdt: init len variable to avoid using garbage value
by Daniel-Constantin Mierla 01 Oct '19

01 Oct '19

Module: kamailio Branch: master Commit: 47e0649eca286bfc26c39dd1142169fc06eea077 URL: https://github.com/kamailio/kamailio/commit/47e0649eca286bfc26c39dd1142169f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-01T12:22:34+02:00 pdt: init len variable to avoid using garbage value --- Modified: src/modules/pdt/pdtree.c --- Diff: https://github.com/kamailio/kamailio/commit/47e0649eca286bfc26c39dd1142169f… Patch: https://github.com/kamailio/kamailio/commit/47e0649eca286bfc26c39dd1142169f… --- diff --git a/src/modules/pdt/pdtree.c b/src/modules/pdt/pdtree.c index e55f5bdfa5..d0ff43871a 100644 --- a/src/modules/pdt/pdtree.c +++ b/src/modules/pdt/pdtree.c @@ -278,7 +278,6 @@ str* get_domain(pdt_tree_t *pt, str *sp, int *plen) *plen = len; return domain; - } /** @@ -287,7 +286,7 @@ str* get_domain(pdt_tree_t *pt, str *sp, int *plen) str* pdt_get_domain(pdt_tree_t *pl, str* sdomain, str *code, int *plen) { pdt_tree_t *it; - int len; + int len = 0; str *domain=NULL; if(pl==NULL || sdomain==NULL || sdomain->s==NULL || code == NULL @@ -300,13 +299,14 @@ str* pdt_get_domain(pdt_tree_t *pl, str* sdomain, str *code, int *plen) it = pl; while(it!=NULL && str_strcmp(&it->sdomain, sdomain)<0) it = it->next; - + if(it==NULL || str_strcmp(&it->sdomain, sdomain)>0) return NULL; - + domain = get_domain(it, code, &len); if(plen!=NULL) - *plen = len; + *plen = len; + return domain; }

1 0

git:master:6861995e: speeddial: fix stripping domain prefix
by Daniel-Constantin Mierla 01 Oct '19

01 Oct '19

Module: kamailio Branch: master Commit: 6861995e417c40e9ab530d4c0bed97c57de184fd URL: https://github.com/kamailio/kamailio/commit/6861995e417c40e9ab530d4c0bed97c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-01T12:17:48+02:00 speeddial: fix stripping domain prefix - increment the index after the value is adjusted --- Modified: src/modules/speeddial/sdlookup.c --- Diff: https://github.com/kamailio/kamailio/commit/6861995e417c40e9ab530d4c0bed97c… Patch: https://github.com/kamailio/kamailio/commit/6861995e417c40e9ab530d4c0bed97c… --- diff --git a/src/modules/speeddial/sdlookup.c b/src/modules/speeddial/sdlookup.c index d9e52bf3cd..e26bc37bb8 100644 --- a/src/modules/speeddial/sdlookup.c +++ b/src/modules/speeddial/sdlookup.c @@ -117,7 +117,6 @@ int sd_lookup_owner(sip_msg_t* _msg, str* stable, str* sowner) db_vals[nr_keys].nul = 0; db_vals[nr_keys].val.str_val.s = puri->host.s; db_vals[nr_keys].val.str_val.len = puri->host.len; - nr_keys++; if (dstrip_s.s!=NULL && dstrip_s.len>0 && dstrip_s.len<puri->host.len @@ -126,6 +125,7 @@ int sd_lookup_owner(sip_msg_t* _msg, str* stable, str* sowner) db_vals[nr_keys].val.str_val.s += dstrip_s.len; db_vals[nr_keys].val.str_val.len -= dstrip_s.len; } + nr_keys++; } /* take sd from r-uri */ if (parse_sip_msg_uri(_msg) < 0)

1 0

sip_trace() broken in master
by Juha Heinanen 01 Oct '19

01 Oct '19

In 5.2 setflag(TRACE); sip_trace(); traces both requests and responses. In master, only requests. Please fix. -- Juha

4 15

git:master:dfe8db75: core: init local structs to avoid use of garbage values
by Daniel-Constantin Mierla 01 Oct '19

01 Oct '19

Module: kamailio Branch: master Commit: dfe8db758f84f5e88e0cb35b80a65dcd48158897 URL: https://github.com/kamailio/kamailio/commit/dfe8db758f84f5e88e0cb35b80a65dc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-01T10:28:43+02:00 core: init local structs to avoid use of garbage values --- Modified: src/core/forward.c Modified: src/core/ip_addr.h --- Diff: https://github.com/kamailio/kamailio/commit/dfe8db758f84f5e88e0cb35b80a65dc… Patch: https://github.com/kamailio/kamailio/commit/dfe8db758f84f5e88e0cb35b80a65dc… --- diff --git a/src/core/forward.c b/src/core/forward.c index 8216ccf88a..a31c1c2af5 100644 --- a/src/core/forward.c +++ b/src/core/forward.c @@ -471,6 +471,7 @@ int forward_request(struct sip_msg* msg, str* dst, unsigned short port, prev_send_sock=0; err=0; + memset(&dns_srv_h, 0, sizeof(struct dns_srv_handle)); #endif buf=0; diff --git a/src/core/ip_addr.h b/src/core/ip_addr.h index 668179c45e..afbaece075 100644 --- a/src/core/ip_addr.h +++ b/src/core/ip_addr.h @@ -421,6 +421,7 @@ static inline void su2ip_addr(struct ip_addr* ip, union sockaddr_union* su) break; default: LM_CRIT("unknown address family %d\n", su->s.sa_family); + memset(ip, 0, sizeof(ip_addr_t)); } }

1 0

git:master:a886f8ef: core: tcp - safety check that dst address is provided for tcp_send()
by Daniel-Constantin Mierla 01 Oct '19

01 Oct '19

Module: kamailio Branch: master Commit: a886f8ef15677b951e36407735f1fb5b94f0edd0 URL: https://github.com/kamailio/kamailio/commit/a886f8ef15677b951e36407735f1fb5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-01T10:28:43+02:00 core: tcp - safety check that dst address is provided for tcp_send() --- Modified: src/core/tcp_main.c --- Diff: https://github.com/kamailio/kamailio/commit/a886f8ef15677b951e36407735f1fb5… Patch: https://github.com/kamailio/kamailio/commit/a886f8ef15677b951e36407735f1fb5… --- diff --git a/src/core/tcp_main.c b/src/core/tcp_main.c index 61a692af85..99d33ee719 100644 --- a/src/core/tcp_main.c +++ b/src/core/tcp_main.c @@ -2002,8 +2002,13 @@ int tcp_send(struct dest_info* dst, union sockaddr_union* from, snd_flags_t t_send_flags; #endif /* USE_TLS */ + if(unlikely(dst==NULL)) { + LM_ERR("no destination address provided\n"); + return -1; + } + port=su_getport(&dst->to); - try_local_port = (dst && dst->send_sock)?dst->send_sock->port_no:0; + try_local_port = (dst->send_sock)?dst->send_sock->port_no:0; con_lifetime=cfg_get(tcp, tcp_cfg, con_lifetime); if (likely(port)){ su2ip_addr(&ip, &dst->to);

1 0

git:master:3f23f9ef: siptrace: docs - more info on using trace_mode vs flag/sip_trace()
by Daniel-Constantin Mierla 01 Oct '19

01 Oct '19

Module: kamailio Branch: master Commit: 3f23f9ef88e4fa2af8d24c3260cb9821aa2f64cc URL: https://github.com/kamailio/kamailio/commit/3f23f9ef88e4fa2af8d24c3260cb982… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-01T10:06:47+02:00 siptrace: docs - more info on using trace_mode vs flag/sip_trace() --- Modified: src/modules/siptrace/doc/siptrace_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/3f23f9ef88e4fa2af8d24c3260cb982… Patch: https://github.com/kamailio/kamailio/commit/3f23f9ef88e4fa2af8d24c3260cb982… --- diff --git a/src/modules/siptrace/doc/siptrace_admin.xml b/src/modules/siptrace/doc/siptrace_admin.xml index 875dc2348f..21d6090c74 100644 --- a/src/modules/siptrace/doc/siptrace_admin.xml +++ b/src/modules/siptrace/doc/siptrace_admin.xml @@ -471,8 +471,10 @@ modparam("siptrace", "force_send_sock", "sip:10.1.1.2:5000") <para> If set to 1, the module uses core events triggered when receiving or sending SIP traffic to mirror traffic to a SIP capture server - using HEP. It will automatically do the mirroring of all traffic, - no need to set the siptrace flag per request. + using HEP. It will automatically do the mirroring of all SIP traffic. + It is no longer needed to set the siptrace flag per request or + execute sip_trace(), if it is done, then there mirroring is + duplicated. </para> <para> If set to 0, no automatic mirroring of SIP traffic via HEP.

1 0

unused variable
by Juha Heinanen 01 Oct '19

01 Oct '19

With latest master, I got this: CC (gcc) [M db_mysql.so] km_dbase.o km_dbase.c: In function 'db_mysql_submit_query': km_dbase.c:71:9: warning: unused variable 't' [-Wunused-variable] time_t t; ^ It would be nice if devs would try to compile the code after making changes. -- Juha

2 2

git:master:fa5f3645: jsonrpcc: removed old todo file
by Daniel-Constantin Mierla 01 Oct '19

01 Oct '19

Module: kamailio Branch: master Commit: fa5f36454f2ef5fb4e55dd05f746430d9786e842 URL: https://github.com/kamailio/kamailio/commit/fa5f36454f2ef5fb4e55dd05f746430… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-01T09:04:01+02:00 jsonrpcc: removed old todo file --- Removed: src/modules/jsonrpcc/TODO --- Diff: https://github.com/kamailio/kamailio/commit/fa5f36454f2ef5fb4e55dd05f746430… Patch: https://github.com/kamailio/kamailio/commit/fa5f36454f2ef5fb4e55dd05f746430… --- diff --git a/src/modules/jsonrpcc/TODO b/src/modules/jsonrpcc/TODO deleted file mode 100644 index f0e19152f1..0000000000 --- a/src/modules/jsonrpcc/TODO +++ /dev/null @@ -1,2 +0,0 @@ -* "Reliable" Notifications (implement using requests, and failover on error; ignore non-error responses) ? -* Implement timout for non-Linux systems

1 0

git:master:a6caed41: ims_qos: fixed typo in comments (timout -> timeout)
by Daniel-Constantin Mierla 01 Oct '19

01 Oct '19

Module: kamailio Branch: master Commit: a6caed41166e555d7297abbae6017c5c54262662 URL: https://github.com/kamailio/kamailio/commit/a6caed41166e555d7297abbae6017c5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-01T09:02:56+02:00 ims_qos: fixed typo in comments (timout -> timeout) --- Modified: src/modules/ims_qos/rx_str.c --- Diff: https://github.com/kamailio/kamailio/commit/a6caed41166e555d7297abbae6017c5… Patch: https://github.com/kamailio/kamailio/commit/a6caed41166e555d7297abbae6017c5… --- diff --git a/src/modules/ims_qos/rx_str.c b/src/modules/ims_qos/rx_str.c index efa9617222..6b243e85a4 100644 --- a/src/modules/ims_qos/rx_str.c +++ b/src/modules/ims_qos/rx_str.c @@ -104,8 +104,8 @@ int rx_send_str(str *rx_session_id) { if (auth->u.auth.state == AUTH_ST_DISCON) { // If we are in DISCON is because an STR was already sent - // so just wait for STA or for Grace Timout to happen - LM_DBG("Hmmm, auth session already in disconnected state\n"); + // so just wait for STA or for Grace Timeout to happen + LM_DBG("auth session already in disconnected state\n"); cdpb.AAASessionsUnlock(auth->hash); return CSCF_RETURN_FALSE; }

1 0

git:master:56313380: sms: fixed typo in comments (timout -> timeout)
by Daniel-Constantin Mierla 01 Oct '19

01 Oct '19

Module: kamailio Branch: master Commit: 5631338036c405b1e8c7fe8a1e320db2eb63c3f9 URL: https://github.com/kamailio/kamailio/commit/5631338036c405b1e8c7fe8a1e320db… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-01T09:01:29+02:00 sms: fixed typo in comments (timout -> timeout) --- Modified: src/modules/sms/libsms_modem.c Modified: src/modules/sms/libsms_modem.h --- Diff: https://github.com/kamailio/kamailio/commit/5631338036c405b1e8c7fe8a1e320db… Patch: https://github.com/kamailio/kamailio/commit/5631338036c405b1e8c7fe8a1e320db… --- diff --git a/src/modules/sms/libsms_modem.c b/src/modules/sms/libsms_modem.c index 5093d28ee2..fe0be1f8a7 100644 --- a/src/modules/sms/libsms_modem.c +++ b/src/modules/sms/libsms_modem.c @@ -125,7 +125,7 @@ int put_command( struct modem *mdm, char* cmd, int cmd_len, char* answer, } } } - /* repeat until timout */ + /* repeat until timeout */ }while (timeoutcounter<timeout); if (!answer_e) diff --git a/src/modules/sms/libsms_modem.h b/src/modules/sms/libsms_modem.h index feeb6acac9..7eb0a80b04 100644 --- a/src/modules/sms/libsms_modem.h +++ b/src/modules/sms/libsms_modem.h @@ -31,7 +31,7 @@ typedef int(*cds_report)( struct modem* , char* , int ); /* put_command - Sends a command to the modem and waits max timout*0.1 seconds for an answer. + Sends a command to the modem and waits max timeout*0.1 seconds for an answer. The function returns the length of the answer. The answer can be Ok, ERROR or expect. The command may be empty or NULL */

1 0

git:master:75e0e0f4: db_mysql: fixed typo in comments (timout -> timeout)
by Daniel-Constantin Mierla 01 Oct '19

01 Oct '19

Module: kamailio Branch: master Commit: 75e0e0f4d693e207d2035f84c3e1ddc9cc715ec4 URL: https://github.com/kamailio/kamailio/commit/75e0e0f4d693e207d2035f84c3e1ddc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-10-01T08:59:44+02:00 db_mysql: fixed typo in comments (timout -> timeout) --- Modified: src/modules/db_mysql/km_dbase.c --- Diff: https://github.com/kamailio/kamailio/commit/75e0e0f4d693e207d2035f84c3e1ddc… Patch: https://github.com/kamailio/kamailio/commit/75e0e0f4d693e207d2035f84c3e1ddc… --- diff --git a/src/modules/db_mysql/km_dbase.c b/src/modules/db_mysql/km_dbase.c index 3014d374f6..eaff3276b6 100644 --- a/src/modules/db_mysql/km_dbase.c +++ b/src/modules/db_mysql/km_dbase.c @@ -89,7 +89,7 @@ static int db_mysql_submit_query(const db1_con_t* _h, const str* _s) } } /* - * We're doing later a query anyway that will reset the timout of the server, + * We're doing later a query anyway that will reset the timeout of the server, * so it makes sense to set the timestamp value to the actual time in order * to prevent unnecessary pings. */

1 0

Re: [sr-dev] unused variable
by Juha Heinanen 01 Oct '19

01 Oct '19

Juha Heinanen writes: > It would be nice if devs would try to compile the code after making changes. I apologize. It was stupid statement. -- Juha

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2019