sr-dev June 2018

sr-dev@lists.kamailio.org

26 participants
320 discussions

git:master:f1bcda4e: core: cleanup dns cache defines, no function change

by Henning Westerholt

Module: kamailio Branch: master Commit: f1bcda4e2e2d37ec2b5556e95b61b03907df6366 URL: https://github.com/kamailio/kamailio/commit/f1bcda4e2e2d37ec2b5556e95b61b03… Author: Henning Westerholt <hw(a)kamailio.org> Committer: Henning Westerholt <hw(a)kamailio.org> Date: 2018-06-09T00:06:23+02:00 core: cleanup dns cache defines, no function change cleanup core dns cache defines, they were set since 2006 for a bit additional debugging, no change in functionality --- Modified: src/core/dns_cache.c --- Diff: https://github.com/kamailio/kamailio/commit/f1bcda4e2e2d37ec2b5556e95b61b03… Patch: https://github.com/kamailio/kamailio/commit/f1bcda4e2e2d37ec2b5556e95b61b03…

6 years

git:master:e963851b: core: cleanup resolver defines, no function change

by Henning Westerholt

Module: kamailio Branch: master Commit: e963851b5391e0f6267788d1bdaf5be576ca7466 URL: https://github.com/kamailio/kamailio/commit/e963851b5391e0f6267788d1bdaf5be… Author: Henning Westerholt <hw(a)kamailio.org> Committer: Henning Westerholt <hw(a)kamailio.org> Date: 2018-06-08T23:52:29+02:00 core: cleanup resolver defines, no function change cleanup core resolver defines, they were set since 2007 for a bit additional debugging, no change in functionality --- Modified: src/core/resolve.c Modified: src/core/resolve.h --- Diff: https://github.com/kamailio/kamailio/commit/e963851b5391e0f6267788d1bdaf5be… Patch: https://github.com/kamailio/kamailio/commit/e963851b5391e0f6267788d1bdaf5be…

6 years

[kamailio/kamailio] packaging: Fix typo in kamailio.spec (#1559)

by Edwin Fine

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - _probably_ - [ ] Tested changes locally (_not applicable_) - [ ] Related to issue #XXXX (_not applicable_) #### Description There is a number of occurrences in `pkg/kamailio/obs/kamailio.spec` of `%bcond_with|without rebbitmq`. Note the `e` in `rebbitmq`. Since the condition to include the `rabbitmq` package (line 633) is `%if %{with rabbitmq}` (with an `a`), this conditional statement would not have the intended effect. If this was not a deliberate typo for some reason, this commit addresses the issue by changing all `%bcond_with|without` occurrences of `rebbitmq` to `rabbitmq`. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1559 -- Commit Summary -- * packaging: Fix typo in kamailio.spec -- File Changes -- M pkg/kamailio/obs/kamailio.spec (16) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1559.patch https://github.com/kamailio/kamailio/pull/1559.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1559

6 years

git:master:861c52ca: packaging: Fix typo in kamailio.spec

by Henning Westerholt

Module: kamailio Branch: master Commit: 861c52ca6a9ca3bd6be5e89df92c1f65b46002f4 URL: https://github.com/kamailio/kamailio/commit/861c52ca6a9ca3bd6be5e89df92c1f6… Author: Edwin Fine <efine(a)users.noreply.github.com> Committer: Henning Westerholt <henningw(a)users.noreply.github.com> Date: 2018-06-08T21:26:20+02:00 packaging: Fix typo in kamailio.spec There is a number of occurrences of `%bcond_with|without rebbitmq`. Since the condition to include the `rabbitmq` package (line 633) is `%if %{with rabbitmq}`, this conditional statement would not have the intended effect. If this was not a deliberate typo for some reason, this commit fixes the issue by changing all `%bcond_with|without` occurrences of `rebbitmq` to `rabbitmq`. --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/861c52ca6a9ca3bd6be5e89df92c1f6… Patch: https://github.com/kamailio/kamailio/commit/861c52ca6a9ca3bd6be5e89df92c1f6… --- diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index d7f27371d3..cc53dc9e30 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -15,7 +15,7 @@ %bcond_without kazoo %bcond_without memcached %bcond_without perl -%bcond_without rebbitmq +%bcond_without rabbitmq %bcond_without redis %bcond_without sctp %bcond_without websocket @@ -35,7 +35,7 @@ %bcond_without kazoo %bcond_without memcached %bcond_without perl -%bcond_without rebbitmq +%bcond_without rabbitmq %bcond_without redis %bcond_without sctp %bcond_without websocket @@ -55,7 +55,7 @@ %bcond_without kazoo %bcond_without memcached %bcond_without perl -%bcond_without rebbitmq +%bcond_without rabbitmq %bcond_without redis %bcond_without sctp %bcond_without websocket @@ -75,7 +75,7 @@ %bcond_with kazoo %bcond_without memcached %bcond_without perl -%bcond_with rebbitmq +%bcond_with rabbitmq %bcond_with redis %bcond_without sctp %bcond_without websocket @@ -96,7 +96,7 @@ %bcond_without kazoo %bcond_without memcached %bcond_without perl -%bcond_without rebbitmq +%bcond_without rabbitmq %bcond_without redis %bcond_without sctp %bcond_without websocket @@ -116,7 +116,7 @@ %bcond_with kazoo %bcond_without memcached %bcond_without perl -%bcond_with rebbitmq +%bcond_with rabbitmq %bcond_without redis %bcond_without sctp %bcond_without websocket @@ -136,7 +136,7 @@ %bcond_with kazoo %bcond_with memcached %bcond_with perl -%bcond_with rebbitmq +%bcond_with rabbitmq %bcond_with redis %bcond_with sctp %bcond_with websocket @@ -156,7 +156,7 @@ %bcond_with kazoo %bcond_with memcached %bcond_without perl -%bcond_without rebbitmq +%bcond_without rabbitmq %bcond_without redis %bcond_with sctp %bcond_with websocket

6 years

git:5.1:538ac2c5: core: make dns name to IP conversion more robust for IPv4 and IPv6

by Henning Westerholt

Module: kamailio Branch: 5.1 Commit: 538ac2c5eeb9f2df1d896adf0661e5e35fadb504 URL: https://github.com/kamailio/kamailio/commit/538ac2c5eeb9f2df1d896adf0661e5e… Author: Henning Westerholt <hw(a)kamailio.org> Committer: Henning Westerholt <hw(a)kamailio.org> Date: 2018-06-08T21:20:54+02:00 core: make dns name to IP conversion more robust for IPv4 and IPv6 (cherry picked from commit 4a55a2b40b91f282d7fd8f0e3c3ae22bcf56d9dc) --- Modified: src/core/resolve.h --- Diff: https://github.com/kamailio/kamailio/commit/538ac2c5eeb9f2df1d896adf0661e5e… Patch: https://github.com/kamailio/kamailio/commit/538ac2c5eeb9f2df1d896adf0661e5e… --- diff --git a/src/core/resolve.h b/src/core/resolve.h index fad783e4e6..30cce19581 100644 --- a/src/core/resolve.h +++ b/src/core/resolve.h @@ -229,6 +229,10 @@ static inline struct ip_addr* str2ip(str* st) static struct ip_addr ip; unsigned char* s; + /* just in case that e.g. the VIA parser get confused */ + if(unlikely(!st->s || st->len <= 0)) { + LM_ERR("invalid name, no conversion to IP address possible\n"); + } s=(unsigned char*)st->s; /*init*/ @@ -281,6 +285,10 @@ static inline struct ip_addr* str2ip6(str* st) unsigned char* limit; unsigned char* s; + /* just in case that e.g. the VIA parser get confused */ + if(unlikely(!st->s || st->len <= 0)) { + LM_ERR("invalid name, no conversion to IP address possible\n"); + } /* init */ if ((st->len) && (st->s[0]=='[')){ /* skip over [ ] */

6 years

git:5.0:11300211: core: make dns name to IP conversion more robust for IPv4 and IPv6

by Henning Westerholt

Module: kamailio Branch: 5.0 Commit: 11300211d6562aafc654a778f25657f001a39790 URL: https://github.com/kamailio/kamailio/commit/11300211d6562aafc654a778f25657f… Author: Henning Westerholt <hw(a)kamailio.org> Committer: Henning Westerholt <hw(a)kamailio.org> Date: 2018-06-08T21:20:32+02:00 core: make dns name to IP conversion more robust for IPv4 and IPv6 (cherry picked from commit 4a55a2b40b91f282d7fd8f0e3c3ae22bcf56d9dc) --- Modified: src/core/resolve.h --- Diff: https://github.com/kamailio/kamailio/commit/11300211d6562aafc654a778f25657f… Patch: https://github.com/kamailio/kamailio/commit/11300211d6562aafc654a778f25657f… --- diff --git a/src/core/resolve.h b/src/core/resolve.h index fad783e4e6..30cce19581 100644 --- a/src/core/resolve.h +++ b/src/core/resolve.h @@ -229,6 +229,10 @@ static inline struct ip_addr* str2ip(str* st) static struct ip_addr ip; unsigned char* s; + /* just in case that e.g. the VIA parser get confused */ + if(unlikely(!st->s || st->len <= 0)) { + LM_ERR("invalid name, no conversion to IP address possible\n"); + } s=(unsigned char*)st->s; /*init*/ @@ -281,6 +285,10 @@ static inline struct ip_addr* str2ip6(str* st) unsigned char* limit; unsigned char* s; + /* just in case that e.g. the VIA parser get confused */ + if(unlikely(!st->s || st->len <= 0)) { + LM_ERR("invalid name, no conversion to IP address possible\n"); + } /* init */ if ((st->len) && (st->s[0]=='[')){ /* skip over [ ] */

6 years

git:master:4a55a2b4: core: make dns name to IP conversion more robust for IPv4 and IPv6

by Henning Westerholt

Module: kamailio Branch: master Commit: 4a55a2b40b91f282d7fd8f0e3c3ae22bcf56d9dc URL: https://github.com/kamailio/kamailio/commit/4a55a2b40b91f282d7fd8f0e3c3ae22… Author: Henning Westerholt <hw(a)kamailio.org> Committer: Henning Westerholt <hw(a)kamailio.org> Date: 2018-06-08T21:16:51+02:00 core: make dns name to IP conversion more robust for IPv4 and IPv6 --- Modified: src/core/resolve.h --- Diff: https://github.com/kamailio/kamailio/commit/4a55a2b40b91f282d7fd8f0e3c3ae22… Patch: https://github.com/kamailio/kamailio/commit/4a55a2b40b91f282d7fd8f0e3c3ae22… --- diff --git a/src/core/resolve.h b/src/core/resolve.h index fad783e4e6..30cce19581 100644 --- a/src/core/resolve.h +++ b/src/core/resolve.h @@ -229,6 +229,10 @@ static inline struct ip_addr* str2ip(str* st) static struct ip_addr ip; unsigned char* s; + /* just in case that e.g. the VIA parser get confused */ + if(unlikely(!st->s || st->len <= 0)) { + LM_ERR("invalid name, no conversion to IP address possible\n"); + } s=(unsigned char*)st->s; /*init*/ @@ -281,6 +285,10 @@ static inline struct ip_addr* str2ip6(str* st) unsigned char* limit; unsigned char* s; + /* just in case that e.g. the VIA parser get confused */ + if(unlikely(!st->s || st->len <= 0)) { + LM_ERR("invalid name, no conversion to IP address possible\n"); + } /* init */ if ((st->len) && (st->s[0]=='[')){ /* skip over [ ] */

6 years

git:master:6a478a24: core: bug fix in function reference for full preprocessor defines output

by Henning Westerholt

Module: kamailio Branch: master Commit: 6a478a2432e04652f2f5ef5919101dd166d9ee2d URL: https://github.com/kamailio/kamailio/commit/6a478a2432e04652f2f5ef5919101dd… Author: Henning Westerholt <hw(a)kamailio.org> Committer: Henning Westerholt <hw(a)kamailio.org> Date: 2018-06-08T18:09:08+02:00 core: bug fix in function reference for full preprocessor defines output --- Modified: src/core/core_cmd.c --- Diff: https://github.com/kamailio/kamailio/commit/6a478a2432e04652f2f5ef5919101dd… Patch: https://github.com/kamailio/kamailio/commit/6a478a2432e04652f2f5ef5919101dd… --- diff --git a/src/core/core_cmd.c b/src/core/core_cmd.c index d1ceb88cef..9acc5361b0 100644 --- a/src/core/core_cmd.c +++ b/src/core/core_cmd.c @@ -1072,9 +1072,9 @@ static rpc_export_t core_rpc_methods[] = { 0}, {"core.aliases_list", core_aliases_list, core_aliases_list_doc, 0}, {"core.sockets_list", core_sockets_list, core_sockets_list_doc, 0}, - {"core.modules", core_modules, core_modules_doc, RET_ARRAY}, - {"core.ppdefines", core_ppdefines, core_ppdefines_doc, RET_ARRAY}, - {"core.ppdefines_full", core_ppdefines_full, core_ppdefines_doc, RET_ARRAY}, + {"core.modules", core_modules, core_modules_doc, RET_ARRAY}, + {"core.ppdefines", core_ppdefines, core_ppdefines_doc, RET_ARRAY}, + {"core.ppdefines_full", core_ppdefines_full, core_ppdefines_full_doc, RET_ARRAY}, #ifdef USE_DNS_CACHE {"dns.mem_info", dns_cache_mem_info, dns_cache_mem_info_doc, 0 },

6 years

git:master:94e7a4d8: modules: readme files regenerated - sdpops ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 94e7a4d862909886ef9ed9426532eee32f0262d9 URL: https://github.com/kamailio/kamailio/commit/94e7a4d862909886ef9ed9426532eee… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2018-06-08T11:01:48+02:00 modules: readme files regenerated - sdpops ... [skip ci] --- Modified: src/modules/sdpops/README --- Diff: https://github.com/kamailio/kamailio/commit/94e7a4d862909886ef9ed9426532eee… Patch: https://github.com/kamailio/kamailio/commit/94e7a4d862909886ef9ed9426532eee… --- diff --git a/src/modules/sdpops/README b/src/modules/sdpops/README index 5986d445e0..7e029018f9 100644 --- a/src/modules/sdpops/README +++ b/src/modules/sdpops/README @@ -481,7 +481,8 @@ if(sdp_with_ice()) { Store the search part of SDP body message with line beginning with 'string' in an AVP. Return 1 if 'string' is found in SDP, -1 on error - and -2 if there is no SDP part in the message body. + and -2 if there is no SDP part in the message body. The second + parameter can contain psudeo-variables. This function can be used from ANY_ROUTE.

6 years

[kamailio/kamailio] log_prefix do not work in failure_route (#1531)

by Jurijs Ivolga

### Description log_prefix do not work in failure_route ### Troubleshooting #### Reproduction log_prefix="{$mt $hdr(CSeq) $ci} " ... ... failure_route[RTF_LCR_ROUTE] { if (t_is_canceled()) { exit; } xlog("L_INFO", "--- SCRIPT: failure_route - RTF_LCR_ROUTE\n"); if (t_check_status("408|50[0-4]") or (t_branch_timeout() and !t_branch_replied())) { if(!next_gw()) { send_reply("503", "No more LCR gateways"); exit; } xlog("L_INFO", "flag $avp(lcr_flag) \n"); t_on_failure("RTF_LCR_ROUTE"); t_set_retr(0, 4000); route(RELAY); exit; } } #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` INFO: <script>: --- SCRIPT: failure_route - RTF_LCR_ROUTE ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 4.4.7 (x86_64/linux) 35d8ab flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 35d8ab compiled on 11:55:20 Mar 19 2018 with gcc 6.3.0 ``` * **Operating System**:  ``` Linux kamailio 4.13.0-37-generic #42~16.04.1-Ubuntu SMP Wed Mar 7 16:03:28 UTC 2018 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1531

6 years

← Newer
1
...
20
21
22
23
24
25
26
...
32
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2018