sr-dev March 2018

sr-dev@lists.kamailio.org

17 participants
326 discussions

[kamailio/kamailio] define flag_t as unsigned long (#1288)

by juha-h

Currently core/flags.h defines typedef unsigned int flag_t; It would better to use unsigned long in order to allow more that 32 flags on 64 bit architectures. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1288

6 years, 8 months

[kamailio/kamailio] IPOPS is_in_subnet function doesn't match host address in cidr notation (#1250)

by kbdfck

### Description is_in_subnet function requires subnet param to be network address and fails for host address in cidr notation despite it is contained in corresponding subnet. For example, is_in_subnet("1.2.3.2", "1.2.3.0/30") returns true but is_in_subnet("1.2.3.2", "1.2.3.2/30") returns false, although 1.2.3.2 is present in 1.2.3.2/30 and 1.2.3.2 is allowed IP of 1.2.3.0/30 Of course, "1.2.3.2/30" this is not actually a subnet specification and rather is IP in CIDR notation, but sometimes it is required to check if some IP matches specified IP with CIDR. ### Possible Solutions It would be cool if is_in_subnet take such cases as matches. I think this should not break anything, because host IP and CIDR always define network containing specified host. Another solution would be separate function with more relaxed behavior... This happens on Kamailio 5.1 devel. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1250

6 years, 8 months

[kamailio/kamailio] Segmentation fault Dialog RPC (#1482)

by pars3c1

### Description Hi all, i’m using kamailio 4.4.6 , and when I call the rpc dialog “profile_list_dlgs” , sometimes I have a segmentation fault. Can you help me to understand why it happened ? Thanks for your support  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` This is the dump: Program terminated with signal 11, Segmentation fault. #0 0x00007f49ee062e07 in internal_rpc_print_dlg (rpc=0x7f49ed99e9c0, c=0x7f49ed99e960, dlg=0x7f49ef89ba38, with_context=0) at dialog.c:1548 1548 if (pl->profile->has_value) { Missing separate debuginfos, use: debuginfo-install glibc-2.12-1.192.el6.x86_64 keyutils-libs-1.4-5.el6.x86_64 krb5-libs-1.10.3-57.el6.x86_64 libcom_err-1.41.12-22.el6.x86_64 libselinux-2.0.94-7.el6.x86_64 libxml2-2.7.6-21.el6_8.1.x86_64 lua-5.1.4-4.1.el6.x86_64 mysql-libs-5.1.73-7.el6.x86_64 nss-softokn-freebl-3.14.3-23.3.el6_8.x86_64 openssl-1.0.1e-48.el6_8.3.x86_64 zlib-1.2.3-29.el6.x86_64 (gdb) bt full #0 0x00007f49ee062e07 in internal_rpc_print_dlg (rpc=0x7f49ed99e9c0, c=0x7f49ed99e960, dlg=0x7f49ef89ba38, with_context=0) at dialog.c:1548 rpc_cb = {rpc = 0x3031ea0, c = 0x400} h = 0x2d21e60 sh = 0x2d1db70 ssh = 0x2d20050 pl = 0x7f49ef18c588 var = 0x0 __FUNCTION__ = "internal_rpc_print_dlg" #1 0x00007f49ee0637b3 in internal_rpc_profile_print_dlgs (rpc=0x7f49ed99e9c0, c=0x7f49ed99e960, profile_name=0x7fff65fcb1a0, value=0x0) at dialog.c:1681 profile = 0x7f49ee5aca88 ph = 0x7f49eeb5b670 i = 2 #2 0x00007f49ee063e64 in rpc_profile_print_dlgs (rpc=0x7f49ed99e9c0, c=0x7f49ed99e960) at dialog.c:1785 profile_name = {s = 0x3031e80 "outbound", len = 8} value = {s = 0x0, len = 0} #3 0x00007f49ed78960f in jsonrpc_dispatch (msg=0x7fff65fcc5a0, s1=0x0, s2=0x0) at jsonrpc-s_mod.c:1098 rpce = 0x7f4a13212d30 ctx = 0x7f49ed99e960 ret = 0 nj = 0x3031ab0 val = {s = 0x3032030 "dlg.profile_list", len = 16} __FUNCTION__ = "jsonrpc_dispatch" #4 0x000000000041f75d in do_action (h=0x7fff65fcc4c0, a=0x7f4a13189e28, msg=0x7fff65fcc5a0) at action.c:1054 ``` #### Log Messages  ``` the result to the commands p *pl and p *pl->profile #0 0x00007f49ee062e07 in internal_rpc_print_dlg (rpc=0x7f49ed99e9c0, c=0x7f49ed99e960, dlg=0x7f49ef89ba38, with_context=0) at dialog.c:1548 1548 if (pl->profile->has_value) { Missing separate debuginfos, use: debuginfo-install glibc-2.12-1.192.el6.x86_64 keyutils-libs-1.4-5.el6.x86_64 krb5-libs-1.10.3-57.el6.x86_64 libcom_err-1.41.12-22.el6.x86_64 libselinux-2.0.94-7.el6.x86_64 libxml2-2.7.6-21.el6_8.1.x86_64 lua-5.1.4-4.1.el6.x86_64 mysql-libs-5.1.73-7.el6.x86_64 nss-softokn-freebl-3.14.3-23.3.el6_8.x86_64 openssl-1.0.1e-48.el6_8.3.x86_64 zlib-1.2.3-29.el6.x86_64 (gdb) p *pl $1 = {hash_linker = {value = {s = 0x113ef180024 <Address 0x113ef180024 out of bounds>, len = -277948848}, dlg = 0x7f49ef18c5b8, puid = "\n\000\000\000-5a9\303\305\030\357I\177\000\000S\000\000\000\060\062\060\063in_routing\000CR=6@", puid_len = 1598313555, expires = 3977578104333875508, flags = 876097589, linker = 0x422d30263936313d, next = 0x3d50542c36343d4f, prev = 0x52542c3634303730, hash = 1028345429}, next = 0x50542c36343d4f42, profile = 0x542c36343037303d} (gdb) p *pl->profile Cannot access memory at address 0x542c36343037303d ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1482

6 years, 8 months

git:master:0f6c984f: modules: readme files regenerated - acc ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 0f6c984feb31f316faaf89d4e83d172fc9c0fc4f URL: https://github.com/kamailio/kamailio/commit/0f6c984feb31f316faaf89d4e83d172… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2018-03-30T21:48:36+02:00 modules: readme files regenerated - acc ... [skip ci] --- Modified: src/modules/acc/README Modified: src/modules/app_perl/README Modified: src/modules/cdp/README Modified: src/modules/cdp_avp/README Modified: src/modules/db_text/README Modified: src/modules/dialog/README Modified: src/modules/dispatcher/README Modified: src/modules/ims_dialog/README Modified: src/modules/ims_registrar_scscf/README Modified: src/modules/ims_usrloc_pcscf/README Modified: src/modules/nathelper/README Modified: src/modules/pua_json/README Modified: src/modules/registrar/README Modified: src/modules/rtpengine/README Modified: src/modules/rtpproxy/README Modified: src/modules/snmpstats/README --- Diff: https://github.com/kamailio/kamailio/commit/0f6c984feb31f316faaf89d4e83d172… Patch: https://github.com/kamailio/kamailio/commit/0f6c984feb31f316faaf89d4e83d172…

6 years, 8 months

git:master:f167a0d1: module FAQs: fix help for private issues in module FAQs, alter docbook entitity

by Henning Westerholt

Module: kamailio Branch: master Commit: f167a0d107d8d266dcdf6ab3d3f649b1caae36e5 URL: https://github.com/kamailio/kamailio/commit/f167a0d107d8d266dcdf6ab3d3f649b… Author: Henning Westerholt <hw(a)kamailio.org> Committer: Henning Westerholt <hw(a)kamailio.org> Date: 2018-03-30T21:37:19+02:00 module FAQs: fix help for private issues in module FAQs, alter docbook entitity - fix wording for private issues in module FAQs - modules: acc, app_perl, cdp, cdp_avp, dialog, dispatcher, ims_dialog, ims_registrar, ims_usrloc, nathelper, registrar, rtpengine, rtpproxy, snmpstats - change docbook entity to a more sensible name "kamailioprivatemail" --- Modified: doc/docbook/entities.xml Modified: src/modules/acc/doc/acc_faq.xml Modified: src/modules/app_perl/doc/app_perl_faq.xml Modified: src/modules/cdp/doc/cdp_faq.xml Modified: src/modules/cdp_avp/doc/cdp_avp_faq.xml Modified: src/modules/dialog/doc/dialog_faq.xml Modified: src/modules/dispatcher/doc/dispatcher_faq.xml Modified: src/modules/ims_dialog/doc/ims_dialog_faq.xml Modified: src/modules/ims_registrar_scscf/doc/ims_registrar_scscf_faq.xml Modified: src/modules/ims_usrloc_pcscf/doc/ims_usrloc_pcscf_faq.xml Modified: src/modules/nathelper/doc/nathelper_faq.xml Modified: src/modules/registrar/doc/registrar_faq.xml Modified: src/modules/rtpengine/doc/rtpengine_faq.xml Modified: src/modules/rtpproxy/doc/rtpproxy_faq.xml Modified: src/modules/snmpstats/doc/snmpstats_faq.xml --- Diff: https://github.com/kamailio/kamailio/commit/f167a0d107d8d266dcdf6ab3d3f649b… Patch: https://github.com/kamailio/kamailio/commit/f167a0d107d8d266dcdf6ab3d3f649b…

6 years, 8 months

git:master:684f98ac: sqlops: proper function prototypes for kemi exports to get num rows and cols

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 684f98ace6ec50d5c52b8f6e14fe184079a6206f URL: https://github.com/kamailio/kamailio/commit/684f98ace6ec50d5c52b8f6e14fe184… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-03-30T17:23:29+02:00 sqlops: proper function prototypes for kemi exports to get num rows and cols --- Modified: src/modules/sqlops/sqlops.c --- Diff: https://github.com/kamailio/kamailio/commit/684f98ace6ec50d5c52b8f6e14fe184… Patch: https://github.com/kamailio/kamailio/commit/684f98ace6ec50d5c52b8f6e14fe184… --- diff --git a/src/modules/sqlops/sqlops.c b/src/modules/sqlops/sqlops.c index 502819e76a..dbad0c78c3 100644 --- a/src/modules/sqlops/sqlops.c +++ b/src/modules/sqlops/sqlops.c @@ -458,12 +458,12 @@ static int ki_sqlops_reset_result(sip_msg_t *msg, str *sres) return 1; } -static int ki_sqlops_num_rows(str *sres) +static int ki_sqlops_num_rows(sip_msg_t *msg, str *sres) { return sqlops_num_rows(sres); } -static int ki_sqlops_num_columns(str *sres) +static int ki_sqlops_num_columns(sip_msg_t *msg, str *sres) { return sqlops_num_columns(sres); } @@ -520,4 +520,4 @@ int mod_register(char *path, int *dlflags, void *p1, void *p2) { sr_kemi_modules_add(sr_kemi_sqlops_exports); return register_trans_mod(path, mod_trans); -} \ No newline at end of file +}

6 years, 8 months

git:master:1d1eeafc: dispatcher: fixed kemi exports param types

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 1d1eeafc88979df41e2dcb6f2c8b41d16695fd7d URL: https://github.com/kamailio/kamailio/commit/1d1eeafc88979df41e2dcb6f2c8b41d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-03-30T17:23:29+02:00 dispatcher: fixed kemi exports param types --- Modified: src/modules/dispatcher/dispatcher.c --- Diff: https://github.com/kamailio/kamailio/commit/1d1eeafc88979df41e2dcb6f2c8b41d… Patch: https://github.com/kamailio/kamailio/commit/1d1eeafc88979df41e2dcb6f2c8b41d… --- diff --git a/src/modules/dispatcher/dispatcher.c b/src/modules/dispatcher/dispatcher.c index 49b9396add..2c1e6fdbd0 100644 --- a/src/modules/dispatcher/dispatcher.c +++ b/src/modules/dispatcher/dispatcher.c @@ -1184,7 +1184,7 @@ static sr_kemi_t sr_kemi_dispatcher_exports[] = { }, { str_init("dispatcher"), str_init("ds_mark_dst_state"), SR_KEMIP_INT, ki_ds_mark_dst_state, - { SR_KEMIP_INT, SR_KEMIP_NONE, SR_KEMIP_NONE, + { SR_KEMIP_STR, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, { str_init("dispatcher"), str_init("ds_is_from_lists"), @@ -1224,7 +1224,7 @@ static sr_kemi_t sr_kemi_dispatcher_exports[] = { }, { str_init("dispatcher"), str_init("ds_list_exists"), SR_KEMIP_INT, ki_ds_list_exists, - { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, + { SR_KEMIP_INT, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } },

6 years, 8 months

git:master:cc661d77: app_lua: test if number of parameters is enough for kemi funtions

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: cc661d776621a5f2d4370eb364402c2a53242cc7 URL: https://github.com/kamailio/kamailio/commit/cc661d776621a5f2d4370eb364402c2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-03-30T17:23:29+02:00 app_lua: test if number of parameters is enough for kemi funtions --- Modified: src/modules/app_lua/app_lua_sr.c --- Diff: https://github.com/kamailio/kamailio/commit/cc661d776621a5f2d4370eb364402c2… Patch: https://github.com/kamailio/kamailio/commit/cc661d776621a5f2d4370eb364402c2… --- diff --git a/src/modules/app_lua/app_lua_sr.c b/src/modules/app_lua/app_lua_sr.c index 64ebafae40..72d2eb0ddf 100644 --- a/src/modules/app_lua/app_lua_sr.c +++ b/src/modules/app_lua/app_lua_sr.c @@ -1489,9 +1489,27 @@ int sr_kemi_lua_exec_func_ex(lua_State* L, sr_kemi_t *ket, int pdelta) for(i=0; i<SR_KEMI_PARAMS_MAX; i++) { if(ket->ptypes[i]==SR_KEMIP_NONE) { break; - } else if(ket->ptypes[i]==SR_KEMIP_STR) { + } + if(argc<i+pdelta+1) { + LM_ERR("not enough parameters for: %.*s.%.*s\n", + mname->len, mname->s, fname->len, fname->s); + return app_lua_return_false(L); + } + if(ket->ptypes[i]==SR_KEMIP_STR) { vps[i].s.s = (char*)lua_tostring(L, i+pdelta+1); - vps[i].s.len = strlen(vps[i].s.s); + if(vps[i].s.s!=NULL) { + if(lua_isstring(L, i+pdelta+1)) { +#if LUA_VERSION_NUM > 501 + vps[i].s.len = lua_rawlen(L, i+pdelta+1); +#else + vps[i].s.len = lua_strlen(L, i+pdelta+1); +#endif + } else { + vps[i].s.len = strlen(vps[i].s.s); + } + } else { + vps[i].s.len = 0; + } LM_DBG("param[%d] for: %.*s is str: %.*s\n", i, fname->len, fname->s, vps[i].s.len, vps[i].s.s); } else if(ket->ptypes[i]==SR_KEMIP_INT) {

6 years, 8 months

git:master:3c373fa7: carrierroute: doxygen fixes

by Henning Westerholt

Module: kamailio Branch: master Commit: 3c373fa7d9973197fcd367f11c61ed380d6eeb75 URL: https://github.com/kamailio/kamailio/commit/3c373fa7d9973197fcd367f11c61ed3… Author: Henning Westerholt <hw(a)kamailio.org> Committer: Henning Westerholt <hw(a)kamailio.org> Date: 2018-03-30T00:21:20+02:00 carrierroute: doxygen fixes --- Modified: src/modules/carrierroute/parser_carrierroute.c --- Diff: https://github.com/kamailio/kamailio/commit/3c373fa7d9973197fcd367f11c61ed3… Patch: https://github.com/kamailio/kamailio/commit/3c373fa7d9973197fcd367f11c61ed3… --- diff --git a/src/modules/carrierroute/parser_carrierroute.c b/src/modules/carrierroute/parser_carrierroute.c index 8aac5f501d..82f967db96 100644 --- a/src/modules/carrierroute/parser_carrierroute.c +++ b/src/modules/carrierroute/parser_carrierroute.c @@ -287,10 +287,10 @@ int parse_options(FILE* file, option_description* opts, int no_options, char* en /** * Searches for next content line in the src file * - * @param data the destination trimmed non blank line + * @param line the destination trimmed non blank line * @param size maximum accepted line length * @param file source file - * @param p_full_len initial lenght of contents line + * @param pFull_len initial lenght of contents line * * @return 0 on success, -1 on error, 1 on EOF */

6 years, 8 months

git:master:b0b9c16c: tsilo: doxygen fixes

by Henning Westerholt

Module: kamailio Branch: master Commit: b0b9c16cdc4deefb2ace276ce126c2cb3aa03129 URL: https://github.com/kamailio/kamailio/commit/b0b9c16cdc4deefb2ace276ce126c2c… Author: Henning Westerholt <hw(a)kamailio.org> Committer: Henning Westerholt <hw(a)kamailio.org> Date: 2018-03-30T00:01:34+02:00 tsilo: doxygen fixes --- Modified: src/modules/tsilo/ts_handlers.c Modified: src/modules/tsilo/ts_handlers.h Modified: src/modules/tsilo/ts_hash.c Modified: src/modules/tsilo/ts_hash.h --- Diff: https://github.com/kamailio/kamailio/commit/b0b9c16cdc4deefb2ace276ce126c2c… Patch: https://github.com/kamailio/kamailio/commit/b0b9c16cdc4deefb2ace276ce126c2c…

6 years, 8 months

← Newer
1
...
5
6
7
8
9
10
11
...
33
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2018