sr-dev March 2018

sr-dev@lists.kamailio.org

17 participants
326 discussions

[kamailio/kamailio] textops: Fixed remove_hf_exp arguments params (#1485)

by sergey-safarov

Current remove_hf_exp not works as expected. This fix it. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1485 -- Commit Summary -- * textops: Fixed remove_hf_exp arguments params -- File Changes -- M src/modules/textops/textops.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1485.patch https://github.com/kamailio/kamailio/pull/1485.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1485

6 years, 9 months

git:master:f3cfb491: textops: Fixed remove_hf_exp arguments params (#1485)

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: f3cfb4910ae0fd197757d2ec2362b9715205e21e URL: https://github.com/kamailio/kamailio/commit/f3cfb4910ae0fd197757d2ec2362b97… Author: sergey-safarov <s.safarov(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-03-20T19:20:11+01:00 textops: Fixed remove_hf_exp arguments params (#1485) --- Modified: src/modules/textops/textops.c --- Diff: https://github.com/kamailio/kamailio/commit/f3cfb4910ae0fd197757d2ec2362b97… Patch: https://github.com/kamailio/kamailio/commit/f3cfb4910ae0fd197757d2ec2362b97… --- diff --git a/src/modules/textops/textops.c b/src/modules/textops/textops.c index f18c450efc..6fb723166b 100644 --- a/src/modules/textops/textops.c +++ b/src/modules/textops/textops.c @@ -212,7 +212,7 @@ static cmd_export_t cmds[]={ {"remove_hf_re", (cmd_function)remove_hf_re_f, 1, fixup_regexp_null, fixup_free_regexp_null, ANY_ROUTE}, - {"remove_hf_exp", (cmd_function)remove_hf_exp_f, 1, + {"remove_hf_exp", (cmd_function)remove_hf_exp_f, 2, fixup_regexp_regexp, fixup_free_regexp_regexp, ANY_ROUTE}, {"is_present_hf", (cmd_function)is_present_hf_f, 1,

6 years, 9 months

[kamailio/kamailio] topos: WARNING: topos [tps_storage.c:385]: tps_storage_record(): no local address - do record routing for all initial requests (#1483)

by Sergey Lavrov

### Description  I have just updated kamailio to 5.1.2 and have bunch of messages on OPTIONS request without Contact header because of commit ce9f67581f45a00fd879329ffc918b2a7ef9b8d0: WARNING: topos [tps_storage.c:385]: tps_storage_record(): no local address - do record routing for all initial requests In [RFC 3261](https://www.ietf.org/rfc/rfc3261.txt) in 11.1 section is stated that Contact header is optional not mandatory. So maybe a workaround will be suppress such messages for OPTIONS and other SIP requests without mandatory Contact header or move it to DEBUG from WARNING? ### Troubleshooting #### Reproduction  #### Log Messages  ``` Mar 15 04:17:31 kamailio-0-0 /usr/sbin/kamailio[1078]: WARNING: topos [tps_storage.c:385]: tps_storage_record(): no local address - do record routing for all initial requests Mar 15 04:17:31 kamailio-0-0 /usr/sbin/kamailio[1078]: WARNING: topos [tps_storage.c:385]: tps_storage_record(): no local address - do record routing for all initial requests Mar 15 04:17:31 kamailio-0-0 /usr/sbin/kamailio[1078]: WARNING: topos [tps_storage.c:385]: tps_storage_record(): no local address - do record routing for all initial requests Mar 15 04:17:31 kamailio-0-0 /usr/sbin/kamailio[1078]: WARNING: topos [tps_storage.c:385]: tps_storage_record(): no local address - do record routing for all initial requests Mar 15 04:17:31 kamailio-0-0 /usr/sbin/kamailio[1078]: WARNING: topos [tps_storage.c:385]: tps_storage_record(): no local address - do record routing for all initial requests Mar 15 04:17:31 kamailio-0-0 /usr/sbin/kamailio[1078]: WARNING: topos [tps_storage.c:385]: tps_storage_record(): no local address - do record routing for all initial requests ``` #### SIP Traffic  ``` 2018/03/15 04:17:31.833335 x.x.x.x:5060 -> y.y.y.y:5060 OPTIONS sip:y.y.y.y:5060;user=phone SIP/2.0 Via: SIP/2.0/UDP x.x.x.x:5060;branch=z9hG4bKehyhoockece8okibyb7ej8vvj Call-ID: ixheb7uuunjeulhocj8n8oiheynvojnl@SE2000 From: <sip:SBC@x.x.x.x;user=phone>;tag=ucljxn87 To: <sip:y.y.y.y;user=phone> CSeq: 1 OPTIONS Max-Forwards: 70 Content-Length: 0 2018/03/15 04:17:31.833740 y.y.y.y:5060 -> x.x.x.x:5060 SIP/2.0 200 OK Via: SIP/2.0/UDP x.x.x.x:5060;branch=z9hG4bKehyhoockece8okibyb7ej8vvj Call-ID: ixheb7uuunjeulhocj8n8oiheynvojnl@SE2000 From: <sip:SBC@x.x.x.x;user=phone>;tag=ucljxn87 To: <sip:y.y.y.y;user=phone>;tag=3403be34b817f61be8d0522eb11c0e7a.58f4 CSeq: 1 OPTIONS Content-Length: 0 ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.1.2 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled on 05:07:55 Mar 15 2018 with gcc 4.8.5 ``` * **Operating System**:  ``` Red Hat Enterprise Linux Server release 7.4 (Maipo) Linux kamailio-0-0 2.6.32-042stab113.21 #1 SMP Wed Mar 23 11:05:25 MSK 2016 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1483

6 years, 9 months

git:master:3ada0852: core: flags - moved xflags functions out of disabled ifdef zone

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 3ada08521de545f76e7d85d6fdf900c576c67664 URL: https://github.com/kamailio/kamailio/commit/3ada08521de545f76e7d85d6fdf900c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-03-20T17:28:32+01:00 core: flags - moved xflags functions out of disabled ifdef zone --- Modified: src/core/flags.c --- Diff: https://github.com/kamailio/kamailio/commit/3ada08521de545f76e7d85d6fdf900c… Patch: https://github.com/kamailio/kamailio/commit/3ada08521de545f76e7d85d6fdf900c… --- diff --git a/src/core/flags.c b/src/core/flags.c index 043824895f..45839d90cd 100644 --- a/src/core/flags.c +++ b/src/core/flags.c @@ -27,6 +27,7 @@ #include <limits.h> +#include <stdint.h> #include "sr_module.h" #include "dprint.h" #include "parser/msg_parser.h" @@ -317,6 +318,8 @@ static int fixup_t_flag(void** param, int param_no) return E_CFG; } +#endif + /** * */ @@ -354,5 +357,3 @@ int isxflagset(struct sip_msg* msg, flag_t flag) fb = flag % (sizeof(flag_t)*CHAR_BIT); return (msg->xflags[fi] & (1<<fb)) ? 1 : -1; } - -#endif

6 years, 9 months

git:master:a3d9816d: core: check for result of dlopen() pointers

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: a3d9816d3881eb9743a14cb1306533469a821d47 URL: https://github.com/kamailio/kamailio/commit/a3d9816d3881eb9743a14cb13065334… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-03-20T16:48:26+01:00 core: check for result of dlopen() pointers --- Modified: src/core/sr_module.c --- Diff: https://github.com/kamailio/kamailio/commit/a3d9816d3881eb9743a14cb13065334… Patch: https://github.com/kamailio/kamailio/commit/a3d9816d3881eb9743a14cb13065334… --- diff --git a/src/core/sr_module.c b/src/core/sr_module.c index f04d486908..62fc81f21b 100644 --- a/src/core/sr_module.c +++ b/src/core/sr_module.c @@ -594,7 +594,7 @@ int load_module(char* mod_path) exit(-1); } mod_if_ver = (unsigned *)dlsym(handle, "module_interface_ver"); - if ( (error =(char*)dlerror())!=0 ){ + if (mod_if_ver==NULL || (error =(char*)dlerror())!=0 ){ LM_ERR("no module interface version in module <%s>\n", path ); goto error1; } @@ -635,12 +635,10 @@ int load_module(char* mod_path) snprintf(exbuf, 62, "_%.*s_exports", expref.len, expref.s); LM_DBG("looking up exports with name: %s\n", exbuf); exp = (union module_exports_u*)dlsym(handle, exbuf); - if(exp==NULL) { - if ( (error =(char*)dlerror())!=0 ){ - LM_ERR("failure for exports symbol: %s - dlerror: %s\n", - exbuf, error); - goto error1; - } + if(exp==NULL || (error =(char*)dlerror())!=0 ){ + LM_ERR("failure for exports symbol: %s - dlerror: %s\n", + exbuf, (error)?error:"none"); + goto error1; } } /* hack to allow for kamailio style dlflags inside exports */

6 years, 9 months

Security announcement related to Kamailio

by Henning Westerholt

Hello, as already announced from Daniel-Constantin Mierla on the lists last Wednesday [1], we strongly advise you to update your Kamailio installation to the latest stable release for security reasons. All supported releases (4.4, 5.0. and 5.1) contains two important security fixes related to the tmx and lcr module. Technical details for the tmx issue: A specially crafted REGISTER message with a malformed branch or From tag triggers a so called "off-by-one heap overflow". This vulnerability existed in the tmx module and makes it possible to remotely crash the Kamailio service. If an attacker sends many of this messages this would lead to a Denial of Service of the attacked infrastructure. This is especially critical as no authentication for the remote source is needed. This vulnerability was found from Sandro Gauci and Alfred Farrugia from the Security Company Enable Security. Many thanks to them for finding the issue and reporting it to us. You find all the details including a proof of concept code in the published security announcement from them: https://github.com/EnableSecurity/advisories/tree/master/ES2018-05-kamailio… Technical details for the lcr issue: A vulnerability existed in the lcr next_gw() function. It happens when a very long R-URI username is sent with an INVITE due to an mistake in the function error code handling. It can be triggered from a remote source, but should be only from a trusted peer, as it expected that calls going through lcr are authenticated by user or IP address. This vulnerability was reported from an user in the Netherlands to us, thanks as well for the bug report. So far we are not aware of any public exploits of this errors. But as already mentioned, we advise you to update your Kamailio servers to the latest stable release as soon as possible, especially as the tmx vulnerability will reported to more security lists later today. Please address any detailed technical questions related to the two bugs to the developer list at sr-dev(a)lists.kamailio.org . In case of confidential remarks related to this or other security issues, please address them to the Kamailio Management at management(a)kamailio.org . Best regards, Henning Westerholt Kamailio Project [1] https://lists.kamailio.org/pipermail/sr-users/2018-March/100672.html

6 years, 9 months

git:master:77beeb5d: core: new parameter kemi.event_route_callback

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 77beeb5d765119f46589a9d519123256fb8a9138 URL: https://github.com/kamailio/kamailio/commit/77beeb5d765119f46589a9d51912325… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-03-19T18:17:31+01:00 core: new parameter kemi.event_route_callback - set the name of kemi function to be executed for core event route equivalet - default value is not set (no callback function name). If set to "none", it is also not executed. - callback function receives a string parameter with the name of the event - execute kemi event callback for "core:worker-one-init" --- Modified: src/core/action.c Modified: src/core/cfg.lex Modified: src/core/cfg.y Modified: src/core/kemi.c Modified: src/core/kemi.h --- Diff: https://github.com/kamailio/kamailio/commit/77beeb5d765119f46589a9d51912325… Patch: https://github.com/kamailio/kamailio/commit/77beeb5d765119f46589a9d51912325…

6 years, 9 months

git:master:22bd6ca0: db_redis: Fix various pointer and memory issues

by Andreas Granig

Module: kamailio Branch: master Commit: 22bd6ca04dd20951a20aca77ec9a8cb46cdf73f9 URL: https://github.com/kamailio/kamailio/commit/22bd6ca04dd20951a20aca77ec9a8cb… Author: Andreas Granig <agranig(a)sipwise.com> Committer: Andreas Granig <agranig(a)sipwise.com> Date: 2018-03-19T17:42:39+01:00 db_redis: Fix various pointer and memory issues Issues discovered by coverity: * Fix mem leaks in error handling * Fix potential null pointer deref * Fix potential out-of-memory cases --- Modified: src/modules/db_redis/redis_connection.c Modified: src/modules/db_redis/redis_dbase.c Modified: src/modules/db_redis/redis_table.c --- Diff: https://github.com/kamailio/kamailio/commit/22bd6ca04dd20951a20aca77ec9a8cb… Patch: https://github.com/kamailio/kamailio/commit/22bd6ca04dd20951a20aca77ec9a8cb…

6 years, 9 months

git:master:eda57ef9: modules: readme files regenerated - p_usrloc ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: eda57ef94bf79605d7b15fe50379913bf76f4fa5 URL: https://github.com/kamailio/kamailio/commit/eda57ef94bf79605d7b15fe50379913… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2018-03-18T11:17:06+01:00 modules: readme files regenerated - p_usrloc ... [skip ci] --- Modified: src/modules/p_usrloc/README Modified: src/modules/speeddial/README Modified: src/modules/uri_db/README --- Diff: https://github.com/kamailio/kamailio/commit/eda57ef94bf79605d7b15fe50379913… Patch: https://github.com/kamailio/kamailio/commit/eda57ef94bf79605d7b15fe50379913… --- diff --git a/src/modules/p_usrloc/README b/src/modules/p_usrloc/README index 5effbeab55..9256c22c57 100644 --- a/src/modules/p_usrloc/README +++ b/src/modules/p_usrloc/README @@ -687,8 +687,8 @@ modparam("p_usrloc", "db_mode", 2) databases. For that, if the table was not created by the installation script or you choose to install everything by yourself you can use the p_usrloc-create.sql SQL script in the database directories in the - openser/scripts folder as template. Database and table name can be set - with module parameters so they can be changed, but the name of the + utils/kamctl/mysql/ folder as template. Database and table name can be + set with module parameters so they can be changed, but the name of the columns must be as they are in the SQL script. You can also find the complete database documentation on the project webpage, https://www.kamailio.org/docs/db-tables/kamailio-db-devel.html. diff --git a/src/modules/speeddial/README b/src/modules/speeddial/README index 1711d7d968..be0efe4db5 100644 --- a/src/modules/speeddial/README +++ b/src/modules/speeddial/README @@ -126,7 +126,7 @@ Chapter 1. Admin Guide Example 1.1. Set db_url parameter ... -modparam("speeddial", "db_url", "mysql://openser:xxx@localhost/openser") +modparam("speeddial", "db_url", "mysql://kamailio:xxx@localhost/kamailio") ... 3.2. user_column (string) @@ -231,7 +231,7 @@ modparam("speeddial", "use_domain", 1) Example 1.9. sd_lookup usage ... -# 'speed_dial' is the default table name created by openser db script +# 'speed_dial' is the default table name created by kamailio db script if(uri=~"sip:[0-9]{2}@.*") sd_lookup("speed_dial"); # use auth username diff --git a/src/modules/uri_db/README b/src/modules/uri_db/README index b11772e641..589fba5b0a 100644 --- a/src/modules/uri_db/README +++ b/src/modules/uri_db/README @@ -125,7 +125,7 @@ Chapter 1. Admin Guide Example 1.1. Set db_url parameter ... -modparam("uri_db", "db_url", "mysql://username:password@localhost/openser") +modparam("uri_db", "db_url", "mysql://username:password@localhost/kamailio") ... 3.2. db_table (string)

6 years, 9 months

git:master:ae1367bf: uri_db: updated database name in docs

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: ae1367bf3a6706b9db742ff6e20e6d11f79d5b02 URL: https://github.com/kamailio/kamailio/commit/ae1367bf3a6706b9db742ff6e20e6d1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-03-18T11:04:55+01:00 uri_db: updated database name in docs --- Modified: src/modules/uri_db/doc/uri_db_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/ae1367bf3a6706b9db742ff6e20e6d1… Patch: https://github.com/kamailio/kamailio/commit/ae1367bf3a6706b9db742ff6e20e6d1… --- diff --git a/src/modules/uri_db/doc/uri_db_admin.xml b/src/modules/uri_db/doc/uri_db_admin.xml index bc7f08cbea..157f43ebf7 100644 --- a/src/modules/uri_db/doc/uri_db_admin.xml +++ b/src/modules/uri_db/doc/uri_db_admin.xml @@ -68,7 +68,7 @@ <title>Set <varname>db_url</varname> parameter</title> <programlisting format="linespecific"> ... -modparam("uri_db", "db_url", "mysql://username:password@localhost/openser") +modparam("uri_db", "db_url", "mysql://username:password@localhost/kamailio") ... </programlisting> </example>

6 years, 9 months

← Newer
1
...
10
11
12
13
14
15
16
...
33
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2018