sr-dev February 2018

sr-dev@lists.kamailio.org

33 participants
355 discussions

[kamailio/kamailio] textops: Support RFC3264 for is_audio_on_hold() function (#1292)

by JuliaBoud

Function "is_audio_on_hold()" has support for rfc2543 only, where "hold" is indicated by setting the "c" destination addresses for the media streams to zero (0.0.0.0). Could you please add support for rfc3264 for this function, where "hold" is indicated by a=sendonly/inactive. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1292

6 years, 10 months

git:master:536c5c36: modules: readme files regenerated - textops ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 536c5c36a2ef56daf0d2e9adcc02594ae95a6cc6 URL: https://github.com/kamailio/kamailio/commit/536c5c36a2ef56daf0d2e9adcc02594… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2018-02-02T20:31:38+01:00 modules: readme files regenerated - textops ... [skip ci] --- Modified: src/modules/textops/README --- Diff: https://github.com/kamailio/kamailio/commit/536c5c36a2ef56daf0d2e9adcc02594… Patch: https://github.com/kamailio/kamailio/commit/536c5c36a2ef56daf0d2e9adcc02594… --- diff --git a/src/modules/textops/README b/src/modules/textops/README index 00875a04b0..775236a016 100644 --- a/src/modules/textops/README +++ b/src/modules/textops/README @@ -910,9 +910,10 @@ if(has_body("application/sdp")) 4.32. is_audio_on_hold() The function returns true if the SIP message has a body attached and at - least one audio stream in on hold. Only RFC2543 is supported - (c=0.0.0.0). Hold detection based on RFC3264 is not supported - (a=sendonly/inactive). + least one audio stream in on hold. The return code of the function + indicates the detected hold type: + * 1 - RFC2543 hold type: null connection IP detected + * 2 - RFC3264 hold type: inactive or sendonly attributes detected This function can be used from REQUEST_ROUTE, ONREPLY_ROUTE, FAILURE_ROUTE and BRANCH_ROUTE. @@ -921,7 +922,15 @@ if(has_body("application/sdp")) ... if(is_audio_on_hold()) { - # do interesting stuff here + switch ($rc) { + case 1: + # RFC2543 hold type + # do interesting stuff here + break; + case 2: + # RFC3264 hold type + # do interesting stuff here + break; } ...

6 years, 10 months

git:master:fad36ca8: textops: documentation updated for is_audio_on_hold()

by Ovidiu Sas

Module: kamailio Branch: master Commit: fad36ca8bc3526f71f8bb3af46afe3bb2a0f1789 URL: https://github.com/kamailio/kamailio/commit/fad36ca8bc3526f71f8bb3af46afe3b… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: 2018-02-02T14:30:53-05:00 textops: documentation updated for is_audio_on_hold() --- Modified: src/modules/textops/doc/textops_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/fad36ca8bc3526f71f8bb3af46afe3b… Patch: https://github.com/kamailio/kamailio/commit/fad36ca8bc3526f71f8bb3af46afe3b… --- diff --git a/src/modules/textops/doc/textops_admin.xml b/src/modules/textops/doc/textops_admin.xml index 4cb99d708e..d5884bfd20 100644 --- a/src/modules/textops/doc/textops_admin.xml +++ b/src/modules/textops/doc/textops_admin.xml @@ -1258,6 +1258,19 @@ if(has_body("application/sdp")) <para> The function returns <emphasis>true</emphasis> if the SIP message has a body attached and at least one audio stream in on hold. + The return code of the function indicates the detected hold type: + <itemizedlist> + <listitem> + <para><emphasis>1</emphasis> - RFC2543 hold type: + null connection IP detected + </para> + </listitem> + <listitem> + <para><emphasis>2</emphasis> - RFC3264 hold type: + inactive or sendonly attributes detected + </para> + </listitem> + </itemizedlist> </para> <para> This function can be used from REQUEST_ROUTE, ONREPLY_ROUTE, @@ -1269,7 +1282,15 @@ if(has_body("application/sdp")) ... if(is_audio_on_hold()) { - # do interesting stuff here + switch ($rc) { + case 1: + # RFC2543 hold type + # do interesting stuff here + break; + case 2: + # RFC3264 hold type + # do interesting stuff here + break; } ... </programlisting>

6 years, 10 months

git:master:9f735ef8: textops: is_audio_on_hold() returns hold type

by Ovidiu Sas

Module: kamailio Branch: master Commit: 9f735ef803bfc8b6722f71a2bef00b071ab1ca1b URL: https://github.com/kamailio/kamailio/commit/9f735ef803bfc8b6722f71a2bef00b0… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: 2018-02-02T14:25:20-05:00 textops: is_audio_on_hold() returns hold type 1 - RFC2543 hold type (the connection IP is set to null IP) 2 - RFC3264 hold type (inactive or sendonly attr) --- Modified: src/modules/textops/textops.c --- Diff: https://github.com/kamailio/kamailio/commit/9f735ef803bfc8b6722f71a2bef00b0… Patch: https://github.com/kamailio/kamailio/commit/9f735ef803bfc8b6722f71a2bef00b0… --- diff --git a/src/modules/textops/textops.c b/src/modules/textops/textops.c index 97f1ecff12..7dbd07b03c 100644 --- a/src/modules/textops/textops.c +++ b/src/modules/textops/textops.c @@ -3368,7 +3368,7 @@ static int ki_is_audio_on_hold(sip_msg_t *msg) if(sdp_stream->media.len==AUDIO_STR_LEN && strncmp(sdp_stream->media.s,AUDIO_STR,AUDIO_STR_LEN)==0 && sdp_stream->is_on_hold) - return 1; + return sdp_stream->is_on_hold; sdp_stream_num++; } sdp_session_num++;

6 years, 10 months

git:master:51be5b7a: parser/sdp: distinguish between RFC2543 and RFC3264 media hold type

by Ovidiu Sas

Module: kamailio Branch: master Commit: 51be5b7a889e394927cce1009a09e1c2f52123ca URL: https://github.com/kamailio/kamailio/commit/51be5b7a889e394927cce1009a09e1c… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: 2018-02-02T14:23:08-05:00 parser/sdp: distinguish between RFC2543 and RFC3264 media hold type --- Modified: src/core/parser/sdp/sdp.c Modified: src/core/parser/sdp/sdp.h Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/51be5b7a889e394927cce1009a09e1c… Patch: https://github.com/kamailio/kamailio/commit/51be5b7a889e394927cce1009a09e1c… --- diff --git a/src/core/parser/sdp/sdp.c b/src/core/parser/sdp/sdp.c index e6708d8188..32db4f1949 100644 --- a/src/core/parser/sdp/sdp.c +++ b/src/core/parser/sdp/sdp.c @@ -584,11 +584,11 @@ static int parse_sdp_session(str *sdp_body, int session_num, str *cnt_disp, sdp_ if (stream->ip_addr.s && stream->ip_addr.len) { if (stream->ip_addr.len == HOLD_IP_LEN && strncmp(stream->ip_addr.s, HOLD_IP_STR, HOLD_IP_LEN)==0) - stream->is_on_hold = 1; + stream->is_on_hold = RFC2543_HOLD; } else if (session->ip_addr.s && session->ip_addr.len) { if (session->ip_addr.len == HOLD_IP_LEN && strncmp(session->ip_addr.s, HOLD_IP_STR, HOLD_IP_LEN)==0) - stream->is_on_hold = 1; + stream->is_on_hold = RFC2543_HOLD; } } ++stream_num; diff --git a/src/core/parser/sdp/sdp.h b/src/core/parser/sdp/sdp.h index 6b24030485..ab32d93d86 100644 --- a/src/core/parser/sdp/sdp.h +++ b/src/core/parser/sdp/sdp.h @@ -32,6 +32,10 @@ #include "../msg_parser.h" +#define NO_HOLD 0 +#define RFC2543_HOLD 1 +#define RFC3264_HOLD 2 + typedef struct sdp_payload_attr { struct sdp_payload_attr *next; int payload_num; /**< payload index inside stream */ diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index 52fe655612..5657cea4a1 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -386,7 +386,7 @@ int extract_sendrecv_mode(str *body, str *sendrecv_mode, int *is_on_hold) (strncasecmp(cp1, "a=recvonly", 10) == 0))) { if ((strncasecmp(cp1, "a=inactive", 10) == 0) || (strncasecmp(cp1, "a=sendonly", 10) == 0) ) { - *is_on_hold = 1; + *is_on_hold = RFC3264_HOLD; } else { return -1; }

6 years, 10 months

[kamailio/kamailio] Feature/help android fcm and ios related push notification module (#1425)

by Dipen Patel

Hello.. Now most sip soft client in required push wakeup phone. So for that required android, ios push notifications module. I have seen some one have developed some module but it is old. So if possible so please write push notifications for wakeup phone module. Thanks -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1425

6 years, 10 months

git:5.1:45233bf5: textops: update documentation for is_audio_on_hold()

by Ovidiu Sas

Module: kamailio Branch: 5.1 Commit: 45233bf5d736b7f47390d150d41511702212183b URL: https://github.com/kamailio/kamailio/commit/45233bf5d736b7f47390d150d415117… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: 2018-02-02T14:11:41-05:00 textops: update documentation for is_audio_on_hold() (cherry picked from commit def7be2a3a60039c21c0711153152533b8ceb836) --- Modified: src/modules/textops/doc/textops_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/45233bf5d736b7f47390d150d415117… Patch: https://github.com/kamailio/kamailio/commit/45233bf5d736b7f47390d150d415117… --- diff --git a/src/modules/textops/doc/textops_admin.xml b/src/modules/textops/doc/textops_admin.xml index f94183dabf..4cb99d708e 100644 --- a/src/modules/textops/doc/textops_admin.xml +++ b/src/modules/textops/doc/textops_admin.xml @@ -1258,8 +1258,6 @@ if(has_body("application/sdp")) <para> The function returns <emphasis>true</emphasis> if the SIP message has a body attached and at least one audio stream in on hold. - Only RFC2543 is supported (c=0.0.0.0). - Hold detection based on RFC3264 is not supported (a=sendonly/inactive). </para> <para> This function can be used from REQUEST_ROUTE, ONREPLY_ROUTE,

6 years, 10 months

git:master:def7be2a: textops: update documentation for is_audio_on_hold()

by Ovidiu Sas

Module: kamailio Branch: master Commit: def7be2a3a60039c21c0711153152533b8ceb836 URL: https://github.com/kamailio/kamailio/commit/def7be2a3a60039c21c071115315253… Author: Ovidiu Sas <osas(a)voipembedded.com> Committer: Ovidiu Sas <osas(a)voipembedded.com> Date: 2018-02-02T14:08:41-05:00 textops: update documentation for is_audio_on_hold() --- Modified: src/modules/textops/doc/textops_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/def7be2a3a60039c21c071115315253… Patch: https://github.com/kamailio/kamailio/commit/def7be2a3a60039c21c071115315253… --- diff --git a/src/modules/textops/doc/textops_admin.xml b/src/modules/textops/doc/textops_admin.xml index f94183dabf..4cb99d708e 100644 --- a/src/modules/textops/doc/textops_admin.xml +++ b/src/modules/textops/doc/textops_admin.xml @@ -1258,8 +1258,6 @@ if(has_body("application/sdp")) <para> The function returns <emphasis>true</emphasis> if the SIP message has a body attached and at least one audio stream in on hold. - Only RFC2543 is supported (c=0.0.0.0). - Hold detection based on RFC3264 is not supported (a=sendonly/inactive). </para> <para> This function can be used from REQUEST_ROUTE, ONREPLY_ROUTE,

6 years, 10 months

git:master:8233e519: app_squirrel: imported last version of squirrel interpreter

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 8233e5191d23f64d879d81aa4bc4e5b17cf68ffe URL: https://github.com/kamailio/kamailio/commit/8233e5191d23f64d879d81aa4bc4e5b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-02-02T18:11:10+01:00 app_squirrel: imported last version of squirrel interpreter - master branch --- Modified: src/modules/app_sqlang/squirrel/include/squirrel.h Modified: src/modules/app_sqlang/squirrel/sqstdlib/sqstdblob.cpp Modified: src/modules/app_sqlang/squirrel/sqstdlib/sqstdblobimpl.h Modified: src/modules/app_sqlang/squirrel/squirrel/sqapi.cpp Modified: src/modules/app_sqlang/squirrel/squirrel/sqbaselib.cpp Modified: src/modules/app_sqlang/squirrel/squirrel/sqcompiler.cpp Modified: src/modules/app_sqlang/squirrel/squirrel/sqfuncstate.cpp Modified: src/modules/app_sqlang/squirrel/squirrel/sqlexer.cpp Modified: src/modules/app_sqlang/squirrel/squirrel/sqvm.cpp Modified: src/modules/app_sqlang/squirrel/squirrel/sqvm.h --- Diff: https://github.com/kamailio/kamailio/commit/8233e5191d23f64d879d81aa4bc4e5b… Patch: https://github.com/kamailio/kamailio/commit/8233e5191d23f64d879d81aa4bc4e5b…

6 years, 10 months

git:master:7612f670: misc/examples/kemi: convert port to string in log messages

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 7612f67001c57d6adf339cd318e48ad828123213 URL: https://github.com/kamailio/kamailio/commit/7612f67001c57d6adf339cd318e48ad… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-02-01T15:06:51+01:00 misc/examples/kemi: convert port to string in log messages --- Modified: misc/examples/kemi/kamailio-basic-kemi-python.py --- Diff: https://github.com/kamailio/kamailio/commit/7612f67001c57d6adf339cd318e48ad… Patch: https://github.com/kamailio/kamailio/commit/7612f67001c57d6adf339cd318e48ad… --- diff --git a/misc/examples/kemi/kamailio-basic-kemi-python.py b/misc/examples/kemi/kamailio-basic-kemi-python.py index f692280959..7d952e413e 100644 --- a/misc/examples/kemi/kamailio-basic-kemi-python.py +++ b/misc/examples/kemi/kamailio-basic-kemi-python.py @@ -146,13 +146,13 @@ def ksr_route_reqinit(self, msg): # ip is already blocked KSR.dbg("request from blocked IP - " + KSR.pv.get("$rm") + " from " + KSR.pv.get("$fu") + " (IP:" - + KSR.pv.get("$si") + ":" + KSR.pv.get("$sp") + ")\n"); + + KSR.pv.get("$si") + ":" + str(KSR.pv.get("$sp")) + ")\n"); return -255; if KSR.pike.pike_check_req()<0 : KSR.err("ALERT: pike blocking " + KSR.pv.get("$rm") + " from " + KSR.pv.get("$fu") + " (IP:" - + KSR.pv.get("$si") + ":" + KSR.pv.get("$sp") + ")\n"); + + KSR.pv.get("$si") + ":" + str(KSR.pv.get("$sp")) + ")\n"); KSR.pv.seti("$sht(ipban=>$si)", 1); return -255; @@ -174,7 +174,7 @@ def ksr_route_reqinit(self, msg): if KSR.sanity.sanity_check(1511, 7)<0 : KSR.err("Malformed SIP message from " - + KSR.pv.get("$si") + ":" + KSR.pv.get("$sp") +"\n"); + + KSR.pv.get("$si") + ":" + str(KSR.pv.get("$sp")) +"\n"); return -255;

6 years, 10 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2018