sr-dev February 2018

sr-dev@lists.kamailio.org

33 participants
355 discussions

git:master:54afa459: ndb_redis: keep reference to server spec string
by Daniel-Constantin Mierla 13 Feb '18

13 Feb '18

Module: kamailio Branch: master Commit: 54afa4599e2e9384e2fba5b3e9ab47dc0b344421 URL: https://github.com/kamailio/kamailio/commit/54afa4599e2e9384e2fba5b3e9ab47d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-02-13T09:19:13+01:00 ndb_redis: keep reference to server spec string - avoid losing the pointer for dynamic discovery which can be interpreted as memory leak - free the new server spec if adding it fails - code reformatted for check_cluster_reply() --- Modified: src/modules/ndb_redis/redis_client.c Modified: src/modules/ndb_redis/redis_client.h --- Diff: https://github.com/kamailio/kamailio/commit/54afa4599e2e9384e2fba5b3e9ab47d… Patch: https://github.com/kamailio/kamailio/commit/54afa4599e2e9384e2fba5b3e9ab47d…

1 0

git:master:7725dc86: modules: readme files regenerated - ndb_redis ... [skip ci]
by Kamailio Dev 13 Feb '18

13 Feb '18

Module: kamailio Branch: master Commit: 7725dc8673bde0a35e820ed334e4e5f378455ac4 URL: https://github.com/kamailio/kamailio/commit/7725dc8673bde0a35e820ed334e4e5f… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2018-02-13T09:01:32+01:00 modules: readme files regenerated - ndb_redis ... [skip ci] --- Modified: src/modules/ndb_redis/README --- Diff: https://github.com/kamailio/kamailio/commit/7725dc8673bde0a35e820ed334e4e5f… Patch: https://github.com/kamailio/kamailio/commit/7725dc8673bde0a35e820ed334e4e5f… --- diff --git a/src/modules/ndb_redis/README b/src/modules/ndb_redis/README index c51fe48c3b..dd04331adc 100644 --- a/src/modules/ndb_redis/README +++ b/src/modules/ndb_redis/README @@ -49,6 +49,7 @@ Carsten Bock 3.6. allowed_timeouts (integer) 3.7. disable_time (integer) 3.8. flush_on_reconnect (integer) + 3.9. allow_dynamic_nodes (integer) 4. Functions @@ -67,9 +68,10 @@ Carsten Bock 1.6. Set allowed_timeots parameter 1.7. Set disable_time parameter 1.8. Set flush_on_reconnect parameter - 1.9. redis_cmd usage - 1.10. redis_execute usage - 1.11. redis_free usage + 1.9. Set allow_dynamic_nodes parameter + 1.10. redis_cmd usage + 1.11. redis_execute usage + 1.12. redis_free usage Chapter 1. Admin Guide @@ -91,6 +93,7 @@ Chapter 1. Admin Guide 3.6. allowed_timeouts (integer) 3.7. disable_time (integer) 3.8. flush_on_reconnect (integer) + 3.9. allow_dynamic_nodes (integer) 4. Functions @@ -134,6 +137,7 @@ Chapter 1. Admin Guide 3.6. allowed_timeouts (integer) 3.7. disable_time (integer) 3.8. flush_on_reconnect (integer) + 3.9. allow_dynamic_nodes (integer) 3.1. server (str) @@ -284,6 +288,28 @@ modparam("ndb_redis", "disable_time", 30) modparam("ndb_redis", "flush_on_reconnect", 1) ... +3.9. allow_dynamic_nodes (integer) + + If set to 1, the module will connect to servers indicated in the + "MOVED" reply, even if they are not specified at startup. + + When “cluster” is enabled the module supports redirections ("MOVED") + replies. Set “allow_dynamic_nodes” to 1 to avoid listing all the nodes + at startup. You can only list one node, e.g. by using a DNS name for + the cluster instead of an IP address. The module will add dynamically + the new nodes as the MOVED replies are received. Only works if + “cluster” is set to 1. + + Default value is “0” (disabled). + + Example 1.9. Set allow_dynamic_nodes parameter +... +modparam("ndb_redis", "server", "name=redis_cluster;addr=127.0.0.1;port=26008") +... +modparam("ndb_redis", "cluster", 1) +modparam("ndb_redis", "allow_dynamic_nodes", 1) +... + 4. Functions 4.1. redis_cmd(srvname, command, ..., replyid) @@ -320,7 +346,7 @@ modparam("ndb_redis", "flush_on_reconnect", 1) The first value[n] references the element in the first array, while the next key references an element of the referenced array. - Example 1.9. redis_cmd usage + Example 1.10. redis_cmd usage ... if(redis_cmd("srvN", "INCR cnt", "r")) { # success - the incremented value is in $redis(r=>value) @@ -399,7 +425,7 @@ if (redis_cmd("srvN", "EXEC", "r")) { If cluster parameter is set to 1, this function will log an error and do nothing. - Example 1.10. redis_execute usage + Example 1.11. redis_execute usage ... After several redis command calls: redis_pipe_cmd("srvA", "SET foo bar", "r1"); @@ -447,7 +473,7 @@ d commands. The call is not necessary function. When ndb_redis module closes, all pending replies are freed automatically. - Example 1.11. redis_free usage + Example 1.12. redis_free usage ... After a redis command call: redis_cmd("srvN", "INCR cnt", "r");

1 0

git:master:5ea80150: ndb_redis: dynamic discovery of nodes
by Daniel-Constantin Mierla 13 Feb '18

13 Feb '18

Module: kamailio Branch: master Commit: 5ea801500e06df6e1eb45712fbd52fb7e0ed382c URL: https://github.com/kamailio/kamailio/commit/5ea801500e06df6e1eb45712fbd52fb… Author: Giacomo Vacca <giacomo.vacca(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-02-13T08:59:19+01:00 ndb_redis: dynamic discovery of nodes --- Modified: src/modules/ndb_redis/doc/ndb_redis_admin.xml Modified: src/modules/ndb_redis/ndb_redis_mod.c Modified: src/modules/ndb_redis/redis_client.c --- Diff: https://github.com/kamailio/kamailio/commit/5ea801500e06df6e1eb45712fbd52fb… Patch: https://github.com/kamailio/kamailio/commit/5ea801500e06df6e1eb45712fbd52fb…

1 0

[kamailio/kamailio] ndb_redis: dynamic discovery of nodes (#1436)
by Giacomo Vacca 13 Feb '18

13 Feb '18

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  This change provides support in `ndb_redis` for a scenario where the Redis server is part of a cluster _and_ the IP addresses of the nodes are either not known in advance or are subject to change (for example in case the cluster sees new nodes being added). Before this change `ndb_redis` supports the `cluster` option, so that after a `MOVED` response from a node `ndb_redis` will perform again the same query but towards the redirection target. The caveat is that `ndb_redis` must know in advance which IP addresses will be used by the nodes. A`MOVED` response is in the form `-MOVED 1234 1.2.3.4:6379.`, indicating the hash for the request and the redirection target IP address and port. Every node in the cluster must have a modparam entry with `name=IP_ADDRESS:PORT;addr=IP_ADDRESS;port=PORT`. With the changes in this PR, ndb_redis doesn't need to have in advance the list of nodes but it can "discover" them at runtime. There is a caveat to this solution: while defining the nodes in advance allows to define also `pass`, `sock` and `db`, this is currently not supported (and default values are used). If this change will be accepted though, we could add a module parameter to define `pass`, `sock` and `db` for the dynamic nodes. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1436 -- Commit Summary -- * ndb_redis: dynamic discovery of nodes -- File Changes -- M src/modules/ndb_redis/doc/ndb_redis_admin.xml (30) M src/modules/ndb_redis/ndb_redis_mod.c (2) M src/modules/ndb_redis/redis_client.c (53) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1436.patch https://github.com/kamailio/kamailio/pull/1436.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1436

2 2

git:master:a0b6b3ab: tls: small updates to tls config
by Daniel-Constantin Mierla 13 Feb '18

13 Feb '18

Module: kamailio Branch: master Commit: a0b6b3abe1beab33e11a52ff601c9cc50f7e2d56 URL: https://github.com/kamailio/kamailio/commit/a0b6b3abe1beab33e11a52ff601c9cc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-02-13T08:41:13+01:00 tls: small updates to tls config --- Modified: src/modules/tls/tls.cfg --- Diff: https://github.com/kamailio/kamailio/commit/a0b6b3abe1beab33e11a52ff601c9cc… Patch: https://github.com/kamailio/kamailio/commit/a0b6b3abe1beab33e11a52ff601c9cc… --- diff --git a/src/modules/tls/tls.cfg b/src/modules/tls/tls.cfg index 102990b421..c1a08f6759 100644 --- a/src/modules/tls/tls.cfg +++ b/src/modules/tls/tls.cfg @@ -17,8 +17,8 @@ verify_certificate = no require_certificate = no private_key = /usr/local/etc/kamailio/kamailio-selfsigned.key certificate = /usr/local/etc/kamailio/kamailio-selfsigned.pem -#ca_list = ./modules/tls/cacert.pem -#crl = ./modules/tls/crl.pem +#ca_list = /usr/local/etc/kamailio/tls/cacert.pem +#crl = /usr/local/etc/kamailio/tls/crl.pem # This is the default client domain, settings # in this domain will be used for all outgoing @@ -27,6 +27,7 @@ certificate = /usr/local/etc/kamailio/kamailio-selfsigned.pem # We require that servers present valid certificate. # [client:default] +#method = TLSv1 verify_certificate = yes require_certificate = yes @@ -39,25 +40,25 @@ require_certificate = yes # interface. # #[server:127.0.0.1:5061] -#method = SSLv23 +#method = TLSv1 #verify_certificate = yes #require_certificate = no -#private_key = ./modules/tls/local_key.pem -#certificate = ./modules/tls/local_cert.pem +#private_key = /usr/local/etc/kamailio/tls/local_key.pem +#certificate = /usr/local/etc/kamailio/tls/local_cert.pem #verify_depth = 3 #ca_list = local_ca.pem #crl = local_crl.pem -# Special settings for the iptel.org public SIP +# Special settings for the example.sip (1.2.3.4) public SIP # server. We do not verify the certificate of the # server because it can be expired. The server # implements authentication using SSL client # certificates so configure the client certificate # that was given to use by iptel.org staff here. # -#[client:195.37.77.101:5061] +#[client:1.2.3.4:5061] #verify_certificate = no -#certificate = ./modules/tls/iptel_client.pem -#private_key = ./modules/tls/iptel_key.pem -#ca_list = ./modules/tls/iptel_ca.pem -#crl = ./modules/tls/iptel_crl.pem +#certificate = /usr/local/etc/kamailio/tls/example_client.pem +#private_key = /usr/local/etc/kamailio/tls/example_key.pem +#ca_list = /usr/local/etc/kamailio/tls/example_ca.pem +#crl = /usr/local/etc/kamailio/tls/example_crl.pem

1 0

[kamailio] having keep-alive response count before ending the dialog (#438)
by jayesh1017 12 Feb '18

12 Feb '18

Kamailio takes care of sending in-dialog keep-alives using OPTIONS when dlg_set_attribute ka-src and ka-dst is used. It also sends OPTIONS to correct address if a client sends Re-Invite indicating a network change, which is a common case with mobile clients (switching between mobile-data and Wifi) fixed in #273 The problem is that it ends the dialog on missing even one keep-alive response. Missing a response is possible when the client is handling the network change and keep-alive is sent around that time. Thus, having a configurable counter after which you expect to end the dialog might be helpful. For eg. you decide to end the dialog after we miss 3 responses for keep-alives in a row. Something like dlg_set_attribute(ka-src, 3) where 3 indicates the number of responses that can be missed before ending the dialog. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/438

4 11

[kamailio/kamailio] redis support into usrloc (#1137)
by Surendra Tiwari 12 Feb '18

12 Feb '18

### Description  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1137

6 15

git:master:92451536: presence: return on having a full match on states in xml document
by Daniel-Constantin Mierla 12 Feb '18

12 Feb '18

Module: kamailio Branch: master Commit: 92451536a0ef985ff1d16c5531c232cd657532e1 URL: https://github.com/kamailio/kamailio/commit/92451536a0ef985ff1d16c5531c232c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-02-12T10:15:47+01:00 presence: return on having a full match on states in xml document - better handling after previous commit, related to GH #1427 --- Modified: src/modules/presence/presentity.c --- Diff: https://github.com/kamailio/kamailio/commit/92451536a0ef985ff1d16c5531c232c… Patch: https://github.com/kamailio/kamailio/commit/92451536a0ef985ff1d16c5531c232c… --- diff --git a/src/modules/presence/presentity.c b/src/modules/presence/presentity.c index 5f0eef6368..4674f0ad49 100644 --- a/src/modules/presence/presentity.c +++ b/src/modules/presence/presentity.c @@ -338,6 +338,7 @@ int ps_match_dialog_state_from_body(str body, int *is_dialog, char *vstate) if (tmp_state != NULL) { if(strcmp(tmp_state, vstate)!=0) { + /* state not matched */ xmlFree(tmp_state); rmatch = 0; goto done; @@ -550,8 +551,8 @@ int ps_match_dialog_state(presentity_t* presentity, char* vstate) rmatch = ps_match_dialog_state_from_body(tmp_db_body, &db_is_dialog, vstate); - if(rmatch<=0) { - /* failure or not a match */ + if(rmatch==1) { + /* having a full match */ pa_dbf.free_result(pa_db, result); result = NULL; return rmatch;

1 0

git:master:76b40abd: presence: check if all related dialog states are terminated
by Daniel-Constantin Mierla 12 Feb '18

12 Feb '18

Module: kamailio Branch: master Commit: 76b40abd6534a5af0164601e48e525b9a5915930 URL: https://github.com/kamailio/kamailio/commit/76b40abd6534a5af0164601e48e525b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-02-12T10:07:00+01:00 presence: check if all related dialog states are terminated - fix for incorrect dialog state for multiple dialogs xml body - reported by GH #1427 --- Modified: src/modules/presence/presentity.c --- Diff: https://github.com/kamailio/kamailio/commit/76b40abd6534a5af0164601e48e525b… Patch: https://github.com/kamailio/kamailio/commit/76b40abd6534a5af0164601e48e525b…

1 0

[kamailio/kamailio] topos 5.1.1 regression: missing Contact header in in-dialog requests despite record_route() having been executed for initial request (#1421)
by George Diamantopoulos 12 Feb '18

12 Feb '18

Hello all, It seems there has been a regression between kamailio 5.1.0 and 5.1.1 with the topos module. ### Description Kamailio acts as a proxy for asterisk instances residing in a private IP range and other entities (subscribers, peers) residing on other networks. This is a multihomed installation, with 4 interfaces total (but mhomed is set to no). Just by upgrading to 5.1.1, topos will complain with: `tps_storage_record(): no local address - do record routing for all initial requests` for re-INVITEs within an established dialog. This warning is also printed for other in-dialog requests (BYE, ACK). Also common behaviour with all those in-dialog requests is that if the request received by kamailio had a Contact header, topos will strip it before relaying (true for re-INVITE and ACK). For ACK there seem to be no obvious side-effects, because there's no response to it. For BYE, its 200 OK response is routed properly, in contrast with the 200 OK to the re-INVITE. During the processing of 200 OK to re-INVITE, the following relevant lines are printed in the logs: ``` DEBUG: topos [tps_msg.c:1031]: tps_response_sent(): handling outgoing response DEBUG: topos [tps_msg.c:1038]: tps_response_sent(): no x-branch header - nothing to do ``` During the processing of 200 OK to BYE, the following relevant lines are printed in the logs: ``` DEBUG: topos [tps_msg.c:1031]: tps_response_sent(): handling outgoing response DEBUG: topos [tps_msg.c:376]: tps_pack_message(): compacted headers - x_via1: [SIP/2.0/UDP 192.168.1.1:5060;rport=5060;received=2.2.2.2;branch=z9hG4bK-c1a29abe](86) - x_via2: [](0) - x_vbranch1: [z9hG4bK-c1a29abe](16) DEBUG: topos [tps_msg.c:485]: tps_pack_message(): compacted headers - a_rr: [](0) - b_rr: [](0) - s_rr: [](0) DEBUG: topos [tps_msg.c:490]: tps_pack_message(): compacted headers - as_contact: [](0) - bs_contact: [](0) DEBUG: topos [tps_storage.c:124]: tps_storage_lock_get(): tps lock get: 436 ``` ### Troubleshooting Downgrading to 5.1.0 fixes the issue, with no changes in configuration. #### Reproduction Most SIP logic adheres to the sample configuration file, one difference being that record_route() is performed regardless of request method, as required for topos (although to reproduce this issue this change is not needed, as record_route() is performed for INVITEs anyway with the sample configuration file). To reproduce on my setup, I initiate a call which kamailio will forward to asterisk, making sure topos is loaded. I then put the call on hold to generate a re-INVITE and watch as a) outgoing INVITE lacks a Contact header and b) Final reply to re-INVITE won't be routed, instead causing several retransmissions from asterisk. #### SIP Traffic I'm not sure SIP Traffic is relevant here, as only the Contact header missing is what strikes me as most odd. I can share pcaps and logs privately if needed. ### Additional Information * **Kamailio Version** Kamailio 5.1.1 on debian stretch from sipwise's repo * **Operating System**: ``` Debian 9.1 ``` * **Other pertinent configuration information**: * The following issues might be relevant: #1356, #1350 * This kamailio box has several network interfaces. mhomed is not used, instead force_send_socket is called where necessary. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1421

3 3

← Newer
1
...
21
22
23
24
25
26
27
...
36
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2018