sr-dev November 2018

sr-dev@lists.kamailio.org

22 participants
299 discussions

[kamailio/kamailio] Dispatcher fails to work with NAPTR/SRV as destination (#1743)
by patmurph11 30 Nov '18

30 Nov '18

### Description 1. Added 3 gateways to the dispatcher list file: ``` 1 sip:naptr.mydomain.net 0 0 2 sip:srv.mydomain.net 0 0 ``` started kamailio and ran: ```kamcmd dispatcher.list``` Output: ```error: 500 - No Destination Sets``` If I append to the list, one gateway which resolves to an A record (or an IP:PORT format) like e.g.: ```3 sip:a.mydomain.net:5060 0 0```, it shows up in the dispatcher list just fine: ``` { NRSETS: 1 RECORDS: { SET: { ID: 3 TARGETS: { DEST: { URI: sip:a.mydomain.net:5060 FLAGS: AP PRIORITY: 0 LATENCY: { AVG: 14.642 STD: 0.05 EST: 15.0345 MAX: 25.452 TIMEOUT: 0 } } } } } } ``` I also verified the DNS resolution with: ```kamcmd dns.lookup naptr naptr.mydomain.net``` and ```kamcmd dns.lookup srv srv.mydomain.net``` which was perfectly as expected. Since I wasn't even able to see a dispatcher loaded, there was no operation that I could do to it to set it to active or anything else. A network trace just shows A record queries to all gateways with no success on those which have NAPTR/SRV records. #### Reproduction 100% reproducible with the description above. ### Additional Information Tested on Kamailio version 4.4.5 and 5.1.1 with the following detailed version info: ``` version: kamailio 5.1.1 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. compiled with /usr/bin/gcc 4.1.2 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1743

3 4

Re: [sr-dev] [kamailio/kamailio] textops: new function regex_substring(itext, regex, index, mcount, dpv) (ca8967c)
by Yasin CANER 30 Nov '18

30 Nov '18

mistype? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/ca8967cfb1dc4b5f97ace4c3a326075…

1 0

[kamailio/kamailio] textops : added a new function for getting substring with regular expression (#1733)
by Yasin CANER 30 Nov '18

30 Nov '18

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  added a new function as get_regsub_string for getting substring with regular expression -regexec() function with REG_EXTENDED flags is used -setting variable as result You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1733 -- Commit Summary -- * textops : added a new function for getting substring with regular expression * textops: doc is added for get_regsub_string -- File Changes -- M src/modules/textops/doc/textops_admin.xml (147) M src/modules/textops/textops.c (122) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1733.patch https://github.com/kamailio/kamailio/pull/1733.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1733

2 4

git:master:1a72cd21: textops: docs for regex_substring()
by Daniel-Constantin Mierla 30 Nov '18

30 Nov '18

Module: kamailio Branch: master Commit: 1a72cd21cf3a4ed245a20cd21adeaf8c7e75a1c5 URL: https://github.com/kamailio/kamailio/commit/1a72cd21cf3a4ed245a20cd21adeaf8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-11-30T10:20:23+01:00 textops: docs for regex_substring() --- Modified: src/modules/textops/doc/textops_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/1a72cd21cf3a4ed245a20cd21adeaf8… Patch: https://github.com/kamailio/kamailio/commit/1a72cd21cf3a4ed245a20cd21adeaf8…

1 0

git:master:ca8967cf: textops: new function regex_substring(itext, regex, index, mcount, dpv)
by Daniel-Constantin Mierla 30 Nov '18

30 Nov '18

Module: kamailio Branch: master Commit: ca8967cfb1dc4b5f97ace4c3a32607503a364f69 URL: https://github.com/kamailio/kamailio/commit/ca8967cfb1dc4b5f97ace4c3a326075… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-11-30T10:19:10+01:00 textops: new function regex_substring(itext, regex, index, mcount, dpv) - return a substring extracted by matching with a regular expression and the index of matched tocken - started from GH #1733 --- Modified: src/modules/textops/textops.c --- Diff: https://github.com/kamailio/kamailio/commit/ca8967cfb1dc4b5f97ace4c3a326075… Patch: https://github.com/kamailio/kamailio/commit/ca8967cfb1dc4b5f97ace4c3a326075…

1 0

[kamailio/kamailio] cdp deadlock (#1739)
by thulasizwe-n 30 Nov '18

30 Nov '18

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1739 -- Commit Summary -- * Add files via upload * Merge pull request #1 from thulasizwe-n/thulasizwe-n-patch-1 * fixed possible list corruption * cdp -- lockup fix -- File Changes -- A modules/routing.c (299) A msrp_env.c (226) A msrp_mod.c (505) A msrp_netio.c (453) A msrp_netio.h (42) A msrp_options.c (75) A msrp_options.h (21) A ro_session_hash.h (244) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1739.patch https://github.com/kamailio/kamailio/pull/1739.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1739

3 5

[kamailio/kamailio] Allow startup with offline database. See issue https://github.com/kam… (#1706)
by mihovilkolaric 30 Nov '18

30 Nov '18

…ailio/kamailio/issues/1681   #### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1706 -- Commit Summary -- * Allow startup with offline database. See issue https://github.com/kamailio/kamailio/issues/1681 -- File Changes -- M src/modules/sqlops/README (25) M src/modules/sqlops/sqlops.c (34) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1706.patch https://github.com/kamailio/kamailio/pull/1706.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1706

2 3

git:master:6c1c70bb: sqlops: docs for connect_mode parameter
by Daniel-Constantin Mierla 30 Nov '18

30 Nov '18

Module: kamailio Branch: master Commit: 6c1c70bbceeba87d6d87c852006c92f7d120ddb9 URL: https://github.com/kamailio/kamailio/commit/6c1c70bbceeba87d6d87c852006c92f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-11-30T09:25:53+01:00 sqlops: docs for connect_mode parameter --- Modified: src/modules/sqlops/doc/sqlops_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/6c1c70bbceeba87d6d87c852006c92f… Patch: https://github.com/kamailio/kamailio/commit/6c1c70bbceeba87d6d87c852006c92f… --- diff --git a/src/modules/sqlops/doc/sqlops_admin.xml b/src/modules/sqlops/doc/sqlops_admin.xml index 4b38a3f7b8..aaec64f302 100644 --- a/src/modules/sqlops/doc/sqlops_admin.xml +++ b/src/modules/sqlops/doc/sqlops_admin.xml @@ -191,6 +191,27 @@ modparam("sqlops", "sqlres", "ra") ... modparam("sqlops", "tr_buf_size", 4096) ... +</programlisting> + </example> + </section> + <section id="sqlops.p.connect_mode"> + <title><varname>connect_mode</varname> (int)</title> + <para> + Control if the module must stop loading when connecting to database + server fails during start up. Values: 0 - stop loading; 1 - continue + even if connecting to database server fails. + </para> + <para> + <emphasis> + Default value is 0. + </emphasis> + </para> + <example> + <title>Set <varname>connect_mode</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("sqlops", "connect_mode", 1) +... </programlisting> </example> </section>

1 0

git:master:2df43b99: sqlops: option to start even when connecting to db fails
by Daniel-Constantin Mierla 30 Nov '18

30 Nov '18

Module: kamailio Branch: master Commit: 2df43b992b1e6932974bd0c928c0465a839b75da URL: https://github.com/kamailio/kamailio/commit/2df43b992b1e6932974bd0c928c0465… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-11-30T09:24:59+01:00 sqlops: option to start even when connecting to db fails - new parameter connect_mode: 0 (default) - do not start if connecting to db fails; 1 - start even if connecting to db fails - started from GH #1706 --- Modified: src/modules/sqlops/sql_api.c Modified: src/modules/sqlops/sql_api.h Modified: src/modules/sqlops/sqlops.c --- Diff: https://github.com/kamailio/kamailio/commit/2df43b992b1e6932974bd0c928c0465… Patch: https://github.com/kamailio/kamailio/commit/2df43b992b1e6932974bd0c928c0465…

1 0

git:master:1b014d65: lib/srdb1: memset db connection structure earlier in db_bind_mod()
by Daniel-Constantin Mierla 30 Nov '18

30 Nov '18

Module: kamailio Branch: master Commit: 1b014d65e26a99f9f5d4aea1b27949776f083c2d URL: https://github.com/kamailio/kamailio/commit/1b014d65e26a99f9f5d4aea1b279497… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-11-30T09:19:16+01:00 lib/srdb1: memset db connection structure earlier in db_bind_mod() --- Modified: src/lib/srdb1/db.c --- Diff: https://github.com/kamailio/kamailio/commit/1b014d65e26a99f9f5d4aea1b279497… Patch: https://github.com/kamailio/kamailio/commit/1b014d65e26a99f9f5d4aea1b279497… --- diff --git a/src/lib/srdb1/db.c b/src/lib/srdb1/db.c index 4a250bc819..7d53f70361 100644 --- a/src/lib/srdb1/db.c +++ b/src/lib/srdb1/db.c @@ -163,6 +163,12 @@ int db_bind_mod(const str* mod, db_func_t* mydbf) LM_CRIT("null dbf parameter\n"); return -1; } + + /* for safety we initialize mydbf with 0 (this will cause + * a segfault immediately if someone tries to call a function + * from it without checking the return code from bind_dbmod */ + memset((void*)mydbf, 0, sizeof(db_func_t)); + if (mod->len > MAX_URL_LENGTH) { LM_ERR("SQL URL too long\n"); @@ -178,11 +184,6 @@ int db_bind_mod(const str* mod, db_func_t* mydbf) memcpy(name+3, mod->s, mod->len); name[mod->len+3] = 0; - /* for safety we initialize mydbf with 0 (this will cause - * a segfault immediately if someone tries to call a function - * from it without checking the return code from bind_dbmod */ - memset((void*)mydbf, 0, sizeof(db_func_t)); - p = strchr(name, ':'); if (p) { len = p - name;

1 0

← Newer
1
...
6
7
8
9
10
11
12
...
30
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2018