sr-dev October 2018

sr-dev@lists.kamailio.org

23 participants
274 discussions

Build failed in Jenkins: kamailio44-nightly-binaries » i386,squeeze,slave #128

by kamailio＠sipwise.com

See <https://kamailio.sipwise.com/job/kamailio44-nightly-binaries/architecture=i…> ------------------------------------------ [...truncated 360.27 KB...] + '[' 3600 -eq 0 ']' + touch /var/run/lock/squeeze-i386.building.3467 + case "$architecture" in + linux32 sudo DIST=squeeze ARCH=i386 cowbuilder --buildresult <https://kamailio.sipwise.com/job/kamailio44-nightly-binaries/architecture=i…> --build <https://kamailio.sipwise.com/job/kamailio44-nightly-binaries/architecture=i…> --basepath /var/cache/pbuilder/base-squeeze-i386.cow --debbuildopts -B --hookdir /usr/share/jenkins-debian-glue/pbuilder-hookdir/ --bindmounts '/tmp/apt-jdg_cwE6xn ' --configfile=/tmp/tmp.9M3renpBjV -> Copying COW directory forking: rm -rf /var/cache/pbuilder/build//cow.11132 forking: cp -al /var/cache/pbuilder/base-squeeze-i386.cow /var/cache/pbuilder/build//cow.11132 I: removed stale ilistfile /var/cache/pbuilder/build//cow.11132/.ilist forking: chroot /var/cache/pbuilder/build//cow.11132 cowdancer-ilistcreate /.ilist find . -xdev -path ./home -prune -o $ \( -type l -o -type f $ -a -links +1 -print0 \) | xargs -0 stat --format '%d %i ' -> Invoking pbuilder forking: pbuilder build --debbuildopts -B --hookdir /usr/share/jenkins-debian-glue/pbuilder-hookdir/ --bindmounts /tmp/apt-jdg_cwE6xn --configfile /tmp/tmp.9M3renpBjV --buildplace /var/cache/pbuilder/build//cow.11132 --buildresult <https://kamailio.sipwise.com/job/kamailio44-nightly-binaries/architecture=i…> --debbuildopts -B --no-targz --internal-chrootexec chroot /var/cache/pbuilder/build//cow.11132 cow-shell <https://kamailio.sipwise.com/job/kamailio44-nightly-binaries/architecture=i…> W: /root/.pbuilderrc does not exist I: Running in no-targz mode I: using fakeroot in build. I: pbuilder: network access will be disabled during build I: Current time: Tue Oct 30 04:27:20 UTC 2018 I: pbuilder-time-stamp: 1540873640 I: copying local configuration I: mounting /proc filesystem I: mounting /run/shm filesystem I: mounting /dev/pts filesystem I: Mounting /tmp/apt-jdg_cwE6xn I: policy-rc.d already exists I: Obtaining the cached apt archive contents I: Installing the build-deps I: user script /var/cache/pbuilder/build/cow.11132/tmp/hooks/D10-man-db starting I: Preseed man-db/auto-update to false I: user script /var/cache/pbuilder/build/cow.11132/tmp/hooks/D10-man-db finished I: user script /var/cache/pbuilder/build/cow.11132/tmp/hooks/D20releaserepo starting + set -- /tmp/apt-jdg_cwE6xn/ + TMPAPT=/tmp/apt-jdg_cwE6xn/ + [ -d /tmp/apt-jdg_cwE6xn/ ] + UPDATE_PKGLIST=0 + ls /tmp/apt-jdg_cwE6xn/*.list + [ -e /tmp/apt-jdg_cwE6xn//keyring.gpg ] + [ 0 = 1 ] I: user script /var/cache/pbuilder/build/cow.11132/tmp/hooks/D20releaserepo finished -> Attempting to satisfy build-dependencies -> Creating pbuilder-satisfydepends-dummy package Package: pbuilder-satisfydepends-dummy Version: 0.invalid.0 Architecture: i386 Maintainer: Debian Pbuilder Team <pbuilder-maint(a)lists.alioth.debian.org> Description: Dummy package to satisfy dependencies with aptitude - created by pbuilder This package was created automatically by pbuilder to satisfy the build-dependencies of the package being currently built. Depends: bison, debhelper (>= 8), libmysqlclient-dev, docbook-xml, erlang-dev, flex, libconfuse-dev, libcurl4-openssl-dev, libdb-dev (>= 4.6.19), libev-dev, libevent-dev, libexpat1-dev, libgeoip-dev (>= 1.4.5), libjson0-dev, libldap2-dev, liblua5.1-0-dev, libmemcached-dev, libncurses5-dev, libpcre3-dev, libperl-dev, libpq-dev, libradiusclient-ng-dev, libreadline-dev, libsasl2-dev, libsnmp-dev, libsqlite3-dev, libunistring-dev, libxml2-dev, libxmlrpc-c3-dev, openssl, pkg-config, python, python-dev, unixodbc-dev, uuid-dev, xsltproc, zlib1g-dev dpkg-deb: building package `pbuilder-satisfydepends-dummy' in `/tmp/satisfydepends-aptitude/pbuilder-satisfydepends-dummy.deb'. Selecting previously deselected package pbuilder-satisfydepends-dummy. (Reading database ... 10562 files and directories currently installed.) Unpacking pbuilder-satisfydepends-dummy (from .../pbuilder-satisfydepends-dummy.deb) ... dpkg: pbuilder-satisfydepends-dummy: dependency problems, but configuring anyway as you requested: pbuilder-satisfydepends-dummy depends on bison; however: Package bison is not installed. pbuilder-satisfydepends-dummy depends on debhelper (>= 8); however: Package debhelper is not installed. pbuilder-satisfydepends-dummy depends on libmysqlclient-dev; however: Package libmysqlclient-dev is not installed. pbuilder-satisfydepends-dummy depends on docbook-xml; however: Package docbook-xml is not installed. pbuilder-satisfydepends-dummy depends on erlang-dev; however: Package erlang-dev is not installed. pbuilder-satisfydepends-dummy depends on flex; however: Package flex is not installed. pbuilder-satisfydepends-dummy depends on libconfuse-dev; however: Package libconfuse-dev is not installed. pbuilder-satisfydepends-dummy depends on libcurl4-openssl-dev; however: Package libcurl4-openssl-dev is not installed. pbuilder-satisfydepends-dummy depends on libdb-dev (>= 4.6.19); however: Package libdb-dev is not installed. pbuilder-satisfydepends-dummy depends on libev-dev; however: Package libev-dev is not installed. pbuilder-satisfydepends-dummy depends on libevent-dev; however: Package libevent-dev is not installed. pbuilder-satisfydepends-dummy depends on libexpat1-dev; however: Package libexpat1-dev is not installed. pbuilder-satisfydepends-dummy depends on libgeoip-dev (>= 1.4.5); however: Package libgeoip-dev is not installed. pbuilder-satisfydepends-dummy depends on libjson0-dev; however: Package libjson0-dev is not installed. pbuilder-satisfydepends-dummy depends on libldap2-dev; however: Package libldap2-dev is not installed. pbuilder-satisfydepends-dummy depends on liblua5.1-0-dev; however: Package liblua5.1-0-dev is not installed. pbuilder-satisfydepends-dummy depends on libmemcached-dev; however: Package libmemcached-dev is not installed. pbuilder-satisfydepends-dummy depends on libncurses5-dev; however: Package libncurses5-dev is not installed. pbuilder-satisfydepends-dummy depends on libpcre3-dev; however: Package libpcre3-dev is not installed. pbuilder-satisfydepends-dummy depends on libperl-dev; however: Package libperl-dev is not installed. pbuilder-satisfydepends-dummy depends on libpq-dev; however: Package libpq-dev is not installed. pbuilder-satisfydepends-dummy depends on libradiusclient-ng-dev; however: Package libradiusclient-ng-dev is not installed. pbuilder-satisfydepends-dummy depends on libreadline-dev; however: Package libreadline-dev is not installed. pbuilder-satisfydepends-dummy depends on libsasl2-dev; however: Package libsasl2-dev is not installed. pbuilder-satisfydepends-dummy depends on libsnmp-dev; however: Package libsnmp-dev is not installed. pbuilder-satisfydepends-dummy depends on libsqlite3-dev; however: Package libsqlite3-dev is not installed. pbuilder-satisfydepends-dummy depends on libunistring-dev; however: Package libunistring-dev is not installed. pbuilder-satisfydepends-dummy depends on libxml2-dev; however: Package libxml2-dev is not installed. pbuilder-satisfydepends-dummy depends on libxmlrpc-c3-dev; however: Package libxmlrpc-c3-dev is not installed. pbuilder-satisfydepends-dummy depends on openssl; however: Package openssl is not installed. pbuilder-satisfydepends-dummy depends on pkg-config; however: Package pkg-config is not installed. pbuilder-satisfydepends-dummy depends on python; however: Package python is not installed. pbuilder-satisfydepends-dummy depends on python-dev; however: Package python-dev is not installed. pbuilder-satisfydepends-dummy depends on unixodbc-dev; however: Package unixodbc-dev is not installed. pbuilder-satisfydepends-dummy depends on uuid-dev; however: Package uuid-dev is not installed. pbuilder-satisfydepends-dummy depends on xsltproc; however: Package xsltproc is not installed. pbuilder-satisfydepends-dummy depends on zlib1g-dev; however: Package zlib1g-dev is not installed. Setting up pbuilder-satisfydepends-dummy (0.invalid.0) ... Reading package lists... Building dependency tree... Reading state information... Initializing package states... Writing extended state information... The following NEW packages will be installed: bison{a} bsdmainutils{a} ca-certificates{a} comerr-dev{a} debhelper{a} docbook-xml{a} erlang-base{a} erlang-dev{a} file{a} flex{a} fontconfig{a} fontconfig-config{a} gettext{a} gettext-base{a} groff-base{a} html2text{a} intltool-debian{a} krb5-multidev{a} libaudio2{a} libconfuse-dev{a} libconfuse0{a} libcroco3{a} libcurl3{a} libcurl4-openssl-dev{a} libdb-dev{a} libdb4.8-dev{a} libev-dev{a} libev3{a} libevent-1.4-2{a} libevent-core-1.4-2{a} libevent-dev{a} libevent-extra-1.4-2{a} libexpat1{a} libexpat1-dev{a} libfontconfig1{a} libfreetype6{a} libgcrypt11{a} libgeoip-dev{a} libgeoip1{a} libglib2.0-0{a} libgnutls26{a} libgpg-error0{a} libgssapi-krb5-2{a} libgssrpc4{a} libhashkit0{a} libice6{a} libidn11{a} libidn11-dev{a} libjpeg62{a} libjson0{a} libjson0-dev{a} libk5crypto3{a} libkadm5clnt-mit7{a} libkadm5srv-mit7{a} libkdb5-4{a} libkeyutils1{a} libkrb5-3{a} libkrb5-dev{a} libkrb5support0{a} liblcms1{a} libldap-2.4-2{a} libldap2-dev{a} libltdl-dev{a} libltdl7{a} liblua5.1-0{a} liblua5.1-0-dev{a} libmagic1{a} libmemcached-dev{a} libmemcached5{a} libmemcachedprotocol0{a} libmemcachedutil0{a} libmng1{a} libmysqlclient-dev{a} libmysqlclient16{a} libncurses5-dev{a} libodbcinstq1c2{a} libpcre3{a} libpcre3-dev{a} libpcrecpp0{a} libperl-dev{a} libperl5.10{a} libpng12-0{a} libpopt0{a} libpq-dev{a} libpq5{a} libpython2.6{a} libqt3-mt{a} libradiusclient-ng-dev{a} libradiusclient-ng2{a} libreadline-dev{a} libreadline6-dev{a} libsasl2-2{a} libsasl2-dev{a} libsasl2-modules{a} libsensors4{a} libsensors4-dev{a} libsm6{a} libsnmp-base{a} libsnmp-dev{a} libsnmp-perl{a} libsnmp15{a} libsqlite3-dev{a} libssh2-1{a} libssh2-1-dev{a} libssl-dev{a} libtasn1-3{a} libunistring-dev{a} libunistring0{a} libwrap0{a} libwrap0-dev{a} libx11-6{a} libx11-data{a} libxau6{a} libxcb1{a} libxcursor1{a} libxdmcp6{a} libxext6{a} libxfixes3{a} libxft2{a} libxi6{a} libxinerama1{a} libxml2{a} libxml2-dev{a} libxmlrpc-c3{a} libxmlrpc-c3-dev{a} libxrandr2{a} libxrender1{a} libxslt1.1{a} libxt6{a} m4{a} makedev{a} man-db{a} mime-support{a} mysql-common{a} odbcinst{a} odbcinst1debian2{a} openssl{a} pkg-config{a} po-debconf{a} procps{a} python{a} python-dev{a} python-minimal{a} python2.6{a} python2.6-dev{a} python2.6-minimal{a} sgml-base{a} sgml-data{a} ttf-dejavu-core{a} ucf{a} unixodbc{a} unixodbc-dev{a} uuid-dev{a} x11-common{a} xml-core{a} xsltproc{a} zlib1g-dev{a} 0 packages upgraded, 157 newly installed, 0 to remove and 0 not upgraded. Need to get 68.8 MB/69.0 MB of archives. After unpacking 190 MB will be used. WARNING: untrusted versions of the following packages will be installed! Untrusted packages could compromise your system's security. You should only proceed with the installation if you are certain that this is what you want to do. libkeyutils1 libconfuse-dev libkrb5-3 libodbcinstq1c2 libpopt0 ttf-dejavu-core libxfixes3 xsltproc libkrb5support0 libperl-dev libevent-1.4-2 liblcms1 python2.6-minimal mime-support procps libidn11 debhelper libsensors4 libwrap0 libhashkit0 pkg-config intltool-debian libsnmp15 libevent-core-1.4-2 libkadm5clnt-mit7 libradiusclient-ng2 bison libx11-data comerr-dev libssh2-1-dev libpcre3-dev libgeoip-dev libxmlrpc-c3 libevent-dev docbook-xml libsasl2-modules m4 libsqlite3-dev libxslt1.1 po-debconf libpcre3 mysql-common groff-base python-dev libfontconfig1 fontconfig-config libgnutls26 unixodbc-dev libkrb5-dev odbcinst libsasl2-dev libmysqlclient-dev xml-core libradiusclient-ng-dev python2.6 libtasn1-3 libmemcachedutil0 python-minimal libdb-dev libldap2-dev libexpat1 libk5crypto3 libgssrpc4 libpcrecpp0 unixodbc fontconfig libjson0 libxmlrpc-c3-dev gettext libxcb1 libunistring-dev libsensors4-dev libxau6 libcurl3 libreadline-dev odbcinst1debian2 libjson0-dev krb5-multidev python libxft2 libssl-dev libssh2-1 libcroco3 libice6 ca-certificates libxdmcp6 libgcrypt11 makedev libpython2.6 libxml2 erlang-dev zlib1g-dev libmemcached5 file libxml2-dev libwrap0-dev bsdmainutils libgpg-error0 python2.6-dev libxrender1 flex sgml-base ucf libsnmp-perl libev3 gettext-base libsnmp-dev uuid-dev libpng12-0 libjpeg62 libgeoip1 libperl5.10 liblua5.1-0-dev libconfuse0 libpq-dev libkadm5srv-mit7 libmysqlclient16 libldap-2.4-2 libfreetype6 libmemcachedprotocol0 libexpat1-dev libreadline6-dev libunistring0 libglib2.0-0 liblua5.1-0 libmemcached-dev x11-common libncurses5-dev sgml-data libsnmp-base libx11-6 libsasl2-2 libpq5 man-db html2text libdb4.8-dev openssl libev-dev libsm6 libkdb5-4 libqt3-mt libgssapi-krb5-2 libevent-extra-1.4-2 libxi6 libaudio2 libxcursor1 libxt6 libxinerama1 libltdl-dev libxext6 libxrandr2 libmng1 libidn11-dev libltdl7 libmagic1 libcurl4-openssl-dev erlang-base Do you want to ignore this warning and proceed anyway? To continue, enter "Yes"; to abort, enter "No": Abort. E: pbuilder-satisfydepends failed. I: Copying back the cached apt archive contents I: unmounting /tmp/apt-jdg_cwE6xn filesystem I: unmounting dev/pts filesystem I: unmounting run/shm filesystem I: unmounting proc filesystem -> Cleaning COW directory forking: rm -rf /var/cache/pbuilder/build//cow.11132 + '[' 1 -eq 0 ']' + bailout 1 'Error: Failed to build with cowbuilder.' + '[' -n 1 ']' + EXIT=1 + '[' -n 'Error: Failed to build with cowbuilder.' ']' + echo 'Error: Failed to build with cowbuilder.' Error: Failed to build with cowbuilder. + rm -f /var/run/lock/squeeze-i386.building.3467 + '[' -r /var/run/lock/squeeze-i386.update.3467 ']' + '[' '' = true ']' + echo '*** Getting rid of files in <https://kamailio.sipwise.com/job/kamailio44-nightly-binaries/architecture=i…> to avoid problems in next run. ***' *** Getting rid of files in <https://kamailio.sipwise.com/job/kamailio44-nightly-binaries/architecture=i…> to avoid problems in next run. *** + rm -f '<https://kamailio.sipwise.com/job/kamailio44-nightly-binaries/architecture=i…'> + '[' -n /tmp/tmp.9M3renpBjV ']' + rm -rf /tmp/tmp.9M3renpBjV + '[' -n /tmp/apt-jdg_cwE6xn ']' + sudo rm -rf /tmp/apt-jdg_cwE6xn + '[' -n 12477 ']' ++ sed -e 's/^$[0-9]*$.*/\1/' + SECONDS=25 ++ date + echo '*** Finished execution of /usr/bin/build-and-provide-package at Tue Oct 30 04:27:32 UTC 2018 [running 25 seconds] ***' *** Finished execution of /usr/bin/build-and-provide-package at Tue Oct 30 04:27:32 UTC 2018 [running 25 seconds] *** + exit 1 Build step 'Execute shell' marked build as failure Archiving artifacts Recording fingerprints TAP Reports Processing: START Looking for TAP results report in workspace using pattern: report/*.tap Did not find any matching files. Recording test results ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error?

6 years, 1 month

[kamailio/kamailio] acc: generating duplicates on missed / failed calls (#1673)

by Julien Chavanton

### Description I am looking at how to properly handle a problem with duplicate ACC This is when `TMCB_ON_FAILURE` and `TMCB_RESPONSE_OUT` are both called, they are not using the same version of the message. `TMCB_ON_FAILURE` is using the cloned version `TMCB_RESPONSE_OUT` is using the original version They are not sharing the message flags and 2 ACC events are generated. Since this is very sensitive, I want to make sure I can trace the real root cause. Not sure if this is a regression ... #### Reproduction Any failed call #### Debugging Data ``` 0(4603) NOTICE: acc [acc_logic.c:686]: tmcb_func(): acc callback called for t(0x7f768b6dac08) event type 2, reply code 404 reqmsg[0x7f768b6dc840] rplmsg[0x7f76d096dee8] 0(4603) ERROR: acc [acc_logic.c:697]: tmcb_func(): [TMCB_RESPONSE_IN][0x7f768b6dc840][0x7f76d096dee8] // reply route execution 0(4603) ERROR: <core> [core/sip_msg_clone.c:504]: sip_msg_shm_clone(): sip_msg_shm_clone[0x7f768b6dc840]>>[0x7f768b6de738] 0(4603) NOTICE: acc [acc_logic.c:686]: tmcb_func(): acc callback called for t(0x7f768b6dac08) event type 128, reply code 404 reqmsg[0x7f768b6de738] rplmsg[0x7f76d096dee8] 0(4603) ERROR: acc [acc_logic.c:694]: tmcb_func(): [TMCB_ON_FAILURE] run on_missed [0x7f768b6de738][0x7f76d096dee8] // working with the cloned message 0(4603) ERROR: <core> [core/flags.c:59]: isflagset(): isflagset[0x7f768b6de738] 0(4603) ERROR: acc_json [acc_json_mod.c:189]: acc_json_send_request(): missed call flag [7] for this transaction [on] // failure route execution, we are working with the cloned message 0(4603) NOTICE: <script>: [FAILURE] 0(4603) ERROR: <core> [core/flags.c:46]: setflag(): setflag[0x7f768b6de738] // failure 0(4603) NOTICE: acc [acc_logic.c:686]: tmcb_func(): acc callback called for t(0x7f768b6dac08) event type 512, reply code 404 reqmsg[0x7f768b6dc840] rplmsg[0x7f76d096dee8] 0(4603) ERROR: acc [acc_logic.c:689]: tmcb_func(): [TMCB_RESPONSE_OUT][0x7f768b6dc840][0x7f76d096dee8] // working with the original message 0(4603) ERROR: <core> [core/flags.c:59]: isflagset(): isflagset[0x7f768b6dc840] 0(4603) ERROR: acc_json [acc_json_mod.c:189]: acc_json_send_request(): missed call flag [7] for this transaction [on] ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1673

6 years, 1 month

[kamailio/kamailio] acc: generating duplicates (#1674)

by Julien Chavanton

on missed / failed calls issue #1673 #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [x] Breaking change (not tested with all scenarios, review could confirm that this is not introducing regressions) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #1673 #### Description problem with confusion when using flags (integer value vs bit position value) proposed solution is using the flags helpers functions `isflagset`, etc. where possible. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1674 -- Commit Summary -- * acc: generating duplicates -- File Changes -- M src/modules/acc/acc.c (8) M src/modules/acc/acc_logic.c (5) M src/modules/acc_diameter/acc_diameter_mod.c (4) M src/modules/acc_json/acc_json_mod.c (4) M src/modules/acc_radius/acc_radius_mod.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1674.patch https://github.com/kamailio/kamailio/pull/1674.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1674

6 years, 1 month

git:master:96aa7990: ims_ipsec_pcscf: Fix a memory leak in add_security_server_header()

by Tsvetomir Dimitrov

Module: kamailio Branch: master Commit: 96aa799065d45a48e00a3efff252aa9bb473e355 URL: https://github.com/kamailio/kamailio/commit/96aa799065d45a48e00a3efff252aa9… Author: Tsvetomir Dimitrov <tsv.dimitrov(a)gmail.com> Committer: Tsvetomir Dimitrov <tsv.dimitrov(a)gmail.com> Date: 2018-10-31T18:43:34+02:00 ims_ipsec_pcscf: Fix a memory leak in add_security_server_header() --- Modified: src/modules/ims_ipsec_pcscf/cmd.c --- Diff: https://github.com/kamailio/kamailio/commit/96aa799065d45a48e00a3efff252aa9… Patch: https://github.com/kamailio/kamailio/commit/96aa799065d45a48e00a3efff252aa9… --- diff --git a/src/modules/ims_ipsec_pcscf/cmd.c b/src/modules/ims_ipsec_pcscf/cmd.c index 17e6c7b000..a662f0c2e4 100644 --- a/src/modules/ims_ipsec_pcscf/cmd.c +++ b/src/modules/ims_ipsec_pcscf/cmd.c @@ -410,6 +410,8 @@ int add_security_server_header(struct sip_msg* m, ipsec_t* s) return -1; } + pkg_free(sec_header); + return 0; }

6 years, 1 month

Build failed in Jenkins: kamailio44-nightly-binaries » amd64,squeeze,slave #128

by kamailio＠sipwise.com

See <https://kamailio.sipwise.com/job/kamailio44-nightly-binaries/architecture=a…> ------------------------------------------ [...truncated 358.90 KB...] + '[' 3600 -eq 0 ']' + touch /var/run/lock/squeeze-amd64.building.16309 + case "$architecture" in + sudo DIST=squeeze ARCH=amd64 cowbuilder --buildresult <https://kamailio.sipwise.com/job/kamailio44-nightly-binaries/architecture=a…> --build <https://kamailio.sipwise.com/job/kamailio44-nightly-binaries/architecture=a…> --basepath /var/cache/pbuilder/base-squeeze-amd64.cow --debbuildopts -sa --hookdir /usr/share/jenkins-debian-glue/pbuilder-hookdir/ --bindmounts '/tmp/apt-jdg_kDNY0m ' --configfile=/tmp/tmp.3UgvqGiG9D -> Copying COW directory forking: rm -rf /var/cache/pbuilder/build//cow.23949 forking: cp -al /var/cache/pbuilder/base-squeeze-amd64.cow /var/cache/pbuilder/build//cow.23949 I: removed stale ilistfile /var/cache/pbuilder/build//cow.23949/.ilist forking: chroot /var/cache/pbuilder/build//cow.23949 cowdancer-ilistcreate /.ilist find . -xdev -path ./home -prune -o $ \( -type l -o -type f $ -a -links +1 -print0 \) | xargs -0 stat --format '%d %i ' -> Invoking pbuilder forking: pbuilder build --debbuildopts -sa --hookdir /usr/share/jenkins-debian-glue/pbuilder-hookdir/ --bindmounts /tmp/apt-jdg_kDNY0m --configfile /tmp/tmp.3UgvqGiG9D --buildplace /var/cache/pbuilder/build//cow.23949 --buildresult <https://kamailio.sipwise.com/job/kamailio44-nightly-binaries/architecture=a…> --debbuildopts -sa --no-targz --internal-chrootexec chroot /var/cache/pbuilder/build//cow.23949 cow-shell <https://kamailio.sipwise.com/job/kamailio44-nightly-binaries/architecture=a…> W: /root/.pbuilderrc does not exist I: Running in no-targz mode I: using fakeroot in build. I: pbuilder: network access will be disabled during build I: Current time: Tue Oct 30 04:26:48 UTC 2018 I: pbuilder-time-stamp: 1540873608 I: copying local configuration I: mounting /proc filesystem I: mounting /run/shm filesystem I: mounting /dev/pts filesystem I: Mounting /tmp/apt-jdg_kDNY0m I: policy-rc.d already exists I: Obtaining the cached apt archive contents I: Installing the build-deps I: user script /var/cache/pbuilder/build/cow.23949/tmp/hooks/D10-man-db starting I: Preseed man-db/auto-update to false I: user script /var/cache/pbuilder/build/cow.23949/tmp/hooks/D10-man-db finished I: user script /var/cache/pbuilder/build/cow.23949/tmp/hooks/D20releaserepo starting + set -- /tmp/apt-jdg_kDNY0m/ + TMPAPT=/tmp/apt-jdg_kDNY0m/ + [ -d /tmp/apt-jdg_kDNY0m/ ] + UPDATE_PKGLIST=0 + ls /tmp/apt-jdg_kDNY0m/*.list + [ -e /tmp/apt-jdg_kDNY0m//keyring.gpg ] + [ 0 = 1 ] I: user script /var/cache/pbuilder/build/cow.23949/tmp/hooks/D20releaserepo finished -> Attempting to satisfy build-dependencies -> Creating pbuilder-satisfydepends-dummy package Package: pbuilder-satisfydepends-dummy Version: 0.invalid.0 Architecture: amd64 Maintainer: Debian Pbuilder Team <pbuilder-maint(a)lists.alioth.debian.org> Description: Dummy package to satisfy dependencies with aptitude - created by pbuilder This package was created automatically by pbuilder to satisfy the build-dependencies of the package being currently built. Depends: bison, debhelper (>= 8), libmysqlclient-dev, docbook-xml, erlang-dev, flex, libconfuse-dev, libcurl4-openssl-dev, libdb-dev (>= 4.6.19), libev-dev, libevent-dev, libexpat1-dev, libgeoip-dev (>= 1.4.5), libjson0-dev, libldap2-dev, liblua5.1-0-dev, libmemcached-dev, libncurses5-dev, libpcre3-dev, libperl-dev, libpq-dev, libradiusclient-ng-dev, libreadline-dev, libsasl2-dev, libsnmp-dev, libsqlite3-dev, libunistring-dev, libxml2-dev, libxmlrpc-c3-dev, openssl, pkg-config, python, python-dev, unixodbc-dev, uuid-dev, xsltproc, zlib1g-dev dpkg-deb: building package `pbuilder-satisfydepends-dummy' in `/tmp/satisfydepends-aptitude/pbuilder-satisfydepends-dummy.deb'. Selecting previously deselected package pbuilder-satisfydepends-dummy. (Reading database ... 10514 files and directories currently installed.) Unpacking pbuilder-satisfydepends-dummy (from .../pbuilder-satisfydepends-dummy.deb) ... dpkg: pbuilder-satisfydepends-dummy: dependency problems, but configuring anyway as you requested: pbuilder-satisfydepends-dummy depends on bison; however: Package bison is not installed. pbuilder-satisfydepends-dummy depends on debhelper (>= 8); however: Package debhelper is not installed. pbuilder-satisfydepends-dummy depends on libmysqlclient-dev; however: Package libmysqlclient-dev is not installed. pbuilder-satisfydepends-dummy depends on docbook-xml; however: Package docbook-xml is not installed. pbuilder-satisfydepends-dummy depends on erlang-dev; however: Package erlang-dev is not installed. pbuilder-satisfydepends-dummy depends on flex; however: Package flex is not installed. pbuilder-satisfydepends-dummy depends on libconfuse-dev; however: Package libconfuse-dev is not installed. pbuilder-satisfydepends-dummy depends on libcurl4-openssl-dev; however: Package libcurl4-openssl-dev is not installed. pbuilder-satisfydepends-dummy depends on libdb-dev (>= 4.6.19); however: Package libdb-dev is not installed. pbuilder-satisfydepends-dummy depends on libev-dev; however: Package libev-dev is not installed. pbuilder-satisfydepends-dummy depends on libevent-dev; however: Package libevent-dev is not installed. pbuilder-satisfydepends-dummy depends on libexpat1-dev; however: Package libexpat1-dev is not installed. pbuilder-satisfydepends-dummy depends on libgeoip-dev (>= 1.4.5); however: Package libgeoip-dev is not installed. pbuilder-satisfydepends-dummy depends on libjson0-dev; however: Package libjson0-dev is not installed. pbuilder-satisfydepends-dummy depends on libldap2-dev; however: Package libldap2-dev is not installed. pbuilder-satisfydepends-dummy depends on liblua5.1-0-dev; however: Package liblua5.1-0-dev is not installed. pbuilder-satisfydepends-dummy depends on libmemcached-dev; however: Package libmemcached-dev is not installed. pbuilder-satisfydepends-dummy depends on libncurses5-dev; however: Package libncurses5-dev is not installed. pbuilder-satisfydepends-dummy depends on libpcre3-dev; however: Package libpcre3-dev is not installed. pbuilder-satisfydepends-dummy depends on libperl-dev; however: Package libperl-dev is not installed. pbuilder-satisfydepends-dummy depends on libpq-dev; however: Package libpq-dev is not installed. pbuilder-satisfydepends-dummy depends on libradiusclient-ng-dev; however: Package libradiusclient-ng-dev is not installed. pbuilder-satisfydepends-dummy depends on libreadline-dev; however: Package libreadline-dev is not installed. pbuilder-satisfydepends-dummy depends on libsasl2-dev; however: Package libsasl2-dev is not installed. pbuilder-satisfydepends-dummy depends on libsnmp-dev; however: Package libsnmp-dev is not installed. pbuilder-satisfydepends-dummy depends on libsqlite3-dev; however: Package libsqlite3-dev is not installed. pbuilder-satisfydepends-dummy depends on libunistring-dev; however: Package libunistring-dev is not installed. pbuilder-satisfydepends-dummy depends on libxml2-dev; however: Package libxml2-dev is not installed. pbuilder-satisfydepends-dummy depends on libxmlrpc-c3-dev; however: Package libxmlrpc-c3-dev is not installed. pbuilder-satisfydepends-dummy depends on openssl; however: Package openssl is not installed. pbuilder-satisfydepends-dummy depends on pkg-config; however: Package pkg-config is not installed. pbuilder-satisfydepends-dummy depends on python; however: Package python is not installed. pbuilder-satisfydepends-dummy depends on python-dev; however: Package python-dev is not installed. pbuilder-satisfydepends-dummy depends on unixodbc-dev; however: Package unixodbc-dev is not installed. pbuilder-satisfydepends-dummy depends on uuid-dev; however: Package uuid-dev is not installed. pbuilder-satisfydepends-dummy depends on xsltproc; however: Package xsltproc is not installed. pbuilder-satisfydepends-dummy depends on zlib1g-dev; however: Package zlib1g-dev is not installed. Setting up pbuilder-satisfydepends-dummy (0.invalid.0) ... Reading package lists... Building dependency tree... Reading state information... Initializing package states... Writing extended state information... The following NEW packages will be installed: bison{a} bsdmainutils{a} ca-certificates{a} comerr-dev{a} debhelper{a} docbook-xml{a} erlang-base{a} erlang-dev{a} file{a} flex{a} fontconfig{a} fontconfig-config{a} gettext{a} gettext-base{a} groff-base{a} html2text{a} intltool-debian{a} krb5-multidev{a} libaudio2{a} libconfuse-dev{a} libconfuse0{a} libcroco3{a} libcurl3{a} libcurl4-openssl-dev{a} libdb-dev{a} libdb4.8-dev{a} libev-dev{a} libev3{a} libevent-1.4-2{a} libevent-core-1.4-2{a} libevent-dev{a} libevent-extra-1.4-2{a} libexpat1{a} libexpat1-dev{a} libfontconfig1{a} libfreetype6{a} libgcrypt11{a} libgeoip-dev{a} libgeoip1{a} libglib2.0-0{a} libgnutls26{a} libgpg-error0{a} libgssapi-krb5-2{a} libgssrpc4{a} libhashkit0{a} libice6{a} libidn11{a} libidn11-dev{a} libjpeg62{a} libjson0{a} libjson0-dev{a} libk5crypto3{a} libkadm5clnt-mit7{a} libkadm5srv-mit7{a} libkdb5-4{a} libkeyutils1{a} libkrb5-3{a} libkrb5-dev{a} libkrb5support0{a} liblcms1{a} libldap-2.4-2{a} libldap2-dev{a} libltdl-dev{a} libltdl7{a} liblua5.1-0{a} liblua5.1-0-dev{a} libmagic1{a} libmemcached-dev{a} libmemcached5{a} libmemcachedprotocol0{a} libmemcachedutil0{a} libmng1{a} libmysqlclient-dev{a} libmysqlclient16{a} libncurses5-dev{a} libodbcinstq1c2{a} libpcre3{a} libpcre3-dev{a} libpcrecpp0{a} libperl-dev{a} libperl5.10{a} libpng12-0{a} libpopt0{a} libpq-dev{a} libpq5{a} libpython2.6{a} libqt3-mt{a} libradiusclient-ng-dev{a} libradiusclient-ng2{a} libreadline-dev{a} libreadline6-dev{a} libsasl2-2{a} libsasl2-dev{a} libsasl2-modules{a} libsensors4{a} libsensors4-dev{a} libsm6{a} libsnmp-base{a} libsnmp-dev{a} libsnmp-perl{a} libsnmp15{a} libsqlite3-dev{a} libssh2-1{a} libssh2-1-dev{a} libssl-dev{a} libtasn1-3{a} libunistring-dev{a} libunistring0{a} libwrap0{a} libwrap0-dev{a} libx11-6{a} libx11-data{a} libxau6{a} libxcb1{a} libxcursor1{a} libxdmcp6{a} libxext6{a} libxfixes3{a} libxft2{a} libxi6{a} libxinerama1{a} libxml2{a} libxml2-dev{a} libxmlrpc-c3{a} libxmlrpc-c3-dev{a} libxrandr2{a} libxrender1{a} libxslt1.1{a} libxt6{a} m4{a} makedev{a} man-db{a} mime-support{a} mysql-common{a} odbcinst{a} odbcinst1debian2{a} openssl{a} pkg-config{a} po-debconf{a} procps{a} python{a} python-dev{a} python-minimal{a} python2.6{a} python2.6-dev{a} python2.6-minimal{a} sgml-base{a} sgml-data{a} ttf-dejavu-core{a} ucf{a} unixodbc{a} unixodbc-dev{a} uuid-dev{a} x11-common{a} xml-core{a} xsltproc{a} zlib1g-dev{a} 0 packages upgraded, 157 newly installed, 0 to remove and 0 not upgraded. Need to get 72.0 MB/72.0 MB of archives. After unpacking 212 MB will be used. WARNING: untrusted versions of the following packages will be installed! Untrusted packages could compromise your system's security. You should only proceed with the installation if you are certain that this is what you want to do. libkrb5-3 libk5crypto3 libpopt0 libxfixes3 libradiusclient-ng2 xsltproc libperl-dev libldap-2.4-2 liblcms1 libexpat1-dev libunistring0 procps libxmlrpc-c3-dev libidn11 debhelper libsensors4 libwrap0 python-minimal libhashkit0 pkg-config libunistring-dev libsnmp15 libjson0-dev ttf-dejavu-core bison libx11-data comerr-dev odbcinst1debian2 liblua5.1-0-dev libpython2.6 docbook-xml libwrap0-dev bsdmainutils libncurses5-dev m4 libxslt1.1 po-debconf libsnmp-perl libpcre3 groff-base gettext-base python-dev libmysqlclient-dev libgnutls26 libkrb5-dev odbcinst xml-core python2.6 intltool-debian libtasn1-3 libfreetype6 libdb-dev libglib2.0-0 libmysqlclient16 libexpat1 libcurl4-openssl-dev libreadline6-dev libgssrpc4 libsnmp-base libpcrecpp0 libmemcached-dev python2.6-minimal unixodbc fontconfig libdb4.8-dev libjson0 gettext libxcb1 libxau6 libodbcinstq1c2 libconfuse-dev libcurl3 libssh2-1-dev libxinerama1 libkrb5support0 python libxft2 fontconfig-config libssl-dev libradiusclient-ng-dev libssh2-1 libcroco3 libmemcachedutil0 libevent-1.4-2 libidn11-dev libice6 libmemcachedprotocol0 libxdmcp6 libgcrypt11 makedev python2.6-dev libxml2 erlang-dev libkeyutils1 zlib1g-dev file libxml2-dev libxrender1 flex sgml-base ucf libevent-core-1.4-2 libev3 libsnmp-dev mime-support uuid-dev libpng12-0 libkadm5clnt-mit7 libjpeg62 libgeoip1 libperl5.10 libconfuse0 libpq-dev libkadm5srv-mit7 liblua5.1-0 libsqlite3-dev x11-common sgml-data libx11-6 libsasl2-2 libpq5 man-db libpcre3-dev libfontconfig1 html2text openssl libev-dev libsm6 libkdb5-4 libqt3-mt libgeoip-dev libxmlrpc-c3 libevent-extra-1.4-2 krb5-multidev libevent-dev libgssapi-krb5-2 libxi6 libaudio2 libxcursor1 libxt6 libltdl-dev libxext6 libsasl2-modules mysql-common libxrandr2 ca-certificates libmng1 libmemcached5 unixodbc-dev libsensors4-dev libsasl2-dev libltdl7 libmagic1 libgpg-error0 erlang-base libldap2-dev libreadline-dev Do you want to ignore this warning and proceed anyway? To continue, enter "Yes"; to abort, enter "No": Abort. E: pbuilder-satisfydepends failed. I: Copying back the cached apt archive contents I: unmounting /tmp/apt-jdg_kDNY0m filesystem I: unmounting dev/pts filesystem I: unmounting run/shm filesystem I: unmounting proc filesystem -> Cleaning COW directory forking: rm -rf /var/cache/pbuilder/build//cow.23949 + '[' 1 -eq 0 ']' + bailout 1 'Error: Failed to build with cowbuilder.' + '[' -n 1 ']' + EXIT=1 + '[' -n 'Error: Failed to build with cowbuilder.' ']' + echo 'Error: Failed to build with cowbuilder.' Error: Failed to build with cowbuilder. + rm -f /var/run/lock/squeeze-amd64.building.16309 + '[' -r /var/run/lock/squeeze-amd64.update.16309 ']' + '[' '' = true ']' + echo '*** Getting rid of files in <https://kamailio.sipwise.com/job/kamailio44-nightly-binaries/architecture=a…> to avoid problems in next run. ***' *** Getting rid of files in <https://kamailio.sipwise.com/job/kamailio44-nightly-binaries/architecture=a…> to avoid problems in next run. *** + rm -f '<https://kamailio.sipwise.com/job/kamailio44-nightly-binaries/architecture=a…'> + '[' -n /tmp/tmp.3UgvqGiG9D ']' + rm -rf /tmp/tmp.3UgvqGiG9D + '[' -n /tmp/apt-jdg_kDNY0m ']' + sudo rm -rf /tmp/apt-jdg_kDNY0m + '[' -n 12447 ']' ++ sed -e 's/^$[0-9]*$.*/\1/' + SECONDS=23 ++ date + echo '*** Finished execution of /usr/bin/build-and-provide-package at Tue Oct 30 04:27:00 UTC 2018 [running 23 seconds] ***' *** Finished execution of /usr/bin/build-and-provide-package at Tue Oct 30 04:27:00 UTC 2018 [running 23 seconds] *** + exit 1 Build step 'Execute shell' marked build as failure Archiving artifacts Recording fingerprints TAP Reports Processing: START Looking for TAP results report in workspace using pattern: report/*.tap Did not find any matching files. Recording test results ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error?

6 years, 1 month

[kamailio/kamailio] usrloc: call contact expired call back for a domain with db_mode: DB_ONLY (#1683)

by adil-mafzool

usrloc: call contact expired call back for a domain with db_mode: DB_ONLY; database rows are removed by the timer function: db_timer_udomain   #### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Currently call contact expired call back for a domain with db_mode: DB_ONLY doesn't callback function for "usrloc:contact-expired" to carry out call back application actions since database rows are removed by the timer function: db_timer_udomain. There is addition of new function udomain_contact_expired_cb which will only call the call back function when contact are being removed from the database. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1683 -- Commit Summary -- * usrloc: call contact expired call back for a domain with db_mode: DB_ONLY -- File Changes -- M src/modules/usrloc/udomain.c (172) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1683.patch https://github.com/kamailio/kamailio/pull/1683.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1683

6 years, 1 month

git:master:9757bb8c: usrloc: call contact expired call back for a domain with db_mode: DB_ONLY (#1683)

by Henning Westerholt

Module: kamailio Branch: master Commit: 9757bb8c0e2fea5173f4fa3dd7798d61759f04af URL: https://github.com/kamailio/kamailio/commit/9757bb8c0e2fea5173f4fa3dd7798d6… Author: adil-mafzool <36664780+adil-mafzool(a)users.noreply.github.com> Committer: Henning Westerholt <henningw(a)users.noreply.github.com> Date: 2018-10-30T21:23:23+01:00 usrloc: call contact expired call back for a domain with db_mode: DB_ONLY (#1683) * usrloc: call contact expired call back for a domain with db_mode: DB_ONLY * usrloc: only execute funtion udomain_contact_expired_cb when db_mode is set as DB_ONLY * usrloc: removed redundant function call mem_insert_urecord from udomain_contact_expired_cb --- Modified: src/modules/usrloc/udomain.c --- Diff: https://github.com/kamailio/kamailio/commit/9757bb8c0e2fea5173f4fa3dd7798d6… Patch: https://github.com/kamailio/kamailio/commit/9757bb8c0e2fea5173f4fa3dd7798d6…

6 years, 1 month

[kamailio/kamailio] pdb: fix SIGABRT in case of too long uris (#1693)

by Lucian Balaceanu

buf in pdb_msg_dbg should correctly accomodate for pdb_bdy size pdb_hdr + pdb_bdy should add to pdb_hdr.length (max 255)   #### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x ] PR should be backported to stable branches - [x ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Can I also port this back to 4.4? Thank you. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1693 -- Commit Summary -- * pdb: fix SIGABRT in case of too long uris -- File Changes -- M src/modules/pdb/common.h (3) M src/modules/pdb/pdb.c (5) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1693.patch https://github.com/kamailio/kamailio/pull/1693.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1693

6 years, 1 month

git:4.4:77706a1f: pdb: fix SIGABRT in case of too long uris

by Lucian Balaceanu

Module: kamailio Branch: 4.4 Commit: 77706a1f45ce83e43c04883a230a41d0a10b70d1 URL: https://github.com/kamailio/kamailio/commit/77706a1f45ce83e43c04883a230a41d… Author: Lucian Balaceanu <lucian.balaceanu(a)1and1.ro> Committer: Lucian Balaceanu <lucian.balaceanu(a)1and1.ro> Date: 2018-10-30T10:44:11+02:00 pdb: fix SIGABRT in case of too long uris kudos for this one go to Verena Kahmann buf in pdb_msg_dbg should correctly accomodate for pdb_bdy size pdb_hdr + pdb_bdy should add to pdb_hdr.length (max 255) --- Modified: modules/pdb/common.h Modified: modules/pdb/pdb.c --- Diff: https://github.com/kamailio/kamailio/commit/77706a1f45ce83e43c04883a230a41d… Patch: https://github.com/kamailio/kamailio/commit/77706a1f45ce83e43c04883a230a41d… --- diff --git a/modules/pdb/common.h b/modules/pdb/common.h index cd4932958b..026c8bc488 100644 --- a/modules/pdb/common.h +++ b/modules/pdb/common.h @@ -41,7 +41,8 @@ #define OTHER_CARRIERID 1000 #define MAX_CARRIERID 1000 #define NULL_CARRIERID -1001 -#define PAYLOADSIZE 256 +/* hdr size + PAYLOADSIZE must add to 255 (uint8_t pdb_hdr.length) */ +#define PAYLOADSIZE 249 #define IS_VALID_PDB_CARRIERID(id) ((id>=MIN_PDB_CARRIERID) && (id<=MAX_PDB_CARRIERID)) diff --git a/modules/pdb/pdb.c b/modules/pdb/pdb.c index 6feb3098c2..9ea05d34d6 100644 --- a/modules/pdb/pdb.c +++ b/modules/pdb/pdb.c @@ -160,7 +160,7 @@ static struct server_list_t *server_list; /* debug function for the new client <-> server protocol */ static void pdb_msg_dbg(struct pdb_msg msg, char *dbg_msg) { int i; - char buf[PAYLOADSIZE]; + char buf[PAYLOADSIZE*3+1]; char *ptr = buf; for (i = 0; i < msg.hdr.length - sizeof(msg.hdr); i++) { @@ -279,7 +279,7 @@ static int pdb_query(struct sip_msg *_msg, struct multiparam_t *_number, struct /* prepare request */ reqlen = number.len + 1; /* include null termination */ - if (reqlen > sizeof(struct pdb_bdy)) { + if (reqlen > PAYLOADSIZE) { LM_ERR("number too long '%.*s'.\n", number.len, number.s); return -1; } @@ -319,6 +319,7 @@ static int pdb_query(struct sip_msg *_msg, struct multiparam_t *_number, struct break; } + memset(&msg,0,sizeof(struct pdb_msg)); /* wait for response */ for (;;) { if (gettimeofday(&tnow, NULL) != 0) {

6 years, 1 month

git:master:e29c90ca: Merge pull request #1693 from lbalaceanu/pdb_fixabrt

by GitHub

Module: kamailio Branch: master Commit: e29c90ca1a7e604a3a86d508e4ac0c7b57f382e8 URL: https://github.com/kamailio/kamailio/commit/e29c90ca1a7e604a3a86d508e4ac0c7… Author: Lucian Balaceanu <lucian.balaceanu(a)1and1.ro> Committer: GitHub <noreply(a)github.com> Date: 2018-10-30T01:38:29-07:00 Merge pull request #1693 from lbalaceanu/pdb_fixabrt pdb: fix SIGABRT in case of too long uris --- Modified: src/modules/pdb/common.h Modified: src/modules/pdb/pdb.c --- Diff: https://github.com/kamailio/kamailio/commit/e29c90ca1a7e604a3a86d508e4ac0c7… Patch: https://github.com/kamailio/kamailio/commit/e29c90ca1a7e604a3a86d508e4ac0c7… --- diff --git a/src/modules/pdb/common.h b/src/modules/pdb/common.h index 1ba16cdf98..7c52c97ce0 100644 --- a/src/modules/pdb/common.h +++ b/src/modules/pdb/common.h @@ -35,7 +35,8 @@ #define OTHER_CARRIERID 1000 #define MAX_CARRIERID 1000 #define NULL_CARRIERID -1001 -#define PAYLOADSIZE 256 +/* hdr size + PAYLOADSIZE must add to 255 (uint8_t pdb_hdr.length) */ +#define PAYLOADSIZE 249 #define IS_VALID_PDB_CARRIERID(id) ((id>=MIN_PDB_CARRIERID) && (id<=MAX_PDB_CARRIERID)) diff --git a/src/modules/pdb/pdb.c b/src/modules/pdb/pdb.c index 8f2f80c326..eb59656734 100644 --- a/src/modules/pdb/pdb.c +++ b/src/modules/pdb/pdb.c @@ -145,7 +145,7 @@ static struct server_list_t *server_list; /* debug function for the new client <-> server protocol */ static void pdb_msg_dbg(struct pdb_msg msg, char *dbg_msg) { int i; - char buf[PAYLOADSIZE]; + char buf[PAYLOADSIZE * 3 + 1]; char *ptr = buf; for (i = 0; i < msg.hdr.length - sizeof(msg.hdr); i++) { @@ -265,7 +265,7 @@ static int pdb_query(struct sip_msg *_msg, struct multiparam_t *_number, struct /* prepare request */ reqlen = number.len + 1; /* include null termination */ - if (reqlen > sizeof(struct pdb_bdy)) { + if (reqlen > PAYLOADSIZE) { LM_ERR("number too long '%.*s'.\n", number.len, number.s); return -1; } @@ -305,6 +305,7 @@ static int pdb_query(struct sip_msg *_msg, struct multiparam_t *_number, struct break; } + memset(&msg, 0, sizeof(struct pdb_msg)); /* wait for response */ for (;;) { if (gettimeofday(&tnow, NULL) != 0) {

6 years, 1 month

← Newer
1
...
5
6
7
8
9
10
11
...
28
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2018