sr-dev October 2018

sr-dev@lists.kamailio.org

23 participants
274 discussions

compiler warning
by Juha Heinanen 02 Oct '18

02 Oct '18

Got this today with latest master: CC (gcc) [M sdpops.so] sdpops_mod.o sdpops_mod.c: In function 'sdp_get_sess_version': sdpops_mod.c:1871:14: warning: unused variable 'sdp' [-Wunused-variable] sdp_info_t *sdp = NULL; ^~~ It would be nice if people who make commits would try to compile the code first. -- Juha

3 5

git:master:1ff3185a: Makefile.defs: version set to 5.2.0-dev8
by Daniel-Constantin Mierla 02 Oct '18

02 Oct '18

Module: kamailio Branch: master Commit: 1ff3185a13247759fdb324eac9857981371aeda2 URL: https://github.com/kamailio/kamailio/commit/1ff3185a13247759fdb324eac985798… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-10-02T15:35:48+02:00 Makefile.defs: version set to 5.2.0-dev8 --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/1ff3185a13247759fdb324eac985798… Patch: https://github.com/kamailio/kamailio/commit/1ff3185a13247759fdb324eac985798… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index 784e2a510d..0832d6f7f0 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -107,7 +107,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) VERSION = 5 PATCHLEVEL = 2 SUBLEVEL = 0 -EXTRAVERSION = -dev7 +EXTRAVERSION = -dev8 # memory manager switcher # 0 - f_malloc (fast malloc)

1 0

git:master:d63548dc: Makefile.defs: enabled clang compile warning flags -Wunused-variable -Wuninitialized
by Daniel-Constantin Mierla 02 Oct '18

02 Oct '18

Module: kamailio Branch: master Commit: d63548dc311df5f2550e788fc026d9ec7c7dd2f4 URL: https://github.com/kamailio/kamailio/commit/d63548dc311df5f2550e788fc026d9e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-10-02T15:33:51+02:00 Makefile.defs: enabled clang compile warning flags -Wunused-variable -Wuninitialized --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/d63548dc311df5f2550e788fc026d9e… Patch: https://github.com/kamailio/kamailio/commit/d63548dc311df5f2550e788fc026d9e… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index dd12e6e60b..784e2a510d 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -1709,9 +1709,9 @@ else # no gcc ifeq ($(CC_NAME), icc) CFLAGS+= -Wall else # no icc -ifeq ($(CC_NAME), suncc) - # FIXME: is the default (-Xa ?) enough? -endif # CC_NAME=suncc +ifeq ($(CC_NAME), clang) + CFLAGS+= -Wunused-variable -Wuninitialized +endif # CC_NAME=clang endif # CC_NAME=icc endif # CC_NAME=gcc

1 0

git:master:afb7ef77: tm: safty checks when destroying the tm cell
by Daniel-Constantin Mierla 02 Oct '18

02 Oct '18

Module: kamailio Branch: master Commit: afb7ef77faab405a4da0c7f601f35358a1130238 URL: https://github.com/kamailio/kamailio/commit/afb7ef77faab405a4da0c7f601f3535… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-10-02T15:00:58+02:00 tm: safty checks when destroying the tm cell --- Modified: src/modules/tm/h_table.c --- Diff: https://github.com/kamailio/kamailio/commit/afb7ef77faab405a4da0c7f601f3535… Patch: https://github.com/kamailio/kamailio/commit/afb7ef77faab405a4da0c7f601f3535… --- diff --git a/src/modules/tm/h_table.c b/src/modules/tm/h_table.c index 4ca611e6ab..4b1f0233f7 100644 --- a/src/modules/tm/h_table.c +++ b/src/modules/tm/h_table.c @@ -132,6 +132,10 @@ void free_cell_helper( LM_DBG("freeing transaction %p from %s:%u\n", dead_cell, fname, fline); + if(dead_cell==NULL) { + return; + } + if(dead_cell->prev_c != NULL && dead_cell->next_c != NULL) { if(likely(silent == 0)) { LM_WARN("removed cell %p is still linked in hash table (%s:%u)\n", @@ -153,6 +157,10 @@ void free_cell_helper( if(dead_cell->fcount!=1) { LM_WARN("unexpected fcount value: %d\n", dead_cell->fcount); } + if(dead_cell->uac==NULL || dead_cell->uac!=T_UAC_PTR(dead_cell)) { + LM_WARN("unexpected tm cell content: %p\n", dead_cell); + return; + } if(unlikely(has_tran_tmcbs(dead_cell, TMCB_DESTROY))) run_trans_callbacks(TMCB_DESTROY, dead_cell, 0, 0, 0);

1 0

git:master:5485afbf: modules: readme files regenerated - peering ... [skip ci]
by Kamailio Dev 02 Oct '18

02 Oct '18

Module: kamailio Branch: master Commit: 5485afbf498dbacd6f0d1a32ec9629158abda62f URL: https://github.com/kamailio/kamailio/commit/5485afbf498dbacd6f0d1a32ec96291… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2018-10-02T12:31:39+02:00 modules: readme files regenerated - peering ... [skip ci] --- Modified: src/modules/peering/README --- Diff: https://github.com/kamailio/kamailio/commit/5485afbf498dbacd6f0d1a32ec96291… Patch: https://github.com/kamailio/kamailio/commit/5485afbf498dbacd6f0d1a32ec96291… --- diff --git a/src/modules/peering/README b/src/modules/peering/README index d06635c16a..0409021beb 100644 --- a/src/modules/peering/README +++ b/src/modules/peering/README @@ -69,6 +69,8 @@ Chapter 1. Admin Guide verify from a broker if source or destination of a SIP request is a trusted peer. + This module is obsolete and will be removed in the next release. + In order to participate in the trust community provided by a broker, each SIP provider registers the domains (host parts of SIP URIs) that they serve with the broker. When a SIP proxy of a provider needs to

1 0

git:master:7e1112ab: modules/peering: added a note that the module is obsolete
by Juha Heinanen 02 Oct '18

02 Oct '18

Module: kamailio Branch: master Commit: 7e1112abd6949600cfabb163466e1557e5baa296 URL: https://github.com/kamailio/kamailio/commit/7e1112abd6949600cfabb163466e155… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: 2018-10-02T13:22:31+03:00 modules/peering: added a note that the module is obsolete --- Modified: src/modules/peering/doc/peering_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/7e1112abd6949600cfabb163466e155… Patch: https://github.com/kamailio/kamailio/commit/7e1112abd6949600cfabb163466e155… --- diff --git a/src/modules/peering/doc/peering_admin.xml b/src/modules/peering/doc/peering_admin.xml index cbfdaac5aa..45be1aaf5a 100644 --- a/src/modules/peering/doc/peering_admin.xml +++ b/src/modules/peering/doc/peering_admin.xml @@ -17,9 +17,12 @@ <section> <title>Overview</title> <para>The peering module allows SIP providers (operators or organizations) - to verify from a broker if source or destination of a SIP request is a trusted peer. - </para> - <para> + to verify from a broker if source or destination of a SIP request is + a trusted peer. + </para> + <para>This module is obsolete and will be removed in the next release. + </para> + <para> In order to participate in the trust community provided by a broker, each SIP provider registers the domains (host parts of SIP URIs) that they serve with the broker. When a SIP proxy of a

1 0

git:master:8b02e9be: sdpops: removed unused variable
by Daniel-Constantin Mierla 02 Oct '18

02 Oct '18

Module: kamailio Branch: master Commit: 8b02e9be516f653734396decadcc9d2246f5a03e URL: https://github.com/kamailio/kamailio/commit/8b02e9be516f653734396decadcc9d2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-10-02T12:21:40+02:00 sdpops: removed unused variable --- Modified: src/modules/sdpops/sdpops_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/8b02e9be516f653734396decadcc9d2… Patch: https://github.com/kamailio/kamailio/commit/8b02e9be516f653734396decadcc9d2… --- diff --git a/src/modules/sdpops/sdpops_mod.c b/src/modules/sdpops/sdpops_mod.c index ffb4780c85..96951853b4 100644 --- a/src/modules/sdpops/sdpops_mod.c +++ b/src/modules/sdpops/sdpops_mod.c @@ -1868,7 +1868,6 @@ static int ki_sdp_get_line_startswith(sip_msg_t *msg, str *aname, str *sline) static int sdp_get_sess_version(sip_msg_t* msg, str* sess_version, int* sess_version_num) { - sdp_info_t *sdp = NULL; sdp_session_cell_t* sdp_session; int sdp_session_num;

1 0

git:master:cb984a53: tm: macro to define the ptr address for tm cell uac field
by Daniel-Constantin Mierla 02 Oct '18

02 Oct '18

Module: kamailio Branch: master Commit: cb984a53016762cb0932ed4dec4c75edb8997c0f URL: https://github.com/kamailio/kamailio/commit/cb984a53016762cb0932ed4dec4c75e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-10-02T12:21:40+02:00 tm: macro to define the ptr address for tm cell uac field --- Modified: src/modules/tm/h_table.c --- Diff: https://github.com/kamailio/kamailio/commit/cb984a53016762cb0932ed4dec4c75e… Patch: https://github.com/kamailio/kamailio/commit/cb984a53016762cb0932ed4dec4c75e… --- diff --git a/src/modules/tm/h_table.c b/src/modules/tm/h_table.c index d4c86db9b5..4ca611e6ab 100644 --- a/src/modules/tm/h_table.c +++ b/src/modules/tm/h_table.c @@ -48,6 +48,10 @@ #include "uac.h" /* free_local_ack */ +#define T_UAC_PTR(T) ((tm_ua_client_t*)((char*)T + sizeof(tm_cell_t) \ + + MD5_LEN - sizeof(((tm_cell_t*)0)->md5))) + + static enum kill_reason kr; /* pointer to the big table where all the transaction data lives */ @@ -337,9 +341,7 @@ struct cell *build_cell(struct sip_msg *p_msg) new_cell->uas.response.my_T = new_cell; init_rb_timers(&new_cell->uas.response); /* UAC */ - new_cell->uac = - (struct ua_client *)((char *)new_cell + sizeof(struct cell) - + MD5_LEN - sizeof(((struct cell *)0)->md5)); + new_cell->uac = T_UAC_PTR(new_cell); /* timers */ init_cell_timers(new_cell);

1 0

removal of unused modules
by Juha Heinanen 02 Oct '18

02 Oct '18

K nowadays has a large number of modules. Some of them may not anymore be in use by anybody and could be deleted. One example is peering module that I wrote in 2008 for a demo. I suspect that it has not been used since then. Perhaps we could issue a list of suspects and if then, if no one objects, remove them from 5.2? -- Juha

2 2

git:master:19e29ec3: modules: readme files regenerated - sdpops ... [skip ci]
by Kamailio Dev 02 Oct '18

02 Oct '18

Module: kamailio Branch: master Commit: 19e29ec302fc0d0d9ee3df6bbf6690223ef69323 URL: https://github.com/kamailio/kamailio/commit/19e29ec302fc0d0d9ee3df6bbf66902… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2018-10-02T12:01:31+02:00 modules: readme files regenerated - sdpops ... [skip ci] --- Modified: src/modules/sdpops/README --- Diff: https://github.com/kamailio/kamailio/commit/19e29ec302fc0d0d9ee3df6bbf66902… Patch: https://github.com/kamailio/kamailio/commit/19e29ec302fc0d0d9ee3df6bbf66902… --- diff --git a/src/modules/sdpops/README b/src/modules/sdpops/README index ce0e06ec2c..3c61b0cdc6 100644 --- a/src/modules/sdpops/README +++ b/src/modules/sdpops/README @@ -46,6 +46,10 @@ Daniel-Constantin Mierla 4.18. sdp_with_ice() 4.19. sdp_get_line_startswith(avpvar, string) + 5. Exported Variables + + 5.1. $sdp( ) + List of Examples 1.1. sdp_remove_codecs_by_id usage @@ -101,6 +105,10 @@ Chapter 1. Admin Guide 4.18. sdp_with_ice() 4.19. sdp_get_line_startswith(avpvar, string) + 5. Exported Variables + + 5.1. $sdp( ) + 1. Overview This module provides functions for checking and managing the SDP @@ -492,3 +500,18 @@ if(sdp_get_line_startswith("$avp(mline)", "m=")) { xlog("m-line: $avp(mline)\n"); } ... + +5. Exported Variables + + 5.1. $sdp( ) + +5.1. $sdp( ) + + Access to SDP attributes + * $sdp(body) - full SDP body (read only) + * $sdp(sess_version) - sess-version -attribute from SDP o= -line. + When set to special value -1, current value is incremented. (read + + write) + + Exported pseudo-variables are also documented at + https://www.kamailio.org/wiki/

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2018