sr-dev October 2018

sr-dev@lists.kamailio.org

23 participants
274 discussions

git:master:fb408fbd: pipelimit: execute timer routine per timer_interval
by Daniel-Constantin Mierla 17 Oct '18

17 Oct '18

Module: kamailio Branch: master Commit: fb408fbde981d86eb008e6a9dbcdd1f48dd9a9ee URL: https://github.com/kamailio/kamailio/commit/fb408fbde981d86eb008e6a9dbcdd1f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-10-17T08:51:50+02:00 pipelimit: execute timer routine per timer_interval - reported by GH #1675 and GH #1671 --- Modified: src/modules/pipelimit/pipelimit.c Modified: src/modules/pipelimit/pl_ht.c --- Diff: https://github.com/kamailio/kamailio/commit/fb408fbde981d86eb008e6a9dbcdd1f… Patch: https://github.com/kamailio/kamailio/commit/fb408fbde981d86eb008e6a9dbcdd1f… --- diff --git a/src/modules/pipelimit/pipelimit.c b/src/modules/pipelimit/pipelimit.c index 716938991a..c3cbf56103 100644 --- a/src/modules/pipelimit/pipelimit.c +++ b/src/modules/pipelimit/pipelimit.c @@ -64,7 +64,7 @@ MODULE_VERSION /* * timer interval length in seconds, tunable via modparam */ -#define PL_TIMER_INTERVAL 10 +#define PL_TIMER_INTERVAL_DEFAULT 10 /** SL API structure */ sl_api_t slb; @@ -85,10 +85,10 @@ static str pl_drop_reason = str_init("Server Unavailable"); static int pl_hash_size = 6; typedef struct pl_queue { - int * pipe; - int pipe_mp; - str * method; - str method_mp; + int *pipe; + int pipe_mp; + str *method; + str method_mp; } pl_queue_t; static struct timer_ln* pl_timer; @@ -107,7 +107,7 @@ static int load_source_mp = LOAD_SOURCE_CPU; static int * load_source; /* these only change in the mod_init() process -- no locking needed */ -static int timer_interval = PL_TIMER_INTERVAL; +static int pl_timer_interval = PL_TIMER_INTERVAL_DEFAULT; int _pl_cfg_setpoint; /* desired load, used when reading modparams */ /* === */ @@ -137,7 +137,7 @@ static cmd_export_t cmds[]={ {0,0,0,0,0,0} }; static param_export_t params[]={ - {"timer_interval", INT_PARAM, &timer_interval}, + {"timer_interval", INT_PARAM, &pl_timer_interval}, {"reply_code", INT_PARAM, &pl_drop_code}, {"reply_reason", PARAM_STR, &pl_drop_reason}, {"db_url", PARAM_STR, &pl_db_url}, @@ -346,7 +346,8 @@ static int mod_init(void) return -1; } timer_init(pl_timer, pl_timer_handle, 0, F_TIMER_FAST); - timer_add(pl_timer, MS_TO_TICKS(1000)); /* Start it after 1000ms */ + /* execute timer routine after pl_timer_interval * 1000ms */ + timer_add(pl_timer, pl_timer_interval * MS_TO_TICKS(1000)); /* bind the SL API */ if (sl_load_api(&slb)!=0) { @@ -723,7 +724,7 @@ static ticks_t pl_timer_handle(ticks_t ticks, struct timer_ln* tl, void* data) *network_load_value = get_total_bytes_waiting(); - pl_pipe_timer_update(timer_interval, *network_load_value); + pl_pipe_timer_update(pl_timer_interval, *network_load_value); return (ticks_t)(-1); /* periodical */ } diff --git a/src/modules/pipelimit/pl_ht.c b/src/modules/pipelimit/pl_ht.c index fa2c9c5ad0..518254f1fa 100644 --- a/src/modules/pipelimit/pl_ht.c +++ b/src/modules/pipelimit/pl_ht.c @@ -345,7 +345,7 @@ void pl_pipe_timer_update(int interval, int netload) if( it->algo == PIPE_ALGO_NETWORK ) { it->load = ( netload > it->limit ) ? 1 : -1; } else if (it->limit && interval) { - it->load = it->counter / (it->limit * interval); + it->load = it->counter / it->limit; } it->last_counter = it->counter; it->counter = 0;

1 0

[kamailio/kamailio] cfg_rpc updates changing variable values to large random numbers (#1583)
by vinesinha 16 Oct '18

16 Oct '18

I was trying to do a cfg_rpc update on a variable and some of the times, the variable would take on randomly large values or negative values. The -1 here is probably causing issues. https://github.com/kamailio/kamailio/blob/1d53ea3dba4e59b05b2e92ecc973c4415… Here's an explanation of what's going on (debugged using gdb). In cfg_struc.c if you put a breakpoint in the following line in cfg_clone_global https://github.com/kamailio/kamailio/blob/1d53ea3dba4e59b05b2e92ecc973c4415… checking variable values: ``` --- Old (correct) value --- (gdb) print sizeof(*(int *)(((unsigned char *)((*cfg_global)->vars + 984)) + 172)) $33 = 4 (gdb) print *((unsigned char *)&(*(int *)(((unsigned char *)((*cfg_global)->vars + 984)) + 172)) + 0) $34 = 99 'c' (gdb) print *((unsigned char *)&(*(int *)(((unsigned char *)((*cfg_global)->vars + 984)) + 172)) + 1) $35 = 0 '\000' (gdb) print *((unsigned char *)&(*(int *)(((unsigned char *)((*cfg_global)->vars + 984)) + 172)) + 2) $36 = 0 '\000' (gdb) print *((unsigned char *)&(*(int *)(((unsigned char *)((*cfg_global)->vars + 984)) + 172)) + 3) $37 = 0 '\000' --- new (corrupt) value --- (gdb) print sizeof(*(int *)(((unsigned char *)((block)->vars + 984)) + 172)) $28 = 4 (gdb) print *((unsigned char *)&(*(int *)(((unsigned char *)((block)->vars + 984)) + 172)) + 0) $29 = 99 'c' (gdb) print *((unsigned char *)&(*(int *)(((unsigned char *)((block)->vars + 984)) + 172)) + 1) $30 = 0 '\000' (gdb) print *((unsigned char *)&(*(int *)(((unsigned char *)((block)->vars + 984)) + 172)) + 2) $31 = 0 '\000' (gdb) print *((unsigned char *)&(*(int *)(((unsigned char *)((block)->vars + 984)) + 172)) + 3) $32 = 130 '\202' ``` As visible, the last byte is getting corrupted. I checked the memory allocation variables: ``` --> cfg_block_size (gdb) print cfg_block_size $2 = 1156 --> sizeof(cfg_block_t) print sizeof(cfg_block_t) $15 = 8 ``` This means that total memory assigned = 8 + 1156 -(1) = 1163 ``` --> address of new block (gdb) print (void *) block $12 = (void *) 0x7f63086b6758 --> address of the corrupted variable in the new block (gdb) print (void *)(((unsigned char *)((block)->vars + 984)) + 172) $13 = (void *) 0x7f63086b6be0 --> offset of the variable from the block start (gdb) print 0x7f63086b6be0 - 0x7f63086b6758 $14 = 1160 ``` since the variable is an integer, memory that should be assigned = 1160 + 4 = 1164 However, we're assigning 1163. Therefore the last byte is getting corrupted. Does it make sense to remove the -1 from all the memory allocation in cfg_struct ? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1583

2 26

git:master:73e3e5d1: siputils: fixed condition for alphanum matching
by Daniel-Constantin Mierla 16 Oct '18

16 Oct '18

Module: kamailio Branch: master Commit: 73e3e5d148c9eb74beb7432d9126abd1c5a8d7e7 URL: https://github.com/kamailio/kamailio/commit/73e3e5d148c9eb74beb7432d9126abd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-10-16T12:04:26+02:00 siputils: fixed condition for alphanum matching --- Modified: src/modules/siputils/checks.c --- Diff: https://github.com/kamailio/kamailio/commit/73e3e5d148c9eb74beb7432d9126abd… Patch: https://github.com/kamailio/kamailio/commit/73e3e5d148c9eb74beb7432d9126abd… --- diff --git a/src/modules/siputils/checks.c b/src/modules/siputils/checks.c index 76f5cac294..1db6901c4c 100644 --- a/src/modules/siputils/checks.c +++ b/src/modules/siputils/checks.c @@ -896,7 +896,7 @@ int ki_is_alphanum(sip_msg_t *msg, str *tval) for(; i<tval->len; i++) { if( !((tval->s[i]>='0' && tval->s[i]<='9') || (tval->s[i]>='A' && tval->s[i]<='Z') - || (tval->s[i]>='z' && tval->s[i]<='z')) ) + || (tval->s[i]>='a' && tval->s[i]<='z')) ) return -3; } @@ -935,7 +935,7 @@ int ki_is_alphanumex(sip_msg_t *msg, str *tval, str *eset) for(; i<tval->len; i++) { if( !((tval->s[i]>='0' && tval->s[i]<='9') || (tval->s[i]>='A' && tval->s[i]<='Z') - || (tval->s[i]>='z' && tval->s[i]<='z')) ) { + || (tval->s[i]>='a' && tval->s[i]<='z')) ) { if(eset==NULL || eset->len<=0) { return -3; }

1 0

git:master:f2f7b5a3: modules: readme files regenerated - siputils ... [skip ci]
by Kamailio Dev 16 Oct '18

16 Oct '18

Module: kamailio Branch: master Commit: f2f7b5a38bff33043cb6de1c4038364d3f5db77b URL: https://github.com/kamailio/kamailio/commit/f2f7b5a38bff33043cb6de1c4038364… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2018-10-16T12:01:40+02:00 modules: readme files regenerated - siputils ... [skip ci] --- Modified: src/modules/siputils/README --- Diff: https://github.com/kamailio/kamailio/commit/f2f7b5a38bff33043cb6de1c4038364… Patch: https://github.com/kamailio/kamailio/commit/f2f7b5a38bff33043cb6de1c4038364… --- diff --git a/src/modules/siputils/README b/src/modules/siputils/README index 32649f976f..390ef1b3cb 100644 --- a/src/modules/siputils/README +++ b/src/modules/siputils/README @@ -657,7 +657,7 @@ if (is_uri("$avp(i:705)") { if (is_tel_number("$rU")) { # Test if R-URI user is telephone number ... } -if (is_tel_number("+24242424") { +if (is_tel_number("+24242424")) { ... } ...

1 0

git:master:1d6b33a7: siputils: docs - added missing parenthesis in example
by Daniel-Constantin Mierla 16 Oct '18

16 Oct '18

Module: kamailio Branch: master Commit: 1d6b33a732ef225e28a367ca043b7e085a7f94f4 URL: https://github.com/kamailio/kamailio/commit/1d6b33a732ef225e28a367ca043b7e0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-10-16T11:45:51+02:00 siputils: docs - added missing parenthesis in example --- Modified: src/modules/siputils/doc/siputils_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/1d6b33a732ef225e28a367ca043b7e0… Patch: https://github.com/kamailio/kamailio/commit/1d6b33a732ef225e28a367ca043b7e0… --- diff --git a/src/modules/siputils/doc/siputils_admin.xml b/src/modules/siputils/doc/siputils_admin.xml index c022dd2dd1..a430f85cc9 100644 --- a/src/modules/siputils/doc/siputils_admin.xml +++ b/src/modules/siputils/doc/siputils_admin.xml @@ -654,7 +654,7 @@ if (is_uri("$avp(i:705)") { if (is_tel_number("$rU")) { # Test if R-URI user is telephone number ... } -if (is_tel_number("+24242424") { +if (is_tel_number("+24242424")) { ... } ...

1 0

[kamailio/kamailio] w_sanity_check(): input parameter (17895) outside of valid range <1-16384) (#1678)
by Rex 16 Oct '18

16 Oct '18

I am new to kamailio and I am trying to use docker to install the 5.1.6 version. I took the image from kamailio/kamailio:5.1.6-xenial and using a 5.7 mysql with it. Two services start fine, when I use sip client - linphone connect to it, it error with w_sanity_check(): input parameter (17895) outside of valid range <1-16384) without telling any reason. Can anyone help? Thanks kamailio.cfg ``` ####### Defined Values ######### #!define WITH_DEBUG #!define WITH_MYSQL #!define WITH_NAT #!define WITH_AUTH #!define WITH_ALIASDB #!define WITH_USRLOCDB #!define DBURL "mysql://kamailio:kamailiorw@tg-kamailio-db/kamailio" # *** Value defines - IDs used later in config ``` kamctlrc `````` # The Kamailio configuration file for the control tools. # # Here you can set variables used in the kamctl and kamdbctl setup # scripts. Per default all variables here are commented out, the control tools # will use their internal default values. ## your SIP domain SIP_DOMAIN=192.168.56.111 ## chrooted directory # $CHROOT_DIR="/path/to/chrooted/directory" ## database type: MYSQL, PGSQL, ORACLE, DB_BERKELEY, DBTEXT, or SQLITE # by default none is loaded # # If you want to setup a database with kamdbctl, you must at least specify # this parameter. DBENGINE=MYSQL ## database host DBHOST=tg-kamailio-db ## database host DBPORT=3306 ## database name (for ORACLE this is TNS name) DBNAME=kamailio # database path used by dbtext, db_berkeley or sqlite # DB_PATH="/usr/local/etc/kamailio/dbtext" ## database read/write user DBRWUSER="kamailio" ## password for database read/write user DBRWPW="kamailiorw" `````` Error Log ````` 2018-10-16T09:03:28.812832261Z 48(52) DEBUG: <core> [core/parser/msg_parser.c:604]: parse_msg(): SIP Request: 2018-10-16T09:03:28.823450876Z 48(52) DEBUG: <core> [core/parser/msg_parser.c:606]: parse_msg(): method: <REGISTER> 2018-10-16T09:03:28.823485491Z 48(52) DEBUG: <core> [core/parser/msg_parser.c:608]: parse_msg(): uri: <sip:192.168.56.111> 2018-10-16T09:03:28.823493873Z 48(52) DEBUG: <core> [core/parser/msg_parser.c:610]: parse_msg(): version: <SIP/2.0> 2018-10-16T09:03:28.823499328Z 48(52) DEBUG: <core> [core/parser/parse_via.c:1303]: parse_via_param(): Found param type 232, <branch> = <z9hG4bK.NszSAuWgI>; state=6 2018-10-16T09:03:28.823505373Z 48(52) DEBUG: <core> [core/parser/parse_via.c:1303]: parse_via_param(): Found param type 235, <rport> = <n/a>; state=17 2018-10-16T09:03:28.823510951Z 48(52) DEBUG: <core> [core/parser/parse_via.c:2639]: parse_via(): end of header reached, state=5 2018-10-16T09:03:28.823516043Z 48(52) DEBUG: <core> [core/parser/msg_parser.c:492]: parse_headers(): Via found, flags=2 2018-10-16T09:03:28.823520787Z 48(52) DEBUG: <core> [core/parser/msg_parser.c:494]: parse_headers(): this is the first via 2018-10-16T09:03:28.823525693Z 48(52) DEBUG: <core> [core/parser/parse_addr_spec.c:864]: parse_addr_spec(): end of header reached, state=10 2018-10-16T09:03:28.823530619Z 48(52) DEBUG: <core> [core/parser/msg_parser.c:171]: get_hdr_field(): <To> [32]; uri=[sip:rex@192.168.56.111] 2018-10-16T09:03:28.823536065Z 48(52) DEBUG: <core> [core/parser/msg_parser.c:172]: get_hdr_field(): to body ["rex" <sip:rex@192.168.56.111> 2018-10-16T09:03:28.823541562Z ] 2018-10-16T09:03:28.823546189Z 48(52) DEBUG: <core> [core/parser/msg_parser.c:152]: get_hdr_field(): cseq <CSeq>: <21> <REGISTER> 2018-10-16T09:03:28.823551761Z 48(52) DEBUG: <core> [core/receive.c:208]: receive_msg(): --- received sip message - request - call-id: [3D1vuRIhoP] - cseq: [21 REGISTER] 2018-10-16T09:03:28.823556553Z 48(52) DEBUG: <core> [core/parser/msg_parser.c:89]: get_hdr_field(): found end of header 2018-10-16T09:03:28.823561121Z {1 21 REGISTER 3D1vuRIhoP} 48(52) DEBUG: <core> [core/receive.c:256]: receive_msg(): preparing to run routing scripts... 2018-10-16T09:03:28.823581455Z {1 21 REGISTER 3D1vuRIhoP} 48(52) exec: *** cfgtrace:request_route=[DEFAULT_ROUTE] c=[/etc/kamailio/kamailio.cfg] l=467 a=5 n=route 2018-10-16T09:03:28.823594380Z {1 21 REGISTER 3D1vuRIhoP} 48(52) exec: *** cfgtrace:request_route=[REQINIT] c=[/etc/kamailio/kamailio.cfg] l=579 a=16 n=if 2018-10-16T09:03:28.823600865Z {1 21 REGISTER 3D1vuRIhoP} 48(52) exec: *** cfgtrace:request_route=[REQINIT] c=[/etc/kamailio/kamailio.cfg] l=584 a=16 n=if 2018-10-16T09:03:28.823606633Z {1 21 REGISTER 3D1vuRIhoP} 48(52) exec: *** cfgtrace:request_route=[REQINIT] c=[/etc/kamailio/kamailio.cfg] l=579 a=25 n=mf_process_maxfwd_header 2018-10-16T09:03:28.823611928Z {1 21 REGISTER 3D1vuRIhoP} 48(52) DEBUG: maxfwd [mf_funcs.c:74]: is_maxfwd_present(): value = 70 2018-10-16T09:03:28.823616365Z {1 21 REGISTER 3D1vuRIhoP} 48(52) exec: *** cfgtrace:request_route=[REQINIT] c=[/etc/kamailio/kamailio.cfg] l=589 a=16 n=if 2018-10-16T09:03:28.823620781Z {1 21 REGISTER 3D1vuRIhoP} 48(52) exec: *** cfgtrace:request_route=[REQINIT] c=[/etc/kamailio/kamailio.cfg] l=584 a=25 n=is_method 2018-10-16T09:03:28.823625526Z {1 21 REGISTER 3D1vuRIhoP} 48(52) exec: *** cfgtrace:request_route=[REQINIT] c=[/etc/kamailio/kamailio.cfg] l=593 a=16 n=if 2018-10-16T09:03:28.823630296Z {1 21 REGISTER 3D1vuRIhoP} 48(52) exec: *** cfgtrace:request_route=[REQINIT] c=[/etc/kamailio/kamailio.cfg] l=589 a=26 n=sanity_check 2018-10-16T09:03:28.823634999Z {1 21 REGISTER 3D1vuRIhoP} 48(52) ERROR: sanity [sanity_mod.c:227]: w_sanity_check(): input parameter (17895) outside of valid range <1-16384) 2018-10-16T09:03:28.823640158Z {1 21 REGISTER 3D1vuRIhoP} 48(52) exec: *** cfgtrace:request_route=[REQINIT] c=[/etc/kamailio/kamailio.cfg] l=590 a=25 n=xlog 2018-10-16T09:03:28.823645318Z {1 21 REGISTER 3D1vuRIhoP} 48(52) ERROR: <script>: Malformed SIP message from 10.255.0.2:5060 2018-10-16T09:03:28.823762609Z {1 21 REGISTER 3D1vuRIhoP} 48(52) exec: *** cfgtrace:request_route=[REQINIT] c=[/etc/kamailio/kamailio.cfg] l=591 a=2 n=exit 2018-10-16T09:03:28.823770707Z {1 21 REGISTER 3D1vuRIhoP} 48(52) DEBUG: <core> [core/receive.c:298]: receive_msg(): request-route executed in: 92 usec 2018-10-16T09:03:28.823776922Z {1 21 REGISTER 3D1vuRIhoP} 48(52) DEBUG: <core> [core/usr_avp.c:636]: destroy_avp_list(): destroying list (nil) 2018-10-16T09:03:28.823782492Z {1 21 REGISTER 3D1vuRIhoP} 48(52) DEBUG: <core> [core/usr_avp.c:636]: destroy_avp_list(): destroying list (nil) 2018-10-16T09:03:28.823787580Z {1 21 REGISTER 3D1vuRIhoP} 48(52) DEBUG: <core> [core/usr_avp.c:636]: destroy_avp_list(): destroying list (nil) 2018-10-16T09:03:28.823792062Z {1 21 REGISTER 3D1vuRIhoP} 48(52) DEBUG: <core> [core/usr_avp.c:636]: destroy_avp_list(): destroying list (nil) 2018-10-16T09:03:28.823806720Z {1 21 REGISTER 3D1vuRIhoP} 48(52) DEBUG: <core> [core/usr_avp.c:636]: destroy_avp_list(): destroying list (nil) 2018-10-16T09:03:28.823812531Z {1 21 REGISTER 3D1vuRIhoP} 48(52) DEBUG: <core> [core/usr_avp.c:636]: destroy_avp_list(): destroying list (nil) 2018-10-16T09:03:28.823817832Z {1 21 REGISTER 3D1vuRIhoP} 48(52) DEBUG: <core> [core/xavp.c:446]: xavp_destroy_list(): destroying xavp list (nil) 2018-10-16T09:03:28.823830768Z {1 21 REGISTER 3D1vuRIhoP} 48(52) DEBUG: <core> [core/receive.c:388]: receive_msg(): cleaning up `````` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1678

2 2

kamcli v1.1.0 released
by Daniel-Constantin Mierla 16 Oct '18

16 Oct '18

Hello, kamcli tool just got its first official release, a step forward in the process of packaging it. It is a command line tool that aims to be a modern alternative to the venerable kamctl, being written in Python and having already a large set of implemented sub-commands, such as: * subscriber – manage SIP subscribers * ul – manage user location records * address – manage permissions address records * aliasdb – manage database aliases * db – manage kamailio database content * dialog – manage active calls (dialog) * dialplan – manage dialplan records * dispatcher – manage load balancer (dispatcher) * group – manage group membership records (acl) * moni – continuous refresh of the values for a list of statistics * mtree – manage memory trees (mtree) * ps – print the details for kamailio running processes * rpc – interact with kamailio via jsonrpc control commands (alias of jsonrpc) * rpcmethods – return the list of available RPC methods (commands) * speeddial – manage speed dial records * srv – server management commands (sockets, aliases, …) * stats – get kamailio internal statistics * tls – management commands for TLS profiles and connections * uptime – print the uptime for kamailio instance The news article for this release is available at: * https://www.kamailio.org/w/2018/10/kamcli-v1-1-0-released/ The corresponding tag in the github repository being: * https://github.com/kamailio/kamcli/releases/tag/v1.1.0 How to install kamcli and examples of usage can be found at: * https://github.com/kamailio/kamcli/blob/v1.1/README.md Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio World Conference -- www.kamailioworld.com Kamailio Advanced Training, Nov 12-14, 2018, in Berlin -- www.asipto.com

1 0

git:master:5f872526: smsops: free allocated structure in case of error handling
by Daniel-Constantin Mierla 15 Oct '18

15 Oct '18

Module: kamailio Branch: master Commit: 5f872526a4927703f404a57b7ab774675e0fb2be URL: https://github.com/kamailio/kamailio/commit/5f872526a4927703f404a57b7ab7746… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-10-15T12:58:08+02:00 smsops: free allocated structure in case of error handling --- Modified: src/modules/smsops/smsops_impl.c --- Diff: https://github.com/kamailio/kamailio/commit/5f872526a4927703f404a57b7ab7746… Patch: https://github.com/kamailio/kamailio/commit/5f872526a4927703f404a57b7ab7746… --- diff --git a/src/modules/smsops/smsops_impl.c b/src/modules/smsops/smsops_impl.c index efc580759e..8150d081d6 100644 --- a/src/modules/smsops/smsops_impl.c +++ b/src/modules/smsops/smsops_impl.c @@ -564,6 +564,7 @@ int decode_3gpp_sms(struct sip_msg *msg) { // Check for malicious length, which might cause buffer overflow if(udh_read + ie->data.len + 2 /* two octets are read so far */ > udh_len) { + pkg_free(ie); LM_ERR("IE Lenght for IE id %d is bigger than the remaining User-Data element!\n", ie->identifier); return -1; @@ -571,6 +572,7 @@ int decode_3gpp_sms(struct sip_msg *msg) { if(ie->identifier == TP_UDH_IE_CONCAT_SM_8BIT_REF) { if(contains_8bit_refnum) { + pkg_free(ie); LM_ERR("IE Concatenated Short Message 8bit Reference occured more than once in UDH\n"); return -1; } @@ -584,6 +586,7 @@ int decode_3gpp_sms(struct sip_msg *msg) { else { /* Unsupported IE, save it as binary */ ie->data.s = pkg_malloc(ie->data.len); if(ie->data.s == NULL) { + pkg_free(ie); LM_ERR("no more pkg\n"); return -1; }

1 0

git:master:fb07b4cb: siputils: exported to kemi the functions to check alpha numeric values
by Daniel-Constantin Mierla 15 Oct '18

15 Oct '18

Module: kamailio Branch: master Commit: fb07b4cb9552a9caa7dea037d5dddbfdd5313990 URL: https://github.com/kamailio/kamailio/commit/fb07b4cb9552a9caa7dea037d5dddbf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-10-15T12:41:46+02:00 siputils: exported to kemi the functions to check alpha numeric values --- Modified: src/modules/siputils/checks.c Modified: src/modules/siputils/checks.h Modified: src/modules/siputils/siputils.c --- Diff: https://github.com/kamailio/kamailio/commit/fb07b4cb9552a9caa7dea037d5dddbf… Patch: https://github.com/kamailio/kamailio/commit/fb07b4cb9552a9caa7dea037d5dddbf…

1 0

git:master:48048b0e: kamctl: man page - note about prefixing number params with 's:' to enforce string
by Daniel-Constantin Mierla 15 Oct '18

15 Oct '18

Module: kamailio Branch: master Commit: 48048b0e372eabdde14460cb539b3e1ecbc13ae5 URL: https://github.com/kamailio/kamailio/commit/48048b0e372eabdde14460cb539b3e1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-10-15T12:20:23+02:00 kamctl: man page - note about prefixing number params with 's:' to enforce string --- Modified: utils/kamctl/kamctl.8 --- Diff: https://github.com/kamailio/kamailio/commit/48048b0e372eabdde14460cb539b3e1… Patch: https://github.com/kamailio/kamailio/commit/48048b0e372eabdde14460cb539b3e1… --- diff --git a/utils/kamctl/kamctl.8 b/utils/kamctl/kamctl.8 index d82f25dc42..83a09c1703 100644 --- a/utils/kamctl/kamctl.8 +++ b/utils/kamctl/kamctl.8 @@ -40,6 +40,10 @@ inside .B kamctlrc file. +.PP +For some commands, parameters can be prefixed with 's:' in order to enforce +string type (e.g., 's:123456789'). + .SH AUTHORS see

1 0

← Newer
1
...
12
13
14
15
16
17
18
...
28
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2018