sr-dev January 2018

sr-dev@lists.kamailio.org

35 participants
368 discussions

[kamailio/kamailio] Kamailio crashes with debug level > 2 and registering from certain SIP clients (#1403)
by mechanixza 18 Jan '18

18 Jan '18

### Description  When registering a soft client running on my Android phone (Grandstream Wave), Kamailio crashes every time when the client registers. When setting the debug level below 3 Kamailio does not crash. I have only found the problem with this SIP client. Others are working fine. ### Troubleshooting #### Reproduction  Set debug level greather than 2 and register the Grandstream Wave soft client from an Android phone. Kamailio then crashes. #### Log Messages  just before crashing I get the following message: 0(7819) ERROR: <core> [core/udp_server.c:484]: udp_rcv_loop(): print buffer building failed (10/16/4) ### Possible Solutions  The problem seems to come from non-printable characters sent by the SIP client causing Kamailio to crash. Changing line 482 in udp_server.c from l = snprintf(printbuf+j, 6, " %02X ", buf[i]); to l = snprintf(printbuf+j, 6, " %02X ", (unsigned char)buf[i]); fixes the problem. The compiler treats buf[i] as a signed integer and prepends 'FFFFFF' to the string making it longer than 6 characters. Casting buf[i] as an unsigned char prevents Kamailio from crashing. ### Additional Information * **Kamailio Version** - output of `kamailio -v` version: kamailio 5.1.0 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 5.3.1 * **Operating System**:  Ubuntu 16.04 (Xenial) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1403

3 5

git:master:219072f0: siptrace: use formatted print for addresses inside trace_onreq_out()
by Daniel-Constantin Mierla 18 Jan '18

18 Jan '18

Module: kamailio Branch: master Commit: 219072f0ef43eff1a5d4947f6fd71f2fd4fb7d1f URL: https://github.com/kamailio/kamailio/commit/219072f0ef43eff1a5d4947f6fd71f2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-01-18T17:40:42+01:00 siptrace: use formatted print for addresses inside trace_onreq_out() --- Modified: src/modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/219072f0ef43eff1a5d4947f6fd71f2… Patch: https://github.com/kamailio/kamailio/commit/219072f0ef43eff1a5d4947f6fd71f2… --- diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c index 3636a0929e..924c4f52e7 100644 --- a/src/modules/siptrace/siptrace.c +++ b/src/modules/siptrace/siptrace.c @@ -1093,12 +1093,16 @@ static void trace_onreq_out(struct cell *t, int type, struct tmcb_params *ps) sto.fromip = trace_local_ip; } else { if(dst == 0 || dst->send_sock == 0 || dst->send_sock->sock_str.s == 0) { - siptrace_copy_proto(msg->rcv.proto, sto.fromip_buff); - strcat(sto.fromip_buff, ip_addr2a(&msg->rcv.dst_ip)); - strcat(sto.fromip_buff, ":"); - strcat(sto.fromip_buff, int2str(msg->rcv.dst_port, NULL)); - sto.fromip.s = sto.fromip_buff; - sto.fromip.len = strlen(sto.fromip_buff); + sto.fromip.len = snprintf(sto.fromip_buff, SIPTRACE_ADDR_MAX, "%s:%s:%d", + siptrace_proto_name(msg->rcv.proto), + ip_addr2a(&msg->rcv.dst_ip), (int)msg->rcv.dst_port); + if(sto.fromip.len<0 || sto.fromip.len>=SIPTRACE_ADDR_MAX) { + LM_ERR("failed to format toip buffer (%d)\n", sto.fromip.len); + sto.fromip.s = SIPTRACE_ANYADDR; + sto.fromip.len = SIPTRACE_ANYADDR_LEN; + } else { + sto.fromip.s = sto.fromip_buff; + } } else { sto.fromip = dst->send_sock->sock_str; } @@ -1109,13 +1113,16 @@ static void trace_onreq_out(struct cell *t, int type, struct tmcb_params *ps) sto.toip.len = SIPTRACE_ANYADDR_LEN; } else { su2ip_addr(&to_ip, &dst->to); - siptrace_copy_proto(dst->proto, sto.toip_buff); - strcat(sto.toip_buff, ip_addr2a(&to_ip)); - strcat(sto.toip_buff, ":"); - strcat(sto.toip_buff, - int2str((unsigned long)su_getport(&dst->to), &len)); - sto.toip.s = sto.toip_buff; - sto.toip.len = strlen(sto.toip_buff); + sto.toip.len = snprintf(sto.toip_buff, SIPTRACE_ADDR_MAX, "%s:%s:%d", + siptrace_proto_name(dst->proto), + ip_addr2a(&to_ip), (int)su_getport(&dst->to)); + if(sto.toip.len<0 || sto.toip.len>=SIPTRACE_ADDR_MAX) { + LM_ERR("failed to format toip buffer (%d)\n", sto.toip.len); + sto.toip.s = SIPTRACE_ANYADDR; + sto.toip.len = SIPTRACE_ANYADDR_LEN; + } else { + sto.toip.s = sto.toip_buff; + } } sto.dir = "out";

1 0

git:5.1:d07ecc13: core: udp server - continue when failing to print debug with received chars
by Daniel-Constantin Mierla 17 Jan '18

17 Jan '18

Module: kamailio Branch: 5.1 Commit: d07ecc133d297adfc9a791f1d8eecf3e7250cbf7 URL: https://github.com/kamailio/kamailio/commit/d07ecc133d297adfc9a791f1d8eecf3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-01-17T22:49:58+01:00 core: udp server - continue when failing to print debug with received chars - reported by GH #1403 (cherry picked from commit 099e784a250581d0c124d6110d3953bfc0716930) --- Modified: src/core/udp_server.c --- Diff: https://github.com/kamailio/kamailio/commit/d07ecc133d297adfc9a791f1d8eecf3… Patch: https://github.com/kamailio/kamailio/commit/d07ecc133d297adfc9a791f1d8eecf3… --- diff --git a/src/core/udp_server.c b/src/core/udp_server.c index 3d54c5a9a6..def3ac1861 100644 --- a/src/core/udp_server.c +++ b/src/core/udp_server.c @@ -483,7 +483,7 @@ int udp_rcv_loop() if(l<0 || l>=6) { LM_ERR("print buffer building failed (%d/%d/%d)\n", l, j, i); - goto error; + continue; /* skip it */ } j += l; }

1 0

git:5.1:476a922a: core: udp server - cast printed debug chars to unsigned
by Daniel-Constantin Mierla 17 Jan '18

17 Jan '18

Module: kamailio Branch: 5.1 Commit: 476a922ad4d50b05a95e43c20c4a2b8b6a98a78f URL: https://github.com/kamailio/kamailio/commit/476a922ad4d50b05a95e43c20c4a2b8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-01-17T22:49:45+01:00 core: udp server - cast printed debug chars to unsigned - reported by GH #1403 (cherry picked from commit 64a391a2408b1d34569947f8b028915ec3462e6d) --- Modified: src/core/udp_server.c --- Diff: https://github.com/kamailio/kamailio/commit/476a922ad4d50b05a95e43c20c4a2b8… Patch: https://github.com/kamailio/kamailio/commit/476a922ad4d50b05a95e43c20c4a2b8… --- diff --git a/src/core/udp_server.c b/src/core/udp_server.c index b88d3d8f51..3d54c5a9a6 100644 --- a/src/core/udp_server.c +++ b/src/core/udp_server.c @@ -479,7 +479,7 @@ int udp_rcv_loop() if(isprint(buf[i])) { printbuf[j++] = buf[i]; } else { - l = snprintf(printbuf+j, 6, " %02X ", buf[i]); + l = snprintf(printbuf+j, 6, " %02X ", (unsigned char)buf[i]); if(l<0 || l>=6) { LM_ERR("print buffer building failed (%d/%d/%d)\n", l, j, i);

1 0

git:master:099e784a: core: udp server - continue when failing to print debug with received chars
by Daniel-Constantin Mierla 17 Jan '18

17 Jan '18

Module: kamailio Branch: master Commit: 099e784a250581d0c124d6110d3953bfc0716930 URL: https://github.com/kamailio/kamailio/commit/099e784a250581d0c124d6110d3953b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-01-17T22:48:11+01:00 core: udp server - continue when failing to print debug with received chars - reported by GH #1403 --- Modified: src/core/udp_server.c --- Diff: https://github.com/kamailio/kamailio/commit/099e784a250581d0c124d6110d3953b… Patch: https://github.com/kamailio/kamailio/commit/099e784a250581d0c124d6110d3953b… --- diff --git a/src/core/udp_server.c b/src/core/udp_server.c index 3d54c5a9a6..def3ac1861 100644 --- a/src/core/udp_server.c +++ b/src/core/udp_server.c @@ -483,7 +483,7 @@ int udp_rcv_loop() if(l<0 || l>=6) { LM_ERR("print buffer building failed (%d/%d/%d)\n", l, j, i); - goto error; + continue; /* skip it */ } j += l; }

1 0

git:master:64a391a2: core: udp server - cast printed debug chars to unsigned
by Daniel-Constantin Mierla 17 Jan '18

17 Jan '18

Module: kamailio Branch: master Commit: 64a391a2408b1d34569947f8b028915ec3462e6d URL: https://github.com/kamailio/kamailio/commit/64a391a2408b1d34569947f8b028915… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-01-17T22:37:10+01:00 core: udp server - cast printed debug chars to unsigned - reported by GH #1403 --- Modified: src/core/udp_server.c --- Diff: https://github.com/kamailio/kamailio/commit/64a391a2408b1d34569947f8b028915… Patch: https://github.com/kamailio/kamailio/commit/64a391a2408b1d34569947f8b028915… --- diff --git a/src/core/udp_server.c b/src/core/udp_server.c index b88d3d8f51..3d54c5a9a6 100644 --- a/src/core/udp_server.c +++ b/src/core/udp_server.c @@ -479,7 +479,7 @@ int udp_rcv_loop() if(isprint(buf[i])) { printbuf[j++] = buf[i]; } else { - l = snprintf(printbuf+j, 6, " %02X ", buf[i]); + l = snprintf(printbuf+j, 6, " %02X ", (unsigned char)buf[i]); if(l<0 || l>=6) { LM_ERR("print buffer building failed (%d/%d/%d)\n", l, j, i);

1 0

git:master:74c9f53a: exec: more info in log messages when uri parsing fails
by Daniel-Constantin Mierla 17 Jan '18

17 Jan '18

Module: kamailio Branch: master Commit: 74c9f53aa736b9d2581666a8a75bc685156447f4 URL: https://github.com/kamailio/kamailio/commit/74c9f53aa736b9d2581666a8a75bc68… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-01-17T22:23:35+01:00 exec: more info in log messages when uri parsing fails --- Modified: src/modules/exec/exec_hf.c --- Diff: https://github.com/kamailio/kamailio/commit/74c9f53aa736b9d2581666a8a75bc68… Patch: https://github.com/kamailio/kamailio/commit/74c9f53aa736b9d2581666a8a75bc68… --- diff --git a/src/modules/exec/exec_hf.c b/src/modules/exec/exec_hf.c index 9b5a54a955..5f79441e6a 100644 --- a/src/modules/exec/exec_hf.c +++ b/src/modules/exec/exec_hf.c @@ -78,9 +78,9 @@ static int insert_hf(struct hf_wrapper **list, struct hdr_field *hf) /* if it is OTHER, check name too */ if(hf->type == HDR_OTHER_T && (hf->name.len != i->u.hf->name.len - || strncasecmp(i->u.hf->name.s, hf->name.s, - hf->name.len) - != 0)) + || strncasecmp(i->u.hf->name.s, hf->name.s, + hf->name.len) + != 0)) continue; /* yes, we found a hf of same type */ w->next_same = i->next_same; @@ -472,14 +472,14 @@ static int append_fixed_vars(struct sip_msg *msg, struct hf_wrapper **list) } /* request URI */ uri = msg->new_uri.s && msg->new_uri.len ? &msg->new_uri - : &msg->first_line.u.request.uri; + : &msg->first_line.u.request.uri; if(!append_var(EV_RURI, uri->s, uri->len, list)) { LM_ERR("append_var URI failed\n"); return 0; } /* userpart of request URI */ if(parse_uri(uri->s, uri->len, &parsed_uri) < 0) { - LM_WARN("uri not parsed\n"); + LM_WARN("uri not parsed (%.*s)\n", uri->len, ZSW(uri->s)); } else { if(!append_var(EV_USER, parsed_uri.user.s, parsed_uri.user.len, list)) { LM_ERR("append_var USER failed\n"); @@ -488,18 +488,19 @@ static int append_fixed_vars(struct sip_msg *msg, struct hf_wrapper **list) } /* original URI */ if(!append_var(EV_ORURI, msg->first_line.u.request.uri.s, - msg->first_line.u.request.uri.len, list)) { + msg->first_line.u.request.uri.len, list)) { LM_ERR("append_var O-URI failed\n"); goto error; } /* userpart of request URI */ if(parse_uri(msg->first_line.u.request.uri.s, - msg->first_line.u.request.uri.len, &oparsed_uri) - < 0) { - LM_WARN("orig URI not parsed\n"); + msg->first_line.u.request.uri.len, &oparsed_uri) < 0) { + LM_WARN("orig URI not parsed (%.*s)\n", + msg->first_line.u.request.uri.len, + ZSW( msg->first_line.u.request.uri.s)); } else { if(!append_var( - EV_OUSER, oparsed_uri.user.s, oparsed_uri.user.len, list)) { + EV_OUSER, oparsed_uri.user.s, oparsed_uri.user.len, list)) { LM_ERR("append_var OUSER failed\n"); goto error; }

1 0

git:master:34ec1fc3: exec: clang format the code
by Daniel-Constantin Mierla 17 Jan '18

17 Jan '18

Module: kamailio Branch: master Commit: 34ec1fc381916ee2ce7b08afce413bf2aa427a55 URL: https://github.com/kamailio/kamailio/commit/34ec1fc381916ee2ce7b08afce413bf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-01-17T22:18:20+01:00 exec: clang format the code --- Modified: src/modules/exec/exec.c Modified: src/modules/exec/exec.h Modified: src/modules/exec/exec_hf.c Modified: src/modules/exec/exec_hf.h Modified: src/modules/exec/exec_mod.c Modified: src/modules/exec/kill.c Modified: src/modules/exec/kill.h --- Diff: https://github.com/kamailio/kamailio/commit/34ec1fc381916ee2ce7b08afce413bf… Patch: https://github.com/kamailio/kamailio/commit/34ec1fc381916ee2ce7b08afce413bf…

1 0

git:master:8a501f2b: exec: small typo in log message
by Daniel-Constantin Mierla 17 Jan '18

17 Jan '18

Module: kamailio Branch: master Commit: 8a501f2be2860b1bfd0b9a3d1f63d85f4654fd01 URL: https://github.com/kamailio/kamailio/commit/8a501f2be2860b1bfd0b9a3d1f63d85… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-01-17T15:05:59+01:00 exec: small typo in log message --- Modified: src/modules/exec/exec_hf.c --- Diff: https://github.com/kamailio/kamailio/commit/8a501f2be2860b1bfd0b9a3d1f63d85… Patch: https://github.com/kamailio/kamailio/commit/8a501f2be2860b1bfd0b9a3d1f63d85… --- diff --git a/src/modules/exec/exec_hf.c b/src/modules/exec/exec_hf.c index e8404216b3..db6d60da3e 100644 --- a/src/modules/exec/exec_hf.c +++ b/src/modules/exec/exec_hf.c @@ -483,7 +483,7 @@ static int append_fixed_vars(struct sip_msg *msg, struct hf_wrapper **list) } else { if (!append_var(EV_OUSER, oparsed_uri.user.s, oparsed_uri.user.len, list)) { - LM_ERR("ppend_var OUSER failed\n"); + LM_ERR("append_var OUSER failed\n"); goto error; } }

1 0

[kamailio/kamailio] Commande tm.t_uac_start issue (#1393)
by JuanPascual2 16 Jan '18

16 Jan '18

Commande tm._uac_start JsonRPC with Headers From, To and Fake works {"id":1,"jsonrpc":"2.0","method":"tm.t_uac_start","params":["REGISTER","sip:suio.com","sip:101.155.139.171:5060","udp:10.155.139.170:5064","From:sip:juan@sui.com\r\nTo:sip:juan@sui.com\r\nFake:hedear\r\n"]} { "jsonrpc": "2.0", "result": { }, "id": 1 } But commande tm.t_uac_start JsonRPC with only Headers From and To doesn't works {"id":1,"jsonrpc":"2.0","method":"tm.t_uac_start","params":["REGISTER","sip:suio.com","sip:101.155.139.171:5060","udp:10.155.139.170:5064","From:sip:juan@sui.com\r\nTo:sip:juan@sui.com\r\n"]} { "jsonrpc": "2.0", "error": { "code": 500, "message": "out of memory" }, "id": 1 } On documentation module tm, only From and To headers are mandatories. 5. RPC Commands 5.1. tm.t_uac_start Generates and sends a local SIP request. Parameters: method - request method RURI - request SIP URI NEXT HOP - next hop SIP URI (OBP); use “.” if no value. socket - local socket to be used for sending the request; use “.” if no value. headers - set of additional headers to be added to the request; at least “From” and “To” headers must be provided) body - (optional, may not be present) request body (if present, requires the “Content-Type” and “Content-length” headers) Best regard Juan -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1393

2 4

← Newer
1
...
20
21
22
23
24
25
26
...
37
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2018