sr-dev August 2017

sr-dev@lists.kamailio.org

24 participants
306 discussions

git:master:57503311: carrierroute: check pointer before dereferencing it

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 57503311555f5ffcda1c4e3b05df4248558ef50b URL: https://github.com/kamailio/kamailio/commit/57503311555f5ffcda1c4e3b05df424… Author: Claudiu Boriga <paul.boriga(a)1and1.ro> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-01T10:36:01+02:00 carrierroute: check pointer before dereferencing it --- Modified: src/modules/carrierroute/cr_config.c --- Diff: https://github.com/kamailio/kamailio/commit/57503311555f5ffcda1c4e3b05df424… Patch: https://github.com/kamailio/kamailio/commit/57503311555f5ffcda1c4e3b05df424… --- diff --git a/src/modules/carrierroute/cr_config.c b/src/modules/carrierroute/cr_config.c index ba55eb8fba..2d1af1ecfe 100644 --- a/src/modules/carrierroute/cr_config.c +++ b/src/modules/carrierroute/cr_config.c @@ -250,14 +250,14 @@ int load_config(struct route_data_t * rd) { /* Create and insert carrier data structure */ tmp_carrier_data = create_carrier_data(1, &rd->carrier_map[0].name, allocated_domain_num); - tmp_carrier_data->domain_num = 0; - tmp_carrier_data->id = 1; - tmp_carrier_data->name = &(rd->carrier_map[0].name); - if (tmp_carrier_data == NULL) { LM_ERR("can't create new carrier\n"); goto errclose; } + tmp_carrier_data->domain_num = 0; + tmp_carrier_data->id = 1; + tmp_carrier_data->name = &(rd->carrier_map[0].name); + if (add_carrier_data(rd, tmp_carrier_data) < 0) { LM_ERR("couldn't add carrier data\n"); destroy_carrier_data(tmp_carrier_data);

7 years, 4 months

git:master:2fa71d29: carrierroute: avoid out-of-bounds access when resetting opts

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 2fa71d29d988cd396607fc20c6271703b3eb656f URL: https://github.com/kamailio/kamailio/commit/2fa71d29d988cd396607fc20c627170… Author: Claudiu Boriga <paul.boriga(a)1and1.ro> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-01T10:36:01+02:00 carrierroute: avoid out-of-bounds access when resetting opts --- Modified: src/modules/carrierroute/cr_config.c --- Diff: https://github.com/kamailio/kamailio/commit/2fa71d29d988cd396607fc20c627170… Patch: https://github.com/kamailio/kamailio/commit/2fa71d29d988cd396607fc20c627170…

7 years, 4 months

[kamailio/kamailio] Fix coverity issues in carrierroute module (#1199)

by Paul Claudiu Boriga

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Fix the following issues found by Coverity: 3c86d68 fixes defect [85605](https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId=… 7f603ec fixes defect [86015](https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId=… 2772f09 fixes defects [85807](https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId=… and [85651](https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId=… d8fdcb3 fixes defects [153773](https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId…, [85749](https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId=… and [85702](https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId=… 3a9365f fixes defects [85541](https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId=… and [85543](https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId=… dbafb5a fixes defect [85484](https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId=… 535eb88 fixes defect [155203](https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId… You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1199 -- Commit Summary -- * carrierroute: avoid out-of-bounds access when resetting opts * carrierroute: check pointer before dereferencing it * carrieroute: remove logically dead code * carrierroute: avoid comparing size_t types with negative values * carrierroute: check return value for fseek * carrierroute: avoid truncating value returned by fgetc * carrierroute: avoid ovverruning a fixed sized buffer -- File Changes -- M src/modules/carrierroute/cr_config.c (125) M src/modules/carrierroute/cr_db.c (6) M src/modules/carrierroute/cr_fifo.c (11) M src/modules/carrierroute/cr_func.c (14) M src/modules/carrierroute/parser_carrierroute.c (13) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1199.patch https://github.com/kamailio/kamailio/pull/1199.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1199

7 years, 4 months

[kamailio/kamailio] pkg/kamailio: Fix of ticket 1085 (#1087)

by sergey-safarov

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1087 -- Commit Summary -- * pkg/kamailio: Fix of ticket 1085 -- File Changes -- M pkg/kamailio/centos/7/kamailio.service (2) M pkg/kamailio/deb/debian/kamailio.service (2) M pkg/kamailio/deb/jessie/kamailio.service (2) M pkg/kamailio/deb/sid/kamailio.service (2) M pkg/kamailio/deb/stretch/kamailio.service (2) M pkg/kamailio/deb/xenial/kamailio.service (2) M pkg/kamailio/fedora/17/kamailio.service (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1087.patch https://github.com/kamailio/kamailio/pull/1087.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1087

7 years, 4 months

git:master:e5b8066e: pua_xmpp: init printbuf_len and detect when no uri is provided

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: e5b8066e1e0f4a69a5d1161dd75aea67014314b5 URL: https://github.com/kamailio/kamailio/commit/e5b8066e1e0f4a69a5d1161dd75aea6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-01T08:51:57+02:00 pua_xmpp: init printbuf_len and detect when no uri is provided --- Modified: src/modules/pua_xmpp/request_winfo.c --- Diff: https://github.com/kamailio/kamailio/commit/e5b8066e1e0f4a69a5d1161dd75aea6… Patch: https://github.com/kamailio/kamailio/commit/e5b8066e1e0f4a69a5d1161dd75aea6… --- diff --git a/src/modules/pua_xmpp/request_winfo.c b/src/modules/pua_xmpp/request_winfo.c index 65964350ae..a79bf1b79f 100644 --- a/src/modules/pua_xmpp/request_winfo.c +++ b/src/modules/pua_xmpp/request_winfo.c @@ -38,7 +38,7 @@ int request_winfo(struct sip_msg* msg, char* uri, char* expires) { subs_info_t subs; struct sip_uri puri; - int printbuf_len; + int printbuf_len = 0; char buffer[PRINTBUF_SIZE]; str uri_str; @@ -55,13 +55,12 @@ int request_winfo(struct sip_msg* msg, char* uri, char* expires) { LM_ERR("bad owner SIP address!\n"); goto error; - } else - { + } else { LM_DBG("using user id [%.*s]\n", printbuf_len, buffer); } } - if(puri.user.len<=0 || puri.user.s==NULL + if(printbuf_len == 0 || puri.user.len<=0 || puri.user.s==NULL || puri.host.len<=0 || puri.host.s==NULL) { LM_ERR("bad owner URI!\n");

7 years, 4 months

git:master:f359625b: pua_reginfo: init vars to avoid accessing invalid value on error

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: f359625bf671a38ec0aa967e2632a4bbdbfe59af URL: https://github.com/kamailio/kamailio/commit/f359625bf671a38ec0aa967e2632a4b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-08-01T08:51:57+02:00 pua_reginfo: init vars to avoid accessing invalid value on error --- Modified: src/modules/pua_reginfo/notify.c --- Diff: https://github.com/kamailio/kamailio/commit/f359625bf671a38ec0aa967e2632a4b… Patch: https://github.com/kamailio/kamailio/commit/f359625bf671a38ec0aa967e2632a4b… --- diff --git a/src/modules/pua_reginfo/notify.c b/src/modules/pua_reginfo/notify.c index 853dbcc878..754a2ed099 100644 --- a/src/modules/pua_reginfo/notify.c +++ b/src/modules/pua_reginfo/notify.c @@ -232,8 +232,8 @@ int process_body(str notify_body, udomain_t * domain) { char * expires_char, * cseq_char; int cseq = 0; int len; - urecord_t * ul_record; - ucontact_t * ul_contact; + urecord_t * ul_record = NULL; + ucontact_t * ul_contact = NULL; struct sip_uri parsed_aor; /* Temporary */

7 years, 4 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev August 2017