sr-dev June 2017

sr-dev@lists.kamailio.org

28 participants
389 discussions

git:5.0:826b3cab: topoh: documented uri_prefix_checks parameter

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.0 Commit: 826b3cab606fb51c7139fe81463aeb2409f40b67 URL: https://github.com/kamailio/kamailio/commit/826b3cab606fb51c7139fe81463aeb2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-06-25T10:14:52+02:00 topoh: documented uri_prefix_checks parameter (cherry picked from commit ca3f2fc6dd2c94410b225d2efb82081b828ddd01) --- Modified: src/modules/topoh/doc/topoh_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/826b3cab606fb51c7139fe81463aeb2… Patch: https://github.com/kamailio/kamailio/commit/826b3cab606fb51c7139fe81463aeb2… --- diff --git a/src/modules/topoh/doc/topoh_admin.xml b/src/modules/topoh/doc/topoh_admin.xml index 2d92f21e47..83850d277c 100644 --- a/src/modules/topoh/doc/topoh_admin.xml +++ b/src/modules/topoh/doc/topoh_admin.xml @@ -10,9 +10,9 @@  <chapter> - + <title>&adminguide;</title> - + <section> <title>Overview</title> <para> @@ -253,7 +253,34 @@ modparam("topoh", "sanity_checks", 1) </programlisting> </example> </section> - + <section> + <title><varname>uri_prefix_checks</varname> (integer)</title> + <para> + If set to 1, topoh module will check if URIs to be decoded match + the expected prefix composed from mask IP and parameter name prefix. + It can make the topoh processing safer by avoiding to try decoding + URIs which were not encoded previously by topoh. + </para> + <para> + Note: do not enable this option if you have SIP devices that can + alter the URI values it takes from Contact or Record-Route headers + (like adding port 5060 when no port is in received URIs, or + thet introduce new parameters at unknown position). + </para> + <para> + <emphasis> + Default value is 0. + </emphasis> + </para> + <example> + <title>Set <varname>uri_prefix_checks</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("topoh", "uri_prefix_checks", 1) +... +</programlisting> + </example> + </section> </section> </chapter>

7 years, 7 months

git:5.0:ee4c2a78: topoh: coherent whitespacing and indentation

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.0 Commit: ee4c2a7811552497fe0321fc92b2ecc68034cd44 URL: https://github.com/kamailio/kamailio/commit/ee4c2a7811552497fe0321fc92b2ecc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-06-25T10:12:25+02:00 topoh: coherent whitespacing and indentation (cherry picked from commit 66ab19a010f833a7c53f7f46de29a749609d5eef) --- Modified: src/modules/topoh/Makefile Modified: src/modules/topoh/api.h Modified: src/modules/topoh/doc/topoh.xml Modified: src/modules/topoh/th_mask.c Modified: src/modules/topoh/th_mask.h Modified: src/modules/topoh/th_msg.c --- Diff: https://github.com/kamailio/kamailio/commit/ee4c2a7811552497fe0321fc92b2ecc… Patch: https://github.com/kamailio/kamailio/commit/ee4c2a7811552497fe0321fc92b2ecc…

7 years, 7 months

git:5.0:a9d6ffa5: topoh: option to disable uri prefix checks

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.0 Commit: a9d6ffa5f39e048642bf14129b9b484250cce3ae URL: https://github.com/kamailio/kamailio/commit/a9d6ffa5f39e048642bf14129b9b484… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-06-25T10:10:58+02:00 topoh: option to disable uri prefix checks - some devices do not copy the exact URI as received in headers (Contact, Record-Route) - they can add default port or mix parameters - reported by GH #1165 (cherry picked from commit de3386e4a303adecc3eee809c05e0654b7a05065) --- Modified: src/modules/topoh/th_msg.c Modified: src/modules/topoh/topoh_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/a9d6ffa5f39e048642bf14129b9b484… Patch: https://github.com/kamailio/kamailio/commit/a9d6ffa5f39e048642bf14129b9b484… --- diff --git a/src/modules/topoh/th_msg.c b/src/modules/topoh/th_msg.c index a1f117e316..24bb32e185 100644 --- a/src/modules/topoh/th_msg.c +++ b/src/modules/topoh/th_msg.c @@ -57,6 +57,7 @@ extern str th_vparam_prefix; extern int th_param_mask_callid; extern int th_mask_addr_myself; +extern int th_uri_prefix_checks; int th_skip_rw(char *s, int len) { @@ -391,8 +392,8 @@ int th_unmask_via(sip_msg_t *msg, str *cookie) if(i!=1) { /* Skip if via is not encoded */ - if (via->host.len!=th_ip.len - || strncasecmp(via->host.s, th_ip.s, th_ip.len)!=0) + if (th_uri_prefix_checks && (via->host.len!=th_ip.len + || strncasecmp(via->host.s, th_ip.s, th_ip.len)!=0)) { LM_DBG("via %d is not encoded",i); continue; @@ -687,10 +688,13 @@ int th_unmask_route(sip_msg_t *msg) if(i!=1) { /* Skip if route is not encoded */ - if ((rr->nameaddr.uri.len<th_uri_prefix.len) || - (strncasecmp(rr->nameaddr.uri.s,th_uri_prefix.s,th_uri_prefix.len)!=0)) + if (th_uri_prefix_checks + && ((rr->nameaddr.uri.len<th_uri_prefix.len) || + (strncasecmp(rr->nameaddr.uri.s,th_uri_prefix.s, + th_uri_prefix.len)!=0))) { - LM_DBG("rr %d is not encoded: [%.*s]",i,rr->nameaddr.uri.len,rr->nameaddr.uri.s); + LM_DBG("rr %d is not encoded: [%.*s]", i, + rr->nameaddr.uri.len, rr->nameaddr.uri.s); rr = rr->next; continue; } @@ -736,8 +740,9 @@ int th_unmask_ruri(sip_msg_t *msg) str out; /* Do nothing if ruri is not encoded */ - if ((REQ_LINE(msg).uri.len<th_uri_prefix.len) || - (strncasecmp(REQ_LINE(msg).uri.s,th_uri_prefix.s,th_uri_prefix.len)!=0)) + if (th_uri_prefix_checks && ((REQ_LINE(msg).uri.len<th_uri_prefix.len) || + (strncasecmp(REQ_LINE(msg).uri.s, th_uri_prefix.s, + th_uri_prefix.len)!=0))) { LM_DBG("ruri [%.*s] is not encoded",REQ_LINE(msg).uri.len,REQ_LINE(msg).uri.s); return 0; @@ -798,8 +803,8 @@ int th_unmask_refer_to(sip_msg_t *msg) uri = &(get_refer_to(msg)->uri); /* Do nothing if refer_to is not encoded */ - if ((uri->len<th_uri_prefix.len) - || (strncasecmp(uri->s, th_uri_prefix.s, th_uri_prefix.len)!=0)) + if (th_uri_prefix_checks && ((uri->len<th_uri_prefix.len) + || (strncasecmp(uri->s, th_uri_prefix.s, th_uri_prefix.len)!=0))) { LM_DBG("refer-to [%.*s] is not encoded",uri->len,uri->s); return 0; diff --git a/src/modules/topoh/topoh_mod.c b/src/modules/topoh/topoh_mod.c index 5eb7490b85..4ff52f6e0a 100644 --- a/src/modules/topoh/topoh_mod.c +++ b/src/modules/topoh/topoh_mod.c @@ -74,11 +74,12 @@ str th_uri_prefix = {0, 0}; int th_param_mask_callid = 0; int th_sanity_checks = 0; -sanity_api_t scb; +int th_uri_prefix_checks = 0; int th_mask_addr_myself = 0; int th_msg_received(void *data); int th_msg_sent(void *data); +sanity_api_t scb; /** module functions */ static int mod_init(void); @@ -93,6 +94,7 @@ static param_export_t params[]={ {"vparam_prefix", PARAM_STR, &th_vparam_prefix}, {"callid_prefix", PARAM_STR, &th_callid_prefix}, {"sanity_checks", PARAM_INT, &th_sanity_checks}, + {"uri_prefix_checks", PARAM_INT, &th_uri_prefix_checks}, {0,0,0} };

7 years, 7 months

[kamailio/kamailio] incorrect ACK BYE packets routing with topoh enabled on kamailio 5.0.2 (#1165)

by Sergey Lavrov

### Description  After upgrading kamailio from 4.4.5 to 5.0.2 ACK/BYE packets are routed incorrectly. Instead of routing from KAMAILIO INT IP to SIP UAC #2 ACK/BYE packets are routed from KAMAILIO EXT IP to KAMAILIO INT IP. I attached two diagrams. First is from kamailio 4.4.5 with correct routing. Second is from kamailio 5.0.2 with wrong routing. One of improtant notice is when topoh module is disabled ACK/BYE packets are routed correctly on kamailio 5.0.2. Also in kamailio 5.0.2 DURI and RURI of ACK/BYE packets are populated not by Contact value of OK packet from SIP UA #2 but Record-Route value from OK packet. In kamailio 4.4.5 DURI is not populated at all and RURI is correct one. ### Troubleshooting #### SIP Traffic  SIP trace diagram from kamailio 4.4.5: http://imgur.com/5J95spW SIP trace diagram from kamailio 5.0.2: http://imgur.com/TDOGdgA  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 4.4.5 (x86_64/linux) f98162 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: f98162 compiled on 03:47:31 Feb 27 2017 with gcc 4.8.5 ``` * **Operating System**:  ``` Red Hat Enterprise Linux Server release 7.3 (Maipo) Linux 2.6.32-042stab113.21 #1 SMP Wed Mar 23 11:05:25 MSK 2016 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1165

7 years, 7 months

git:master:1b9e1f78: topoh: documented event_callback parameter

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 1b9e1f788d3c4c8ebaf81e252d07fe3200ca37e8 URL: https://github.com/kamailio/kamailio/commit/1b9e1f788d3c4c8ebaf81e252d07fe3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-06-25T10:04:53+02:00 topoh: documented event_callback parameter --- Modified: src/modules/topoh/doc/topoh_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/1b9e1f788d3c4c8ebaf81e252d07fe3… Patch: https://github.com/kamailio/kamailio/commit/1b9e1f788d3c4c8ebaf81e252d07fe3… --- diff --git a/src/modules/topoh/doc/topoh_admin.xml b/src/modules/topoh/doc/topoh_admin.xml index 0d8bda5bb1..f421f8ce64 100644 --- a/src/modules/topoh/doc/topoh_admin.xml +++ b/src/modules/topoh/doc/topoh_admin.xml @@ -281,6 +281,36 @@ modparam("topoh", "uri_prefix_checks", 1) </programlisting> </example> </section> + <section id="topoh.p.event_callback"> + <title><varname>event_callback</varname> (str)</title> + <para> + The name of the function in the KEMI configuration file (embedded + scripting language such as Lua, Python, ...) to be executed instead + of event_route[...] blocks. + </para> + <para> + The function receives a string parameter with the name of the event. + </para> + <para> + <emphasis> + Default value is 'empty' (no function is executed for events). + </emphasis> + </para> + <example> + <title>Set <varname>event_callback</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("topoh", "event_callback", "ksr_topoh_event") +... +-- event callback function implemented in Lua +function ksr_topoh_event(evname) + KSR.info("===== topoh module triggered event: " .. evname .. "\n"); + return 1; +end +... +</programlisting> + </example> + </section> </section> <section>

7 years, 7 months

git:master:ca3f2fc6: topoh: documented uri_prefix_checks parameter

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: ca3f2fc6dd2c94410b225d2efb82081b828ddd01 URL: https://github.com/kamailio/kamailio/commit/ca3f2fc6dd2c94410b225d2efb82081… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-06-25T10:00:01+02:00 topoh: documented uri_prefix_checks parameter --- Modified: src/modules/topoh/doc/topoh_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/ca3f2fc6dd2c94410b225d2efb82081… Patch: https://github.com/kamailio/kamailio/commit/ca3f2fc6dd2c94410b225d2efb82081… --- diff --git a/src/modules/topoh/doc/topoh_admin.xml b/src/modules/topoh/doc/topoh_admin.xml index c3366dd735..0d8bda5bb1 100644 --- a/src/modules/topoh/doc/topoh_admin.xml +++ b/src/modules/topoh/doc/topoh_admin.xml @@ -253,6 +253,34 @@ modparam("topoh", "sanity_checks", 1) </programlisting> </example> </section> + <section> + <title><varname>uri_prefix_checks</varname> (integer)</title> + <para> + If set to 1, topoh module will check if URIs to be decoded match + the expected prefix composed from mask IP and parameter name prefix. + It can make the topoh processing safer by avoiding to try decoding + URIs which were not encoded previously by topoh. + </para> + <para> + Note: do not enable this option if you have SIP devices that can + alter the URI values it takes from Contact or Record-Route headers + (like adding port 5060 when no port is in received URIs, or + thet introduce new parameters at unknown position). + </para> + <para> + <emphasis> + Default value is 0. + </emphasis> + </para> + <example> + <title>Set <varname>uri_prefix_checks</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("topoh", "uri_prefix_checks", 1) +... +</programlisting> + </example> + </section> </section> <section>

7 years, 7 months

git:master:66ab19a0: topoh: coherent whitespacing and indentation

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 66ab19a010f833a7c53f7f46de29a749609d5eef URL: https://github.com/kamailio/kamailio/commit/66ab19a010f833a7c53f7f46de29a74… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-06-25T09:54:09+02:00 topoh: coherent whitespacing and indentation --- Modified: src/modules/topoh/Makefile Modified: src/modules/topoh/api.h Modified: src/modules/topoh/doc/topoh.xml Modified: src/modules/topoh/th_mask.c Modified: src/modules/topoh/th_mask.h Modified: src/modules/topoh/th_msg.c --- Diff: https://github.com/kamailio/kamailio/commit/66ab19a010f833a7c53f7f46de29a74… Patch: https://github.com/kamailio/kamailio/commit/66ab19a010f833a7c53f7f46de29a74…

7 years, 7 months

git:master:de3386e4: topoh: option to disable uri prefix checks

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: de3386e4a303adecc3eee809c05e0654b7a05065 URL: https://github.com/kamailio/kamailio/commit/de3386e4a303adecc3eee809c05e065… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-06-25T09:48:26+02:00 topoh: option to disable uri prefix checks - some devices do not copy the exact URI as received in headers (Contact, Record-Route) - they can add default port or mix parameters - reported by GH #1165 --- Modified: src/modules/topoh/th_msg.c Modified: src/modules/topoh/topoh_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/de3386e4a303adecc3eee809c05e065… Patch: https://github.com/kamailio/kamailio/commit/de3386e4a303adecc3eee809c05e065… --- diff --git a/src/modules/topoh/th_msg.c b/src/modules/topoh/th_msg.c index a1f117e316..24bb32e185 100644 --- a/src/modules/topoh/th_msg.c +++ b/src/modules/topoh/th_msg.c @@ -57,6 +57,7 @@ extern str th_vparam_prefix; extern int th_param_mask_callid; extern int th_mask_addr_myself; +extern int th_uri_prefix_checks; int th_skip_rw(char *s, int len) { @@ -391,8 +392,8 @@ int th_unmask_via(sip_msg_t *msg, str *cookie) if(i!=1) { /* Skip if via is not encoded */ - if (via->host.len!=th_ip.len - || strncasecmp(via->host.s, th_ip.s, th_ip.len)!=0) + if (th_uri_prefix_checks && (via->host.len!=th_ip.len + || strncasecmp(via->host.s, th_ip.s, th_ip.len)!=0)) { LM_DBG("via %d is not encoded",i); continue; @@ -687,10 +688,13 @@ int th_unmask_route(sip_msg_t *msg) if(i!=1) { /* Skip if route is not encoded */ - if ((rr->nameaddr.uri.len<th_uri_prefix.len) || - (strncasecmp(rr->nameaddr.uri.s,th_uri_prefix.s,th_uri_prefix.len)!=0)) + if (th_uri_prefix_checks + && ((rr->nameaddr.uri.len<th_uri_prefix.len) || + (strncasecmp(rr->nameaddr.uri.s,th_uri_prefix.s, + th_uri_prefix.len)!=0))) { - LM_DBG("rr %d is not encoded: [%.*s]",i,rr->nameaddr.uri.len,rr->nameaddr.uri.s); + LM_DBG("rr %d is not encoded: [%.*s]", i, + rr->nameaddr.uri.len, rr->nameaddr.uri.s); rr = rr->next; continue; } @@ -736,8 +740,9 @@ int th_unmask_ruri(sip_msg_t *msg) str out; /* Do nothing if ruri is not encoded */ - if ((REQ_LINE(msg).uri.len<th_uri_prefix.len) || - (strncasecmp(REQ_LINE(msg).uri.s,th_uri_prefix.s,th_uri_prefix.len)!=0)) + if (th_uri_prefix_checks && ((REQ_LINE(msg).uri.len<th_uri_prefix.len) || + (strncasecmp(REQ_LINE(msg).uri.s, th_uri_prefix.s, + th_uri_prefix.len)!=0))) { LM_DBG("ruri [%.*s] is not encoded",REQ_LINE(msg).uri.len,REQ_LINE(msg).uri.s); return 0; @@ -798,8 +803,8 @@ int th_unmask_refer_to(sip_msg_t *msg) uri = &(get_refer_to(msg)->uri); /* Do nothing if refer_to is not encoded */ - if ((uri->len<th_uri_prefix.len) - || (strncasecmp(uri->s, th_uri_prefix.s, th_uri_prefix.len)!=0)) + if (th_uri_prefix_checks && ((uri->len<th_uri_prefix.len) + || (strncasecmp(uri->s, th_uri_prefix.s, th_uri_prefix.len)!=0))) { LM_DBG("refer-to [%.*s] is not encoded",uri->len,uri->s); return 0; diff --git a/src/modules/topoh/topoh_mod.c b/src/modules/topoh/topoh_mod.c index 91a1b7f29c..164087592a 100644 --- a/src/modules/topoh/topoh_mod.c +++ b/src/modules/topoh/topoh_mod.c @@ -77,9 +77,11 @@ str th_uri_prefix = {0, 0}; int th_param_mask_callid = 0; int th_sanity_checks = 0; -sanity_api_t scb; +int th_uri_prefix_checks = 0; int th_mask_addr_myself = 0; +sanity_api_t scb; + int th_msg_received(sr_event_param_t *evp); int th_msg_sent(sr_event_param_t *evp); int th_execute_event_route(sip_msg_t *msg, sr_event_param_t *evp); @@ -101,6 +103,7 @@ static param_export_t params[]={ {"vparam_prefix", PARAM_STR, &th_vparam_prefix}, {"callid_prefix", PARAM_STR, &th_callid_prefix}, {"sanity_checks", PARAM_INT, &th_sanity_checks}, + {"uri_prefix_checks", PARAM_INT, &th_uri_prefix_checks}, {"event_callback", PARAM_STR, &_th_eventrt_callback}, {0,0,0} };

7 years, 7 months

[kamailio/kamailio] wrong callback type after asynchronous SAR to HSS (distinct PSI) (#1160)

by christoph-v

### Description 1) I used kamailio as an scscf (based on the configuration files from kamailio/examples/scscf) 2) I did some changes according to my needs 3) I did some Basic tests - the results were satisfying --> OK 4) I configured a distinct PSI on the HSS (sip:04321234501@vict-ims.net) --> OK 5) I registered some user from a Zoiper Client --> OK 6) I told zoiper to call sip:04321234501@vict-ims.net --> I received 555 AS Contacting Failed - iFC terminated dialog ### Troubleshooting The SIP Response 555...... is misleading, in the WITH_DEBUG Logs we can see, the ims_isc module cannot deliver the INVITE message to the AS, because it "thinks", we are in an "on_failure" route, but the asynchronous SAR to the HSS was sent in an "request" route. File 2017_06_20_distinct_psi_03_scscf_kamailio.log: Line 642 - 660: Jun 20 16:14:12 vict-ims /usr/local/sbin/kamailio[108125]: INFO: ims_registrar_scscf [cxdx_avp.c:138]: cxdx_get_avp(): cxdx_get_experimental_result_code: Failed finding avp Jun 20 16:14:12 vict-ims /usr/local/sbin/kamailio[108125]: INFO: ims_registrar_scscf [cxdx_sar.c:84]: create_return_code(): created AVP successfully : [saa_return_code] - [1] Jun 20 16:14:12 vict-ims /usr/local/sbin/kamailio[108125]: ERROR: *** cfgtrace:failure_route=[UNREG_SAR_REPLY] c=[/usr/local/etc/kamailio-scscf/kamailio-scscf-routes.cfg] l=127 a=26 n=xlog Jun 20 16:14:12 vict-ims /usr/local/sbin/kamailio[108125]: ERROR: *** cfgtrace:failure_route=[UNREG_SAR_REPLY] c=[/usr/local/etc/kamailio-scscf/kamailio-scscf-routes.cfg] l=143 a=21 n=switch Jun 20 16:14:12 vict-ims /usr/local/sbin/kamailio[108125]: ERROR: *** cfgtrace:failure_route=[UNREG_SAR_REPLY] c=[/usr/local/etc/kamailio-scscf/kamailio-scscf-routes.cfg] l=130 a=26 n=xlog Jun 20 16:14:12 vict-ims /usr/local/sbin/kamailio[108125]: ERROR: *** cfgtrace:failure_route=[UNREG_SAR_REPLY] c=[/usr/local/etc/kamailio-scscf/kamailio-scscf-routes.cfg] l=131 a=5 n=route Jun 20 16:14:12 vict-ims /usr/local/sbin/kamailio[108125]: ERROR: *** cfgtrace:failure_route=[term] c=[/usr/local/etc/kamailio-scscf/kamailio-scscf-routes.cfg] l=673 a=26 n=xlog Jun 20 16:14:12 vict-ims /usr/local/sbin/kamailio[108125]: ERROR: *** cfgtrace:failure_route=[term] c=[/usr/local/etc/kamailio-scscf/kamailio-scscf-routes.cfg] l=675 a=24 n=t_newtran Jun 20 16:14:12 vict-ims /usr/local/sbin/kamailio[108125]: ERROR: tm [tm.c:1316]: w_t_newtran(): ERROR: t_newtran: transaction already in process 0x7ff2a6e66a58 Jun 20 16:14:12 vict-ims /usr/local/sbin/kamailio[108125]: ERROR: *** cfgtrace:failure_route=[term] c=[/usr/local/etc/kamailio-scscf/kamailio-scscf-routes.cfg] l=677 a=25 n=set_dlg_profile Jun 20 16:14:12 vict-ims /usr/local/sbin/kamailio[108125]: ERROR: *** cfgtrace:failure_route=[term] c=[/usr/local/etc/kamailio-scscf/kamailio-scscf-routes.cfg] l=692 a=16 n=if Jun 20 16:14:12 vict-ims /usr/local/sbin/kamailio[108125]: ERROR: *** cfgtrace:failure_route=[term] c=[/usr/local/etc/kamailio-scscf/kamailio-scscf-routes.cfg] l=685 a=25 n=is_method Jun 20 16:14:12 vict-ims /usr/local/sbin/kamailio[108125]: ERROR: *** cfgtrace:failure_route=[term] c=[/usr/local/etc/kamailio-scscf/kamailio-scscf-routes.cfg] l=686 a=63 n=assign Jun 20 16:14:12 vict-ims /usr/local/sbin/kamailio[108125]: ERROR: *** cfgtrace:failure_route=[term] c=[/usr/local/etc/kamailio-scscf/kamailio-scscf-routes.cfg] l=687 a=63 n=assign Jun 20 16:14:12 vict-ims /usr/local/sbin/kamailio[108125]: ERROR: *** cfgtrace:failure_route=[term] c=[/usr/local/etc/kamailio-scscf/kamailio-scscf-routes.cfg] l=688 a=24 n=record_route Jun 20 16:14:12 vict-ims /usr/local/sbin/kamailio[108125]: ERROR: *** cfgtrace:failure_route=[term] c=[/usr/local/etc/kamailio-scscf/kamailio-scscf-routes.cfg] l=698 a=16 n=if Jun 20 16:14:12 vict-ims /usr/local/sbin/kamailio[108125]: ERROR: *** cfgtrace:failure_route=[term] c=[/usr/local/etc/kamailio-scscf/kamailio-scscf-routes.cfg] l=692 a=26 n=isc_match_filter Jun 20 16:14:12 vict-ims /usr/local/sbin/kamailio[108125]: INFO: ims_isc [mod.c:233]: isc_match_filter(): Checking triggers Jun 20 16:14:12 vict-ims /usr/local/sbin/kamailio[108125]: CRITICAL: ims_isc [mod.c:284]: isc_match_filter(): SKIP: 0 Root cause must be found in TM module in file t_suspend.c in function t_continue(), where the type of the Routing block, that was suspended is written to the type of the new Routing block: line 214 - 229 /* which route block type were we in when we were suspended */ cb_type = FAILURE_CB_TYPE; switch (t->async_backup.backup_route) { case REQUEST_ROUTE: cb_type = **FAILURE_CB_TYPE**; <------------ this is the root cause, imho break; case FAILURE_ROUTE: cb_type = FAILURE_CB_TYPE; break; case TM_ONREPLY_ROUTE: cb_type = ONREPLY_CB_TYPE; break; case BRANCH_ROUTE: cb_type = FAILURE_CB_TYPE; break; } #### Reproduction I can help to reproduce the issue. mailto:christoph.valentin@kapsch.net Currently I have got an experimental test Setup using Zoiper Clients. After week 27 I should have simulated test cases to repeat the Scenario "per mouse-click" #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` [logs-tshark-routes_2017_06_21.zip](https://github.com/kamailio/kamailio/fil… ``` #### SIP Traffic  ``` [logs-tshark-routes_2017_06_21.zip](https://github.com/kamailio/kamailio/fil… ``` ### Possible Solutions  ### Additional Information ``` [root@vict-ims ~]# kamailio -v version: kamailio 4.4.5 (x86_64/linux) b0945e-dirty flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: b0945e -dirty compiled on 20:06:13 Jun 7 2017 with gcc 4.8.5 [root@vict-ims ~]# ``` * **Operating System**:  ``` [root@vict-ims ~]# uname -a Linux vict-ims 3.10.0-229.el7.x86_64 #1 SMP Thu Jan 29 18:37:38 EST 2015 x86_64 x86_64 x86_64 GNU/Linux [root@vict-ims ~]# ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1160

7 years, 7 months

git:master:da07cc8c: pv: coherent whitespacing and indentation for pv time code

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: da07cc8c724724d89dfe02bbe8a980f241afc582 URL: https://github.com/kamailio/kamailio/commit/da07cc8c724724d89dfe02bbe8a980f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-06-24T08:18:18+02:00 pv: coherent whitespacing and indentation for pv time code --- Modified: src/modules/pv/pv_time.c --- Diff: https://github.com/kamailio/kamailio/commit/da07cc8c724724d89dfe02bbe8a980f… Patch: https://github.com/kamailio/kamailio/commit/da07cc8c724724d89dfe02bbe8a980f… --- diff --git a/src/modules/pv/pv_time.c b/src/modules/pv/pv_time.c index 094b301d2d..4414b09ac9 100644 --- a/src/modules/pv/pv_time.c +++ b/src/modules/pv/pv_time.c @@ -13,8 +13,8 @@ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA * */ @@ -40,7 +40,7 @@ int pv_parse_time_name(pv_spec_p sp, str *in) switch(in->len) { - case 3: + case 3: if(strncmp(in->s, "sec", 3)==0) sp->pvp.pvn.u.isname.name.n = 0; else if(strncmp(in->s, "min", 3)==0) @@ -49,7 +49,7 @@ int pv_parse_time_name(pv_spec_p sp, str *in) sp->pvp.pvn.u.isname.name.n = 4; else goto error; break; - case 4: + case 4: if(strncmp(in->s, "hour", 4)==0) sp->pvp.pvn.u.isname.name.n = 2; else if(strncmp(in->s, "mday", 4)==0) @@ -62,7 +62,7 @@ int pv_parse_time_name(pv_spec_p sp, str *in) sp->pvp.pvn.u.isname.name.n = 7; else goto error; break; - case 5: + case 5: if(strncmp(in->s, "isdst", 5)==0) sp->pvp.pvn.u.isname.name.n = 8; else goto error; @@ -145,27 +145,31 @@ int get_time(struct sip_msg *msg, pv_param_t *param, switch(param->pvn.u.isname.name.n) { case 1: - return pv_get_uintval(msg, param, res, (unsigned int)_cfgutils_ts->tm_min); + return pv_get_uintval(msg, param, res, + (unsigned int)_cfgutils_ts->tm_min); case 2: - return pv_get_uintval(msg, param, res, (unsigned int)_cfgutils_ts->tm_hour); + return pv_get_uintval(msg, param, res, + (unsigned int)_cfgutils_ts->tm_hour); case 3: - return pv_get_uintval(msg, param, res, (unsigned int)_cfgutils_ts->tm_mday); + return pv_get_uintval(msg, param, res, + (unsigned int)_cfgutils_ts->tm_mday); case 4: - return pv_get_uintval(msg, param, res, + return pv_get_uintval(msg, param, res, (unsigned int)(_cfgutils_ts->tm_mon+1)); case 5: return pv_get_uintval(msg, param, res, (unsigned int)(_cfgutils_ts->tm_year+1900)); case 6: - return pv_get_uintval(msg, param, res, + return pv_get_uintval(msg, param, res, (unsigned int)(_cfgutils_ts->tm_wday+1)); case 7: - return pv_get_uintval(msg, param, res, + return pv_get_uintval(msg, param, res, (unsigned int)(_cfgutils_ts->tm_yday+1)); case 8: return pv_get_sintval(msg, param, res, _cfgutils_ts->tm_isdst); default: - return pv_get_uintval(msg, param, res, (unsigned int)_cfgutils_ts->tm_sec); + return pv_get_uintval(msg, param, res, + (unsigned int)_cfgutils_ts->tm_sec); } } @@ -243,7 +247,7 @@ int pv_get_timenowf(struct sip_msg *msg, pv_param_t *param, { str s; time_t t; - + t = time(NULL); s.s = ctime(&t); s.len = strlen(s.s)-1; @@ -265,12 +269,12 @@ int pv_get_timef(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) { str s; - + if(msg==NULL) return -1; msg_set_time(msg); - + s.s = ctime(&msg->tval.tv_sec); s.len = strlen(s.s)-1; return pv_get_strintval(msg, param, res, &s, (int)msg->tval.tv_sec); @@ -363,5 +367,3 @@ int pv_parse_timeval_name(pv_spec_p sp, str *in) LM_ERR("unknown PV timeval name %.*s\n", in->len, in->s); return -1; } - -

7 years, 7 months

← Newer
1
...
11
12
13
14
15
16
17
...
39
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2017