sr-dev May 2017

sr-dev@lists.kamailio.org

32 participants
298 discussions

git:master:ff3cf17f: core, sctp: check if IP_FREEBIND is defined
by Daniel-Constantin Mierla 02 May '17

02 May '17

Module: kamailio Branch: master Commit: ff3cf17ff3566cb08cb0a6b9f7f7d893cd908956 URL: https://github.com/kamailio/kamailio/commit/ff3cf17ff3566cb08cb0a6b9f7f7d89… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-05-02T10:37:41+02:00 core, sctp: check if IP_FREEBIND is defined - not all os-es have it --- Modified: src/core/tcp_main.c Modified: src/core/udp_server.c Modified: src/modules/sctp/sctp_server.c --- Diff: https://github.com/kamailio/kamailio/commit/ff3cf17ff3566cb08cb0a6b9f7f7d89… Patch: https://github.com/kamailio/kamailio/commit/ff3cf17ff3566cb08cb0a6b9f7f7d89… --- diff --git a/src/core/tcp_main.c b/src/core/tcp_main.c index b9af4e8..2b08967 100644 --- a/src/core/tcp_main.c +++ b/src/core/tcp_main.c @@ -2783,12 +2783,16 @@ int tcp_init(struct socket_info* sock_info) } } - /* Allow bind to non local address. Required when daemon started before network initialized */ +#if defined(IP_FREEBIND) + /* allow bind to non local address. + * useful when daemon started before network initialized */ if (setsockopt(sock_info->socket, IPPROTO_IP, IP_FREEBIND, (void*)&optval, sizeof(optval)) ==-1) { - LM_WARN("setsockopt freebind: %s\n", strerror(errno)); + LM_WARN("setsockopt freebind failed: %s\n", strerror(errno)); /* continue since this is not critical */ } +#endif + #ifdef HAVE_TCP_DEFER_ACCEPT /* linux only */ if ((optval=cfg_get(tcp, tcp_cfg, defer_accept))){ diff --git a/src/core/udp_server.c b/src/core/udp_server.c index 96ba8eb..2641fae 100644 --- a/src/core/udp_server.c +++ b/src/core/udp_server.c @@ -339,14 +339,16 @@ int udp_init(struct socket_info* sock_info) } #endif - /* Allow bind to non local address. Required when daemon started before network initialized */ +#if defined(IP_FREEBIND) + /* allow bind to non local address. + * useful when daemon started before network initialized */ optval = 1; if (setsockopt(sock_info->socket, IPPROTO_IP, IP_FREEBIND, (void*)&optval, sizeof(optval)) ==-1) { - LM_WARN("setsockopt freebind: %s\n", strerror(errno)); + LM_WARN("setsockopt freebind failed: %s\n", strerror(errno)); /* continue since this is not critical */ } - +#endif #ifdef USE_MCAST if ((sock_info->flags & SI_IS_MCAST) && (setup_mcast_rcvr(sock_info->socket, addr, sock_info->mcast.s)<0)){ diff --git a/src/modules/sctp/sctp_server.c b/src/modules/sctp/sctp_server.c index 686139c..5d5371a 100644 --- a/src/modules/sctp/sctp_server.c +++ b/src/modules/sctp/sctp_server.c @@ -468,14 +468,17 @@ static int sctp_init_sock_opt_common(int s, int af) /* continue since this is not critical */ } } - - /* Allow bind to non local address. Required when daemon started before network initialized */ + +#if defined(IP_FREEBIND) + /* allow bind to non local address. + * useful when daemon started before network initialized */ optval = 1; if (setsockopt(s, IPPROTO_IP, IP_FREEBIND, (void*)&optval, sizeof(optval)) ==-1) { - LM_WARN("sctp_init_sock_opt_common: setsockopt freebind %s\n", strerror(errno)); + LM_WARN("setsockopt freebind failed: %s\n", strerror(errno)); /* continue since this is not critical */ } +#endif /* set receive buffer: SO_RCVBUF*/ if (cfg_get(sctp, sctp_cfg, so_rcvbuf)){ @@ -487,7 +490,7 @@ static int sctp_init_sock_opt_common(int s, int af) /* continue, non-critical */ } } - + /* set send buffer: SO_SNDBUF */ if (cfg_get(sctp, sctp_cfg, so_sndbuf)){ optval=cfg_get(sctp, sctp_cfg, so_sndbuf);

1 0

git:master:1af9fe36: Merge pull request #1104 from sergey-safarov/FREEBIND
by GitHub 02 May '17

02 May '17

Module: kamailio Branch: master Commit: 1af9fe360780fbf723006f8e569d019788e5a2fa URL: https://github.com/kamailio/kamailio/commit/1af9fe360780fbf723006f8e569d019… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2017-05-02T10:24:30+02:00 Merge pull request #1104 from sergey-safarov/FREEBIND src/core: Added IP_FREEBIND flag durring socket initialization --- Modified: src/core/tcp_main.c Modified: src/core/udp_server.c Modified: src/modules/sctp/sctp_server.c --- Diff: https://github.com/kamailio/kamailio/commit/1af9fe360780fbf723006f8e569d019… Patch: https://github.com/kamailio/kamailio/commit/1af9fe360780fbf723006f8e569d019… --- diff --git a/src/core/tcp_main.c b/src/core/tcp_main.c index 14dcaea..b9af4e8 100644 --- a/src/core/tcp_main.c +++ b/src/core/tcp_main.c @@ -2782,6 +2782,13 @@ int tcp_init(struct socket_info* sock_info) /* continue since this is not critical */ } } + + /* Allow bind to non local address. Required when daemon started before network initialized */ + if (setsockopt(sock_info->socket, IPPROTO_IP, IP_FREEBIND, + (void*)&optval, sizeof(optval)) ==-1) { + LM_WARN("setsockopt freebind: %s\n", strerror(errno)); + /* continue since this is not critical */ + } #ifdef HAVE_TCP_DEFER_ACCEPT /* linux only */ if ((optval=cfg_get(tcp, tcp_cfg, defer_accept))){ diff --git a/src/core/udp_server.c b/src/core/udp_server.c index cff4ef0..96ba8eb 100644 --- a/src/core/udp_server.c +++ b/src/core/udp_server.c @@ -339,6 +339,14 @@ int udp_init(struct socket_info* sock_info) } #endif + /* Allow bind to non local address. Required when daemon started before network initialized */ + optval = 1; + if (setsockopt(sock_info->socket, IPPROTO_IP, IP_FREEBIND, + (void*)&optval, sizeof(optval)) ==-1) { + LM_WARN("setsockopt freebind: %s\n", strerror(errno)); + /* continue since this is not critical */ + } + #ifdef USE_MCAST if ((sock_info->flags & SI_IS_MCAST) && (setup_mcast_rcvr(sock_info->socket, addr, sock_info->mcast.s)<0)){ diff --git a/src/modules/sctp/sctp_server.c b/src/modules/sctp/sctp_server.c index e2301f0..686139c 100644 --- a/src/modules/sctp/sctp_server.c +++ b/src/modules/sctp/sctp_server.c @@ -469,6 +469,14 @@ static int sctp_init_sock_opt_common(int s, int af) } } + /* Allow bind to non local address. Required when daemon started before network initialized */ + optval = 1; + if (setsockopt(s, IPPROTO_IP, IP_FREEBIND, + (void*)&optval, sizeof(optval)) ==-1) { + LM_WARN("sctp_init_sock_opt_common: setsockopt freebind %s\n", strerror(errno)); + /* continue since this is not critical */ + } + /* set receive buffer: SO_RCVBUF*/ if (cfg_get(sctp, sctp_cfg, so_rcvbuf)){ optval=cfg_get(sctp, sctp_cfg, so_rcvbuf);

1 0

git:master:7036c0ea: src/core: Added IP_FREEBIND flag durring socket initialization
by Sergey Safarov 02 May '17

02 May '17

Module: kamailio Branch: master Commit: 7036c0ea947d6450e6a23c2e5b2428c834352de0 URL: https://github.com/kamailio/kamailio/commit/7036c0ea947d6450e6a23c2e5b2428c… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2017-04-29T15:33:03-04:00 src/core: Added IP_FREEBIND flag durring socket initialization --- Modified: src/core/tcp_main.c Modified: src/core/udp_server.c Modified: src/modules/sctp/sctp_server.c --- Diff: https://github.com/kamailio/kamailio/commit/7036c0ea947d6450e6a23c2e5b2428c… Patch: https://github.com/kamailio/kamailio/commit/7036c0ea947d6450e6a23c2e5b2428c… --- diff --git a/src/core/tcp_main.c b/src/core/tcp_main.c index 14dcaea..b9af4e8 100644 --- a/src/core/tcp_main.c +++ b/src/core/tcp_main.c @@ -2782,6 +2782,13 @@ int tcp_init(struct socket_info* sock_info) /* continue since this is not critical */ } } + + /* Allow bind to non local address. Required when daemon started before network initialized */ + if (setsockopt(sock_info->socket, IPPROTO_IP, IP_FREEBIND, + (void*)&optval, sizeof(optval)) ==-1) { + LM_WARN("setsockopt freebind: %s\n", strerror(errno)); + /* continue since this is not critical */ + } #ifdef HAVE_TCP_DEFER_ACCEPT /* linux only */ if ((optval=cfg_get(tcp, tcp_cfg, defer_accept))){ diff --git a/src/core/udp_server.c b/src/core/udp_server.c index cff4ef0..96ba8eb 100644 --- a/src/core/udp_server.c +++ b/src/core/udp_server.c @@ -339,6 +339,14 @@ int udp_init(struct socket_info* sock_info) } #endif + /* Allow bind to non local address. Required when daemon started before network initialized */ + optval = 1; + if (setsockopt(sock_info->socket, IPPROTO_IP, IP_FREEBIND, + (void*)&optval, sizeof(optval)) ==-1) { + LM_WARN("setsockopt freebind: %s\n", strerror(errno)); + /* continue since this is not critical */ + } + #ifdef USE_MCAST if ((sock_info->flags & SI_IS_MCAST) && (setup_mcast_rcvr(sock_info->socket, addr, sock_info->mcast.s)<0)){ diff --git a/src/modules/sctp/sctp_server.c b/src/modules/sctp/sctp_server.c index e2301f0..686139c 100644 --- a/src/modules/sctp/sctp_server.c +++ b/src/modules/sctp/sctp_server.c @@ -469,6 +469,14 @@ static int sctp_init_sock_opt_common(int s, int af) } } + /* Allow bind to non local address. Required when daemon started before network initialized */ + optval = 1; + if (setsockopt(s, IPPROTO_IP, IP_FREEBIND, + (void*)&optval, sizeof(optval)) ==-1) { + LM_WARN("sctp_init_sock_opt_common: setsockopt freebind %s\n", strerror(errno)); + /* continue since this is not critical */ + } + /* set receive buffer: SO_RCVBUF*/ if (cfg_get(sctp, sctp_cfg, so_rcvbuf)){ optval=cfg_get(sctp, sctp_cfg, so_rcvbuf);

1 0

possible memory leak in registrar module (xavp_rcd_helper)
by Luis Azedo 02 May '17

02 May '17

Hi, i'm investigating a possible memory leak in registrar module, namely in xavp_rcd_helper function. noticed an increase in shared memory allocated by core, removing the modparam("registrar", "xavp_rcd", "ulrcd") seems to fix this. [root@dev-01 kamailio]# kamcmd mod.stats core shm Module: core { xavp_new_value(94): 35704 ..... } [root@dev-01 kamailio]# kamcmd mod.stats core shm Module: core { xavp_new_value(94): 164064 .... } only one client registering every 60 sec. not sure if it keeps accumulating values in the xavp or if its leaking. however, a doubt came across. the lookup function is supposed to fill the xavp if configured, but the value seems to be related to the current process and afaik xavp are allocated in shared memory making it available to all processes. now, if two requests arrive at the same time and both do a lookup on the registrar, the xavp will potentially have the wrong value for one of the requests. what am i missing here ? Thanks

1 0

git:master:07ce768f: htable: Fix memory leak when reloading an empty htable from database
by Kristian HÃ¸gh 02 May '17

02 May '17

Module: kamailio Branch: master Commit: 07ce768fc6064867ed33d7ab6c9cbbb05db329db URL: https://github.com/kamailio/kamailio/commit/07ce768fc6064867ed33d7ab6c9cbbb… Author: Kristian HÃ¸gh <kfh(a)uni-tel.dk> Committer: Kristian HÃ¸gh <kfh(a)uni-tel.dk> Date: 2017-05-02T07:43:54+02:00 htable: Fix memory leak when reloading an empty htable from database --- Modified: src/modules/htable/ht_db.c --- Diff: https://github.com/kamailio/kamailio/commit/07ce768fc6064867ed33d7ab6c9cbbb… Patch: https://github.com/kamailio/kamailio/commit/07ce768fc6064867ed33d7ab6c9cbbb… --- diff --git a/src/modules/htable/ht_db.c b/src/modules/htable/ht_db.c index 83a9f01..fd5ec46 100644 --- a/src/modules/htable/ht_db.c +++ b/src/modules/htable/ht_db.c @@ -247,6 +247,7 @@ int ht_db_load_table(ht_t *ht, str *dbtable, int mode) } else { if(RES_ROW_N(db_res)==0) { + ht_dbf.free_result(ht_db_con, db_res); LM_DBG("Nothing to be loaded in hash table\n"); return 0; }

1 0

git:master:d09176e2: Merge pull request #1110 from khoegh/master
by GitHub 02 May '17

02 May '17

Module: kamailio Branch: master Commit: d09176e291a0b06ebd2ea386195a1968bffd4e1a URL: https://github.com/kamailio/kamailio/commit/d09176e291a0b06ebd2ea386195a196… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2017-05-02T10:17:11+02:00 Merge pull request #1110 from khoegh/master htable: Fix memory leak when reloading an empty htable from database --- Modified: src/modules/htable/ht_db.c --- Diff: https://github.com/kamailio/kamailio/commit/d09176e291a0b06ebd2ea386195a196… Patch: https://github.com/kamailio/kamailio/commit/d09176e291a0b06ebd2ea386195a196… --- diff --git a/src/modules/htable/ht_db.c b/src/modules/htable/ht_db.c index 83a9f01..fd5ec46 100644 --- a/src/modules/htable/ht_db.c +++ b/src/modules/htable/ht_db.c @@ -247,6 +247,7 @@ int ht_db_load_table(ht_t *ht, str *dbtable, int mode) } else { if(RES_ROW_N(db_res)==0) { + ht_dbf.free_result(ht_db_con, db_res); LM_DBG("Nothing to be loaded in hash table\n"); return 0; }

1 0

[kamailio/kamailio] htable: Fix memory leak when reloading an empty htable from database (#1110)
by Kristian Høgh 02 May '17

02 May '17

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1110 -- Commit Summary -- * htable: Fix memory leak when reloading an empty htable from database -- File Changes -- M src/modules/htable/ht_db.c (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1110.patch https://github.com/kamailio/kamailio/pull/1110.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1110

2 2

git: new commits in branch master
by Daniel-Constantin Mierla 02 May '17

02 May '17

- URL: https://github.com/kamailio/kamailio/commit/ae6367f4568a3775ff0c75a1a30c3f3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-05-01T08:08:59+02:00 pv: exported sbranch functions to kemi framework - URL: https://github.com/kamailio/kamailio/commit/b7baf05bd27aec0bfb606ff1ad43c01… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-05-01T08:08:59+02:00 registrar: add_sock_hdr() uses spve fixup - URL: https://github.com/kamailio/kamailio/commit/fe847cc0f567c38bf51d5a9bf28f654… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-05-01T08:08:59+02:00 registrar: extended docs about add_sock_hdr() - URL: https://github.com/kamailio/kamailio/commit/4f9143e6ce9e91165ac3916e6c142db… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-05-01T08:08:59+02:00 uac: uac_auth() and uac_req_send() exported to kemi framework - URL: https://github.com/kamailio/kamailio/commit/69353523a758a1823c0e9d52afe5d62… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-05-01T08:08:59+02:00 registrar: more functions exported to kemi framework - URL: https://github.com/kamailio/kamailio/commit/d88453f15d067a9e6cbc827b4dc6655… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-05-01T08:44:51+02:00 uac: exported replace from/to functions to kemi interface - URL: https://github.com/kamailio/kamailio/commit/7fb76f9c4f247a1b62609e6ff22a5ec… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-05-01T09:06:01+02:00 core: fixup helper functions for spve and pvar parameters - URL: https://github.com/kamailio/kamailio/commit/459f2e064789a86f6e278485ba6f5df… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-05-01T09:08:55+02:00 diversion: fixed error log message - URL: https://github.com/kamailio/kamailio/commit/f68bd70eb5e84515978a137a558d45c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-05-01T09:09:25+02:00 uac: uac_reg functions use spve and igp fixup helpers - URL: https://github.com/kamailio/kamailio/commit/c1677c39a1e6255aa01d623cc2cd556… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-05-01T09:14:27+02:00 registrar: fixed typo in reg_free_contacts() kemi exports - URL: https://github.com/kamailio/kamailio/commit/b8e64d95599bd2893900360644d5516… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-05-01T09:29:18+02:00 uac: exported uac_reg functions to kemi interface - URL: https://github.com/kamailio/kamailio/commit/8fc83e83cbe6f14dc89ad1b19c2a0c5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-05-01T22:20:32+02:00 sst: fix flag condtion in sst_check_min() - URL: https://github.com/kamailio/kamailio/commit/ee256fdd8b2c6a5ea42b703181af298… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-05-02T08:24:32+02:00 ss7ops: exported functions to kemi framework - URL: https://github.com/kamailio/kamailio/commit/f9ca87af6bef4d2dd4c3ec103e9bdcc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-05-02T08:25:10+02:00 sqlops: exported functions to kemi framework - URL: https://github.com/kamailio/kamailio/commit/0b9899a503db5080c56aeb372961df4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-05-02T08:25:37+02:00 dialog: exported dlg flags functions to kemi framework - URL: https://github.com/kamailio/kamailio/commit/f335900ae40fe1552dc2fa85953f991… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-05-02T08:26:14+02:00 tm: retransmission management functions exported to kemi framework

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2017